@bongos/core 1.24.79 → 1.24.81

package/modules/hall-ui/public/shell-game.js

@@ -9,10 +9,10 @@
 //
 // The mode is one localStorage key (`hall-game`), so it follows the browser across
 // every hall page, and one attribute, html[data-game="on"], for a sheet or script
-// that wants to read it. Leaving full screen in game mode (the button, Escape)
+// that wants to read it. Leaving full screen in game mode (the corner button)
 // brings the bars back for THAT page load only: the next page opens without them
 // again, and a page's own remembered choice is never overwritten. `?game=on` /
-// `?game=off` on any hall URL sets it by hand until the start screen does (R03).
+// `?game=off` on any hall URL sets it by hand; the start screen's Start sets it on (R03, below).
 // Loaded BEFORE shell.js on every hall page; a page without this file is simply
 // never in game mode.
 (function () {
@@ -41,10 +41,323 @@
     write('sessionStorage', HINT_KEY, '1');
     return true;
   }
+
+  // ---------- the start screen and the load screen (task 1005143, BONGOS-V3 R03) ----------
+  // A fresh sign-in opens on the start screen: Start, Options, Achievements, Extras, Quit over a
+  // still. Start turns game mode on and passes through the load screen, where the project city
+  // builds itself up week by week under a tip, and then the world is there. welcome-boot.js calls
+  // start() on Home (where a sign-in lands) and hands in the still; this file draws both screens.
+  // Rules are in modules/hall-ui/records/start-screen.md.
+  var MENU = [
+    { id: 'start', label: 'Start' },
+    { id: 'options', label: 'Options', href: '/settings' },   // the ONE options menu (task 1005144)
+    { id: 'achievements', label: 'Achievements', href: '/profile' },
+    { id: 'extras', label: 'Extras' },
+    { id: 'quit', label: 'Quit' },
+  ];
+  var EXTRAS = [
+    { label: 'The thinking sky', href: '/thinking' },
+    { label: 'The atlas', href: '/atlas' },
+    { label: 'The docs', href: '/docs' },
+  ];
+  var TIPS = [
+    'Escape opens the options menu, where every setting lives.',
+    'Every tower is a goal. It gains a floor each time work ships under it.',
+    'A crane marks a site someone worked on this week.',
+    'A salmon dot on a tower means something there is waiting on you.',
+    'Ctrl K, or Cmd K on a Mac, jumps to any page.',
+  ];
+  var TIP_KEY = 'hall-game-tip';
+  var CITY_READ = '/api/bongos/home/city?weeks=10';
+  var STEPS = 30, STEP_MS = 90;   // the history runs in about three seconds
+  var HOLD_MS = 1400;             // how long the still and the tip stand when there is no city to build
+  var LEAVE_MS = 500;             // the fade into the world (shell-game.css)
+  var NS = 'http://www.w3.org/2000/svg';
+
+  function tipAt(n) { return TIPS[((Number(n) || 0) % TIPS.length + TIPS.length) % TIPS.length]; }
+  // The weeks the load screen stops at, oldest first, ending exactly on now.
+  function historySteps(weeks, steps) {
+    var last = Math.max(0, (Number(weeks) || 0) - 1), n = Math.max(1, Number(steps) || 1), out = [];
+    for (var i = 0; i <= n; i++) out.push(Math.round((last * i / n) * 100) / 100);
+    return out;
+  }
+  function whenLabel(weeks, t) {
+    var ago = Math.round(Math.max(0, (Number(weeks) || 0) - 1) - t);
+    return ago <= 0 ? 'The city, now' : 'The city, ' + ago + (ago === 1 ? ' week ago' : ' weeks ago');
+  }
+  function esc(v) { return window.OTB.escapeHtml(v); }
+  function itemHtml(m) {
+    var inner = ' class="gs__item" data-gs="' + m.id + '"';
+    if (m.href) return '<li><a' + inner + ' href="' + esc(m.href) + '">' + esc(m.label) + '</a></li>';
+    return '<li><button type="button"' + inner + (m.id === 'extras' ? ' aria-expanded="false" aria-controls="gs-extras"' : '') + '>' + esc(m.label) + '</button></li>';
+  }
+  // The project's own logo where it has one (ADR 0358), else the shared mark, as the sidebar draws it.
+  function markHtml() {
+    var theme = (window.__BRANDING__ && window.__BRANDING__.theme) || {};
+    if (theme.logo) return '<img class="gs__mark" src="' + esc(theme.logo) + '" alt="" decoding="async">';
+    return '<svg class="gs__mark" viewBox="0 0 200 200" aria-hidden="true"><use href="/modules/ui-design/public/brand/mark.svg#mark"/></svg>';
+  }
+  // The Helm panel (task 1005192, ADR 0402): the mark and the name, the choices, one line at the foot.
+  function screenHtml(o) {
+    return '<div class="gs__art" aria-hidden="true">' + (o.art ? '<img class="gs__img" alt="" src="' + esc(o.art) + '" decoding="async">' : '') + '</div>' +
+      '<div class="gs__menu">' +
+        '<div class="gs__top">' +
+          '<div class="gs__head">' + markHtml() +
+            '<h2 class="gs__title" id="gs-title">' + esc(o.name || 'This project') + '</h2>' +
+          '</div>' +
+          '<div class="gs__list">' +
+            '<ul class="gs__items">' + MENU.map(itemHtml).join('') + '</ul>' +
+            '<ul class="gs__items gs__items--extras" id="gs-extras" hidden>' + EXTRAS.map(function (x) {
+              return '<li><a class="gs__item gs__item--extra" href="' + esc(x.href) + '">' + esc(x.label) + '</a></li>';
+            }).join('') + '</ul>' +
+          '</div>' +
+        '</div>' +
+        '<div class="gs__foot">' +
+          '<p class="gs__line" id="gs-line">' + esc(tipAt(read('localStorage', TIP_KEY))) + '</p>' +
+          '<p class="gs__note" id="gs-note" role="status" hidden></p>' +
+        '</div>' +
+      '</div>' +
+      '<div class="gs__load" id="gs-load" role="status" hidden>' +
+        '<p class="gs__when" id="gs-when" hidden></p>' +
+        '<ol class="gs__segs segs" id="gs-segs" aria-hidden="true" hidden></ol>' +
+        '<svg class="gs__city" id="gs-city" role="img" aria-label="The project city building up, week by week" hidden></svg>' +
+        '<p class="gs__tip"><b>Tip</b><span id="gs-tip"></span></p>' +
+      '</div>';
+  }
+  // One segment per week of the history: filled up to the week being shown. The words beside
+  // them (#gs-when) say the same thing, so the row is hidden from a screen reader.
+  // Counted the way whenLabel words it, so the row and the sentence never disagree.
+  function segsDone(weeks, t) {
+    var n = Math.max(0, Math.round(Number(weeks) || 0));
+    return Math.max(0, n - Math.round(Math.max(0, n - 1 - (Number(t) || 0))));
+  }
+  function drawSegs(weeks, t) {
+    var box = root && root.querySelector('#gs-segs'), n = Math.max(0, Math.round(Number(weeks) || 0));
+    if (!box || n < 2) return;
+    while (box.children.length < n) box.appendChild(document.createElement('li'));
+    var done = segsDone(n, t);
+    for (var i = 0; i < box.children.length; i++) box.children[i].className = i < done ? 'seg seg--done' : 'seg';
+    box.hidden = false;
+  }
+
+  var root = null, opts = null, timers = [], phase = null;
+  function later(ms, fn) { timers.push(setTimeout(fn, ms)); }
+  function stopTimers() { timers.forEach(clearTimeout); timers = []; }
+  function still() { return !!(window.matchMedia && window.matchMedia('(prefers-reduced-motion: reduce)').matches); }
+  function items() {
+    return Array.prototype.filter.call(root.querySelectorAll('.gs__item'), function (b) { return !b.closest('[hidden]'); });
+  }
+
+  function close() {
+    if (!root) return;
+    stopTimers();
+    document.removeEventListener('keydown', onKey, true);
+    if (root.parentNode) root.parentNode.removeChild(root);
+    root = null; phase = null;
+    document.documentElement.classList.remove('gs-open');
+    var done = opts && opts.done;
+    opts = null;
+    if (typeof done === 'function') done();
+  }
+  function leave() {
+    if (!root || phase === 'leaving') return;
+    phase = 'leaving';
+    stopTimers();
+    if (still()) { close(); return; }
+    root.classList.add('gs--leaving');
+    later(LEAVE_MS, close);
+  }
+
+  // ---- the load screen: the still, a tip, and the city building up through its history ----
+  function build(n) {
+    var e = document.createElementNS(NS, n.tag);
+    Object.keys(n.attrs).forEach(function (k) { e.setAttribute(k, String(n.attrs[k])); });
+    if (n.text != null) e.textContent = n.text;
+    n.kids.forEach(function (c) { e.appendChild(build(c)); });
+    return e;
+  }
+  function themeMode() {
+    var t = document.documentElement.dataset.theme;
+    if (t === 'light' || t === 'dark') return t;
+    return window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light';
+  }
+  function drawCity(model, t) {
+    var Draw = window.OTBHomeCityDraw, svg = root && root.querySelector('#gs-city'), when = root && root.querySelector('#gs-when');
+    if (!svg) return;
+    var out = Draw.citySvg(model, t, { mode: themeMode(), gov: window.GovCity || null });
+    svg.setAttribute('viewBox', out.viewBox);
+    while (svg.firstChild) svg.removeChild(svg.firstChild);
+    out.nodes.forEach(function (n) { svg.appendChild(build(n)); });
+    svg.removeAttribute('hidden');
+    when.textContent = whenLabel(model.W, t);
+    when.hidden = false;
+    drawSegs(model.W, t);
+  }
+  // One week after another, as state: each stop is a whole drawing, so nothing here animates.
+  function runHistory(model) {
+    if (!root || phase !== 'load') return;
+    stopTimers();
+    var stops = still() ? [model.W - 1] : historySteps(model.W, STEPS), i = 0;
+    (function step() {
+      if (!root) return;
+      drawCity(model, stops[i]);
+      i += 1;
+      if (i < stops.length) later(STEP_MS, step); else later(still() ? HOLD_MS : 700, leave);
+    })();
+  }
+  function readCity() {
+    var Draw = window.OTBHomeCityDraw;
+    if (!Draw || typeof fetch !== 'function') return;
+    fetch(CITY_READ, { credentials: 'same-origin' }).then(function (r) { return r.ok ? r.json() : null; }).then(function (data) {
+      var model = data && Draw.cityModel(data);
+      if (model && model.W && model.areas.length) runHistory(model);
+    }, function () { /* no city: the still and the tip stand, then the world */ });
+  }
+  function load() {
+    if (!root || phase !== 'menu') return;
+    phase = 'load';
+    set(true);
+    var n = Number(read('localStorage', TIP_KEY)) || 0;
+    write('localStorage', TIP_KEY, String(n + 1));
+    root.querySelector('#gs-tip').textContent = tipAt(n);
+    root.querySelector('.gs__menu').hidden = true;
+    root.querySelector('#gs-load').hidden = false;
+    root.classList.add('gs--load');
+    later(HOLD_MS, leave);   // runHistory replaces this once the city answers
+    readCity();
+  }
+
+  // Quit closes the tab. A browser only lets a script close a tab a script opened, so when the
+  // tab is still here a moment later the screen says so instead of doing nothing.
+  function quit() {
+    try { window.close(); } catch (_) { /* refused */ }
+    later(300, function () {
+      var note = root && root.querySelector('#gs-note');
+      if (!note) return;
+      note.textContent = 'Your browser kept this tab open. Close it to quit.';
+      note.hidden = false;
+    });
+  }
+  function toggleExtras(btn) {
+    var box = root.querySelector('#gs-extras'), open = box.hidden;
+    box.hidden = !open;
+    btn.setAttribute('aria-expanded', open ? 'true' : 'false');
+    if (open) box.querySelector('a').focus();
+  }
+  function onClick(e) {
+    var el = e.target.closest && e.target.closest('.gs__item');
+    if (!el || phase !== 'menu') return;
+    var id = el.getAttribute('data-gs');
+    if (id === 'start') load();
+    else if (id === 'extras') toggleExtras(el);
+    else if (id === 'quit') quit();
+  }
+  // The screen keeps every key while it is up: Escape folds Extras away and nothing else (the
+  // shell's Escape must not flip the bars underneath), the arrows and Tab stay inside the menu.
+  function onKey(e) {
+    if (!root) return;
+    if (e.key === 'Escape') {
+      e.preventDefault();
+      var box = root.querySelector('#gs-extras');
+      if (phase === 'menu' && !box.hidden) { var b = root.querySelector('[data-gs="extras"]'); toggleExtras(b); b.focus(); }
+      return;
+    }
+    if (phase !== 'menu') return;
+    var f = items(), at = f.indexOf(document.activeElement), step = 0;
+    if (e.key === 'ArrowDown') step = 1;
+    else if (e.key === 'ArrowUp') step = -1;
+    else if (e.key === 'Tab') step = e.shiftKey ? -1 : 1;
+    if (!step || !f.length) return;
+    e.preventDefault();
+    f[(at + step + f.length) % f.length].focus();
+  }
+
+  // Put the start screen up. `o`: { name, art, done } — the project's name, the still to stand
+  // behind both screens, and what to do once the world is showing. True when it is up.
+  function start(o) {
+    if (root || !document.body) return !!root;
+    opts = o || {};
+    phase = 'menu';
+    root = document.createElement('div');
+    root.className = 'gs';
+    root.id = 'game-start';
+    root.setAttribute('role', 'dialog');
+    root.setAttribute('aria-modal', 'true');
+    root.setAttribute('aria-labelledby', 'gs-title');
+    root.innerHTML = screenHtml(opts);
+    root.addEventListener('click', onClick);
+    document.addEventListener('keydown', onKey, true);
+    document.body.appendChild(root);
+    document.documentElement.classList.add('gs-open');
+    var first = root.querySelector('.gs__item');
+    if (first && first.focus) first.focus();
+    return true;
+  }
+
   try {
     var asked = new URLSearchParams(window.location.search || '').get('game');
     if (asked === 'on' || asked === 'off') write('localStorage', KEY, asked);
   } catch (_) { /* old engine: the stored value stands */ }
   stamp();
-  window.OTBShellGame = { on: on, set: set, hint: hint };
+
+  // ---------- the options menu (task 1005144, BONGOS-V3 R04, ADR 0401) ----------
+  // Every setting lives in ONE menu, the Settings page (options-menu.js). A screen
+  // that used to have its own page (My agents, Project settings, Modules, …) now
+  // opens INSIDE that menu, in a frame, with `?embed=1`. Such a page is EMBEDDED:
+  // html[data-embed="on"], no sidebar, top bar, foot or page head (style.css), no
+  // full-screen switch, a link to another page opens in the whole window, and an
+  // Escape nobody used goes to the menu. Only inside a frame: the same URL opened
+  // on its own is the page with its chrome (the server sends a plain visit of the
+  // old address to the menu, serve-internal.js).
+  var embedded = false;
+  try {
+    embedded = new URLSearchParams(window.location.search || '').get('embed') === '1'
+      && !!window.parent && window.parent !== window;
+  } catch (_) { embedded = false; }
+  if (embedded) {
+    document.documentElement.dataset.embed = 'on';
+    // The shell reads this before it draws the switch, so no button, no Escape-to-leave.
+    if (document.body && document.body.setAttribute) document.body.setAttribute('data-fullscreen-switch', 'off');
+  }
+  // The hall's address for the menu: '/settings' on the builders host, '/builders/settings' on the apex.
+  function menuPath() {
+    var p = String((window.location && window.location.pathname) || '');
+    return (p.indexOf('/builders/') === 0 || p === '/builders' ? '/builders' : '') + '/settings';
+  }
+  function inField(el) {
+    var tag = el && el.tagName ? String(el.tagName).toLowerCase() : '';
+    return tag === 'input' || tag === 'textarea' || tag === 'select' || !!(el && el.isContentEditable);
+  }
+  // ADR 0399 §2.4 row 6: in game mode, the last Escape — one no dialog, picker,
+  // palette, sheet or scene pop-up used — is the options menu's. It is judged after
+  // the dispatch (a page listener may sit later on the window), and it is marked
+  // used before the shell's own check runs, so the bars do not flash back first.
+  // On the menu itself it closes the menu; inside a frame it is the menu's too.
+  function onEscape(e) {
+    if (!e || e.key !== 'Escape' || e.defaultPrevented || inField(e.target)) return;
+    if (!embedded && !on()) return;
+    window.setTimeout(function () {
+      if (e.defaultPrevented) return;
+      try { e.preventDefault(); } catch (_) { /* already finished */ }
+      var host = embedded ? window.parent : window;
+      if (host && host.OTBOptions && typeof host.OTBOptions.escape === 'function') { host.OTBOptions.escape(); return; }
+      if (embedded) return;
+      var here = String(window.location.pathname || '') + String(window.location.search || '') + String(window.location.hash || '');
+      window.location.assign(menuPath() + '?from=' + encodeURIComponent(here));
+    }, 0);
+  }
+  if (window.addEventListener) window.addEventListener('keydown', onEscape);
+  // Inside the menu, a link to ANOTHER page leaves the menu for it; a link within the page stays.
+  if (embedded && document.addEventListener) {
+    document.addEventListener('click', function (e) {
+      var a = e.target && e.target.closest ? e.target.closest('a[href]') : null;
+      if (!a || a.getAttribute('target')) return;
+      try {
+        var to = new URL(a.getAttribute('href'), window.location.href);
+        if (to.origin !== window.location.origin || to.pathname !== window.location.pathname) a.setAttribute('target', '_top');
+      } catch (_) { /* a href the browser cannot read: leave it alone */ }
+    }, true);
+  }
+  window.OTBShellGame = { on: on, set: set, hint: hint, start: start, tipAt: tipAt, historySteps: historySteps, whenLabel: whenLabel, segsDone: segsDone, MENU: MENU, TIPS: TIPS,
+    embedded: function () { return embedded; }, menuPath: menuPath };
 })();

package/modules/hall-ui/public/shell.js

@@ -110,8 +110,6 @@
     // You
     accomplishments: '<path d="M6 2.5l1.6 4.2M12 2.5l-1.6 4.2"/><circle cx="9" cy="10.8" r="4.2"/><circle cx="9" cy="10.8" r="1.8"/>',
     profile: '<rect x="2.5" y="4" width="13" height="10" rx="1.5"/><circle cx="6.3" cy="8" r="1.6"/><path d="M4.1 12c.3-1.1 1.1-1.7 2.2-1.7s1.9.6 2.2 1.7"/><path d="M10.4 7.5h3M10.4 10.3h3"/>',
-    // task 1004685 (prototype): My agents — a helper's head on an antenna, not a person.
-    agents: '<rect x="4" y="6" width="10" height="8.5" rx="2.5"/><path d="M9 6V3.6"/><circle cx="9" cy="2.7" r="0.9"/><path d="M7 10.2v0.6M11 10.2v0.6"/><path d="M1.8 9v3M16.2 9v3"/>',
     // Community
     collab: '<path d="M2.5 4a1 1 0 0 1 1-1h7a1 1 0 0 1 1 1v4.5a1 1 0 0 1-1 1H6.5L4 11.5v-2h-.5a1 1 0 0 1-1-1V4Z"/><path d="M11.5 6.5h3a1 1 0 0 1 1 1V12a1 1 0 0 1-1 1H14v2l-2.5-2H8.5a1 1 0 0 1-1-1V9.5"/>',
     roster: '<circle cx="6.5" cy="6.3" r="2.3"/><path d="M2.5 15c.4-2.3 1.9-3.7 4-3.7s3.6 1.4 4 3.7"/><circle cx="12.5" cy="5.8" r="2"/><path d="M11.4 10.5c.4-.1.7-.2 1.1-.2 1.9 0 3.3 1.3 3.7 3.5"/>',
@@ -119,16 +117,13 @@
     primer: '<path d="M9 5C7.5 3.9 5.5 3.5 2.5 3.5v10c3 0 5 .4 6.5 1.5 1.5-1.1 3.5-1.5 6.5-1.5v-10c-3 0-5 .4-6.5 1.5Z"/><path d="M9 5v10"/>',
     commands: '<rect x="2.5" y="3.5" width="13" height="11" rx="1.5"/><path d="M5.5 7.3 7.7 9l-2.2 1.7M9.5 11.2h3"/>',
     atlas: '<circle cx="9" cy="9" r="6.5"/><path d="M2.5 9h13M9 2.5c1.7 1.8 2.6 4 2.6 6.5s-.9 4.7-2.6 6.5c-1.7-1.8-2.6-4-2.6-6.5S7.3 4.3 9 2.5Z"/>',
-    modules: '<rect x="2.5" y="2.5" width="5.5" height="5.5" rx="1"/><rect x="10" y="2.5" width="5.5" height="5.5" rx="1"/><rect x="2.5" y="10" width="5.5" height="5.5" rx="1"/><path d="M12.75 10.5v4.5M10.5 12.75h4.5"/>',
     apidocs: '<path d="M6.5 3C5 3 4.5 3.7 4.5 5v2c0 1-.6 2-1.5 2 .9 0 1.5 1 1.5 2v2c0 1.3.5 2 2 2M11.5 3c1.5 0 2 .7 2 2v2c0 1 .6 2 1.5 2-.9 0-1.5 1-1.5 2v2c0 1.3-.5 2-2 2"/>',
     // Government
     watch: '<path d="M1.8 9S4.5 4 9 4s7.2 5 7.2 5-2.7 5-7.2 5S1.8 9 1.8 9Z"/><circle cx="9" cy="9" r="2.2"/>',
     gate: '<path d="M9 2.5 15 5v4c0 3.5-2.4 6-6 7-3.6-1-6-3.5-6-7V5l6-2.5Z"/><path d="M6.5 9l1.8 1.8 3.4-3.6"/>',
     sessions: '<path d="M7 5h8M7 9h8M7 13h8"/><circle cx="3.8" cy="5" r=".7" fill="currentColor"/><circle cx="3.8" cy="9" r=".7" fill="currentColor"/><circle cx="3.8" cy="13" r=".7" fill="currentColor"/>',
-    settings: '<circle cx="9" cy="9" r="2.5"/><path d="M9 2.5v2m0 9v2M2.5 9h2m9 0h2M4.4 4.4l1.4 1.4m6.4 6.4 1.4 1.4m0-9.2-1.4 1.4M5.8 12.2l-1.4 1.4"/>',
     deploy: '<path d="M9 12V3M5.5 6.5 9 3l3.5 3.5M3 12.5v2a1 1 0 0 0 1 1h10a1 1 0 0 0 1-1v-2"/>',
     money: '<path d="M4 2.5h10v13l-1.7-1-1.6 1-1.7-1-1.7 1-1.6-1-1.7 1v-13Z"/><path d="M6.5 6h5M6.5 9h5M6.5 12h3"/>',
-    permissions: '<circle cx="6" cy="12" r="3.5"/><path d="M8.5 9.5 15 3M12.5 5.5l2 2M10.5 7.5l1.5 1.5"/>',
     // The governor city: a pediment over columns, the Governing mode's own glyph.
     city: '<path d="M2.5 7 9 3l6.5 4M4 7.5v6.5M7 7.5v6.5M11 7.5v6.5M14 7.5v6.5M2.5 15.5h13"/>',
     // the foot
@@ -302,9 +297,9 @@
       // /profile?id=N from the leaderboard); 'signed' just means "show this 'my
       // profile' shortcut once you're signed in".
       { id: 'profile', label: 'Profile', icon: 'profile', href: '/profile', gate: 'signed' },
-      // task 1004685 (prototype, board 6): MY AGENTS — how your own Claude works for you
-      // and which settings the project's laws lock. 'signed' is its page's real floor.
-      { id: 'my-agents', label: 'My agents', icon: 'agents', href: '/my-agents', gate: 'signed' },
+      // task 1005144 (ADR 0401): My agents, Project settings, Permissions and Modules
+      // left the sidebar — they are entries in the ONE options menu (the profile chip),
+      // and their old URLs open it (serve-internal.js RETIRED_TO_OPTIONS).
     ] },
     // task 1005071: the board's own rooms get a head of their own. Gated on the SAME
     // atom as both items (perm:, which floors below any rank), so the head can never
@@ -360,9 +355,6 @@
       // surface, so this group's gate and audience are unchanged.
       { id: 'watch', label: 'Watch', icon: 'watch', href: '/watch', gate: 'government', position: true },
       // task 1005049: Sessions and Autobongos (/gate) are tabs on Watch; both URLs redirect there.
-      // The project's own fundamentals (task 1003280, goal 1000072). Mirrors the
-      // server's requireGovernmentPage floor; cosmetic only, as every item here is.
-      { id: 'project-settings', label: 'Project settings', icon: 'settings', href: '/project-settings', gate: 'government', position: true },
       // task 1005047 (owner decision 2026-11-03, idea 1001312): the owner's one money page —
       // spend and payouts (once on Project settings), the treasury (once the Economy page)
       // and the hosting bills (once 'Fleet costs', /fleet, which now redirects to its
@@ -379,17 +371,7 @@
       // is the platform hall's page alone, and every other hall takes its update from
       // Settings → Software update, whose Update button carries the hub hand-off.
       { id: 'deploy', label: 'Deploy', icon: 'deploy', href: '/deploy', gate: 'archon', module: 'provisioning render-deploy', position: true },
-      // task 1005045: the owner's Market Watch settings (task 1004938) are an owner-only tab on
-      // /market-watch now, so the sidebar says "Market Watch" once (owner decision 2026-11-03).
-      // BV1.R113: the roles-and-permissions tab (ADR 0151). The one genuinely
-      // Archon-only item the 'government' gate comment anticipated — cosmetic
-      // only. The wall is the `government.manage` atom checked on each of the
-      // tab's nine data routes (route-rank-check.js); the page SHELL itself is
-      // metic+, because R16 made /government three rooms and only this one is
-      // the archon surface.
-      { id: 'government', label: 'Permissions', icon: 'permissions', href: '/government', gate: 'archon', position: true }  // NOT 'Ranks': the ladder is explained in the Primer, and a nav item
-      //   reading 'Ranks' beside it is the confusion this rename exists to remove. This tab
-      //   is where a rank's permissions are granted, so it says what it does.,
+      // Project settings and Permissions left this group in task 1005144: options menu entries.
     ] },
     // task 1005071: 'Docs' → 'Help', and every craft shows it (craft-mode.js ALWAYS_TABS).
     { group: 'Help', gate: 'signed', items: [
@@ -409,7 +391,6 @@
       // both reads behind it are sign-in gated, so 'signed' is the real floor here.
       { id: 'commands', label: 'Commands', icon: 'commands', href: '/commands', gate: 'signed' },
       { id: 'atlas', label: 'Repo Atlas', icon: 'atlas', href: '/atlas', gate: 'member' },
-      { id: 'modules', label: 'Modules', icon: 'modules', href: '/modules', gate: 'member' },
       // The rendered OpenAPI reference lives on the APEX (/docs), not this builders
       // subdomain — external so the rewrite shim doesn't turn it into /builders/docs.
       { id: 'apidocs', label: 'API docs', icon: 'apidocs', href: '/docs', gate: 'signed', external: true },
@@ -516,7 +497,7 @@
         // task 1831: the profile chip IS the Settings link — one spot, no separate
         // nav-item. It's an <a> so keyboard focus + Enter work for free; visibility
         // stays 'signed'-gated via applyAccess (shown only when authed + filled).
-        '<a class="shell-user" id="shell-user" href="/settings" title="Settings" aria-label="Settings" hidden>' +
+        '<a class="shell-user" id="shell-user" href="/settings" title="Options" aria-label="Options" hidden>' +
           '<span class="shell-user__avatar" id="shell-user-avatar" aria-hidden="true"></span>' +
           '<span class="shell-user__meta"><span class="shell-user__name" id="shell-user-name"></span>' +
           '<span class="shell-user__rank" id="shell-user-rank"></span></span>' +
@@ -557,7 +538,6 @@
       '</button>' +
       (CRAFT ? CRAFT.switchHtml() : '') +
       '<button class="zoom-toggle" id="zoom-toggle" type="button" aria-label="Text size"></button>' +
-      '<button class="theme-toggle" id="theme-toggle" type="button" aria-label="Switch theme"></button>' +
       // task 1004327: the full-screen switch, LAST so it sits in the corner the
       // collapsed bar keeps in full screen — the one control that stays put.
       // task 1004430: on every page now, unless the page opts out.
@@ -665,44 +645,21 @@
     window.setTimeout(function () { if (!e.defaultPrevented && isFullscreen()) setFullscreen(false); }, 0);
   }
 
-  // ---------- theme (light / dark) ----------
-  // The pack's :root override carries only light values; the dark neutrals live
-  // in style.css under html[data-theme="dark"] (higher specificity than :root,
-  // so they win over the pack while the instance accent survives). Stored
-  // preference beats the OS setting; no stored preference follows it live.
-  var THEME_KEY = 'hall-theme';
-  var themeMedia = window.matchMedia ? window.matchMedia('(prefers-color-scheme: dark)') : null;
-
-  function storedTheme() {
-    try { var v = window.localStorage.getItem(THEME_KEY); return v === 'dark' || v === 'light' ? v : null; } catch (_) { return null; }
-  }
-  function effectiveTheme() {
-    return storedTheme() || (themeMedia && themeMedia.matches ? 'dark' : 'light');
-  }
+  // ---------- theme: the hall is dark only (task 1005192, ADR 0402) ----------
+  // Helm is the hall's one look, so there is no light/dark switch and no stored
+  // choice: the server stamps html[data-theme="dark"] on every hall page
+  // (src/hall-helm.js) and this sets it again, for a page read without that stamp.
+  // The old 'hall-theme' preference is never read. Scripts that only READ the
+  // attribute (the city, the sky, the atlas) keep working: they always read dark.
   function applyTheme() {
-    var t = effectiveTheme();
-    document.documentElement.dataset.theme = t;
-    var btn = document.getElementById('theme-toggle');
-    if (btn) {
-      var toDark = t !== 'dark';
-      btn.setAttribute('aria-label', toDark ? 'Switch to dark theme' : 'Switch to light theme');
-      btn.title = btn.getAttribute('aria-label');
-      btn.innerHTML = toDark
-        ? '<svg viewBox="0 0 18 18" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" aria-hidden="true"><path d="M14.5 10.8A6 6 0 0 1 7.2 3.5a6 6 0 1 0 7.3 7.3Z"/></svg>'
-        : '<svg viewBox="0 0 18 18" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" aria-hidden="true"><circle cx="9" cy="9" r="3.5"/><path d="M9 1.5v2m0 11v2M1.5 9h2m11 0h2M3.7 3.7l1.4 1.4m7.8 7.8 1.4 1.4m0-10.6-1.4 1.4M5.1 12.9l-1.4 1.4"/></svg>';
-    }
-  }
-  function toggleTheme() {
-    var next = effectiveTheme() === 'dark' ? 'light' : 'dark';
-    try { window.localStorage.setItem(THEME_KEY, next); } catch (_) { /* private mode */ }
-    applyTheme();
+    document.documentElement.dataset.theme = 'dark';
   }
 
   // ---------- zoom (accessibility: enlarge the whole page) ----------
   // task 1475 (idea 280): a one-click "make everything bigger" control for
   // readability. Cycles 100% -> 125% -> 150% -> 100% via CSS `zoom` on <html>,
   // which enlarges px AND rem sizes uniformly (a font-size bump would miss the
-  // hall's many px values). Persisted per-browser like the theme preference.
+  // hall's many px values). Persisted per-browser.
   var ZOOM_KEY = 'hall-zoom';
   var ZOOM_STEPS = [1, 1.25, 1.5];
   function storedZoom() {
@@ -1196,7 +1153,7 @@
     maybeRenderCoreUpdate();
     // task 1004492: a builder with no mode yet this session is asked once — unless Home's welcome (task 1004785, welcome-boot.js) greets the day's first visit instead; it marks the picker asked.
     // task 1005076: neither is drawn over the setup screen; setup comes first.
-    if (!holdForSetup(state && state.builder) && !(window.OTBWelcome && window.OTBWelcome.onAccess(access, state && state.builder)) && CRAFT) CRAFT.onAccess(access, state && state.builder);
+    if (!holdForSetup(state && state.builder) && !(CRAFT && CRAFT.characterGate && CRAFT.characterGate(access, state)) && !(window.OTBWelcome && window.OTBWelcome.onAccess(access, state && state.builder)) && CRAFT) CRAFT.onAccess(access, state && state.builder);
     var signin = document.getElementById('shell-signin');
     if (signin) signin.hidden = access.authed !== false;
     var user = document.getElementById('shell-user');
@@ -1345,8 +1302,6 @@
       if (document.documentElement.classList.contains('drawer-open')) closeDrawer();
       else openDrawer();
     });
-    var theme = document.getElementById('theme-toggle');
-    if (theme) theme.addEventListener('click', toggleTheme);
     var zoom = document.getElementById('zoom-toggle');
     if (zoom) zoom.addEventListener('click', cycleZoom);
     var full = document.getElementById('fullscreen-toggle');
@@ -1354,9 +1309,6 @@
       full.addEventListener('click', function () { setFullscreen(!isFullscreen()); });
       window.addEventListener('keydown', onFullscreenKey);
     }
-    if (themeMedia && themeMedia.addEventListener) {
-      themeMedia.addEventListener('change', function () { if (!storedTheme()) applyTheme(); });
-    }
     var scrim = document.getElementById('app-scrim');
     if (scrim) scrim.addEventListener('click', closeDrawer);
     var sidebar = document.getElementById('app-sidebar');
@@ -1443,7 +1395,7 @@
         positions: me.positions || null,
         // task 1005076: whether setup is complete; incomplete shows setup-gate.js.
         setup: (me.onboarding && me.onboarding.setup) || null,
-        builder: me.builder,
+        builder: me.builder, character: me.character, // task 1005147: the character held (null: pick one)
       });
     }).catch(function () { /* cosmetic only */ });
   }
@@ -1488,9 +1440,6 @@
     closeDrawer: closeDrawer,
     isFullscreen: isFullscreen,
     setFullscreen: setFullscreen,
-    // task 1004544: a page with its own light/dark switch (the governor city
-    // and street) repaints the top bar's after writing 'hall-theme'.
-    applyTheme: applyTheme,
     // task 1004477: a page that renders an exit after boot asks the shell to fill it.
     fillExits: TRAIL.fillExits,
     positions: function () { return access.positions; }, // task 1004713: seats held (null while unknown)

package/modules/hall-ui/public/sky-interaction.js

@@ -147,4 +147,11 @@
   ].filter(([cls]) => cls !== 'unseen' || S.lenses.includes('all')).map(([cls, name, what]) => `<button type="button" class="obj" title="${esc(what)}"><span class="g"><span class="mk ${cls}"></span></span>${esc(name)}</button>`).join('');
 
   Object.assign(SKY, { card, menu, glyphHtml, ideaTitle, sizeWords, showCard, showMenu, hideMenu, pick, setLens, togglePill, updateStats, altText, TAU, hash });
+
+  // task 1005148: the sky as the visor's scene (ADR 0399 §2.2). The visor owns no camera:
+  // "Back to centre" is the camera's own fitAll, and the keys listed are the ones bound above.
+  window.__visorScene = { name: 'sky', place: '', // the sky's own heading names the place
+    actions: [{ label: 'Back to centre', key: '0', run: () => SKY.fitAll() }],
+    keys: [{ label: 'Look around', key: 'drag' }, { label: 'List view', key: 'L' }, { label: 'Search', key: '/' }, { label: 'Take the tour', key: '?' }] };
+  if (window.OTBVisor) window.OTBVisor.scene(window.__visorScene);
 })();

package/modules/hall-ui/public/speciality-tools.js

@@ -621,8 +621,7 @@
                   <span>Role it sits under</span>
                   <select name="discipline" required>
                     <option value="">Pick one…</option>
-                    <option value="engineer">Engineer</option>
-                    <option value="ideator">Ideator</option>
+                    <option value="artisan">Artisan</option>
                     <option value="artist">Artist</option>
                     <option value="ui">UI design</option>
                   </select>

package/modules/hall-ui/public/street-card.states.json

@@ -1,6 +1,7 @@
 {
   "_": "THE MATTER CARD THAT ACTS (task 1004528, goal 1000125) on the street page, through modules/ui-design/kit/render.js. Kept beside street.states.json rather than inside it, so the street and its interiors (task 1004526) and the card each own their states. The populated card needs the hall-preview harness, whose government__docket.json puts the review-seat amendment on the board source (board:47) and whose government__board__items.json carries its ballot (item 47), with a canned answer for a vote:\n\n  node scripts/hall-preview/server.js --port 4625 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/street-card.states.json --base-in http://localhost:4625 --base-out http://localhost:4625\n\nTask 1004566 adds a card per kind the docket carries (blocker, red-team report, core update, module re-check, a Full Idea and the review queue), each compact and with \"more\" open; the harness fixture carries them. Against the kit stub there is no docket and no pin, so these states are for the harness.",
   "page": "/builders/street",
+  "modes": ["dark"],
   "_storage": "The hall asks a first-visit question (the session mode picker, craft-mode.js) over every page; seeding \"already asked\" renders the page a returning builder sees (task 1005080).",
   "storage": { "session": { "hall-craft-asked": "1" } },
   "surface": "hall-ui",

package/modules/hall-ui/public/street-inside.js

@@ -81,7 +81,6 @@
     let top = h;
     if (craft === 'artist') { const bh = Math.round(h * 0.8); S.box(out, T, x, 0, w, bh, T.work, { d: 6, win: true, lit: lit }); S.sawtooth(out, x, -bh, w, 3, 12, T.roof, T.glass); top = bh + 12; }
     else if (craft === 'ui') { S.box(out, T, x, 0, w, h, T.glass, { d: 6, grid: 3 }); S.box(out, T, x - 2, 0, w + 4, 4, T.roof, { d: 6, z: h }); top = h + 4; }
-    else if (craft === 'ideator') { S.box(out, T, x, 0, w, 22, T.work, { d: 6, door: true }); S.gable(out, x, -22, w, 14, T.roof); top = 36; }
     else S.box(out, T, x, 0, w, h, T.work, { d: 6, win: true, lit: lit });
     if (!lit) {
       const fx = x + w / 2;
@@ -410,7 +409,7 @@
         stageEdge: p.draw === 'awaiting a tester' ? 'rgba(251,149,105,0.6)' : T.ruleStrong,
       })),
       legend: [
-        { key: 'a', text: 'Shape is the craft: tower for engineer, studio roof for artist, glass front for UI, a small pavilion for ideator.' },
+        { key: 'a', text: 'Shape is the craft: tower for artisan, studio roof for artist, glass front for UI.' },
         { key: 'b', text: 'Stage is the status: staked plot, slab, scaffold, built, then lit once shipped. A flag means it waits on a check.' },
       ],
     };
@@ -670,7 +669,7 @@
   }
 
   // ---------- the real districts ----------
-  const CRAFTS = Object.freeze(['engineer', 'artist', 'ui', 'ideator']);
+  const CRAFTS = Object.freeze(['artisan', 'artist', 'ui']);
   // A task's status as the prototype's construction stage: [drawing stage, pill words].
   const STAGES = Object.freeze({
     shipped: ['shipped', 'shipped'], confirmed: ['graded · landing', 'graded · landing'], completed: ['being graded', 'being graded'],
@@ -699,7 +698,7 @@
     const shown = mine.slice().sort((a, b) => rank(a) - rank(b) || recent(a) - recent(b) || Number(a.id) - Number(b.id)).slice(0, MAX_ITEMS)
       .sort((a, b) => PIPELINE.indexOf(a.status) - PIPELINE.indexOf(b.status) || Number(a.id) - Number(b.id));
     const items = shown.map((t) => {
-      const craft = CRAFTS.indexOf(t.discipline) >= 0 ? t.discipline : 'engineer';
+      const craft = CRAFTS.indexOf(t.discipline) >= 0 ? t.discipline : 'artisan';
       const st = STAGES[t.status];
       const built = ['ready', 'backlog'].indexOf(st[0]) < 0;
       return [String(t.title || 'task ' + t.id), String(t.kind || 'task'), craft, st[0], built ? taskHeight(t) : 0, st[1], '/builders/task/' + encodeURIComponent(t.id)];

package/modules/hall-ui/public/street.css

@@ -128,8 +128,6 @@ html[data-fullscreen="on"] .street-top { padding-right: 184px; }
 .street-hud__dot--hot { background: var(--accent); }
 .street-hud__dot--moving { width: 6px; height: 6px; border: 0; background: var(--ink); }
 .street-hud__n { font-size: 24px; font-weight: 300; font-variant-numeric: tabular-nums; }
-.street-mode { margin-left: 36px; flex: none; background: none; border: 1px solid var(--street-rule-strong); border-radius: 999px; height: 36px; padding: 0 14px; display: flex; align-items: center; gap: 8px; cursor: pointer; color: var(--ink); font-family: var(--font-body); font-size: 13px; text-transform: lowercase; }
-.street-mode svg { display: block; stroke-width: 1.4; }
 
 /* the street band: the prototype's 1440-wide artboard, scaled by street.js */
 /* The living street's parallax (task 1004685) is Keith Clark's, sideways and
@@ -309,20 +307,18 @@ html[data-fullscreen="on"] .street-top { padding-right: 184px; }
 .street-card__lines li { padding: 8px 0; border-top: 1px solid var(--street-rule); font-size: 14px; line-height: 1.4; }
 .street-card__result { margin: 0; font-size: 15px; line-height: 1.45; }
 
-.street-mark:focus-visible, .street-mode:focus-visible, .street-pin:focus-visible, .street-door:focus-visible, .street-sign:focus-visible, .street-card__close:focus-visible { outline: 2px solid var(--accent); outline-offset: 3px; }
+.street-mark:focus-visible, .street-pin:focus-visible, .street-door:focus-visible, .street-sign:focus-visible, .street-card__close:focus-visible { outline: 2px solid var(--accent); outline-offset: 3px; }
 
 /* narrower: the strip tightens, then wraps; the readings scroll sideways */
 @media (max-width: 1180px) {
   .street-hud { gap: 20px; }
   .street-hud__n { font-size: 20px; }
-  .street-mode { margin-left: 20px; }
 }
 /* narrow: two rows inside the 80 px top-bar floor, the wordmark and the switch
    on the first, the three figures on the second as their own sideways strip */
 @media (max-width: 900px) {
   .street-top { height: auto; max-height: 80px; display: grid; grid-template-columns: minmax(0, 1fr) auto; grid-template-areas: "brand mode" "hud hud"; row-gap: 2px; padding: 5px 16px; }
   .street-top__brand { grid-area: brand; }
-  .street-mode { grid-area: mode; margin-left: 0; height: 34px; }
   .street-hud { grid-area: hud; margin-left: 0; gap: 18px; min-width: 0; overflow-x: auto; overflow-y: hidden; white-space: nowrap; height: 30px; }
   .street-hud__item { gap: 6px; flex: none; }
   .street-hud .street-label { font-size: 11px; }