@bongos/core 1.24.79 → 1.24.81

package/modules/hall-ui/public/craft-mode.js

@@ -1,7 +1,8 @@
 // craft-mode.js — the hall's craft mode (task 1004492, goal 1000095 WA6).
 //
 // On entering the hall (once per browser session) a picker asks "What are you
-// doing now?": Building, Artistry, Ideating or Governing. The
+// doing now?": Artisan, Artist or Patron (task 1005141; old saved modes are
+// read as today's — LEGACY_MODES). The
 // answer is ONE attribute, html[data-craft="<mode>"], that every hall page can
 // read, and a switch in the top bar changes it at any time without a reload.
 // Each change also fires `otb:craft` on document ({ detail: { mode } }).
@@ -28,10 +29,10 @@
   'use strict';
 
   var ICONS = {
-    building: '<path d="M2 13.5h12M3.5 13.5V8.5h4v5M7.5 13.5V4.5h5v9"/>',
-    artistry: '<path d="M8 2a6 6 0 1 0 0 12c.9 0 1.4-.6 1.4-1.3 0-.8-.6-1-.6-1.7 0-.6.5-1 1.2-1h1.6A2.4 2.4 0 0 0 14 7.6C14 4.5 11.3 2 8 2Z"/><path d="M5 6.2h.01M7.6 4.6h.01M10.4 5.2h.01M4.6 9h.01" stroke-width="2.2"/>',
+    artisan: '<path d="M2 13.5h12M3.5 13.5V8.5h4v5M7.5 13.5V4.5h5v9"/>',
+    artist: '<path d="M8 2a6 6 0 1 0 0 12c.9 0 1.4-.6 1.4-1.3 0-.8-.6-1-.6-1.7 0-.6.5-1 1.2-1h1.6A2.4 2.4 0 0 0 14 7.6C14 4.5 11.3 2 8 2Z"/><path d="M5 6.2h.01M7.6 4.6h.01M10.4 5.2h.01M4.6 9h.01" stroke-width="2.2"/>',
     ideating: '<path d="M6 12.5h4M6.6 14.5h2.8M8 1.8a4.2 4.2 0 0 0-2.6 7.5c.6.5 1 1.2 1 2h3.2c0-.8.4-1.5 1-2A4.2 4.2 0 0 0 8 1.8Z"/>',
-    governing: '<path d="M2 6 8 2.5 14 6M3.5 6.5v6M6.5 6.5v6M9.5 6.5v6M12.5 6.5v6M2 13.5h12"/>',
+    patron: '<path d="M2 6 8 2.5 14 6M3.5 6.5v6M6.5 6.5v6M9.5 6.5v6M12.5 6.5v6M2 13.5h12"/>',
     brush: '<path d="M13.6 2.4 7.4 8.6"/><path d="M7.4 8.6c-1.3-.7-3-.1-3.4 1.5-.3 1.3-.8 2.2-1.9 2.9 2.4.7 4.6.1 5.6-1.4.6-.9.5-2.1-.3-3Z"/>',
     note: '<path d="M9.5 2.5h-6v11h9v-6"/><path d="M5.5 8h5M5.5 10.5h3.5"/><path d="M12.5 1.5v4M10.5 3.5h4"/>',
     modes: '<rect x="2.5" y="2.5" width="4.5" height="4.5" rx="1"/><rect x="9" y="2.5" width="4.5" height="4.5" rx="1"/><rect x="2.5" y="9" width="4.5" height="4.5" rx="1"/><rect x="9" y="9" width="4.5" height="4.5" rx="1"/>',
@@ -39,11 +40,15 @@
   // The four crafts. `short` is the switch's label; `line` is the
   // picker's one sentence — what you do in the mode, never a feature not built yet.
   var MODES = [
-    { id: 'building', label: 'Building', short: 'Building', line: 'Claim tasks and ship code.' },
-    { id: 'artistry', label: 'Artistry', short: 'Artistry', line: 'Review how pages look and read.' },
-    { id: 'ideating', label: 'Ideating', short: 'Ideating', line: 'Turn thoughts into ideas.' },
-    { id: 'governing', label: 'Governing', short: 'Governing', line: 'Decide, approve and keep it healthy.' },
+    { id: 'artisan', label: 'Artisan', short: 'Artisan', line: 'Claim tasks and ship code.' },
+    { id: 'artist', label: 'Artist', short: 'Artist', line: 'Shape how pages look and read, and turn thoughts into ideas.' },
+    { id: 'patron', label: 'Patron', short: 'Patron', line: 'Watch, propose, and with a seat decide.' },
   ];
+  // The game's three characters (task 1005141, BONGOS-V3): Building became Artisan,
+  // Artistry and Ideating became Artist, Governing became Patron. A mode stored
+  // under its old id is read as the new one (LEGACY_MODES in valid()), so nobody
+  // loses their choice to the rename.
+  var LEGACY_MODES = { building: 'artisan', artistry: 'artist', ideating: 'artist', governing: 'patron' };
   var IDS = MODES.map(function (m) { return m.id; });
 
   // ---------- GOVERNING IS A SEAT (task 1004685, the living-city prototype) ----------
@@ -55,15 +60,21 @@
   // so a hall that cannot read the seats is unchanged. Cosmetic, like the mode itself.
   var seat;
   function seatName() { return typeof seat === 'string' ? seat : null; }
-  function offered(mode) { return mode !== 'governing' || seat !== null; }
-  function labelOf(m) { return m.id === 'governing' && seatName() ? seatName() : m.label; }
-  function lineOf(m) { return m.id === 'governing' && seatName() ? 'Your seat. ' + m.line : m.line; }
+  // A builder who holds a character (task 1005147) is offered that one alone: the
+  // switch, the session picker and the welcome's role choices all read offered(), so
+  // none of them can wear another. Changing character is signing out (CHARACTER below).
+  function offered(mode) {
+    if (typeof account === 'string' && mode !== account) return false;
+    return mode !== 'patron' || seat !== null;
+  }
+  function labelOf(m) { return m.id === 'patron' && seatName() ? seatName() : m.label; }
+  function lineOf(m) { return m.id === 'patron' && seatName() ? 'Your seat. ' + m.line : m.line; }
   function paintSeat() {
     var q = document.querySelector ? function (s) { return document.querySelector(s); } : function () { return null; };
-    var opt = q('#craft-switch [data-craft-opt="governing"]');
-    var gov = MODES[IDS.indexOf('governing')];
+    var opt = q('#craft-switch [data-craft-opt="patron"]');
+    var gov = MODES[IDS.indexOf('patron')];
     if (opt) {
-      if (offered('governing')) opt.removeAttribute('hidden'); else opt.setAttribute('hidden', '');
+      if (offered('patron')) opt.removeAttribute('hidden'); else opt.setAttribute('hidden', '');
       opt.setAttribute('title', labelOf(gov) + ' — ' + lineOf(gov));
       var lab = opt.querySelector && opt.querySelector('.craft-switch__label');
       if (lab) lab.textContent = labelOf(gov);
@@ -73,7 +84,7 @@
       var keep = picker.querySelector('[data-craft-again]');
       var again = !keep || keep.checked;
       var inside = picker.contains && picker.contains(document.activeElement);
-      picker.innerHTML = pickerHtml(read());
+      picker.innerHTML = creating ? createHtml(creating) : pickerHtml(read());
       var box = picker.querySelector('[data-craft-again]');
       if (box) box.checked = again;
       var pre = inside && (picker.querySelector('.craft-door--pre') || picker.querySelector('[data-craft-close]'));
@@ -81,11 +92,11 @@
     }
   }
   function setPositions(p) {
-    seat = !p || p.known !== true ? undefined : (p.has_position ? (p.title || 'Governing') : null);
-    if (seat === null && stored() === 'governing') {
+    seat = !p || p.known !== true ? undefined : (p.has_position ? (p.title || 'Patron') : null);
+    if (seat === null && stored() === 'patron') {
       drop('sessionStorage', MODE_KEY);
-      if (get('localStorage', KEEP_KEY) === 'governing') drop('localStorage', KEEP_KEY);
-      if (document.documentElement && document.documentElement.dataset.craft === 'governing') apply(null);
+      if (get('localStorage', KEEP_KEY) === 'patron') drop('localStorage', KEEP_KEY);
+      if (document.documentElement && document.documentElement.dataset.craft === 'patron') apply(null);
     }
     paintSeat();
   }
@@ -101,25 +112,25 @@
   // every craft has agents, and board 6 pairs it with the city in every mode.
   // task 1005071 (owner, 2026-11-04): Help (the old Docs group) joins ALWAYS — the
   // Primer is the newcomer's way in, and only Building could see it.
-  var ALWAYS_TABS = ['roster', 'collab', 'profile', 'my-agents',
-    'primer', 'commands', 'atlas', 'modules', 'apidocs'];
+  // task 1005144: My agents and Modules are options menu entries now, not tabs.
+  var ALWAYS_TABS = ['roster', 'collab', 'profile',
+    'primer', 'commands', 'atlas', 'apidocs'];
   // No mode lists 'home': the craft plate under the brand is the Home button in
   // every mode (task 1005065), so a Home tab beside it is a second home icon
   // (task 1005070). With no mode the plate is absent and the Home tab shows.
   var MODE_TABS = {
-    building: ['goals', 'goal-map', 'work', 'blockers', 'thinking', 'studio',
+    artisan: ['goals', 'goal-map', 'work', 'blockers', 'thinking', 'studio',
       'market-watch'],
-    artistry: ['studio', 'goals', 'thinking'],
-    ideating: ['goal-map', 'thinking', 'goals', 'market-watch'],
-    governing: ['city', 'blockers', 'board-room',
-      'watch', 'project-settings', 'money', 'deploy', 'government'],
+    artist: ['studio', 'goals', 'thinking', 'goal-map', 'market-watch'],
+    patron: ['city', 'blockers', 'board-room',
+      'watch', 'money', 'deploy'],
   };
   // A mode can lead with ONE tab and fold the rest of its own under a dropdown
   // (owner, 2026-10-08: the city is Governing's tab, everything else under it).
   // The folded items are MOVED into the dropdown, never copied, so the ids, the
   // gate attributes and the active mark the shell set all travel with them; a
   // placeholder keeps each one's place so leaving the mode puts it back exactly.
-  var MODE_LEAD = { governing: { lead: 'city', label: 'More governing' } };
+  var MODE_LEAD = { patron: { lead: 'city', label: 'More' } };
   var FOLD_ID = 'craft-fold';
   // The tab ids a mode shows, or null for every tab.
   function tabsFor(mode) {
@@ -224,7 +235,7 @@
   // in both crafts' lists) and a page no craft owns (a task, an idea) stay put; so
   // does Home, which redraws itself in place. The street has no nav item, so it is
   // named here as Governing's. Tests swap the hop for a recorder (OTBCraftHop).
-  var OWN_PAGES = { governing: ['street'] };
+  var OWN_PAGES = { patron: ['street'] };
   function pageKeys() {
     var keys = [];
     var nav = document.getElementById('app-sidebar');
@@ -254,7 +265,7 @@
     return false;
   }
   function homeHref(mode) {
-    var street = mode === 'governing' && window.GovCity && window.GovCity.STREET_HREF;
+    var street = mode === 'patron' && window.GovCity && window.GovCity.STREET_HREF;
     return street || '/';
   }
   function goHome(mode) {
@@ -269,11 +280,11 @@
   // draw — the mode's words beside the page title, and its door's scene framed
   // under the brand (artHtml, the picker's own art, so the two never drift).
   // Building and no mode have no entry here and wear nothing.
-  var LOOKS = { artistry: 'the studio · night', ideating: 'the sky', governing: 'the city' };
+  var LOOKS = { artist: 'the studio · night', patron: 'the city' };
   // The plate is the Home button in every mode (owner, 2026-11-04, task 1005065): the
   // mode's scene with a home mark over it. Building wears no look, so its plate shows
   // the city, the scene its Home is.
-  var PLATE_ART = { building: 'governing', artistry: 'artistry', ideating: 'ideating', governing: 'governing' };
+  var PLATE_ART = { artisan: 'patron', artist: 'artist', patron: 'patron' };
   var HOME_MARK = '<span class="craft-plate__home" aria-hidden="true"><svg viewBox="0 0 18 18" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linejoin="round">' +
     '<path d="M3 8.5 9 3l6 5.5V15a1 1 0 0 1-1 1h-3.5v-4h-3v4H4a1 1 0 0 1-1-1V8.5Z"/></svg></span>';
   function remove(el) { if (el && el.parentNode) el.parentNode.removeChild(el); }
@@ -373,7 +384,7 @@
   }
   function applyTallies(mode) {
     var box = document.getElementById('craft-tallies');
-    if (mode !== 'governing' || !tallyPage()) { remove(box); return; }
+    if (mode !== 'patron' || !tallyPage()) { remove(box); return; }
     var mark = document.getElementById('craft-eyebrow');
     if (!box && mark && mark.parentNode) {
       box = document.createElement('span');
@@ -385,7 +396,7 @@
     if (!box) return;
     askTallies().then(function (t) {
       var live = document.getElementById('craft-tallies');
-      if (!live || document.documentElement.dataset.craft !== 'governing') return;
+      if (!live || document.documentElement.dataset.craft !== 'patron') return;
       var html = tallyHtml(t);
       live.innerHTML = html;
       if (html) live.removeAttribute('hidden'); else live.setAttribute('hidden', '');
@@ -401,17 +412,16 @@
   // (same ?v as this file) and calls its open(). Cosmetic, like the mode: the
   // routes behind a tool hold its walls (ADR 0016).
   var TOOLS = {
-    artistry: [
+    artist: [
       // Named "Artist review" since task 1004499: the public site's button
       // (public-landing assets/artist-review.js) opens this same panel.
       // `docked` (task 1004771): no top-bar button. The panel itself sits on
       // the right edge behind a small tab, and carries the review-mode choice.
-      { id: 'palette', icon: 'artistry', short: 'Review', label: 'Artist review: write feedback on this page', script: 'page-notes.js', api: 'OTBPageNotes', docked: true },
+      { id: 'palette', icon: 'artist', short: 'Review', label: 'Artist review: write feedback on this page', script: 'page-notes.js', api: 'OTBPageNotes', docked: true },
       // Task 1004497: this page's words, edited where they stand as a proposed wording change.
       { id: 'paintbrush', icon: 'brush', short: 'Edit words', label: 'Edit this page\'s words', script: 'paintbrush.js', api: 'OTBPaintbrush' },
-    ],
-    // Task 1004498: the ideator's notes about this page, split into ideas (lightbulb.js).
-    ideating: [
+      // Task 1004498: notes about this page, split into ideas (lightbulb.js) — the
+      // ideator's tool, the artist's since the two crafts folded (task 1005141).
       { id: 'lightbulb', icon: 'note', short: 'Ideas', label: 'Write ideas about this page', script: 'lightbulb.js', api: 'OTBLightbulb' },
     ],
   };
@@ -441,8 +451,8 @@
   // artist keeps Artistry's tools and gains that experience's own after them.
   function toolsFor(mode) {
     var own = Object.prototype.hasOwnProperty.call(TOOLS, mode) ? TOOLS[mode] : [];
-    if (!review || mode === 'artistry') return own;
-    return TOOLS.artistry.concat(own);
+    if (!review || mode === 'artist') return own;
+    return TOOLS.artist.concat(own);
   }
   function openTool(t, b) {
     loadTool(t).then(function (api) { api.open(); }, function () { b.setAttribute('aria-disabled', 'true'); });
@@ -493,7 +503,7 @@
     // 360px the bar has no room for three, so craft-review.css folds it away.
     own.forEach(function (t) {
       var el = document.getElementById('craft-tool-' + t.id);
-      if (el && el.classList) el.classList.toggle('craft-tool--guest', !!review && TOOLS.artistry.indexOf(t) === -1);
+      if (el && el.classList) el.classList.toggle('craft-tool--guest', !!review && TOOLS.artist.indexOf(t) === -1);
     });
   }
 
@@ -509,23 +519,22 @@
   // picker ends it. Cosmetic like the mode: a tab the gate hides stays hidden.
   var REVIEW_KEY = 'hall-craft-review';
   var EXPERIENCES = [
-    { id: 'ideating', label: 'Ideator experience' },
-    { id: 'governing', label: 'Governing experience' },
-    { id: 'building', label: 'Building experience' },
-    { id: 'artistry', label: 'Artistry experience' },
+    { id: 'patron', label: 'Patron experience' },
+    { id: 'artisan', label: 'Artisan experience' },
+    { id: 'artist', label: 'Artist experience' },
   ];
   // The experience being reviewed, or null. Read from the session once, then
   // held here, so a browser whose storage throws still reviews this page.
   var review = null;
   function storedReview() {
-    return read() === 'artistry' ? valid(get('sessionStorage', REVIEW_KEY)) : null;
+    return read() === 'artist' ? valid(get('sessionStorage', REVIEW_KEY)) : null;
   }
   // The mode the hall wears: the experience under review, else the chosen mode.
   function wearing() { return review || read(); }
   function startReview(mode) {
     mode = valid(mode);
     if (!mode) return;
-    set('sessionStorage', MODE_KEY, 'artistry');
+    set('sessionStorage', MODE_KEY, 'artist');
     set('sessionStorage', ASKED_KEY, '1');
     set('sessionStorage', REVIEW_KEY, mode);
     review = mode;
@@ -534,7 +543,7 @@
   function stopReview() {
     drop('sessionStorage', REVIEW_KEY);
     review = null;
-    apply('artistry');
+    apply('artist');
   }
 
   // The scribble wall: the top bar's empty space, doodled on while reviewing.
@@ -576,7 +585,10 @@
   function icon(id, cls) {
     return '<svg class="' + cls + '" viewBox="0 0 16 16" fill="none" stroke="currentColor" stroke-width="1.4" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true">' + ICONS[id] + '</svg>';
   }
-  function valid(v) { return IDS.indexOf(v) !== -1 ? v : null; }
+  function valid(v) {
+    if (v && Object.prototype.hasOwnProperty.call(LEGACY_MODES, v)) v = LEGACY_MODES[v];
+    return IDS.indexOf(v) !== -1 ? v : null;
+  }
   function get(store, key) { try { return window[store].getItem(key); } catch (_) { return null; } }
   function set(store, key, v) { try { window[store].setItem(key, v); } catch (_) { /* private mode */ } }
   function drop(store, key) { try { window[store].removeItem(key); } catch (_) { /* private mode */ } }
@@ -590,6 +602,7 @@
   // earlier session. null = no mode, which is the hall as it always was. A stored
   // Governing reads as no mode for a builder known to hold no seat (task 1004685).
   function stored() {
+    if (typeof account === 'string') return account;
     return valid(get('sessionStorage', MODE_KEY)) || valid(get('localStorage', KEEP_KEY));
   }
   function read() {
@@ -640,13 +653,15 @@
   function switchHtml() {
     if (pageOptsOut()) return '';
     review = storedReview();
+    var held = heldCharacter();
+    if (held) return '<div class="craft-switch craft-switch--character" id="craft-switch" role="group" aria-label="Your character">' + chipHtml(held) + '</div>';
     var current = review || read();
     return '<div class="craft-switch' + (current ? '' : ' craft-switch--unset') + '" id="craft-switch" role="group" aria-label="Mode">' +
       MODES.map(function (m) {
         return '<button class="craft-switch__opt craft-switch__opt--' + m.id + '" type="button" data-craft-opt="' + m.id + '"' +
           ' aria-pressed="' + (m.id === current ? 'true' : 'false') + '" title="' + esc(labelOf(m) + ' — ' + lineOf(m)) + '"' +
           (offered(m.id) ? '' : ' hidden') + '>' +
-          icon(m.id, 'craft-switch__icon') + '<span class="craft-switch__label">' + esc(m.id === 'governing' && seatName() ? seatName() : m.short) + '</span></button>';
+          icon(m.id, 'craft-switch__icon') + '<span class="craft-switch__label">' + esc(m.id === 'patron' && seatName() ? seatName() : m.short) + '</span></button>';
       }).join('') +
       // At phone width the options fold away and this one button opens the picker.
       '<button class="craft-switch__open" type="button" data-craft-open aria-haspopup="dialog" aria-label="Choose your mode" title="Choose your mode">' +
@@ -659,6 +674,7 @@
   function onSwitchClick(e) {
     var btn = e.target.closest && e.target.closest('button');
     if (!btn) return;
+    if (btn.hasAttribute('data-craft-me')) { changeCharacter(); return; }
     if (btn.hasAttribute('data-craft-open')) { openPicker(); return; }
     var mode = btn.getAttribute('data-craft-opt');
     // At phone width only the current mode shows; tapping it opens the full picker.
@@ -698,24 +714,17 @@
   }
   function artHtml(id) {
     var html = '', rnd, i;
-    if (id === 'building') {
+    if (id === 'artisan') {
       html = '<span class="craft-art__bar" style="left:20px;top:22px;width:110px"></span>' +
         '<span class="craft-art__bar craft-art__bar--dim" style="left:20px;top:42px;width:150px"></span>' +
         '<span class="craft-art__pill" style="left:20px;top:68px"></span><span class="craft-art__card"></span>';
-    } else if (id === 'artistry') {
+    } else if (id === 'artist') {
       rnd = seeded(7);
       for (i = 0; i < 14; i++) html += dot(Math.round(rnd() * 250), Math.round(rnd() * 66), rnd() > 0.8 ? 2 : 1, 'opacity:' + (0.4 + rnd() * 0.6).toFixed(2), 'star');
       html += '<span class="craft-art__moon"></span><span class="craft-art__ground"></span>' +
         '<span class="craft-art__house" style="left:24px;height:54px;width:26px"></span><span class="craft-art__house" style="left:60px;height:44px;width:34px"></span>' +
         dot(32, 66, 3, '', 'lit') + dot(70, 72, 3, '', 'lit');
-    } else if (id === 'ideating') {
-      rnd = seeded(11);
-      html = '<span class="craft-art__ring"></span>';
-      for (i = 0; i < 18; i++) {
-        var proto = rnd() > 0.7, r = proto ? 6 : (rnd() > 0.75 ? 5 : 2);
-        html += dot(Math.round(rnd() * 260), Math.round(6 + rnd() * 90), r, '', proto ? 'proto' : (r > 3 ? 'glow' : 'gold'));
-      }
-    } else if (id === 'governing') {
+    } else if (id === 'patron') {
       html = '<svg class="craft-art__city" viewBox="0 0 300 110" aria-hidden="true">' + cityPaths() + '</svg>';
     }
     return '<span class="craft-art craft-art--' + id + '" aria-hidden="true">' + html + '</span>';
@@ -737,7 +746,7 @@
       '<div class="craft-picker__doors" data-doors="' + shown.length + '">' + doors + '</div>' +
       '<div class="craft-picker__foot">' +
         '<label class="craft-picker__again"><input type="checkbox" data-craft-again checked> Ask me again next session</label>' +
-        (preselect === 'artistry' ? '<span class="craft-picker__hint">Artists start on Artistry.</span>' : '') +
+        (preselect === 'artist' ? '<span class="craft-picker__hint">Artists start here.</span>' : '') +
       '</div>' +
     '</div>';
   }
@@ -746,7 +755,8 @@
   }
   function onPickerKey(e) {
     if (!picker) return;
-    if (e.key === 'Escape') { e.preventDefault(); closePicker(); return; }
+    // Character creation is a choice to make, not a box to dismiss: Escape stays put.
+    if (e.key === 'Escape') { e.preventDefault(); if (!creating) closePicker(); return; }
     if (e.key !== 'Tab') return;
     var f = focusables();
     if (!f.length) return;
@@ -755,6 +765,11 @@
     else if (!e.shiftKey && document.activeElement === last) { e.preventDefault(); first.focus(); }
   }
   function onPickerClick(e) {
+    if (creating) {
+      var c = e.target.closest && e.target.closest('button[data-char-pick]');
+      if (c) pickCharacter(c.getAttribute('data-char-pick'));
+      return;
+    }
     if (e.target === picker) { closePicker(); return; }
     var btn = e.target.closest && e.target.closest('button');
     if (!btn) return;
@@ -787,6 +802,7 @@
     document.removeEventListener('keydown', onPickerKey, true);
     if (picker.parentNode) picker.parentNode.removeChild(picker);
     picker = null;
+    creating = false;
     document.documentElement.classList.remove('craft-picker-open');
     if (returnFocus && returnFocus.focus) { try { returnFocus.focus(); } catch (_) { /* gone */ } }
     returnFocus = null;
@@ -797,7 +813,173 @@
     if (!builder) return null;
     var main = builder.main_discipline;
     var crafts = Array.isArray(builder.preferred_disciplines) ? builder.preferred_disciplines : [];
-    return (main === 'artist' || (!main && crafts[0] === 'artist')) ? 'artistry' : null;
+    return (main === 'artist' || (!main && crafts[0] === 'artist')) ? 'artist' : null;
+  }
+
+  // ---------- character creation (task 1005147, BONGOS-V3 G2) ----------
+  // A builder picks one of three characters when they join, and the pick is kept on
+  // their ACCOUNT (PUT /me/character, core_297), so it follows them to every device.
+  // /me says which one they hold; null means not picked yet, and the hall then shows
+  // character creation before anything else (the welcome and the session picker wait).
+  // Holding a character replaces the per-session mode: the top-bar switch becomes the
+  // character's sprite, and offered() names that character alone. Switching is signing
+  // out and back in (the spec's settled point 2): the sprite's "Change character"
+  // clears the pick and signs out, and the next sign-in finds none and asks again.
+  // Identity and view only — rank still gates every verb on the server (ADR 0016).
+  //
+  // The sprites are the owner's art (Builder → Artisan, Artist → Artist, Ruler →
+  // Patron; the Governor is the spare), one file per character under characters/.
+  var account;            // undefined: not told; null: none picked; else the character
+  var creating = false;   // the preselected door while character creation is open
+  var CHAR_KEY = 'hall-character'; // localStorage: the last held character, so the first paint is right
+  var CHARACTER_LINES = {
+    artisan: 'Claim work and build it. Your record is the leaderboard.',
+    artist: 'Shape how things look and read, and turn thoughts into ideas. Your work hangs in the museum.',
+    patron: 'Watch the project, propose, and with a seat decide.',
+  };
+  // Only ever one of the three names reaches the URL (valid() is the allowlist).
+  function spriteSrc(id) { return '/builders/characters/' + (valid(id) || 'artisan') + '.png' + (SCRIPT_V ? '?v=' + SCRIPT_V : ''); }
+  function spriteHtml(id, cls) {
+    return '<img class="craft-sprite ' + cls + '" src="' + spriteSrc(id) + '" alt="" width="250" height="290" decoding="async">';
+  }
+  function heldCharacter() {
+    if (typeof account === 'string') return account;
+    if (account === null) return null;
+    return valid(get('localStorage', CHAR_KEY));
+  }
+  function modeOf(id) { return MODES[IDS.indexOf(id)]; }
+  function chipHtml(id) {
+    var m = modeOf(id);
+    var name = m.label; // a character's name, never the seat's title
+    return '<button class="craft-switch__me craft-switch__opt--' + id + '" type="button" data-craft-me aria-haspopup="dialog"' +
+      ' title="' + esc('You are the ' + name + '. Change character') + '">' +
+      spriteHtml(id, 'craft-sprite--chip') + '<span class="craft-switch__label">' + esc(name) + '</span></button>';
+  }
+  function paintCharacter() {
+    var sw = document.getElementById('craft-switch');
+    if (!sw) return;
+    var held = heldCharacter();
+    if (held) {
+      sw.className = 'craft-switch craft-switch--character';
+      sw.setAttribute('aria-label', 'Your character');
+      sw.innerHTML = chipHtml(held);
+    } else if (sw.classList && sw.classList.contains('craft-switch--character')) {
+      // A character dropped (signed out mid-change): back to the plain switch.
+      var tmp = document.createElement('div');
+      tmp.innerHTML = switchHtml();
+      var fresh = tmp.firstChild;
+      if (fresh && sw.parentNode) { sw.parentNode.replaceChild(fresh, sw); fresh.addEventListener('click', onSwitchClick); }
+    }
+  }
+  // What /me said. Called by characterGate; also exported for a page that re-reads /me.
+  function setCharacter(c) {
+    account = c === null ? null : (valid(c) || undefined);
+    if (typeof account === 'string') set('localStorage', CHAR_KEY, account);
+    else if (account === null) drop('localStorage', CHAR_KEY);
+    paintCharacter();
+    if (typeof account === 'string' && offered(account)) {
+      if (document.documentElement.dataset.craft !== account && !review) apply(account);
+    }
+  }
+  function createHtml(preselect) {
+    var shown = MODES.filter(function (m) { return offered(m.id); });
+    var doors = shown.map(function (m) {
+      return '<button class="craft-door craft-door--character craft-door--' + m.id + (m.id === preselect ? ' craft-door--pre' : '') + '" type="button" data-char-pick="' + m.id + '">' +
+        '<span class="craft-plinth" aria-hidden="true">' + spriteHtml(m.id, 'craft-sprite--door') + '</span>' +
+        '<span class="craft-door__head"><span class="craft-door__name">' + esc(m.label) + '</span></span>' +
+        '<span class="craft-door__line">' + esc(CHARACTER_LINES[m.id] || m.line) + '</span></button>';
+    }).join('');
+    return '<div class="craft-picker__panel craft-picker__panel--create" role="dialog" aria-modal="true" aria-labelledby="craft-picker-title" aria-describedby="craft-picker-lede">' +
+      '<p class="craft-picker__eyebrow">Character creation</p>' +
+      '<h2 class="craft-picker__title" id="craft-picker-title">Choose your character</h2>' +
+      '<p class="craft-picker__lede" id="craft-picker-lede">This is who you are in the project. To change it later, sign out and pick again.</p>' +
+      '<div class="craft-picker__doors" data-doors="' + shown.length + '">' + doors + '</div>' +
+      '<p class="craft-picker__error" data-char-error role="alert" hidden></p>' +
+    '</div>';
+  }
+  function openCreate(preselect) {
+    if (picker || pageOptsOut() || !document.body) return;
+    creating = valid(preselect) || 'artisan';
+    returnFocus = document.activeElement;
+    picker = document.createElement('div');
+    picker.className = 'craft-picker craft-picker--create';
+    picker.id = 'craft-picker';
+    picker.innerHTML = createHtml(creating);
+    picker.addEventListener('click', onPickerClick);
+    document.addEventListener('keydown', onPickerKey, true);
+    document.body.appendChild(picker);
+    document.documentElement.classList.add('craft-picker-open');
+    var pre = picker.querySelector('.craft-door--pre') || picker.querySelector('[data-char-pick]');
+    if (pre && pre.focus) pre.focus();
+  }
+  function client() {
+    var C = window.BongosClient;
+    return C && C.createClient ? C.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false }) : null;
+  }
+  var saving = false;
+  function pickCharacter(mode) {
+    mode = valid(mode);
+    if (!mode || !offered(mode) || saving) return;
+    var api = client();
+    var err = picker && picker.querySelector('[data-char-error]');
+    if (!api) { if (err) { err.textContent = 'Your character could not be saved. Reload and try again.'; err.removeAttribute('hidden'); } return; }
+    saving = true;
+    if (err) err.setAttribute('hidden', '');
+    api.request('PUT', '/api/bongos/me/character', { body: { character: mode } }).then(function (res) {
+      saving = false;
+      if (!res || !res.ok) throw new Error('character not saved');
+      closePicker();
+      choose(mode, true);
+      setCharacter(res.data && res.data.character ? res.data.character : mode);
+    }).then(null, function () {
+      saving = false;
+      var e2 = picker && picker.querySelector('[data-char-error]');
+      if (e2) { e2.textContent = 'Your character could not be saved. Try again.'; e2.removeAttribute('hidden'); }
+    });
+  }
+  // The sprite's one action: change character, which is signing out (spec point 2).
+  function signOut() {
+    var link = document.getElementById('logout-link');
+    if (link && link.click) { link.click(); return; }
+    var api = client();
+    var home = function () { if (window.location) window.location.assign('/'); };
+    if (api) api.request('POST', '/api/bongos/auth/logout').then(home, home); else home();
+  }
+  var changing = false; // one dialog at a time, however many clicks
+  function changeCharacter() {
+    if (changing) return;
+    changing = true;
+    var held = heldCharacter();
+    var name = held ? modeOf(held).label : 'your character';
+    var D = window.OTBDialog;
+    var ask = D && D.confirm ? D.confirm({
+      title: 'Change character?',
+      body: 'You are the ' + name + '. To change, you sign out, and you pick a character again when you sign back in.',
+      confirmLabel: 'Sign out and change',
+    }) : Promise.resolve(false);
+    ask.then(function (yes) {
+      changing = false;
+      if (!yes) return;
+      var api = client();
+      var done = function () { drop('localStorage', CHAR_KEY); drop('localStorage', KEEP_KEY); drop('sessionStorage', MODE_KEY); signOut(); };
+      if (api) api.request('PUT', '/api/bongos/me/character', { body: { character: null } }).then(done, done); else done();
+    });
+  }
+  // The shell's first call once /me has answered, ahead of the welcome and the
+  // session picker: true when character creation is up (so nothing else stacks on it).
+  // The last /me the gate was handed (task 1005148): the visor reads the credits off it.
+  var lastMe = null;
+  function characterGate(access, me) {
+    if (!access || access.authed !== true || !me || !me.builder || pageOptsOut()) return false;
+    lastMe = me;
+    try { document.dispatchEvent(new CustomEvent('otbcraft:me')); } catch (_) { /* old engine */ }
+    if (me.character === undefined) return false; // an older core, or not told: no characters yet
+    setCharacter(me.character);
+    if (account !== null) return false;
+    if (creating) return true;
+    var main = me.builder.main_discipline;
+    openCreate(main === 'artist' ? 'artist' : 'artisan');
+    return true;
   }
 
   // ---------- the shell's three calls ----------
@@ -820,9 +1002,11 @@
     if (note && notes && !onStudio) loadTool(notes).then(function (api) { api.openNote(note[1]); }, function () { /* the page still works */ });
   }
   // Once a signed-in builder is known, ask — unless this session already has a
-  // mode, already saw the picker, or the page opts out.
+  // mode, already saw the picker, or the page opts out. A screen inside the options menu's
+  // frame never asks (task 1005144): the menu page around it does, once.
   function onAccess(access, builder) {
     if (!access || access.authed !== true || !builder || pageOptsOut() || !sessionOk()) return;
+    if (window.OTBShellGame && window.OTBShellGame.embedded && window.OTBShellGame.embedded()) return;
     if (read() || get('sessionStorage', ASKED_KEY)) return;
     openPicker(preselectFor(builder));
   }
@@ -867,5 +1051,15 @@
     // task 1004685 (prototype): the seats the viewer holds, and the Governing seat's name.
     setPositions: setPositions,
     seatName: seatName,
+    // task 1005147: character creation. characterGate is the shell's first call once
+    // /me answers; character() is the one held (null: none, undefined: not told yet).
+    characterGate: characterGate,
+    setCharacter: setCharacter,
+    character: function () { return account; },
+    changeCharacter: changeCharacter,
+    spriteSrc: spriteSrc,
+    // task 1005148: the visor's two reads — the /me the gate saw, and a tool by id.
+    me: function () { return lastMe; },
+    openTool: function (id) { var t = toolFor(id); if (t) loadTool(t).then(function (api) { api.open(); }, function () { /* tool did not load */ }); },
   };
 })();

package/modules/hall-ui/public/deploy.html

@@ -8,7 +8,7 @@
   <link rel="icon" href="/modules/ui-design/public/brand/favicon.svg" type="image/svg+xml">
   <link rel="preconnect" href="https://fonts.googleapis.com">
   <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
-  <link rel="stylesheet" href="/builders/style.css?v=2026-09-23-changelist1">
+  <link rel="stylesheet" href="/builders/style.css?v=2026-11-11-helm">
   <link rel="stylesheet" href="/builders/oversight.css">
   <link rel="stylesheet" href="/builders/hall-ask.css">
   <link rel="stylesheet" href="/builders/project-settings.css">
@@ -79,10 +79,10 @@
 <div id="toast" class="toast" role="status" aria-live="polite" data-visible="0"></div>
 
 <script src="/builders/dom-utils.js?v=2026-11-05-numbers"></script>
-<script src="/builders/shell-game.js?v=2026-11-09-game-mode"></script>
+<script src="/builders/shell-game.js?v=2026-11-11-helm"></script>
 <script src="/builders/shell-trail.js?v=2026-11-05-numbers"></script>
-<script src="/builders/craft-mode.js?v=2026-11-05-goals"></script>
-<script src="/builders/shell.js?v=2026-11-09-game-mode"></script>
+<script src="/builders/craft-mode.js?v=2026-11-10-visor"></script>
+<script src="/builders/shell.js?v=2026-11-11-helm"></script>
 <script src="/builders/hall-dialog.js"></script>
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/hall-kit.js"></script>

package/modules/hall-ui/public/deploy.states.json

@@ -1,6 +1,7 @@
 {
   "_": "DEPLOY (task 1003159, ADR 0293; the npm-release module's sections, task 1002622) through modules/ui-design/kit/render.js. The page reads authenticated routes gated on core.pin.move, so against the kit's own stub it renders its restricted or failed-read state. To look at the populated page — the deploy door AND the module's 'where the work is' + version history, from a fixture taken off the live registry and ledger — run the hall-preview harness with the module on:\n\n  BONGOS_MODULE_NPM_RELEASE=1 node scripts/hall-preview/server.js --port 4602 --rank archon --fixture-me --modules-on npm-release,provisioning\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/deploy.states.json --base-in http://localhost:4602 --base-out http://localhost:4602",
   "page": "/builders/deploy",
+  "modes": ["dark"],
   "_storage": "The hall asks a first-visit question (the session mode picker, craft-mode.js) over every page; seeding \"already asked\" renders the page a returning builder sees (task 1005080).",
   "storage": { "session": { "hall-craft-asked": "1" } },
   "surface": "hall-ui",

package/modules/hall-ui/public/diagram-viewer.js

@@ -318,7 +318,8 @@
     }
     // Esc exits fullscreen from anywhere.
     document.addEventListener('keydown', (e) => {
-      if ((e.key === 'Escape' || e.key === 'Esc') && fullscreen) toggleFullscreen(fullscreen);
+      // Spent once it left the viewer's full screen (ADR 0399 §2.4 row 5, task 1005144).
+      if ((e.key === 'Escape' || e.key === 'Esc') && fullscreen) { e.preventDefault(); toggleFullscreen(fullscreen); }
     });
     // Re-fit on resize: the fullscreen viewer always, and any inline viewer the
     // reader hasn't manually zoomed/panned (so they stay responsive).

package/modules/hall-ui/public/dom-utils.js

@@ -185,7 +185,7 @@
   function disciplines() {
     const m = window.__MODULES__;
     const list = m && Array.isArray(m.disciplines) ? m.disciplines : null;
-    return list && list.length ? list.slice() : ['engineer', 'ideator'];
+    return list && list.length ? list.slice() : ['artisan', 'artist'];
   }
 
   // Fill a Kind <select> from the vocabulary the SERVER serves (GET /me