@bongos/core 1.24.79 → 1.24.81

package/src/bongos/routes/me.js

@@ -217,6 +217,12 @@ module.exports = function buildMeRouter() {
     const openPayoutHoldsP = (async () => {
       try { return await require('../payout-gates').openHoldsFor(req.builder.id); } catch (_) { return null; }
     })();
+    // task 1005147: the character this builder holds, or null (not picked yet — the
+    // hall then shows character creation). Fail-open to null: a core that runs
+    // before core_297 has no column, and that must never break /me.
+    const characterP = (async () => {
+      try { return await db.getBuilderCharacter(req.builder.id); } catch (_) { return null; }
+    })();
     const stuckPageTweaksP = (async () => {
       try {
         const port = seams.resolveOptional('copy-desk.stuckPageTweaksFor');
@@ -476,6 +482,9 @@ module.exports = function buildMeRouter() {
       // when lifecycle is disabled or the read failed, and the shell treats null
       // as OFF — a mode that cannot be read is not on.
       social: socialMode,
+      // task 1005147: the builder's character ('artisan' | 'artist' | 'patron'),
+      // or null until they pick one. Identity and view only; rank still gates.
+      character: await characterP,
       // task 1004422 (BV2.PS03, goal 1000121): PROJECT FOUNDING MODE. Genesis is a
       // mode the EXISTING hall wears (the blend rule, docs/design/project-startup-
       // direction.md), so it rides /me exactly like social: the shell stamps
@@ -724,6 +733,30 @@ module.exports = function buildMeRouter() {
     }
   });
 
+  // task 1005147 (BONGOS-V3 G2): character creation. Body: { character } —
+  // 'artisan' | 'artist' | 'patron', or null to clear it (the hall clears it and
+  // signs out: switching character is signing out and back in, spec settled point 2).
+  // Identity and view only: no claim, vote, deploy or spend gate reads it
+  // (criterion character-is-identity-not-authority). 422 invalid_character otherwise.
+  // rank: any-builder — a builder writes only their own row (req.builder.id), the
+  // /me/disciplines posture.
+  router.put('/me/character', auth.requireBuilder, async (req, res) => {
+    // Nullable by the validator's default: null is the deliberate clear.
+    if (validateOrRespond(req, res, { character: { type: 'string', maxLength: 32 } }, { strict: true })) return;
+    const body = req.body || {};
+    if (!Object.prototype.hasOwnProperty.call(body, 'character')) {
+      return res.fail('character_required', 400);
+    }
+    const raw = body.character;
+    try {
+      const character = await db.setBuilderCharacter(req.builder.id, raw);
+      res.json({ character });
+    } catch (err) {
+      if (err.code === 'invalid_character') return res.fail('invalid_character', 422);
+      throw err;
+    }
+  });
+
   // V3.R10 (#235), criterion C3 — link the authed builder's Anthropic account.
   // Body: { anthropic_email, anthropic_user_id }. Self-attestation: the builder's
   // own Claude Code reads ~/.claude.json oauthAccount during /builder-setup,

package/src/bongos/serve-internal.js

@@ -45,6 +45,7 @@ const { buildInfo } = require('../build-info');
 const { buildBongosDownloads, installScriptReader } = require('../bongos-downloads');
 const { clientBranding, branding, applyBrandConditionals } = require('../branding');
 const { themeMarkup } = require('../theme-markup');
+const { applyHelm } = require('../hall-helm');
 const { linkPreviewTags } = require('../link-preview');
 const { prelaunchGate } = require('./prelaunch-gate');
 const { platformVisibilityGate } = require('./platform-visibility-gate');
@@ -126,8 +127,12 @@ function injectBrandingGlobal(html, brand = clientBranding(), mods = clientModul
   // §4), injected the same way as __BRANDING__ so hall/status scripts can hide
   // UI sections for off modules synchronously (no fetch, no race). R60 wires the
   // actual section-hiding; this exposes the data. The link-preview card (task 1005091) rides along.
-  const stamped = applyBrandTokens(html, brand);
-  const tag = `${clientBundleScriptTag()}<script>window.__BRANDING__=${jsonForScript(brand)};window.__MODULES__=${jsonForScript(mods)};</script>${linkPreviewTags(stamped, brand, safePublicOrigin())}${themeMarkup(brand.theme)}`;
+  // A HALL page (one that links the hall's sheet) is pinned dark and, unless its pack
+  // chose faces of its own, takes the Helm faces (task 1005192, ADR 0402, src/hall-helm.js).
+  // Every other page comes back from applyHelm untouched.
+  const helm = applyHelm(applyBrandTokens(html, brand), brand.theme);
+  const stamped = helm.html;
+  const tag = `${clientBundleScriptTag()}<script>window.__BRANDING__=${jsonForScript(brand)};window.__MODULES__=${jsonForScript(mods)};</script>${linkPreviewTags(stamped, brand, safePublicOrigin())}${themeMarkup(brand.theme)}${helm.tail}`;
   return stamped.includes('</head>') ? stamped.replace('</head>', `${tag}</head>`) : tag + stamped;
 }
 
@@ -965,18 +970,35 @@ function mountInternalSurfaces(app) {
     return res.redirect(302, `${isBuildersHost(req) ? '' : '/builders'}/roster${qs}`);
   });
 
-  // task 1005045 (owner decision 2026-11-03, idea 1001310): the owner's Market Watch
-  // settings left their own page (task 1004938) for an owner-only Settings tab on
-  // /market-watch, so the sidebar says "Market Watch" once. The old URL lands on that
-  // tab; 302 for the same reason as the directory above, and no page gate: the redirect
-  // discloses nothing, /market-watch has its own, and the settings routes are the wall.
-  const RETIRED_MW_SETTINGS_RE = /^\/builders\/market-watch-settings(?:\.html)?\/?$/;
+  // THE ONE OPTIONS MENU (task 1005144, BONGOS-V3 R04, ADR 0401). Every setting is
+  // reached from Settings, which is the options menu now; the screens that were pages
+  // of their own open INSIDE it, in a frame that asks for the old address with
+  // ?embed=1. A plain visit to an old address (a bookmark, a doc, a Discord message)
+  // lands on the menu with that screen open (?open=<entry>), and the browser carries
+  // the old #anchor across the redirect because the Location names none. The framed
+  // request passes through to the page and its own page gate below. 302 and no gate,
+  // as the redirects that follow: the redirect discloses nothing, Settings has its own
+  // sign-in gate, and each screen keeps its page gate and its routes (ADR 0016).
+  // options-menu.js RETIRED is this map's twin (tests/hall_options_menu.mjs holds them
+  // equal). market-watch-settings was the owner's tab on /market-watch (task 1005045)
+  // and a page before that; it has no page left, so it never passes through.
+  const RETIRED_TO_OPTIONS = Object.freeze({
+    'my-agents': 'my-agents',
+    'project-settings': 'project-settings',
+    modules: 'modules',
+    government: 'permissions',
+    'market-watch-rules': 'market-watch-rules',
+    'market-watch-settings': 'market-watch',
+  });
+  const RETIRED_OPTIONS_RE = /^\/builders\/(my-agents|project-settings|modules|government|market-watch-rules|market-watch-settings)(?:\.html)?\/?$/;
   app.use((req, res, next) => {
     if (isModuleSurfaceHost(req)) return next();
     if (req.method !== 'GET' && req.method !== 'HEAD') return next();
-    if (!RETIRED_MW_SETTINGS_RE.test(path.posix.normalize(req.path))) return next();
-    const qs = req.url.includes('?') ? req.url.slice(req.url.indexOf('?')) : '';
-    return res.redirect(302, `${isBuildersHost(req) ? '' : '/builders'}/market-watch${qs}#settings`);
+    const m = RETIRED_OPTIONS_RE.exec(path.posix.normalize(req.path));
+    if (!m) return next();
+    const embed = new URLSearchParams(req.url.includes('?') ? req.url.slice(req.url.indexOf('?') + 1) : '').get('embed');
+    if (embed === '1' && m[1] !== 'market-watch-settings') return next();
+    return res.redirect(302, `${isBuildersHost(req) ? '' : '/builders'}/settings?open=${RETIRED_TO_OPTIONS[m[1]]}`);
   });
 
   // Pages folded into another page; 302 and no gate, as above. Task 1005047: Fleet costs is

package/src/crafts.js

@@ -0,0 +1,66 @@
+'use strict';
+// src/crafts.js — the craft vocabulary, in one place (task 1005141, BONGOS-V3 C1).
+//
+// The game conversion (docs/specs/bongos-v3-game-conversion.md, "Task outline / G1",
+// settled point 6) names the three characters a builder holds:
+//
+//   artisan — builds: code, infra, Bongos itself           (was 'engineer')
+//   artist  — how the project looks and reads, AND its ideas (was 'artist' + 'ideator')
+//   patron  — watches, proposes, and (with a seat) governs   (was the 'governing' craft mode)
+//
+// 'ui' stays a module-contributed discipline (ADR 0272); it is not a character.
+//
+// THE OLD SPELLINGS STILL ARRIVE. A rolled-back release, a co-tenant instance on an
+// older core (federated craft rollups), an old CLI, a bookmarked ?discipline=engineer
+// and a help request's historical 'builder' all still say the old word. Every input
+// boundary runs a value through normalizeCraft() so the old word lands as the new one;
+// nothing downstream should ever compare against 'engineer' or 'ideator' again. The
+// database keeps ACCEPTING the old words too (core_296's CHECKs are a superset) because
+// `bongos upgrade` rolls code back without rolling the database back — a contraction
+// that drops them is a later, separate migration.
+//
+// The crafts a TASK can carry are artisan and artist. Patron is a character, not a
+// kind of work: a task is built (artisan) or made/imagined (artist), and governing
+// work is a vote, not a task.
+//
+// ONLY THE TWO FUNCTIONS ARE EXPORTED. A list of the crafts, display labels and a
+// label helper were exported here once and nothing read them, which the dead-code
+// ratchet (knip) counts as a regression. Add one back when a caller needs it.
+
+// Old spelling → new spelling. 'builder' is the help-request spelling of the
+// engineering craft (ADR 0174); 'building'/'artistry'/'ideating'/'governing' are the
+// hall's old craft-mode ids (modules/hall-ui/public/craft-mode.js).
+const LEGACY = Object.freeze({
+  engineer: 'artisan',
+  engineering: 'artisan',
+  builder: 'artisan',
+  building: 'artisan',
+  ideator: 'artist',
+  ideating: 'artist',
+  artistry: 'artist',
+  governing: 'patron',
+  governor: 'patron',
+  ruler: 'patron',
+});
+
+// Any spelling → today's. Non-strings pass through untouched (callers validate);
+// an unknown word passes through too, so a module-contributed craft is never eaten.
+function normalizeCraft(value) {
+  if (typeof value !== 'string') return value;
+  const v = value.trim().toLowerCase();
+  return Object.prototype.hasOwnProperty.call(LEGACY, v) ? LEGACY[v] : v;
+}
+
+// A list of crafts → today's spellings, deduped in first-seen order. The fold matters:
+// ['artist', 'ideator'] is one craft now, not two.
+function normalizeCrafts(list) {
+  if (!Array.isArray(list)) return list;
+  const out = [];
+  for (const item of list) {
+    const c = normalizeCraft(item);
+    if (!out.includes(c)) out.push(c);
+  }
+  return out;
+}
+
+module.exports = { normalizeCraft, normalizeCrafts };

package/src/hall-helm.js

@@ -0,0 +1,79 @@
+// src/hall-helm.js — Helm, the look the builders' hall wears (task 1005192, ADR 0402).
+//
+// The hall is the game: everything after sign-in. It is dark only, and it reads in
+// the two Helm faces unless its pack chose faces of its own. Both are decided HERE,
+// at serve time, for one reason each:
+//
+//   * DARK ONLY. A fixed html[data-theme="dark"] in the served markup selects the
+//     hall sheet's dark tier before first paint, with nothing to flash and nothing
+//     for the OS preference to reach (the ADR 0204 move, on the hall's own
+//     attribute). shell.js sets the same value again for a page read without it.
+//   * THE FACES. The pack splices --font-display / --font-body as a plain :root
+//     after every sheet, for every surface, so the landing and the hall would
+//     always read the same face. The hall sheet carries the Helm stacks as its own
+//     tokens (--helm-display / --helm-body) and hands them to the two font tokens
+//     under html[data-faces="helm"], which outranks the pack's :root. This file
+//     stamps that attribute, and links the two families, only for a hall whose
+//     pack still names the platform's default faces. A pack that names its own
+//     (config/branding.json, or a look from the style library with faces of its
+//     own, ADR 0358) is never stamped and keeps them.
+//
+// A hall page is recognised by what makes it one: it links the hall's sheet. So one
+// seam (serve-internal.js injectBrandingGlobal) covers the server, the preview
+// harness and the design kit's stub, and the landing, the hub and the status page,
+// which never link that sheet, are never touched. PURE given `defaults`.
+'use strict';
+
+const fs = require('node:fs');
+const path = require('node:path');
+const { escapeHtml: esc } = require('./html-escape');
+
+// Barlow Condensed (the name voice) and Barlow (everything said to you), swapped in.
+const HELM_FONTS_HREF = 'https://fonts.googleapis.com/css2?family=Barlow+Condensed:wght@400;500;600&family=Barlow:wght@400;500&display=swap';
+const HALL_SHEET_RE = /<link\b[^>]*\bhref="\/builders\/style\.css[^"]*"/i;
+const HTML_TAG_RE = /<html\b([^>]*)>/i;
+
+function isHallPage(html) {
+  return HALL_SHEET_RE.test(String(html || ''));
+}
+
+// The platform's default faces: the neutral pack's two stacks, read once. A hall
+// whose resolved pack still carries exactly these has not chosen faces.
+let _defaults = null;
+function defaultFaces() {
+  if (_defaults) return _defaults;
+  try {
+    const { resolveCoreRoot } = require('./instance-config'); // eslint-disable-line global-require
+    const pack = JSON.parse(fs.readFileSync(path.join(resolveCoreRoot(), 'config', 'branding.neutral.json'), 'utf8'));
+    const fonts = (pack.theme && pack.theme.ui && pack.theme.ui.fonts) || {};
+    _defaults = { display: String(fonts.display || ''), body: String(fonts.body || '') };
+  } catch { _defaults = { display: '', body: '' }; }
+  return _defaults;
+}
+
+// Whether this hall takes the Helm faces: its pack names the default ones (or none).
+function wearsHelmFaces(theme, defaults = defaultFaces()) {
+  const fonts = (theme && theme.fonts) || {};
+  const same = (mine, theirs) => !mine || mine === theirs;
+  return same(fonts.display, defaults.display) && same(fonts.body, defaults.body);
+}
+
+// Set one attribute on the document's <html> tag, replacing a value already there.
+function stampHtml(html, name, value) {
+  return html.replace(HTML_TAG_RE, (tag, attrs) => {
+    const rest = attrs.replace(new RegExp(`\\s${name}(?:="[^"]*")?`, 'i'), '');
+    return `<html${rest} ${name}="${esc(value)}">`;
+  });
+}
+
+// The whole transform for one served page: a page that does not link the hall's
+// sheet comes back untouched. `tail` is markup for the end of <head>.
+function applyHelm(html, theme, defaults = defaultFaces()) {
+  if (!isHallPage(html)) return { html, tail: '' };
+  let out = stampHtml(html, 'data-theme', 'dark');
+  if (!wearsHelmFaces(theme, defaults)) return { html: out, tail: '' };
+  out = stampHtml(out, 'data-faces', 'helm');
+  return { html: out, tail: `<link rel="stylesheet" href="${esc(HELM_FONTS_HREF)}">` };
+}
+
+module.exports = { applyHelm, isHallPage, wearsHelmFaces, stampHtml, HELM_FONTS_HREF };

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.79'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.81'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');
@@ -134,6 +134,11 @@ module.exports = {
   // sleep(ms) — the one server-side "wait N milliseconds" (a Promise over setTimeout).
   //     The browser twin is window.OTB.sleep; fitness fails on a third copy (task 1004893).
   sleep,
+  // crafts — the craft vocabulary (artisan · artist · patron, plus module 'ui') and
+  //     normalizeCraft/normalizeCrafts, which turn an old spelling ('artisan',
+  //     'artist', 'builder') into today's. Every craft read from outside goes through
+  //     it (task 1005141, src/crafts.js).
+  get crafts() { return require('./crafts'); },
 
   // --- auth & rank (ADR 0016) — the gates the loader composes around a module's
   //     routes; a module declares the rank it needs and never wires auth itself.

package/src/module-loader/manifest-schema.js

@@ -16,6 +16,9 @@
 //                                       //   what update, rollout channels and re-assessment name.
 //     "coreVersion":  "^1.0.0",         // REQUIRED. semver range of src/module-api.js CORE_VERSION it supports.
 //     "default":      false,            // OPTIONAL (default false). Enablement fail-safe when no config names it.
+//     "language":     "javascript",     // OPTIONAL (default "javascript", task 1004794). What the module's code is
+//                                       //   written in — one of MODULE_LANGUAGES. A closed list: only languages
+//                                       //   the core can actually run are on it.
 //     "author":       "…",              // OPTIONAL. Attribution (ADR 0107 §2) — portable, not a cross-GDS FK.
 //     "origin":       "…",              // OPTIONAL. Origin instance/project this module was built in.
 //     "license":      "…",              // OPTIONAL. e.g. "AGPL-3.0" — the license this module is offered under.
@@ -138,6 +141,14 @@ function isClaudeArtifactUrl(v) {
   return u.protocol === 'https:' && !u.username && !u.password && (host === 'claude.ai' || host.endsWith('.claude.ai'));
 }
 
+// The languages a module may declare (task 1004794). Closed on purpose: a value is on
+// this list only once the core can RUN a module written in it, so a manifest that says
+// "python" today fails loudly at validation instead of being loaded as JavaScript and
+// failing somewhere far from the cause. How a separate-program module runs beside
+// Bongos is decided in its own ADR (task 1004797); that work adds its languages here.
+const MODULE_LANGUAGES = Object.freeze(['javascript']);
+const DEFAULT_MODULE_LANGUAGE = 'javascript';
+
 const MAINTENANCE_STATUSES = ['core-maintained', 'maintained', 'deprecated', 'orphaned'];
 const MAINTENANCE_KEYS = ['status', 'since', 'removeAfter', 'successor', 'note'];
 // Statuses that describe a module on its way out — these owe a deprecation path.
@@ -213,6 +224,11 @@ function validateManifest(obj) {
   // --- optional default ---
   if ('default' in obj && typeof obj.default !== 'boolean') E('default: must be a boolean when present');
 
+  // --- optional language (task 1004794) — absent means "javascript" ---
+  if ('language' in obj && !MODULE_LANGUAGES.includes(obj.language)) {
+    E(`language: ${JSON.stringify(obj.language)} is not a supported module language (allowed: ${MODULE_LANGUAGES.join(', ')}; omit it for "${DEFAULT_MODULE_LANGUAGE}")`);
+  }
+
   // --- optional attribution (ADR 0107 §2 — portable credit, not a cross-GDS FK) ---
   for (const k of ATTRIBUTION_KEYS) {
     if (k in obj && !isStr(obj[k])) E(`${k}: must be a non-empty string when present`);

package/src/modules.js

@@ -86,7 +86,7 @@ const MODULE_REGISTRY = {};
 // shipping a pixel-art pipeline. Making it core aligns the one outlier list with
 // the DB CHECK and keeps the copyright exclusion untouched. Order mirrors the
 // migration 176 enum (engineer | artist | ideator | ui).
-const CORE_DISCIPLINES = ['engineer', 'artist', 'ideator'];
+const CORE_DISCIPLINES = ['artisan', 'artist'];
 
 const KNOWN_MODULES = Object.keys(MODULE_REGISTRY);
 
@@ -475,7 +475,7 @@ function isModuleEnabled(name, set = modules()) {
 const enabledModules = (set = modules()) => knownModules().filter((k) => set[k] === true);
 
 // Disciplines this instance offers = core + every enabled module's declared
-// disciplines, deduped, stable order. Vanilla = ['engineer','ideator'].
+// disciplines, deduped, stable order. Vanilla = ['artisan','artist'].
 function enabledDisciplines(set = modules()) {
   const reg = effectiveRegistry();
   const out = [...CORE_DISCIPLINES];

package/src/role-responsibilities.js

@@ -29,15 +29,16 @@
 'use strict';
 
 // discipline key (tasks.discipline / builders.preferred_disciplines) → the owner's
-// sentence. Keys mirror CORE_DISCIPLINES order (engineer | artist | ideator), the
-// migration 176 enum order. A module-contributed discipline (ui-design → 'ui') has
+// sentence. Keys mirror CORE_DISCIPLINES order (artisan | artist), the
+// core_296 order. A module-contributed discipline (ui-design → 'ui') has
 // no statement here on purpose: a craft a module brings is that module's to
 // describe, and inventing one for it would be exactly the paraphrase this file
 // forbids. Consumers must therefore treat "no statement" as normal, not as an error.
 const ROLE_RESPONSIBILITIES = Object.freeze({
-  engineer: 'Running and optimizing the running of Claude nonstop, and ensuring Ideators and Artists can continue to interface with that system effectively.',
-  artist: 'No slop in the appearance and text of the project; the story, emotion and ideology of the project are communicated effectively; project purpose and gravitas are upheld.',
-  ideator: 'Make good ideas; be a philosopher / thought leader for the project; enable Engineers to scope and Artists to create with maximum efficiency — a baseline for creating scopes of work.',
+  artisan: 'Running and optimizing the running of Claude nonstop, and ensuring Artists can continue to interface with that system effectively.',
+  // The artist holds both of the owner's sentences since the ideator folded in
+  // (task 1005141, BONGOS-V3): the craft names changed, the words did not.
+  artist: 'No slop in the appearance and text of the project; the story, emotion and ideology of the project are communicated effectively; project purpose and gravitas are upheld. Make good ideas; be a philosopher / thought leader for the project; enable Artisans to scope and Artists to create with maximum efficiency — a baseline for creating scopes of work.',
 });
 
 // Provenance, carried with the text so every rendering can say where it came from

package/tests/acclaim_feed_evidence_db.mjs

@@ -111,7 +111,7 @@ try {
   ]) {
     await q(
       `INSERT INTO tasks (id, version_id, title, status, shipped_by, shipped_at, discipline, kind)
-       VALUES ($1, $2, $3, 'shipped', $4, now(), 'engineer', 'feature')`,
+       VALUES ($1, $2, $3, 'shipped', $4, now(), 'artisan', 'feature')`,
       [id, VER, title, SHIPPER],
     );
   }

package/tests/activity_rollup_as_of.mjs

@@ -57,7 +57,7 @@ const pin = (rel, exports) => {
 await t('reportActivityRollup sends Bongos-Report-As-Of, stamped before the totals were read', async () => {
   const senderPool = mockPool((sql) => {
     if (/FROM builders WHERE id/.test(sql)) {
-      return { rows: [{ github_id: 42, total_credits: 7, karma: 1, rank: 'metic', preferred_disciplines: ['engineer'] }] };
+      return { rows: [{ github_id: 42, total_credits: 7, karma: 1, rank: 'metic', preferred_disciplines: ['artisan'] }] };
     }
     if (/count\(\*\)/.test(sql)) return { rows: [{ n: 3 }] };
     return { rows: [] };

package/tests/api_alias_caller_ratchet.mjs

@@ -89,7 +89,7 @@ test('the exclusions are real and each one is reachable', () => {
     'docs/architecture.md',
     'docs/canonical-permissions.md',
     'docs/recipes/parallel-goal-waves.md',
-    'docs/packs/engineer.md',
+    'docs/packs/artisan.md',
     'docs/onboarding/drachmae-and-karma.md',
   ]) {
     assert.equal(scan.isExcludedPath(p), false, `${p} must NOT be excluded`);
@@ -112,11 +112,11 @@ test('docs/ is SPLIT: the frozen record stays out, live instruction is now count
     'docs/governance/rank-map-2026-08-06.md': 'GET /api/gds/tasks\n',
     'docs/recipes/failed-ship-recovery-proof.md': 'POST /api/gds/claims/1/resolve\n',
     'docs/recipes/how-to-do-a-thing.md': 'node scripts/bongos/api.js GET /api/gds/tasks/1\n',
-    'docs/packs/engineer.md': 'create a task via POST /api/gds/tasks\n',
+    'docs/packs/artisan.md': 'create a task via POST /api/gds/tasks\n',
   }));
   assert.deepEqual(
     Object.keys(r.byFile).sort(),
-    ['docs/packs/engineer.md', 'docs/recipes/how-to-do-a-thing.md'],
+    ['docs/packs/artisan.md', 'docs/recipes/how-to-do-a-thing.md'],
     'only the instructional docs count — and they MUST count, or the narrowing did nothing',
   );
   assert.equal(r.total, 2);

package/tests/application_lifecycle.mjs

@@ -661,7 +661,7 @@ test('list-pending: the real vouch writer’s row resolves its profile and guild
 
 test('list-pending: a vouched TAKEOVER resolves the vouched applicant, not whoever filed first', async () => {
   reset();
-  hubViews['8001'] = { profile: { view: 'sliver', sliver: { disciplines: ['engineer'] } }, guild: null };
+  hubViews['8001'] = { profile: { view: 'sliver', sliver: { disciplines: ['artisan'] } }, guild: null };
   await applyAs('ada', { [VOUCH_HEADER]: vouchFor('ada', { githubId: 8001, handle: 'ada-h' }) });
   const r = await call('GET', '/api/gds/access-requests');
   const ada = r.json.requests.find((x) => x.github_login === 'ada');

package/tests/artist_review.mjs

@@ -214,7 +214,7 @@ test('the panel names a public page as site:<first path segment>, and its ideas
 
 test('the public button and the hall palette wear one name', () => {
   const craft = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/craft-mode.js'), 'utf8');
-  const tool = /id: 'palette', icon: 'artistry', short: '([^']+)', label: '([^']+)'/.exec(craft);
+  const tool = /id: 'palette', icon: '[^']+', short: '([^']+)', label: '([^']+)'/.exec(craft);
   assert.ok(tool, 'the palette tool');
   assert.ok(LOADER.includes("var SHORT = '" + tool[1] + "';"), 'the short name');
   assert.ok(LOADER.includes("var LABEL = '" + tool[2] + "';"), 'the full name');

package/tests/artist_review_goal.mjs

@@ -100,7 +100,7 @@ await test('createTask with artistReview lands in the goal; without one the catc
   await createTask({ versionId: 'BONGOS-V3', title: 'Tweak: Home (builders:home)', discipline: 'artist', artistReview: true }, { client: c });
   assert.equal(c.state.tasks[0].goal_id, 91, 'the studio task names the artist review goal');
   await assert.rejects(
-    () => createTask({ versionId: 'BONGOS-V3', title: 'plain', discipline: 'engineer' }, { client: fakeClient() }),
+    () => createTask({ versionId: 'BONGOS-V3', title: 'plain', discipline: 'artisan' }, { client: fakeClient() }),
     /goalId is required/, 'an ordinary goal-less create still throws');
 });
 

package/tests/blocker_hall_live_proof.mjs

@@ -183,7 +183,7 @@ async function seed() {
   // since core_247 (task 1002988); every real create path resolves one.
   await q(
     `INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,discipline)
-     VALUES ($1,$2,'bhlp fixture task','ready',10,'feature','engineer')`,
+     VALUES ($1,$2,'bhlp fixture task','ready',10,'feature','artisan')`,
     [TASK, VER],
   );
 }

package/tests/blocker_tasks_named_db.mjs

@@ -43,8 +43,8 @@ try {
   await q(`INSERT INTO versions (id,name,status,track) VALUES ($1,'names','shipped','internal') ON CONFLICT (id) DO NOTHING`, [VER]);
   // T2 first and with no name: the read must order by id and keep a null name.
   await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,discipline,short_name)
-           VALUES ($1,$3,'Payout approvals','backlog',10,'feature','engineer','payout approvals'),
-                  ($2,$3,'#12','backlog',10,'feature','engineer',NULL)`, [T1, T2, VER]);
+           VALUES ($1,$3,'Payout approvals','backlog',10,'feature','artisan','payout approvals'),
+                  ($2,$3,'#12','backlog',10,'feature','artisan',NULL)`, [T1, T2, VER]);
   const holding = await blockers.createBlocker({ title: 'names fixture: holds two', bodyMd: '', source: 'test', sourceRef: `${REF}-a` });
   const empty = await blockers.createBlocker({ title: 'names fixture: holds none', bodyMd: '', source: 'test', sourceRef: `${REF}-b` });
   await blockers.linkBlockerToTask({ blockerId: holding.id, taskId: T2 }); // linked out of id order on purpose

package/tests/canonical_profile_url.mjs

@@ -280,7 +280,7 @@ const BUILDER = {
   total_credits: 12,
   karma: 3,
   created_at: '2026-01-01T00:00:00.000Z',
-  preferred_disciplines: ['engineer'],
+  preferred_disciplines: ['artisan'],
   // The private columns the whitelist exists to keep out. Sentinel values so a
   // raw-text scan of the serialized body bites even if a key were renamed.
   anthropic_email: 'SENTINEL-anthropic-email',

package/tests/cap_newcomer_tasks.mjs

@@ -23,31 +23,31 @@ function t(name, fn) {
 
 // A claimable feed row (only the fields capNewcomerTasks reads).
 const nc = (id, discipline) => ({ id, discipline, newcomer_friendly: true });
-const real = (id, discipline = 'engineer') => ({ id, discipline, newcomer_friendly: false });
+const real = (id, discipline = 'artisan') => ({ id, discipline, newcomer_friendly: false });
 const ids = (rows) => rows.map((r) => r.id);
 
-// ---- the reported case: 3 artist + 2 ideator newcomer seats ----
-t('caps an artist+ideator pool of 5 down to 3, both lanes represented', () => {
+// ---- the reported case: 3 artist + 2 artisan newcomer seats (was ideator before task 1005141 folded it into artist) ----
+t('caps an artist+artisan pool of 5 down to 3, both lanes represented', () => {
   const feed = [
     nc(1259, 'artist'), nc(1260, 'artist'), nc(1261, 'artist'),
-    nc(1176, 'ideator'), nc(1177, 'ideator'),
+    nc(1176, 'artisan'), nc(1177, 'artisan'),
   ];
   const out = capNewcomerTasks(feed);
   assert.equal(out.length, 3, 'exactly 3 newcomer rows kept');
-  // Round-robin SELECTS artist[0]=1259, ideator[0]=1176, artist[1]=1260; the
+  // Round-robin SELECTS artist[0]=1259, artisan[0]=1176, artist[1]=1260; the
   // output preserves INPUT order (we filter the ordered array), so 1260 (which
   // came before 1176 in the feed) lands ahead of it.
   assert.deepEqual(ids(out), [1259, 1260, 1176]);
   // Both disciplines are represented before a duplicate fills the third slot.
   const disciplines = new Set(out.map((r) => r.discipline));
-  assert.ok(disciplines.has('artist') && disciplines.has('ideator'));
+  assert.ok(disciplines.has('artist') && disciplines.has('artisan'));
 });
 
 // ---- non-newcomer (real) rows are never dropped ----
 t('real version tasks pass through untouched and unbounded', () => {
   const feed = [
     real(900), real(901), real(902), real(903),
-    nc(1259, 'artist'), nc(1260, 'artist'), nc(1261, 'artist'), nc(1176, 'ideator'),
+    nc(1259, 'artist'), nc(1260, 'artist'), nc(1261, 'artist'), nc(1176, 'artisan'),
   ];
   const out = capNewcomerTasks(feed);
   const reals = out.filter((r) => r.newcomer_friendly !== true);
@@ -59,19 +59,19 @@ t('real version tasks pass through untouched and unbounded', () => {
 // ---- ordering is preserved (we filter the input array, not re-sort) ----
 t('preserves original feed ordering across mixed rows', () => {
   const feed = [
-    real(900), nc(1259, 'artist'), real(901), nc(1176, 'ideator'),
-    nc(1260, 'artist'), nc(1261, 'artist'), nc(1177, 'ideator'),
+    real(900), nc(1259, 'artist'), real(901), nc(1176, 'artisan'),
+    nc(1260, 'artist'), nc(1261, 'artist'), nc(1177, 'artisan'),
   ];
   const out = capNewcomerTasks(feed);
-  // Kept newcomer ids (round-robin over [artist, ideator] groups by appearance):
-  //   artist[0]=1259, ideator[0]=1176, artist[1]=1260.
+  // Kept newcomer ids (round-robin over [artist, artisan] groups by appearance):
+  //   artist[0]=1259, artisan[0]=1176, artist[1]=1260.
   // Output keeps input order, dropping only un-kept newcomer rows (1261, 1177).
   assert.deepEqual(ids(out), [900, 1259, 901, 1176, 1260]);
 });
 
 // ---- no-op when at or under the cap ----
 t('returns the list unchanged when newcomer rows <= cap', () => {
-  const feed = [nc(1, 'artist'), nc(2, 'ideator'), real(3)];
+  const feed = [nc(1, 'artist'), nc(2, 'artisan'), real(3)];
   const out = capNewcomerTasks(feed);
   assert.equal(out.length, 3);
   assert.deepEqual(ids(out), [1, 2, 3]);
@@ -106,7 +106,7 @@ t('tolerates non-array input', () => {
 
 // ---- custom cap argument ----
 t('honors a custom cap', () => {
-  const feed = [nc(1, 'artist'), nc(2, 'ideator'), nc(3, 'artist'), nc(4, 'ideator')];
+  const feed = [nc(1, 'artist'), nc(2, 'artisan'), nc(3, 'artist'), nc(4, 'artisan')];
   assert.equal(capNewcomerTasks(feed, 2).length, 2);
   assert.deepEqual(ids(capNewcomerTasks(feed, 2)), [1, 2]);
 });