@bevel-software/platform-core-frontend 0.4.1 → 0.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (327) hide show
  1. package/THIRD-PARTY-NOTICES.md +5366 -0
  2. package/package.json +7 -4
  3. package/src/core/CoreAppShell.tsx +195 -56
  4. package/src/core/__tests__/AppChrome.test.tsx +125 -0
  5. package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
  6. package/src/core/__tests__/bootstrap.test.ts +63 -0
  7. package/src/core/bootstrap.ts +73 -0
  8. package/src/core/events.ts +12 -0
  9. package/src/core/registry.ts +58 -9
  10. package/src/index.css +100 -11
  11. package/src/index.ts +24 -23
  12. package/src/lib/utils.ts +93 -117
  13. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
  15. package/src/modules/access/api.ts +49 -0
  16. package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
  17. package/src/modules/access/hooks/useFileAccess.ts +1 -1
  18. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
  19. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
  20. package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
  21. package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
  22. package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
  23. package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
  24. package/src/modules/admin/state/admin.context.tsx +15 -6
  25. package/src/modules/auth/components/AccountPage.tsx +11 -11
  26. package/src/modules/auth/components/LoginScreen.tsx +12 -12
  27. package/src/modules/auth/services/sso.ts +47 -1
  28. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
  29. package/src/modules/change-requests/__tests__/author.test.ts +48 -0
  30. package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
  31. package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
  32. package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
  33. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
  34. package/src/modules/change-requests/change-requests.css +22 -0
  35. package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
  36. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
  37. package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
  38. package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
  39. package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
  40. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
  41. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
  42. package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
  43. package/src/modules/change-requests/services/change-requests.api.ts +45 -0
  44. package/src/modules/change-requests/services/propose.api.ts +162 -0
  45. package/src/modules/change-requests/utils/author.ts +47 -0
  46. package/src/modules/change-requests/utils/conflict.ts +38 -0
  47. package/src/modules/change-requests/utils/diff.ts +80 -0
  48. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
  49. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
  50. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
  51. package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
  52. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
  53. package/src/modules/git/components/BranchSwitcher.tsx +68 -31
  54. package/src/modules/git/components/DiffView.tsx +4 -4
  55. package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
  56. package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
  57. package/src/modules/git/components/PullNeededBanner.tsx +6 -13
  58. package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
  59. package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
  60. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
  61. package/src/modules/git/hooks/useGitState.ts +15 -14
  62. package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
  63. package/src/modules/git/services/error-messages.ts +7 -7
  64. package/src/modules/git/services/git.api.ts +17 -11
  65. package/src/modules/git/services/pr-prompts.ts +2 -2
  66. package/src/modules/git/state/git.context.ts +10 -1
  67. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
  68. package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
  69. package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
  70. package/src/modules/layout/breakpoints.ts +6 -0
  71. package/src/modules/layout/components/AppLayout.tsx +17 -5
  72. package/src/modules/layout/components/DemoBanner.tsx +10 -1
  73. package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
  74. package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
  75. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
  76. package/src/modules/layout/components/SidebarFrame.tsx +317 -0
  77. package/src/modules/layout/components/SidebarToggle.tsx +86 -0
  78. package/src/modules/layout/components/SlideOverlay.tsx +1 -1
  79. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
  80. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
  81. package/src/modules/layout/state/sidebar.ts +200 -0
  82. package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
  83. package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
  84. package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
  85. package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
  86. package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
  87. package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
  88. package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
  89. package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
  90. package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
  91. package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
  92. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
  93. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
  94. package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
  95. package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
  96. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
  97. package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
  98. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
  99. package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
  100. package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
  101. package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
  102. package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
  103. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
  104. package/src/modules/library/__tests__/auth-harness.tsx +37 -0
  105. package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
  106. package/src/modules/library/__tests__/status.test.ts +113 -20
  107. package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
  108. package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
  109. package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
  110. package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
  111. package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
  112. package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
  113. package/src/modules/library/components/GroupIndexRow.tsx +63 -0
  114. package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
  115. package/src/modules/library/components/GroupPage.tsx +373 -0
  116. package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
  117. package/src/modules/library/components/GroupsSidebar.tsx +338 -0
  118. package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
  119. package/src/modules/library/components/LibraryCard.tsx +123 -102
  120. package/src/modules/library/components/LibraryLayout.tsx +344 -0
  121. package/src/modules/library/components/LibraryPage.tsx +111 -227
  122. package/src/modules/library/components/LockGlyph.tsx +31 -0
  123. package/src/modules/library/components/LockedGroupView.tsx +159 -0
  124. package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
  125. package/src/modules/library/components/NewGroupDialog.tsx +112 -0
  126. package/src/modules/library/components/NewSkillPanel.tsx +151 -0
  127. package/src/modules/library/components/PageActions.tsx +156 -0
  128. package/src/modules/library/components/PendingSkillReview.tsx +63 -0
  129. package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
  130. package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
  131. package/src/modules/library/components/StatusDot.tsx +25 -0
  132. package/src/modules/library/components/ToolLogo.tsx +171 -0
  133. package/src/modules/library/components/group-page-parts.tsx +419 -0
  134. package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
  135. package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
  136. package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
  137. package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
  138. package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
  139. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
  140. package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
  141. package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
  142. package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
  143. package/src/modules/library/hooks/useJoinRequests.ts +114 -0
  144. package/src/modules/library/hooks/useLibraryData.ts +134 -119
  145. package/src/modules/library/hooks/useSkillDetail.ts +119 -74
  146. package/src/modules/library/hooks/useToolPage.ts +145 -0
  147. package/src/modules/library/library.css +33 -245
  148. package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
  149. package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
  150. package/src/modules/library/routes/library-paths.ts +191 -0
  151. package/src/modules/library/services/groups.api.ts +189 -0
  152. package/src/modules/library/services/library.api.ts +291 -164
  153. package/src/modules/library/services/tools.api.ts +60 -0
  154. package/src/modules/library/state/library-context.ts +22 -0
  155. package/src/modules/library/state/library-data.tsx +223 -0
  156. package/src/modules/library/state/toast.context.ts +32 -0
  157. package/src/modules/library/state/toast.tsx +84 -42
  158. package/src/modules/library/utils/clipboard.ts +33 -0
  159. package/src/modules/library/utils/group-summary.ts +68 -0
  160. package/src/modules/library/utils/names.ts +30 -0
  161. package/src/modules/library/utils/navigate-external.ts +15 -0
  162. package/src/modules/library/utils/oauth-fragment.ts +32 -0
  163. package/src/modules/library/utils/personal-group.ts +36 -0
  164. package/src/modules/library/utils/status.ts +108 -25
  165. package/src/modules/library/utils/toast-duration.ts +16 -0
  166. package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
  167. package/src/modules/onboarding/agent-clients.ts +48 -0
  168. package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
  169. package/src/modules/onboarding/components/RootLanding.tsx +54 -0
  170. package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
  171. package/src/modules/onboarding/paths.ts +9 -0
  172. package/src/modules/onboarding/state/onboarding.ts +191 -0
  173. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
  174. package/src/modules/pr/services/pr-approvals.api.ts +19 -0
  175. package/src/modules/pr/services/pr-cancel.api.ts +11 -0
  176. package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
  177. package/src/modules/review/components/DiffViewer.tsx +4 -4
  178. package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
  179. package/src/modules/review/components/ReviewFileRow.tsx +10 -10
  180. package/src/modules/review/components/ReviewPanel.tsx +49 -17
  181. package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
  182. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
  183. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
  184. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
  185. package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
  186. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
  187. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
  188. package/src/modules/secrets-vault/services/connect.api.ts +24 -3
  189. package/src/modules/settings/components/DeploymentPage.tsx +90 -0
  190. package/src/modules/settings/components/SettingsLayout.tsx +135 -0
  191. package/src/modules/settings/components/SettingsNav.tsx +114 -0
  192. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
  193. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
  194. package/src/modules/settings/settings-nav-items.tsx +166 -0
  195. package/src/modules/setup/__tests__/setup.test.tsx +540 -0
  196. package/src/modules/setup/components/SetupGate.tsx +67 -0
  197. package/src/modules/setup/components/SetupScreen.tsx +573 -0
  198. package/src/modules/setup/services/setup.api.ts +106 -0
  199. package/src/modules/setup/utils/git-host.ts +34 -0
  200. package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
  201. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
  202. package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
  203. package/src/modules/toolbar/components/Toolbar.tsx +56 -54
  204. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
  205. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
  206. package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
  207. package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
  208. package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
  209. package/src/modules/workspace/components/EditorTabs.tsx +82 -50
  210. package/src/modules/workspace/components/FileExplorer.tsx +413 -189
  211. package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
  212. package/src/modules/workspace/components/FileRoute.tsx +89 -84
  213. package/src/modules/workspace/components/FileViewer.tsx +700 -294
  214. package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
  215. package/src/modules/workspace/components/KbFileRail.tsx +128 -0
  216. package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
  217. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
  218. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
  219. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
  220. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
  221. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
  222. package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
  223. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
  224. package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
  225. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
  226. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
  227. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
  228. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
  229. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
  230. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
  231. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
  232. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
  233. package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
  234. package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
  235. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
  236. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
  237. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
  238. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
  239. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
  240. package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
  241. package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
  242. package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
  243. package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
  244. package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
  245. package/src/modules/workspace/components/renderers/index.ts +78 -2
  246. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
  247. package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
  248. package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
  249. package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
  250. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
  251. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
  252. package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
  253. package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
  254. package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
  255. package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
  256. package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
  257. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
  258. package/src/modules/workspace/services/workspace.api.ts +9 -2
  259. package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
  260. package/src/modules/workspace/state/open-change-requests.tsx +185 -0
  261. package/src/modules/workspace/state/workspace.context.ts +9 -0
  262. package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
  263. package/src/modules/workspace/utils/diff.ts +130 -53
  264. package/src/modules/workspace/utils/fileTree.ts +7 -4
  265. package/src/modules/workspace/workspace.css +28 -0
  266. package/src/shared/components/Badge.tsx +62 -0
  267. package/src/shared/components/Banner.tsx +58 -0
  268. package/src/shared/components/Button.tsx +90 -0
  269. package/src/shared/components/Dialog.tsx +6 -6
  270. package/src/shared/components/Field.tsx +45 -0
  271. package/src/shared/components/IconButton.tsx +74 -0
  272. package/src/shared/components/ListRow.tsx +96 -0
  273. package/src/shared/components/Menu.tsx +88 -0
  274. package/src/shared/components/PageShell.tsx +8 -5
  275. package/src/shared/components/Surface.tsx +86 -0
  276. package/src/shared/components/__tests__/primitives.test.tsx +333 -0
  277. package/src/shared/components/index.ts +48 -0
  278. package/src/shared/components/useDismissableMenu.ts +71 -0
  279. package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
  280. package/src/shared/theme/index.css +12 -0
  281. package/src/shared/theme/measure.ts +64 -0
  282. package/src/shared/theme/shadows.css +34 -0
  283. package/src/shared/theme/tokens.css +193 -0
  284. package/src/test-setup.ts +9 -0
  285. package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
  286. package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
  287. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
  288. package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
  289. package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
  290. package/src/modules/library/__tests__/diff.test.ts +0 -62
  291. package/src/modules/library/__tests__/loadout.test.tsx +0 -72
  292. package/src/modules/library/components/CompareView.tsx +0 -357
  293. package/src/modules/library/components/DetailDialog.tsx +0 -566
  294. package/src/modules/library/components/GearIcon.tsx +0 -12
  295. package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
  296. package/src/modules/library/components/StatusGem.tsx +0 -21
  297. package/src/modules/library/components/SuggestChange.tsx +0 -171
  298. package/src/modules/library/components/particles.ts +0 -50
  299. package/src/modules/library/state/loadout.tsx +0 -129
  300. package/src/modules/library/utils/diff.ts +0 -102
  301. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
  302. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
  303. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
  304. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
  305. package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
  306. package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
  307. package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
  308. package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
  309. package/src/modules/pr/components/PrCancelButton.tsx +0 -99
  310. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
  311. package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
  312. package/src/modules/pr/components/PrCommentThread.tsx +0 -168
  313. package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
  314. package/src/modules/pr/components/PrDiffPane.tsx +0 -425
  315. package/src/modules/pr/components/PrFileRow.tsx +0 -164
  316. package/src/modules/pr/components/PrFilesList.tsx +0 -53
  317. package/src/modules/pr/components/PrHeader.tsx +0 -45
  318. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
  319. package/src/modules/pr/components/PrMergeButton.tsx +0 -268
  320. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
  321. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
  322. package/src/modules/pr/components/PrViewer.tsx +0 -364
  323. package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
  324. package/src/modules/pr/state/pr-viewer.context.ts +0 -34
  325. package/src/modules/pr/utils/bucketize-comments.ts +0 -55
  326. package/src/modules/pr/utils/parsePatch.ts +0 -57
  327. package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
@@ -0,0 +1,249 @@
1
+ import type { ReactNode } from 'react';
2
+ import { describe, it, expect, beforeEach, vi } from 'vitest';
3
+ import { render, screen, within } from '@testing-library/react';
4
+ import userEvent from '@testing-library/user-event';
5
+ import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
6
+ import { SettingsLayout } from '../SettingsLayout';
7
+ import { AdminContext, type AdminContextValue } from '../../../admin/state/admin.context';
8
+ import { SIDEBAR_DOM_ID } from '../../../layout/components/SidebarFrame';
9
+ import { setSidebarCollapsed } from '../../../layout/state/sidebar';
10
+ import { AppRegistryContext, makeRegistry, type AdminMenuItem } from '../../../../core/registry';
11
+
12
+ /**
13
+ * The settings nav's contract.
14
+ *
15
+ * The load-bearing case is "the nav survives the click" — the exact inverse of
16
+ * the profile menu's `panelGone()`, and the regression test for the bug this
17
+ * layout exists to fix.
18
+ *
19
+ * Renders `SettingsLayout` as a real layout route over STUB children, so no
20
+ * real settings page mounts and the suite needs no API mocks and no provider
21
+ * stack beyond the two contexts under test.
22
+ */
23
+
24
+ /**
25
+ * Two shapes the membership rule must REJECT, alongside a normal row: a
26
+ * dialog-only row (no URL, so it can be neither linked nor marked current),
27
+ * and an `onSelect` + off-surface `path` row — the enterprise shape that
28
+ * navigates somewhere else in the app.
29
+ */
30
+ const stubRows: AdminMenuItem[] = [
31
+ {
32
+ id: 'stub-dialog',
33
+ order: 10,
34
+ label: 'Stub dialog row',
35
+ dialog: ({ open }) => (open ? <div role="dialog" aria-label="Stub" /> : <></>),
36
+ },
37
+ {
38
+ id: 'stub-elsewhere',
39
+ order: 20,
40
+ label: 'Stub elsewhere row',
41
+ path: '/workspace/connectors',
42
+ onSelect: () => {},
43
+ },
44
+ ];
45
+
46
+ function LocationProbe() {
47
+ return <div data-testid="pathname">{useLocation().pathname}</div>;
48
+ }
49
+
50
+ /**
51
+ * The router subtree, built ONCE and shared by `renderAt` and the rerender
52
+ * below.
53
+ *
54
+ * React reconciles children by position and type, so a rerender that omits any
55
+ * of this — `LocationProbe`, a sibling route — replaces the subtree instead of
56
+ * updating it, and `SettingsLayout` remounts with the new props already baked
57
+ * in. A remounted component cannot be caught holding stale memoized state,
58
+ * which is the one thing the update test exists to catch. Sharing the builder
59
+ * is what makes "identical except for the AdminContext value" true by
60
+ * construction rather than by everyone remembering.
61
+ */
62
+ function routerTree(route: string) {
63
+ return (
64
+ <AppRegistryContext.Provider value={makeRegistry({ adminMenuItems: stubRows })}>
65
+ <MemoryRouter initialEntries={[route]}>
66
+ <LocationProbe />
67
+ <Routes>
68
+ <Route element={<SettingsLayout />}>
69
+ <Route path="/secrets" element={<div>Secrets stub</div>} />
70
+ <Route path="/account" element={<div>Account stub</div>} />
71
+ <Route path="/tools" element={<div>Tools stub</div>} />
72
+ <Route path="/external-agent-access" element={<div>Agent access stub</div>} />
73
+ <Route path="/roles-and-members" element={<div>Roles stub</div>} />
74
+ <Route path="/user-accounts" element={<div>User accounts stub</div>} />
75
+ </Route>
76
+ </Routes>
77
+ </MemoryRouter>
78
+ </AppRegistryContext.Provider>
79
+ );
80
+ }
81
+
82
+ function withAdmin(isAdmin: boolean, tree: ReactNode) {
83
+ return (
84
+ <AdminContext.Provider value={{ isAdmin } as AdminContextValue}>{tree}</AdminContext.Provider>
85
+ );
86
+ }
87
+
88
+ function renderAt(
89
+ route: string,
90
+ { isAdmin, withAdminContext = true }: { isAdmin?: boolean; withAdminContext?: boolean } = {},
91
+ ) {
92
+ const tree = routerTree(route);
93
+ if (!withAdminContext) return render(tree);
94
+ return render(withAdmin(!!isAdmin, tree));
95
+ }
96
+
97
+ const nav = () => screen.getByRole('navigation', { name: 'Settings' });
98
+ const noNav = () => screen.queryByRole('navigation', { name: 'Settings' });
99
+
100
+ /**
101
+ * `collapsed` is module state that `test-setup.ts` does not reset, and
102
+ * Toolbar.test.tsx mutates it — so it leaks across files in a run. A collapsed
103
+ * sidebar is `inert`, which would make every query here fail for a reason that
104
+ * has nothing to do with this suite.
105
+ */
106
+ beforeEach(() => setSidebarCollapsed(false));
107
+
108
+ describe('SettingsLayout', () => {
109
+ it('lists every settings destination', () => {
110
+ renderAt('/secrets');
111
+ const links = within(nav()).getAllByRole('link');
112
+ expect(links.map((l) => l.textContent)).toEqual([
113
+ 'External agent access',
114
+ 'Secrets',
115
+ 'Browse available tools',
116
+ 'Account',
117
+ ]);
118
+ });
119
+
120
+ it('marks the current destination, and only it', () => {
121
+ renderAt('/secrets');
122
+ expect(within(nav()).getByRole('link', { name: 'Secrets' })).toHaveAttribute(
123
+ 'aria-current',
124
+ 'page',
125
+ );
126
+ expect(within(nav()).getByRole('link', { name: 'Account' })).not.toHaveAttribute(
127
+ 'aria-current',
128
+ );
129
+ expect(
130
+ within(nav())
131
+ .getAllByRole('link')
132
+ .filter((l) => l.getAttribute('aria-current') === 'page'),
133
+ ).toHaveLength(1);
134
+ });
135
+
136
+ // THE REGRESSION TEST. The reported bug was that picking a destination made
137
+ // the list of destinations disappear.
138
+ it('keeps the nav on screen after navigating, and moves the current marker', async () => {
139
+ renderAt('/secrets');
140
+ await userEvent.click(within(nav()).getByRole('link', { name: 'Account' }));
141
+
142
+ expect(screen.getByTestId('pathname')).toHaveTextContent('/account');
143
+ expect(nav()).toBeInTheDocument();
144
+ expect(within(nav()).getByRole('link', { name: 'Account' })).toHaveAttribute(
145
+ 'aria-current',
146
+ 'page',
147
+ );
148
+ });
149
+
150
+ // React Router matches `/secrets/` to the route declared `/secrets`, so the
151
+ // page renders — but `useLocation().pathname` keeps the slash. Comparing it
152
+ // raw against the row paths marked NOTHING as current, on a page that is
153
+ // plainly one of the six.
154
+ it('marks the current destination when the URL carries a trailing slash', () => {
155
+ renderAt('/secrets/');
156
+ expect(within(nav()).getByRole('link', { name: 'Secrets' })).toHaveAttribute(
157
+ 'aria-current',
158
+ 'page',
159
+ );
160
+ });
161
+
162
+ it('excludes a registry row that only opens a dialog', () => {
163
+ renderAt('/secrets');
164
+ expect(within(nav()).queryByRole('link', { name: 'Stub dialog row' })).toBeNull();
165
+ });
166
+
167
+ // A settings nav that could navigate you into Knowledge would be a nav that
168
+ // replaces itself mid-click.
169
+ it('excludes a registry row pointing outside the settings surface', () => {
170
+ renderAt('/secrets');
171
+ expect(within(nav()).queryByRole('link', { name: 'Stub elsewhere row' })).toBeNull();
172
+ });
173
+
174
+ // This is what keeps ShellRoutes.test.tsx free of providers: the layout
175
+ // reads AdminContext directly rather than through useAdmin(), which throws.
176
+ it('renders with no AdminContext at all, as a non-admin', () => {
177
+ expect(() => renderAt('/secrets', { withAdminContext: false })).not.toThrow();
178
+ expect(within(nav()).queryByText('Admin only')).toBeNull();
179
+ expect(within(nav()).queryByRole('link', { name: 'Roles & Members' })).toBeNull();
180
+ });
181
+
182
+ it('hides the admin section from a non-admin', () => {
183
+ renderAt('/secrets', { isAdmin: false });
184
+ expect(within(nav()).queryByText('Admin only')).toBeNull();
185
+ expect(within(nav()).queryByRole('link', { name: 'Roles & Members' })).toBeNull();
186
+ expect(within(nav()).queryByRole('link', { name: 'User accounts' })).toBeNull();
187
+ });
188
+
189
+ it('shows the admin section to an admin', () => {
190
+ renderAt('/secrets', { isAdmin: true });
191
+ expect(within(nav()).getByText('Admin only')).toBeInTheDocument();
192
+ expect(within(nav()).getByRole('link', { name: 'Roles & Members' })).toBeInTheDocument();
193
+ expect(within(nav()).getByRole('link', { name: 'User accounts' })).toBeInTheDocument();
194
+ });
195
+
196
+ // isAdmin resolves asynchronously — the nav must not have baked in the
197
+ // starting `false`.
198
+ //
199
+ // Rerendered through the SAME `routerTree`, with only the AdminContext value
200
+ // changed, so the layout is UPDATED rather than replaced. The identity check
201
+ // below is what enforces that: a remount would build a new <nav> node, and
202
+ // the assertion after it would then be passing for the wrong reason — a
203
+ // fresh component reading `isAdmin: true` on its first render proves nothing
204
+ // about a memo going stale.
205
+ it('grows the admin section when isAdmin flips true after mount', () => {
206
+ const { rerender } = renderAt('/secrets', { isAdmin: false });
207
+ const navBefore = nav();
208
+ expect(within(navBefore).queryByRole('link', { name: 'Roles & Members' })).toBeNull();
209
+
210
+ rerender(withAdmin(true, routerTree('/secrets')));
211
+
212
+ expect(nav()).toBe(navBefore);
213
+ expect(within(nav()).getByRole('link', { name: 'Roles & Members' })).toBeInTheDocument();
214
+ });
215
+
216
+ describe('narrow windows', () => {
217
+ const stubMatchMedia = (matches: boolean) => {
218
+ vi.stubGlobal(
219
+ 'matchMedia',
220
+ vi.fn().mockImplementation((query: string) => ({
221
+ matches,
222
+ media: query,
223
+ addEventListener: vi.fn(),
224
+ removeEventListener: vi.fn(),
225
+ })),
226
+ );
227
+ };
228
+
229
+ it('fills the app sidebar frame on a wide window', () => {
230
+ stubMatchMedia(false);
231
+ renderAt('/secrets');
232
+ const frame = document.getElementById(SIDEBAR_DOM_ID);
233
+ expect(frame).not.toBeNull();
234
+ expect(frame).toContainElement(nav());
235
+ vi.unstubAllGlobals();
236
+ });
237
+
238
+ // The one-sidebar invariant on phones: a 212px rail on a 375px screen is
239
+ // most of the screen, so the rows become a strip and no frame is mounted.
240
+ it('becomes a strip with no sidebar frame on a narrow window', () => {
241
+ stubMatchMedia(true);
242
+ renderAt('/secrets');
243
+ expect(document.getElementById(SIDEBAR_DOM_ID)).toBeNull();
244
+ expect(noNav()).not.toBeNull();
245
+ expect(within(nav()).getAllByRole('link')).toHaveLength(4);
246
+ vi.unstubAllGlobals();
247
+ });
248
+ });
249
+ });
@@ -0,0 +1,166 @@
1
+ import { useMemo } from 'react';
2
+ import { Boxes, CircleUserRound, KeyRound, Lock, SlidersHorizontal, Users } from 'lucide-react';
3
+ import { useAppRegistry, type AdminMenuItem } from '../../core/registry';
4
+
5
+ /**
6
+ * The settings rows, and the one merge that orders them.
7
+ *
8
+ * This module exists so the profile dropdown and the settings nav read from
9
+ * ONE list. They are two renderers of the same set — the dropdown is the door,
10
+ * the nav is where you are once you are inside — and two lists would drift the
11
+ * first time somebody added a row to whichever file they had open.
12
+ *
13
+ * It deliberately does NOT live under `modules/workspace`: the design-system
14
+ * parity test walks that directory specifically.
15
+ */
16
+
17
+ /**
18
+ * The core menu rows. Everything else (Connectors, Watchlist, Routines,
19
+ * Connected apps, feedback, LLM configuration, …) is registry-contributed —
20
+ * see the enterprise shell's `adminMenuItems`. The `order` values interleave
21
+ * the two lists to reproduce the historical row order. In THIS repo the
22
+ * registry is empty (`makeRegistry({})`), so the menu is these six rows and no
23
+ * more; the enterprise app gets all thirteen.
24
+ *
25
+ * Skills & Tools is deliberately NOT here. It is an APP (see `CORE_APPS` in
26
+ * CoreAppShell), and apps belong to the app switcher — which already lists it
27
+ * and marks it as current. Listing it here too made one destination answerable
28
+ * from two different menus, and only one of them could show you were already
29
+ * in it. Do not re-add it.
30
+ *
31
+ * Every core row is DATA: a `path`, not an `onSelect` closure that navigates
32
+ * to one. The closures said the same thing twice — where the row goes, and how
33
+ * to go there — and only the second half was legible to anything that was not
34
+ * a click. The `dialog` and `onSelect` contracts on {@link AdminMenuItem} stay
35
+ * fully supported for registry-contributed rows.
36
+ */
37
+ export const CORE_MENU_ITEMS: AdminMenuItem[] = [
38
+ {
39
+ id: 'external-agent-access',
40
+ order: 40,
41
+ icon: <KeyRound size={15} />,
42
+ label: 'External agent access',
43
+ path: '/external-agent-access',
44
+ },
45
+ {
46
+ id: 'secrets',
47
+ order: 50,
48
+ icon: <Lock size={15} />,
49
+ label: 'Secrets',
50
+ path: '/secrets',
51
+ },
52
+ {
53
+ id: 'browse-tools',
54
+ order: 70,
55
+ icon: <Boxes size={15} />,
56
+ label: 'Browse available tools',
57
+ path: '/tools',
58
+ },
59
+ {
60
+ id: 'account',
61
+ order: 90,
62
+ icon: <CircleUserRound size={15} />,
63
+ label: 'Account',
64
+ path: '/account',
65
+ },
66
+ {
67
+ id: 'deployment',
68
+ section: 'admin',
69
+ order: 5,
70
+ icon: <SlidersHorizontal size={15} />,
71
+ label: 'Deployment',
72
+ path: '/deployment',
73
+ },
74
+ {
75
+ id: 'roles-members',
76
+ section: 'admin',
77
+ order: 10,
78
+ icon: <Users size={15} />,
79
+ label: 'Roles & Members',
80
+ path: '/roles-and-members',
81
+ },
82
+ {
83
+ id: 'user-accounts',
84
+ section: 'admin',
85
+ order: 20,
86
+ icon: <CircleUserRound size={15} />,
87
+ label: 'User accounts',
88
+ path: '/user-accounts',
89
+ },
90
+ ];
91
+
92
+ /**
93
+ * The routes {@link SettingsLayout} wraps, and the gate the toolbar uses to
94
+ * decide whether this surface has a sidebar to toggle.
95
+ *
96
+ * DERIVED from the rows above rather than written out again. These were the
97
+ * same six strings in two places, and two places is where a seventh settings
98
+ * page gets added to one of them: the row would appear in the dropdown, and
99
+ * the page it opened would have no nav and no toggle — exactly the bug this
100
+ * module exists to prevent, reintroduced one route at a time.
101
+ *
102
+ * The consequence is a rule worth having: a settings page reaches the nav by
103
+ * having a row, and a settings page with no way to navigate to it is the
104
+ * original bug. `/connect` is outside this set for that reason — it is a flow
105
+ * page with no row, an OAuth landing target whose agent-connect mode has
106
+ * somebody else blocked on a Finish button.
107
+ */
108
+ export const SETTINGS_NAV_PATHS: readonly string[] = CORE_MENU_ITEMS.map(
109
+ (item) => item.path,
110
+ ).filter((path): path is string => !!path);
111
+
112
+ /**
113
+ * `/secrets/` and `/secrets` are the SAME destination, so they must compare
114
+ * equal here.
115
+ *
116
+ * React Router already treats them as one: `compilePath` ends an `end: true`
117
+ * pattern with `\/*$`, so the route declared `/secrets` matches both and the
118
+ * page renders either way. But `useLocation().pathname` reports the URL as it
119
+ * actually is, trailing slash included — and everything below compares that
120
+ * string against the paths above. Untreated, arriving at `/secrets/` (a typed
121
+ * URL, an old bookmark, an OAuth redirect that appended one) gives you the
122
+ * settings page with no sidebar toggle in the toolbar and no row marked
123
+ * current: the page renders, its navigation does not.
124
+ *
125
+ * Root keeps its slash. Stripping `/` leaves the empty string, which is not a
126
+ * path — and no settings row is at the root anyway.
127
+ */
128
+ export function normalizeSettingsPath(pathname: string): string {
129
+ return pathname.length > 1 ? pathname.replace(/\/+$/, '') : pathname;
130
+ }
131
+
132
+ /**
133
+ * Exact match, never a prefix. These are exact routes, and the nav marks the
134
+ * current row by comparing the whole pathname — a prefix test would light up
135
+ * `/account` for a hypothetical `/accounts-of-other-people`. Exact AFTER
136
+ * normalizing the trailing slash, which is a spelling of the same path rather
137
+ * than a different one.
138
+ */
139
+ export function isSettingsNavPath(pathname: string): boolean {
140
+ return SETTINGS_NAV_PATHS.includes(normalizeSettingsPath(pathname));
141
+ }
142
+
143
+ export interface MenuSections {
144
+ defaultItems: AdminMenuItem[];
145
+ adminItems: AdminMenuItem[];
146
+ }
147
+
148
+ /**
149
+ * Core rows merged with the registry's, split by section and sorted.
150
+ *
151
+ * The semantics here are frozen, because enterprise `order` values are tuned
152
+ * against these exact defaults: core rows come first in the input array and
153
+ * `Array.prototype.sort` is stable, so a tie resolves core-before-registry;
154
+ * a row with no `section` is a default row; a row with no `order` sorts at 100.
155
+ */
156
+ export function useMenuSections(): MenuSections {
157
+ const registry = useAppRegistry();
158
+ return useMemo(() => {
159
+ const all = [...CORE_MENU_ITEMS, ...registry.adminMenuItems];
160
+ const bySection = (section: 'default' | 'admin') =>
161
+ all
162
+ .filter((item) => (item.section ?? 'default') === section)
163
+ .sort((a, b) => (a.order ?? 100) - (b.order ?? 100));
164
+ return { defaultItems: bySection('default'), adminItems: bySection('admin') };
165
+ }, [registry]);
166
+ }