@bevel-software/platform-core-frontend 0.4.1 → 0.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (327) hide show
  1. package/THIRD-PARTY-NOTICES.md +5366 -0
  2. package/package.json +7 -4
  3. package/src/core/CoreAppShell.tsx +195 -56
  4. package/src/core/__tests__/AppChrome.test.tsx +125 -0
  5. package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
  6. package/src/core/__tests__/bootstrap.test.ts +63 -0
  7. package/src/core/bootstrap.ts +73 -0
  8. package/src/core/events.ts +12 -0
  9. package/src/core/registry.ts +58 -9
  10. package/src/index.css +100 -11
  11. package/src/index.ts +24 -23
  12. package/src/lib/utils.ts +93 -117
  13. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
  15. package/src/modules/access/api.ts +49 -0
  16. package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
  17. package/src/modules/access/hooks/useFileAccess.ts +1 -1
  18. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
  19. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
  20. package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
  21. package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
  22. package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
  23. package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
  24. package/src/modules/admin/state/admin.context.tsx +15 -6
  25. package/src/modules/auth/components/AccountPage.tsx +11 -11
  26. package/src/modules/auth/components/LoginScreen.tsx +12 -12
  27. package/src/modules/auth/services/sso.ts +47 -1
  28. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
  29. package/src/modules/change-requests/__tests__/author.test.ts +48 -0
  30. package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
  31. package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
  32. package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
  33. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
  34. package/src/modules/change-requests/change-requests.css +22 -0
  35. package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
  36. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
  37. package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
  38. package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
  39. package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
  40. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
  41. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
  42. package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
  43. package/src/modules/change-requests/services/change-requests.api.ts +45 -0
  44. package/src/modules/change-requests/services/propose.api.ts +162 -0
  45. package/src/modules/change-requests/utils/author.ts +47 -0
  46. package/src/modules/change-requests/utils/conflict.ts +38 -0
  47. package/src/modules/change-requests/utils/diff.ts +80 -0
  48. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
  49. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
  50. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
  51. package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
  52. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
  53. package/src/modules/git/components/BranchSwitcher.tsx +68 -31
  54. package/src/modules/git/components/DiffView.tsx +4 -4
  55. package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
  56. package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
  57. package/src/modules/git/components/PullNeededBanner.tsx +6 -13
  58. package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
  59. package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
  60. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
  61. package/src/modules/git/hooks/useGitState.ts +15 -14
  62. package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
  63. package/src/modules/git/services/error-messages.ts +7 -7
  64. package/src/modules/git/services/git.api.ts +17 -11
  65. package/src/modules/git/services/pr-prompts.ts +2 -2
  66. package/src/modules/git/state/git.context.ts +10 -1
  67. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
  68. package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
  69. package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
  70. package/src/modules/layout/breakpoints.ts +6 -0
  71. package/src/modules/layout/components/AppLayout.tsx +17 -5
  72. package/src/modules/layout/components/DemoBanner.tsx +10 -1
  73. package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
  74. package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
  75. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
  76. package/src/modules/layout/components/SidebarFrame.tsx +317 -0
  77. package/src/modules/layout/components/SidebarToggle.tsx +86 -0
  78. package/src/modules/layout/components/SlideOverlay.tsx +1 -1
  79. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
  80. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
  81. package/src/modules/layout/state/sidebar.ts +200 -0
  82. package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
  83. package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
  84. package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
  85. package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
  86. package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
  87. package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
  88. package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
  89. package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
  90. package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
  91. package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
  92. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
  93. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
  94. package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
  95. package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
  96. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
  97. package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
  98. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
  99. package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
  100. package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
  101. package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
  102. package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
  103. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
  104. package/src/modules/library/__tests__/auth-harness.tsx +37 -0
  105. package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
  106. package/src/modules/library/__tests__/status.test.ts +113 -20
  107. package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
  108. package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
  109. package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
  110. package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
  111. package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
  112. package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
  113. package/src/modules/library/components/GroupIndexRow.tsx +63 -0
  114. package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
  115. package/src/modules/library/components/GroupPage.tsx +373 -0
  116. package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
  117. package/src/modules/library/components/GroupsSidebar.tsx +338 -0
  118. package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
  119. package/src/modules/library/components/LibraryCard.tsx +123 -102
  120. package/src/modules/library/components/LibraryLayout.tsx +344 -0
  121. package/src/modules/library/components/LibraryPage.tsx +111 -227
  122. package/src/modules/library/components/LockGlyph.tsx +31 -0
  123. package/src/modules/library/components/LockedGroupView.tsx +159 -0
  124. package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
  125. package/src/modules/library/components/NewGroupDialog.tsx +112 -0
  126. package/src/modules/library/components/NewSkillPanel.tsx +151 -0
  127. package/src/modules/library/components/PageActions.tsx +156 -0
  128. package/src/modules/library/components/PendingSkillReview.tsx +63 -0
  129. package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
  130. package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
  131. package/src/modules/library/components/StatusDot.tsx +25 -0
  132. package/src/modules/library/components/ToolLogo.tsx +171 -0
  133. package/src/modules/library/components/group-page-parts.tsx +419 -0
  134. package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
  135. package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
  136. package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
  137. package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
  138. package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
  139. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
  140. package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
  141. package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
  142. package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
  143. package/src/modules/library/hooks/useJoinRequests.ts +114 -0
  144. package/src/modules/library/hooks/useLibraryData.ts +134 -119
  145. package/src/modules/library/hooks/useSkillDetail.ts +119 -74
  146. package/src/modules/library/hooks/useToolPage.ts +145 -0
  147. package/src/modules/library/library.css +33 -245
  148. package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
  149. package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
  150. package/src/modules/library/routes/library-paths.ts +191 -0
  151. package/src/modules/library/services/groups.api.ts +189 -0
  152. package/src/modules/library/services/library.api.ts +291 -164
  153. package/src/modules/library/services/tools.api.ts +60 -0
  154. package/src/modules/library/state/library-context.ts +22 -0
  155. package/src/modules/library/state/library-data.tsx +223 -0
  156. package/src/modules/library/state/toast.context.ts +32 -0
  157. package/src/modules/library/state/toast.tsx +84 -42
  158. package/src/modules/library/utils/clipboard.ts +33 -0
  159. package/src/modules/library/utils/group-summary.ts +68 -0
  160. package/src/modules/library/utils/names.ts +30 -0
  161. package/src/modules/library/utils/navigate-external.ts +15 -0
  162. package/src/modules/library/utils/oauth-fragment.ts +32 -0
  163. package/src/modules/library/utils/personal-group.ts +36 -0
  164. package/src/modules/library/utils/status.ts +108 -25
  165. package/src/modules/library/utils/toast-duration.ts +16 -0
  166. package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
  167. package/src/modules/onboarding/agent-clients.ts +48 -0
  168. package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
  169. package/src/modules/onboarding/components/RootLanding.tsx +54 -0
  170. package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
  171. package/src/modules/onboarding/paths.ts +9 -0
  172. package/src/modules/onboarding/state/onboarding.ts +191 -0
  173. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
  174. package/src/modules/pr/services/pr-approvals.api.ts +19 -0
  175. package/src/modules/pr/services/pr-cancel.api.ts +11 -0
  176. package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
  177. package/src/modules/review/components/DiffViewer.tsx +4 -4
  178. package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
  179. package/src/modules/review/components/ReviewFileRow.tsx +10 -10
  180. package/src/modules/review/components/ReviewPanel.tsx +49 -17
  181. package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
  182. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
  183. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
  184. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
  185. package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
  186. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
  187. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
  188. package/src/modules/secrets-vault/services/connect.api.ts +24 -3
  189. package/src/modules/settings/components/DeploymentPage.tsx +90 -0
  190. package/src/modules/settings/components/SettingsLayout.tsx +135 -0
  191. package/src/modules/settings/components/SettingsNav.tsx +114 -0
  192. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
  193. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
  194. package/src/modules/settings/settings-nav-items.tsx +166 -0
  195. package/src/modules/setup/__tests__/setup.test.tsx +540 -0
  196. package/src/modules/setup/components/SetupGate.tsx +67 -0
  197. package/src/modules/setup/components/SetupScreen.tsx +573 -0
  198. package/src/modules/setup/services/setup.api.ts +106 -0
  199. package/src/modules/setup/utils/git-host.ts +34 -0
  200. package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
  201. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
  202. package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
  203. package/src/modules/toolbar/components/Toolbar.tsx +56 -54
  204. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
  205. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
  206. package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
  207. package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
  208. package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
  209. package/src/modules/workspace/components/EditorTabs.tsx +82 -50
  210. package/src/modules/workspace/components/FileExplorer.tsx +413 -189
  211. package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
  212. package/src/modules/workspace/components/FileRoute.tsx +89 -84
  213. package/src/modules/workspace/components/FileViewer.tsx +700 -294
  214. package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
  215. package/src/modules/workspace/components/KbFileRail.tsx +128 -0
  216. package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
  217. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
  218. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
  219. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
  220. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
  221. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
  222. package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
  223. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
  224. package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
  225. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
  226. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
  227. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
  228. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
  229. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
  230. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
  231. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
  232. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
  233. package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
  234. package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
  235. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
  236. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
  237. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
  238. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
  239. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
  240. package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
  241. package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
  242. package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
  243. package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
  244. package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
  245. package/src/modules/workspace/components/renderers/index.ts +78 -2
  246. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
  247. package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
  248. package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
  249. package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
  250. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
  251. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
  252. package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
  253. package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
  254. package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
  255. package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
  256. package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
  257. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
  258. package/src/modules/workspace/services/workspace.api.ts +9 -2
  259. package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
  260. package/src/modules/workspace/state/open-change-requests.tsx +185 -0
  261. package/src/modules/workspace/state/workspace.context.ts +9 -0
  262. package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
  263. package/src/modules/workspace/utils/diff.ts +130 -53
  264. package/src/modules/workspace/utils/fileTree.ts +7 -4
  265. package/src/modules/workspace/workspace.css +28 -0
  266. package/src/shared/components/Badge.tsx +62 -0
  267. package/src/shared/components/Banner.tsx +58 -0
  268. package/src/shared/components/Button.tsx +90 -0
  269. package/src/shared/components/Dialog.tsx +6 -6
  270. package/src/shared/components/Field.tsx +45 -0
  271. package/src/shared/components/IconButton.tsx +74 -0
  272. package/src/shared/components/ListRow.tsx +96 -0
  273. package/src/shared/components/Menu.tsx +88 -0
  274. package/src/shared/components/PageShell.tsx +8 -5
  275. package/src/shared/components/Surface.tsx +86 -0
  276. package/src/shared/components/__tests__/primitives.test.tsx +333 -0
  277. package/src/shared/components/index.ts +48 -0
  278. package/src/shared/components/useDismissableMenu.ts +71 -0
  279. package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
  280. package/src/shared/theme/index.css +12 -0
  281. package/src/shared/theme/measure.ts +64 -0
  282. package/src/shared/theme/shadows.css +34 -0
  283. package/src/shared/theme/tokens.css +193 -0
  284. package/src/test-setup.ts +9 -0
  285. package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
  286. package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
  287. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
  288. package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
  289. package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
  290. package/src/modules/library/__tests__/diff.test.ts +0 -62
  291. package/src/modules/library/__tests__/loadout.test.tsx +0 -72
  292. package/src/modules/library/components/CompareView.tsx +0 -357
  293. package/src/modules/library/components/DetailDialog.tsx +0 -566
  294. package/src/modules/library/components/GearIcon.tsx +0 -12
  295. package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
  296. package/src/modules/library/components/StatusGem.tsx +0 -21
  297. package/src/modules/library/components/SuggestChange.tsx +0 -171
  298. package/src/modules/library/components/particles.ts +0 -50
  299. package/src/modules/library/state/loadout.tsx +0 -129
  300. package/src/modules/library/utils/diff.ts +0 -102
  301. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
  302. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
  303. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
  304. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
  305. package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
  306. package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
  307. package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
  308. package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
  309. package/src/modules/pr/components/PrCancelButton.tsx +0 -99
  310. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
  311. package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
  312. package/src/modules/pr/components/PrCommentThread.tsx +0 -168
  313. package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
  314. package/src/modules/pr/components/PrDiffPane.tsx +0 -425
  315. package/src/modules/pr/components/PrFileRow.tsx +0 -164
  316. package/src/modules/pr/components/PrFilesList.tsx +0 -53
  317. package/src/modules/pr/components/PrHeader.tsx +0 -45
  318. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
  319. package/src/modules/pr/components/PrMergeButton.tsx +0 -268
  320. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
  321. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
  322. package/src/modules/pr/components/PrViewer.tsx +0 -364
  323. package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
  324. package/src/modules/pr/state/pr-viewer.context.ts +0 -34
  325. package/src/modules/pr/utils/bucketize-comments.ts +0 -55
  326. package/src/modules/pr/utils/parsePatch.ts +0 -57
  327. package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
@@ -0,0 +1,317 @@
1
+ import { useCallback, useEffect, useRef, useState, type ReactNode } from 'react';
2
+ import { cn } from '../../../lib/utils';
3
+ import {
4
+ SIDEBAR_DEFAULT_WIDTH,
5
+ SIDEBAR_MAX_WIDTH,
6
+ SIDEBAR_MIN_WIDTH,
7
+ commitSidebarWidth,
8
+ setSidebarCollapsed,
9
+ setSidebarNarrow,
10
+ setSidebarWidth,
11
+ useSidebar,
12
+ } from '../state/sidebar';
13
+ import { useMediaQuery } from '../hooks/useMediaQuery';
14
+ import { NARROW_QUERY } from '../breakpoints';
15
+ import { useModalLayer } from '../../../shared/components/useModalLayer';
16
+
17
+ /**
18
+ * The `aria-controls` target for the top bar's toggle, which renders in a
19
+ * different subtree. One id because there is only ever one sidebar mounted —
20
+ * the two surfaces never appear at once.
21
+ */
22
+ export const SIDEBAR_DOM_ID = 'app-sidebar';
23
+
24
+ /** The old Knowledge drawer's phone measure: most of the screen, with a
25
+ * visible strip of backdrop left as an obvious tap target. */
26
+ export const SIDEBAR_DRAWER_WIDTH = '85vw';
27
+ export const SIDEBAR_DRAWER_MAX_WIDTH = '24rem';
28
+
29
+ const FOCUSABLE_SELECTOR =
30
+ 'button:not([disabled]), [href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), [tabindex]:not([tabindex="-1"])';
31
+
32
+ /**
33
+ * The app's nav spine — the prototype's `.side` + `.resizer` + `.side-inner`
34
+ * (proto:85-104, proto:4328-4370).
35
+ *
36
+ * ONE frame, filled by whichever surface you are on: the group list in Skills
37
+ * & Tools, the file tree in Knowledge. They were two components with two
38
+ * different backgrounds, two paddings and only one of them resizable, which is
39
+ * two products wearing one logo. The prototype has a single `<aside>` and two
40
+ * renderers, and this is that — the contents are `children`, everything about
41
+ * being a sidebar is here.
42
+ *
43
+ * Collapsing is a WIDTH change on the frame, never a layout change on the
44
+ * contents: the inner column keeps its own explicit width and is clipped, so
45
+ * the rows slide out intact instead of reflowing to nothing on the way. The
46
+ * border goes transparent rather than away — a border that stops existing
47
+ * would jump the main column by a pixel at the end of a 240ms animation.
48
+ *
49
+ * `inert` is what makes "hidden" true rather than merely narrow. Zero width
50
+ * still leaves every row focusable and still reads it out, so a keyboard user
51
+ * would tab into a nav nobody can see. Clipping is a picture; `inert` is the
52
+ * fact.
53
+ */
54
+ export function SidebarFrame({
55
+ children,
56
+ label,
57
+ header,
58
+ }: {
59
+ children: ReactNode;
60
+ /** Names the region and its resize handle, e.g. `Library groups`. */
61
+ label: string;
62
+ /**
63
+ * Pinned above `children`, outside whatever list the surface is holding.
64
+ *
65
+ * A SLOT rather than a component this frame names, because the frame is the
66
+ * app's consistency layer and must stay domain-agnostic: what belongs at the
67
+ * top of the nav is the composing surface's decision, not the sidebar's.
68
+ * Both surfaces pass the connect-your-agent reminder — which is what makes
69
+ * it one pill in one place across Knowledge and Skills — but the frame does
70
+ * not know that, and the next thing to go there costs no edit here.
71
+ */
72
+ header?: ReactNode;
73
+ }) {
74
+ // `narrow` comes off the store rather than straight off `viewportNarrow`
75
+ // below, because the store is where it lands in the same write as
76
+ // `collapsed` (see `setSidebarNarrow`). Reading the raw query here instead
77
+ // would reintroduce the render this frame is careful not to have: narrow
78
+ // viewport, sidebar not yet collapsed, drawer briefly open.
79
+ const { collapsed, width, instant, narrow } = useSidebar();
80
+ const viewportNarrow = useMediaQuery(NARROW_QUERY);
81
+ const [dragging, setDragging] = useState(false);
82
+ const asideRef = useRef<HTMLElement>(null);
83
+ const drawerOpen = narrow && !collapsed;
84
+ const isTopModalLayer = useModalLayer(drawerOpen);
85
+
86
+ // This frame owns the breakpoint because there is only ever one sidebar
87
+ // mounted. The store ignores a repeat of the value it already holds, so a
88
+ // sidebar the user reopened at phone width stays open until the next
89
+ // crossing (or navigation), and a pre-collapsed desktop mount is left alone
90
+ // rather than mistaken for a crossing.
91
+ useEffect(() => {
92
+ setSidebarNarrow(viewportNarrow);
93
+ }, [viewportNarrow]);
94
+
95
+ // A narrow sidebar covers the page rather than taking width from it. Treat
96
+ // that presentation as a modal drawer: pull focus inside, keep Tab inside,
97
+ // let Escape dismiss only the topmost modal layer, then return focus to the
98
+ // toolbar toggle that opened it. Desktop remains a plain complementary nav.
99
+ useEffect(() => {
100
+ if (!drawerOpen) return;
101
+ const previouslyFocused = document.activeElement as HTMLElement | null;
102
+ const aside = asideRef.current;
103
+ (aside?.querySelector<HTMLElement>(FOCUSABLE_SELECTOR) ?? aside)?.focus?.();
104
+
105
+ /**
106
+ * The drawer's key handling: Escape dismisses, but only when this is the
107
+ * topmost modal layer, and Tab wraps at both ends so focus cannot walk out
108
+ * of a drawer that is covering the page behind it.
109
+ */
110
+ function onKeyDown(e: KeyboardEvent) {
111
+ if (e.key === 'Escape') {
112
+ if (!isTopModalLayer()) return;
113
+ e.stopPropagation();
114
+ setSidebarCollapsed(true);
115
+ return;
116
+ }
117
+ if (e.key !== 'Tab' || !aside) return;
118
+ const focusable = Array.from(
119
+ aside.querySelectorAll<HTMLElement>(FOCUSABLE_SELECTOR),
120
+ );
121
+ if (focusable.length === 0) {
122
+ e.preventDefault();
123
+ aside.focus();
124
+ return;
125
+ }
126
+ const first = focusable[0];
127
+ const last = focusable[focusable.length - 1];
128
+ const active = document.activeElement;
129
+ if (e.shiftKey && (active === first || active === aside)) {
130
+ e.preventDefault();
131
+ last.focus();
132
+ } else if (!e.shiftKey && active === last) {
133
+ e.preventDefault();
134
+ first.focus();
135
+ }
136
+ }
137
+
138
+ document.addEventListener('keydown', onKeyDown);
139
+ return () => {
140
+ document.removeEventListener('keydown', onKeyDown);
141
+ previouslyFocused?.focus?.();
142
+ };
143
+ }, [drawerOpen, isTopModalLayer]);
144
+
145
+ const onPointerDown = useCallback(
146
+ (e: React.PointerEvent<HTMLDivElement>) => {
147
+ if (collapsed || e.button !== 0) return;
148
+ e.preventDefault();
149
+ // Pointer capture rather than document listeners: it keeps the drag
150
+ // alive over an iframe or a cross-origin embed in the main column, which
151
+ // a mousemove on `document` silently loses.
152
+ e.currentTarget.setPointerCapture(e.pointerId);
153
+ setDragging(true);
154
+ },
155
+ [collapsed],
156
+ );
157
+
158
+ const onPointerMove = useCallback(
159
+ (e: React.PointerEvent<HTMLDivElement>) => {
160
+ if (!dragging) return;
161
+ const left = asideRef.current?.getBoundingClientRect().left ?? 0;
162
+ // Measured from the sidebar's own left edge, not from a start offset, so
163
+ // the handle cannot drift away from the cursor over a long drag.
164
+ setSidebarWidth(e.clientX - left, false);
165
+ },
166
+ [dragging],
167
+ );
168
+
169
+ const endDrag = useCallback(() => setDragging(false), []);
170
+
171
+ /**
172
+ * Keyboard gets the same control (proto:4366-4369). A separator you can only
173
+ * drag is a control half the people cannot use — and `role="separator"` with
174
+ * `aria-valuenow` is what makes it one to a screen reader rather than a
175
+ * decorative strip.
176
+ */
177
+ const onKeyDown = useCallback(
178
+ (e: React.KeyboardEvent<HTMLDivElement>) => {
179
+ const step = e.shiftKey ? 32 : 8;
180
+ if (e.key === 'ArrowLeft') {
181
+ e.preventDefault();
182
+ setSidebarWidth(width - step);
183
+ } else if (e.key === 'ArrowRight') {
184
+ e.preventDefault();
185
+ setSidebarWidth(width + step);
186
+ } else if (e.key === 'Home') {
187
+ e.preventDefault();
188
+ setSidebarWidth(SIDEBAR_DEFAULT_WIDTH);
189
+ }
190
+ },
191
+ [width],
192
+ );
193
+
194
+ /**
195
+ * Collapsing UNMOUNTS the separator, so a drag in flight never gets its
196
+ * `pointerup`. Left alone the drag stays "live" for good: `dragging` never
197
+ * returns to false, the effect below never runs its cleanup, and the whole
198
+ * document keeps the resize cursor and the selection lock.
199
+ *
200
+ * Adjusted DURING RENDER rather than from an effect, which is what React
201
+ * prescribes for resetting state that an incoming value has invalidated.
202
+ * React re-runs the component before committing, so the lock is released in
203
+ * the same paint the sidebar collapses in; from an effect the state would
204
+ * change AFTER the commit — a second render pass with the cursor still stuck
205
+ * for its duration, which is the cascade `set-state-in-effect` names.
206
+ */
207
+ const [wasCollapsed, setWasCollapsed] = useState(collapsed);
208
+ if (wasCollapsed !== collapsed) {
209
+ setWasCollapsed(collapsed);
210
+ if (collapsed) setDragging(false);
211
+ }
212
+
213
+ // While dragging, the whole page shows the resize cursor and stops selecting
214
+ // text — otherwise sweeping across the document highlights it, and the
215
+ // cursor flickers to a text caret every time it crosses a label.
216
+ //
217
+ // The cleanup is "this drag ended" by EVERY route there is — pointerup, a
218
+ // collapse, an unmount mid-drag — so the width commit belongs in it rather
219
+ // than in `endDrag`, which only ever covered the first of the three.
220
+ useEffect(() => {
221
+ if (!dragging) return;
222
+ const { style } = document.body;
223
+ const prevCursor = style.cursor;
224
+ const prevSelect = style.userSelect;
225
+ style.cursor = 'col-resize';
226
+ style.userSelect = 'none';
227
+ return () => {
228
+ style.cursor = prevCursor;
229
+ style.userSelect = prevSelect;
230
+ commitSidebarWidth();
231
+ };
232
+ }, [dragging]);
233
+
234
+ return (
235
+ <>
236
+ {drawerOpen && (
237
+ <div
238
+ data-sidebar-backdrop
239
+ aria-hidden="true"
240
+ className="fixed inset-0 z-40 bg-scrim"
241
+ onClick={() => {
242
+ if (isTopModalLayer()) setSidebarCollapsed(true);
243
+ }}
244
+ />
245
+ )}
246
+ <aside
247
+ ref={asideRef}
248
+ id={SIDEBAR_DOM_ID}
249
+ aria-label={label}
250
+ role={drawerOpen ? 'dialog' : undefined}
251
+ aria-modal={drawerOpen ? true : undefined}
252
+ tabIndex={drawerOpen ? -1 : undefined}
253
+ inert={collapsed}
254
+ className={cn(
255
+ 'h-full shrink-0 overflow-hidden border-r bg-sidebar',
256
+ narrow ? 'fixed inset-y-0 left-0 z-50 shadow-2xl' : 'relative',
257
+ collapsed ? 'border-r-transparent' : 'border-line',
258
+ // An easing curve would lag the cursor, so the transition is off for
259
+ // the duration of the drag (proto:89) — and off again for a change
260
+ // nobody gestured at (`instant`), where a 240ms slide would be the
261
+ // nav appearing to move on its own.
262
+ dragging || instant
263
+ ? 'transition-none'
264
+ : 'transition-[width] duration-[240ms] ease-[cubic-bezier(.2,.8,.2,1)]',
265
+ )}
266
+ style={{
267
+ width: collapsed ? 0 : narrow ? SIDEBAR_DRAWER_WIDTH : width,
268
+ maxWidth: narrow ? SIDEBAR_DRAWER_MAX_WIDTH : undefined,
269
+ }}
270
+ >
271
+ {/* proto:104 — `padding:16px 14px 18px`, and an explicit width so the
272
+ column does not reflow while the frame animates to zero. */}
273
+ <div
274
+ className="flex h-full flex-col px-3.5 pt-4 pb-[18px]"
275
+ style={{
276
+ width: narrow ? SIDEBAR_DRAWER_WIDTH : width,
277
+ maxWidth: narrow ? SIDEBAR_DRAWER_MAX_WIDTH : undefined,
278
+ }}
279
+ >
280
+ {header}
281
+ {children}
282
+ </div>
283
+ </aside>
284
+
285
+ {/* The handle straddles the border without occupying layout: its own
286
+ width is cancelled by the negative margins, so nothing shifts when
287
+ the sidebar collapses and it goes away (proto:92-97). */}
288
+ {!narrow && !collapsed && (
289
+ <div
290
+ role="separator"
291
+ aria-orientation="vertical"
292
+ aria-label={`Resize ${label}`}
293
+ aria-valuenow={width}
294
+ aria-valuemin={SIDEBAR_MIN_WIDTH}
295
+ aria-valuemax={SIDEBAR_MAX_WIDTH}
296
+ tabIndex={0}
297
+ onPointerDown={onPointerDown}
298
+ onPointerMove={onPointerMove}
299
+ onPointerUp={endDrag}
300
+ onPointerCancel={endDrag}
301
+ onKeyDown={onKeyDown}
302
+ onDoubleClick={() => setSidebarWidth(SIDEBAR_DEFAULT_WIDTH)}
303
+ className="group/grip relative z-30 -mx-[3.5px] w-[7px] flex-none cursor-col-resize"
304
+ >
305
+ <span
306
+ aria-hidden
307
+ className={cn(
308
+ 'absolute inset-y-0 left-[3px] w-px transition-colors',
309
+ dragging ? 'bg-accent' : 'bg-transparent group-hover/grip:bg-accent',
310
+ 'group-focus-visible/grip:bg-accent',
311
+ )}
312
+ />
313
+ </div>
314
+ )}
315
+ </>
316
+ );
317
+ }
@@ -0,0 +1,86 @@
1
+ import { cn } from '../../../lib/utils';
2
+ import { SIDEBAR_DOM_ID } from './SidebarFrame';
3
+
4
+ /**
5
+ * Hide / show the nav — the prototype's `#side-open` (lines 89-91).
6
+ *
7
+ * It lives in the TOP BAR, first in the row and left of the brand — the spot
8
+ * every app puts the control that owns the panel below it. The `Toolbar`
9
+ * mounts it wherever a sidebar exists and wires it to the shared store in
10
+ * `layout/state/sidebar.ts`; the sidebar it controls renders in a different
11
+ * subtree entirely, which `aria-controls` bridges by id.
12
+ *
13
+ * ONE button, at ONE place, for ONE sidebar. It sat in the `library` module
14
+ * while Knowledge's explorer had a separate toggle of its own — same glyph,
15
+ * same spot, different state — and moved here when those became the same
16
+ * control. The prototype's own note is the whole design: "the toggle never
17
+ * moves — same spot, open or closed", so collapsing does not move the thing
18
+ * you just clicked out from under the pointer.
19
+ */
20
+ export function SidebarToggle({
21
+ collapsed,
22
+ onToggle,
23
+ className,
24
+ }: {
25
+ collapsed: boolean;
26
+ onToggle(): void;
27
+ className?: string;
28
+ }) {
29
+ const label = collapsed ? 'Show sidebar' : 'Hide sidebar';
30
+ return (
31
+ <button
32
+ type="button"
33
+ onClick={onToggle}
34
+ title={label}
35
+ aria-label={label}
36
+ aria-expanded={!collapsed}
37
+ aria-controls={SIDEBAR_DOM_ID}
38
+ className={cn(
39
+ // `ink-muted`, not `ink-faint`: at 16px with a 1.3 stroke this is a
40
+ // thin shape on a tinted panel, and the faint step rendered it close
41
+ // enough to the background to read as "no button here at all".
42
+ 'flex size-7 items-center justify-center rounded-md text-ink-muted transition-colors hover:bg-hover hover:text-ink',
43
+ className,
44
+ )}
45
+ >
46
+ <PanelGlyph className="size-4" />
47
+ </button>
48
+ );
49
+ }
50
+
51
+ /**
52
+ * A panel with its left rail filled — the sidebar, drawn as itself.
53
+ *
54
+ * Exported because BOTH surfaces show it now: the Library's nav toggle and
55
+ * Knowledge's explorer toggle are the same control in the same spot doing the
56
+ * same thing, and two glyphs for that would be the app saying "you are
57
+ * somewhere else" at the one place that must never move (proto:3696).
58
+ *
59
+ * Inline for the same reason as `LockGlyph`: it inherits `currentColor` from
60
+ * the button's hover state, and one shape is not worth an icon dependency.
61
+ *
62
+ * The rail is a path rather than a second `<rect>` because only its LEFT
63
+ * corners are round — it has to sit flush inside the outer radius on that
64
+ * side and butt square against the divider on the other. Both arcs carry the
65
+ * outer `rx`, so the two shapes share one silhouette at any size.
66
+ */
67
+ export function PanelGlyph({ className }: { className?: string }) {
68
+ return (
69
+ <svg className={className} aria-hidden="true" focusable="false" viewBox="0 0 16 16">
70
+ <rect
71
+ x="1.5"
72
+ y="2.5"
73
+ width="13"
74
+ height="11"
75
+ rx="3.2"
76
+ fill="none"
77
+ stroke="currentColor"
78
+ strokeWidth="1.3"
79
+ />
80
+ <path
81
+ d="M4.7 2.5H6.1V13.5H4.7A3.2 3.2 0 0 1 1.5 10.3V5.7A3.2 3.2 0 0 1 4.7 2.5Z"
82
+ fill="currentColor"
83
+ />
84
+ </svg>
85
+ );
86
+ }
@@ -193,7 +193,7 @@ export function SlideOverlay({
193
193
  aria-label={ariaLabel}
194
194
  >
195
195
  <div
196
- className="absolute inset-0 bg-slate-900/40"
196
+ className="absolute inset-0 bg-scrim"
197
197
  // Tying backdrop opacity to drag progress makes the close gesture feel
198
198
  // continuous — the sheet and the backdrop both fade together as the
199
199
  // user pulls down. Falls back to a fixed CSS transition when nothing
@@ -1,10 +1,33 @@
1
- import { describe, it, expect } from 'vitest';
1
+ import { beforeEach, describe, it, expect } from 'vitest';
2
2
  import { render, screen, waitForElementToBeRemoved } from '@testing-library/react';
3
3
  import userEvent from '@testing-library/user-event';
4
4
  import { MemoryRouter } from 'react-router-dom';
5
5
  import { MobileChatLayout } from '../MobileChatLayout';
6
6
  import { useLayout } from '../../state/layout.context';
7
+ import {
8
+ SIDEBAR_DOM_ID,
9
+ SIDEBAR_DRAWER_MAX_WIDTH,
10
+ SIDEBAR_DRAWER_WIDTH,
11
+ } from '../SidebarFrame';
12
+ import { setSidebarCollapsed, setSidebarNarrow } from '../../state/sidebar';
7
13
 
14
+ /**
15
+ * Cross the narrow breakpoint. happy-dom answers `matchMedia` out of
16
+ * `innerWidth`, so moving the viewport is how a test reaches the drawer
17
+ * layout — there is no CSS engine here to do it for us.
18
+ */
19
+ function setViewportWidth(width: number): void {
20
+ const testWindow = window as typeof window & {
21
+ happyDOM: { setInnerWidth(value: number): void };
22
+ };
23
+ testWindow.happyDOM.setInnerWidth(width);
24
+ }
25
+
26
+ /**
27
+ * A stand-in toolbar. It reaches the explorer through the layout CONTEXT
28
+ * rather than a prop, which is the wiring under test: the real toolbar renders
29
+ * outside this layout and can only drive it through the reported controller.
30
+ */
8
31
  function HeaderToggle() {
9
32
  const { toggleExplorer, canToggleChat } = useLayout();
10
33
  return (
@@ -17,6 +40,10 @@ function HeaderToggle() {
17
40
  );
18
41
  }
19
42
 
43
+ /**
44
+ * Mount the layout at a route, with a distinct marker in each of the three
45
+ * panes so an assertion can tell which one is actually showing.
46
+ */
20
47
  function renderLayout(initialPath: string) {
21
48
  return render(
22
49
  <MemoryRouter initialEntries={[initialPath]}>
@@ -31,10 +58,18 @@ function renderLayout(initialPath: string) {
31
58
  }
32
59
 
33
60
  describe('MobileChatLayout', () => {
61
+ beforeEach(() => {
62
+ setViewportWidth(375);
63
+ // Module state: clear the breakpoint the previous test settled on so this
64
+ // mount reads as a fresh crossing into narrow rather than a no-op.
65
+ setSidebarNarrow(false);
66
+ setSidebarCollapsed(false);
67
+ });
68
+
34
69
  it('always renders the chat slot and hides the explorer until opened', () => {
35
70
  renderLayout('/');
36
71
  expect(screen.getByText('CHAT_PANEL')).toBeInTheDocument();
37
- expect(screen.queryByText('FILE_EXPLORER')).toBeNull();
72
+ expect(document.getElementById(SIDEBAR_DOM_ID)).toHaveAttribute('inert');
38
73
  });
39
74
 
40
75
  it('exposes canToggleChat=false because chat is pinned full-screen', () => {
@@ -46,6 +81,9 @@ describe('MobileChatLayout', () => {
46
81
  const user = userEvent.setup();
47
82
  renderLayout('/');
48
83
  await user.click(screen.getByRole('button', { name: 'open-explorer' }));
84
+ const drawer = screen.getByRole('dialog', { name: 'File explorer' });
85
+ expect(drawer.style.width).toBe(SIDEBAR_DRAWER_WIDTH);
86
+ expect(drawer.style.maxWidth).toBe(SIDEBAR_DRAWER_MAX_WIDTH);
49
87
  expect(screen.getByText('FILE_EXPLORER')).toBeInTheDocument();
50
88
  });
51
89
 
@@ -42,7 +42,11 @@ describe('ResizableThreePaneLayout', () => {
42
42
  expect(screen.getByTestId('probe-chat').textContent).toBe('false');
43
43
  });
44
44
 
45
- it('renders two resize handles between the three panels', () => {
45
+ // The explorer left the group: it is the app's SIDEBAR now, sized by
46
+ // `SidebarFrame` against a shared, persisted width rather than by a panel in
47
+ // this layout's own persisted arrangement. So the group holds viewer + chat
48
+ // and needs one panel separator, while the sidebar brings its own handle.
49
+ it('separates the panels it still owns, and lets the sidebar bring its own handle', () => {
46
50
  const { container } = render(
47
51
  <ResizableThreePaneLayout
48
52
  header={<div />}
@@ -51,7 +55,19 @@ describe('ResizableThreePaneLayout', () => {
51
55
  chat={<div />}
52
56
  />,
53
57
  );
54
- const handles = container.querySelectorAll('[data-separator]');
55
- expect(handles).toHaveLength(2);
58
+ expect(container.querySelectorAll('[data-separator]')).toHaveLength(1);
59
+ expect(screen.getByRole('separator', { name: /resize/i })).toBeInTheDocument();
60
+ });
61
+
62
+ it('renders the explorer inside the sidebar frame, not as a panel', () => {
63
+ render(
64
+ <ResizableThreePaneLayout
65
+ header={<div />}
66
+ explorer={<div>tree</div>}
67
+ viewer={<div />}
68
+ />,
69
+ );
70
+ const aside = screen.getByRole('complementary', { name: /file explorer/i });
71
+ expect(aside).toHaveTextContent('tree');
56
72
  });
57
73
  });