@bevel-software/platform-core-frontend 0.4.1 → 0.5.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +5366 -0
- package/package.json +7 -4
- package/src/core/CoreAppShell.tsx +195 -56
- package/src/core/__tests__/AppChrome.test.tsx +125 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
- package/src/core/__tests__/bootstrap.test.ts +63 -0
- package/src/core/bootstrap.ts +73 -0
- package/src/core/events.ts +12 -0
- package/src/core/registry.ts +58 -9
- package/src/index.css +100 -11
- package/src/index.ts +24 -23
- package/src/lib/utils.ts +93 -117
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
- package/src/modules/access/api.ts +49 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
- package/src/modules/access/hooks/useFileAccess.ts +1 -1
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
- package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
- package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
- package/src/modules/admin/state/admin.context.tsx +15 -6
- package/src/modules/auth/components/AccountPage.tsx +11 -11
- package/src/modules/auth/components/LoginScreen.tsx +12 -12
- package/src/modules/auth/services/sso.ts +47 -1
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
- package/src/modules/change-requests/__tests__/author.test.ts +48 -0
- package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
- package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
- package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
- package/src/modules/change-requests/change-requests.css +22 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
- package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
- package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
- package/src/modules/change-requests/services/change-requests.api.ts +45 -0
- package/src/modules/change-requests/services/propose.api.ts +162 -0
- package/src/modules/change-requests/utils/author.ts +47 -0
- package/src/modules/change-requests/utils/conflict.ts +38 -0
- package/src/modules/change-requests/utils/diff.ts +80 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
- package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
- package/src/modules/git/components/BranchSwitcher.tsx +68 -31
- package/src/modules/git/components/DiffView.tsx +4 -4
- package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
- package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
- package/src/modules/git/components/PullNeededBanner.tsx +6 -13
- package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
- package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
- package/src/modules/git/hooks/useGitState.ts +15 -14
- package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
- package/src/modules/git/services/error-messages.ts +7 -7
- package/src/modules/git/services/git.api.ts +17 -11
- package/src/modules/git/services/pr-prompts.ts +2 -2
- package/src/modules/git/state/git.context.ts +10 -1
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
- package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
- package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
- package/src/modules/layout/breakpoints.ts +6 -0
- package/src/modules/layout/components/AppLayout.tsx +17 -5
- package/src/modules/layout/components/DemoBanner.tsx +10 -1
- package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
- package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
- package/src/modules/layout/components/SidebarFrame.tsx +317 -0
- package/src/modules/layout/components/SidebarToggle.tsx +86 -0
- package/src/modules/layout/components/SlideOverlay.tsx +1 -1
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
- package/src/modules/layout/state/sidebar.ts +200 -0
- package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
- package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
- package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
- package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
- package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
- package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
- package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
- package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
- package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
- package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
- package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
- package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
- package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
- package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
- package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
- package/src/modules/library/__tests__/auth-harness.tsx +37 -0
- package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
- package/src/modules/library/__tests__/status.test.ts +113 -20
- package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
- package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
- package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
- package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
- package/src/modules/library/components/GroupIndexRow.tsx +63 -0
- package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
- package/src/modules/library/components/GroupPage.tsx +373 -0
- package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
- package/src/modules/library/components/GroupsSidebar.tsx +338 -0
- package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
- package/src/modules/library/components/LibraryCard.tsx +123 -102
- package/src/modules/library/components/LibraryLayout.tsx +344 -0
- package/src/modules/library/components/LibraryPage.tsx +111 -227
- package/src/modules/library/components/LockGlyph.tsx +31 -0
- package/src/modules/library/components/LockedGroupView.tsx +159 -0
- package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
- package/src/modules/library/components/NewGroupDialog.tsx +112 -0
- package/src/modules/library/components/NewSkillPanel.tsx +151 -0
- package/src/modules/library/components/PageActions.tsx +156 -0
- package/src/modules/library/components/PendingSkillReview.tsx +63 -0
- package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
- package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
- package/src/modules/library/components/StatusDot.tsx +25 -0
- package/src/modules/library/components/ToolLogo.tsx +171 -0
- package/src/modules/library/components/group-page-parts.tsx +419 -0
- package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
- package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
- package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
- package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
- package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
- package/src/modules/library/hooks/useJoinRequests.ts +114 -0
- package/src/modules/library/hooks/useLibraryData.ts +134 -119
- package/src/modules/library/hooks/useSkillDetail.ts +119 -74
- package/src/modules/library/hooks/useToolPage.ts +145 -0
- package/src/modules/library/library.css +33 -245
- package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
- package/src/modules/library/routes/library-paths.ts +191 -0
- package/src/modules/library/services/groups.api.ts +189 -0
- package/src/modules/library/services/library.api.ts +291 -164
- package/src/modules/library/services/tools.api.ts +60 -0
- package/src/modules/library/state/library-context.ts +22 -0
- package/src/modules/library/state/library-data.tsx +223 -0
- package/src/modules/library/state/toast.context.ts +32 -0
- package/src/modules/library/state/toast.tsx +84 -42
- package/src/modules/library/utils/clipboard.ts +33 -0
- package/src/modules/library/utils/group-summary.ts +68 -0
- package/src/modules/library/utils/names.ts +30 -0
- package/src/modules/library/utils/navigate-external.ts +15 -0
- package/src/modules/library/utils/oauth-fragment.ts +32 -0
- package/src/modules/library/utils/personal-group.ts +36 -0
- package/src/modules/library/utils/status.ts +108 -25
- package/src/modules/library/utils/toast-duration.ts +16 -0
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
- package/src/modules/onboarding/agent-clients.ts +48 -0
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
- package/src/modules/onboarding/components/RootLanding.tsx +54 -0
- package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
- package/src/modules/onboarding/paths.ts +9 -0
- package/src/modules/onboarding/state/onboarding.ts +191 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
- package/src/modules/pr/services/pr-approvals.api.ts +19 -0
- package/src/modules/pr/services/pr-cancel.api.ts +11 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
- package/src/modules/review/components/DiffViewer.tsx +4 -4
- package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
- package/src/modules/review/components/ReviewFileRow.tsx +10 -10
- package/src/modules/review/components/ReviewPanel.tsx +49 -17
- package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
- package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
- package/src/modules/secrets-vault/services/connect.api.ts +24 -3
- package/src/modules/settings/components/DeploymentPage.tsx +90 -0
- package/src/modules/settings/components/SettingsLayout.tsx +135 -0
- package/src/modules/settings/components/SettingsNav.tsx +114 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
- package/src/modules/settings/settings-nav-items.tsx +166 -0
- package/src/modules/setup/__tests__/setup.test.tsx +540 -0
- package/src/modules/setup/components/SetupGate.tsx +67 -0
- package/src/modules/setup/components/SetupScreen.tsx +573 -0
- package/src/modules/setup/services/setup.api.ts +106 -0
- package/src/modules/setup/utils/git-host.ts +34 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
- package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
- package/src/modules/toolbar/components/Toolbar.tsx +56 -54
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
- package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
- package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
- package/src/modules/workspace/components/EditorTabs.tsx +82 -50
- package/src/modules/workspace/components/FileExplorer.tsx +413 -189
- package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
- package/src/modules/workspace/components/FileRoute.tsx +89 -84
- package/src/modules/workspace/components/FileViewer.tsx +700 -294
- package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
- package/src/modules/workspace/components/KbFileRail.tsx +128 -0
- package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
- package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
- package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
- package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
- package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
- package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
- package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
- package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
- package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
- package/src/modules/workspace/components/renderers/index.ts +78 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
- package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
- package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
- package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
- package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
- package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
- package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
- package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
- package/src/modules/workspace/services/workspace.api.ts +9 -2
- package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
- package/src/modules/workspace/state/open-change-requests.tsx +185 -0
- package/src/modules/workspace/state/workspace.context.ts +9 -0
- package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
- package/src/modules/workspace/utils/diff.ts +130 -53
- package/src/modules/workspace/utils/fileTree.ts +7 -4
- package/src/modules/workspace/workspace.css +28 -0
- package/src/shared/components/Badge.tsx +62 -0
- package/src/shared/components/Banner.tsx +58 -0
- package/src/shared/components/Button.tsx +90 -0
- package/src/shared/components/Dialog.tsx +6 -6
- package/src/shared/components/Field.tsx +45 -0
- package/src/shared/components/IconButton.tsx +74 -0
- package/src/shared/components/ListRow.tsx +96 -0
- package/src/shared/components/Menu.tsx +88 -0
- package/src/shared/components/PageShell.tsx +8 -5
- package/src/shared/components/Surface.tsx +86 -0
- package/src/shared/components/__tests__/primitives.test.tsx +333 -0
- package/src/shared/components/index.ts +48 -0
- package/src/shared/components/useDismissableMenu.ts +71 -0
- package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
- package/src/shared/theme/index.css +12 -0
- package/src/shared/theme/measure.ts +64 -0
- package/src/shared/theme/shadows.css +34 -0
- package/src/shared/theme/tokens.css +193 -0
- package/src/test-setup.ts +9 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
- package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
- package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
- package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
- package/src/modules/library/__tests__/diff.test.ts +0 -62
- package/src/modules/library/__tests__/loadout.test.tsx +0 -72
- package/src/modules/library/components/CompareView.tsx +0 -357
- package/src/modules/library/components/DetailDialog.tsx +0 -566
- package/src/modules/library/components/GearIcon.tsx +0 -12
- package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
- package/src/modules/library/components/StatusGem.tsx +0 -21
- package/src/modules/library/components/SuggestChange.tsx +0 -171
- package/src/modules/library/components/particles.ts +0 -50
- package/src/modules/library/state/loadout.tsx +0 -129
- package/src/modules/library/utils/diff.ts +0 -102
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
- package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
- package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
- package/src/modules/pr/components/PrCancelButton.tsx +0 -99
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
- package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
- package/src/modules/pr/components/PrCommentThread.tsx +0 -168
- package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
- package/src/modules/pr/components/PrDiffPane.tsx +0 -425
- package/src/modules/pr/components/PrFileRow.tsx +0 -164
- package/src/modules/pr/components/PrFilesList.tsx +0 -53
- package/src/modules/pr/components/PrHeader.tsx +0 -45
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
- package/src/modules/pr/components/PrMergeButton.tsx +0 -268
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
- package/src/modules/pr/components/PrViewer.tsx +0 -364
- package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
- package/src/modules/pr/state/pr-viewer.context.ts +0 -34
- package/src/modules/pr/utils/bucketize-comments.ts +0 -55
- package/src/modules/pr/utils/parsePatch.ts +0 -57
- package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
|
@@ -0,0 +1,281 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
|
2
|
+
import { act, render, screen } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import type { FileTreeEntry } from '@bevel-software/platform-shared';
|
|
5
|
+
import type { AccessResponse } from '../api';
|
|
6
|
+
|
|
7
|
+
// --- Mock the API module ----------------------------------------------------
|
|
8
|
+
const api = vi.hoisted(() => ({
|
|
9
|
+
fetchFileAccess: vi.fn(),
|
|
10
|
+
grantAccess: vi.fn(),
|
|
11
|
+
revokeAccess: vi.fn(),
|
|
12
|
+
suggestPrincipals: vi.fn(),
|
|
13
|
+
}));
|
|
14
|
+
vi.mock('../api', async (importOriginal) => {
|
|
15
|
+
const actual = await importOriginal<typeof import('../api')>();
|
|
16
|
+
return { ...actual, ...api };
|
|
17
|
+
});
|
|
18
|
+
|
|
19
|
+
// --- Mock the context hooks the dialog reads --------------------------------
|
|
20
|
+
vi.mock('../../workspace/state/workspace.context', () => ({
|
|
21
|
+
useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
|
|
22
|
+
}));
|
|
23
|
+
vi.mock('../../auth/state/auth.context', () => ({
|
|
24
|
+
useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
|
|
25
|
+
}));
|
|
26
|
+
|
|
27
|
+
import { ManageAccessDialog } from '../components/ManageAccessDialog';
|
|
28
|
+
|
|
29
|
+
const KB = 'knowledge-base';
|
|
30
|
+
const ENTRY: FileTreeEntry = {
|
|
31
|
+
name: 'Deal.md',
|
|
32
|
+
relativePath: `${KB}/Sales/Deal.md`,
|
|
33
|
+
type: 'file',
|
|
34
|
+
} as unknown as FileTreeEntry;
|
|
35
|
+
const A = { name: 'Alice', email: 'alice@x.com' };
|
|
36
|
+
|
|
37
|
+
/** Alice, granted read + write directly here — one row with an editable checklist. */
|
|
38
|
+
const VIEW = {
|
|
39
|
+
canRead: true,
|
|
40
|
+
canWrite: true,
|
|
41
|
+
canDownload: false,
|
|
42
|
+
canOwner: false,
|
|
43
|
+
eligible: { roles: [], users: [A] },
|
|
44
|
+
readers: { restricted: true, roles: [], users: [A] },
|
|
45
|
+
owners: { roles: [], users: [] },
|
|
46
|
+
downloaders: { roles: [], users: [] },
|
|
47
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'direct' }], write: [{ kind: 'direct' }] } },
|
|
48
|
+
} as AccessResponse;
|
|
49
|
+
|
|
50
|
+
// The viewport the placement math is measured against. Pinned so the expected
|
|
51
|
+
// coordinates below are arithmetic, not whatever happy-dom defaults to.
|
|
52
|
+
const VIEWPORT = { width: 1200, height: 800 };
|
|
53
|
+
/** `MENU_MIN_WIDTH` — the width every menu here is clamped up to. */
|
|
54
|
+
const MENU_W = 200;
|
|
55
|
+
|
|
56
|
+
/**
|
|
57
|
+
* happy-dom runs no layout engine: every rect is 0×0 at the origin and
|
|
58
|
+
* `offsetHeight` is always 0, so `AnchoredMenu` would be measuring a
|
|
59
|
+
* degenerate viewport in which nothing ever overflows and nothing ever flips.
|
|
60
|
+
* These hand the component the two boxes it measures — the trigger's parent
|
|
61
|
+
* and the panel — with numbers the test controls.
|
|
62
|
+
*/
|
|
63
|
+
const rects = new Map<Element, DOMRect>();
|
|
64
|
+
const NO_RECT = {
|
|
65
|
+
top: 0, left: 0, right: 0, bottom: 0, width: 0, height: 0, x: 0, y: 0,
|
|
66
|
+
toJSON: () => ({}),
|
|
67
|
+
} as DOMRect;
|
|
68
|
+
|
|
69
|
+
function setRect(el: Element, r: { top: number; left: number; width: number; height: number }) {
|
|
70
|
+
rects.set(el, {
|
|
71
|
+
...r,
|
|
72
|
+
right: r.left + r.width,
|
|
73
|
+
bottom: r.top + r.height,
|
|
74
|
+
x: r.left,
|
|
75
|
+
y: r.top,
|
|
76
|
+
toJSON: () => r,
|
|
77
|
+
} as DOMRect);
|
|
78
|
+
}
|
|
79
|
+
|
|
80
|
+
/**
|
|
81
|
+
* The open panel's height. Only `AnchoredMenu`'s own wrapper is `fixed` AND
|
|
82
|
+
* measured — `Dialog`'s scrim is fixed too but nothing reads its height — so
|
|
83
|
+
* keying the stub on the class is unambiguous here.
|
|
84
|
+
*/
|
|
85
|
+
let menuHeight = 0;
|
|
86
|
+
|
|
87
|
+
/**
|
|
88
|
+
* A `ResizeObserver` the test can fire by hand. The real one never delivers in
|
|
89
|
+
* happy-dom (it has no layout to observe), and the whole point of these cases
|
|
90
|
+
* is what happens when a box the menu is anchored to changes size.
|
|
91
|
+
*/
|
|
92
|
+
interface Watcher {
|
|
93
|
+
cb: () => void;
|
|
94
|
+
targets: Set<Element>;
|
|
95
|
+
}
|
|
96
|
+
let watchers: Watcher[] = [];
|
|
97
|
+
|
|
98
|
+
class TestResizeObserver {
|
|
99
|
+
private readonly watcher: Watcher;
|
|
100
|
+
constructor(cb: () => void) {
|
|
101
|
+
this.watcher = { cb, targets: new Set() };
|
|
102
|
+
watchers.push(this.watcher);
|
|
103
|
+
}
|
|
104
|
+
observe(el: Element) {
|
|
105
|
+
this.watcher.targets.add(el);
|
|
106
|
+
}
|
|
107
|
+
unobserve(el: Element) {
|
|
108
|
+
this.watcher.targets.delete(el);
|
|
109
|
+
}
|
|
110
|
+
disconnect() {
|
|
111
|
+
this.watcher.targets.clear();
|
|
112
|
+
}
|
|
113
|
+
}
|
|
114
|
+
|
|
115
|
+
/** Deliver a resize notification for `el` to every observer watching it. */
|
|
116
|
+
function resize(el: Element) {
|
|
117
|
+
act(() => {
|
|
118
|
+
for (const w of watchers) if (w.targets.has(el)) w.cb();
|
|
119
|
+
});
|
|
120
|
+
}
|
|
121
|
+
|
|
122
|
+
let offsetHeightDescriptor: PropertyDescriptor | undefined;
|
|
123
|
+
|
|
124
|
+
beforeEach(() => {
|
|
125
|
+
vi.clearAllMocks();
|
|
126
|
+
api.fetchFileAccess.mockResolvedValue(VIEW);
|
|
127
|
+
api.suggestPrincipals.mockResolvedValue({ groups: [], people: [], peopleWithheld: false });
|
|
128
|
+
|
|
129
|
+
rects.clear();
|
|
130
|
+
watchers = [];
|
|
131
|
+
menuHeight = 0;
|
|
132
|
+
|
|
133
|
+
vi.spyOn(HTMLElement.prototype, 'getBoundingClientRect').mockImplementation(function (
|
|
134
|
+
this: HTMLElement,
|
|
135
|
+
) {
|
|
136
|
+
return rects.get(this) ?? NO_RECT;
|
|
137
|
+
});
|
|
138
|
+
offsetHeightDescriptor = Object.getOwnPropertyDescriptor(HTMLElement.prototype, 'offsetHeight');
|
|
139
|
+
Object.defineProperty(HTMLElement.prototype, 'offsetHeight', {
|
|
140
|
+
configurable: true,
|
|
141
|
+
get(this: HTMLElement) {
|
|
142
|
+
return this.classList.contains('fixed') ? menuHeight : 0;
|
|
143
|
+
},
|
|
144
|
+
});
|
|
145
|
+
for (const [k, v] of Object.entries(VIEWPORT)) {
|
|
146
|
+
Object.defineProperty(window, k === 'width' ? 'innerWidth' : 'innerHeight', {
|
|
147
|
+
configurable: true,
|
|
148
|
+
writable: true,
|
|
149
|
+
value: v,
|
|
150
|
+
});
|
|
151
|
+
}
|
|
152
|
+
vi.stubGlobal('ResizeObserver', TestResizeObserver);
|
|
153
|
+
});
|
|
154
|
+
|
|
155
|
+
afterEach(() => {
|
|
156
|
+
vi.restoreAllMocks();
|
|
157
|
+
vi.unstubAllGlobals();
|
|
158
|
+
if (offsetHeightDescriptor) {
|
|
159
|
+
Object.defineProperty(HTMLElement.prototype, 'offsetHeight', offsetHeightDescriptor);
|
|
160
|
+
} else {
|
|
161
|
+
delete (HTMLElement.prototype as unknown as Record<string, unknown>).offsetHeight;
|
|
162
|
+
}
|
|
163
|
+
});
|
|
164
|
+
|
|
165
|
+
/**
|
|
166
|
+
* Open Alice's verb menu with her row's trigger sitting at `anchor`, and hand
|
|
167
|
+
* back both the trigger's anchor box and the open panel.
|
|
168
|
+
*
|
|
169
|
+
* The add-row's verb selector reads "Can edit" too; Alice's row trigger is the
|
|
170
|
+
* later one in the DOM. The rect has to be registered BEFORE the click — the
|
|
171
|
+
* placement runs in a layout effect on the render that opens the menu.
|
|
172
|
+
*/
|
|
173
|
+
async function openAliceMenu(
|
|
174
|
+
user: ReturnType<typeof userEvent.setup>,
|
|
175
|
+
anchor: { top: number; left: number; width: number; height: number },
|
|
176
|
+
) {
|
|
177
|
+
const triggers = await screen.findAllByRole('button', { name: /^can edit$/i });
|
|
178
|
+
const trigger = triggers[triggers.length - 1];
|
|
179
|
+
const anchorEl = trigger.parentElement!;
|
|
180
|
+
setRect(anchorEl, anchor);
|
|
181
|
+
|
|
182
|
+
await user.click(trigger);
|
|
183
|
+
|
|
184
|
+
const panel = screen
|
|
185
|
+
.getByRole('button', { name: /remove access/i })
|
|
186
|
+
.closest('div.fixed') as HTMLElement;
|
|
187
|
+
return { anchorEl, panel };
|
|
188
|
+
}
|
|
189
|
+
|
|
190
|
+
/**
|
|
191
|
+
* WHERE AN OPEN MENU IS PLACED.
|
|
192
|
+
*
|
|
193
|
+
* `Dialog` renders its body inside `overflow-y-auto`, which clips an
|
|
194
|
+
* absolutely positioned menu: opening the verb menu on a low grantee row cut
|
|
195
|
+
* everything past the first item or two — "Remove access" included — off at
|
|
196
|
+
* the body's edge, unreachable without scrolling the list out from under the
|
|
197
|
+
* menu. The menus are `fixed` now, which means the placement is computed
|
|
198
|
+
* rather than inherited, and has to keep up with everything that moves it.
|
|
199
|
+
*/
|
|
200
|
+
describe('ManageAccessDialog: where an open menu is placed', () => {
|
|
201
|
+
it('escapes the dialog body by going fixed, at coordinates measured off the trigger', async () => {
|
|
202
|
+
const user = userEvent.setup();
|
|
203
|
+
menuHeight = 150;
|
|
204
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
205
|
+
|
|
206
|
+
// A trigger low in a scrolled list — the case that used to be clipped.
|
|
207
|
+
const { panel } = await openAliceMenu(user, { top: 600, left: 700, width: 120, height: 28 });
|
|
208
|
+
|
|
209
|
+
expect(panel).toHaveClass('fixed');
|
|
210
|
+
// Right edge lines up with the trigger's: 820 - 200.
|
|
211
|
+
expect(panel.style.left).toBe('620px');
|
|
212
|
+
// Below the trigger, MENU_GAP under its bottom edge: 628 + 4.
|
|
213
|
+
expect(panel.style.top).toBe('632px');
|
|
214
|
+
expect(panel.style.width).toBe(`${MENU_W}px`);
|
|
215
|
+
// NOT portaled: the panel stays inside the dialog, whose focus trap only
|
|
216
|
+
// queries its own subtree, so the items remain Tab-reachable.
|
|
217
|
+
expect(screen.getByRole('dialog').contains(panel)).toBe(true);
|
|
218
|
+
});
|
|
219
|
+
|
|
220
|
+
it('flips above the trigger when the panel would run off the bottom', async () => {
|
|
221
|
+
const user = userEvent.setup();
|
|
222
|
+
menuHeight = 200; // 632 + 200 overruns the 800px viewport
|
|
223
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
224
|
+
|
|
225
|
+
const { panel } = await openAliceMenu(user, { top: 600, left: 700, width: 120, height: 28 });
|
|
226
|
+
|
|
227
|
+
// Above: trigger top - MENU_GAP - height = 600 - 4 - 200.
|
|
228
|
+
expect(panel.style.top).toBe('396px');
|
|
229
|
+
});
|
|
230
|
+
|
|
231
|
+
it('re-anchors when the trigger relabels itself and changes width', async () => {
|
|
232
|
+
const user = userEvent.setup();
|
|
233
|
+
menuHeight = 150;
|
|
234
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
235
|
+
|
|
236
|
+
const { anchorEl, panel } = await openAliceMenu(user, {
|
|
237
|
+
top: 600, left: 700, width: 120, height: 28,
|
|
238
|
+
});
|
|
239
|
+
expect(panel.style.left).toBe('620px');
|
|
240
|
+
|
|
241
|
+
// The trigger's label IS `summarizeVerbs(...)`, so ticking a box in the
|
|
242
|
+
// open menu rewrites it ("Can edit" → "Owner, Can download") and the box
|
|
243
|
+
// grows. No scroll, no window resize — nothing else tells the menu.
|
|
244
|
+
setRect(anchorEl, { top: 600, left: 700, width: 180, height: 28 });
|
|
245
|
+
resize(anchorEl);
|
|
246
|
+
|
|
247
|
+
// Still flush with the trigger's right edge: 880 - 200.
|
|
248
|
+
expect(panel.style.left).toBe('680px');
|
|
249
|
+
});
|
|
250
|
+
|
|
251
|
+
it('re-flips when the panel itself grows past the room below', async () => {
|
|
252
|
+
const user = userEvent.setup();
|
|
253
|
+
menuHeight = 150;
|
|
254
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
255
|
+
|
|
256
|
+
const { panel } = await openAliceMenu(user, { top: 600, left: 700, width: 120, height: 28 });
|
|
257
|
+
expect(panel.style.top).toBe('632px');
|
|
258
|
+
|
|
259
|
+
// The panel's own height follows its contents — the autocomplete's list
|
|
260
|
+
// grows and shrinks with every keystroke — so a menu measured to fit below
|
|
261
|
+
// stops fitting while it is open.
|
|
262
|
+
menuHeight = 200;
|
|
263
|
+
resize(panel);
|
|
264
|
+
|
|
265
|
+
expect(panel.style.top).toBe('396px');
|
|
266
|
+
});
|
|
267
|
+
|
|
268
|
+
it('keeps the panel inside the viewport when the trigger is at the right edge', async () => {
|
|
269
|
+
const user = userEvent.setup();
|
|
270
|
+
menuHeight = 150;
|
|
271
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
272
|
+
|
|
273
|
+
// A trigger whose right edge is past the viewport's — the dialog is wider
|
|
274
|
+
// than the window, or the window shrank under it.
|
|
275
|
+
const { panel } = await openAliceMenu(user, { top: 100, left: 1170, width: 40, height: 28 });
|
|
276
|
+
|
|
277
|
+
// Flush with the trigger would be 1210 - 200 = 1010, off the right edge.
|
|
278
|
+
// Pulled in to leave MENU_MARGIN: 1200 - 200 - 8.
|
|
279
|
+
expect(panel.style.left).toBe('992px');
|
|
280
|
+
});
|
|
281
|
+
});
|
|
@@ -43,7 +43,7 @@ async function openAndUncheckEdit(user: ReturnType<typeof userEvent.setup>) {
|
|
|
43
43
|
await user.click(editItems[editItems.length - 1]);
|
|
44
44
|
}
|
|
45
45
|
|
|
46
|
-
describe('ManageAccessDialog
|
|
46
|
+
describe('ManageAccessDialog: unchecking an inherited verb on a mixed row', () => {
|
|
47
47
|
beforeEach(() => {
|
|
48
48
|
vi.clearAllMocks();
|
|
49
49
|
api.suggestPrincipals.mockResolvedValue({ groups: [], people: [], peopleWithheld: false });
|
|
@@ -128,3 +128,168 @@ describe('ManageAccessDialog — unchecking an inherited verb on a mixed row', (
|
|
|
128
128
|
);
|
|
129
129
|
});
|
|
130
130
|
});
|
|
131
|
+
|
|
132
|
+
/**
|
|
133
|
+
* Which BRANCH an access edit lands on.
|
|
134
|
+
*
|
|
135
|
+
* The file explorer edits the branch the user is looking at, so the ambient
|
|
136
|
+
* workspace is the right default and stays the default. The Library is the
|
|
137
|
+
* other case entirely: it describes the default branch no matter which branch
|
|
138
|
+
* happens to be open, so a group's access edit has to be pinned. Without the
|
|
139
|
+
* pin the same click would splice `access.md` on a draft — a rule that looks
|
|
140
|
+
* written and governs nothing.
|
|
141
|
+
*/
|
|
142
|
+
describe('ManageAccessDialog: which workspace the edit targets', () => {
|
|
143
|
+
const PINNED = 'target-company-state';
|
|
144
|
+
|
|
145
|
+
/** Alice, granted `write` directly here — one row, one editable checklist. */
|
|
146
|
+
const VIEW = {
|
|
147
|
+
canRead: true,
|
|
148
|
+
canWrite: true,
|
|
149
|
+
canDownload: false,
|
|
150
|
+
canOwner: false,
|
|
151
|
+
eligible: { roles: [], users: [A] },
|
|
152
|
+
readers: { restricted: true, roles: [], users: [A] },
|
|
153
|
+
owners: { roles: [], users: [] },
|
|
154
|
+
downloaders: { roles: [], users: [] },
|
|
155
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'direct' }], write: [{ kind: 'direct' }] } },
|
|
156
|
+
} as AccessResponse;
|
|
157
|
+
|
|
158
|
+
/** Check "Can download" on Alice's row — the shortest path to a grant call. */
|
|
159
|
+
async function grantDownloadToAlice(user: ReturnType<typeof userEvent.setup>) {
|
|
160
|
+
// The add-row's verb selector also reads "Can edit"; Alice's row trigger is
|
|
161
|
+
// the later one in the DOM.
|
|
162
|
+
const triggers = await screen.findAllByRole('button', { name: /^can edit$/i });
|
|
163
|
+
await user.click(triggers[triggers.length - 1]);
|
|
164
|
+
await user.click(await screen.findByRole('button', { name: /^can download$/i }));
|
|
165
|
+
}
|
|
166
|
+
|
|
167
|
+
beforeEach(() => {
|
|
168
|
+
vi.clearAllMocks();
|
|
169
|
+
api.suggestPrincipals.mockResolvedValue({ groups: [], people: [], peopleWithheld: false });
|
|
170
|
+
api.fetchFileAccess.mockResolvedValue(VIEW);
|
|
171
|
+
api.grantAccess.mockResolvedValue(VIEW);
|
|
172
|
+
});
|
|
173
|
+
|
|
174
|
+
it('reads and writes the workspace given by the prop, not the ambient one', async () => {
|
|
175
|
+
const user = userEvent.setup();
|
|
176
|
+
render(<ManageAccessDialog entry={ENTRY} workspaceId={PINNED} onClose={() => {}} />);
|
|
177
|
+
|
|
178
|
+
await waitFor(() =>
|
|
179
|
+
expect(api.fetchFileAccess).toHaveBeenCalledWith(PINNED, 'Sales/Deal.md', 'file'),
|
|
180
|
+
);
|
|
181
|
+
expect(api.fetchFileAccess).not.toHaveBeenCalledWith('ws-1', expect.anything(), expect.anything());
|
|
182
|
+
|
|
183
|
+
await grantDownloadToAlice(user);
|
|
184
|
+
|
|
185
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
186
|
+
expect(api.grantAccess).toHaveBeenCalledWith(
|
|
187
|
+
PINNED,
|
|
188
|
+
expect.objectContaining({ verb: 'download' }),
|
|
189
|
+
);
|
|
190
|
+
});
|
|
191
|
+
|
|
192
|
+
it('falls back to the ambient workspace when the prop is absent', async () => {
|
|
193
|
+
const user = userEvent.setup();
|
|
194
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
195
|
+
|
|
196
|
+
await waitFor(() =>
|
|
197
|
+
expect(api.fetchFileAccess).toHaveBeenCalledWith('ws-1', 'Sales/Deal.md', 'file'),
|
|
198
|
+
);
|
|
199
|
+
|
|
200
|
+
await grantDownloadToAlice(user);
|
|
201
|
+
|
|
202
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
203
|
+
expect(api.grantAccess).toHaveBeenCalledWith('ws-1', expect.objectContaining({ verb: 'download' }));
|
|
204
|
+
});
|
|
205
|
+
});
|
|
206
|
+
|
|
207
|
+
// ── the sheet's two headings, and what they name ──
|
|
208
|
+
//
|
|
209
|
+
// The direct section used to read "People with access" and every inherited
|
|
210
|
+
// grant collapsed into one "Inherited access (N) — from parent folders &
|
|
211
|
+
// roles" disclosure. Both were named after the CONCEPT rather than the thing:
|
|
212
|
+
// the reader could not tell which of the two lists was the rule set HERE, and
|
|
213
|
+
// a merged inherited list threw away the only fact that makes an inherited
|
|
214
|
+
// grant actionable — which folder to go and edit (proto:3625, 3637-3649).
|
|
215
|
+
describe('ManageAccessDialog: naming the rules', () => {
|
|
216
|
+
beforeEach(() => {
|
|
217
|
+
vi.clearAllMocks();
|
|
218
|
+
api.suggestPrincipals.mockResolvedValue({ users: [], groups: [], peopleWithheld: false });
|
|
219
|
+
});
|
|
220
|
+
|
|
221
|
+
/** The real AccessResponse shape — see the passing fixture above. */
|
|
222
|
+
const view = (over: Partial<AccessResponse> = {}): AccessResponse =>
|
|
223
|
+
({
|
|
224
|
+
canRead: true,
|
|
225
|
+
canWrite: true,
|
|
226
|
+
canDownload: false,
|
|
227
|
+
canOwner: false,
|
|
228
|
+
eligible: { roles: [], users: [] },
|
|
229
|
+
readers: { restricted: true, roles: [], users: [] },
|
|
230
|
+
owners: { roles: [], users: [] },
|
|
231
|
+
downloaders: { roles: [], users: [] },
|
|
232
|
+
sources: {},
|
|
233
|
+
...over,
|
|
234
|
+
}) as AccessResponse;
|
|
235
|
+
|
|
236
|
+
it('names the target in the direct heading, not the concept', async () => {
|
|
237
|
+
api.fetchFileAccess.mockResolvedValue(view());
|
|
238
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
239
|
+
expect(await screen.findByRole('heading', { name: /On this file/i })).toBeInTheDocument();
|
|
240
|
+
expect(screen.queryByRole('heading', { name: /People with access/i })).not.toBeInTheDocument();
|
|
241
|
+
});
|
|
242
|
+
|
|
243
|
+
it('gives each granting folder its own group, named after the folder', async () => {
|
|
244
|
+
api.fetchFileAccess.mockResolvedValue(
|
|
245
|
+
view({
|
|
246
|
+
readers: { restricted: true, roles: [], users: [A, { name: 'Bo', email: 'bo@x.com' }] },
|
|
247
|
+
sources: {
|
|
248
|
+
'u:alice@x.com': { read: [{ kind: 'ancestor', path: 'Sales/access.md' }] },
|
|
249
|
+
'u:bo@x.com': { read: [{ kind: 'ancestor', path: 'Sales/EMEA/access.md' }] },
|
|
250
|
+
},
|
|
251
|
+
}),
|
|
252
|
+
);
|
|
253
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
254
|
+
|
|
255
|
+
// One disclosure per folder — never one merged "Inherited access".
|
|
256
|
+
expect(await screen.findByRole('button', { name: /People invited to EMEA/ })).toBeInTheDocument();
|
|
257
|
+
expect(screen.getByRole('button', { name: /People invited to Sales/ })).toBeInTheDocument();
|
|
258
|
+
expect(screen.queryByRole('button', { name: /Inherited access/ })).not.toBeInTheDocument();
|
|
259
|
+
});
|
|
260
|
+
|
|
261
|
+
it('offers a way to the folder that owns the rule, and retargets the sheet', async () => {
|
|
262
|
+
const user = userEvent.setup();
|
|
263
|
+
const onManageAncestor = vi.fn();
|
|
264
|
+
api.fetchFileAccess.mockResolvedValue(
|
|
265
|
+
view({
|
|
266
|
+
readers: { restricted: true, roles: [], users: [A] },
|
|
267
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'ancestor', path: 'Sales/access.md' }] } },
|
|
268
|
+
}),
|
|
269
|
+
);
|
|
270
|
+
render(
|
|
271
|
+
<ManageAccessDialog entry={ENTRY} onClose={() => {}} onManageAncestor={onManageAncestor} />,
|
|
272
|
+
);
|
|
273
|
+
|
|
274
|
+
await user.click(await screen.findByRole('button', { name: /People invited to Sales/ }));
|
|
275
|
+
await user.click(await screen.findByRole('button', { name: /Manage Sales →/ }));
|
|
276
|
+
|
|
277
|
+
// The path handed back is workspace-relative, which is what the dialog takes.
|
|
278
|
+
expect(onManageAncestor).toHaveBeenCalledWith(
|
|
279
|
+
expect.objectContaining({ name: 'Sales', relativePath: `${KB}/Sales`, type: 'directory' }),
|
|
280
|
+
);
|
|
281
|
+
});
|
|
282
|
+
|
|
283
|
+
it('does not offer the link when the caller cannot retarget', async () => {
|
|
284
|
+
const user = userEvent.setup();
|
|
285
|
+
api.fetchFileAccess.mockResolvedValue(
|
|
286
|
+
view({
|
|
287
|
+
readers: { restricted: true, roles: [], users: [A] },
|
|
288
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'ancestor', path: 'Sales/access.md' }] } },
|
|
289
|
+
}),
|
|
290
|
+
);
|
|
291
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
292
|
+
await user.click(await screen.findByRole('button', { name: /People invited to Sales/ }));
|
|
293
|
+
expect(screen.queryByRole('button', { name: /Manage Sales →/ })).not.toBeInTheDocument();
|
|
294
|
+
});
|
|
295
|
+
});
|
|
@@ -203,3 +203,52 @@ export async function fetchFileAccessBatch(
|
|
|
203
203
|
);
|
|
204
204
|
}
|
|
205
205
|
|
|
206
|
+
/** A principal named by a rule, as the overrides endpoint reports it. */
|
|
207
|
+
export type AccessOverridePrincipal =
|
|
208
|
+
| { kind: 'role'; role: string }
|
|
209
|
+
| { kind: 'user'; email: string; name: string }
|
|
210
|
+
| { kind: 'everyone' };
|
|
211
|
+
|
|
212
|
+
/** One `verb: principal` line of a rule; `deny` mirrors the literal prefix. */
|
|
213
|
+
export interface AccessOverrideEntry {
|
|
214
|
+
verb: GrantVerb;
|
|
215
|
+
deny: boolean;
|
|
216
|
+
principal: AccessOverridePrincipal;
|
|
217
|
+
}
|
|
218
|
+
|
|
219
|
+
/**
|
|
220
|
+
* A file INSIDE a folder that declares its own access rules — a descendant
|
|
221
|
+
* `access.md` or a node's own frontmatter. `path` is the file that declares;
|
|
222
|
+
* `governs` is what the rules apply to (the containing directory for an
|
|
223
|
+
* `access.md`, the file itself for frontmatter). `parseError` is set, with
|
|
224
|
+
* `entries: []`, when an `access.md` could not be parsed.
|
|
225
|
+
*/
|
|
226
|
+
export interface AccessOverride {
|
|
227
|
+
path: string;
|
|
228
|
+
governs: string;
|
|
229
|
+
source: 'access-md' | 'frontmatter';
|
|
230
|
+
entries: AccessOverrideEntry[];
|
|
231
|
+
parseError?: string;
|
|
232
|
+
}
|
|
233
|
+
|
|
234
|
+
/**
|
|
235
|
+
* Every access rule declared inside `folder` (repo-relative). Display-only: a
|
|
236
|
+
* folder's share list is not the whole story, because resolution is
|
|
237
|
+
* closeness-first and a rule written on one item overrides the folder's rule
|
|
238
|
+
* for the principals it names.
|
|
239
|
+
*
|
|
240
|
+
* 403s for a caller who cannot read the folder, and drops rows governing
|
|
241
|
+
* anything they cannot read — so this can only ever describe rules on things
|
|
242
|
+
* the caller already sees.
|
|
243
|
+
*/
|
|
244
|
+
export async function fetchAccessOverrides(
|
|
245
|
+
workspaceId: string,
|
|
246
|
+
folder: string,
|
|
247
|
+
): Promise<{ overrides: AccessOverride[]; truncated: boolean }> {
|
|
248
|
+
return handleApiResponse(
|
|
249
|
+
await authFetch(
|
|
250
|
+
`/api/workspace/${workspaceId}/access/overrides?path=${encodeURIComponent(folder)}`,
|
|
251
|
+
),
|
|
252
|
+
);
|
|
253
|
+
}
|
|
254
|
+
|