@bevel-software/platform-core-frontend 0.4.1 → 0.5.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +5366 -0
- package/package.json +7 -4
- package/src/core/CoreAppShell.tsx +195 -56
- package/src/core/__tests__/AppChrome.test.tsx +125 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
- package/src/core/__tests__/bootstrap.test.ts +63 -0
- package/src/core/bootstrap.ts +73 -0
- package/src/core/events.ts +12 -0
- package/src/core/registry.ts +58 -9
- package/src/index.css +100 -11
- package/src/index.ts +24 -23
- package/src/lib/utils.ts +93 -117
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
- package/src/modules/access/api.ts +49 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
- package/src/modules/access/hooks/useFileAccess.ts +1 -1
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
- package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
- package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
- package/src/modules/admin/state/admin.context.tsx +15 -6
- package/src/modules/auth/components/AccountPage.tsx +11 -11
- package/src/modules/auth/components/LoginScreen.tsx +12 -12
- package/src/modules/auth/services/sso.ts +47 -1
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
- package/src/modules/change-requests/__tests__/author.test.ts +48 -0
- package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
- package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
- package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
- package/src/modules/change-requests/change-requests.css +22 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
- package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
- package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
- package/src/modules/change-requests/services/change-requests.api.ts +45 -0
- package/src/modules/change-requests/services/propose.api.ts +162 -0
- package/src/modules/change-requests/utils/author.ts +47 -0
- package/src/modules/change-requests/utils/conflict.ts +38 -0
- package/src/modules/change-requests/utils/diff.ts +80 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
- package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
- package/src/modules/git/components/BranchSwitcher.tsx +68 -31
- package/src/modules/git/components/DiffView.tsx +4 -4
- package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
- package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
- package/src/modules/git/components/PullNeededBanner.tsx +6 -13
- package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
- package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
- package/src/modules/git/hooks/useGitState.ts +15 -14
- package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
- package/src/modules/git/services/error-messages.ts +7 -7
- package/src/modules/git/services/git.api.ts +17 -11
- package/src/modules/git/services/pr-prompts.ts +2 -2
- package/src/modules/git/state/git.context.ts +10 -1
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
- package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
- package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
- package/src/modules/layout/breakpoints.ts +6 -0
- package/src/modules/layout/components/AppLayout.tsx +17 -5
- package/src/modules/layout/components/DemoBanner.tsx +10 -1
- package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
- package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
- package/src/modules/layout/components/SidebarFrame.tsx +317 -0
- package/src/modules/layout/components/SidebarToggle.tsx +86 -0
- package/src/modules/layout/components/SlideOverlay.tsx +1 -1
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
- package/src/modules/layout/state/sidebar.ts +200 -0
- package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
- package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
- package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
- package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
- package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
- package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
- package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
- package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
- package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
- package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
- package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
- package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
- package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
- package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
- package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
- package/src/modules/library/__tests__/auth-harness.tsx +37 -0
- package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
- package/src/modules/library/__tests__/status.test.ts +113 -20
- package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
- package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
- package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
- package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
- package/src/modules/library/components/GroupIndexRow.tsx +63 -0
- package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
- package/src/modules/library/components/GroupPage.tsx +373 -0
- package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
- package/src/modules/library/components/GroupsSidebar.tsx +338 -0
- package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
- package/src/modules/library/components/LibraryCard.tsx +123 -102
- package/src/modules/library/components/LibraryLayout.tsx +344 -0
- package/src/modules/library/components/LibraryPage.tsx +111 -227
- package/src/modules/library/components/LockGlyph.tsx +31 -0
- package/src/modules/library/components/LockedGroupView.tsx +159 -0
- package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
- package/src/modules/library/components/NewGroupDialog.tsx +112 -0
- package/src/modules/library/components/NewSkillPanel.tsx +151 -0
- package/src/modules/library/components/PageActions.tsx +156 -0
- package/src/modules/library/components/PendingSkillReview.tsx +63 -0
- package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
- package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
- package/src/modules/library/components/StatusDot.tsx +25 -0
- package/src/modules/library/components/ToolLogo.tsx +171 -0
- package/src/modules/library/components/group-page-parts.tsx +419 -0
- package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
- package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
- package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
- package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
- package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
- package/src/modules/library/hooks/useJoinRequests.ts +114 -0
- package/src/modules/library/hooks/useLibraryData.ts +134 -119
- package/src/modules/library/hooks/useSkillDetail.ts +119 -74
- package/src/modules/library/hooks/useToolPage.ts +145 -0
- package/src/modules/library/library.css +33 -245
- package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
- package/src/modules/library/routes/library-paths.ts +191 -0
- package/src/modules/library/services/groups.api.ts +189 -0
- package/src/modules/library/services/library.api.ts +291 -164
- package/src/modules/library/services/tools.api.ts +60 -0
- package/src/modules/library/state/library-context.ts +22 -0
- package/src/modules/library/state/library-data.tsx +223 -0
- package/src/modules/library/state/toast.context.ts +32 -0
- package/src/modules/library/state/toast.tsx +84 -42
- package/src/modules/library/utils/clipboard.ts +33 -0
- package/src/modules/library/utils/group-summary.ts +68 -0
- package/src/modules/library/utils/names.ts +30 -0
- package/src/modules/library/utils/navigate-external.ts +15 -0
- package/src/modules/library/utils/oauth-fragment.ts +32 -0
- package/src/modules/library/utils/personal-group.ts +36 -0
- package/src/modules/library/utils/status.ts +108 -25
- package/src/modules/library/utils/toast-duration.ts +16 -0
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
- package/src/modules/onboarding/agent-clients.ts +48 -0
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
- package/src/modules/onboarding/components/RootLanding.tsx +54 -0
- package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
- package/src/modules/onboarding/paths.ts +9 -0
- package/src/modules/onboarding/state/onboarding.ts +191 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
- package/src/modules/pr/services/pr-approvals.api.ts +19 -0
- package/src/modules/pr/services/pr-cancel.api.ts +11 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
- package/src/modules/review/components/DiffViewer.tsx +4 -4
- package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
- package/src/modules/review/components/ReviewFileRow.tsx +10 -10
- package/src/modules/review/components/ReviewPanel.tsx +49 -17
- package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
- package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
- package/src/modules/secrets-vault/services/connect.api.ts +24 -3
- package/src/modules/settings/components/DeploymentPage.tsx +90 -0
- package/src/modules/settings/components/SettingsLayout.tsx +135 -0
- package/src/modules/settings/components/SettingsNav.tsx +114 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
- package/src/modules/settings/settings-nav-items.tsx +166 -0
- package/src/modules/setup/__tests__/setup.test.tsx +540 -0
- package/src/modules/setup/components/SetupGate.tsx +67 -0
- package/src/modules/setup/components/SetupScreen.tsx +573 -0
- package/src/modules/setup/services/setup.api.ts +106 -0
- package/src/modules/setup/utils/git-host.ts +34 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
- package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
- package/src/modules/toolbar/components/Toolbar.tsx +56 -54
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
- package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
- package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
- package/src/modules/workspace/components/EditorTabs.tsx +82 -50
- package/src/modules/workspace/components/FileExplorer.tsx +413 -189
- package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
- package/src/modules/workspace/components/FileRoute.tsx +89 -84
- package/src/modules/workspace/components/FileViewer.tsx +700 -294
- package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
- package/src/modules/workspace/components/KbFileRail.tsx +128 -0
- package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
- package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
- package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
- package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
- package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
- package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
- package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
- package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
- package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
- package/src/modules/workspace/components/renderers/index.ts +78 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
- package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
- package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
- package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
- package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
- package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
- package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
- package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
- package/src/modules/workspace/services/workspace.api.ts +9 -2
- package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
- package/src/modules/workspace/state/open-change-requests.tsx +185 -0
- package/src/modules/workspace/state/workspace.context.ts +9 -0
- package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
- package/src/modules/workspace/utils/diff.ts +130 -53
- package/src/modules/workspace/utils/fileTree.ts +7 -4
- package/src/modules/workspace/workspace.css +28 -0
- package/src/shared/components/Badge.tsx +62 -0
- package/src/shared/components/Banner.tsx +58 -0
- package/src/shared/components/Button.tsx +90 -0
- package/src/shared/components/Dialog.tsx +6 -6
- package/src/shared/components/Field.tsx +45 -0
- package/src/shared/components/IconButton.tsx +74 -0
- package/src/shared/components/ListRow.tsx +96 -0
- package/src/shared/components/Menu.tsx +88 -0
- package/src/shared/components/PageShell.tsx +8 -5
- package/src/shared/components/Surface.tsx +86 -0
- package/src/shared/components/__tests__/primitives.test.tsx +333 -0
- package/src/shared/components/index.ts +48 -0
- package/src/shared/components/useDismissableMenu.ts +71 -0
- package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
- package/src/shared/theme/index.css +12 -0
- package/src/shared/theme/measure.ts +64 -0
- package/src/shared/theme/shadows.css +34 -0
- package/src/shared/theme/tokens.css +193 -0
- package/src/test-setup.ts +9 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
- package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
- package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
- package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
- package/src/modules/library/__tests__/diff.test.ts +0 -62
- package/src/modules/library/__tests__/loadout.test.tsx +0 -72
- package/src/modules/library/components/CompareView.tsx +0 -357
- package/src/modules/library/components/DetailDialog.tsx +0 -566
- package/src/modules/library/components/GearIcon.tsx +0 -12
- package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
- package/src/modules/library/components/StatusGem.tsx +0 -21
- package/src/modules/library/components/SuggestChange.tsx +0 -171
- package/src/modules/library/components/particles.ts +0 -50
- package/src/modules/library/state/loadout.tsx +0 -129
- package/src/modules/library/utils/diff.ts +0 -102
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
- package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
- package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
- package/src/modules/pr/components/PrCancelButton.tsx +0 -99
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
- package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
- package/src/modules/pr/components/PrCommentThread.tsx +0 -168
- package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
- package/src/modules/pr/components/PrDiffPane.tsx +0 -425
- package/src/modules/pr/components/PrFileRow.tsx +0 -164
- package/src/modules/pr/components/PrFilesList.tsx +0 -53
- package/src/modules/pr/components/PrHeader.tsx +0 -45
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
- package/src/modules/pr/components/PrMergeButton.tsx +0 -268
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
- package/src/modules/pr/components/PrViewer.tsx +0 -364
- package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
- package/src/modules/pr/state/pr-viewer.context.ts +0 -34
- package/src/modules/pr/utils/bucketize-comments.ts +0 -55
- package/src/modules/pr/utils/parsePatch.ts +0 -57
- package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
|
@@ -1,12 +1,15 @@
|
|
|
1
1
|
import { describe, it, expect } from 'vitest';
|
|
2
2
|
import type { ToolSecrets } from '../../secrets-vault/services/tool-secrets.api';
|
|
3
3
|
import {
|
|
4
|
+
emptyMessageFor,
|
|
4
5
|
filterLibraryItems,
|
|
6
|
+
groupCounts,
|
|
5
7
|
neededToolsFor,
|
|
6
8
|
skillStatus,
|
|
7
9
|
toolStatus,
|
|
8
10
|
type LibraryFilterable,
|
|
9
11
|
} from '../utils/status';
|
|
12
|
+
import { toastDuration } from '../utils/toast-duration';
|
|
10
13
|
|
|
11
14
|
function tool(overrides: Partial<ToolSecrets>): ToolSecrets {
|
|
12
15
|
return {
|
|
@@ -48,14 +51,16 @@ describe('toolStatus', () => {
|
|
|
48
51
|
expect(toolStatus(expired).state).toBe('err');
|
|
49
52
|
});
|
|
50
53
|
|
|
51
|
-
it('flags a missing shared value
|
|
54
|
+
it('flags a missing shared value in AMBER, and says what it needs', () => {
|
|
52
55
|
const t = tool({
|
|
53
56
|
variables: [
|
|
54
57
|
{ name: 'API_KEY', scope: 'admin', label: null, key: 'k', adminConfigured: false, userConfigured: false },
|
|
55
58
|
],
|
|
56
59
|
});
|
|
57
|
-
|
|
58
|
-
|
|
60
|
+
// Never grey. Grey read as "disabled" or "not your problem", when an
|
|
61
|
+
// unconfigured integration is the state that most needs somebody.
|
|
62
|
+
expect(toolStatus(t)).toEqual({ state: 'warn', text: 'Needs setup' });
|
|
63
|
+
expect(toolStatus(tool({ ...t, canWrite: true })).text).toBe('Needs setup: yours to set up');
|
|
59
64
|
});
|
|
60
65
|
});
|
|
61
66
|
|
|
@@ -77,41 +82,129 @@ describe('neededToolsFor / skillStatus', () => {
|
|
|
77
82
|
|
|
78
83
|
it('skill is ready only when every needed integration is connected', () => {
|
|
79
84
|
expect(skillStatus([slack]).state).toBe('ok');
|
|
80
|
-
expect(skillStatus([slack, notion])).toEqual({ state: 'warn', text: 'Needs setup' });
|
|
81
85
|
expect(skillStatus([]).state).toBe('ok');
|
|
82
86
|
});
|
|
87
|
+
|
|
88
|
+
it('names the integration standing in the skill\'s way, not just that one is', () => {
|
|
89
|
+
// The first unhealthy one: fixing it either unblocks the skill or reveals
|
|
90
|
+
// the next name, and "Needs setup" told you neither.
|
|
91
|
+
expect(skillStatus([slack, notion])).toEqual({ state: 'warn', text: `Needs ${notion.name}` });
|
|
92
|
+
});
|
|
83
93
|
});
|
|
84
94
|
|
|
85
|
-
describe('filterLibraryItems (
|
|
95
|
+
describe('filterLibraryItems (sidebar selection + search)', () => {
|
|
86
96
|
const items: LibraryFilterable[] = [
|
|
87
|
-
{ kind: 'skill', name: 'Weekly newsletter', description: 'drafts the Friday newsletter', owned: true },
|
|
88
|
-
{ kind: 'skill', name: 'RFI responder', description: 'answers requests', owned: false },
|
|
89
|
-
{ kind: 'integration', name: 'Slack', description: 'messages', owned: false },
|
|
90
|
-
{ kind: 'integration', name: 'GitHub', description: 'code and change requests', owned: true },
|
|
97
|
+
{ kind: 'skill', name: 'Weekly newsletter', description: 'drafts the Friday newsletter', owned: true, group: 'Everyone' },
|
|
98
|
+
{ kind: 'skill', name: 'RFI responder', description: 'answers requests', owned: false, group: 'GTM' },
|
|
99
|
+
{ kind: 'integration', name: 'Slack', description: 'messages', owned: false, group: 'Everyone' },
|
|
100
|
+
{ kind: 'integration', name: 'GitHub', description: 'code and change requests', owned: true, group: null },
|
|
91
101
|
];
|
|
92
102
|
|
|
93
|
-
it('narrows by
|
|
94
|
-
expect(filterLibraryItems(items, '
|
|
103
|
+
it('narrows to a group. Skills and tools together, not split by kind', () => {
|
|
104
|
+
expect(filterLibraryItems(items, { kind: 'group', group: 'Everyone' }, '').map((i) => i.name)).toEqual([
|
|
95
105
|
'Weekly newsletter',
|
|
96
|
-
'RFI responder',
|
|
97
|
-
]);
|
|
98
|
-
expect(filterLibraryItems(items, 'integrations', '').map((i) => i.name)).toEqual([
|
|
99
106
|
'Slack',
|
|
100
|
-
'GitHub',
|
|
101
107
|
]);
|
|
102
|
-
|
|
108
|
+
});
|
|
109
|
+
|
|
110
|
+
it('narrows to owned, and to the ungrouped bucket', () => {
|
|
111
|
+
expect(filterLibraryItems(items, { kind: 'owned' }, '').map((i) => i.name)).toEqual([
|
|
103
112
|
'Weekly newsletter',
|
|
104
113
|
'GitHub',
|
|
105
114
|
]);
|
|
115
|
+
expect(filterLibraryItems(items, { kind: 'ungrouped' }, '').map((i) => i.name)).toEqual([
|
|
116
|
+
'GitHub',
|
|
117
|
+
]);
|
|
106
118
|
});
|
|
107
119
|
|
|
108
|
-
it('
|
|
109
|
-
expect(filterLibraryItems(items, '
|
|
120
|
+
it('"all" keeps everything, including ungrouped items', () => {
|
|
121
|
+
expect(filterLibraryItems(items, { kind: 'all' }, '')).toHaveLength(4);
|
|
122
|
+
});
|
|
123
|
+
|
|
124
|
+
it('search matches name or description within the selection, case-insensitively', () => {
|
|
125
|
+
expect(filterLibraryItems(items, { kind: 'all' }, 'friday').map((i) => i.name)).toEqual([
|
|
110
126
|
'Weekly newsletter',
|
|
111
127
|
]);
|
|
112
|
-
expect(filterLibraryItems(items, '
|
|
128
|
+
expect(filterLibraryItems(items, { kind: 'all' }, 'CHANGE').map((i) => i.name)).toEqual([
|
|
113
129
|
'GitHub',
|
|
114
130
|
]);
|
|
115
|
-
|
|
131
|
+
// The query is applied INSIDE the selection, so a match outside it stays out.
|
|
132
|
+
expect(filterLibraryItems(items, { kind: 'group', group: 'GTM' }, 'slack')).toEqual([]);
|
|
133
|
+
});
|
|
134
|
+
});
|
|
135
|
+
|
|
136
|
+
describe('groupCounts', () => {
|
|
137
|
+
it('counts per group, skips ungrouped, and sorts by name not by count', () => {
|
|
138
|
+
const items: LibraryFilterable[] = [
|
|
139
|
+
{ kind: 'skill', name: 'a', description: '', owned: false, group: 'Zeta' },
|
|
140
|
+
{ kind: 'skill', name: 'b', description: '', owned: false, group: 'Alpha' },
|
|
141
|
+
{ kind: 'integration', name: 'c', description: '', owned: false, group: 'Zeta' },
|
|
142
|
+
{ kind: 'skill', name: 'd', description: '', owned: false, group: null },
|
|
143
|
+
];
|
|
144
|
+
// Alpha first despite having fewer items — a nav that reorders itself when
|
|
145
|
+
// a group gains an item moves under the pointer.
|
|
146
|
+
expect(groupCounts(items)).toEqual([
|
|
147
|
+
{ group: 'Alpha', count: 1 },
|
|
148
|
+
{ group: 'Zeta', count: 2 },
|
|
149
|
+
]);
|
|
150
|
+
});
|
|
151
|
+
|
|
152
|
+
it('is empty when nothing is grouped', () => {
|
|
153
|
+
expect(groupCounts([{ kind: 'skill', name: 'a', description: '', owned: true, group: null }])).toEqual([]);
|
|
154
|
+
});
|
|
155
|
+
});
|
|
156
|
+
|
|
157
|
+
describe('emptyMessageFor', () => {
|
|
158
|
+
/**
|
|
159
|
+
* An empty view and a failed search are different facts, and saying the
|
|
160
|
+
* wrong one is worse than saying nothing: told "you're not responsible for
|
|
161
|
+
* changes in any skills yet" after mistyping a search, you would believe the
|
|
162
|
+
* shelf was empty rather than that you had missed.
|
|
163
|
+
*/
|
|
164
|
+
it('names why the view is empty when nobody searched', () => {
|
|
165
|
+
expect(emptyMessageFor({ kind: 'owned' }, '')).toBe(
|
|
166
|
+
"You're not responsible for changes in any skills yet.",
|
|
167
|
+
);
|
|
168
|
+
});
|
|
169
|
+
|
|
170
|
+
it('blames the search when there is one, in that same view', () => {
|
|
171
|
+
expect(emptyMessageFor({ kind: 'owned' }, 'postgres')).toBe('Nothing here matches yet.');
|
|
172
|
+
// Whitespace is not a search.
|
|
173
|
+
expect(emptyMessageFor({ kind: 'owned' }, ' ')).toBe(
|
|
174
|
+
"You're not responsible for changes in any skills yet.",
|
|
175
|
+
);
|
|
176
|
+
});
|
|
177
|
+
|
|
178
|
+
it('leaves the other views on the general wording', () => {
|
|
179
|
+
expect(emptyMessageFor({ kind: 'all' }, '')).toBe('Nothing here matches yet.');
|
|
180
|
+
expect(emptyMessageFor({ kind: 'ungrouped' }, '')).toBe('Nothing here matches yet.');
|
|
181
|
+
});
|
|
182
|
+
});
|
|
183
|
+
|
|
184
|
+
describe('toastDuration', () => {
|
|
185
|
+
/**
|
|
186
|
+
* The flat 2.6s was set when the only toast said "Copied". A 76-character
|
|
187
|
+
* confirmation on that budget is unreadable — the message is the whole point
|
|
188
|
+
* of a toast, so how long it stays has to follow how long it takes to read.
|
|
189
|
+
*/
|
|
190
|
+
it('gives a long message time to be read', () => {
|
|
191
|
+
const done = 'Done. Reopen the setup any time from your profile menu → External agent access.';
|
|
192
|
+
expect(toastDuration(done)).toBeGreaterThan(4500);
|
|
193
|
+
});
|
|
194
|
+
|
|
195
|
+
it('does not blink a short one', () => {
|
|
196
|
+
expect(toastDuration('Copied')).toBe(3000);
|
|
197
|
+
});
|
|
198
|
+
|
|
199
|
+
// Nothing camps on the screen: a runaway message is still a message you can
|
|
200
|
+
// ignore, but a permanent one is a bug wearing a toast.
|
|
201
|
+
it('caps however long the message is', () => {
|
|
202
|
+
expect(toastDuration('x'.repeat(5000))).toBe(9000);
|
|
203
|
+
});
|
|
204
|
+
|
|
205
|
+
it('is never shorter for a longer message', () => {
|
|
206
|
+
const lengths = [0, 10, 40, 80, 160, 400];
|
|
207
|
+
const times = lengths.map((n) => toastDuration('x'.repeat(n)));
|
|
208
|
+
expect([...times].sort((a, b) => a - b)).toEqual(times);
|
|
116
209
|
});
|
|
117
210
|
});
|
|
@@ -0,0 +1,102 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { renderHook, act, waitFor } from '@testing-library/react';
|
|
3
|
+
|
|
4
|
+
const api = vi.hoisted(() => ({ getSkill: vi.fn(), getSkillFile: vi.fn() }));
|
|
5
|
+
vi.mock('../services/library.api', () => ({
|
|
6
|
+
getSkill: api.getSkill,
|
|
7
|
+
getSkillFile: api.getSkillFile,
|
|
8
|
+
}));
|
|
9
|
+
|
|
10
|
+
import { useSkillDetail } from '../hooks/useSkillDetail';
|
|
11
|
+
|
|
12
|
+
const skill = {
|
|
13
|
+
name: 'newsletter',
|
|
14
|
+
description: 'Drafts the Friday newsletter.',
|
|
15
|
+
path: 'Skills/newsletter',
|
|
16
|
+
body: 'before',
|
|
17
|
+
allowedTools: [],
|
|
18
|
+
files: ['Skills/newsletter/sources.yaml'],
|
|
19
|
+
};
|
|
20
|
+
|
|
21
|
+
beforeEach(() => {
|
|
22
|
+
api.getSkill.mockReset().mockResolvedValue(skill);
|
|
23
|
+
api.getSkillFile.mockReset().mockResolvedValue('sources: before');
|
|
24
|
+
});
|
|
25
|
+
|
|
26
|
+
describe('useSkillDetail', () => {
|
|
27
|
+
/**
|
|
28
|
+
* A bundled-file read started before a reload resolves AFTER it, carrying the
|
|
29
|
+
* file as it read before the merge. Letting that land would poison the map
|
|
30
|
+
* the reload just cleared — and the `contents[relFile]` guard would then
|
|
31
|
+
* treat the file as fetched and never ask again, so the stale tab stays
|
|
32
|
+
* stale for as long as the page is open.
|
|
33
|
+
*/
|
|
34
|
+
it('drops a bundled-file read that a reload has overtaken', async () => {
|
|
35
|
+
let releaseStale!: (v: string) => void;
|
|
36
|
+
api.getSkillFile.mockImplementationOnce(
|
|
37
|
+
() =>
|
|
38
|
+
new Promise<string>((res) => {
|
|
39
|
+
releaseStale = res;
|
|
40
|
+
}),
|
|
41
|
+
);
|
|
42
|
+
|
|
43
|
+
const { result } = renderHook(() => useSkillDetail('newsletter'));
|
|
44
|
+
await waitFor(() => expect(result.current.skill).not.toBeNull());
|
|
45
|
+
|
|
46
|
+
act(() => result.current.loadFile('sources.yaml'));
|
|
47
|
+
expect(api.getSkillFile).toHaveBeenCalledTimes(1);
|
|
48
|
+
|
|
49
|
+
// The merge lands; the first read is still in flight.
|
|
50
|
+
api.getSkill.mockResolvedValue({ ...skill, body: 'after' });
|
|
51
|
+
api.getSkillFile.mockResolvedValue('sources: after');
|
|
52
|
+
act(() => result.current.reload());
|
|
53
|
+
await waitFor(() => expect(result.current.skill?.body).toBe('after'));
|
|
54
|
+
|
|
55
|
+
// The re-issued read wins…
|
|
56
|
+
act(() => result.current.loadFile('sources.yaml'));
|
|
57
|
+
await waitFor(() => expect(result.current.fileContent('sources.yaml')).toBe('sources: after'));
|
|
58
|
+
|
|
59
|
+
// …and the overtaken one cannot claw the tab back to its old contents.
|
|
60
|
+
await act(async () => {
|
|
61
|
+
releaseStale('sources: before');
|
|
62
|
+
});
|
|
63
|
+
expect(result.current.fileContent('sources.yaml')).toBe('sources: after');
|
|
64
|
+
});
|
|
65
|
+
|
|
66
|
+
/**
|
|
67
|
+
* A reload keeps the body it has while the new one is in flight — blanking it
|
|
68
|
+
* would flash the whole page through its loading state on every merge.
|
|
69
|
+
* Switching SKILLS is the opposite: that body belongs to another page.
|
|
70
|
+
*/
|
|
71
|
+
it('keeps the current body across a reload but clears it across a skill switch', async () => {
|
|
72
|
+
const { result, rerender } = renderHook(({ name }) => useSkillDetail(name), {
|
|
73
|
+
initialProps: { name: 'newsletter' },
|
|
74
|
+
});
|
|
75
|
+
await waitFor(() => expect(result.current.skill?.body).toBe('before'));
|
|
76
|
+
|
|
77
|
+
let releaseReload!: (v: typeof skill) => void;
|
|
78
|
+
api.getSkill.mockImplementationOnce(
|
|
79
|
+
() =>
|
|
80
|
+
new Promise<typeof skill>((res) => {
|
|
81
|
+
releaseReload = res;
|
|
82
|
+
}),
|
|
83
|
+
);
|
|
84
|
+
act(() => result.current.reload());
|
|
85
|
+
// Still readable while the fresh copy is on its way.
|
|
86
|
+
expect(result.current.skill?.body).toBe('before');
|
|
87
|
+
await act(async () => {
|
|
88
|
+
releaseReload({ ...skill, body: 'after' });
|
|
89
|
+
});
|
|
90
|
+
expect(result.current.skill?.body).toBe('after');
|
|
91
|
+
|
|
92
|
+
// A different skill blanks immediately — even though `revision` is now
|
|
93
|
+
// non-zero, which is why the hook tracks the shown NAME rather than the
|
|
94
|
+
// counter.
|
|
95
|
+
api.getSkill.mockImplementation(
|
|
96
|
+
() => new Promise<typeof skill>(() => {}),
|
|
97
|
+
);
|
|
98
|
+
rerender({ name: 'digest' });
|
|
99
|
+
expect(result.current.skill).toBeNull();
|
|
100
|
+
expect(result.current.loading).toBe(true);
|
|
101
|
+
});
|
|
102
|
+
});
|
|
@@ -0,0 +1,146 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { renderHook, waitFor, act } from '@testing-library/react';
|
|
3
|
+
import type { ToolSecrets } from '../../secrets-vault/services/tool-secrets.api';
|
|
4
|
+
import type { ToolManualDetail } from '../services/tools.api';
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* The hook's whole job is failure posture: which of three loads is allowed to
|
|
8
|
+
* break the page, and which quietly degrade. Plus ordering — a reload that
|
|
9
|
+
* overtakes an in-flight round must not be overwritten by it.
|
|
10
|
+
*/
|
|
11
|
+
|
|
12
|
+
const secretsMock = vi.hoisted(() => ({ listToolSecrets: vi.fn() }));
|
|
13
|
+
vi.mock('../../secrets-vault/services/tool-secrets.api', () => ({
|
|
14
|
+
listToolSecrets: secretsMock.listToolSecrets,
|
|
15
|
+
}));
|
|
16
|
+
|
|
17
|
+
const toolsMock = vi.hoisted(() => ({ getToolDetail: vi.fn() }));
|
|
18
|
+
vi.mock('../services/tools.api', () => ({ getToolDetail: toolsMock.getToolDetail }));
|
|
19
|
+
|
|
20
|
+
const libraryMock = vi.hoisted(() => ({ listSkills: vi.fn(), getSkill: vi.fn() }));
|
|
21
|
+
vi.mock('../services/library.api', () => ({
|
|
22
|
+
listSkills: libraryMock.listSkills,
|
|
23
|
+
getSkill: libraryMock.getSkill,
|
|
24
|
+
}));
|
|
25
|
+
|
|
26
|
+
import { useToolPage } from '../hooks/useToolPage';
|
|
27
|
+
|
|
28
|
+
const GITHUB: ToolSecrets = {
|
|
29
|
+
slug: 'github',
|
|
30
|
+
name: 'github',
|
|
31
|
+
path: 'Groups/Engineering/github.tool',
|
|
32
|
+
type: 'inline',
|
|
33
|
+
setup: null,
|
|
34
|
+
canWrite: false,
|
|
35
|
+
variables: [],
|
|
36
|
+
};
|
|
37
|
+
|
|
38
|
+
const DETAIL: ToolManualDetail = {
|
|
39
|
+
slug: 'github',
|
|
40
|
+
name: 'github',
|
|
41
|
+
path: 'Groups/Engineering/github.tool',
|
|
42
|
+
type: 'inline',
|
|
43
|
+
description: 'Read and write GitHub issues.',
|
|
44
|
+
capabilities: [{ name: 'create_issue', description: 'Open an issue.' }],
|
|
45
|
+
};
|
|
46
|
+
|
|
47
|
+
beforeEach(() => {
|
|
48
|
+
secretsMock.listToolSecrets.mockReset().mockResolvedValue([GITHUB]);
|
|
49
|
+
toolsMock.getToolDetail.mockReset().mockResolvedValue(DETAIL);
|
|
50
|
+
libraryMock.listSkills.mockReset().mockResolvedValue([]);
|
|
51
|
+
libraryMock.getSkill.mockReset().mockResolvedValue({ allowedTools: [] });
|
|
52
|
+
});
|
|
53
|
+
|
|
54
|
+
describe('useToolPage', () => {
|
|
55
|
+
it('resolves the tool with the matching slug and its detail', async () => {
|
|
56
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
57
|
+
expect(result.current.loading).toBe(true);
|
|
58
|
+
|
|
59
|
+
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
60
|
+
expect(result.current.tool).toEqual(GITHUB);
|
|
61
|
+
expect(result.current.notFound).toBe(false);
|
|
62
|
+
expect(result.current.error).toBeNull();
|
|
63
|
+
await waitFor(() => expect(result.current.detail).toEqual(DETAIL));
|
|
64
|
+
});
|
|
65
|
+
|
|
66
|
+
it('reports notFound: not an error. When no accessible tool carries the slug', async () => {
|
|
67
|
+
const { result } = renderHook(() => useToolPage('nope'));
|
|
68
|
+
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
69
|
+
expect(result.current.notFound).toBe(true);
|
|
70
|
+
expect(result.current.error).toBeNull();
|
|
71
|
+
expect(result.current.tool).toBeNull();
|
|
72
|
+
});
|
|
73
|
+
|
|
74
|
+
it('surfaces only a listToolSecrets failure as error', async () => {
|
|
75
|
+
secretsMock.listToolSecrets.mockRejectedValue(new Error("Couldn't load tool secrets."));
|
|
76
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
77
|
+
await waitFor(() => expect(result.current.error).toBe("Couldn't load tool secrets."));
|
|
78
|
+
expect(result.current.notFound).toBe(false);
|
|
79
|
+
});
|
|
80
|
+
|
|
81
|
+
it('degrades a failed detail load to null without touching error', async () => {
|
|
82
|
+
toolsMock.getToolDetail.mockRejectedValue(new Error('boom'));
|
|
83
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
84
|
+
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
85
|
+
expect(result.current.detail).toBeNull();
|
|
86
|
+
expect(result.current.error).toBeNull();
|
|
87
|
+
});
|
|
88
|
+
|
|
89
|
+
it('degrades a failed skill catalog to an empty index, still marked loaded', async () => {
|
|
90
|
+
libraryMock.listSkills.mockRejectedValue(new Error('nope'));
|
|
91
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
92
|
+
await waitFor(() => expect(result.current.skillsLoaded).toBe(true));
|
|
93
|
+
expect(result.current.poweredSkills).toEqual([]);
|
|
94
|
+
expect(result.current.error).toBeNull();
|
|
95
|
+
});
|
|
96
|
+
|
|
97
|
+
it('builds the reverse index from allowed-tools frontmatter', async () => {
|
|
98
|
+
libraryMock.listSkills.mockResolvedValue([
|
|
99
|
+
{ name: 'triage', description: '', path: 'Groups/Engineering/triage' },
|
|
100
|
+
{ name: 'newsletter', description: '', path: 'Skills/newsletter' },
|
|
101
|
+
]);
|
|
102
|
+
libraryMock.getSkill.mockImplementation(async (name: string) =>
|
|
103
|
+
name === 'triage' ? { allowedTools: ['github_create_issue'] } : { allowedTools: ['Bash'] },
|
|
104
|
+
);
|
|
105
|
+
|
|
106
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
107
|
+
await waitFor(() => expect(result.current.skillsLoaded).toBe(true));
|
|
108
|
+
await waitFor(() => expect(result.current.poweredSkills.map((s) => s.name)).toEqual(['triage']));
|
|
109
|
+
});
|
|
110
|
+
|
|
111
|
+
it('keeps one skill failing from emptying the whole index', async () => {
|
|
112
|
+
libraryMock.listSkills.mockResolvedValue([
|
|
113
|
+
{ name: 'triage', description: '', path: 'Groups/Engineering/triage' },
|
|
114
|
+
{ name: 'broken', description: '', path: 'Skills/broken' },
|
|
115
|
+
]);
|
|
116
|
+
libraryMock.getSkill.mockImplementation(async (name: string) => {
|
|
117
|
+
if (name === 'broken') throw new Error('unreadable');
|
|
118
|
+
return { allowedTools: ['github.create_issue'] };
|
|
119
|
+
});
|
|
120
|
+
|
|
121
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
122
|
+
await waitFor(() => expect(result.current.poweredSkills.map((s) => s.name)).toEqual(['triage']));
|
|
123
|
+
});
|
|
124
|
+
|
|
125
|
+
it('discards a stale response from a superseded request', async () => {
|
|
126
|
+
const stale: ToolSecrets = { ...GITHUB, name: 'stale-name' };
|
|
127
|
+
let releaseFirst: (tools: ToolSecrets[]) => void = () => {};
|
|
128
|
+
secretsMock.listToolSecrets
|
|
129
|
+
.mockImplementationOnce(
|
|
130
|
+
() =>
|
|
131
|
+
new Promise<ToolSecrets[]>((resolve) => {
|
|
132
|
+
releaseFirst = resolve;
|
|
133
|
+
}),
|
|
134
|
+
)
|
|
135
|
+
.mockResolvedValue([GITHUB]);
|
|
136
|
+
|
|
137
|
+
const { result } = renderHook(() => useToolPage('github'));
|
|
138
|
+
// Reload while the first round is still in flight, then let it land late.
|
|
139
|
+
act(() => result.current.reload());
|
|
140
|
+
await waitFor(() => expect(result.current.tool?.name).toBe('github'));
|
|
141
|
+
act(() => releaseFirst([stale]));
|
|
142
|
+
|
|
143
|
+
await waitFor(() => expect(result.current.tool?.name).toBe('github'));
|
|
144
|
+
expect(result.current.tool?.name).not.toBe('stale-name');
|
|
145
|
+
});
|
|
146
|
+
});
|
|
@@ -0,0 +1,101 @@
|
|
|
1
|
+
import { Banner, Button } from '../../../shared/components';
|
|
2
|
+
import { cn } from '../../../lib/utils';
|
|
3
|
+
import type { JoinProposal, JoinRequest } from '../services/groups.api';
|
|
4
|
+
|
|
5
|
+
/**
|
|
6
|
+
* Somebody asked to join this group — the manager-side face of a join change
|
|
7
|
+
* request.
|
|
8
|
+
*
|
|
9
|
+
* It shows what the request PROPOSES, one row per grant, because that is what
|
|
10
|
+
* accepting acts on: each Accept writes exactly that one grant onto the
|
|
11
|
+
* default branch through the ordinary access path. The request's branch is
|
|
12
|
+
* never merged, so a request naming five people can be answered with two
|
|
13
|
+
* yeses and three ignores, and nothing the branch happens to carry besides
|
|
14
|
+
* the grants can ride in on a click.
|
|
15
|
+
*
|
|
16
|
+
* Naming the verb is not pedantry: a request may propose `write` or `owner`
|
|
17
|
+
* rather than `read`, and "asked to join" would hide that. Whatever the
|
|
18
|
+
* branch asks for is what the row says.
|
|
19
|
+
*
|
|
20
|
+
* Decline rejects the whole request. Manage access is the third path — a
|
|
21
|
+
* manager who wants to do something other than what was proposed opens the
|
|
22
|
+
* dialog, and the request settles itself if that covers it.
|
|
23
|
+
*/
|
|
24
|
+
|
|
25
|
+
export interface AccessRequestsBannerProps {
|
|
26
|
+
group: string;
|
|
27
|
+
/** Repo-relative group folder for `Manage access` (single-element today). */
|
|
28
|
+
folders: string[];
|
|
29
|
+
requests: JoinRequest[];
|
|
30
|
+
onManage(folder: string): void;
|
|
31
|
+
onAccept(request: JoinRequest, proposal: JoinProposal): void;
|
|
32
|
+
onDecline(request: JoinRequest): void;
|
|
33
|
+
className?: string;
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
export function AccessRequestsBanner({
|
|
37
|
+
group,
|
|
38
|
+
folders,
|
|
39
|
+
requests,
|
|
40
|
+
onManage,
|
|
41
|
+
onAccept,
|
|
42
|
+
onDecline,
|
|
43
|
+
className,
|
|
44
|
+
}: AccessRequestsBannerProps) {
|
|
45
|
+
if (requests.length === 0) return null;
|
|
46
|
+
|
|
47
|
+
return (
|
|
48
|
+
<Banner role="status" tone="wait" className={cn('mb-4', className)}>
|
|
49
|
+
<p>
|
|
50
|
+
{requests.length === 1
|
|
51
|
+
? `${requests[0].requesterName} asked to join ${group}.`
|
|
52
|
+
: `${requests.length} people asked to join ${group}.`}
|
|
53
|
+
</p>
|
|
54
|
+
|
|
55
|
+
<div className="mt-2 flex flex-col gap-2">
|
|
56
|
+
{requests.map((request) => (
|
|
57
|
+
<div key={request.number} className="flex flex-col gap-1">
|
|
58
|
+
{requests.length > 1 && (
|
|
59
|
+
<span className="text-meta font-semibold text-ink">{request.requesterName}</span>
|
|
60
|
+
)}
|
|
61
|
+
{request.proposals.map((proposal) => (
|
|
62
|
+
<div
|
|
63
|
+
key={`${proposal.verb}:${proposal.id}`}
|
|
64
|
+
className="flex flex-wrap items-center gap-2"
|
|
65
|
+
>
|
|
66
|
+
<span className="min-w-0 flex-1 truncate">
|
|
67
|
+
{proposal.label}: <span className="font-semibold">{proposal.verb}</span>
|
|
68
|
+
</span>
|
|
69
|
+
<Button
|
|
70
|
+
variant="outline"
|
|
71
|
+
size="sm"
|
|
72
|
+
aria-label={`Grant ${proposal.verb} to ${proposal.label}`}
|
|
73
|
+
onClick={() => onAccept(request, proposal)}
|
|
74
|
+
>
|
|
75
|
+
Accept
|
|
76
|
+
</Button>
|
|
77
|
+
</div>
|
|
78
|
+
))}
|
|
79
|
+
<div>
|
|
80
|
+
<Button
|
|
81
|
+
variant="quiet"
|
|
82
|
+
size="sm"
|
|
83
|
+
aria-label={`Decline the request from ${request.requesterName}`}
|
|
84
|
+
onClick={() => onDecline(request)}
|
|
85
|
+
>
|
|
86
|
+
Decline
|
|
87
|
+
</Button>
|
|
88
|
+
</div>
|
|
89
|
+
</div>
|
|
90
|
+
))}
|
|
91
|
+
{folders.map((folder) => (
|
|
92
|
+
<div key={folder}>
|
|
93
|
+
<Button variant="quiet" size="sm" onClick={() => onManage(folder)}>
|
|
94
|
+
Manage access
|
|
95
|
+
</Button>
|
|
96
|
+
</div>
|
|
97
|
+
))}
|
|
98
|
+
</div>
|
|
99
|
+
</Banner>
|
|
100
|
+
);
|
|
101
|
+
}
|
|
@@ -0,0 +1,115 @@
|
|
|
1
|
+
import { Button, Dialog, Surface } from '../../../shared/components';
|
|
2
|
+
import { useAdmin } from '../../admin/state/admin.context';
|
|
3
|
+
import { NewSkillPanel } from './NewSkillPanel';
|
|
4
|
+
import { useLibraryToast } from '../state/toast.context';
|
|
5
|
+
import { COPIED_TOAST, COPY_FAILED_TOAST, copyToClipboard } from '../utils/clipboard';
|
|
6
|
+
|
|
7
|
+
export interface AddToGroupDialogProps {
|
|
8
|
+
/** Group name — the folder segment, already decoded. */
|
|
9
|
+
name: string;
|
|
10
|
+
/** Repo-relative primary folder, e.g. `Groups/GTM`. */
|
|
11
|
+
primaryPath: string;
|
|
12
|
+
/**
|
|
13
|
+
* Whether the caller can write the folder. It changes the prompt's landing
|
|
14
|
+
* clause and, for an admin, whether an empty skill lands directly or goes
|
|
15
|
+
* through review. `null` (verdict not in yet) is treated as "not a writer":
|
|
16
|
+
* the cautious sentence is true either way, the confident one is not.
|
|
17
|
+
*/
|
|
18
|
+
canWrite: boolean | null;
|
|
19
|
+
/** Every skill name already in the catalog. The admin create half rejects collisions. */
|
|
20
|
+
existingSkills: string[];
|
|
21
|
+
onClose(): void;
|
|
22
|
+
}
|
|
23
|
+
|
|
24
|
+
/**
|
|
25
|
+
* "Add a skill or tool to {group}" — the writer's half of the group page.
|
|
26
|
+
*
|
|
27
|
+
* The agent prompt is the path everyone gets. Admins also get the direct
|
|
28
|
+
* starter that creates an empty `SKILL.md`; non-admins do not. A placeholder
|
|
29
|
+
* is useful to an admin who can finish it directly, while a non-admin should
|
|
30
|
+
* send complete drafted content through the ordinary review flow.
|
|
31
|
+
*
|
|
32
|
+
* The prompt is the actual product here. It is copy-pasteable into the agent
|
|
33
|
+
* verbatim and it already knows the group, so nobody has to explain where the
|
|
34
|
+
* skill goes.
|
|
35
|
+
*
|
|
36
|
+
* The add button itself stays consistent for every role. What changes is the
|
|
37
|
+
* safe action inside it: non-admins can copy the prompt, and the prompt's last
|
|
38
|
+
* clause tells the truth about whether the resulting skill lands directly or
|
|
39
|
+
* arrives as a change request.
|
|
40
|
+
*/
|
|
41
|
+
export function AddToGroupDialog({
|
|
42
|
+
name,
|
|
43
|
+
primaryPath,
|
|
44
|
+
canWrite,
|
|
45
|
+
existingSkills,
|
|
46
|
+
onClose,
|
|
47
|
+
}: AddToGroupDialogProps) {
|
|
48
|
+
const { isAdmin } = useAdmin();
|
|
49
|
+
const toast = useLibraryToast();
|
|
50
|
+
|
|
51
|
+
// The only sentence in this dialog that varies by role.
|
|
52
|
+
const landing = canWrite
|
|
53
|
+
? 'I run it, so it goes in directly. No review step.'
|
|
54
|
+
: 'I am not an owner, so send it to the group as a change request for review.';
|
|
55
|
+
const prompt = `Help me build a new skill or tool and add it to the ${name} group at Bevel. ${landing}`;
|
|
56
|
+
|
|
57
|
+
async function copyPrompt() {
|
|
58
|
+
const copied = await copyToClipboard(prompt);
|
|
59
|
+
toast(copied ? COPIED_TOAST : COPY_FAILED_TOAST, copied ? 'neutral' : 'danger');
|
|
60
|
+
}
|
|
61
|
+
|
|
62
|
+
return (
|
|
63
|
+
<Dialog
|
|
64
|
+
open
|
|
65
|
+
onClose={onClose}
|
|
66
|
+
title={`Add a skill or tool to ${name}`}
|
|
67
|
+
footer={
|
|
68
|
+
<>
|
|
69
|
+
<Button variant="quiet" onClick={onClose}>
|
|
70
|
+
Close
|
|
71
|
+
</Button>
|
|
72
|
+
<Button variant="primary" onClick={() => void copyPrompt()}>
|
|
73
|
+
Copy prompt
|
|
74
|
+
</Button>
|
|
75
|
+
</>
|
|
76
|
+
}
|
|
77
|
+
>
|
|
78
|
+
<p className="text-ui text-ink-muted">
|
|
79
|
+
{isAdmin
|
|
80
|
+
? canWrite
|
|
81
|
+
? `Two ways in. Either way it joins ${name}. Everyone in the group gets it the next time their agent connects.`
|
|
82
|
+
: `Two ways in. Either way it goes to ${name} as a change request, and an owner reviews it before it joins.`
|
|
83
|
+
: canWrite
|
|
84
|
+
? `Use the prompt below to have your agent draft the skill and add it to ${name} for everyone in the group.`
|
|
85
|
+
: `Use the prompt below to have your agent draft the skill and send it to ${name} as a change request for an owner to review.`}
|
|
86
|
+
</p>
|
|
87
|
+
|
|
88
|
+
{isAdmin && (
|
|
89
|
+
<>
|
|
90
|
+
<NewSkillPanel
|
|
91
|
+
destination={{ parentPath: primaryPath, canWrite }}
|
|
92
|
+
existingSkills={existingSkills}
|
|
93
|
+
onCreated={onClose}
|
|
94
|
+
/>
|
|
95
|
+
|
|
96
|
+
<div className="my-3.5 flex items-center gap-3">
|
|
97
|
+
<span aria-hidden="true" className="h-px flex-1 bg-line" />
|
|
98
|
+
<span className="text-meta text-ink-faint">or</span>
|
|
99
|
+
<span aria-hidden="true" className="h-px flex-1 bg-line" />
|
|
100
|
+
</div>
|
|
101
|
+
</>
|
|
102
|
+
)}
|
|
103
|
+
|
|
104
|
+
{isAdmin && (
|
|
105
|
+
<p className="text-ui text-ink-muted">
|
|
106
|
+
{`Tell your agent what you need. It drafts the skill and adds it to ${name}.`}
|
|
107
|
+
</p>
|
|
108
|
+
)}
|
|
109
|
+
|
|
110
|
+
<Surface tone="sunken" radius="md" elevation="none" padded className="mt-2.5">
|
|
111
|
+
<p className="font-mono text-detail text-ink">{prompt}</p>
|
|
112
|
+
</Surface>
|
|
113
|
+
</Dialog>
|
|
114
|
+
);
|
|
115
|
+
}
|