@bevel-software/platform-core-frontend 0.4.1 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +5 -3
- package/src/core/CoreAppShell.tsx +195 -56
- package/src/core/__tests__/AppChrome.test.tsx +125 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
- package/src/core/__tests__/bootstrap.test.ts +63 -0
- package/src/core/bootstrap.ts +73 -0
- package/src/core/events.ts +12 -0
- package/src/core/registry.ts +58 -9
- package/src/index.css +100 -11
- package/src/index.ts +24 -23
- package/src/lib/utils.ts +93 -117
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
- package/src/modules/access/api.ts +49 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
- package/src/modules/access/hooks/useFileAccess.ts +1 -1
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
- package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
- package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
- package/src/modules/admin/state/admin.context.tsx +15 -6
- package/src/modules/auth/components/AccountPage.tsx +11 -11
- package/src/modules/auth/components/LoginScreen.tsx +12 -12
- package/src/modules/auth/services/sso.ts +47 -1
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
- package/src/modules/change-requests/__tests__/author.test.ts +48 -0
- package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
- package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
- package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
- package/src/modules/change-requests/change-requests.css +22 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
- package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
- package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
- package/src/modules/change-requests/services/change-requests.api.ts +45 -0
- package/src/modules/change-requests/services/propose.api.ts +162 -0
- package/src/modules/change-requests/utils/author.ts +47 -0
- package/src/modules/change-requests/utils/conflict.ts +38 -0
- package/src/modules/change-requests/utils/diff.ts +80 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
- package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
- package/src/modules/git/components/BranchSwitcher.tsx +68 -31
- package/src/modules/git/components/DiffView.tsx +4 -4
- package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
- package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
- package/src/modules/git/components/PullNeededBanner.tsx +6 -13
- package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
- package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
- package/src/modules/git/hooks/useGitState.ts +15 -14
- package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
- package/src/modules/git/services/error-messages.ts +7 -7
- package/src/modules/git/services/git.api.ts +17 -11
- package/src/modules/git/services/pr-prompts.ts +2 -2
- package/src/modules/git/state/git.context.ts +10 -1
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
- package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
- package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
- package/src/modules/layout/breakpoints.ts +6 -0
- package/src/modules/layout/components/AppLayout.tsx +17 -5
- package/src/modules/layout/components/DemoBanner.tsx +10 -1
- package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
- package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
- package/src/modules/layout/components/SidebarFrame.tsx +317 -0
- package/src/modules/layout/components/SidebarToggle.tsx +86 -0
- package/src/modules/layout/components/SlideOverlay.tsx +1 -1
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
- package/src/modules/layout/state/sidebar.ts +200 -0
- package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
- package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
- package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
- package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
- package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
- package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
- package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
- package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
- package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
- package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
- package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
- package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
- package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
- package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
- package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
- package/src/modules/library/__tests__/auth-harness.tsx +37 -0
- package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
- package/src/modules/library/__tests__/status.test.ts +113 -20
- package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
- package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
- package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
- package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
- package/src/modules/library/components/GroupIndexRow.tsx +63 -0
- package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
- package/src/modules/library/components/GroupPage.tsx +373 -0
- package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
- package/src/modules/library/components/GroupsSidebar.tsx +338 -0
- package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
- package/src/modules/library/components/LibraryCard.tsx +123 -102
- package/src/modules/library/components/LibraryLayout.tsx +344 -0
- package/src/modules/library/components/LibraryPage.tsx +111 -227
- package/src/modules/library/components/LockGlyph.tsx +31 -0
- package/src/modules/library/components/LockedGroupView.tsx +159 -0
- package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
- package/src/modules/library/components/NewGroupDialog.tsx +112 -0
- package/src/modules/library/components/NewSkillPanel.tsx +151 -0
- package/src/modules/library/components/PageActions.tsx +156 -0
- package/src/modules/library/components/PendingSkillReview.tsx +63 -0
- package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
- package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
- package/src/modules/library/components/StatusDot.tsx +25 -0
- package/src/modules/library/components/ToolLogo.tsx +171 -0
- package/src/modules/library/components/group-page-parts.tsx +419 -0
- package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
- package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
- package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
- package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
- package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
- package/src/modules/library/hooks/useJoinRequests.ts +114 -0
- package/src/modules/library/hooks/useLibraryData.ts +134 -119
- package/src/modules/library/hooks/useSkillDetail.ts +119 -74
- package/src/modules/library/hooks/useToolPage.ts +145 -0
- package/src/modules/library/library.css +33 -245
- package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
- package/src/modules/library/routes/library-paths.ts +191 -0
- package/src/modules/library/services/groups.api.ts +189 -0
- package/src/modules/library/services/library.api.ts +291 -164
- package/src/modules/library/services/tools.api.ts +60 -0
- package/src/modules/library/state/library-context.ts +22 -0
- package/src/modules/library/state/library-data.tsx +223 -0
- package/src/modules/library/state/toast.context.ts +32 -0
- package/src/modules/library/state/toast.tsx +84 -42
- package/src/modules/library/utils/clipboard.ts +33 -0
- package/src/modules/library/utils/group-summary.ts +68 -0
- package/src/modules/library/utils/names.ts +30 -0
- package/src/modules/library/utils/navigate-external.ts +15 -0
- package/src/modules/library/utils/oauth-fragment.ts +32 -0
- package/src/modules/library/utils/personal-group.ts +36 -0
- package/src/modules/library/utils/status.ts +108 -25
- package/src/modules/library/utils/toast-duration.ts +16 -0
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
- package/src/modules/onboarding/agent-clients.ts +48 -0
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
- package/src/modules/onboarding/components/RootLanding.tsx +54 -0
- package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
- package/src/modules/onboarding/paths.ts +9 -0
- package/src/modules/onboarding/state/onboarding.ts +191 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
- package/src/modules/pr/services/pr-approvals.api.ts +19 -0
- package/src/modules/pr/services/pr-cancel.api.ts +11 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
- package/src/modules/review/components/DiffViewer.tsx +4 -4
- package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
- package/src/modules/review/components/ReviewFileRow.tsx +10 -10
- package/src/modules/review/components/ReviewPanel.tsx +49 -17
- package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
- package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
- package/src/modules/secrets-vault/services/connect.api.ts +24 -3
- package/src/modules/settings/components/DeploymentPage.tsx +90 -0
- package/src/modules/settings/components/SettingsLayout.tsx +135 -0
- package/src/modules/settings/components/SettingsNav.tsx +114 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
- package/src/modules/settings/settings-nav-items.tsx +166 -0
- package/src/modules/setup/__tests__/setup.test.tsx +540 -0
- package/src/modules/setup/components/SetupGate.tsx +67 -0
- package/src/modules/setup/components/SetupScreen.tsx +573 -0
- package/src/modules/setup/services/setup.api.ts +106 -0
- package/src/modules/setup/utils/git-host.ts +34 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
- package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
- package/src/modules/toolbar/components/Toolbar.tsx +56 -54
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
- package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
- package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
- package/src/modules/workspace/components/EditorTabs.tsx +82 -50
- package/src/modules/workspace/components/FileExplorer.tsx +413 -189
- package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
- package/src/modules/workspace/components/FileRoute.tsx +89 -84
- package/src/modules/workspace/components/FileViewer.tsx +700 -294
- package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
- package/src/modules/workspace/components/KbFileRail.tsx +128 -0
- package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
- package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
- package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
- package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
- package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
- package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
- package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
- package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
- package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
- package/src/modules/workspace/components/renderers/index.ts +78 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
- package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
- package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
- package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
- package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
- package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
- package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
- package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
- package/src/modules/workspace/services/workspace.api.ts +9 -2
- package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
- package/src/modules/workspace/state/open-change-requests.tsx +185 -0
- package/src/modules/workspace/state/workspace.context.ts +9 -0
- package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
- package/src/modules/workspace/utils/diff.ts +130 -53
- package/src/modules/workspace/utils/fileTree.ts +7 -4
- package/src/modules/workspace/workspace.css +28 -0
- package/src/shared/components/Badge.tsx +62 -0
- package/src/shared/components/Banner.tsx +58 -0
- package/src/shared/components/Button.tsx +90 -0
- package/src/shared/components/Dialog.tsx +6 -6
- package/src/shared/components/Field.tsx +45 -0
- package/src/shared/components/IconButton.tsx +74 -0
- package/src/shared/components/ListRow.tsx +96 -0
- package/src/shared/components/Menu.tsx +88 -0
- package/src/shared/components/PageShell.tsx +8 -5
- package/src/shared/components/Surface.tsx +86 -0
- package/src/shared/components/__tests__/primitives.test.tsx +333 -0
- package/src/shared/components/index.ts +48 -0
- package/src/shared/components/useDismissableMenu.ts +71 -0
- package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
- package/src/shared/theme/index.css +12 -0
- package/src/shared/theme/measure.ts +64 -0
- package/src/shared/theme/shadows.css +34 -0
- package/src/shared/theme/tokens.css +193 -0
- package/src/test-setup.ts +9 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
- package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
- package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
- package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
- package/src/modules/library/__tests__/diff.test.ts +0 -62
- package/src/modules/library/__tests__/loadout.test.tsx +0 -72
- package/src/modules/library/components/CompareView.tsx +0 -357
- package/src/modules/library/components/DetailDialog.tsx +0 -566
- package/src/modules/library/components/GearIcon.tsx +0 -12
- package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
- package/src/modules/library/components/StatusGem.tsx +0 -21
- package/src/modules/library/components/SuggestChange.tsx +0 -171
- package/src/modules/library/components/particles.ts +0 -50
- package/src/modules/library/state/loadout.tsx +0 -129
- package/src/modules/library/utils/diff.ts +0 -102
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
- package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
- package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
- package/src/modules/pr/components/PrCancelButton.tsx +0 -99
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
- package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
- package/src/modules/pr/components/PrCommentThread.tsx +0 -168
- package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
- package/src/modules/pr/components/PrDiffPane.tsx +0 -425
- package/src/modules/pr/components/PrFileRow.tsx +0 -164
- package/src/modules/pr/components/PrFilesList.tsx +0 -53
- package/src/modules/pr/components/PrHeader.tsx +0 -45
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
- package/src/modules/pr/components/PrMergeButton.tsx +0 -268
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
- package/src/modules/pr/components/PrViewer.tsx +0 -364
- package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
- package/src/modules/pr/state/pr-viewer.context.ts +0 -34
- package/src/modules/pr/utils/bucketize-comments.ts +0 -55
- package/src/modules/pr/utils/parsePatch.ts +0 -57
- package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
|
@@ -1,15 +1,17 @@
|
|
|
1
|
-
import { useMemo, useCallback, useEffect, useRef, useState
|
|
2
|
-
import { Check, XCircle,
|
|
1
|
+
import { useMemo, useCallback, useContext, useEffect, useRef, useState } from 'react';
|
|
2
|
+
import { Check, XCircle, Lock, AlertTriangle, ArrowLeft } from 'lucide-react';
|
|
3
|
+
import type { FileTreeEntry, PullRequestSummary } from '@bevel-software/platform-shared';
|
|
3
4
|
import { useWorkspace } from '../state/workspace.context';
|
|
4
5
|
import { EditorTabs } from './EditorTabs';
|
|
6
|
+
import { KbPageHeader } from './KbPageHeader';
|
|
7
|
+
import { useOpenChangeRequests } from '../hooks/useOpenChangeRequests';
|
|
8
|
+
import { Banner, Button, Surface } from '../../../shared/components';
|
|
9
|
+
import { ManageAccessDialog } from '../../access/components/ManageAccessDialog';
|
|
5
10
|
import { useGit } from '../../git/state/git.context';
|
|
11
|
+
import { LayoutContext } from '../../layout/state/layout.context';
|
|
6
12
|
import { useCanonicalFileUrl } from '../routing/kb-routes';
|
|
7
|
-
import { useReview } from '../../review/state/review.context';
|
|
8
|
-
import { ProtectedBranchBanner } from '../../git/components/ProtectedBranchBanner';
|
|
9
13
|
import { PullNeededBanner } from '../../git/components/PullNeededBanner';
|
|
10
14
|
import { useFileAccess } from '../../access/hooks/useFileAccess';
|
|
11
|
-
import { AccessRestrictedBanner } from '../../access/components/AccessRestrictedBanner';
|
|
12
|
-
import { NodeOwnersBanner } from '../../access/components/NodeOwnersBanner';
|
|
13
15
|
import { FileHistoryPanel } from '../../git/components/FileHistoryPanel';
|
|
14
16
|
import { FileComparisonPanel } from '../../git/components/FileComparisonPanel';
|
|
15
17
|
import {
|
|
@@ -20,12 +22,25 @@ import {
|
|
|
20
22
|
useAppRegistry,
|
|
21
23
|
useSuggestedPromptSeed,
|
|
22
24
|
} from '../../../core/registry';
|
|
23
|
-
import { PrViewer } from '../../pr/components/PrViewer';
|
|
24
25
|
import { useFileLock } from '../../workflow/hooks/useFileLock';
|
|
25
26
|
import { LockApiError } from '../../workflow/services/lock.api';
|
|
26
27
|
import { useAuth } from '../../auth/state/auth.context';
|
|
27
|
-
import {
|
|
28
|
+
import {
|
|
29
|
+
knowledgeSuggestionBranchFor,
|
|
30
|
+
proposeKnowledgeChange,
|
|
31
|
+
} from '../../change-requests/services/propose.api';
|
|
32
|
+
import {
|
|
33
|
+
listMyChangeRequests,
|
|
34
|
+
readFileOnBranch,
|
|
35
|
+
} from '../../change-requests/services/change-requests.api';
|
|
36
|
+
import { FileChangeBoxes } from '../../change-requests/components/FileChangeBoxes';
|
|
37
|
+
import { ChangeRequestDialog } from '../../change-requests/components/ChangeRequestDialog';
|
|
38
|
+
import { formatEligible } from '../../access/hooks/useFileAccess';
|
|
39
|
+
import { PR_STALE_EVENT } from '../../../core/events';
|
|
40
|
+
import { getFileRenderer, getRendererLayout } from './renderers';
|
|
28
41
|
import type { RendererSaveState } from './renderers';
|
|
42
|
+
import { KbDocumentShell } from './KbDocumentShell';
|
|
43
|
+
import { FilePaneCard } from './FilePaneCard';
|
|
29
44
|
|
|
30
45
|
const SUGGESTED_PROMPTS = [
|
|
31
46
|
'Give me an overview of the process landscape.',
|
|
@@ -36,6 +51,7 @@ const SUGGESTED_PROMPTS = [
|
|
|
36
51
|
export function FileViewer() {
|
|
37
52
|
const {
|
|
38
53
|
workspaceId,
|
|
54
|
+
kbDirName,
|
|
39
55
|
openFilePath,
|
|
40
56
|
openFileContent,
|
|
41
57
|
openFileSavedContent,
|
|
@@ -47,17 +63,24 @@ export function FileViewer() {
|
|
|
47
63
|
acceptPendingContent,
|
|
48
64
|
rejectPendingContent,
|
|
49
65
|
addTab,
|
|
50
|
-
refreshFileTree,
|
|
51
|
-
bumpFsRevision,
|
|
52
66
|
reloadTabFromDisk,
|
|
53
67
|
} = useWorkspace();
|
|
54
|
-
const [linkCopied, setLinkCopied] = useState(false);
|
|
55
68
|
// Chat decoupling: the suggested-prompt seed is an optional registry port
|
|
56
69
|
// (null when no chat surface is registered → the prompt buttons hide).
|
|
57
70
|
const seedSuggestedPrompt = useSuggestedPromptSeed();
|
|
58
71
|
const { fileViewerPanels, renderers } = useAppRegistry();
|
|
59
72
|
const git = useGit();
|
|
60
|
-
|
|
73
|
+
// Hiding the tree buys margin, not line length (proto:709), and the pane
|
|
74
|
+
// controller is the only thing that knows whether it is hidden.
|
|
75
|
+
//
|
|
76
|
+
// Read straight off the context rather than through `useLayout`, which
|
|
77
|
+
// THROWS when there is no provider. A gutter is cosmetic; it must not be
|
|
78
|
+
// able to take the whole viewer down. There are two live cases with no
|
|
79
|
+
// controller — a registry app mounted outside the pane layout, and every
|
|
80
|
+
// unit test that renders FileViewer on its own — and in both the honest
|
|
81
|
+
// answer is "the tree is not hidden".
|
|
82
|
+
const layout = useContext(LayoutContext);
|
|
83
|
+
const explorerHidden = layout?.isExplorerCollapsed ?? false;
|
|
61
84
|
|
|
62
85
|
// File-lock integration (PLAN §2). One useFileLock per (branch, file)
|
|
63
86
|
// the user has open. Acquired on first dirty edit, released when the
|
|
@@ -101,13 +124,6 @@ export function FileViewer() {
|
|
|
101
124
|
// Keep the existing variable name so the rest of the file (legacy uses for
|
|
102
125
|
// dirty-flag bookkeeping etc.) doesn't need to change.
|
|
103
126
|
const onProtectedBranch = accessRestricted;
|
|
104
|
-
// `hasPendingReview` (the fact that a review session exists) suppresses the
|
|
105
|
-
// legacy single-file Accept/Reject banner below so the two review UIs don't
|
|
106
|
-
// compete. The review *surface* itself (badge + panel, with its own
|
|
107
|
-
// open-intent state) is no longer hard-mounted here — it's a registered
|
|
108
|
-
// panel (see `fileViewerPanels` / the enterprise ReviewPanelSurface), so
|
|
109
|
-
// the core viewer carries no review-UI dependency.
|
|
110
|
-
const hasPendingReview = !!review.session && review.session.changes.length > 0;
|
|
111
127
|
// Registered auxiliary surfaces (e.g. the enterprise agent-review badge +
|
|
112
128
|
// panel). Rendered on every return path exactly where the hard-mounted
|
|
113
129
|
// review surface used to sit, inside this component's relative container so
|
|
@@ -140,6 +156,39 @@ export function FileViewer() {
|
|
|
140
156
|
>(null);
|
|
141
157
|
const [pendingDeferred, setPendingDeferred] = useState(false);
|
|
142
158
|
const [hadPending, setHadPending] = useState(false);
|
|
159
|
+
|
|
160
|
+
// **Propose mode** — the write path for a reader WITHOUT write permission.
|
|
161
|
+
// Where Edit acquires the file lock and commits to this branch, Propose
|
|
162
|
+
// takes no lock and never touches this branch: the text goes to the
|
|
163
|
+
// caller's personal suggestions branch and surfaces as a change request
|
|
164
|
+
// for the file's owners to approve. No lock because the lock protects the
|
|
165
|
+
// file's canonical bytes, and a proposal does not change them.
|
|
166
|
+
const [proposeMode, setProposeMode] = useState(false);
|
|
167
|
+
const [proposalBusy, setProposalBusy] = useState(false);
|
|
168
|
+
// The one confirmation the author gets that the proposal is now someone
|
|
169
|
+
// else's to act on. Knowledge has no toast provider (see KbPageHeader),
|
|
170
|
+
// so this is a banner, dismissed on the next file/mode change.
|
|
171
|
+
const [proposalSent, setProposalSent] = useState(false);
|
|
172
|
+
// "Loading…" between the Propose click and the editor opening: entering
|
|
173
|
+
// checks for an existing open proposal and, if there is one, reads the
|
|
174
|
+
// file's PROPOSED version off the suggestions branch first.
|
|
175
|
+
const [isEnteringPropose, setIsEnteringPropose] = useState(false);
|
|
176
|
+
/**
|
|
177
|
+
* The editor's base when the caller already has an open proposal: the file
|
|
178
|
+
* as it reads on THEIR suggestions branch. Seeding from it is what makes a
|
|
179
|
+
* second proposal INCREMENTAL — it stacks on the pending change instead of
|
|
180
|
+
* silently starting over from this branch's text and overwriting it. Null
|
|
181
|
+
* = no open proposal (or the read failed): seed from the tab as before.
|
|
182
|
+
*/
|
|
183
|
+
const [proposeSeed, setProposeSeed] = useState<string | null>(null);
|
|
184
|
+
/**
|
|
185
|
+
* What Send actually sends. The tab's content ref lags the editor by one
|
|
186
|
+
* state propagation and — when a seed is in play — starts out pointing at
|
|
187
|
+
* THIS branch's text, not the proposed text on screen. This ref is set to
|
|
188
|
+
* the seed on entry and to every keystroke after, so the zero-edits case
|
|
189
|
+
* sends what the editor showed, never what it replaced.
|
|
190
|
+
*/
|
|
191
|
+
const proposeBufferRef = useRef<string | null>(null);
|
|
143
192
|
// Picker overrides set by the chat tool-card's "View full comparison" link.
|
|
144
193
|
// Cleared when the user opens a different file so a deep-link doesn't stick
|
|
145
194
|
// around and override their natural defaults on the next open.
|
|
@@ -161,6 +210,9 @@ export function FileViewer() {
|
|
|
161
210
|
// history tab of file B, which is surprising — opening a file should default
|
|
162
211
|
// to showing what's in it.
|
|
163
212
|
useEffect(() => {
|
|
213
|
+
// Intentional reset-on-key-change (same pattern as useWorkspaceState):
|
|
214
|
+
// opening a different file must start from the content tab.
|
|
215
|
+
// eslint-disable-next-line react-hooks/set-state-in-effect
|
|
164
216
|
setActiveTab('content');
|
|
165
217
|
setIsManualDirty(false);
|
|
166
218
|
setManualSaveState('idle');
|
|
@@ -221,6 +273,7 @@ export function FileViewer() {
|
|
|
221
273
|
const hasPendingNow = pendingFileContent !== null;
|
|
222
274
|
|
|
223
275
|
if (!hasPendingNow) {
|
|
276
|
+
// eslint-disable-next-line react-hooks/set-state-in-effect
|
|
224
277
|
setPendingDeferred(false);
|
|
225
278
|
setHadPending(false);
|
|
226
279
|
} else if (!hadPending) {
|
|
@@ -231,27 +284,14 @@ export function FileViewer() {
|
|
|
231
284
|
|
|
232
285
|
// Pending review / protected branches are read-only surfaces — ensure the file-
|
|
233
286
|
// level dirty indicator does not stay latched from a prior editable state.
|
|
287
|
+
// Propose mode is the exception: it IS the editable surface for a reader
|
|
288
|
+
// without write access, and its dirty flag is real.
|
|
234
289
|
useEffect(() => {
|
|
235
|
-
if (onProtectedBranch || isReviewingPending) {
|
|
290
|
+
if ((onProtectedBranch && !proposeMode) || isReviewingPending) {
|
|
291
|
+
// eslint-disable-next-line react-hooks/set-state-in-effect
|
|
236
292
|
setIsManualDirty(false);
|
|
237
293
|
}
|
|
238
|
-
}, [onProtectedBranch, isReviewingPending]);
|
|
239
|
-
|
|
240
|
-
const handleRevertCompleted = useCallback(async () => {
|
|
241
|
-
await refreshFileTree();
|
|
242
|
-
// A revert writes to the working tree, so the active tab's cached content
|
|
243
|
-
// is stale. Bump fs revision — the hook's invalidation effect refetches
|
|
244
|
-
// the active tab, and if the file no longer exists (e.g. revert of its
|
|
245
|
-
// creation), drops it from the tab list. The state→URL effect in
|
|
246
|
-
// FileRoute then updates the URL to the new active tab.
|
|
247
|
-
bumpFsRevision();
|
|
248
|
-
await git.refreshStatus();
|
|
249
|
-
// A revert writes to the working tree, so pending-review state may no
|
|
250
|
-
// longer match what's on disk. Refresh the session before switching tabs
|
|
251
|
-
// so the review panel reflects the reconciled paths.
|
|
252
|
-
await review.refresh();
|
|
253
|
-
setActiveTab('content');
|
|
254
|
-
}, [refreshFileTree, bumpFsRevision, git, review]);
|
|
294
|
+
}, [onProtectedBranch, isReviewingPending, proposeMode]);
|
|
255
295
|
|
|
256
296
|
const handleAccept = useCallback(async () => {
|
|
257
297
|
if (isSubmitting) return;
|
|
@@ -270,6 +310,14 @@ export function FileViewer() {
|
|
|
270
310
|
try {
|
|
271
311
|
await rejectPendingContent();
|
|
272
312
|
setPendingDeferred(false);
|
|
313
|
+
} catch (err) {
|
|
314
|
+
// Reject WRITES — the baseline back over the agent's bytes — and a
|
|
315
|
+
// failed write must not read as "rejected". Same banner the save path
|
|
316
|
+
// uses. (Accept performs no write, so it has no failure to surface.)
|
|
317
|
+
setSaveError({
|
|
318
|
+
kind: 'generic',
|
|
319
|
+
message: `Couldn't reject the update: ${err instanceof Error ? err.message : String(err)}`,
|
|
320
|
+
});
|
|
273
321
|
} finally {
|
|
274
322
|
setIsSubmitting(false);
|
|
275
323
|
}
|
|
@@ -277,7 +325,8 @@ export function FileViewer() {
|
|
|
277
325
|
|
|
278
326
|
// **Edit mode is explicit** (the lock spec, simplified). Viewing a file
|
|
279
327
|
// never claims the lock — the user clicks "Edit" to enter edit mode,
|
|
280
|
-
// which acquires. Idle for
|
|
328
|
+
// which acquires. Idle for `IDLE_RELEASE_MS` (two minutes)?
|
|
329
|
+
// `useFileLock` auto-releases and
|
|
281
330
|
// `holdingLock` flips false; the effect below mirrors that into
|
|
282
331
|
// `editMode` so the UI flips back to view. To resume editing, the
|
|
283
332
|
// user clicks Edit again (which tries to acquire — may fail if
|
|
@@ -328,8 +377,15 @@ export function FileViewer() {
|
|
|
328
377
|
// `isEnteringEdit` flag is cleared too so a switch-during-load
|
|
329
378
|
// doesn't leave the new tab's button stuck in "Loading…".
|
|
330
379
|
useEffect(() => {
|
|
380
|
+
// Intentional reset-on-key-change: a new file starts in View mode.
|
|
381
|
+
// eslint-disable-next-line react-hooks/set-state-in-effect
|
|
331
382
|
setEditMode(false);
|
|
332
383
|
setIsEnteringEdit(false);
|
|
384
|
+
setProposeMode(false);
|
|
385
|
+
setProposalSent(false);
|
|
386
|
+
setIsEnteringPropose(false);
|
|
387
|
+
setProposeSeed(null);
|
|
388
|
+
proposeBufferRef.current = null;
|
|
333
389
|
}, [openFilePath, currentBranch, workspaceId]);
|
|
334
390
|
|
|
335
391
|
// Monotonic token to scope each enter-edit flow's async completion to
|
|
@@ -473,12 +529,143 @@ export function FileViewer() {
|
|
|
473
529
|
});
|
|
474
530
|
}, [editMode, fileLock]);
|
|
475
531
|
|
|
532
|
+
/**
|
|
533
|
+
* Enter propose mode. If the caller already has an OPEN proposal, the
|
|
534
|
+
* editor seeds from the file as it reads on their suggestions branch —
|
|
535
|
+
* proposing again is a continuation, and starting from this branch's text
|
|
536
|
+
* would silently overwrite their own pending change. No lock either way:
|
|
537
|
+
* the lock protects the file's canonical bytes, and a proposal never
|
|
538
|
+
* touches them. Any staleness against this branch shows up in the change
|
|
539
|
+
* request's diff, where it is visible.
|
|
540
|
+
*/
|
|
541
|
+
const handleEnterPropose = useCallback(() => {
|
|
542
|
+
if (proposeMode || isEnteringPropose || !openFilePath) return;
|
|
543
|
+
setProposalSent(false);
|
|
544
|
+
setSaveError(null);
|
|
545
|
+
const targetPath = openFilePath;
|
|
546
|
+
setIsEnteringPropose(true);
|
|
547
|
+
(async () => {
|
|
548
|
+
let seed: string | null = null;
|
|
549
|
+
const user = auth.user;
|
|
550
|
+
const prefix = kbDirName ? `${kbDirName}/` : null;
|
|
551
|
+
if (user && prefix && targetPath.startsWith(prefix)) {
|
|
552
|
+
let existing = null;
|
|
553
|
+
try {
|
|
554
|
+
const branch = knowledgeSuggestionBranchFor(user);
|
|
555
|
+
const mine = await listMyChangeRequests();
|
|
556
|
+
existing = mine.find((c) => c.state === 'open' && c.branch === branch) ?? null;
|
|
557
|
+
if (existing) {
|
|
558
|
+
seed = await readFileOnBranch(branch, targetPath.slice(prefix.length));
|
|
559
|
+
}
|
|
560
|
+
} catch (err) {
|
|
561
|
+
// TWO failure causes, and only one may degrade. "Is there an open
|
|
562
|
+
// proposal?" failing means we KNOW nothing — seed from this branch,
|
|
563
|
+
// which is better than a propose button that does nothing. But a
|
|
564
|
+
// proposal we KNOW exists and could not read must refuse: opening
|
|
565
|
+
// the editor on this branch's text and sending would silently
|
|
566
|
+
// replace the caller's pending proposal — the exact overwrite the
|
|
567
|
+
// seed exists to prevent.
|
|
568
|
+
if (existing) {
|
|
569
|
+
console.warn('[FileViewer] could not read the open proposal:', err);
|
|
570
|
+
if (openFilePathRef.current === targetPath) {
|
|
571
|
+
setSaveError({
|
|
572
|
+
kind: 'generic',
|
|
573
|
+
message:
|
|
574
|
+
"Couldn't load your open proposal, so the editor stayed closed. Try again in a moment.",
|
|
575
|
+
});
|
|
576
|
+
}
|
|
577
|
+
return;
|
|
578
|
+
}
|
|
579
|
+
console.warn('[FileViewer] could not check for an open proposal:', err);
|
|
580
|
+
seed = null;
|
|
581
|
+
}
|
|
582
|
+
}
|
|
583
|
+
// Switched files while the seed loaded — this propose is moot.
|
|
584
|
+
if (openFilePathRef.current !== targetPath) return;
|
|
585
|
+
setProposeSeed(seed);
|
|
586
|
+
proposeBufferRef.current = seed ?? openFileContentRef.current;
|
|
587
|
+
setProposeMode(true);
|
|
588
|
+
})().finally(() => setIsEnteringPropose(false));
|
|
589
|
+
}, [proposeMode, isEnteringPropose, openFilePath, auth.user, kbDirName]);
|
|
590
|
+
|
|
591
|
+
/** Leave propose mode, throwing the typed text away and re-reading disk. */
|
|
592
|
+
const handleDiscardProposal = useCallback(() => {
|
|
593
|
+
setProposeMode(false);
|
|
594
|
+
setProposeSeed(null);
|
|
595
|
+
proposeBufferRef.current = null;
|
|
596
|
+
if (openFilePath) {
|
|
597
|
+
reloadTabFromDisk(openFilePath).catch((err) => {
|
|
598
|
+
console.warn('[FileViewer] reload after discarding a proposal failed:', err);
|
|
599
|
+
});
|
|
600
|
+
}
|
|
601
|
+
}, [openFilePath, reloadTabFromDisk]);
|
|
602
|
+
|
|
603
|
+
/**
|
|
604
|
+
* Send the proposal: the buffer goes to the caller's personal suggestions
|
|
605
|
+
* branch and an open change request against the default branch is created
|
|
606
|
+
* (or reused — one bundle per person). The file on THIS branch is untouched,
|
|
607
|
+
* so on success the tab re-reads disk: leaving the proposed text on screen
|
|
608
|
+
* would claim the file now says something it does not.
|
|
609
|
+
*/
|
|
610
|
+
const handleSendProposal = useCallback(async (contentOverride?: string) => {
|
|
611
|
+
const path = openFilePathRef.current;
|
|
612
|
+
// Ctrl+S hands the renderer's buffer straight in; the Send button has no
|
|
613
|
+
// buffer of its own and falls back to the propose buffer (seed +
|
|
614
|
+
// keystrokes), then to the tab's mirror.
|
|
615
|
+
const content = contentOverride ?? proposeBufferRef.current ?? openFileContentRef.current;
|
|
616
|
+
if (!path || !kbDirName || !auth.user || content === null || proposalBusy) return;
|
|
617
|
+
const prefix = `${kbDirName}/`;
|
|
618
|
+
if (!path.startsWith(prefix)) return;
|
|
619
|
+
// Nothing typed over an existing proposal: the branch already says
|
|
620
|
+
// exactly this. Close the editor rather than pushing an empty commit at
|
|
621
|
+
// the change request.
|
|
622
|
+
if (proposeSeed !== null && content === proposeSeed) {
|
|
623
|
+
setProposeMode(false);
|
|
624
|
+
setProposeSeed(null);
|
|
625
|
+
proposeBufferRef.current = null;
|
|
626
|
+
if (openFilePathRef.current === path) {
|
|
627
|
+
reloadTabFromDisk(path).catch(() => {});
|
|
628
|
+
}
|
|
629
|
+
return;
|
|
630
|
+
}
|
|
631
|
+
setProposalBusy(true);
|
|
632
|
+
setSaveError(null);
|
|
633
|
+
try {
|
|
634
|
+
await proposeKnowledgeChange({
|
|
635
|
+
repoRelativePath: path.slice(prefix.length),
|
|
636
|
+
content,
|
|
637
|
+
userEmail: auth.user.email,
|
|
638
|
+
userId: auth.user.id,
|
|
639
|
+
userName: auth.user.name,
|
|
640
|
+
});
|
|
641
|
+
setProposeMode(false);
|
|
642
|
+
setProposeSeed(null);
|
|
643
|
+
proposeBufferRef.current = null;
|
|
644
|
+
setProposalSent(true);
|
|
645
|
+
// The same signal a share dialog or an agent turn sends: the open
|
|
646
|
+
// change-request list just changed, so the tree dots and the page
|
|
647
|
+
// banner refetch.
|
|
648
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
649
|
+
if (openFilePathRef.current === path) {
|
|
650
|
+
await reloadTabFromDisk(path);
|
|
651
|
+
}
|
|
652
|
+
} catch (err) {
|
|
653
|
+
console.error('[FileViewer] sending a proposal failed:', err);
|
|
654
|
+
setSaveError({
|
|
655
|
+
kind: 'generic',
|
|
656
|
+
message: err instanceof Error ? err.message : "Couldn't send your proposed change.",
|
|
657
|
+
});
|
|
658
|
+
} finally {
|
|
659
|
+
setProposalBusy(false);
|
|
660
|
+
}
|
|
661
|
+
}, [kbDirName, auth.user, proposalBusy, proposeSeed, reloadTabFromDisk]);
|
|
662
|
+
|
|
476
663
|
// Save flow (PLAN §2):
|
|
477
664
|
// - Lock is already held because we're in edit mode (handleEnterEditMode
|
|
478
665
|
// guarantees it). Save = checkpoint commit, lock stays held so
|
|
479
666
|
// subsequent keystrokes don't have to re-acquire.
|
|
480
667
|
// - Final commit + release happens on exit-edit, unmount, file switch,
|
|
481
|
-
// or
|
|
668
|
+
// or `IDLE_RELEASE_MS` of inactivity (the hook's idle timer).
|
|
482
669
|
const handleSave = useCallback(async (content: string) => {
|
|
483
670
|
if (!openFilePath) return;
|
|
484
671
|
openFileContentRef.current = content;
|
|
@@ -521,6 +708,9 @@ export function FileViewer() {
|
|
|
521
708
|
const recordActivity = fileLock.recordActivity;
|
|
522
709
|
const handleValueChange = useCallback((value: string) => {
|
|
523
710
|
recordActivity();
|
|
711
|
+
// Keep the propose buffer current too — harmless in edit mode, and in
|
|
712
|
+
// propose mode it is what Send reads (see `proposeBufferRef`).
|
|
713
|
+
proposeBufferRef.current = value;
|
|
524
714
|
setActiveTabContent(value);
|
|
525
715
|
}, [recordActivity, setActiveTabContent]);
|
|
526
716
|
|
|
@@ -551,30 +741,72 @@ export function FileViewer() {
|
|
|
551
741
|
// Canonical link for the open file: the node's id URL when it's a node, else
|
|
552
742
|
// its path URL (resolved in the background, falls back to the path meanwhile).
|
|
553
743
|
const canonicalFileUrl = useCanonicalFileUrl(openFilePath);
|
|
744
|
+
// Each copy resolves to whether it actually landed. `navigator.clipboard`
|
|
745
|
+
// rejects outright on a non-secure origin, and the header says so on the
|
|
746
|
+
// control that was clicked rather than swallowing it.
|
|
554
747
|
const handleCopyLink = useCallback(async () => {
|
|
555
748
|
try {
|
|
556
749
|
const base = canonicalFileUrl ?? `${window.location.origin}${window.location.pathname}`;
|
|
557
750
|
await navigator.clipboard.writeText(base + window.location.hash);
|
|
558
|
-
|
|
559
|
-
window.setTimeout(() => setLinkCopied(false), 1500);
|
|
751
|
+
return true;
|
|
560
752
|
} catch (err) {
|
|
561
753
|
console.error('Failed to copy link:', err);
|
|
754
|
+
return false;
|
|
562
755
|
}
|
|
563
756
|
}, [canonicalFileUrl]);
|
|
564
757
|
|
|
758
|
+
// "Copy page as Markdown" is the document's own source. It is offered only
|
|
759
|
+
// when there IS markdown to copy — a PDF or an image has none, and copying
|
|
760
|
+
// a blob's bytes as text is nonsense rather than a feature.
|
|
761
|
+
const canCopyPage = !!openFilePath && /\.(md|markdown)$/i.test(openFilePath);
|
|
762
|
+
const handleCopyPage = useCallback(async () => {
|
|
763
|
+
if (openFileContent === null) return false;
|
|
764
|
+
try {
|
|
765
|
+
await navigator.clipboard.writeText(openFileContent);
|
|
766
|
+
return true;
|
|
767
|
+
} catch (err) {
|
|
768
|
+
console.error('Failed to copy page:', err);
|
|
769
|
+
return false;
|
|
770
|
+
}
|
|
771
|
+
}, [openFileContent]);
|
|
772
|
+
|
|
773
|
+
// Manage access on the open file, reached from the page's Share button.
|
|
774
|
+
//
|
|
775
|
+
// This page shares ONE thing: the file you are reading. It used to also
|
|
776
|
+
// offer "Share the whole folder", and that went — from a file's page it was
|
|
777
|
+
// a single click away from handing over everything in the folder, with
|
|
778
|
+
// nothing on screen showing what "everything" was. Sharing a folder now
|
|
779
|
+
// starts where the folder is: its row in the tree, right-click → Manage
|
|
780
|
+
// access, next to the children it governs.
|
|
781
|
+
const [shareTarget, setShareTarget] = useState<FileTreeEntry | null>(null);
|
|
782
|
+
const handleShare = useCallback(() => {
|
|
783
|
+
if (!openFilePath) return;
|
|
784
|
+
setShareTarget({
|
|
785
|
+
name: openFilePath.slice(openFilePath.lastIndexOf('/') + 1),
|
|
786
|
+
relativePath: openFilePath,
|
|
787
|
+
type: 'file',
|
|
788
|
+
});
|
|
789
|
+
}, [openFilePath]);
|
|
790
|
+
|
|
791
|
+
// ALL open requests, not just the ones scoped to you — a colleague's request
|
|
792
|
+
// on a file you can read but not write still belongs on this page.
|
|
793
|
+
const openChangeRequests = useOpenChangeRequests();
|
|
794
|
+
const requestsOnThisFile = openFilePath ? openChangeRequests.forPath(openFilePath) : [];
|
|
795
|
+
// The full-bleed banner's "Review the change" opens the SHARED
|
|
796
|
+
// change-request dialog — the old PR viewer surface is gone.
|
|
797
|
+
const [bannerCr, setBannerCr] = useState<PullRequestSummary | null>(null);
|
|
565
798
|
|
|
566
799
|
if (!openFilePath || openFileContent === null || !Renderer) {
|
|
567
800
|
return (
|
|
568
801
|
<div className="h-full w-full flex flex-col bg-white min-w-0 relative">
|
|
569
|
-
<ProtectedBranchBanner />
|
|
570
802
|
<PullNeededBanner />
|
|
571
803
|
<EditorTabs />
|
|
572
804
|
<div className="flex-1 flex items-center justify-center px-6">
|
|
573
805
|
<div className="max-w-md text-center">
|
|
574
|
-
<h2 className="
|
|
806
|
+
<h2 className="mb-2 text-head text-ink">
|
|
575
807
|
Open a file, or ask the process assistant a question.
|
|
576
808
|
</h2>
|
|
577
|
-
<p className="
|
|
809
|
+
<p className="mb-6 text-ui text-ink-muted">
|
|
578
810
|
Pick anything from the file tree, or start with a suggestion.
|
|
579
811
|
</p>
|
|
580
812
|
{/* Suggested prompts seed the chat composer — only rendered when a
|
|
@@ -582,204 +814,376 @@ export function FileViewer() {
|
|
|
582
814
|
{seedSuggestedPrompt && (
|
|
583
815
|
<div className="flex flex-col gap-2">
|
|
584
816
|
{SUGGESTED_PROMPTS.map((prompt) => (
|
|
585
|
-
<
|
|
817
|
+
<Surface
|
|
586
818
|
key={prompt}
|
|
819
|
+
as="button"
|
|
820
|
+
tone="sunken"
|
|
821
|
+
radius="lg"
|
|
822
|
+
elevation="none"
|
|
823
|
+
interactive
|
|
587
824
|
type="button"
|
|
588
825
|
onClick={() => seedSuggestedPrompt(prompt)}
|
|
589
|
-
className="
|
|
826
|
+
className="px-3 py-2 text-left text-ui text-ink"
|
|
590
827
|
>
|
|
591
828
|
{prompt}
|
|
592
|
-
</
|
|
829
|
+
</Surface>
|
|
593
830
|
))}
|
|
594
831
|
</div>
|
|
595
832
|
)}
|
|
596
833
|
</div>
|
|
597
834
|
</div>
|
|
598
835
|
{registeredPanels}
|
|
599
|
-
<PrViewer />
|
|
600
836
|
</div>
|
|
601
837
|
);
|
|
602
838
|
}
|
|
603
839
|
|
|
604
|
-
|
|
605
|
-
|
|
606
|
-
|
|
840
|
+
// Which shape the document column takes. A history / comparison panel is a
|
|
841
|
+
// fixed-height viewport with its own scroller (both roots are
|
|
842
|
+
// `flex-1 flex flex-col min-h-0`), so it gets the full-bleed contract for
|
|
843
|
+
// the same reason a PDF does — an auto-height column would collapse it.
|
|
844
|
+
const shellVariant =
|
|
845
|
+
activeTab === 'content' ? getRendererLayout(openFilePath) : 'full-bleed';
|
|
846
|
+
|
|
847
|
+
// What the pane card's bar names — extension kept, unlike the `<h1>` above,
|
|
848
|
+
// because the bar is the technical label (`SKILL.md`, `How to get
|
|
849
|
+
// started.md`) exactly as the skill page's file bar renders it.
|
|
850
|
+
const fileBaseName = openFilePath.slice(openFilePath.lastIndexOf('/') + 1);
|
|
851
|
+
|
|
852
|
+
// The repo-relative path (kbDirName stripped) — what the change-request
|
|
853
|
+
// machinery speaks. Null for files outside the KB clone, which cannot have
|
|
854
|
+
// change requests.
|
|
855
|
+
const repoRelativePath =
|
|
856
|
+
kbDirName && openFilePath.startsWith(`${kbDirName}/`)
|
|
857
|
+
? openFilePath.slice(kbDirName.length + 1)
|
|
858
|
+
: null;
|
|
859
|
+
const ownersLabel =
|
|
860
|
+
access.owners.roles.length > 0 || access.owners.users.length > 0
|
|
861
|
+
? formatEligible(access.owners)
|
|
862
|
+
: 'the owners';
|
|
863
|
+
|
|
864
|
+
const rendererElement = (
|
|
865
|
+
// The renderer is a dynamic per-extension lookup resolved in a useMemo
|
|
866
|
+
// above — not a component created during render.
|
|
867
|
+
// eslint-disable-next-line react-hooks/static-components
|
|
868
|
+
<Renderer
|
|
869
|
+
// **Why we key on `openFileSavedContent` (read-only mode only).**
|
|
870
|
+
// When a teammate's save lands, the workspace state updates the
|
|
871
|
+
// tab's content + savedContent. The renderer's internal
|
|
872
|
+
// `useState(content)` + sync-on-prop-change `useEffect` is
|
|
873
|
+
// supposed to pull the new value into `value`, but in practice
|
|
874
|
+
// (production build, multiple suspended subscribers, etc.) we
|
|
875
|
+
// were seeing the preview stay on the stale buffer until the
|
|
876
|
+
// user manually closed + reopened the tab. Keying the renderer
|
|
877
|
+
// on the bytes themselves forces a fresh mount when those
|
|
878
|
+
// bytes change, which initializes `value` from the latest
|
|
879
|
+
// content prop directly and bypasses any stuck-state edge
|
|
880
|
+
// case. We gate this on `!editMode` so the user's in-flight
|
|
881
|
+
// edits (where `value` diverges from `savedContent`) don't
|
|
882
|
+
// trigger a remount that would discard their typing —
|
|
883
|
+
// savedContent stays stable through an edit until the save
|
|
884
|
+
// commits, then advances once.
|
|
885
|
+
key={editMode || proposeMode ? `${openFilePath}|edit` : `${openFilePath}|${openFileSavedContent?.length ?? 0}|${openFileSavedContent?.slice(0, 64) ?? ''}|${openFileSavedContent?.slice(-64) ?? ''}`}
|
|
886
|
+
// In propose mode with an open proposal, the buffer AND the dirty
|
|
887
|
+
// baseline are the PROPOSED text (the seed) — the editor continues the
|
|
888
|
+
// pending change, and "dirty" means "differs from what I already
|
|
889
|
+
// proposed", not "differs from this branch".
|
|
890
|
+
content={
|
|
891
|
+
isReviewingPending
|
|
892
|
+
? pendingFileContent!
|
|
893
|
+
: proposeMode && proposeSeed !== null
|
|
894
|
+
? proposeSeed
|
|
895
|
+
: openFileContent
|
|
896
|
+
}
|
|
897
|
+
savedContent={
|
|
898
|
+
isReviewingPending
|
|
899
|
+
? pendingFileContent!
|
|
900
|
+
: proposeMode && proposeSeed !== null
|
|
901
|
+
? proposeSeed
|
|
902
|
+
: (openFileSavedContent ?? openFileContent)
|
|
903
|
+
}
|
|
904
|
+
filePath={openFilePath}
|
|
905
|
+
// In propose mode a save (Ctrl+S) IS sending the proposal — the
|
|
906
|
+
// one thing it must never be is a write to this branch.
|
|
907
|
+
onSave={
|
|
908
|
+
isReviewingPending
|
|
909
|
+
? handlePendingSave
|
|
910
|
+
: proposeMode
|
|
911
|
+
? handleSendProposal
|
|
912
|
+
: onProtectedBranch
|
|
913
|
+
? handlePendingSave
|
|
914
|
+
: handleSave
|
|
915
|
+
}
|
|
916
|
+
onDirtyChange={setIsManualDirty}
|
|
917
|
+
onValueChange={
|
|
918
|
+
isReviewingPending || !(editMode || proposeMode) ? undefined : handleValueChange
|
|
919
|
+
}
|
|
920
|
+
onSaveStateChange={setManualSaveState}
|
|
921
|
+
readOnly={isReviewingPending || !(editMode || proposeMode)}
|
|
922
|
+
/>
|
|
923
|
+
);
|
|
924
|
+
|
|
925
|
+
// The pane bar's write action — the labelled button at the frame's top
|
|
926
|
+
// left, same slot the skill page uses. What it says is the access answer:
|
|
927
|
+
// `Edit` when you may write the file, `Propose changes` when you may not
|
|
928
|
+
// (null = lookup in flight = optimistic Edit, exactly the header's old
|
|
929
|
+
// rule). While a mode is OPEN it shows the way out instead. The header's
|
|
930
|
+
// own cluster is suppressed for prose files (`writeActionInPane`).
|
|
931
|
+
const lockedBy = fileLock.externalLock?.holderName ?? null;
|
|
932
|
+
const paneActions = isReviewingPending ? null : proposeMode ? (
|
|
933
|
+
<>
|
|
934
|
+
<Button variant="quiet" size="tiny" onClick={handleDiscardProposal} disabled={proposalBusy}>
|
|
935
|
+
Discard
|
|
936
|
+
</Button>
|
|
937
|
+
<Button
|
|
938
|
+
variant="primary"
|
|
939
|
+
size="tiny"
|
|
940
|
+
onClick={() => void handleSendProposal()}
|
|
941
|
+
disabled={proposalBusy}
|
|
942
|
+
title="Send your proposed change for approval"
|
|
943
|
+
>
|
|
944
|
+
{proposalBusy ? 'Sending…' : 'Send proposal'}
|
|
945
|
+
</Button>
|
|
946
|
+
</>
|
|
947
|
+
) : editMode ? (
|
|
948
|
+
<Button
|
|
949
|
+
variant="outline"
|
|
950
|
+
size="tiny"
|
|
951
|
+
onClick={handleExitEditMode}
|
|
952
|
+
title="Save changes and return to view mode"
|
|
953
|
+
>
|
|
954
|
+
Done
|
|
955
|
+
</Button>
|
|
956
|
+
) : accessRestricted ? (
|
|
957
|
+
<Button
|
|
958
|
+
variant="outline"
|
|
959
|
+
size="tiny"
|
|
960
|
+
disabled={isEnteringPropose}
|
|
961
|
+
onClick={handleEnterPropose}
|
|
962
|
+
title={
|
|
963
|
+
isEnteringPropose
|
|
964
|
+
? 'Checking for an open proposal…'
|
|
965
|
+
: "You can't edit this file directly. Propose a change for its owners to approve"
|
|
966
|
+
}
|
|
967
|
+
>
|
|
968
|
+
{isEnteringPropose ? 'Loading…' : 'Propose changes'}
|
|
969
|
+
</Button>
|
|
970
|
+
) : (
|
|
971
|
+
<Button
|
|
972
|
+
variant="outline"
|
|
973
|
+
size="tiny"
|
|
974
|
+
disabled={!!lockedBy || isEnteringEdit}
|
|
975
|
+
onClick={handleEnterEditMode}
|
|
976
|
+
title={
|
|
977
|
+
lockedBy
|
|
978
|
+
? `Locked by ${lockedBy}`
|
|
979
|
+
: isEnteringEdit
|
|
980
|
+
? 'Acquiring lock and fetching latest content…'
|
|
981
|
+
: 'Click to edit this file'
|
|
982
|
+
}
|
|
983
|
+
>
|
|
984
|
+
{isEnteringEdit ? 'Loading…' : 'Edit'}
|
|
985
|
+
</Button>
|
|
986
|
+
);
|
|
607
987
|
|
|
608
988
|
return (
|
|
609
989
|
<div className="h-full w-full flex flex-col bg-white min-w-0 relative">
|
|
610
|
-
<ProtectedBranchBanner />
|
|
611
990
|
<PullNeededBanner />
|
|
612
|
-
{
|
|
613
|
-
|
|
614
|
-
|
|
615
|
-
|
|
991
|
+
{/* No "you don't have permission to edit" banner, deliberately: for a
|
|
992
|
+
reader the restriction is not news worth a stripe across every page —
|
|
993
|
+
the Propose changes affordance already says what they CAN do, and the
|
|
994
|
+
detailed who-may-edit copy still appears where it answers a question
|
|
995
|
+
(the disabled-save tooltip). */}
|
|
996
|
+
{/* ONE column holds the tabs, the title and the text at the same width,
|
|
997
|
+
so they share an edge and the page reads as a single centred block
|
|
998
|
+
(proto:700-705). `editorContainerRef` goes to `scrollRef` because the
|
|
999
|
+
shell is now the element that scrolls — the capture-phase listener
|
|
1000
|
+
bound to it is the file lock's only activity signal for a reader. */}
|
|
1001
|
+
<KbDocumentShell
|
|
1002
|
+
roomy={explorerHidden}
|
|
1003
|
+
variant={shellVariant}
|
|
1004
|
+
scrollRef={editorContainerRef}
|
|
1005
|
+
>
|
|
616
1006
|
<EditorTabs />
|
|
617
|
-
{/*
|
|
618
|
-
|
|
619
|
-
|
|
620
|
-
|
|
621
|
-
|
|
622
|
-
|
|
623
|
-
|
|
624
|
-
|
|
625
|
-
|
|
626
|
-
|
|
627
|
-
{
|
|
628
|
-
|
|
629
|
-
|
|
630
|
-
|
|
631
|
-
|
|
632
|
-
|
|
633
|
-
{
|
|
634
|
-
|
|
635
|
-
|
|
636
|
-
|
|
637
|
-
|
|
638
|
-
|
|
639
|
-
{
|
|
640
|
-
|
|
641
|
-
|
|
642
|
-
|
|
643
|
-
|
|
644
|
-
|
|
645
|
-
|
|
646
|
-
<TabButton
|
|
647
|
-
active={activeTab === 'content'}
|
|
648
|
-
onClick={() => setActiveTab('content')}
|
|
649
|
-
icon={<FileText size={12} />}
|
|
650
|
-
label="Content"
|
|
651
|
-
/>
|
|
652
|
-
{historyAvailable && (
|
|
653
|
-
<TabButton
|
|
654
|
-
active={activeTab === 'history'}
|
|
655
|
-
onClick={() => setActiveTab('history')}
|
|
656
|
-
icon={<History size={12} />}
|
|
657
|
-
label="History"
|
|
658
|
-
/>
|
|
659
|
-
)}
|
|
660
|
-
{historyAvailable && (
|
|
661
|
-
<TabButton
|
|
662
|
-
active={activeTab === 'compare'}
|
|
663
|
-
onClick={() => setActiveTab('compare')}
|
|
664
|
-
icon={<GitCompare size={12} />}
|
|
665
|
-
label="Compare"
|
|
666
|
-
/>
|
|
667
|
-
)}
|
|
668
|
-
<button
|
|
669
|
-
onClick={handleCopyLink}
|
|
670
|
-
className="ml-1 p-1 rounded hover:bg-slate-100 text-slate-600 hover:text-slate-900 transition-colors duration-150 relative"
|
|
671
|
-
title={linkCopied ? 'Link copied' : 'Copy link to this file'}
|
|
672
|
-
aria-label="Copy link to this file"
|
|
673
|
-
>
|
|
674
|
-
<Link2 size={14} />
|
|
675
|
-
{linkCopied && (
|
|
676
|
-
<span className="absolute top-full right-0 mt-1 px-1.5 py-0.5 rounded bg-slate-900 text-[10px] text-emerald-300 whitespace-nowrap pointer-events-none">
|
|
677
|
-
Link copied
|
|
678
|
-
</span>
|
|
679
|
-
)}
|
|
680
|
-
</button>
|
|
681
|
-
{/* Edit / Save toggle. Hidden on protected branches (read-only)
|
|
682
|
-
and while reviewing a pending agent update (the Accept/Reject
|
|
683
|
-
banner owns the workflow there). Disabled when someone else
|
|
684
|
-
holds the lock — the existing lock banner explains who. Both
|
|
685
|
-
states use the same emerald palette so the toolbar reads as
|
|
686
|
-
"one action button changing its label" rather than two
|
|
687
|
-
competing controls. */}
|
|
688
|
-
{!onProtectedBranch && !isReviewingPending && activeTab === 'content' && (
|
|
689
|
-
editMode ? (
|
|
690
|
-
<button
|
|
691
|
-
onClick={handleExitEditMode}
|
|
692
|
-
className="ml-1 flex items-center gap-1 px-2 py-1 rounded text-xs font-medium bg-emerald-700 text-white hover:bg-emerald-600 transition-colors"
|
|
693
|
-
title="Save changes and return to view mode"
|
|
694
|
-
>
|
|
695
|
-
<Check size={12} />
|
|
696
|
-
Save
|
|
697
|
-
</button>
|
|
698
|
-
) : (
|
|
699
|
-
<button
|
|
700
|
-
onClick={handleEnterEditMode}
|
|
701
|
-
disabled={!!fileLock.externalLock || isEnteringEdit}
|
|
702
|
-
className="ml-1 flex items-center gap-1 px-2 py-1 rounded text-xs font-medium bg-emerald-700 text-white hover:bg-emerald-600 transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
|
|
703
|
-
title={
|
|
704
|
-
fileLock.externalLock
|
|
705
|
-
? `Locked by ${fileLock.externalLock.holderName}`
|
|
706
|
-
: isEnteringEdit
|
|
707
|
-
? 'Acquiring lock and fetching latest content…'
|
|
708
|
-
: 'Click to edit this file'
|
|
709
|
-
}
|
|
710
|
-
>
|
|
711
|
-
<Pencil size={12} />
|
|
712
|
-
{isEnteringEdit ? 'Loading…' : 'Edit'}
|
|
713
|
-
</button>
|
|
714
|
-
)
|
|
715
|
-
)}
|
|
716
|
-
</div>
|
|
717
|
-
</div>
|
|
1007
|
+
{/* The document names itself, and its actions sit beside its name.
|
|
1008
|
+
Everything the deleted 40px strip carried is here — the three chips
|
|
1009
|
+
as Badges, Edit with the same handlers and the same lock semantics,
|
|
1010
|
+
the copy-link that used to be an icon in the corner — plus Share and
|
|
1011
|
+
the overflow the prototype puts on the page. */}
|
|
1012
|
+
<KbPageHeader
|
|
1013
|
+
path={openFilePath}
|
|
1014
|
+
canWrite={access.canWrite}
|
|
1015
|
+
editMode={editMode}
|
|
1016
|
+
entering={isEnteringEdit}
|
|
1017
|
+
proposeMode={proposeMode}
|
|
1018
|
+
proposalBusy={proposalBusy}
|
|
1019
|
+
onPropose={handleEnterPropose}
|
|
1020
|
+
onSendProposal={() => void handleSendProposal()}
|
|
1021
|
+
onDiscardProposal={handleDiscardProposal}
|
|
1022
|
+
writeActionInPane={shellVariant === 'prose'}
|
|
1023
|
+
lockedBy={fileLock.externalLock?.holderName ?? null}
|
|
1024
|
+
historyAvailable={historyAvailable}
|
|
1025
|
+
isDirty={isManualDirty}
|
|
1026
|
+
waitingOnAgentUpdate={waitingOnAgentUpdate}
|
|
1027
|
+
isReviewingPending={isReviewingPending}
|
|
1028
|
+
activeTab={activeTab}
|
|
1029
|
+
onEdit={handleEnterEditMode}
|
|
1030
|
+
onDone={handleExitEditMode}
|
|
1031
|
+
onOpenHistory={() => setActiveTab('history')}
|
|
1032
|
+
onShare={handleShare}
|
|
1033
|
+
onCopyPage={canCopyPage ? handleCopyPage : undefined}
|
|
1034
|
+
onCopyLink={handleCopyLink}
|
|
1035
|
+
/>
|
|
718
1036
|
|
|
1037
|
+
{/* Content stopped being a tab: the document IS the page, and history
|
|
1038
|
+
and comparison are two things you can go and look at. Each renders in
|
|
1039
|
+
place of the body with an explicit way back — without it the only
|
|
1040
|
+
route home would be reopening the file. */}
|
|
719
1041
|
{activeTab === 'history' && historyAvailable ? (
|
|
720
|
-
|
|
721
|
-
|
|
722
|
-
|
|
723
|
-
|
|
1042
|
+
<>
|
|
1043
|
+
<BackToDocument onBack={() => setActiveTab('content')} label="Version history" />
|
|
1044
|
+
<FileHistoryPanel filePath={openFilePath} />
|
|
1045
|
+
</>
|
|
724
1046
|
) : activeTab === 'compare' && historyAvailable ? (
|
|
725
|
-
|
|
726
|
-
|
|
727
|
-
|
|
728
|
-
|
|
729
|
-
|
|
730
|
-
|
|
1047
|
+
<>
|
|
1048
|
+
<BackToDocument onBack={() => setActiveTab('content')} label="Compare versions" />
|
|
1049
|
+
<FileComparisonPanel
|
|
1050
|
+
filePath={openFilePath}
|
|
1051
|
+
initialFrom={comparisonOverride?.fromBranch ?? null}
|
|
1052
|
+
initialTo={comparisonOverride?.toBranch ?? null}
|
|
1053
|
+
refreshKey={fsRevision}
|
|
1054
|
+
/>
|
|
1055
|
+
</>
|
|
731
1056
|
) : (
|
|
732
1057
|
<>
|
|
1058
|
+
{/* Somebody has proposed a change to this file. For a DOCUMENT the
|
|
1059
|
+
proposals render as change boxes UNDER the file (below) — the
|
|
1060
|
+
skill page's presentation, because the question they ask is
|
|
1061
|
+
unanswerable without the text. This banner remains only for
|
|
1062
|
+
full-bleed files, which have no below to put a box in. The
|
|
1063
|
+
signal comes from the broad endpoint, not from the dock's
|
|
1064
|
+
you-scoped queue, so a colleague's request on a file you can
|
|
1065
|
+
read but not write still shows. */}
|
|
1066
|
+
{requestsOnThisFile.length > 0 && shellVariant !== 'prose' && (
|
|
1067
|
+
<Banner role="note" tone="wait" className="mb-4 flex-none">
|
|
1068
|
+
<div className="font-semibold">
|
|
1069
|
+
{requestsOnThisFile.length === 1
|
|
1070
|
+
? 'Open change request'
|
|
1071
|
+
: `${requestsOnThisFile.length} open change requests`}
|
|
1072
|
+
</div>
|
|
1073
|
+
<div className="mt-0.5 text-detail text-ink-muted">
|
|
1074
|
+
{requestsOnThisFile[0].appAuthor?.name ?? requestsOnThisFile[0].author.login}{' '}
|
|
1075
|
+
proposed “{requestsOnThisFile[0].title}”. Nothing here changes until someone
|
|
1076
|
+
with write access applies it.
|
|
1077
|
+
</div>
|
|
1078
|
+
<div className="mt-3">
|
|
1079
|
+
<Button
|
|
1080
|
+
variant="primary"
|
|
1081
|
+
size="sm"
|
|
1082
|
+
onClick={() => setBannerCr(requestsOnThisFile[0])}
|
|
1083
|
+
>
|
|
1084
|
+
Review the change
|
|
1085
|
+
</Button>
|
|
1086
|
+
</div>
|
|
1087
|
+
</Banner>
|
|
1088
|
+
)}
|
|
1089
|
+
{/* Propose mode's one-line contract: where the text goes, and that
|
|
1090
|
+
nothing on this page changes until someone with write access
|
|
1091
|
+
says yes. Shown INSTEAD of the access-restricted banner. */}
|
|
1092
|
+
{proposeMode && (
|
|
1093
|
+
<Banner role="status" tone="wait" aria-live="polite" className="mb-4 flex-none">
|
|
1094
|
+
You're proposing a change. Nothing here changes until someone with write
|
|
1095
|
+
access approves it.
|
|
1096
|
+
</Banner>
|
|
1097
|
+
)}
|
|
1098
|
+
{proposalSent && (
|
|
1099
|
+
<Banner
|
|
1100
|
+
role="status"
|
|
1101
|
+
tone="ok"
|
|
1102
|
+
icon={<Check size={14} />}
|
|
1103
|
+
aria-live="polite"
|
|
1104
|
+
className="mb-4 flex-none"
|
|
1105
|
+
>
|
|
1106
|
+
<div className="flex items-center gap-2">
|
|
1107
|
+
<span className="flex-1">
|
|
1108
|
+
Your proposed change was sent as a change request.
|
|
1109
|
+
</span>
|
|
1110
|
+
<Button variant="quiet" size="sm" title="Dismiss" onClick={() => setProposalSent(false)}>
|
|
1111
|
+
Dismiss
|
|
1112
|
+
</Button>
|
|
1113
|
+
</div>
|
|
1114
|
+
</Banner>
|
|
1115
|
+
)}
|
|
733
1116
|
{waitingOnAgentUpdate && (
|
|
734
|
-
<
|
|
735
|
-
|
|
736
|
-
|
|
737
|
-
|
|
738
|
-
|
|
739
|
-
|
|
740
|
-
|
|
741
|
-
|
|
742
|
-
|
|
743
|
-
|
|
744
|
-
|
|
745
|
-
|
|
746
|
-
|
|
1117
|
+
<Banner
|
|
1118
|
+
role="status"
|
|
1119
|
+
tone="wait"
|
|
1120
|
+
aria-live="polite"
|
|
1121
|
+
aria-atomic="true"
|
|
1122
|
+
className="mb-4 flex-none items-center"
|
|
1123
|
+
>
|
|
1124
|
+
<div className="flex items-center gap-2">
|
|
1125
|
+
<span className="flex-1">
|
|
1126
|
+
Agent update is waiting. Save or undo your unsaved edits before reviewing it.
|
|
1127
|
+
</span>
|
|
1128
|
+
<Button
|
|
1129
|
+
variant="outline"
|
|
1130
|
+
size="sm"
|
|
1131
|
+
onClick={handleReviewAgentUpdate}
|
|
1132
|
+
disabled={isManualDirty}
|
|
1133
|
+
title={isManualDirty ? 'Finish local edits first' : 'Open the agent update preview'}
|
|
1134
|
+
>
|
|
1135
|
+
Review agent update
|
|
1136
|
+
</Button>
|
|
1137
|
+
</div>
|
|
1138
|
+
</Banner>
|
|
747
1139
|
)}
|
|
748
|
-
{/* Accept / Reject banner
|
|
749
|
-
|
|
750
|
-
|
|
751
|
-
|
|
752
|
-
|
|
753
|
-
|
|
754
|
-
|
|
755
|
-
|
|
756
|
-
|
|
757
|
-
|
|
758
|
-
|
|
759
|
-
|
|
760
|
-
|
|
761
|
-
|
|
762
|
-
|
|
763
|
-
|
|
764
|
-
|
|
765
|
-
|
|
766
|
-
|
|
767
|
-
|
|
768
|
-
|
|
769
|
-
|
|
770
|
-
|
|
771
|
-
|
|
772
|
-
|
|
1140
|
+
{/* Accept / Reject banner for a single previewed agent update. */}
|
|
1141
|
+
{isReviewingPending && (
|
|
1142
|
+
<Banner
|
|
1143
|
+
role="status"
|
|
1144
|
+
tone="neutral"
|
|
1145
|
+
aria-live="polite"
|
|
1146
|
+
aria-atomic="true"
|
|
1147
|
+
className="mb-4 flex-none"
|
|
1148
|
+
>
|
|
1149
|
+
<div className="flex items-center gap-2">
|
|
1150
|
+
<span className="flex-1">
|
|
1151
|
+
Previewing agent's changes: accept to keep, reject to undo
|
|
1152
|
+
</span>
|
|
1153
|
+
<Button
|
|
1154
|
+
variant="quiet"
|
|
1155
|
+
size="sm"
|
|
1156
|
+
leadingIcon={<XCircle size={13} />}
|
|
1157
|
+
onClick={handleReject}
|
|
1158
|
+
disabled={isSubmitting}
|
|
1159
|
+
>
|
|
1160
|
+
Reject
|
|
1161
|
+
</Button>
|
|
1162
|
+
<Button
|
|
1163
|
+
variant="primary"
|
|
1164
|
+
size="sm"
|
|
1165
|
+
leadingIcon={<Check size={13} />}
|
|
1166
|
+
onClick={handleAccept}
|
|
1167
|
+
disabled={isSubmitting}
|
|
1168
|
+
>
|
|
1169
|
+
Accept
|
|
1170
|
+
</Button>
|
|
1171
|
+
</div>
|
|
1172
|
+
</Banner>
|
|
773
1173
|
)}
|
|
774
1174
|
|
|
775
1175
|
{/* Lock-by-someone-else banner — read-only state until the holder releases. */}
|
|
776
1176
|
{fileLock.externalLock && !fileLock.holdingLock && !isReviewingPending && !onProtectedBranch && (
|
|
777
|
-
<
|
|
778
|
-
|
|
779
|
-
|
|
780
|
-
|
|
781
|
-
|
|
782
|
-
|
|
1177
|
+
<Banner
|
|
1178
|
+
role="status"
|
|
1179
|
+
tone="wait"
|
|
1180
|
+
icon={<Lock size={14} />}
|
|
1181
|
+
aria-live="polite"
|
|
1182
|
+
aria-atomic="true"
|
|
1183
|
+
className="mb-4 flex-none"
|
|
1184
|
+
>
|
|
1185
|
+
Locked by <span className="font-medium">{fileLock.externalLock.holderName}</span>. The editor is read-only until they finish.
|
|
1186
|
+
</Banner>
|
|
783
1187
|
)}
|
|
784
1188
|
|
|
785
1189
|
{/* Save-failure banner. Validator failures carry a structured
|
|
@@ -788,21 +1192,25 @@ export function FileViewer() {
|
|
|
788
1192
|
commits, even unrelated edits — without this UI the failure
|
|
789
1193
|
looks silent and the user keeps clicking Save). */}
|
|
790
1194
|
{saveError && (
|
|
791
|
-
<
|
|
1195
|
+
<Banner
|
|
1196
|
+
role="alert"
|
|
1197
|
+
tone="danger"
|
|
1198
|
+
icon={<AlertTriangle size={14} />}
|
|
1199
|
+
aria-live="assertive"
|
|
1200
|
+
className="mb-4 flex-none"
|
|
1201
|
+
>
|
|
792
1202
|
<div className="flex items-center gap-2">
|
|
793
|
-
<
|
|
794
|
-
<
|
|
795
|
-
<button
|
|
796
|
-
type="button"
|
|
797
|
-
onClick={() => setSaveError(null)}
|
|
798
|
-
className="text-red-700 hover:text-red-900 text-xs underline"
|
|
799
|
-
title="Dismiss"
|
|
800
|
-
>
|
|
1203
|
+
<span className="flex-1 font-medium">{saveError.message}</span>
|
|
1204
|
+
<Button variant="quiet" size="sm" title="Dismiss" onClick={() => setSaveError(null)}>
|
|
801
1205
|
Dismiss
|
|
802
|
-
</
|
|
1206
|
+
</Button>
|
|
803
1207
|
</div>
|
|
1208
|
+
{/* The validator gates EVERY commit, even an unrelated edit, so
|
|
1209
|
+
the structured issue list is the only way the user learns
|
|
1210
|
+
which KB problem is blocking their save. The 20-item cap and
|
|
1211
|
+
its "…and N more" tail stay. */}
|
|
804
1212
|
{saveError.kind === 'validation' && saveError.mustFix.length > 0 && (
|
|
805
|
-
<ul className="
|
|
1213
|
+
<ul className="mt-1.5 max-h-32 list-disc space-y-0.5 overflow-y-auto pl-4 text-detail">
|
|
806
1214
|
{saveError.mustFix.slice(0, 20).map((issue, i) => (
|
|
807
1215
|
<li key={i}>
|
|
808
1216
|
{issue.path && <span className="font-mono">{issue.path}</span>}
|
|
@@ -815,92 +1223,90 @@ export function FileViewer() {
|
|
|
815
1223
|
)}
|
|
816
1224
|
</ul>
|
|
817
1225
|
)}
|
|
818
|
-
</
|
|
819
|
-
)}
|
|
820
|
-
|
|
821
|
-
{/* Review-action failure banner. Rejecting an agent change is
|
|
822
|
-
optimistic — the row leaves the panel immediately — so a
|
|
823
|
-
background commit/push failure would otherwise be silent. This
|
|
824
|
-
surfaces it (and survives the review panel optimistically
|
|
825
|
-
unmounting on a failed "Reject all"). */}
|
|
826
|
-
{review.lastError && (
|
|
827
|
-
<div role="alert" aria-live="assertive" className="flex items-center gap-2 px-3 py-2 bg-red-50 border-b border-red-200 shrink-0">
|
|
828
|
-
<AlertTriangle size={14} className="text-red-700 shrink-0" />
|
|
829
|
-
<span className="text-xs text-red-800 flex-1 font-medium">{review.lastError}</span>
|
|
830
|
-
<button
|
|
831
|
-
type="button"
|
|
832
|
-
onClick={() => review.clearError()}
|
|
833
|
-
className="text-red-700 hover:text-red-900 text-xs underline"
|
|
834
|
-
title="Dismiss"
|
|
835
|
-
>
|
|
836
|
-
Dismiss
|
|
837
|
-
</button>
|
|
838
|
-
</div>
|
|
1226
|
+
</Banner>
|
|
839
1227
|
)}
|
|
840
1228
|
|
|
841
1229
|
{/* File content — show pending (new) content when reviewing, accepted content otherwise.
|
|
842
1230
|
Lock semantics: the editor is read-only whenever we're not in
|
|
843
1231
|
explicit Edit mode. Edit mode is gated by the lock, so this
|
|
844
1232
|
also covers "someone else holds it" without a separate check.
|
|
845
|
-
|
|
846
|
-
|
|
847
|
-
|
|
848
|
-
|
|
849
|
-
|
|
850
|
-
|
|
851
|
-
|
|
852
|
-
|
|
853
|
-
|
|
854
|
-
|
|
855
|
-
|
|
856
|
-
|
|
857
|
-
|
|
858
|
-
|
|
859
|
-
|
|
860
|
-
|
|
861
|
-
|
|
862
|
-
|
|
863
|
-
|
|
864
|
-
|
|
865
|
-
|
|
866
|
-
|
|
867
|
-
|
|
868
|
-
|
|
869
|
-
|
|
870
|
-
|
|
871
|
-
|
|
872
|
-
|
|
873
|
-
|
|
874
|
-
|
|
1233
|
+
The scroll-activity source for the idle-release timer is the
|
|
1234
|
+
shell above, not this wrapper — see `KbDocumentShell.scrollRef`.
|
|
1235
|
+
|
|
1236
|
+
A PROSE document sits inside `FilePaneCard` — the same edged
|
|
1237
|
+
frame, with the same mono filename bar, that the skill page puts
|
|
1238
|
+
around its files. One file-in-a-box drawing for the whole app;
|
|
1239
|
+
full-bleed renderers (pdf, csv, images…) are viewports, not
|
|
1240
|
+
documents, and keep their unframed definite-height contract. */}
|
|
1241
|
+
<div className={shellVariant === 'full-bleed' ? 'flex min-h-0 flex-1 flex-col' : 'min-w-0'}>
|
|
1242
|
+
{shellVariant === 'prose' ? (
|
|
1243
|
+
<>
|
|
1244
|
+
<FilePaneCard file={fileBaseName} actions={paneActions}>
|
|
1245
|
+
{rendererElement}
|
|
1246
|
+
</FilePaneCard>
|
|
1247
|
+
{/* Every open proposal on this file, under the file it is
|
|
1248
|
+
about — the same boxes, the same dialog, as the skill
|
|
1249
|
+
page. Hidden while the reader IS editing or proposing:
|
|
1250
|
+
the diffs are against text that is changing under them. */}
|
|
1251
|
+
{!editMode && !proposeMode && repoRelativePath && requestsOnThisFile.length > 0 && (
|
|
1252
|
+
<FileChangeBoxes
|
|
1253
|
+
repoRelativePath={repoRelativePath}
|
|
1254
|
+
requests={requestsOnThisFile}
|
|
1255
|
+
canDecide={access.canWrite === true}
|
|
1256
|
+
ownersLabel={ownersLabel}
|
|
1257
|
+
onApplied={() => {
|
|
1258
|
+
reloadTabFromDisk(openFilePath).catch(() => {});
|
|
1259
|
+
}}
|
|
1260
|
+
/>
|
|
1261
|
+
)}
|
|
1262
|
+
</>
|
|
1263
|
+
) : (
|
|
1264
|
+
rendererElement
|
|
1265
|
+
)}
|
|
875
1266
|
</div>
|
|
876
1267
|
</>
|
|
877
1268
|
)}
|
|
1269
|
+
</KbDocumentShell>
|
|
878
1270
|
{registeredPanels}
|
|
879
|
-
|
|
1271
|
+
{bannerCr && (
|
|
1272
|
+
<ChangeRequestDialog
|
|
1273
|
+
cr={bannerCr}
|
|
1274
|
+
onClose={() => setBannerCr(null)}
|
|
1275
|
+
// Applying is the only verdict the dialog reaches now.
|
|
1276
|
+
onResolved={() => {
|
|
1277
|
+
setBannerCr(null);
|
|
1278
|
+
window.dispatchEvent(new Event(PR_STALE_EVENT));
|
|
1279
|
+
reloadTabFromDisk(openFilePath).catch(() => {});
|
|
1280
|
+
}}
|
|
1281
|
+
/>
|
|
1282
|
+
)}
|
|
1283
|
+
{shareTarget && (
|
|
1284
|
+
<ManageAccessDialog
|
|
1285
|
+
key={shareTarget.relativePath}
|
|
1286
|
+
entry={shareTarget}
|
|
1287
|
+
// Keyed on the path, so retargeting at a parent remounts the sheet
|
|
1288
|
+
// against that folder — the whole thing is this one setter.
|
|
1289
|
+
onManageAncestor={setShareTarget}
|
|
1290
|
+
onClose={() => setShareTarget(null)}
|
|
1291
|
+
/>
|
|
1292
|
+
)}
|
|
880
1293
|
</div>
|
|
881
1294
|
);
|
|
882
1295
|
}
|
|
883
1296
|
|
|
884
|
-
|
|
885
|
-
|
|
886
|
-
|
|
887
|
-
|
|
888
|
-
|
|
889
|
-
|
|
890
|
-
|
|
891
|
-
function TabButton({ active, onClick, icon, label }: TabButtonProps) {
|
|
1297
|
+
/**
|
|
1298
|
+
* The way back from a panel that took the document's place.
|
|
1299
|
+
*
|
|
1300
|
+
* `Content` is no longer a tab, so there is no tab to click to return. Without
|
|
1301
|
+
* this row the only route home from Version history is reopening the file.
|
|
1302
|
+
*/
|
|
1303
|
+
function BackToDocument({ onBack, label }: { onBack(): void; label: string }) {
|
|
892
1304
|
return (
|
|
893
|
-
<
|
|
894
|
-
|
|
895
|
-
|
|
896
|
-
|
|
897
|
-
|
|
898
|
-
|
|
899
|
-
: 'text-slate-600 hover:text-slate-900 hover:bg-slate-100/80'
|
|
900
|
-
}`}
|
|
901
|
-
>
|
|
902
|
-
{icon}
|
|
903
|
-
{label}
|
|
904
|
-
</button>
|
|
1305
|
+
<div className="mb-3 flex shrink-0 items-center gap-2">
|
|
1306
|
+
<Button variant="quiet" size="sm" leadingIcon={<ArrowLeft size={13} />} onClick={onBack}>
|
|
1307
|
+
Back to the document
|
|
1308
|
+
</Button>
|
|
1309
|
+
<span className="text-detail text-ink-faint">{label}</span>
|
|
1310
|
+
</div>
|
|
905
1311
|
);
|
|
906
1312
|
}
|