@bevel-software/platform-core-frontend 0.4.1 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +5 -3
- package/src/core/CoreAppShell.tsx +195 -56
- package/src/core/__tests__/AppChrome.test.tsx +125 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
- package/src/core/__tests__/bootstrap.test.ts +63 -0
- package/src/core/bootstrap.ts +73 -0
- package/src/core/events.ts +12 -0
- package/src/core/registry.ts +58 -9
- package/src/index.css +100 -11
- package/src/index.ts +24 -23
- package/src/lib/utils.ts +93 -117
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
- package/src/modules/access/api.ts +49 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
- package/src/modules/access/hooks/useFileAccess.ts +1 -1
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
- package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
- package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
- package/src/modules/admin/state/admin.context.tsx +15 -6
- package/src/modules/auth/components/AccountPage.tsx +11 -11
- package/src/modules/auth/components/LoginScreen.tsx +12 -12
- package/src/modules/auth/services/sso.ts +47 -1
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
- package/src/modules/change-requests/__tests__/author.test.ts +48 -0
- package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
- package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
- package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
- package/src/modules/change-requests/change-requests.css +22 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
- package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
- package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
- package/src/modules/change-requests/services/change-requests.api.ts +45 -0
- package/src/modules/change-requests/services/propose.api.ts +162 -0
- package/src/modules/change-requests/utils/author.ts +47 -0
- package/src/modules/change-requests/utils/conflict.ts +38 -0
- package/src/modules/change-requests/utils/diff.ts +80 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
- package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
- package/src/modules/git/components/BranchSwitcher.tsx +68 -31
- package/src/modules/git/components/DiffView.tsx +4 -4
- package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
- package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
- package/src/modules/git/components/PullNeededBanner.tsx +6 -13
- package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
- package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
- package/src/modules/git/hooks/useGitState.ts +15 -14
- package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
- package/src/modules/git/services/error-messages.ts +7 -7
- package/src/modules/git/services/git.api.ts +17 -11
- package/src/modules/git/services/pr-prompts.ts +2 -2
- package/src/modules/git/state/git.context.ts +10 -1
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
- package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
- package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
- package/src/modules/layout/breakpoints.ts +6 -0
- package/src/modules/layout/components/AppLayout.tsx +17 -5
- package/src/modules/layout/components/DemoBanner.tsx +10 -1
- package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
- package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
- package/src/modules/layout/components/SidebarFrame.tsx +317 -0
- package/src/modules/layout/components/SidebarToggle.tsx +86 -0
- package/src/modules/layout/components/SlideOverlay.tsx +1 -1
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
- package/src/modules/layout/state/sidebar.ts +200 -0
- package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
- package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
- package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
- package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
- package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
- package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
- package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
- package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
- package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
- package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
- package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
- package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
- package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
- package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
- package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
- package/src/modules/library/__tests__/auth-harness.tsx +37 -0
- package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
- package/src/modules/library/__tests__/status.test.ts +113 -20
- package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
- package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
- package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
- package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
- package/src/modules/library/components/GroupIndexRow.tsx +63 -0
- package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
- package/src/modules/library/components/GroupPage.tsx +373 -0
- package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
- package/src/modules/library/components/GroupsSidebar.tsx +338 -0
- package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
- package/src/modules/library/components/LibraryCard.tsx +123 -102
- package/src/modules/library/components/LibraryLayout.tsx +344 -0
- package/src/modules/library/components/LibraryPage.tsx +111 -227
- package/src/modules/library/components/LockGlyph.tsx +31 -0
- package/src/modules/library/components/LockedGroupView.tsx +159 -0
- package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
- package/src/modules/library/components/NewGroupDialog.tsx +112 -0
- package/src/modules/library/components/NewSkillPanel.tsx +151 -0
- package/src/modules/library/components/PageActions.tsx +156 -0
- package/src/modules/library/components/PendingSkillReview.tsx +63 -0
- package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
- package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
- package/src/modules/library/components/StatusDot.tsx +25 -0
- package/src/modules/library/components/ToolLogo.tsx +171 -0
- package/src/modules/library/components/group-page-parts.tsx +419 -0
- package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
- package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
- package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
- package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
- package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
- package/src/modules/library/hooks/useJoinRequests.ts +114 -0
- package/src/modules/library/hooks/useLibraryData.ts +134 -119
- package/src/modules/library/hooks/useSkillDetail.ts +119 -74
- package/src/modules/library/hooks/useToolPage.ts +145 -0
- package/src/modules/library/library.css +33 -245
- package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
- package/src/modules/library/routes/library-paths.ts +191 -0
- package/src/modules/library/services/groups.api.ts +189 -0
- package/src/modules/library/services/library.api.ts +291 -164
- package/src/modules/library/services/tools.api.ts +60 -0
- package/src/modules/library/state/library-context.ts +22 -0
- package/src/modules/library/state/library-data.tsx +223 -0
- package/src/modules/library/state/toast.context.ts +32 -0
- package/src/modules/library/state/toast.tsx +84 -42
- package/src/modules/library/utils/clipboard.ts +33 -0
- package/src/modules/library/utils/group-summary.ts +68 -0
- package/src/modules/library/utils/names.ts +30 -0
- package/src/modules/library/utils/navigate-external.ts +15 -0
- package/src/modules/library/utils/oauth-fragment.ts +32 -0
- package/src/modules/library/utils/personal-group.ts +36 -0
- package/src/modules/library/utils/status.ts +108 -25
- package/src/modules/library/utils/toast-duration.ts +16 -0
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
- package/src/modules/onboarding/agent-clients.ts +48 -0
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
- package/src/modules/onboarding/components/RootLanding.tsx +54 -0
- package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
- package/src/modules/onboarding/paths.ts +9 -0
- package/src/modules/onboarding/state/onboarding.ts +191 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
- package/src/modules/pr/services/pr-approvals.api.ts +19 -0
- package/src/modules/pr/services/pr-cancel.api.ts +11 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
- package/src/modules/review/components/DiffViewer.tsx +4 -4
- package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
- package/src/modules/review/components/ReviewFileRow.tsx +10 -10
- package/src/modules/review/components/ReviewPanel.tsx +49 -17
- package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
- package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
- package/src/modules/secrets-vault/services/connect.api.ts +24 -3
- package/src/modules/settings/components/DeploymentPage.tsx +90 -0
- package/src/modules/settings/components/SettingsLayout.tsx +135 -0
- package/src/modules/settings/components/SettingsNav.tsx +114 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
- package/src/modules/settings/settings-nav-items.tsx +166 -0
- package/src/modules/setup/__tests__/setup.test.tsx +540 -0
- package/src/modules/setup/components/SetupGate.tsx +67 -0
- package/src/modules/setup/components/SetupScreen.tsx +573 -0
- package/src/modules/setup/services/setup.api.ts +106 -0
- package/src/modules/setup/utils/git-host.ts +34 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
- package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
- package/src/modules/toolbar/components/Toolbar.tsx +56 -54
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
- package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
- package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
- package/src/modules/workspace/components/EditorTabs.tsx +82 -50
- package/src/modules/workspace/components/FileExplorer.tsx +413 -189
- package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
- package/src/modules/workspace/components/FileRoute.tsx +89 -84
- package/src/modules/workspace/components/FileViewer.tsx +700 -294
- package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
- package/src/modules/workspace/components/KbFileRail.tsx +128 -0
- package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
- package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
- package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
- package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
- package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
- package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
- package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
- package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
- package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
- package/src/modules/workspace/components/renderers/index.ts +78 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
- package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
- package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
- package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
- package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
- package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
- package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
- package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
- package/src/modules/workspace/services/workspace.api.ts +9 -2
- package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
- package/src/modules/workspace/state/open-change-requests.tsx +185 -0
- package/src/modules/workspace/state/workspace.context.ts +9 -0
- package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
- package/src/modules/workspace/utils/diff.ts +130 -53
- package/src/modules/workspace/utils/fileTree.ts +7 -4
- package/src/modules/workspace/workspace.css +28 -0
- package/src/shared/components/Badge.tsx +62 -0
- package/src/shared/components/Banner.tsx +58 -0
- package/src/shared/components/Button.tsx +90 -0
- package/src/shared/components/Dialog.tsx +6 -6
- package/src/shared/components/Field.tsx +45 -0
- package/src/shared/components/IconButton.tsx +74 -0
- package/src/shared/components/ListRow.tsx +96 -0
- package/src/shared/components/Menu.tsx +88 -0
- package/src/shared/components/PageShell.tsx +8 -5
- package/src/shared/components/Surface.tsx +86 -0
- package/src/shared/components/__tests__/primitives.test.tsx +333 -0
- package/src/shared/components/index.ts +48 -0
- package/src/shared/components/useDismissableMenu.ts +71 -0
- package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
- package/src/shared/theme/index.css +12 -0
- package/src/shared/theme/measure.ts +64 -0
- package/src/shared/theme/shadows.css +34 -0
- package/src/shared/theme/tokens.css +193 -0
- package/src/test-setup.ts +9 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
- package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
- package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
- package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
- package/src/modules/library/__tests__/diff.test.ts +0 -62
- package/src/modules/library/__tests__/loadout.test.tsx +0 -72
- package/src/modules/library/components/CompareView.tsx +0 -357
- package/src/modules/library/components/DetailDialog.tsx +0 -566
- package/src/modules/library/components/GearIcon.tsx +0 -12
- package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
- package/src/modules/library/components/StatusGem.tsx +0 -21
- package/src/modules/library/components/SuggestChange.tsx +0 -171
- package/src/modules/library/components/particles.ts +0 -50
- package/src/modules/library/state/loadout.tsx +0 -129
- package/src/modules/library/utils/diff.ts +0 -102
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
- package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
- package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
- package/src/modules/pr/components/PrCancelButton.tsx +0 -99
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
- package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
- package/src/modules/pr/components/PrCommentThread.tsx +0 -168
- package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
- package/src/modules/pr/components/PrDiffPane.tsx +0 -425
- package/src/modules/pr/components/PrFileRow.tsx +0 -164
- package/src/modules/pr/components/PrFilesList.tsx +0 -53
- package/src/modules/pr/components/PrHeader.tsx +0 -45
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
- package/src/modules/pr/components/PrMergeButton.tsx +0 -268
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
- package/src/modules/pr/components/PrViewer.tsx +0 -364
- package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
- package/src/modules/pr/state/pr-viewer.context.ts +0 -34
- package/src/modules/pr/utils/bucketize-comments.ts +0 -55
- package/src/modules/pr/utils/parsePatch.ts +0 -57
- package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
|
@@ -0,0 +1,142 @@
|
|
|
1
|
+
import { describe, it, expect, vi, type Mock } from 'vitest';
|
|
2
|
+
import { render, screen, fireEvent, cleanup } from '@testing-library/react';
|
|
3
|
+
import { GroupsSidebar, type GroupsSidebarProps } from '../components/GroupsSidebar';
|
|
4
|
+
import type { LibraryFilter } from '../utils/status';
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* The sidebar as a pure view: given a filter and counts, which row is current,
|
|
8
|
+
* what its count slot says, and which intent a click emits. It owns no state
|
|
9
|
+
* and no navigation, so nothing here needs a router.
|
|
10
|
+
*/
|
|
11
|
+
|
|
12
|
+
function renderSidebar(over: Partial<GroupsSidebarProps> = {}) {
|
|
13
|
+
const onSelect = vi.fn();
|
|
14
|
+
const onFinishSetup = vi.fn();
|
|
15
|
+
const props: GroupsSidebarProps = {
|
|
16
|
+
filter: { kind: 'all' },
|
|
17
|
+
onSelect,
|
|
18
|
+
groups: [
|
|
19
|
+
{ group: 'Engineering', count: 4, attention: 0 },
|
|
20
|
+
{ group: 'GTM', count: 3, attention: 2 },
|
|
21
|
+
{ group: 'Product', count: 0, attention: 0 },
|
|
22
|
+
],
|
|
23
|
+
lockedGroups: [],
|
|
24
|
+
ownedCount: 2,
|
|
25
|
+
ownedAttention: 0,
|
|
26
|
+
personalGroupLabel: "Juan's Group",
|
|
27
|
+
ungroupedCount: 1,
|
|
28
|
+
attentionCount: 2,
|
|
29
|
+
onFinishSetup,
|
|
30
|
+
onCreateGroup: vi.fn(),
|
|
31
|
+
groupsIndexActive: false,
|
|
32
|
+
onOpenGroupsIndex: vi.fn(),
|
|
33
|
+
|
|
34
|
+
...over,
|
|
35
|
+
};
|
|
36
|
+
render(<GroupsSidebar {...props} />);
|
|
37
|
+
return {
|
|
38
|
+
onSelect,
|
|
39
|
+
onFinishSetup,
|
|
40
|
+
onCreateGroup: props.onCreateGroup as Mock,
|
|
41
|
+
onOpenGroupsIndex: props.onOpenGroupsIndex as Mock,
|
|
42
|
+
};
|
|
43
|
+
}
|
|
44
|
+
|
|
45
|
+
const row = (name: RegExp | string) => screen.getByRole('button', { name });
|
|
46
|
+
|
|
47
|
+
describe('GroupsSidebar', () => {
|
|
48
|
+
it('leads with All groups. The Library opens there, so the nav starts there', () => {
|
|
49
|
+
const { onOpenGroupsIndex } = renderSidebar();
|
|
50
|
+
const rows = screen.getAllByRole('button');
|
|
51
|
+
expect(rows[0]).toHaveAccessibleName('All groups');
|
|
52
|
+
fireEvent.click(rows[0]);
|
|
53
|
+
expect(onOpenGroupsIndex).toHaveBeenCalledTimes(1);
|
|
54
|
+
});
|
|
55
|
+
|
|
56
|
+
it('marks All groups current on the index, and nothing else', () => {
|
|
57
|
+
renderSidebar({ filter: null, groupsIndexActive: true });
|
|
58
|
+
expect(row(/^All groups/)).toHaveAttribute('aria-current', 'true');
|
|
59
|
+
expect(row(/^Everything/)).toHaveAttribute('aria-current', 'false');
|
|
60
|
+
expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
|
|
61
|
+
});
|
|
62
|
+
|
|
63
|
+
it('keeps Everything as a lens of its own, since the root is the index now', () => {
|
|
64
|
+
renderSidebar({ filter: { kind: 'all' } });
|
|
65
|
+
expect(row(/^Everything/)).toHaveAttribute('aria-current', 'true');
|
|
66
|
+
expect(row(/^All groups/)).toHaveAttribute('aria-current', 'false');
|
|
67
|
+
});
|
|
68
|
+
|
|
69
|
+
it('heads the group rows with what the list is: the set in your MCP', () => {
|
|
70
|
+
renderSidebar();
|
|
71
|
+
expect(screen.getByText('Included in your MCP')).toBeInTheDocument();
|
|
72
|
+
});
|
|
73
|
+
|
|
74
|
+
it("leads the groups with the caller's own space", () => {
|
|
75
|
+
renderSidebar({ filter: { kind: 'ungrouped' } });
|
|
76
|
+
expect(row(/^Juan's Group/)).toHaveAttribute('aria-current', 'true');
|
|
77
|
+
expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
|
|
78
|
+
});
|
|
79
|
+
|
|
80
|
+
it('offers a way to make a group', () => {
|
|
81
|
+
const { onCreateGroup } = renderSidebar();
|
|
82
|
+
fireEvent.click(screen.getByRole('button', { name: 'New group' }));
|
|
83
|
+
expect(onCreateGroup).toHaveBeenCalledTimes(1);
|
|
84
|
+
});
|
|
85
|
+
|
|
86
|
+
it('marks the selected group current and leaves the others alone', () => {
|
|
87
|
+
renderSidebar({ filter: { kind: 'group', group: 'GTM' } });
|
|
88
|
+
expect(row(/^GTM/)).toHaveAttribute('aria-current', 'true');
|
|
89
|
+
expect(row(/^Engineering/)).toHaveAttribute('aria-current', 'false');
|
|
90
|
+
});
|
|
91
|
+
|
|
92
|
+
it('shows the attention count instead of the item count when something needs setup', () => {
|
|
93
|
+
renderSidebar();
|
|
94
|
+
// GTM: 3 items but 2 integrations need setup — amber wins the slot.
|
|
95
|
+
expect(row(/^GTM/)).toHaveAccessibleName('GTM 2');
|
|
96
|
+
expect(row(/^Engineering/)).toHaveAccessibleName('Engineering 4');
|
|
97
|
+
// Never a grey 0: an empty group shows no count at all.
|
|
98
|
+
expect(row(/^Product/)).toHaveAccessibleName('Product');
|
|
99
|
+
});
|
|
100
|
+
|
|
101
|
+
it('emits the right LibraryFilter per row', () => {
|
|
102
|
+
const { onSelect } = renderSidebar();
|
|
103
|
+
const expected: [RegExp, LibraryFilter][] = [
|
|
104
|
+
[/^Everything/, { kind: 'all' }],
|
|
105
|
+
[/^Owned by me/, { kind: 'owned' }],
|
|
106
|
+
[/^GTM/, { kind: 'group', group: 'GTM' }],
|
|
107
|
+
[/^Juan's Group/, { kind: 'ungrouped' }],
|
|
108
|
+
];
|
|
109
|
+
for (const [name, filter] of expected) {
|
|
110
|
+
onSelect.mockClear();
|
|
111
|
+
fireEvent.click(row(name));
|
|
112
|
+
expect(onSelect).toHaveBeenCalledWith(filter);
|
|
113
|
+
}
|
|
114
|
+
});
|
|
115
|
+
|
|
116
|
+
it("keeps the caller's own group listed even when it is empty", () => {
|
|
117
|
+
// It is a PLACE, not a filtered view: a group you are always in does not
|
|
118
|
+
// vanish because you have not put anything in it yet.
|
|
119
|
+
renderSidebar({ ungroupedCount: 0 });
|
|
120
|
+
expect(row(/^Juan's Group/)).toBeInTheDocument();
|
|
121
|
+
});
|
|
122
|
+
|
|
123
|
+
it('shows the owned count in grey, and amber only when something waits on you', () => {
|
|
124
|
+
renderSidebar({ ownedCount: 26, ownedAttention: 0 });
|
|
125
|
+
expect(row(/^Owned by me/)).toHaveAccessibleName('Owned by me 26');
|
|
126
|
+
|
|
127
|
+
cleanup();
|
|
128
|
+
renderSidebar({ ownedCount: 26, ownedAttention: 1 });
|
|
129
|
+
expect(row(/^Owned by me/)).toHaveAccessibleName('Owned by me 1');
|
|
130
|
+
});
|
|
131
|
+
|
|
132
|
+
it('sends the setup footer to Connect', () => {
|
|
133
|
+
const { onFinishSetup } = renderSidebar();
|
|
134
|
+
fireEvent.click(row(/integrations need setup/));
|
|
135
|
+
expect(onFinishSetup).toHaveBeenCalledTimes(1);
|
|
136
|
+
});
|
|
137
|
+
|
|
138
|
+
it('hides the setup footer when nothing needs setup', () => {
|
|
139
|
+
renderSidebar({ attentionCount: 0 });
|
|
140
|
+
expect(screen.queryByRole('button', { name: /needs? setup/ })).not.toBeInTheDocument();
|
|
141
|
+
});
|
|
142
|
+
});
|
|
@@ -0,0 +1,142 @@
|
|
|
1
|
+
import { describe, it, expect, vi } from 'vitest';
|
|
2
|
+
import { createRef } from 'react';
|
|
3
|
+
import { render, screen, fireEvent, within } from '@testing-library/react';
|
|
4
|
+
import { GroupsSidebarMenu, type GroupsSidebarMenuProps } from '../components/GroupsSidebarMenu';
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* The Library nav's right-click menu.
|
|
8
|
+
*
|
|
9
|
+
* Two things are under test and they are not the same thing. The ITEMS are the
|
|
10
|
+
* Library's own — a group is not a file, so this menu says `New group` where
|
|
11
|
+
* the tree says `New folder` — but the BEHAVIOUR has to be the file tree's,
|
|
12
|
+
* because a right-click that dismisses one way in Knowledge and another way in
|
|
13
|
+
* Skills is two products in one window. Outside click closes, Escape closes,
|
|
14
|
+
* Escape returns focus to the row (`useDismissableMenu`).
|
|
15
|
+
*/
|
|
16
|
+
|
|
17
|
+
function renderMenu(over: Partial<GroupsSidebarMenuProps> = {}) {
|
|
18
|
+
const onClose = vi.fn();
|
|
19
|
+
const props: GroupsSidebarMenuProps = {
|
|
20
|
+
x: 140,
|
|
21
|
+
y: 260,
|
|
22
|
+
label: 'GTM',
|
|
23
|
+
onClose,
|
|
24
|
+
onAdd: vi.fn(),
|
|
25
|
+
onCreateGroup: vi.fn(),
|
|
26
|
+
onCopyLink: vi.fn(),
|
|
27
|
+
onManageAccess: vi.fn(),
|
|
28
|
+
...over,
|
|
29
|
+
};
|
|
30
|
+
render(<GroupsSidebarMenu {...props} />);
|
|
31
|
+
return { ...props, onClose };
|
|
32
|
+
}
|
|
33
|
+
|
|
34
|
+
const menu = () => screen.getByRole('menu');
|
|
35
|
+
const items = () =>
|
|
36
|
+
within(menu())
|
|
37
|
+
.getAllByRole('menuitem')
|
|
38
|
+
.map((i) => i.textContent);
|
|
39
|
+
|
|
40
|
+
describe('GroupsSidebarMenu', () => {
|
|
41
|
+
it('names itself after the row it was opened from', () => {
|
|
42
|
+
renderMenu();
|
|
43
|
+
expect(screen.getByRole('menu', { name: 'Actions for GTM' })).toBeInTheDocument();
|
|
44
|
+
});
|
|
45
|
+
|
|
46
|
+
it('opens at the pointer', () => {
|
|
47
|
+
renderMenu();
|
|
48
|
+
// The panel is presentation only, so the fixed wrapper is the caller's.
|
|
49
|
+
const wrapper = menu().parentElement!;
|
|
50
|
+
expect(wrapper).toHaveStyle({ left: '140px', top: '260px' });
|
|
51
|
+
});
|
|
52
|
+
|
|
53
|
+
/**
|
|
54
|
+
* Create verbs first, copy next, access below the rule — the file tree's
|
|
55
|
+
* order (`FileExplorer.tsx:232-287`), so the two menus have the same shape
|
|
56
|
+
* even where they do not have the same words.
|
|
57
|
+
*/
|
|
58
|
+
it('orders a full group menu the way the file tree orders its own', () => {
|
|
59
|
+
renderMenu();
|
|
60
|
+
expect(items()).toEqual(['Add a skill or tool', 'New group', 'Copy link', 'Manage access']);
|
|
61
|
+
});
|
|
62
|
+
|
|
63
|
+
it('renders only the verbs it was given. An absent one is not a disabled one', () => {
|
|
64
|
+
// What a lens row gets: no folder behind it, so nothing to add to and no
|
|
65
|
+
// access to manage.
|
|
66
|
+
renderMenu({ onAdd: undefined, onManageAccess: undefined });
|
|
67
|
+
expect(items()).toEqual(['New group', 'Copy link']);
|
|
68
|
+
});
|
|
69
|
+
|
|
70
|
+
it("puts Delete group last, below its own rule, and only when it was given — the owner's verb", () => {
|
|
71
|
+
renderMenu({ onDelete: vi.fn() });
|
|
72
|
+
expect(items()).toEqual([
|
|
73
|
+
'Add a skill or tool',
|
|
74
|
+
'New group',
|
|
75
|
+
'Copy link',
|
|
76
|
+
'Manage access',
|
|
77
|
+
'Delete group',
|
|
78
|
+
]);
|
|
79
|
+
// The default render (no onDelete) is the non-owner's menu — the earlier
|
|
80
|
+
// full-menu assertion already proves the item is absent there.
|
|
81
|
+
});
|
|
82
|
+
|
|
83
|
+
it('runs Delete group and then closes', () => {
|
|
84
|
+
const onDelete = vi.fn();
|
|
85
|
+
const props = renderMenu({ onDelete });
|
|
86
|
+
fireEvent.click(screen.getByRole('menuitem', { name: 'Delete group' }));
|
|
87
|
+
expect(onDelete).toHaveBeenCalledTimes(1);
|
|
88
|
+
expect(props.onClose).toHaveBeenCalledTimes(1);
|
|
89
|
+
});
|
|
90
|
+
|
|
91
|
+
it('keeps New group on the empty-space menu, where it is the only verb', () => {
|
|
92
|
+
renderMenu({
|
|
93
|
+
label: 'Library',
|
|
94
|
+
onAdd: undefined,
|
|
95
|
+
onCopyLink: undefined,
|
|
96
|
+
onManageAccess: undefined,
|
|
97
|
+
});
|
|
98
|
+
expect(items()).toEqual(['New group']);
|
|
99
|
+
});
|
|
100
|
+
|
|
101
|
+
it.each([
|
|
102
|
+
['Add a skill or tool', 'onAdd'],
|
|
103
|
+
['New group', 'onCreateGroup'],
|
|
104
|
+
['Copy link', 'onCopyLink'],
|
|
105
|
+
['Manage access', 'onManageAccess'],
|
|
106
|
+
] as const)('runs %s and then closes', (name, key) => {
|
|
107
|
+
const props = renderMenu();
|
|
108
|
+
fireEvent.click(screen.getByRole('menuitem', { name }));
|
|
109
|
+
expect(props[key]).toHaveBeenCalledTimes(1);
|
|
110
|
+
// A menu that stayed open behind the sheet it just opened would be a second
|
|
111
|
+
// thing to dismiss.
|
|
112
|
+
expect(props.onClose).toHaveBeenCalledTimes(1);
|
|
113
|
+
});
|
|
114
|
+
|
|
115
|
+
it('closes on an outside click', () => {
|
|
116
|
+
const { onClose } = renderMenu();
|
|
117
|
+
fireEvent.mouseDown(document.body);
|
|
118
|
+
expect(onClose).toHaveBeenCalledTimes(1);
|
|
119
|
+
});
|
|
120
|
+
|
|
121
|
+
it('stays open when the click is inside it', () => {
|
|
122
|
+
const { onClose } = renderMenu();
|
|
123
|
+
fireEvent.mouseDown(menu());
|
|
124
|
+
expect(onClose).not.toHaveBeenCalled();
|
|
125
|
+
});
|
|
126
|
+
|
|
127
|
+
it('closes on Escape and hands focus back to the row', () => {
|
|
128
|
+
const row = document.createElement('button');
|
|
129
|
+
document.body.appendChild(row);
|
|
130
|
+
const ref = createRef<HTMLElement>() as React.RefObject<HTMLElement | null>;
|
|
131
|
+
ref.current = row;
|
|
132
|
+
|
|
133
|
+
const { onClose } = renderMenu({ returnFocusTo: ref });
|
|
134
|
+
fireEvent.keyDown(document, { key: 'Escape' });
|
|
135
|
+
|
|
136
|
+
expect(onClose).toHaveBeenCalledTimes(1);
|
|
137
|
+
// Otherwise focus is left on a node that just unmounted and the next Tab
|
|
138
|
+
// starts from the top of the document.
|
|
139
|
+
expect(document.activeElement).toBe(row);
|
|
140
|
+
row.remove();
|
|
141
|
+
});
|
|
142
|
+
});
|
|
@@ -0,0 +1,149 @@
|
|
|
1
|
+
import { describe, it, expect, vi } from 'vitest';
|
|
2
|
+
import { render, screen, cleanup } from '@testing-library/react';
|
|
3
|
+
import { LibraryCard, type LibraryCardProps } from '../components/LibraryCard';
|
|
4
|
+
import { displayFirstName, personalGroupName } from '../utils/personal-group';
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* What a card says when it has nothing to report, and what it says when it has.
|
|
8
|
+
*
|
|
9
|
+
* The rule under test: the footer is EARNED. A tool always states its
|
|
10
|
+
* connection because that is the only question anyone asks of a tool; a skill
|
|
11
|
+
* says nothing unless something is in its way. Neither ever labels its own kind
|
|
12
|
+
* — "SKILL" under a skill is a word spent restating the obvious.
|
|
13
|
+
*/
|
|
14
|
+
|
|
15
|
+
function card(over: Partial<LibraryCardProps> = {}) {
|
|
16
|
+
const props: LibraryCardProps = {
|
|
17
|
+
kind: 'skill',
|
|
18
|
+
id: 'rfi',
|
|
19
|
+
name: 'rfi',
|
|
20
|
+
description: 'Answers an RFI.',
|
|
21
|
+
owned: false,
|
|
22
|
+
status: { state: 'ok', text: 'Ready' },
|
|
23
|
+
onOpen: vi.fn(),
|
|
24
|
+
...over,
|
|
25
|
+
};
|
|
26
|
+
render(<LibraryCard {...props} />);
|
|
27
|
+
}
|
|
28
|
+
|
|
29
|
+
describe('LibraryCard', () => {
|
|
30
|
+
it('never labels its own kind', () => {
|
|
31
|
+
card({ kind: 'skill' });
|
|
32
|
+
expect(screen.queryByText(/^Skill$/i)).not.toBeInTheDocument();
|
|
33
|
+
|
|
34
|
+
cleanup();
|
|
35
|
+
card({ kind: 'integration', id: 'slack', name: 'slack', status: { state: 'ok', text: 'Connected' } });
|
|
36
|
+
expect(screen.queryByText(/^Integration$/i)).not.toBeInTheDocument();
|
|
37
|
+
});
|
|
38
|
+
|
|
39
|
+
it('says nothing about a healthy skill', () => {
|
|
40
|
+
card({ kind: 'skill', status: { state: 'ok', text: 'Ready' } });
|
|
41
|
+
// Not even "Ready": a green word on every skill in the grid is a row of
|
|
42
|
+
// noise that buries the two cards that actually need somebody.
|
|
43
|
+
expect(screen.queryByText('Ready')).not.toBeInTheDocument();
|
|
44
|
+
});
|
|
45
|
+
|
|
46
|
+
it('names what is in a blocked skill’s way', () => {
|
|
47
|
+
card({ kind: 'skill', status: { state: 'warn', text: 'Needs slack' } });
|
|
48
|
+
expect(screen.getByText('Needs slack')).toBeInTheDocument();
|
|
49
|
+
});
|
|
50
|
+
|
|
51
|
+
it('always states a tool’s connection, either way', () => {
|
|
52
|
+
card({ kind: 'integration', id: 'slack', name: 'slack', status: { state: 'ok', text: 'Connected' } });
|
|
53
|
+
expect(screen.getByText('Connected')).toBeInTheDocument();
|
|
54
|
+
|
|
55
|
+
cleanup();
|
|
56
|
+
card({
|
|
57
|
+
kind: 'integration',
|
|
58
|
+
id: 'notion',
|
|
59
|
+
name: 'notion',
|
|
60
|
+
status: { state: 'warn', text: 'Needs your sign-in' },
|
|
61
|
+
});
|
|
62
|
+
expect(screen.getByText('Needs your sign-in')).toBeInTheDocument();
|
|
63
|
+
});
|
|
64
|
+
|
|
65
|
+
it('carries a version when the skill declares one', () => {
|
|
66
|
+
card({ version: '1.4.0' });
|
|
67
|
+
expect(screen.getByText('v1.4.0')).toBeInTheDocument();
|
|
68
|
+
});
|
|
69
|
+
|
|
70
|
+
it('shows no version for the many skills that declare none', () => {
|
|
71
|
+
// Absence is the normal case — `version:` is optional in `SKILL.md`, and
|
|
72
|
+
// no skill in the shipped KB sets it. An empty slot, not a placeholder.
|
|
73
|
+
card({ version: undefined });
|
|
74
|
+
expect(screen.queryByText(/^v/)).not.toBeInTheDocument();
|
|
75
|
+
});
|
|
76
|
+
|
|
77
|
+
it('still marks what you own', () => {
|
|
78
|
+
card({ owned: true });
|
|
79
|
+
expect(screen.getByText('Owner')).toBeInTheDocument();
|
|
80
|
+
});
|
|
81
|
+
|
|
82
|
+
/**
|
|
83
|
+
* A proposed skill — one that exists only on an open change request.
|
|
84
|
+
*
|
|
85
|
+
* Before this, a skill an agent proposed was in the product nowhere at all
|
|
86
|
+
* until somebody merged it: the catalog reads the default branch, and the
|
|
87
|
+
* request had not landed there. The card is the fix, and what it has to say
|
|
88
|
+
* differs by who is reading it — the author is waiting on somebody, the
|
|
89
|
+
* approver IS the somebody.
|
|
90
|
+
*/
|
|
91
|
+
it('says a proposed skill is in review, and who it is between', () => {
|
|
92
|
+
card({ pending: { authorName: 'Ali Raza', mine: false } });
|
|
93
|
+
expect(screen.getByText('In review')).toBeInTheDocument();
|
|
94
|
+
expect(screen.getByText(/From Ali Raza: waiting on you/)).toBeInTheDocument();
|
|
95
|
+
|
|
96
|
+
cleanup();
|
|
97
|
+
card({ pending: { authorName: 'Ali Raza', mine: true } });
|
|
98
|
+
expect(screen.getByText('Waiting on approval')).toBeInTheDocument();
|
|
99
|
+
expect(screen.queryByText(/waiting on you/)).not.toBeInTheDocument();
|
|
100
|
+
});
|
|
101
|
+
|
|
102
|
+
it('does not report integration status on something nobody has approved', () => {
|
|
103
|
+
// The status line is about a skill's integrations. On a proposal it would
|
|
104
|
+
// answer a question nobody is asking yet, over the one thing to know: that
|
|
105
|
+
// it is not usable.
|
|
106
|
+
card({ status: { state: 'warn', text: 'Needs slack' }, pending: { authorName: 'Ali', mine: true } });
|
|
107
|
+
expect(screen.queryByText('Needs slack')).not.toBeInTheDocument();
|
|
108
|
+
});
|
|
109
|
+
|
|
110
|
+
it('does not call a proposal yours to own', () => {
|
|
111
|
+
// `Owner` means you can change the released skill. There is no released
|
|
112
|
+
// skill, so the two badges would contradict each other in one row.
|
|
113
|
+
card({ owned: true, pending: { authorName: 'Ali', mine: true } });
|
|
114
|
+
expect(screen.queryByText('Owner')).not.toBeInTheDocument();
|
|
115
|
+
expect(screen.getByText('In review')).toBeInTheDocument();
|
|
116
|
+
});
|
|
117
|
+
});
|
|
118
|
+
|
|
119
|
+
describe('personalGroupName', () => {
|
|
120
|
+
it('uses the first name, as a colleague would say it out loud', () => {
|
|
121
|
+
expect(personalGroupName('Juan Viera')).toBe("Juan's Group");
|
|
122
|
+
expect(personalGroupName('juan')).toBe("Juan's Group");
|
|
123
|
+
});
|
|
124
|
+
|
|
125
|
+
it('still names the place when nobody is signed in', () => {
|
|
126
|
+
// The space exists either way and still needs a heading — and "Yours" is
|
|
127
|
+
// true for whoever is reading it.
|
|
128
|
+
expect(personalGroupName(null)).toBe('Yours');
|
|
129
|
+
expect(personalGroupName(' ')).toBe('Yours');
|
|
130
|
+
});
|
|
131
|
+
});
|
|
132
|
+
|
|
133
|
+
describe('displayFirstName', () => {
|
|
134
|
+
// A sign-in record is not a style guide: an account created from a lowercase
|
|
135
|
+
// name should still be greeted the way a person writes their own.
|
|
136
|
+
it('capitalizes the first name', () => {
|
|
137
|
+
expect(displayFirstName('juan viera')).toBe('Juan');
|
|
138
|
+
expect(displayFirstName('Juan Viera')).toBe('Juan');
|
|
139
|
+
expect(displayFirstName(' juan ')).toBe('Juan');
|
|
140
|
+
});
|
|
141
|
+
|
|
142
|
+
// Empty rather than a fallback, because the two callers want different
|
|
143
|
+
// words for it — "Yours" on the group heading, "there" on the welcome page.
|
|
144
|
+
it('gives nothing back when there is no name, and lets the caller decide', () => {
|
|
145
|
+
expect(displayFirstName(null)).toBe('');
|
|
146
|
+
expect(displayFirstName(undefined)).toBe('');
|
|
147
|
+
expect(displayFirstName(' ')).toBe('');
|
|
148
|
+
});
|
|
149
|
+
});
|