@bevel-software/platform-core-frontend 0.4.1 → 0.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (326) hide show
  1. package/package.json +5 -3
  2. package/src/core/CoreAppShell.tsx +195 -56
  3. package/src/core/__tests__/AppChrome.test.tsx +125 -0
  4. package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
  5. package/src/core/__tests__/bootstrap.test.ts +63 -0
  6. package/src/core/bootstrap.ts +73 -0
  7. package/src/core/events.ts +12 -0
  8. package/src/core/registry.ts +58 -9
  9. package/src/index.css +100 -11
  10. package/src/index.ts +24 -23
  11. package/src/lib/utils.ts +93 -117
  12. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
  14. package/src/modules/access/api.ts +49 -0
  15. package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
  16. package/src/modules/access/hooks/useFileAccess.ts +1 -1
  17. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
  18. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
  19. package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
  20. package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
  21. package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
  22. package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
  23. package/src/modules/admin/state/admin.context.tsx +15 -6
  24. package/src/modules/auth/components/AccountPage.tsx +11 -11
  25. package/src/modules/auth/components/LoginScreen.tsx +12 -12
  26. package/src/modules/auth/services/sso.ts +47 -1
  27. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
  28. package/src/modules/change-requests/__tests__/author.test.ts +48 -0
  29. package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
  30. package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
  31. package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
  32. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
  33. package/src/modules/change-requests/change-requests.css +22 -0
  34. package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
  35. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
  36. package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
  37. package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
  38. package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
  39. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
  40. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
  41. package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
  42. package/src/modules/change-requests/services/change-requests.api.ts +45 -0
  43. package/src/modules/change-requests/services/propose.api.ts +162 -0
  44. package/src/modules/change-requests/utils/author.ts +47 -0
  45. package/src/modules/change-requests/utils/conflict.ts +38 -0
  46. package/src/modules/change-requests/utils/diff.ts +80 -0
  47. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
  48. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
  49. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
  50. package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
  51. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
  52. package/src/modules/git/components/BranchSwitcher.tsx +68 -31
  53. package/src/modules/git/components/DiffView.tsx +4 -4
  54. package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
  55. package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
  56. package/src/modules/git/components/PullNeededBanner.tsx +6 -13
  57. package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
  58. package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
  59. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
  60. package/src/modules/git/hooks/useGitState.ts +15 -14
  61. package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
  62. package/src/modules/git/services/error-messages.ts +7 -7
  63. package/src/modules/git/services/git.api.ts +17 -11
  64. package/src/modules/git/services/pr-prompts.ts +2 -2
  65. package/src/modules/git/state/git.context.ts +10 -1
  66. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
  67. package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
  68. package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
  69. package/src/modules/layout/breakpoints.ts +6 -0
  70. package/src/modules/layout/components/AppLayout.tsx +17 -5
  71. package/src/modules/layout/components/DemoBanner.tsx +10 -1
  72. package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
  73. package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
  74. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
  75. package/src/modules/layout/components/SidebarFrame.tsx +317 -0
  76. package/src/modules/layout/components/SidebarToggle.tsx +86 -0
  77. package/src/modules/layout/components/SlideOverlay.tsx +1 -1
  78. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
  79. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
  80. package/src/modules/layout/state/sidebar.ts +200 -0
  81. package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
  82. package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
  83. package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
  84. package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
  85. package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
  86. package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
  87. package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
  88. package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
  89. package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
  90. package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
  91. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
  92. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
  93. package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
  94. package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
  95. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
  96. package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
  97. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
  98. package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
  99. package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
  100. package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
  101. package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
  102. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
  103. package/src/modules/library/__tests__/auth-harness.tsx +37 -0
  104. package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
  105. package/src/modules/library/__tests__/status.test.ts +113 -20
  106. package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
  107. package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
  108. package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
  109. package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
  110. package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
  111. package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
  112. package/src/modules/library/components/GroupIndexRow.tsx +63 -0
  113. package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
  114. package/src/modules/library/components/GroupPage.tsx +373 -0
  115. package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
  116. package/src/modules/library/components/GroupsSidebar.tsx +338 -0
  117. package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
  118. package/src/modules/library/components/LibraryCard.tsx +123 -102
  119. package/src/modules/library/components/LibraryLayout.tsx +344 -0
  120. package/src/modules/library/components/LibraryPage.tsx +111 -227
  121. package/src/modules/library/components/LockGlyph.tsx +31 -0
  122. package/src/modules/library/components/LockedGroupView.tsx +159 -0
  123. package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
  124. package/src/modules/library/components/NewGroupDialog.tsx +112 -0
  125. package/src/modules/library/components/NewSkillPanel.tsx +151 -0
  126. package/src/modules/library/components/PageActions.tsx +156 -0
  127. package/src/modules/library/components/PendingSkillReview.tsx +63 -0
  128. package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
  129. package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
  130. package/src/modules/library/components/StatusDot.tsx +25 -0
  131. package/src/modules/library/components/ToolLogo.tsx +171 -0
  132. package/src/modules/library/components/group-page-parts.tsx +419 -0
  133. package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
  134. package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
  135. package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
  136. package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
  137. package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
  138. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
  139. package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
  140. package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
  141. package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
  142. package/src/modules/library/hooks/useJoinRequests.ts +114 -0
  143. package/src/modules/library/hooks/useLibraryData.ts +134 -119
  144. package/src/modules/library/hooks/useSkillDetail.ts +119 -74
  145. package/src/modules/library/hooks/useToolPage.ts +145 -0
  146. package/src/modules/library/library.css +33 -245
  147. package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
  148. package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
  149. package/src/modules/library/routes/library-paths.ts +191 -0
  150. package/src/modules/library/services/groups.api.ts +189 -0
  151. package/src/modules/library/services/library.api.ts +291 -164
  152. package/src/modules/library/services/tools.api.ts +60 -0
  153. package/src/modules/library/state/library-context.ts +22 -0
  154. package/src/modules/library/state/library-data.tsx +223 -0
  155. package/src/modules/library/state/toast.context.ts +32 -0
  156. package/src/modules/library/state/toast.tsx +84 -42
  157. package/src/modules/library/utils/clipboard.ts +33 -0
  158. package/src/modules/library/utils/group-summary.ts +68 -0
  159. package/src/modules/library/utils/names.ts +30 -0
  160. package/src/modules/library/utils/navigate-external.ts +15 -0
  161. package/src/modules/library/utils/oauth-fragment.ts +32 -0
  162. package/src/modules/library/utils/personal-group.ts +36 -0
  163. package/src/modules/library/utils/status.ts +108 -25
  164. package/src/modules/library/utils/toast-duration.ts +16 -0
  165. package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
  166. package/src/modules/onboarding/agent-clients.ts +48 -0
  167. package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
  168. package/src/modules/onboarding/components/RootLanding.tsx +54 -0
  169. package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
  170. package/src/modules/onboarding/paths.ts +9 -0
  171. package/src/modules/onboarding/state/onboarding.ts +191 -0
  172. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
  173. package/src/modules/pr/services/pr-approvals.api.ts +19 -0
  174. package/src/modules/pr/services/pr-cancel.api.ts +11 -0
  175. package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
  176. package/src/modules/review/components/DiffViewer.tsx +4 -4
  177. package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
  178. package/src/modules/review/components/ReviewFileRow.tsx +10 -10
  179. package/src/modules/review/components/ReviewPanel.tsx +49 -17
  180. package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
  181. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
  182. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
  183. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
  184. package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
  185. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
  186. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
  187. package/src/modules/secrets-vault/services/connect.api.ts +24 -3
  188. package/src/modules/settings/components/DeploymentPage.tsx +90 -0
  189. package/src/modules/settings/components/SettingsLayout.tsx +135 -0
  190. package/src/modules/settings/components/SettingsNav.tsx +114 -0
  191. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
  192. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
  193. package/src/modules/settings/settings-nav-items.tsx +166 -0
  194. package/src/modules/setup/__tests__/setup.test.tsx +540 -0
  195. package/src/modules/setup/components/SetupGate.tsx +67 -0
  196. package/src/modules/setup/components/SetupScreen.tsx +573 -0
  197. package/src/modules/setup/services/setup.api.ts +106 -0
  198. package/src/modules/setup/utils/git-host.ts +34 -0
  199. package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
  200. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
  201. package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
  202. package/src/modules/toolbar/components/Toolbar.tsx +56 -54
  203. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
  204. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
  205. package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
  206. package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
  207. package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
  208. package/src/modules/workspace/components/EditorTabs.tsx +82 -50
  209. package/src/modules/workspace/components/FileExplorer.tsx +413 -189
  210. package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
  211. package/src/modules/workspace/components/FileRoute.tsx +89 -84
  212. package/src/modules/workspace/components/FileViewer.tsx +700 -294
  213. package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
  214. package/src/modules/workspace/components/KbFileRail.tsx +128 -0
  215. package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
  216. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
  217. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
  218. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
  219. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
  220. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
  221. package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
  222. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
  223. package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
  224. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
  225. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
  226. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
  227. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
  228. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
  229. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
  230. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
  231. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
  232. package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
  233. package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
  234. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
  235. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
  236. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
  237. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
  238. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
  239. package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
  240. package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
  241. package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
  242. package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
  243. package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
  244. package/src/modules/workspace/components/renderers/index.ts +78 -2
  245. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
  246. package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
  247. package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
  248. package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
  249. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
  250. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
  251. package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
  252. package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
  253. package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
  254. package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
  255. package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
  256. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
  257. package/src/modules/workspace/services/workspace.api.ts +9 -2
  258. package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
  259. package/src/modules/workspace/state/open-change-requests.tsx +185 -0
  260. package/src/modules/workspace/state/workspace.context.ts +9 -0
  261. package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
  262. package/src/modules/workspace/utils/diff.ts +130 -53
  263. package/src/modules/workspace/utils/fileTree.ts +7 -4
  264. package/src/modules/workspace/workspace.css +28 -0
  265. package/src/shared/components/Badge.tsx +62 -0
  266. package/src/shared/components/Banner.tsx +58 -0
  267. package/src/shared/components/Button.tsx +90 -0
  268. package/src/shared/components/Dialog.tsx +6 -6
  269. package/src/shared/components/Field.tsx +45 -0
  270. package/src/shared/components/IconButton.tsx +74 -0
  271. package/src/shared/components/ListRow.tsx +96 -0
  272. package/src/shared/components/Menu.tsx +88 -0
  273. package/src/shared/components/PageShell.tsx +8 -5
  274. package/src/shared/components/Surface.tsx +86 -0
  275. package/src/shared/components/__tests__/primitives.test.tsx +333 -0
  276. package/src/shared/components/index.ts +48 -0
  277. package/src/shared/components/useDismissableMenu.ts +71 -0
  278. package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
  279. package/src/shared/theme/index.css +12 -0
  280. package/src/shared/theme/measure.ts +64 -0
  281. package/src/shared/theme/shadows.css +34 -0
  282. package/src/shared/theme/tokens.css +193 -0
  283. package/src/test-setup.ts +9 -0
  284. package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
  285. package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
  286. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
  287. package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
  288. package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
  289. package/src/modules/library/__tests__/diff.test.ts +0 -62
  290. package/src/modules/library/__tests__/loadout.test.tsx +0 -72
  291. package/src/modules/library/components/CompareView.tsx +0 -357
  292. package/src/modules/library/components/DetailDialog.tsx +0 -566
  293. package/src/modules/library/components/GearIcon.tsx +0 -12
  294. package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
  295. package/src/modules/library/components/StatusGem.tsx +0 -21
  296. package/src/modules/library/components/SuggestChange.tsx +0 -171
  297. package/src/modules/library/components/particles.ts +0 -50
  298. package/src/modules/library/state/loadout.tsx +0 -129
  299. package/src/modules/library/utils/diff.ts +0 -102
  300. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
  301. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
  302. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
  303. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
  304. package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
  305. package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
  306. package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
  307. package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
  308. package/src/modules/pr/components/PrCancelButton.tsx +0 -99
  309. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
  310. package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
  311. package/src/modules/pr/components/PrCommentThread.tsx +0 -168
  312. package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
  313. package/src/modules/pr/components/PrDiffPane.tsx +0 -425
  314. package/src/modules/pr/components/PrFileRow.tsx +0 -164
  315. package/src/modules/pr/components/PrFilesList.tsx +0 -53
  316. package/src/modules/pr/components/PrHeader.tsx +0 -45
  317. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
  318. package/src/modules/pr/components/PrMergeButton.tsx +0 -268
  319. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
  320. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
  321. package/src/modules/pr/components/PrViewer.tsx +0 -364
  322. package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
  323. package/src/modules/pr/state/pr-viewer.context.ts +0 -34
  324. package/src/modules/pr/utils/bucketize-comments.ts +0 -55
  325. package/src/modules/pr/utils/parsePatch.ts +0 -57
  326. package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
@@ -3,7 +3,12 @@ import { Check, Trash2, Eye, ChevronDown, X } from 'lucide-react';
3
3
  import type { PendingChange } from '@bevel-software/platform-shared';
4
4
  import { useReview } from '../state/review.context';
5
5
  import { useWorkspace } from '../../workspace/state/workspace.context';
6
- import { useFileNav } from '../../workspace/routing/kb-routes';
6
+ import {
7
+ useFileNav,
8
+ useNodeIdNav,
9
+ resolveRelativePath,
10
+ KB_ROUTE_PREFIX,
11
+ } from '../../workspace/routing/kb-routes';
7
12
  import { ReviewFileRow } from './ReviewFileRow';
8
13
  import { DiffViewer } from './DiffViewer';
9
14
  import { MarkdownDiffViewer } from './MarkdownDiffViewer';
@@ -43,6 +48,29 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
43
48
  const review = useReview();
44
49
  const { refreshFileTree } = useWorkspace();
45
50
  const { openFile } = useFileNav();
51
+ // Links inside a rendered diff. Both resolvers navigate relative to
52
+ // `git.status.branch`, which is CORRECT here and only here: this panel
53
+ // reviews the agent's uncommitted changes on the branch you are already
54
+ // standing on, so "the diff's branch" and "the current branch" are the same
55
+ // thing. (The change-request dialog is not in that position, which is why it
56
+ // passes no resolvers — see the comment at its MarkdownDiffViewer call.)
57
+ const { openNodeId } = useNodeIdNav();
58
+ const diffPath = review.fileDiff?.path ?? '';
59
+ const openDiffLink = useCallback(
60
+ (href: string) => {
61
+ // Absolute workspace URLs carry their own branch; running them through
62
+ // resolveRelativePath would treat them as relative to the diffed file
63
+ // and mangle the path. Same guard as MarkdownRenderer's handleFileLink.
64
+ if (href.startsWith(`${KB_ROUTE_PREFIX}/`)) {
65
+ openFile(href);
66
+ return;
67
+ }
68
+ let decoded = href;
69
+ try { decoded = decodeURIComponent(href); } catch { /* leave as-is */ }
70
+ openFile(resolveRelativePath(diffPath, decoded));
71
+ },
72
+ [openFile, diffPath],
73
+ );
46
74
  const [busy, setBusy] = useState(false);
47
75
  // `busy` alone is not re-entrant-safe: two rapid clicks (or a click + a
48
76
  // keyboard activation of the same button) can both read `busy === false`
@@ -127,12 +155,12 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
127
155
 
128
156
  return (
129
157
  <div className="absolute inset-0 z-20 flex flex-col bg-white">
130
- <div className="min-h-10 border-b border-slate-200 flex flex-wrap items-center px-3 py-1.5 gap-2 shrink-0">
158
+ <div className="min-h-10 border-b border-line flex flex-wrap items-center px-3 py-1.5 gap-2 shrink-0">
131
159
  <Eye size={14} className="text-emerald-600 shrink-0" />
132
- <span className="text-sm font-medium text-slate-900 shrink-0">
160
+ <span className="text-sm font-medium text-ink shrink-0">
133
161
  Review agent changes
134
162
  </span>
135
- <span className="text-xs text-slate-600 shrink-0">
163
+ <span className="text-xs text-ink-muted shrink-0">
136
164
  {count} file{count === 1 ? '' : 's'} pending
137
165
  </span>
138
166
 
@@ -142,26 +170,26 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
142
170
  onClick={() => setPickerOpen((v) => !v)}
143
171
  aria-haspopup="listbox"
144
172
  aria-expanded={pickerOpen}
145
- className="w-full flex items-center gap-2 px-2.5 py-1 rounded border border-slate-300 bg-white hover:bg-slate-50 text-left"
173
+ className="w-full flex items-center gap-2 px-2.5 py-1 rounded border border-line-strong bg-white hover:bg-hover text-left"
146
174
  >
147
- <span className="text-xs text-slate-900 truncate flex-1" title={selected?.path}>
175
+ <span className="text-xs text-ink truncate flex-1" title={selected?.path}>
148
176
  {selectedLabel}
149
177
  </span>
150
178
  {selectedKind && (
151
- <span className="text-[10px] uppercase tracking-wider text-slate-600 shrink-0">
179
+ <span className="text-[10px] uppercase tracking-wider text-ink-muted shrink-0">
152
180
  {selectedKind}
153
181
  </span>
154
182
  )}
155
183
  <ChevronDown
156
184
  size={12}
157
- className={`text-slate-600 shrink-0 transition-transform ${pickerOpen ? 'rotate-180' : ''}`}
185
+ className={`text-ink-muted shrink-0 transition-transform ${pickerOpen ? 'rotate-180' : ''}`}
158
186
  />
159
187
  </button>
160
188
 
161
189
  {pickerOpen && (
162
190
  <div
163
191
  role="listbox"
164
- className="absolute left-0 right-0 top-full mt-1 max-h-[60vh] overflow-y-auto bg-white border border-slate-200 rounded-md shadow-xl z-30 p-1 space-y-1"
192
+ className="absolute left-0 right-0 top-full mt-1 max-h-[60vh] overflow-y-auto bg-white border border-line rounded-md shadow-xl z-30 p-1 space-y-1"
165
193
  >
166
194
  {session.changes.map((change) => (
167
195
  <ReviewFileRow
@@ -188,8 +216,8 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
188
216
  : selected ? review.rejectOne(selected.path) : Promise.resolve(),
189
217
  )
190
218
  }
191
- title={applyToAll ? 'Delete every pending change — restore the originals' : 'Delete this change — restore the original'}
192
- className="flex items-center gap-1.5 px-2.5 py-1 rounded text-xs font-medium text-slate-700 hover:text-red-700 hover:bg-red-100 disabled:opacity-40"
219
+ title={applyToAll ? 'Delete every pending change. Restore the originals' : 'Delete this change. Restore the original'}
220
+ className="flex items-center gap-1.5 px-2.5 py-1 rounded text-xs font-medium text-ink hover:text-red-700 hover:bg-red-100 disabled:opacity-40"
193
221
  >
194
222
  <Trash2 size={12} />
195
223
  Delete
@@ -210,7 +238,7 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
210
238
  <Check size={12} />
211
239
  Accept
212
240
  </button>
213
- <label className="flex items-center gap-1.5 text-xs text-slate-700 select-none shrink-0 cursor-pointer">
241
+ <label className="flex items-center gap-1.5 text-xs text-ink select-none shrink-0 cursor-pointer">
214
242
  <input
215
243
  type="checkbox"
216
244
  checked={applyToAll}
@@ -224,9 +252,9 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
224
252
  <button
225
253
  type="button"
226
254
  onClick={onClose}
227
- title="Close review — changes stay pending"
255
+ title="Close review: changes stay pending"
228
256
  aria-label="Close review"
229
- className="ml-1 p-1 rounded text-slate-500 hover:text-slate-900 hover:bg-slate-100 shrink-0"
257
+ className="ml-1 p-1 rounded text-ink-muted hover:text-ink hover:bg-hover shrink-0"
230
258
  >
231
259
  <X size={16} />
232
260
  </button>
@@ -235,12 +263,12 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
235
263
 
236
264
  <div className="flex-1 min-w-0 min-h-0">
237
265
  {isLoadingDiff && (
238
- <div className="h-full flex items-center justify-center text-xs text-slate-600">
266
+ <div className="h-full flex items-center justify-center text-xs text-ink-muted">
239
267
  Loading diff…
240
268
  </div>
241
269
  )}
242
270
  {!isLoadingDiff && !fileDiff && (
243
- <div className="h-full flex items-center justify-center text-xs text-slate-600">
271
+ <div className="h-full flex items-center justify-center text-xs text-ink-muted">
244
272
  Select a file to see the diff.
245
273
  </div>
246
274
  )}
@@ -249,7 +277,11 @@ export function ReviewPanel({ onClose }: { onClose?: () => void }) {
249
277
  )}
250
278
  {!isLoadingDiff && fileDiff && !fileDiff.isBinary && (
251
279
  isMarkdownPath(fileDiff.path) ? (
252
- <MarkdownDiffViewer payload={fileDiff} />
280
+ <MarkdownDiffViewer
281
+ payload={fileDiff}
282
+ onOpenFile={openDiffLink}
283
+ onOpenNodeId={openNodeId}
284
+ />
253
285
  ) : (
254
286
  <DiffViewer payload={fileDiff} />
255
287
  )
@@ -39,7 +39,7 @@ export function ReviewPanelSurface() {
39
39
  <button
40
40
  type="button"
41
41
  onClick={() => setReviewPanelOpen(true)}
42
- className="absolute bottom-4 right-4 z-20 flex items-center gap-2 px-3 py-2 rounded-full shadow-lg bg-emerald-700 hover:bg-emerald-600 text-white text-xs font-medium"
42
+ className="absolute bottom-4 right-4 z-20 flex items-center gap-2 px-3 py-2 rounded-full shadow-lg bg-ok hover:bg-ok/90 text-white text-xs font-medium"
43
43
  title="Review the agent's pending changes"
44
44
  >
45
45
  <Eye size={14} />
@@ -0,0 +1,122 @@
1
+ import { describe, it, expect, vi } from 'vitest';
2
+ import { render, screen } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import type { FileDiffPayload } from '@bevel-software/platform-shared';
5
+ import { MarkdownDiffViewer } from '../MarkdownDiffViewer';
6
+
7
+ /**
8
+ * The diff viewer renders through the shared KB markdown pipeline, so a diff
9
+ * reads like the document it is a diff of. These tests pin the two things that
10
+ * make that safe rather than merely nice: it must stay renderable with NO
11
+ * providers, and it must never swallow content.
12
+ */
13
+
14
+ function payload(baseline: string, current: string): FileDiffPayload {
15
+ return {
16
+ path: 'Knowledge/Node.md',
17
+ kind: 'modified',
18
+ baseline,
19
+ current,
20
+ isBinary: false,
21
+ } as FileDiffPayload;
22
+ }
23
+
24
+ describe('MarkdownDiffViewer', () => {
25
+ /**
26
+ * The load-bearing constraint. This component is rendered by the
27
+ * change-request dialog and the file-history panel — both of which are
28
+ * exercised bare in their own tests — and it is reachable from the embed
29
+ * routes, which mount outside the Git/Workspace providers. If a future edit
30
+ * reaches for `useFileNav()` instead of taking a resolver as a prop, this
31
+ * test fails immediately rather than the embed crashing in production.
32
+ */
33
+ it('renders with no Router and no Git/Workspace providers', () => {
34
+ render(<MarkdownDiffViewer payload={payload('# Old title\n', '# New title\n')} />);
35
+ expect(screen.getByRole('heading', { name: 'New title' })).toBeInTheDocument();
36
+ expect(screen.getByRole('heading', { name: 'Old title' })).toBeInTheDocument();
37
+ });
38
+
39
+ it('renders unchanged text once and changed text on both sides', () => {
40
+ render(
41
+ <MarkdownDiffViewer
42
+ payload={payload('shared para\n\nold line\n', 'shared para\n\nnew line\n')}
43
+ />,
44
+ );
45
+ expect(screen.getByText('shared para')).toBeInTheDocument();
46
+ expect(screen.getByText('old line')).toBeInTheDocument();
47
+ expect(screen.getByText('new line')).toBeInTheDocument();
48
+ });
49
+
50
+ describe('node-id links', () => {
51
+ // The link exists only on the added side, so its text is unambiguous —
52
+ // a diff renders both sides, so a fixture sharing text across them would
53
+ // match twice.
54
+ const withIdLink = payload('See nothing yet\n', 'See [the process](order-intake)\n');
55
+
56
+ it('are inert when no resolver is supplied', () => {
57
+ const { container } = render(<MarkdownDiffViewer payload={withIdLink} />);
58
+ // A bare id must never fall through as a relative-URL anchor — that
59
+ // would navigate the SPA to a path that does not exist.
60
+ const anchors = Array.from(container.querySelectorAll('a'));
61
+ expect(anchors.some((a) => a.getAttribute('href') === 'order-intake')).toBe(false);
62
+ expect(screen.getAllByText('the process').length).toBeGreaterThan(0);
63
+ });
64
+
65
+ it('call the injected resolver when one is supplied', async () => {
66
+ const onOpenNodeId = vi.fn();
67
+ render(<MarkdownDiffViewer payload={withIdLink} onOpenNodeId={onOpenNodeId} />);
68
+ await userEvent.click(screen.getByText('the process'));
69
+ expect(onOpenNodeId).toHaveBeenCalledWith('order-intake');
70
+ });
71
+ });
72
+
73
+ it('escapes spaces in link destinations so KB links resolve', () => {
74
+ const onOpenFile = vi.fn();
75
+ render(
76
+ <MarkdownDiffViewer
77
+ payload={payload('a\n', 'a\n\n[Foo](Some File.md)\n')}
78
+ onOpenFile={onOpenFile}
79
+ />,
80
+ );
81
+ // Without escaping, CommonMark rejects the unescaped space and the whole
82
+ // link renders as literal text — the diff viewer's behaviour before it
83
+ // adopted the KB pipeline.
84
+ expect(screen.getByText('Foo')).toBeInTheDocument();
85
+ });
86
+
87
+ it('renders raw HTML blocks rather than escaping them', () => {
88
+ const { container } = render(
89
+ <MarkdownDiffViewer
90
+ payload={payload('x\n', 'x\n\n<details><summary>Source</summary>body</details>\n')}
91
+ />,
92
+ );
93
+ expect(container.querySelector('details')).toBeTruthy();
94
+ });
95
+
96
+ /**
97
+ * rehype-raw is only safe alongside rehype-sanitize, and this surface renders
98
+ * content someone else has PROPOSED — the one place an injected script would
99
+ * be most valuable to an attacker and least expected by a reviewer.
100
+ */
101
+ it('sanitises dangerous markup in proposed content', () => {
102
+ const { container } = render(
103
+ <MarkdownDiffViewer
104
+ payload={payload('x\n', 'x\n\n<img src=q onerror="alert(1)">\n')}
105
+ />,
106
+ );
107
+ expect(container.innerHTML).not.toContain('onerror');
108
+ });
109
+
110
+ it('does not render a frontmatter panel for a body fragment that opens on a thematic break', () => {
111
+ // `parseFrontmatter` matches ANY string starting with `---`, and diff
112
+ // fragments are split at arbitrary change boundaries. Rendering a fragment
113
+ // through a frontmatter-parsing view would swallow everything between the
114
+ // two rules. The text must survive.
115
+ render(
116
+ <MarkdownDiffViewer
117
+ payload={payload('intro\n', 'intro\n\n---\n\nvisible body text\n\n---\n')}
118
+ />,
119
+ );
120
+ expect(screen.getByText('visible body text')).toBeInTheDocument();
121
+ });
122
+ });
@@ -27,7 +27,7 @@ function mkSession(paths: string[]): ReviewSession {
27
27
  return { branchName: 'main', baselineRef: '', createdAt: '', changes: paths.map(mkChange) };
28
28
  }
29
29
 
30
- describe('useReviewState — optimistic reject', () => {
30
+ describe('useReviewState: optimistic reject', () => {
31
31
  beforeEach(() => {
32
32
  vi.clearAllMocks();
33
33
  });