@bevel-software/platform-core-frontend 0.4.1 → 0.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (326) hide show
  1. package/package.json +5 -3
  2. package/src/core/CoreAppShell.tsx +195 -56
  3. package/src/core/__tests__/AppChrome.test.tsx +125 -0
  4. package/src/core/__tests__/ShellRoutes.test.tsx +37 -2
  5. package/src/core/__tests__/bootstrap.test.ts +63 -0
  6. package/src/core/bootstrap.ts +73 -0
  7. package/src/core/events.ts +12 -0
  8. package/src/core/registry.ts +58 -9
  9. package/src/index.css +100 -11
  10. package/src/index.ts +24 -23
  11. package/src/lib/utils.ts +93 -117
  12. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
  14. package/src/modules/access/api.ts +49 -0
  15. package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
  16. package/src/modules/access/hooks/useFileAccess.ts +1 -1
  17. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
  18. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +17 -1
  19. package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
  20. package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
  21. package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
  22. package/src/modules/admin/components/UserAccountsPage.tsx +36 -28
  23. package/src/modules/admin/state/admin.context.tsx +15 -6
  24. package/src/modules/auth/components/AccountPage.tsx +11 -11
  25. package/src/modules/auth/components/LoginScreen.tsx +12 -12
  26. package/src/modules/auth/services/sso.ts +47 -1
  27. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
  28. package/src/modules/change-requests/__tests__/author.test.ts +48 -0
  29. package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
  30. package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
  31. package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
  32. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
  33. package/src/modules/change-requests/change-requests.css +22 -0
  34. package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
  35. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
  36. package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
  37. package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
  38. package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
  39. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
  40. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
  41. package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
  42. package/src/modules/change-requests/services/change-requests.api.ts +45 -0
  43. package/src/modules/change-requests/services/propose.api.ts +162 -0
  44. package/src/modules/change-requests/utils/author.ts +47 -0
  45. package/src/modules/change-requests/utils/conflict.ts +38 -0
  46. package/src/modules/change-requests/utils/diff.ts +80 -0
  47. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
  48. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
  49. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
  50. package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
  51. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
  52. package/src/modules/git/components/BranchSwitcher.tsx +68 -31
  53. package/src/modules/git/components/DiffView.tsx +4 -4
  54. package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
  55. package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
  56. package/src/modules/git/components/PullNeededBanner.tsx +6 -13
  57. package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
  58. package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
  59. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
  60. package/src/modules/git/hooks/useGitState.ts +15 -14
  61. package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
  62. package/src/modules/git/services/error-messages.ts +7 -7
  63. package/src/modules/git/services/git.api.ts +17 -11
  64. package/src/modules/git/services/pr-prompts.ts +2 -2
  65. package/src/modules/git/state/git.context.ts +10 -1
  66. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
  67. package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
  68. package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
  69. package/src/modules/layout/breakpoints.ts +6 -0
  70. package/src/modules/layout/components/AppLayout.tsx +17 -5
  71. package/src/modules/layout/components/DemoBanner.tsx +10 -1
  72. package/src/modules/layout/components/MaintenanceOverlay.tsx +3 -3
  73. package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
  74. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
  75. package/src/modules/layout/components/SidebarFrame.tsx +317 -0
  76. package/src/modules/layout/components/SidebarToggle.tsx +86 -0
  77. package/src/modules/layout/components/SlideOverlay.tsx +1 -1
  78. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
  79. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
  80. package/src/modules/layout/state/sidebar.ts +200 -0
  81. package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
  82. package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
  83. package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
  84. package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
  85. package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
  86. package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
  87. package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
  88. package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
  89. package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
  90. package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
  91. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
  92. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
  93. package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
  94. package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
  95. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
  96. package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
  97. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
  98. package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
  99. package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
  100. package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
  101. package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
  102. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
  103. package/src/modules/library/__tests__/auth-harness.tsx +37 -0
  104. package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
  105. package/src/modules/library/__tests__/status.test.ts +113 -20
  106. package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
  107. package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
  108. package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
  109. package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
  110. package/src/modules/library/components/ChangeRequestDock.tsx +52 -28
  111. package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
  112. package/src/modules/library/components/GroupIndexRow.tsx +63 -0
  113. package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
  114. package/src/modules/library/components/GroupPage.tsx +373 -0
  115. package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
  116. package/src/modules/library/components/GroupsSidebar.tsx +338 -0
  117. package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
  118. package/src/modules/library/components/LibraryCard.tsx +123 -102
  119. package/src/modules/library/components/LibraryLayout.tsx +344 -0
  120. package/src/modules/library/components/LibraryPage.tsx +111 -227
  121. package/src/modules/library/components/LockGlyph.tsx +31 -0
  122. package/src/modules/library/components/LockedGroupView.tsx +159 -0
  123. package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
  124. package/src/modules/library/components/NewGroupDialog.tsx +112 -0
  125. package/src/modules/library/components/NewSkillPanel.tsx +151 -0
  126. package/src/modules/library/components/PageActions.tsx +156 -0
  127. package/src/modules/library/components/PendingSkillReview.tsx +63 -0
  128. package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
  129. package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
  130. package/src/modules/library/components/StatusDot.tsx +25 -0
  131. package/src/modules/library/components/ToolLogo.tsx +171 -0
  132. package/src/modules/library/components/group-page-parts.tsx +419 -0
  133. package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
  134. package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
  135. package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
  136. package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
  137. package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
  138. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
  139. package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
  140. package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
  141. package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
  142. package/src/modules/library/hooks/useJoinRequests.ts +114 -0
  143. package/src/modules/library/hooks/useLibraryData.ts +134 -119
  144. package/src/modules/library/hooks/useSkillDetail.ts +119 -74
  145. package/src/modules/library/hooks/useToolPage.ts +145 -0
  146. package/src/modules/library/library.css +33 -245
  147. package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
  148. package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
  149. package/src/modules/library/routes/library-paths.ts +191 -0
  150. package/src/modules/library/services/groups.api.ts +189 -0
  151. package/src/modules/library/services/library.api.ts +291 -164
  152. package/src/modules/library/services/tools.api.ts +60 -0
  153. package/src/modules/library/state/library-context.ts +22 -0
  154. package/src/modules/library/state/library-data.tsx +223 -0
  155. package/src/modules/library/state/toast.context.ts +32 -0
  156. package/src/modules/library/state/toast.tsx +84 -42
  157. package/src/modules/library/utils/clipboard.ts +33 -0
  158. package/src/modules/library/utils/group-summary.ts +68 -0
  159. package/src/modules/library/utils/names.ts +30 -0
  160. package/src/modules/library/utils/navigate-external.ts +15 -0
  161. package/src/modules/library/utils/oauth-fragment.ts +32 -0
  162. package/src/modules/library/utils/personal-group.ts +36 -0
  163. package/src/modules/library/utils/status.ts +108 -25
  164. package/src/modules/library/utils/toast-duration.ts +16 -0
  165. package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
  166. package/src/modules/onboarding/agent-clients.ts +48 -0
  167. package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
  168. package/src/modules/onboarding/components/RootLanding.tsx +54 -0
  169. package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
  170. package/src/modules/onboarding/paths.ts +9 -0
  171. package/src/modules/onboarding/state/onboarding.ts +191 -0
  172. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
  173. package/src/modules/pr/services/pr-approvals.api.ts +19 -0
  174. package/src/modules/pr/services/pr-cancel.api.ts +11 -0
  175. package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
  176. package/src/modules/review/components/DiffViewer.tsx +4 -4
  177. package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
  178. package/src/modules/review/components/ReviewFileRow.tsx +10 -10
  179. package/src/modules/review/components/ReviewPanel.tsx +49 -17
  180. package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
  181. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
  182. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
  183. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
  184. package/src/modules/secrets-vault/components/SecretsPage.tsx +147 -110
  185. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
  186. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +35 -4
  187. package/src/modules/secrets-vault/services/connect.api.ts +24 -3
  188. package/src/modules/settings/components/DeploymentPage.tsx +90 -0
  189. package/src/modules/settings/components/SettingsLayout.tsx +135 -0
  190. package/src/modules/settings/components/SettingsNav.tsx +114 -0
  191. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
  192. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
  193. package/src/modules/settings/settings-nav-items.tsx +166 -0
  194. package/src/modules/setup/__tests__/setup.test.tsx +540 -0
  195. package/src/modules/setup/components/SetupGate.tsx +67 -0
  196. package/src/modules/setup/components/SetupScreen.tsx +573 -0
  197. package/src/modules/setup/services/setup.api.ts +106 -0
  198. package/src/modules/setup/utils/git-host.ts +34 -0
  199. package/src/modules/toolbar/components/AppSwitcher.tsx +38 -15
  200. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +50 -50
  201. package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
  202. package/src/modules/toolbar/components/Toolbar.tsx +56 -54
  203. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
  204. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
  205. package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
  206. package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
  207. package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
  208. package/src/modules/workspace/components/EditorTabs.tsx +82 -50
  209. package/src/modules/workspace/components/FileExplorer.tsx +413 -189
  210. package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
  211. package/src/modules/workspace/components/FileRoute.tsx +89 -84
  212. package/src/modules/workspace/components/FileViewer.tsx +700 -294
  213. package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
  214. package/src/modules/workspace/components/KbFileRail.tsx +128 -0
  215. package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
  216. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
  217. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
  218. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
  219. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
  220. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
  221. package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
  222. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
  223. package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
  224. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
  225. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
  226. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
  227. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
  228. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
  229. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
  230. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
  231. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
  232. package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
  233. package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
  234. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
  235. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
  236. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
  237. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
  238. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
  239. package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
  240. package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
  241. package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
  242. package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
  243. package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
  244. package/src/modules/workspace/components/renderers/index.ts +78 -2
  245. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
  246. package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
  247. package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
  248. package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
  249. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
  250. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
  251. package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
  252. package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
  253. package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
  254. package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
  255. package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
  256. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
  257. package/src/modules/workspace/services/workspace.api.ts +9 -2
  258. package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
  259. package/src/modules/workspace/state/open-change-requests.tsx +185 -0
  260. package/src/modules/workspace/state/workspace.context.ts +9 -0
  261. package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
  262. package/src/modules/workspace/utils/diff.ts +130 -53
  263. package/src/modules/workspace/utils/fileTree.ts +7 -4
  264. package/src/modules/workspace/workspace.css +28 -0
  265. package/src/shared/components/Badge.tsx +62 -0
  266. package/src/shared/components/Banner.tsx +58 -0
  267. package/src/shared/components/Button.tsx +90 -0
  268. package/src/shared/components/Dialog.tsx +6 -6
  269. package/src/shared/components/Field.tsx +45 -0
  270. package/src/shared/components/IconButton.tsx +74 -0
  271. package/src/shared/components/ListRow.tsx +96 -0
  272. package/src/shared/components/Menu.tsx +88 -0
  273. package/src/shared/components/PageShell.tsx +8 -5
  274. package/src/shared/components/Surface.tsx +86 -0
  275. package/src/shared/components/__tests__/primitives.test.tsx +333 -0
  276. package/src/shared/components/index.ts +48 -0
  277. package/src/shared/components/useDismissableMenu.ts +71 -0
  278. package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
  279. package/src/shared/theme/index.css +12 -0
  280. package/src/shared/theme/measure.ts +64 -0
  281. package/src/shared/theme/shadows.css +34 -0
  282. package/src/shared/theme/tokens.css +193 -0
  283. package/src/test-setup.ts +9 -0
  284. package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
  285. package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
  286. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
  287. package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
  288. package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
  289. package/src/modules/library/__tests__/diff.test.ts +0 -62
  290. package/src/modules/library/__tests__/loadout.test.tsx +0 -72
  291. package/src/modules/library/components/CompareView.tsx +0 -357
  292. package/src/modules/library/components/DetailDialog.tsx +0 -566
  293. package/src/modules/library/components/GearIcon.tsx +0 -12
  294. package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
  295. package/src/modules/library/components/StatusGem.tsx +0 -21
  296. package/src/modules/library/components/SuggestChange.tsx +0 -171
  297. package/src/modules/library/components/particles.ts +0 -50
  298. package/src/modules/library/state/loadout.tsx +0 -129
  299. package/src/modules/library/utils/diff.ts +0 -102
  300. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
  301. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
  302. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
  303. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
  304. package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
  305. package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
  306. package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
  307. package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
  308. package/src/modules/pr/components/PrCancelButton.tsx +0 -99
  309. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
  310. package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
  311. package/src/modules/pr/components/PrCommentThread.tsx +0 -168
  312. package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
  313. package/src/modules/pr/components/PrDiffPane.tsx +0 -425
  314. package/src/modules/pr/components/PrFileRow.tsx +0 -164
  315. package/src/modules/pr/components/PrFilesList.tsx +0 -53
  316. package/src/modules/pr/components/PrHeader.tsx +0 -45
  317. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
  318. package/src/modules/pr/components/PrMergeButton.tsx +0 -268
  319. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
  320. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
  321. package/src/modules/pr/components/PrViewer.tsx +0 -364
  322. package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
  323. package/src/modules/pr/state/pr-viewer.context.ts +0 -34
  324. package/src/modules/pr/utils/bucketize-comments.ts +0 -55
  325. package/src/modules/pr/utils/parsePatch.ts +0 -57
  326. package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
@@ -0,0 +1,347 @@
1
+ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor, within } from '@testing-library/react';
3
+ import { MemoryRouter, Route, Routes } from 'react-router-dom';
4
+ import type { ReactNode } from 'react';
5
+ import {
6
+ WorkspaceContext,
7
+ type WorkspaceContextValue,
8
+ } from '../../workspace/state/workspace.context';
9
+ import { AdminContext } from '../../admin/state/admin.context';
10
+ import type { LibraryData } from '../hooks/useLibraryData';
11
+ import type { GroupSummary } from '../services/groups.api';
12
+
13
+ /**
14
+ * The Library nav's right-click menu, wired up for real.
15
+ *
16
+ * `GroupsSidebar.contextmenu` proves the nav REPORTS the gesture and
17
+ * `GroupsSidebarMenu` proves the panel behaves; neither can prove the thing
18
+ * that actually matters, which is that the layout hands each kind of row the
19
+ * verbs that are true of it. That decision needs the group summaries and the
20
+ * workspace's KB dir, so it only exists once the whole surface is mounted —
21
+ * hence this file.
22
+ *
23
+ * Same seams as `LibraryRoutes.test.tsx`: the catalog is mocked at its hook and
24
+ * the group index at its API, because what is under test is the menu, not the
25
+ * fetching.
26
+ */
27
+
28
+ const dataMock = vi.hoisted(() => ({ useLibraryData: vi.fn() }));
29
+ vi.mock('../hooks/useLibraryData', () => ({ useLibraryData: dataMock.useLibraryData }));
30
+
31
+ const groupsMock = vi.hoisted(() => ({
32
+ listGroups: vi.fn(),
33
+ listJoinRequests: vi.fn(),
34
+ deleteGroup: vi.fn(),
35
+ }));
36
+ vi.mock('../services/groups.api', () => ({
37
+ listGroups: groupsMock.listGroups,
38
+ listJoinRequests: groupsMock.listJoinRequests,
39
+ deleteGroup: groupsMock.deleteGroup,
40
+ reconcileJoinRequest: vi.fn(),
41
+ requestGroupAccess: vi.fn(),
42
+ AlreadyReadableError: class AlreadyReadableError extends Error {},
43
+ }));
44
+
45
+ // `Manage access` opens a dialog that fetches the verdict. Stub it so the sheet
46
+ // can actually mount without waiting on a refused connection.
47
+ vi.mock('../../access/api', async (importOriginal) => {
48
+ const actual = await importOriginal<typeof import('../../access/api')>();
49
+ return {
50
+ ...actual,
51
+ fetchFileAccess: vi.fn().mockResolvedValue({
52
+ canRead: true,
53
+ canWrite: true,
54
+ canDownload: false,
55
+ canOwner: false,
56
+ eligible: { roles: [], users: [] },
57
+ readers: { restricted: true, roles: [], users: [] },
58
+ owners: { roles: [], users: [] },
59
+ downloaders: { roles: [], users: [] },
60
+ sources: {},
61
+ }),
62
+ fetchAccessOverrides: vi.fn().mockResolvedValue({ overrides: [], truncated: false }),
63
+ };
64
+ });
65
+
66
+ import { LibraryRoutes } from '../routes/LibraryRoutes';
67
+ import { withAuth, TEST_PERSONAL_GROUP } from './auth-harness';
68
+
69
+ const CATALOG: LibraryData = {
70
+ loading: false,
71
+ error: null,
72
+ skills: [
73
+ { name: 'outreach', description: 'Runs the GTM outreach.', path: 'Groups/GTM/outreach' },
74
+ { name: 'scratch', description: 'A skill in no group.', path: 'Skills/scratch' },
75
+ ],
76
+ tools: [],
77
+ ownedSkills: new Set(['outreach']),
78
+ allowedToolsBySkill: new Map(),
79
+ pendingSkills: [],
80
+ crs: [],
81
+ myCrNumbers: new Set(),
82
+ reload: vi.fn(),
83
+ };
84
+
85
+ const summary = (over: Partial<GroupSummary>): GroupSummary => ({
86
+ name: 'GTM',
87
+ folders: ['Groups/GTM'],
88
+ canRead: true,
89
+ canWrite: true,
90
+ isOwner: false,
91
+ skillCount: 1,
92
+ toolCount: 0,
93
+ owners: { roles: [], users: [] },
94
+ writers: { roles: [], users: [] },
95
+ readers: { restricted: true, roles: [], users: [] },
96
+ hasRequested: false,
97
+ requestNumber: null,
98
+ ...over,
99
+ });
100
+
101
+ const GROUPS: GroupSummary[] = [
102
+ summary({}),
103
+ // Not readable and not writable, and no item of it reaches the catalog — the
104
+ // sidebar's locked half.
105
+ summary({ name: 'Finance', folders: ['Groups/Finance'], canRead: false, canWrite: false }),
106
+ ];
107
+
108
+ function wrap(children: ReactNode) {
109
+ const adminValue = {
110
+ isAdmin: false,
111
+ unreadCount: 0,
112
+ lastSeen: null,
113
+ markSeen: vi.fn(),
114
+ refresh: vi.fn(),
115
+ rolesConfigCorrupted: false,
116
+ rolesConfigErrors: [],
117
+ runRolesRecovery: vi.fn(),
118
+ };
119
+ const workspaceValue = {
120
+ workspaceId: 'target-company-state',
121
+ kbDirName: 'knowledge-base',
122
+ } as unknown as WorkspaceContextValue;
123
+
124
+ return (
125
+ <AdminContext.Provider value={adminValue}>
126
+ <WorkspaceContext.Provider value={workspaceValue}>
127
+ {withAuth(children)}
128
+ </WorkspaceContext.Provider>
129
+ </AdminContext.Provider>
130
+ );
131
+ }
132
+
133
+ function renderLibrary(path = '/skills-and-tools') {
134
+ return render(
135
+ <MemoryRouter initialEntries={[path]}>
136
+ {wrap(
137
+ <Routes>
138
+ <Route path="/skills-and-tools/*" element={<LibraryRoutes />} />
139
+ </Routes>,
140
+ )}
141
+ </MemoryRouter>,
142
+ );
143
+ }
144
+
145
+ const nav = () => screen.getByRole('navigation', { name: 'Library groups' });
146
+ const menuItems = () =>
147
+ within(screen.getByRole('menu'))
148
+ .getAllByRole('menuitem')
149
+ .map((i) => i.textContent);
150
+
151
+ /**
152
+ * A row in the NAV, by name. Scoped rather than global because the Library
153
+ * opens on the all-groups index, whose rows name the same groups the nav does —
154
+ * `GTM` is two buttons on this screen, and only one of them is the nav's.
155
+ */
156
+ const navRow = (name: RegExp | string) => within(nav()).findByRole('button', { name });
157
+
158
+ /** Right-click a row and wait for the menu the layout renders in response. */
159
+ async function openMenuOn(name: RegExp | string) {
160
+ const row = await navRow(name);
161
+ fireEvent.contextMenu(row, { clientX: 60, clientY: 180 });
162
+ await screen.findByRole('menu');
163
+ return row;
164
+ }
165
+
166
+ describe('Library sidebar: right-click, end to end', () => {
167
+ beforeEach(() => {
168
+ dataMock.useLibraryData.mockReturnValue(CATALOG);
169
+ groupsMock.listGroups.mockResolvedValue(GROUPS);
170
+ groupsMock.listJoinRequests.mockResolvedValue([]);
171
+ groupsMock.deleteGroup.mockResolvedValue(undefined);
172
+ });
173
+
174
+ // Only the globals this file stubs — NOT `restoreAllMocks`, which would strip
175
+ // the resolved values off the module mocks above and leave `fetchFileAccess`
176
+ // returning undefined for whichever test happens to run next.
177
+ afterEach(() => vi.unstubAllGlobals());
178
+
179
+ it('gives a group row the full menu, titled after the group', async () => {
180
+ renderLibrary();
181
+ await openMenuOn(/^GTM/);
182
+ expect(screen.getByRole('menu', { name: 'Actions for GTM' })).toBeInTheDocument();
183
+ expect(menuItems()).toEqual(['Add a skill or tool', 'New group', 'Copy link', 'Manage access']);
184
+ });
185
+
186
+ /**
187
+ * A lens is a slice of the catalog, not a folder — there is nothing to add a
188
+ * skill TO and no `access.md` behind it. The same call the group page's
189
+ * `PageActions` makes when it hides `Share` on the personal page.
190
+ */
191
+ it('gives a lens row only the verbs a slice of the catalog can answer', async () => {
192
+ renderLibrary();
193
+ await openMenuOn(/^Owned by me/);
194
+ expect(menuItems()).toEqual(['New group', 'Copy link']);
195
+
196
+ fireEvent.keyDown(document, { key: 'Escape' });
197
+ await waitFor(() => expect(screen.queryByRole('menu')).toBeNull());
198
+
199
+ await openMenuOn(new RegExp(`^${TEST_PERSONAL_GROUP}`));
200
+ expect(menuItems()).toEqual(['New group', 'Copy link']);
201
+ });
202
+
203
+ /**
204
+ * `Manage access` is UNGATED on `canWrite`, exactly as the group page's
205
+ * `Share` is: for a non-writer the dialog renders read-only, which is
206
+ * precisely what "who is this shared with?" should answer — and for an admin
207
+ * locked out of a group it is the self-service way back in.
208
+ */
209
+ it('offers Manage access on a locked group too', async () => {
210
+ renderLibrary();
211
+ await openMenuOn('Finance (locked)');
212
+ expect(screen.getByRole('menu', { name: 'Actions for Finance' })).toBeInTheDocument();
213
+ expect(menuItems()).toContain('Manage access');
214
+ });
215
+
216
+ /**
217
+ * Delete is the OWNER's verb: `isOwner` is the same verdict the backend's
218
+ * DELETE route enforces, so the affordance appears for exactly the people
219
+ * the endpoint will let through. GTM's default summary here says
220
+ * `canWrite: true, isOwner: false` — the full-menu test above is therefore
221
+ * also the proof that a mere MANAGER does not see the item.
222
+ */
223
+ it('offers Delete group to an owner, and drives the confirm → delete round-trip', async () => {
224
+ groupsMock.listGroups.mockResolvedValue([summary({ isOwner: true })]);
225
+ renderLibrary();
226
+ await openMenuOn(/^GTM/);
227
+ expect(menuItems()).toEqual([
228
+ 'Add a skill or tool',
229
+ 'New group',
230
+ 'Copy link',
231
+ 'Manage access',
232
+ 'Delete group',
233
+ ]);
234
+
235
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Delete group' }));
236
+ // The menu hands over to the confirmation — nothing is deleted yet.
237
+ const dialog = await screen.findByRole('dialog');
238
+ expect(screen.queryByRole('menu')).toBeNull();
239
+ expect(groupsMock.deleteGroup).not.toHaveBeenCalled();
240
+
241
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Delete group' }));
242
+ await waitFor(() => expect(groupsMock.deleteGroup).toHaveBeenCalledWith('GTM'));
243
+ // The layout says so — same voice as every other completed verb here.
244
+ expect(await screen.findByText('Deleted GTM.')).toBeInTheDocument();
245
+ });
246
+
247
+ it('gives the empty nav space the one verb that belongs to the nav itself', async () => {
248
+ renderLibrary();
249
+ await navRow(/^GTM/);
250
+ fireEvent.contextMenu(nav(), { clientX: 40, clientY: 400 });
251
+ await screen.findByRole('menu');
252
+ expect(menuItems()).toEqual(['New group']);
253
+ });
254
+
255
+ it('opens the new-group dialog from the menu', async () => {
256
+ renderLibrary();
257
+ await openMenuOn(/^GTM/);
258
+ fireEvent.click(screen.getByRole('menuitem', { name: 'New group' }));
259
+ expect(await screen.findByRole('dialog')).toBeInTheDocument();
260
+ expect(screen.queryByRole('menu')).toBeNull();
261
+ });
262
+
263
+ it('opens the add dialog for the group that was clicked, not the page you are on', async () => {
264
+ renderLibrary('/skills-and-tools/owned');
265
+ await openMenuOn(/^GTM/);
266
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Add a skill or tool' }));
267
+ // The dialog titles itself with its group — proof the layout captured the
268
+ // ROW's group, and not the route it happened to be sitting on.
269
+ const dialog = await screen.findByRole('dialog');
270
+ expect(within(dialog).getByText('Add a skill or tool to GTM')).toBeInTheDocument();
271
+ });
272
+
273
+ it('opens Manage access on the group folder, under the KB dir', async () => {
274
+ const access = await import('../../access/api');
275
+ renderLibrary();
276
+ await openMenuOn(/^GTM/);
277
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Manage access' }));
278
+
279
+ await waitFor(() => expect(access.fetchFileAccess).toHaveBeenCalled());
280
+ /**
281
+ * The whole round trip, in one assertion. The layout hands the dialog a
282
+ * WORKSPACE path (`<kbDirName>/<folder>`), the dialog strips that prefix
283
+ * back off, and what reaches the resolver is the REPO-relative folder —
284
+ * which is the only address `access.md` is written at. Get either half
285
+ * wrong and this is `undefined/Groups/GTM` or `knowledge-base/Groups/GTM`,
286
+ * and the dialog silently resolves a folder that does not exist. It is the
287
+ * same handoff `GroupPage` makes, which is why it has to match exactly.
288
+ */
289
+ expect(vi.mocked(access.fetchFileAccess).mock.calls[0][1]).toBe('Groups/GTM');
290
+ });
291
+
292
+ it("copies the clicked row's own URL, not the one you are standing on", async () => {
293
+ const writeText = vi.fn().mockResolvedValue(undefined);
294
+ vi.stubGlobal('navigator', { ...navigator, clipboard: { writeText } });
295
+
296
+ renderLibrary('/skills-and-tools/owned');
297
+ await openMenuOn(/^GTM/);
298
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Copy link' }));
299
+
300
+ await waitFor(() =>
301
+ expect(writeText).toHaveBeenCalledWith(
302
+ `${window.location.origin}/skills-and-tools/groups/GTM`,
303
+ ),
304
+ );
305
+ expect(await screen.findByText('Link copied.')).toBeInTheDocument();
306
+ vi.unstubAllGlobals();
307
+ });
308
+
309
+ it('says so when the clipboard refuses, instead of a silent no-op', async () => {
310
+ vi.stubGlobal('navigator', {
311
+ ...navigator,
312
+ clipboard: { writeText: vi.fn().mockRejectedValue(new Error('not allowed')) },
313
+ });
314
+
315
+ renderLibrary();
316
+ await openMenuOn(/^GTM/);
317
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Copy link' }));
318
+
319
+ // The pill itself, not `getByRole('status')` — the tree carries a second
320
+ // live region (the route announcer), so the role alone is ambiguous.
321
+ const pill = await screen.findByText("Couldn't copy: open the row and copy its address.");
322
+ expect(pill).toBeInTheDocument();
323
+ // And it has to LOOK like a failure. A refusal rendered on the same ink
324
+ // plate as a confirmation is the silent no-op this test exists to prevent,
325
+ // one step removed — the user reads "copied" from the colour and stops.
326
+ expect(pill).toHaveClass('bg-danger');
327
+ vi.unstubAllGlobals();
328
+ });
329
+
330
+ it('closes on an outside click, and a left click still navigates', async () => {
331
+ renderLibrary();
332
+ await openMenuOn(/^GTM/);
333
+ fireEvent.mouseDown(document.body);
334
+ await waitFor(() => expect(screen.queryByRole('menu')).toBeNull());
335
+
336
+ fireEvent.click(await navRow(/^GTM/));
337
+ expect(await screen.findByRole('heading', { name: 'GTM', level: 1 })).toBeInTheDocument();
338
+ });
339
+
340
+ it('hands focus back to the row on Escape', async () => {
341
+ renderLibrary();
342
+ const row = await openMenuOn(/^GTM/);
343
+ fireEvent.keyDown(document, { key: 'Escape' });
344
+ await waitFor(() => expect(screen.queryByRole('menu')).toBeNull());
345
+ expect(document.activeElement).toBe(row);
346
+ });
347
+ });
@@ -0,0 +1,203 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import { MemoryRouter } from 'react-router-dom';
4
+ import type { GroupSummary } from '../services/groups.api';
5
+
6
+ /**
7
+ * The locked group page: what it is allowed to say, and what asking to join
8
+ * does.
9
+ *
10
+ * Copy is asserted verbatim throughout because it IS the feature — a locked
11
+ * group's whole surface is four sentences, and every one of them was chosen to
12
+ * describe the group without describing its contents.
13
+ */
14
+
15
+ const apiMock = vi.hoisted(() => ({
16
+ requestGroupAccess: vi.fn(),
17
+ AlreadyReadableError: class AlreadyReadableError extends Error {},
18
+ }));
19
+ vi.mock('../services/groups.api', () => ({
20
+ requestGroupAccess: apiMock.requestGroupAccess,
21
+ AlreadyReadableError: apiMock.AlreadyReadableError,
22
+ }));
23
+
24
+ import { LibraryToastProvider } from '../state/toast';
25
+ import { LockedGroupView } from '../components/LockedGroupView';
26
+ import { joinNames, firstNames } from '../utils/names';
27
+
28
+ const finance = (over: Partial<GroupSummary> = {}): GroupSummary => ({
29
+ name: 'Finance',
30
+ folders: ['Groups/Finance'],
31
+ canRead: false,
32
+ canWrite: false,
33
+ isOwner: false,
34
+ skillCount: 2,
35
+ toolCount: 1,
36
+ owners: { roles: [], users: [{ name: 'Olga Ivanova', email: 'olga@bevel.software' }] },
37
+ writers: { roles: [], users: [] },
38
+ readers: { restricted: true, roles: [], users: [] },
39
+ hasRequested: false,
40
+ requestNumber: null,
41
+ ...over,
42
+ });
43
+
44
+ function renderLocked(group: GroupSummary = finance()) {
45
+ const onRequested = vi.fn();
46
+ const onUnlocked = vi.fn();
47
+ const onManage = vi.fn();
48
+ const view = render(
49
+ <MemoryRouter>
50
+ <LibraryToastProvider>
51
+ <LockedGroupView
52
+ group={group}
53
+ onRequested={onRequested}
54
+ onUnlocked={onUnlocked}
55
+ onManage={onManage}
56
+ />
57
+ </LibraryToastProvider>
58
+ </MemoryRouter>,
59
+ );
60
+ return { ...view, onRequested, onUnlocked, onManage };
61
+ }
62
+
63
+ const askButton = () => screen.getByRole('button', { name: 'Subscribe to its skills and tools' });
64
+
65
+ describe('LockedGroupView', () => {
66
+ beforeEach(() => {
67
+ apiMock.requestGroupAccess.mockReset();
68
+ apiMock.requestGroupAccess.mockResolvedValue(undefined);
69
+ });
70
+
71
+ it('states the group, who runs it, and how much is in it. And nothing else', () => {
72
+ renderLocked();
73
+ expect(screen.getByRole('heading', { name: 'Finance', level: 1 })).toBeInTheDocument();
74
+ expect(screen.getByText('Locked')).toBeInTheDocument();
75
+ expect(screen.getByText('Run by Olga Ivanova.')).toBeInTheDocument();
76
+ expect(screen.getByText('2 skills · 1 tool. Visible to members only.')).toBeInTheDocument();
77
+ expect(screen.getByRole('link', { name: 'All groups' })).toHaveAttribute(
78
+ 'href',
79
+ '/skills-and-tools',
80
+ );
81
+ });
82
+
83
+ it('never leaks an address, even when the summary carries one', () => {
84
+ // The backend nulls emails for non-readers; this asserts the view would not
85
+ // print one if a future wire change ever handed it one anyway.
86
+ const { container } = renderLocked(
87
+ finance({ owners: { roles: [], users: [{ name: 'Olga Ivanova', email: 'olga@bevel.software' }] } }),
88
+ );
89
+ expect(container.textContent).not.toContain('@');
90
+ });
91
+
92
+ it('pluralises the counts line honestly', () => {
93
+ renderLocked(finance({ skillCount: 1, toolCount: 0 }));
94
+ expect(screen.getByText('1 skill · 0 tools. Visible to members only.')).toBeInTheDocument();
95
+ });
96
+
97
+ it('asks once, disables while in flight, and flips to the Requested box', async () => {
98
+ let release = () => {};
99
+ apiMock.requestGroupAccess.mockReturnValue(
100
+ new Promise<void>((resolve) => {
101
+ release = () => resolve();
102
+ }),
103
+ );
104
+ const { onRequested } = renderLocked();
105
+
106
+ fireEvent.click(askButton());
107
+ expect(askButton()).toBeDisabled();
108
+ fireEvent.click(askButton());
109
+ expect(apiMock.requestGroupAccess).toHaveBeenCalledTimes(1);
110
+ expect(apiMock.requestGroupAccess).toHaveBeenCalledWith('Finance');
111
+
112
+ release();
113
+ expect(
114
+ await screen.findByText('Requested: Olga Ivanova decides who joins.'),
115
+ ).toBeInTheDocument();
116
+ expect(
117
+ screen.queryByRole('button', { name: 'Subscribe to its skills and tools' }),
118
+ ).not.toBeInTheDocument();
119
+ expect(onRequested).toHaveBeenCalledTimes(1);
120
+ });
121
+
122
+ it('confirms with the first names of the people who now have to decide', async () => {
123
+ renderLocked();
124
+ fireEvent.click(askButton());
125
+ expect(
126
+ await screen.findByText('Asked Olga. You get its skills and tools if they let you in.'),
127
+ ).toBeInTheDocument();
128
+ });
129
+
130
+ it('shows the Requested box with no button when the server already has one', () => {
131
+ renderLocked(finance({ hasRequested: true }));
132
+ expect(screen.getByText('Requested: Olga Ivanova decides who joins.')).toBeInTheDocument();
133
+ expect(
134
+ screen.queryByRole('button', { name: 'Subscribe to its skills and tools' }),
135
+ ).not.toBeInTheDocument();
136
+ });
137
+
138
+ it('falls back to the admins, in the plural, when nobody is named', async () => {
139
+ renderLocked(finance({ owners: { roles: [], users: [] }, writers: { roles: [], users: [] } }));
140
+ expect(screen.getByText('Run by the workspace admins.')).toBeInTheDocument();
141
+ fireEvent.click(askButton());
142
+ expect(
143
+ await screen.findByText(
144
+ 'Asked the admins. You get its skills and tools if they let you in.',
145
+ ),
146
+ ).toBeInTheDocument();
147
+ expect(
148
+ screen.getByText('Requested: the workspace admins decide who joins.'),
149
+ ).toBeInTheDocument();
150
+ });
151
+
152
+ it('falls back through writers when the folder names no owner', () => {
153
+ renderLocked(
154
+ finance({
155
+ owners: { roles: [], users: [] },
156
+ writers: { roles: ['Admin'], users: [{ name: 'Juan Viera', email: 'juan@bevel.software' }] },
157
+ }),
158
+ );
159
+ expect(screen.getByText('Run by Juan Viera, Admin.')).toBeInTheDocument();
160
+ });
161
+
162
+ it('opens the group rather than complaining when access already landed', async () => {
163
+ apiMock.requestGroupAccess.mockRejectedValue(new apiMock.AlreadyReadableError());
164
+ const { onUnlocked, onRequested } = renderLocked();
165
+ fireEvent.click(askButton());
166
+ await waitFor(() => expect(onUnlocked).toHaveBeenCalledTimes(1));
167
+ expect(onRequested).not.toHaveBeenCalled();
168
+ expect(screen.queryByText(/^Requested/)).not.toBeInTheDocument();
169
+ });
170
+
171
+ it('re-enables the button and says so when the request fails', async () => {
172
+ apiMock.requestGroupAccess.mockRejectedValue(new Error('boom'));
173
+ const { onRequested } = renderLocked();
174
+ fireEvent.click(askButton());
175
+ expect(await screen.findByText("Couldn't send that: try again.")).toBeInTheDocument();
176
+ expect(askButton()).not.toBeDisabled();
177
+ expect(onRequested).not.toHaveBeenCalled();
178
+ });
179
+
180
+ it('gives a locked-out admin the self-service way in', () => {
181
+ const { onManage } = renderLocked(finance({ canWrite: true, folders: ['Groups/Finance'] }));
182
+ fireEvent.click(screen.getByRole('button', { name: 'Manage access' }));
183
+ expect(onManage).toHaveBeenCalledWith('Groups/Finance');
184
+ });
185
+
186
+ it('offers no Manage access to somebody who cannot write the folder', () => {
187
+ renderLocked();
188
+ expect(screen.queryByRole('button', { name: 'Manage access' })).not.toBeInTheDocument();
189
+ });
190
+ });
191
+
192
+ describe('name helpers', () => {
193
+ it('joins names the way a person says them out loud', () => {
194
+ expect(joinNames([])).toBe('');
195
+ expect(joinNames(['Olga'])).toBe('Olga');
196
+ expect(joinNames(['Olga', 'Juan'])).toBe('Olga and Juan');
197
+ expect(joinNames(['Olga', 'Juan', 'Ali'])).toBe('Olga, Juan and Ali');
198
+ });
199
+
200
+ it('takes the first token of each name', () => {
201
+ expect(firstNames(['Olga Ivanova', 'Juan Viera', 'GTM Team'])).toEqual(['Olga', 'Juan', 'GTM']);
202
+ });
203
+ });
@@ -0,0 +1,114 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
4
+
5
+ /**
6
+ * Making a group.
7
+ *
8
+ * A group comes from the dedicated provisioning endpoint — the server owns
9
+ * the folder, the seeded access.md and the commit. What is worth testing here
10
+ * is the two refusals the dialog can reach before the call — a name that
11
+ * collides with a group you cannot even see, and a name that would create a
12
+ * nested folder — plus the fact that the caller lands somewhere real
13
+ * afterwards, and that the server's own refusal is what the toast shows.
14
+ */
15
+
16
+ const groupsMock = vi.hoisted(() => ({ createGroup: vi.fn() }));
17
+ vi.mock('../services/groups.api', () => ({
18
+ createGroup: groupsMock.createGroup,
19
+ }));
20
+
21
+ import { NewGroupDialog } from '../components/NewGroupDialog';
22
+ import { LibraryToastProvider } from '../state/toast';
23
+
24
+ function LocationProbe() {
25
+ const location = useLocation();
26
+ return <div aria-label="pathname">{location.pathname}</div>;
27
+ }
28
+
29
+ function renderDialog(existing: string[] = ['GTM', 'Finance']) {
30
+ const onCreated = vi.fn();
31
+ const onClose = vi.fn();
32
+ render(
33
+ <MemoryRouter initialEntries={['/skills-and-tools']}>
34
+ <LibraryToastProvider>
35
+ <Routes>
36
+ <Route
37
+ path="*"
38
+ element={
39
+ <NewGroupDialog existing={existing} onClose={onClose} onCreated={onCreated} />
40
+ }
41
+ />
42
+ </Routes>
43
+ <LocationProbe />
44
+ </LibraryToastProvider>
45
+ </MemoryRouter>,
46
+ );
47
+ return {
48
+ onCreated,
49
+ onClose,
50
+ field: () => screen.getByRole('textbox', { name: 'Group name' }),
51
+ submit: () => screen.getByRole('button', { name: /Create group|Creating/ }),
52
+ pathname: () => screen.getByLabelText('pathname').textContent,
53
+ };
54
+ }
55
+
56
+ describe('NewGroupDialog', () => {
57
+ beforeEach(() => {
58
+ groupsMock.createGroup.mockReset();
59
+ // A folder name that DIFFERS from the input, so a dialog that navigates
60
+ // with the typed name instead of the server's answer fails here.
61
+ groupsMock.createGroup.mockImplementation(async (name: string) => ({
62
+ folder: `${name}-canonical`,
63
+ }));
64
+ });
65
+
66
+ it('will not create an unnamed group', () => {
67
+ const { submit } = renderDialog();
68
+ expect(submit()).toBeDisabled();
69
+ });
70
+
71
+ it('creates the folder under Groups/ and opens the new group', async () => {
72
+ const { field, submit, onCreated, pathname } = renderDialog();
73
+ fireEvent.change(field(), { target: { value: ' Design ' } });
74
+ fireEvent.click(submit());
75
+
76
+ // Trimmed — the endpoint owns everything after the name.
77
+ await waitFor(() => expect(groupsMock.createGroup).toHaveBeenCalledWith('Design'));
78
+ // The route is built from the SERVER's folder, not the typed name.
79
+ await waitFor(() => expect(pathname()).toBe('/skills-and-tools/groups/Design-canonical'));
80
+ expect(onCreated).toHaveBeenCalledTimes(1);
81
+ });
82
+
83
+ it('refuses a name that is already taken, whoever can see it', () => {
84
+ // `existing` carries LOCKED groups too. Creating `Groups/Finance` when a
85
+ // Finance you cannot read exists would not make a group — it would put
86
+ // your items in somebody else's.
87
+ const { field, submit } = renderDialog(['GTM', 'Finance']);
88
+ fireEvent.change(field(), { target: { value: 'finance' } });
89
+ expect(screen.getByRole('alert')).toHaveTextContent('already exists');
90
+ expect(submit()).toBeDisabled();
91
+ });
92
+
93
+ it('refuses a name that would create a nested folder', () => {
94
+ // `Groups/A/B` would be read back by `groupOfPath` as the group "A".
95
+ const { field, submit } = renderDialog();
96
+ fireEvent.change(field(), { target: { value: 'GTM/EMEA' } });
97
+ expect(screen.getByRole('alert')).toHaveTextContent('/');
98
+ expect(submit()).toBeDisabled();
99
+ });
100
+
101
+ it("shows the server's own refusal and stays open", async () => {
102
+ // The server's check runs against the live tree (ours against a stale
103
+ // catalog), so ITS words are the ones worth showing.
104
+ groupsMock.createGroup.mockRejectedValue(
105
+ new Error('Group names starting with "personal-" are reserved.'),
106
+ );
107
+ const { field, submit, onClose } = renderDialog();
108
+ fireEvent.change(field(), { target: { value: 'personal-notes' } });
109
+ fireEvent.click(submit());
110
+
111
+ expect(await screen.findByText(/reserved/)).toBeInTheDocument();
112
+ expect(onClose).not.toHaveBeenCalled();
113
+ });
114
+ });