@bevel-software/platform-core-frontend 0.15.1 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +16 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  33. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  34. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  35. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  36. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  37. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  38. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  39. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  40. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  41. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  42. package/src/modules/admin/components/group-members-path.ts +32 -0
  43. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  44. package/src/modules/admin/services/roles.api.ts +12 -1
  45. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  46. package/src/modules/auth/components/AccountPage.tsx +73 -54
  47. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  48. package/src/modules/auth/services/account.api.ts +78 -4
  49. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  57. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  58. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  59. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  60. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  61. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  62. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  63. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  64. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  65. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  66. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  67. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  68. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  69. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  70. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  71. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  72. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  73. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  74. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  75. package/src/modules/change-requests/services/propose.api.ts +97 -8
  76. package/src/modules/change-requests/utils/approval.ts +15 -0
  77. package/src/modules/change-requests/utils/author.ts +32 -0
  78. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  79. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  80. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  81. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  82. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  83. package/src/modules/git/services/error-messages.ts +12 -0
  84. package/src/modules/git/services/pr-prompts.ts +5 -5
  85. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  86. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  87. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  88. package/src/modules/layout/components/AppLayout.tsx +2 -0
  89. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  90. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  91. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  92. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  93. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  94. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  95. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  96. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  97. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  98. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  99. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  100. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  101. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  102. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  103. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  104. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  105. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  106. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  107. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  108. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  109. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  110. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  111. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  112. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  113. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  114. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  115. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  116. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  117. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  118. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  119. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  120. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  121. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  122. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  123. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  124. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  125. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  126. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  127. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  128. package/src/modules/library/__tests__/status.test.ts +82 -2
  129. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  130. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  131. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  132. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  133. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  134. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  135. package/src/modules/library/components/LibraryCard.tsx +146 -45
  136. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  137. package/src/modules/library/components/LibraryPage.tsx +172 -39
  138. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  139. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  140. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  141. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  142. package/src/modules/library/components/PageActions.tsx +11 -9
  143. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  144. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  145. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  146. package/src/modules/library/components/PluginExtras.tsx +140 -17
  147. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  148. package/src/modules/library/components/PluginPage.tsx +157 -41
  149. package/src/modules/library/components/PluginRows.tsx +286 -0
  150. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  151. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  152. package/src/modules/library/components/ShareButton.tsx +17 -0
  153. package/src/modules/library/components/SkillsTree.tsx +141 -28
  154. package/src/modules/library/components/TeamRoute.tsx +15 -0
  155. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  156. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  157. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  158. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  159. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  160. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  161. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  162. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  163. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  164. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  165. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  166. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  167. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  168. package/src/modules/library/routes/library-paths.ts +26 -28
  169. package/src/modules/library/services/library.api.ts +38 -20
  170. package/src/modules/library/services/plugins.api.ts +69 -8
  171. package/src/modules/library/services/teams.api.ts +15 -0
  172. package/src/modules/library/services/tools.api.ts +78 -0
  173. package/src/modules/library/state/library-data.tsx +170 -32
  174. package/src/modules/library/utils/personal-plugin.ts +13 -15
  175. package/src/modules/library/utils/plugin-entries.ts +134 -0
  176. package/src/modules/library/utils/plugin-summary.ts +75 -9
  177. package/src/modules/library/utils/status.ts +135 -33
  178. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  179. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  180. package/src/modules/onboarding/agent-clients.ts +55 -23
  181. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  182. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  183. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  184. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  185. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  186. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  187. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  188. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  189. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  190. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  191. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  192. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  193. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  194. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  195. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  196. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  197. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  198. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  199. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  200. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  201. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  202. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  203. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  204. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  205. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  206. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  207. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  208. package/src/modules/settings/services/github-facade.api.ts +23 -0
  209. package/src/modules/settings/settings-nav-items.tsx +10 -2
  210. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  211. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  212. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  213. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  214. package/src/modules/setup/components/SetupGate.tsx +16 -16
  215. package/src/modules/setup/components/SetupScreen.tsx +521 -43
  216. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  217. package/src/modules/setup/services/setup.api.ts +140 -3
  218. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  219. package/src/modules/setup/utils/root-folders.ts +46 -0
  220. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  221. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  232. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  233. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  234. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  235. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  236. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  237. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  238. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  239. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  240. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  241. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  242. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  243. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  244. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  245. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  246. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  247. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  248. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  249. package/src/modules/toolbar/services/external-api-keys.api.ts +6 -0
  250. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  251. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  252. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  254. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  255. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  256. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  257. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  258. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  259. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  260. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  261. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  262. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  263. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  264. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +331 -12
  265. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  266. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  267. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  268. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  269. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  270. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  271. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  272. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  273. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  274. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  275. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  276. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  277. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  279. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  280. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  281. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  282. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  283. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  284. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  285. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  286. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  287. package/src/modules/workspace/components/renderers/index.ts +53 -2
  288. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  289. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  290. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  291. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  292. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  294. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  295. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  296. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  297. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  298. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  299. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  300. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  301. package/src/modules/workspace/services/workspace.api.ts +57 -4
  302. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  303. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  304. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  305. package/src/modules/workspace/state/workspace.context.ts +125 -19
  306. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  307. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  308. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  309. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  310. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  311. package/src/modules/workspace/utils/file-trace.ts +50 -0
  312. package/src/modules/workspace/utils/fileTree.ts +112 -36
  313. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  314. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  315. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  316. package/src/modules/workspace/utils/uploadError.ts +29 -0
  317. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  318. package/src/shared/components/Button.tsx +16 -2
  319. package/src/shared/components/Dialog.tsx +27 -11
  320. package/src/shared/components/Menu.tsx +13 -1
  321. package/src/shared/components/PageShell.tsx +13 -8
  322. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  323. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  324. package/src/shared/components/index.ts +2 -0
  325. package/src/shared/components/useDismissableMenu.ts +32 -10
  326. package/src/shared/components/useFocusHandoff.ts +51 -0
  327. package/src/shared/components/useLatestRef.ts +28 -0
  328. package/src/shared/markdown/Markdown.tsx +12 -3
  329. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  330. package/src/shared/markdown/hrefs.ts +50 -0
  331. package/src/shared/marketplace-url.ts +33 -5
  332. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  333. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  334. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  335. package/src/shared/mcp/connect-snippets.ts +14 -9
  336. package/src/shared/mcp/index.ts +1 -1
  337. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  338. package/src/shared/theme/header.ts +75 -0
  339. package/src/shared/theme/measure.ts +7 -4
  340. package/src/shared/theme/tokens.css +25 -0
  341. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  342. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  343. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  344. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  345. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  346. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,7 +1,8 @@
1
1
  import { useEffect, useState } from 'react';
2
2
  import { Presentation } from 'lucide-react';
3
- import { useWorkspace } from '../../state/workspace.context';
3
+ import { useRendererWorkspaceId } from './rendererWorkspace';
4
4
  import { authFetch } from '../../../../lib/api';
5
+ import { rawFileUrl } from '../../services/workspace.api';
5
6
  import { DownloadFileButton } from './DownloadFileButton';
6
7
  import { extractPptxOutline, type PptxSlide } from './pptxOutline';
7
8
  import { readBodyCapped } from './readBodyCapped';
@@ -47,7 +48,7 @@ const MAX_ARCHIVE_BYTES = 200 * 1024 * 1024;
47
48
  const MAX_LINES_PER_SLIDE = 500;
48
49
 
49
50
  export function PptxRenderer({ filePath }: FileRendererProps) {
50
- const { workspaceId } = useWorkspace();
51
+ const workspaceId = useRendererWorkspaceId();
51
52
  const [slides, setSlides] = useState<PptxSlide[] | null>(null);
52
53
  const [error, setError] = useState<string | null>(null);
53
54
 
@@ -64,7 +65,7 @@ export function PptxRenderer({ filePath }: FileRendererProps) {
64
65
  (async () => {
65
66
  try {
66
67
  const res = await authFetch(
67
- `/api/workspace/${workspaceId}/file/raw?path=${encodeURIComponent(filePath)}`,
68
+ rawFileUrl(workspaceId, filePath),
68
69
  { signal: abort.signal },
69
70
  );
70
71
  if (cancelled) return;
@@ -1,7 +1,8 @@
1
1
  import { useEffect, useMemo, useState } from 'react';
2
2
  import * as XLSX from 'xlsx';
3
- import { useWorkspace } from '../../state/workspace.context';
3
+ import { useRendererWorkspaceId } from './rendererWorkspace';
4
4
  import { authFetch } from '../../../../lib/api';
5
+ import { rawFileUrl } from '../../services/workspace.api';
5
6
  import { DownloadFileButton } from './DownloadFileButton';
6
7
  import { readBodyCapped } from './readBodyCapped';
7
8
  import type { FileRendererProps } from './types';
@@ -95,7 +96,7 @@ interface SheetView {
95
96
  * as raw serial numbers / decimals.
96
97
  */
97
98
  export function XlsxRenderer({ filePath }: FileRendererProps) {
98
- const { workspaceId } = useWorkspace();
99
+ const workspaceId = useRendererWorkspaceId();
99
100
  const [workbook, setWorkbook] = useState<XLSX.WorkBook | null>(null);
100
101
  const [activeSheet, setActiveSheet] = useState(0);
101
102
  const [error, setError] = useState<string | null>(null);
@@ -113,7 +114,7 @@ export function XlsxRenderer({ filePath }: FileRendererProps) {
113
114
  (async () => {
114
115
  try {
115
116
  const res = await authFetch(
116
- `/api/workspace/${workspaceId}/file/raw?path=${encodeURIComponent(filePath)}`,
117
+ rawFileUrl(workspaceId, filePath),
117
118
  { signal: controller.signal },
118
119
  );
119
120
  if (cancelled) return;
@@ -64,3 +64,15 @@ describe('DocxRenderer', () => {
64
64
  expect(container.querySelector('a')!.getAttribute('href')).toBe('https://example.com');
65
65
  });
66
66
  });
67
+
68
+ /** The URL the viewer asks for is the raw file route, built by `rawFileUrl`. */
69
+ describe('DocxRenderer fetch', () => {
70
+ it('asks the raw file route for exactly this file', async () => {
71
+ mammothMock.convertToHtml.mockResolvedValue({ value: '<p>body</p>' });
72
+ renderDocx();
73
+ await waitFor(() => expect(apiMock.authFetch).toHaveBeenCalled());
74
+ expect(apiMock.authFetch.mock.calls[0][0]).toBe(
75
+ '/api/workspace/ws-1/file/raw?path=Inbox%2Freport.docx',
76
+ );
77
+ });
78
+ });
@@ -1,15 +1,33 @@
1
+ import type { ReactNode } from 'react';
1
2
  import { describe, it, expect, vi } from 'vitest';
2
- import { render, screen } from '@testing-library/react';
3
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
4
 
4
5
  const apiMock = vi.hoisted(() => ({ authFetch: vi.fn() }));
5
6
  vi.mock('../../../../../lib/api', () => ({ authFetch: apiMock.authFetch }));
6
- vi.mock('../../../state/workspace.context', async (importOriginal) => ({
7
- ...(await importOriginal<object>()),
8
- useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
9
- }));
10
-
7
+ import {
8
+ WorkspaceContext,
9
+ type WorkspaceContextValue,
10
+ } from '../../../state/workspace.context';
11
11
  import { CanDownloadContext, DownloadFileButton } from '../DownloadFileButton';
12
12
 
13
+ /**
14
+ * The button reads its workspace through `useRendererWorkspaceId`, so the
15
+ * checked-out workspace is PROVIDED here rather than the hook mocked away —
16
+ * the change-request dialog overrides that same lookup to point the viewers
17
+ * at a request's branch, and a mocked hook would hide whether it still works.
18
+ */
19
+ function withWorkspace(node: ReactNode) {
20
+ return (
21
+ <WorkspaceContext.Provider
22
+ value={
23
+ { workspaceId: 'ws-1', kbDirName: 'knowledge-base' } as unknown as WorkspaceContextValue
24
+ }
25
+ >
26
+ {node}
27
+ </WorkspaceContext.Provider>
28
+ );
29
+ }
30
+
13
31
  /**
14
32
  * The button reflects the per-path `download:` verb the backend resolves —
15
33
  * FileViewer provides the verdict through CanDownloadContext. The backend's
@@ -19,9 +37,11 @@ import { CanDownloadContext, DownloadFileButton } from '../DownloadFileButton';
19
37
  describe('DownloadFileButton — download permission', () => {
20
38
  const renderWith = (canDownload: boolean | null) =>
21
39
  render(
22
- <CanDownloadContext.Provider value={canDownload}>
23
- <DownloadFileButton filePath="knowledge-base/Plugins/GTM/deck.pptx" />
24
- </CanDownloadContext.Provider>,
40
+ withWorkspace(
41
+ <CanDownloadContext.Provider value={canDownload}>
42
+ <DownloadFileButton filePath="knowledge-base/Plugins/GTM/deck.pptx" />
43
+ </CanDownloadContext.Provider>,
44
+ ),
25
45
  );
26
46
 
27
47
  it('is disabled with an explanation when the download verb says no', () => {
@@ -46,3 +66,31 @@ describe('DownloadFileButton — download permission', () => {
46
66
  expect(screen.getByRole('button', { name: 'Download' })).toBeEnabled();
47
67
  });
48
68
  });
69
+
70
+ /** The URL the button fetches is the raw file route's download form, built by `rawFileUrl`. */
71
+ describe('DownloadFileButton — the URL it fetches', () => {
72
+ it('asks the raw file route for this file as a download', async () => {
73
+ apiMock.authFetch.mockResolvedValue({
74
+ ok: true,
75
+ status: 200,
76
+ blob: async () => new Blob(['bytes']),
77
+ text: async () => '',
78
+ });
79
+ (globalThis.URL as unknown as { createObjectURL: unknown }).createObjectURL = vi.fn(
80
+ () => 'blob:fake-url',
81
+ );
82
+ (globalThis.URL as unknown as { revokeObjectURL: unknown }).revokeObjectURL = vi.fn();
83
+ render(
84
+ withWorkspace(
85
+ <CanDownloadContext.Provider value={true}>
86
+ <DownloadFileButton filePath="knowledge-base/Plugins/GTM/deck.pptx" />
87
+ </CanDownloadContext.Provider>,
88
+ ),
89
+ );
90
+ fireEvent.click(screen.getByRole('button', { name: 'Download' }));
91
+ await waitFor(() => expect(apiMock.authFetch).toHaveBeenCalled());
92
+ expect(apiMock.authFetch.mock.calls[0][0]).toBe(
93
+ '/api/workspace/ws-1/file/raw?path=knowledge-base%2FPlugins%2FGTM%2Fdeck.pptx&download=1',
94
+ );
95
+ });
96
+ });
@@ -1,5 +1,5 @@
1
1
  import { describe, it, expect, vi, beforeEach } from 'vitest';
2
- import { render, screen } from '@testing-library/react';
2
+ import { render, screen, waitFor } from '@testing-library/react';
3
3
  import * as XLSX from 'xlsx';
4
4
  import {
5
5
  WorkspaceContext,
@@ -174,3 +174,15 @@ describe('EmailRenderer', () => {
174
174
  expect(signal?.aborted).toBe(true);
175
175
  });
176
176
  });
177
+
178
+ /** The URL the viewer asks for is the raw file route, built by `rawFileUrl`. */
179
+ describe('EmailRenderer fetch', () => {
180
+ it('asks the raw file route for exactly this file', async () => {
181
+ apiMock.authFetch.mockResolvedValue({ ok: true, arrayBuffer: async () => EML_BYTES });
182
+ renderEmail('Inbox/numbers.eml');
183
+ await waitFor(() => expect(apiMock.authFetch).toHaveBeenCalled());
184
+ expect(apiMock.authFetch.mock.calls[0][0]).toBe(
185
+ '/api/workspace/ws-1/file/raw?path=Inbox%2Fnumbers.eml',
186
+ );
187
+ });
188
+ });
@@ -0,0 +1,163 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { act, fireEvent, render, screen, waitFor } from '@testing-library/react';
3
+ import type { WorkflowEvent } from '@bevel-software/platform-shared';
4
+ import {
5
+ WorkspaceContext,
6
+ type WorkspaceContextValue,
7
+ } from '../../../state/workspace.context';
8
+ import {
9
+ EventBusContext,
10
+ type EventBusContextValue,
11
+ } from '../../../../workflow/state/event-bus.context';
12
+
13
+ const apiMock = vi.hoisted(() => ({ authFetch: vi.fn() }));
14
+ vi.mock('../../../../../lib/api', () => ({ authFetch: apiMock.authFetch }));
15
+
16
+ import { ImageRenderer } from '../ImageRenderer';
17
+
18
+ beforeEach(() => {
19
+ apiMock.authFetch.mockReset();
20
+ (globalThis.URL as unknown as { createObjectURL: unknown }).createObjectURL = vi.fn(
21
+ () => 'blob:fake-url',
22
+ );
23
+ (globalThis.URL as unknown as { revokeObjectURL: unknown }).revokeObjectURL = vi.fn();
24
+ });
25
+
26
+ /**
27
+ * The whole-file image view (a `.png` opened from the tree) fetches through
28
+ * `authFetch` and paints a blob URL. Pinned so the raw-route URL it asks for
29
+ * cannot drift from the one the backend serves.
30
+ */
31
+ describe('ImageRenderer', () => {
32
+ it('fetches the bytes from the raw file route and paints them as a blob URL', async () => {
33
+ apiMock.authFetch.mockResolvedValue({ ok: true, blob: async () => new Blob(['png']) });
34
+ render(
35
+ <WorkspaceContext.Provider
36
+ value={{ workspaceId: 'ws-1' } as unknown as WorkspaceContextValue}
37
+ >
38
+ <ImageRenderer filePath="Knowledge/assets/shot.png" content="" onSave={async () => {}} />
39
+ </WorkspaceContext.Provider>,
40
+ );
41
+ const img = await screen.findByRole('img');
42
+ expect(img).toHaveAttribute('src', 'blob:fake-url');
43
+ expect(apiMock.authFetch).toHaveBeenCalledTimes(1);
44
+ expect(apiMock.authFetch.mock.calls[0][0]).toBe(
45
+ '/api/workspace/ws-1/file/raw?path=Knowledge%2Fassets%2Fshot.png',
46
+ );
47
+ });
48
+
49
+ /**
50
+ * A rejected read used to return silently, leaving the pane on "Loading
51
+ * image…" for as long as anyone cared to watch — the shape a 403 on a
52
+ * restricted file takes, and a 404 on a path the workspace's branch does not
53
+ * have (the change-request pane reads someone else's branch).
54
+ */
55
+ it('names a failed read instead of spinning on it forever', async () => {
56
+ apiMock.authFetch.mockResolvedValue({ ok: false, status: 403 });
57
+ render(
58
+ <WorkspaceContext.Provider
59
+ value={{ workspaceId: 'ws-1' } as unknown as WorkspaceContextValue}
60
+ >
61
+ <ImageRenderer filePath="Knowledge/assets/shot.png" content="" onSave={async () => {}} />
62
+ </WorkspaceContext.Provider>,
63
+ );
64
+ expect(await screen.findByRole('alert')).toHaveTextContent(
65
+ "Couldn't load this image (HTTP 403).",
66
+ );
67
+ expect(screen.queryByText('Loading image...')).toBeNull();
68
+ });
69
+
70
+ /**
71
+ * A replaced picture reaches an open pane. The markdown pipeline's `<img>`
72
+ * tags already carried the workspace's image revision; the whole-file view
73
+ * was the one image on the page that stayed stale until a reload — including
74
+ * the change-request pane, pointed at a branch its author is still pushing
75
+ * to.
76
+ */
77
+ it('refetches when an image in the workspace changes', async () => {
78
+ const handlers: ((e: WorkflowEvent) => void)[] = [];
79
+ const bus = {
80
+ subscribe: (_kind: string, handler: (e: WorkflowEvent) => void) => {
81
+ handlers.push(handler);
82
+ return () => {};
83
+ },
84
+ setFocus: () => {},
85
+ watchWorkspace: () => () => {},
86
+ } as unknown as EventBusContextValue;
87
+
88
+ apiMock.authFetch.mockResolvedValue({ ok: true, blob: async () => new Blob(['png']) });
89
+ render(
90
+ <EventBusContext.Provider value={bus}>
91
+ <WorkspaceContext.Provider
92
+ value={{ workspaceId: 'ws-1' } as unknown as WorkspaceContextValue}
93
+ >
94
+ <ImageRenderer filePath="Knowledge/assets/shot.png" content="" onSave={async () => {}} />
95
+ </WorkspaceContext.Provider>
96
+ </EventBusContext.Provider>,
97
+ );
98
+ await screen.findByRole('img');
99
+ // No `&v=` yet: the URL stays cacheable until something is known to have
100
+ // changed.
101
+ expect(apiMock.authFetch.mock.calls[0][0]).toBe(
102
+ '/api/workspace/ws-1/file/raw?path=Knowledge%2Fassets%2Fshot.png',
103
+ );
104
+
105
+ act(() =>
106
+ handlers.forEach((h) =>
107
+ h({
108
+ kind: 'file-changed',
109
+ workspaceId: 'ws-1',
110
+ branch: 'ws-1',
111
+ path: 'Knowledge/assets/shot.png',
112
+ } as unknown as WorkflowEvent),
113
+ ),
114
+ );
115
+
116
+ await waitFor(() => expect(apiMock.authFetch).toHaveBeenCalledTimes(2));
117
+ expect(apiMock.authFetch.mock.calls[1][0]).toBe(
118
+ '/api/workspace/ws-1/file/raw?path=Knowledge%2Fassets%2Fshot.png&v=1',
119
+ );
120
+ });
121
+
122
+ /**
123
+ * A failure whose workspace, path and revision are all unchanged has nothing
124
+ * to re-trigger the read, so a dropped connection was TERMINAL until the
125
+ * pane remounted — a reviewer with the dialog open had no way back to the
126
+ * picture. Try again is that way back.
127
+ */
128
+ it('recovers from a transient failure when asked to try again', async () => {
129
+ apiMock.authFetch.mockRejectedValueOnce(new Error('network down'));
130
+ apiMock.authFetch.mockResolvedValue({ ok: true, blob: async () => new Blob(['png']) });
131
+ render(
132
+ <WorkspaceContext.Provider
133
+ value={{ workspaceId: 'ws-1' } as unknown as WorkspaceContextValue}
134
+ >
135
+ <ImageRenderer filePath="Knowledge/assets/shot.png" content="" onSave={async () => {}} />
136
+ </WorkspaceContext.Provider>,
137
+ );
138
+ expect(await screen.findByRole('alert')).toHaveTextContent("Couldn't load this image.");
139
+
140
+ fireEvent.click(screen.getByRole('button', { name: 'Try again' }));
141
+
142
+ // The SAME request, re-run: the picture arrives and the failure is gone.
143
+ expect(await screen.findByRole('img')).toHaveAttribute('src', 'blob:fake-url');
144
+ expect(screen.queryByRole('alert')).toBeNull();
145
+ expect(apiMock.authFetch).toHaveBeenCalledTimes(2);
146
+ expect(apiMock.authFetch.mock.calls[1][0]).toBe(
147
+ '/api/workspace/ws-1/file/raw?path=Knowledge%2Fassets%2Fshot.png',
148
+ );
149
+ });
150
+
151
+ /** A thrown fetch (offline, aborted connection) is a failure too. */
152
+ it('names a read that threw', async () => {
153
+ apiMock.authFetch.mockRejectedValue(new Error('network down'));
154
+ render(
155
+ <WorkspaceContext.Provider
156
+ value={{ workspaceId: 'ws-1' } as unknown as WorkspaceContextValue}
157
+ >
158
+ <ImageRenderer filePath="Knowledge/assets/shot.png" content="" onSave={async () => {}} />
159
+ </WorkspaceContext.Provider>,
160
+ );
161
+ expect(await screen.findByRole('alert')).toHaveTextContent("Couldn't load this image.");
162
+ });
163
+ });
@@ -19,6 +19,26 @@ describe('KbMarkdownView', () => {
19
19
  expect(onOpenFile).toHaveBeenCalledWith('../NodeTypes/Process.md');
20
20
  });
21
21
 
22
+ // The panel never goes through the markdown pipeline, so it applies the
23
+ // pipeline's URL policy itself: what the body would refuse, it refuses.
24
+ it('holds a frontmatter link to the URL policy the body follows', () => {
25
+ const onOpenFile = vi.fn();
26
+ const source = (dest: string) => `---\nnodeType: "[Today](${dest})"\n---\n\nBody.\n`;
27
+ const { rerender } = render(<KbMarkdownView source={source('./Notes: today.md')} onOpenFile={onOpenFile} />);
28
+ fireEvent.click(screen.getByRole('link', { name: 'Today' }));
29
+ expect(onOpenFile).toHaveBeenCalledWith('./Notes: today.md');
30
+
31
+ // A bare name with a colon reads as a scheme, to react-markdown and to a
32
+ // browser alike; the value stays text so the author sees what to fix.
33
+ rerender(<KbMarkdownView source={source('Notes: today.md')} onOpenFile={onOpenFile} />);
34
+ expect(screen.queryByRole('link', { name: 'Today' })).toBeNull();
35
+ expect(screen.getByText('[Today](Notes: today.md)')).toBeInTheDocument();
36
+
37
+ rerender(<KbMarkdownView source={source('javascript:alert(1)')} onOpenFile={onOpenFile} />);
38
+ expect(screen.queryByRole('link', { name: 'Today' })).toBeNull();
39
+ expect(document.querySelector('a[href^="javascript"]')).toBeNull();
40
+ });
41
+
22
42
  it('routes internal .md body links (incl. anchors) through onOpenFile', () => {
23
43
  const onOpenFile = vi.fn();
24
44
  render(<KbMarkdownView source={SOURCE} onOpenFile={onOpenFile} />);
@@ -109,3 +129,220 @@ describe('KbMarkdownView', () => {
109
129
  expect((container.firstElementChild as HTMLElement).className).not.toContain('overflow-auto');
110
130
  });
111
131
  });
132
+
133
+ /**
134
+ * Images: every state of `KbImage` in the pipeline, driven through the view so
135
+ * the `resolveImage` prop is proven to reach the override.
136
+ */
137
+ describe('KbMarkdownView images', () => {
138
+ const RAW_URL = '/api/workspace/ws-1/file/raw?path=KB%2Fassets%2Fshot.png';
139
+ const serve = () => ({ src: RAW_URL, path: 'KB/assets/shot.png' });
140
+
141
+ it('passes an external image through as written, lazy and without a referrer', () => {
142
+ const resolveImage = vi.fn(serve);
143
+ render(
144
+ <KbMarkdownView
145
+ source={'![Ext](https://cdn.example.com/a.png)\n'}
146
+ onOpenFile={vi.fn()}
147
+ resolveImage={resolveImage}
148
+ />,
149
+ );
150
+ const img = screen.getByRole('img', { name: 'Ext' });
151
+ expect(img).toHaveAttribute('src', 'https://cdn.example.com/a.png');
152
+ expect(img).toHaveAttribute('loading', 'lazy');
153
+ expect(img).toHaveAttribute('referrerpolicy', 'no-referrer');
154
+ expect(resolveImage).not.toHaveBeenCalled();
155
+ });
156
+
157
+ it('treats a protocol-relative image as external', () => {
158
+ const resolveImage = vi.fn(serve);
159
+ render(
160
+ <KbMarkdownView
161
+ source={'![Ext](//cdn.example.com/a.png)\n'}
162
+ onOpenFile={vi.fn()}
163
+ resolveImage={resolveImage}
164
+ />,
165
+ );
166
+ expect(screen.getByRole('img', { name: 'Ext' })).toHaveAttribute('src', '//cdn.example.com/a.png');
167
+ expect(resolveImage).not.toHaveBeenCalled();
168
+ });
169
+
170
+ it('says what to do when the sanitizer stripped a data: image', () => {
171
+ render(
172
+ <KbMarkdownView
173
+ source={'![Pasted](data:image/png;base64,iVBORw0KGgo=)\n'}
174
+ onOpenFile={vi.fn()}
175
+ resolveImage={serve}
176
+ />,
177
+ );
178
+ const placeholder = screen.getByRole('img', { name: /no usable source/ });
179
+ expect(placeholder.getAttribute('aria-label')).toContain('Pasted');
180
+ expect(placeholder.getAttribute('aria-label')).toContain('./assets/');
181
+ });
182
+
183
+ it('renders a workspace image as a plain tag when no resolver is injected (the embed)', () => {
184
+ render(<KbMarkdownView source={'![Shot](./assets/shot.png)\n'} onOpenFile={vi.fn()} />);
185
+ expect(screen.getByRole('img', { name: 'Shot' })).toHaveAttribute('src', './assets/shot.png');
186
+ });
187
+
188
+ it("serves a workspace image from the resolver's URL", () => {
189
+ const resolveImage = vi.fn(serve);
190
+ render(
191
+ <KbMarkdownView
192
+ source={'![Shot](./assets/shot.png)\n'}
193
+ onOpenFile={vi.fn()}
194
+ resolveImage={resolveImage}
195
+ />,
196
+ );
197
+ expect(resolveImage).toHaveBeenCalledWith('./assets/shot.png');
198
+ const img = screen.getByRole('img', { name: 'Shot' });
199
+ expect(img).toHaveAttribute('src', RAW_URL);
200
+ expect(img).toHaveAttribute('loading', 'lazy');
201
+ expect(img).toHaveAttribute('referrerpolicy', 'no-referrer');
202
+ });
203
+
204
+ it('replaces an image that fails to load with a placeholder naming the workspace path', () => {
205
+ render(
206
+ <KbMarkdownView
207
+ source={'![Shot](./assets/shot.png)\n'}
208
+ onOpenFile={vi.fn()}
209
+ resolveImage={serve}
210
+ />,
211
+ );
212
+ fireEvent.error(screen.getByRole('img', { name: 'Shot' }));
213
+ const placeholder = screen.getByRole('button', { name: /Couldn't load image: KB\/assets\/shot.png/ });
214
+ // The alt text survives the picture.
215
+ expect(placeholder.getAttribute('aria-label')).toMatch(/^Shot\./);
216
+ });
217
+
218
+ // A URL that never changes (a blip, a 403 that lifts, a file fixed on disk
219
+ // with no event) is the one failure nothing else clears.
220
+ it('tries the same source again on request after a failed load', () => {
221
+ render(
222
+ <KbMarkdownView
223
+ source={'![Shot](./assets/shot.png)\n'}
224
+ onOpenFile={vi.fn()}
225
+ resolveImage={serve}
226
+ />,
227
+ );
228
+ fireEvent.error(screen.getByRole('img', { name: 'Shot' }));
229
+ fireEvent.click(screen.getByRole('button', { name: /Retry$/ }));
230
+ expect(screen.getByRole('img', { name: 'Shot' })).toHaveAttribute('src', RAW_URL);
231
+ });
232
+
233
+ it('recovers when the source changes after a failure, without a reload', () => {
234
+ const resolveImage = (src: string) => ({ src: `/raw/${src}`, path: src });
235
+ const view = (src: string) => (
236
+ <KbMarkdownView source={`![Shot](${src})\n`} onOpenFile={vi.fn()} resolveImage={resolveImage} />
237
+ );
238
+ const { rerender } = render(view('missing.png'));
239
+ fireEvent.error(screen.getByRole('img', { name: 'Shot' }));
240
+ expect(screen.getByRole('button', { name: /Couldn't load image/ })).toBeInTheDocument();
241
+ rerender(view('fixed.png'));
242
+ expect(screen.getByRole('img', { name: 'Shot' })).toHaveAttribute('src', '/raw/fixed.png');
243
+ });
244
+
245
+ it("shows the resolver's note instead of fetching when it withholds the bytes", () => {
246
+ render(
247
+ <KbMarkdownView
248
+ source={'![Shot](./assets/shot.png)\n'}
249
+ onOpenFile={vi.fn()}
250
+ resolveImage={(src) => ({ src: null, path: src, note: 'Baseline image not shown' })}
251
+ />,
252
+ );
253
+ expect(
254
+ screen.getByRole('img', { name: /Baseline image not shown: \.\/assets\/shot.png/ }),
255
+ ).toBeInTheDocument();
256
+ expect(document.querySelector('img')).toBeNull();
257
+ });
258
+
259
+ it('names the raw source when the resolver cannot place it', () => {
260
+ render(
261
+ <KbMarkdownView
262
+ source={'![Shot](./assets/shot.png)\n'}
263
+ onOpenFile={vi.fn()}
264
+ resolveImage={() => null}
265
+ />,
266
+ );
267
+ expect(
268
+ screen.getByRole('img', { name: /Couldn't load image: \.\/assets\/shot.png/ }),
269
+ ).toBeInTheDocument();
270
+ });
271
+
272
+ it('routes an inline HTML <img> through the same override', () => {
273
+ const resolveImage = vi.fn(serve);
274
+ render(
275
+ <KbMarkdownView
276
+ source={'<img src="./assets/shot.png" alt="Inline">\n'}
277
+ onOpenFile={vi.fn()}
278
+ resolveImage={resolveImage}
279
+ />,
280
+ );
281
+ expect(resolveImage).toHaveBeenCalledWith('./assets/shot.png');
282
+ expect(screen.getByRole('img', { name: 'Inline' })).toHaveAttribute('src', RAW_URL);
283
+ });
284
+
285
+ it('forwards the attributes the sanitizer let through on an inline image', () => {
286
+ render(
287
+ <KbMarkdownView
288
+ source={'<img src="./assets/shot.png" alt="Inline" align="right">\n'}
289
+ onOpenFile={vi.fn()}
290
+ resolveImage={serve}
291
+ />,
292
+ );
293
+ const img = screen.getByRole('img', { name: 'Inline' });
294
+ expect(img).toHaveAttribute('align', 'right');
295
+ expect(img).toHaveAttribute('src', RAW_URL);
296
+ });
297
+
298
+ // A placeholder stands in for the image in the document: an anchor to the
299
+ // figure still lands, a caption still describes it, nothing sizes a
300
+ // picture that is not there, and nothing names it but itself.
301
+ it("gives a placeholder the image's place in the document, not its dimensions or its name", () => {
302
+ render(
303
+ <KbMarkdownView
304
+ source={
305
+ '<p id="ttl">Figure 1</p><img src="./assets/shot.png" alt="Shot" id="fig-1" aria-describedby="cap" aria-labelledby="ttl" width="300">\n'
306
+ }
307
+ onOpenFile={vi.fn()}
308
+ resolveImage={serve}
309
+ />,
310
+ );
311
+ const img = screen.getByRole('img', { name: 'Figure 1' });
312
+ expect(img).toHaveAttribute('width', '300');
313
+ fireEvent.error(img);
314
+ const placeholder = screen.getByRole('button', { name: /^Shot\. Couldn't load image/ });
315
+ // The sanitizer prefixes ids and id references alike.
316
+ expect(placeholder).toHaveAttribute('id', 'user-content-fig-1');
317
+ expect(placeholder).toHaveAttribute('aria-describedby', 'user-content-cap');
318
+ expect(placeholder).not.toHaveAttribute('aria-labelledby');
319
+ expect(placeholder).not.toHaveAttribute('width');
320
+ });
321
+
322
+ it("names the placeholder for what it is, whatever aria-label the image carried", () => {
323
+ render(
324
+ <KbMarkdownView
325
+ source={'<img src="./assets/rule.png" alt="Rule" aria-label="Decorative rule">\n'}
326
+ onOpenFile={vi.fn()}
327
+ resolveImage={serve}
328
+ />,
329
+ );
330
+ fireEvent.error(screen.getByRole('img', { name: 'Decorative rule' }));
331
+ expect(screen.getByRole('button', { name: /^Rule\. Couldn't load image/ })).toBeInTheDocument();
332
+ expect(screen.queryByRole('button', { name: 'Decorative rule' })).toBeNull();
333
+ });
334
+
335
+ it('keeps alt and title, and leaks no hast node onto the element', () => {
336
+ render(
337
+ <KbMarkdownView
338
+ source={'![Shot](./assets/shot.png "The approval screen")\n'}
339
+ onOpenFile={vi.fn()}
340
+ resolveImage={serve}
341
+ />,
342
+ );
343
+ const img = screen.getByRole('img', { name: 'Shot' });
344
+ expect(img).toHaveAttribute('alt', 'Shot');
345
+ expect(img).toHaveAttribute('title', 'The approval screen');
346
+ expect(img.hasAttribute('node')).toBe(false);
347
+ });
348
+ });