@bevel-software/platform-core-frontend 0.15.1 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +16 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  33. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  34. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  35. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  36. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  37. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  38. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  39. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  40. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  41. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  42. package/src/modules/admin/components/group-members-path.ts +32 -0
  43. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  44. package/src/modules/admin/services/roles.api.ts +12 -1
  45. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  46. package/src/modules/auth/components/AccountPage.tsx +73 -54
  47. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  48. package/src/modules/auth/services/account.api.ts +78 -4
  49. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  57. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  58. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  59. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  60. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  61. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  62. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  63. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  64. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  65. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  66. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  67. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  68. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  69. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  70. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  71. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  72. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  73. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  74. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  75. package/src/modules/change-requests/services/propose.api.ts +97 -8
  76. package/src/modules/change-requests/utils/approval.ts +15 -0
  77. package/src/modules/change-requests/utils/author.ts +32 -0
  78. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  79. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  80. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  81. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  82. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  83. package/src/modules/git/services/error-messages.ts +12 -0
  84. package/src/modules/git/services/pr-prompts.ts +5 -5
  85. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  86. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  87. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  88. package/src/modules/layout/components/AppLayout.tsx +2 -0
  89. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  90. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  91. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  92. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  93. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  94. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  95. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  96. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  97. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  98. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  99. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  100. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  101. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  102. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  103. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  104. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  105. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  106. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  107. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  108. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  109. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  110. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  111. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  112. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  113. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  114. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  115. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  116. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  117. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  118. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  119. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  120. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  121. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  122. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  123. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  124. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  125. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  126. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  127. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  128. package/src/modules/library/__tests__/status.test.ts +82 -2
  129. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  130. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  131. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  132. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  133. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  134. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  135. package/src/modules/library/components/LibraryCard.tsx +146 -45
  136. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  137. package/src/modules/library/components/LibraryPage.tsx +172 -39
  138. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  139. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  140. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  141. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  142. package/src/modules/library/components/PageActions.tsx +11 -9
  143. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  144. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  145. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  146. package/src/modules/library/components/PluginExtras.tsx +140 -17
  147. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  148. package/src/modules/library/components/PluginPage.tsx +157 -41
  149. package/src/modules/library/components/PluginRows.tsx +286 -0
  150. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  151. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  152. package/src/modules/library/components/ShareButton.tsx +17 -0
  153. package/src/modules/library/components/SkillsTree.tsx +141 -28
  154. package/src/modules/library/components/TeamRoute.tsx +15 -0
  155. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  156. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  157. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  158. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  159. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  160. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  161. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  162. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  163. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  164. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  165. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  166. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  167. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  168. package/src/modules/library/routes/library-paths.ts +26 -28
  169. package/src/modules/library/services/library.api.ts +38 -20
  170. package/src/modules/library/services/plugins.api.ts +69 -8
  171. package/src/modules/library/services/teams.api.ts +15 -0
  172. package/src/modules/library/services/tools.api.ts +78 -0
  173. package/src/modules/library/state/library-data.tsx +170 -32
  174. package/src/modules/library/utils/personal-plugin.ts +13 -15
  175. package/src/modules/library/utils/plugin-entries.ts +134 -0
  176. package/src/modules/library/utils/plugin-summary.ts +75 -9
  177. package/src/modules/library/utils/status.ts +135 -33
  178. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  179. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  180. package/src/modules/onboarding/agent-clients.ts +55 -23
  181. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  182. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  183. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  184. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  185. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  186. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  187. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  188. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  189. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  190. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  191. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  192. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  193. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  194. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  195. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  196. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  197. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  198. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  199. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  200. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  201. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  202. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  203. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  204. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  205. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  206. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  207. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  208. package/src/modules/settings/services/github-facade.api.ts +23 -0
  209. package/src/modules/settings/settings-nav-items.tsx +10 -2
  210. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  211. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  212. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  213. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  214. package/src/modules/setup/components/SetupGate.tsx +16 -16
  215. package/src/modules/setup/components/SetupScreen.tsx +521 -43
  216. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  217. package/src/modules/setup/services/setup.api.ts +140 -3
  218. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  219. package/src/modules/setup/utils/root-folders.ts +46 -0
  220. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  221. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  232. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  233. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  234. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  235. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  236. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  237. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  238. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  239. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  240. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  241. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  242. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  243. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  244. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  245. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  246. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  247. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  248. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  249. package/src/modules/toolbar/services/external-api-keys.api.ts +6 -0
  250. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  251. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  252. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  254. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  255. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  256. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  257. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  258. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  259. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  260. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  261. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  262. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  263. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  264. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +331 -12
  265. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  266. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  267. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  268. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  269. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  270. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  271. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  272. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  273. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  274. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  275. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  276. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  277. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  279. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  280. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  281. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  282. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  283. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  284. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  285. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  286. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  287. package/src/modules/workspace/components/renderers/index.ts +53 -2
  288. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  289. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  290. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  291. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  292. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  294. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  295. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  296. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  297. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  298. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  299. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  300. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  301. package/src/modules/workspace/services/workspace.api.ts +57 -4
  302. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  303. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  304. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  305. package/src/modules/workspace/state/workspace.context.ts +125 -19
  306. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  307. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  308. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  309. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  310. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  311. package/src/modules/workspace/utils/file-trace.ts +50 -0
  312. package/src/modules/workspace/utils/fileTree.ts +112 -36
  313. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  314. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  315. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  316. package/src/modules/workspace/utils/uploadError.ts +29 -0
  317. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  318. package/src/shared/components/Button.tsx +16 -2
  319. package/src/shared/components/Dialog.tsx +27 -11
  320. package/src/shared/components/Menu.tsx +13 -1
  321. package/src/shared/components/PageShell.tsx +13 -8
  322. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  323. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  324. package/src/shared/components/index.ts +2 -0
  325. package/src/shared/components/useDismissableMenu.ts +32 -10
  326. package/src/shared/components/useFocusHandoff.ts +51 -0
  327. package/src/shared/components/useLatestRef.ts +28 -0
  328. package/src/shared/markdown/Markdown.tsx +12 -3
  329. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  330. package/src/shared/markdown/hrefs.ts +50 -0
  331. package/src/shared/marketplace-url.ts +33 -5
  332. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  333. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  334. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  335. package/src/shared/mcp/connect-snippets.ts +14 -9
  336. package/src/shared/mcp/index.ts +1 -1
  337. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  338. package/src/shared/theme/header.ts +75 -0
  339. package/src/shared/theme/measure.ts +7 -4
  340. package/src/shared/theme/tokens.css +25 -0
  341. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  342. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  343. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  344. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  345. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  346. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,191 +1,173 @@
1
- import { describe, it, expect, vi, type Mock } from 'vitest';
1
+ import { describe, it, expect, vi, beforeEach, type Mock } from 'vitest';
2
2
  import { render, screen, fireEvent, cleanup, within } from '@testing-library/react';
3
3
  import { PluginsSidebar, type PluginsSidebarProps } from '../components/PluginsSidebar';
4
4
  import type { LibraryFilter } from '../utils/status';
5
5
 
6
6
  /**
7
- * The sidebar as a pure view: given a filter and counts, which row is current,
8
- * what its count slot says, and which intent a click emits. It owns no state
9
- * and no navigation, so nothing here needs a router.
7
+ * The Library nav: two lenses, the groups as the server lists them, the two
8
+ * roots as trees. A pure view of the URL — `filter` in, intents out.
10
9
  */
11
10
 
12
11
  function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
13
12
  const onSelect = vi.fn();
14
- const onFinishSetup = vi.fn();
15
13
  const props: PluginsSidebarProps = {
16
14
  filter: { kind: 'all' },
17
15
  onSelect,
18
- plugins: [
19
- { plugin: 'Engineering', count: 4, attention: 0 },
20
- { plugin: 'GTM', count: 3, attention: 2 },
21
- { plugin: 'Product', count: 0, attention: 0 },
22
- ],
23
- lockedPlugins: [],
24
16
  ownedCount: 2,
25
17
  ownedAttention: 0,
26
- personalPluginLabel: "Juan's Plugin",
27
- ungroupedCount: 1,
28
- attentionCount: 2,
29
- onFinishSetup,
18
+ teams: [
19
+ { name: 'Engineering', count: 4, urgent: 0 },
20
+ { name: 'GTM', count: 3, urgent: 2 },
21
+ { name: 'Product', count: 0, urgent: 0 },
22
+ ],
30
23
  onCreatePlugin: vi.fn(),
31
- canCreatePlugin: true,
32
- pluginsIndexActive: false,
33
- onOpenPluginsIndex: vi.fn(),
34
-
24
+ canCreatePlugin: false,
35
25
  ...over,
36
26
  };
37
27
  render(<PluginsSidebar {...props} />);
38
28
  return {
39
29
  onSelect,
40
- onFinishSetup,
41
30
  onCreatePlugin: props.onCreatePlugin as Mock,
42
- onOpenPluginsIndex: props.onOpenPluginsIndex as Mock,
43
31
  };
44
32
  }
45
33
 
46
34
  const row = (name: RegExp | string) => screen.getByRole('button', { name });
47
35
 
48
36
  describe('PluginsSidebar', () => {
49
- it('shows a plugin by its label and navigates by its identity — locked rows too', () => {
50
- const { onSelect } = renderSidebar({
51
- plugins: [{ plugin: 'gtm', label: 'Go To Market', count: 3, attention: 0 }],
52
- lockedPlugins: [{ name: 'finance', label: 'Finance' }],
53
- });
54
- fireEvent.click(row(/^Go To Market/));
55
- expect(onSelect).toHaveBeenCalledWith({ kind: 'group', plugin: 'gtm' });
56
- expect(screen.queryByRole('button', { name: /^gtm/ })).toBeNull();
57
-
58
- fireEvent.click(row('Finance (locked)'));
59
- expect(onSelect).toHaveBeenCalledWith({ kind: 'group', plugin: 'finance' });
60
- expect(screen.queryByRole('button', { name: /^finance/ })).toBeNull();
61
- });
62
-
63
- it('two plugins wearing one label are still two rows, each navigating to its own identity', () => {
64
- // React tells on a list keyed by something two children share; the rows
65
- // are keyed by what they ARE, so it has nothing to say.
66
- const consoleError = vi.spyOn(console, 'error').mockImplementation(() => {});
67
- try {
68
- const { onSelect } = renderSidebar({
69
- plugins: [
70
- { plugin: 'sales-eu', label: 'Sales', count: 1, attention: 0 },
71
- { plugin: 'sales-us', label: 'Sales', count: 2, attention: 0 },
72
- ],
73
- });
74
- const rows = screen.getAllByRole('button', { name: /^Sales/ });
75
- expect(rows).toHaveLength(2);
76
- fireEvent.click(rows[1]);
77
- expect(onSelect).toHaveBeenLastCalledWith({ kind: 'group', plugin: 'sales-us' });
78
- expect(consoleError).not.toHaveBeenCalled();
79
- } finally {
80
- consoleError.mockRestore();
81
- }
82
- });
37
+ // The remembered view is per-browser state; each test starts from a browser
38
+ // that remembers nothing.
39
+ beforeEach(() => window.localStorage.removeItem('bevel-library-sidebar-view'));
83
40
 
84
- it('leads with All plugins. The Library opens there, so the nav starts there', () => {
85
- const { onOpenPluginsIndex } = renderSidebar();
41
+ it('leads with Everything, the Library home, and marks it current on the root', () => {
42
+ renderSidebar({ filter: { kind: 'all' } });
86
43
  const rows = screen.getAllByRole('button');
87
- expect(rows[0]).toHaveAccessibleName('All plugins');
88
- fireEvent.click(rows[0]);
89
- expect(onOpenPluginsIndex).toHaveBeenCalledTimes(1);
90
- });
91
-
92
- it('marks All plugins current on the index, and nothing else', () => {
93
- renderSidebar({ filter: null, pluginsIndexActive: true });
94
- expect(row(/^All plugins/)).toHaveAttribute('aria-current', 'true');
95
- expect(row(/^Everything/)).toHaveAttribute('aria-current', 'false');
44
+ expect(rows[0]).toHaveAccessibleName('Everything');
45
+ expect(row(/^Everything/)).toHaveAttribute('aria-current', 'true');
96
46
  expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
97
47
  });
98
48
 
99
- it('keeps Everything as a lens of its own, since the root is the index now', () => {
100
- renderSidebar({ filter: { kind: 'all' } });
101
- expect(row(/^Everything/)).toHaveAttribute('aria-current', 'true');
102
- expect(row(/^All plugins/)).toHaveAttribute('aria-current', 'false');
49
+ it('lights no row on a page with no filter — an item page, a plugin page', () => {
50
+ renderSidebar({ filter: null });
51
+ for (const button of screen.getAllByRole('button')) {
52
+ expect(button).not.toHaveAttribute('aria-current', 'true');
53
+ }
103
54
  });
104
55
 
105
- it('heads the plugin rows with what they are: plugins', () => {
56
+ it('offers two views under the lenses — Teams by default — and lists no plugins of its own', () => {
106
57
  renderSidebar();
107
- expect(screen.getByText('Plugins')).toBeInTheDocument();
108
- expect(screen.queryByText('Included in your MCP')).not.toBeInTheDocument();
109
- });
110
-
111
- it('renders the Skills tree it is handed right under All plugins, before the lenses', () => {
112
- renderSidebar({ skillsTree: <div data-testid="skills-tree">tree</div> });
113
- const tree = screen.getByTestId('skills-tree');
114
- const home = screen.getByRole('button', { name: 'All plugins' });
115
- const library = screen.getByText('Library');
116
- // Document order: All plugins → the tree → the Library heading.
117
- expect(home.compareDocumentPosition(tree) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
118
- expect(tree.compareDocumentPosition(library) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
58
+ const tabs = screen.getByRole('tablist', { name: 'Sidebar view' });
59
+ expect(within(tabs).getByRole('tab', { name: 'Groups' })).toHaveAttribute('aria-selected', 'true');
60
+ expect(within(tabs).getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'false');
61
+ expect(screen.getByRole('tabpanel', { name: 'Groups' })).toBeInTheDocument();
62
+ expect(screen.queryByText('Plugins')).not.toBeInTheDocument();
63
+ expect(screen.queryByText('All plugins')).not.toBeInTheDocument();
64
+ expect(screen.queryByText('Library')).not.toBeInTheDocument();
119
65
  });
120
66
 
121
- it("leads the plugins with the caller's own space", () => {
67
+ it("lists the groups in the server's order and nothing else — your own space is not a group", () => {
122
68
  renderSidebar({ filter: { kind: 'ungrouped' } });
123
- expect(row(/^Juan's Plugin/)).toHaveAttribute('aria-current', 'true');
124
- expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
125
- });
126
-
127
- it('offers a way to make a plugin', () => {
128
- const { onCreatePlugin } = renderSidebar();
129
- fireEvent.click(screen.getByRole('button', { name: 'New plugin' }));
130
- expect(onCreatePlugin).toHaveBeenCalledTimes(1);
131
- });
132
-
133
- it('spells out Create a plugin while the MCP list is empty — the `+` alone is hover-hidden', () => {
134
- const { onCreatePlugin } = renderSidebar({ plugins: [] });
135
- fireEvent.click(screen.getByRole('button', { name: 'Create a plugin' }));
136
- expect(onCreatePlugin).toHaveBeenCalledTimes(1);
137
- });
138
-
139
- it('stands the create CTA down once a real plugin exists', () => {
140
- renderSidebar(); // default fixture has three plugins
141
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
142
- });
143
-
144
- it('stands the create CTA down when only locked plugins exist — someone already created them', () => {
145
- renderSidebar({ plugins: [], lockedPlugins: ['Ops'] });
146
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
69
+ const panel = screen.getByRole('tabpanel', { name: 'Groups' });
70
+ expect(within(panel).getAllByRole('button').map((b) => b.textContent)).toEqual([
71
+ 'Engineering4',
72
+ 'GTM2',
73
+ 'Product',
74
+ ]);
75
+ // The own-space page lights no row: it is reached from Everything, not from here.
76
+ expect(within(panel).queryByRole('button', { current: true })).toBeNull();
147
77
  });
148
78
 
149
- it('stands the create CTA down for a non-admin, empty workspace or not', () => {
150
- renderSidebar({ plugins: [], lockedPlugins: [], canCreatePlugin: false });
151
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
152
- });
153
-
154
- it('says nothing about creating when the prop is omitted — the nav a host app already had', () => {
155
- // `canCreatePlugin` is optional so this public props type survives the
156
- // upgrade. Omitted must mean OFF, which is the nav exactly as it shipped.
157
- renderSidebar({ plugins: [], lockedPlugins: [], canCreatePlugin: undefined });
158
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
79
+ it('switches to the Advanced view, which holds the two trees — Skills before Plugins — and no team rows', () => {
80
+ renderSidebar({
81
+ skillsTree: <div data-testid="skills-tree">skills</div>,
82
+ pluginsTree: <div data-testid="plugins-tree">plugins</div>,
83
+ });
84
+ // The other view stays MOUNTED and hidden — the trees keep their state
85
+ // across a switch, and every tab's `aria-controls` names a real panel.
86
+ expect(screen.getByTestId('skills-tree')).not.toBeVisible();
87
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-controls', 'library-view-advanced');
88
+ expect(document.getElementById('library-view-advanced')).not.toBeNull();
89
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
90
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'true');
91
+ const panel = screen.getByRole('tabpanel', { name: 'Advanced' });
92
+ const skills = within(panel).getByTestId('skills-tree');
93
+ const plugins = within(panel).getByTestId('plugins-tree');
94
+ expect(skills.compareDocumentPosition(plugins) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
95
+ // No heading over the trees: the tab already names the view.
96
+ expect(within(panel).queryByText('Files on disk')).toBeNull();
97
+ expect(screen.queryByRole('button', { name: /^Engineering/ })).toBeNull();
98
+ // The lenses belong to neither view and stay put.
99
+ expect(row(/^Everything/)).toBeInTheDocument();
100
+ expect(row(/^Owned by me/)).toBeInTheDocument();
101
+ });
102
+
103
+ it('remembers the view in the browser, and defaults to Teams when the browser remembers nothing', () => {
104
+ renderSidebar();
105
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
106
+ expect(window.localStorage.getItem('bevel-library-sidebar-view')).toBe('advanced');
107
+ cleanup();
108
+ renderSidebar();
109
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'true');
110
+ window.localStorage.removeItem('bevel-library-sidebar-view');
111
+ cleanup();
112
+ renderSidebar();
113
+ expect(screen.getByRole('tab', { name: 'Groups' })).toHaveAttribute('aria-selected', 'true');
159
114
  });
160
115
 
161
- it('marks the selected plugin current and leaves the others alone', () => {
162
- renderSidebar({ filter: { kind: 'group', plugin: 'GTM' } });
116
+ it('is one tab stop: the arrows move between the views and choose as they go, Home and End go to the ends', () => {
117
+ renderSidebar();
118
+ const teams = screen.getByRole('tab', { name: 'Groups' });
119
+ const advanced = screen.getByRole('tab', { name: 'Advanced' });
120
+ // Roving tabIndex: only the chosen tab is in the Tab order.
121
+ expect(teams).toHaveAttribute('tabindex', '0');
122
+ expect(advanced).toHaveAttribute('tabindex', '-1');
123
+
124
+ teams.focus();
125
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'ArrowRight' });
126
+ expect(advanced).toHaveAttribute('aria-selected', 'true');
127
+ expect(document.activeElement).toBe(advanced);
128
+ expect(advanced).toHaveAttribute('tabindex', '0');
129
+ expect(teams).toHaveAttribute('tabindex', '-1');
130
+
131
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'ArrowRight' });
132
+ expect(teams).toHaveAttribute('aria-selected', 'true'); // wraps
133
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'End' });
134
+ expect(advanced).toHaveAttribute('aria-selected', 'true');
135
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'Home' });
136
+ expect(teams).toHaveAttribute('aria-selected', 'true');
137
+ expect(document.activeElement).toBe(teams);
138
+ });
139
+
140
+ it('answers a right-click on the switch with nothing — it is a control, not empty nav space', () => {
141
+ const onContextMenu = vi.fn();
142
+ renderSidebar({ onContextMenu });
143
+ fireEvent.contextMenu(screen.getByRole('tab', { name: 'Advanced' }));
144
+ fireEvent.contextMenu(screen.getByRole('tablist', { name: 'Sidebar view' }));
145
+ expect(onContextMenu).not.toHaveBeenCalled();
146
+ });
147
+
148
+ it('marks the selected team current and leaves the others alone', () => {
149
+ renderSidebar({ filter: { kind: 'team', group: 'GTM' } });
163
150
  expect(row(/^GTM/)).toHaveAttribute('aria-current', 'true');
164
151
  expect(row(/^Engineering/)).toHaveAttribute('aria-current', 'false');
152
+ expect(row(/^Everything/)).toHaveAttribute('aria-current', 'false');
165
153
  });
166
154
 
167
- it('shows the attention count instead of the item count when something needs setup', () => {
155
+ it("shows how much a team can use, in grey — and nothing at all for a team that can use nothing", () => {
168
156
  renderSidebar();
169
- // GTM: 3 items but 2 integrations need setup — amber wins the slot.
170
- expect(row(/^GTM/)).toHaveAccessibleName('GTM 2');
171
- expect(within(row(/^GTM/)).getByText('2')).toHaveClass('text-wait');
172
157
  expect(row(/^Engineering/)).toHaveAccessibleName('Engineering 4');
173
- // Never a grey 0: an empty plugin shows no count at all.
158
+ expect(within(row(/^Engineering/)).getByText('4')).toHaveClass('text-ink-faint');
159
+ // Never a grey 0.
174
160
  expect(row(/^Product/)).toHaveAccessibleName('Product');
175
161
  });
176
162
 
177
- it('turns the count orange when members are locked out of a linked skill', () => {
178
- renderSidebar({
179
- plugins: [
180
- { plugin: 'GTM', count: 3, attention: 2, urgent: true },
181
- { plugin: 'Ops', count: 3, attention: 1, urgent: false },
182
- ],
183
- });
184
- // Blocking other people outranks a tool the reader has not set up.
185
- const gtm = within(row(/^GTM/)).getByText('2');
186
- expect(gtm).toHaveClass('text-urgent');
187
- expect(gtm).not.toHaveClass('text-wait');
188
- expect(within(row(/^Ops/)).getByText('1')).toHaveClass('text-wait');
163
+ it("turns a team's count orange when its plugins lock its members out of a skill", () => {
164
+ renderSidebar();
165
+ // GTM can use 3 things, but 2 links are broken for its members: orange
166
+ // wins the slot — other people's problem outranks the inventory.
167
+ expect(row(/^GTM/)).toHaveAccessibleName('GTM 2');
168
+ const badge = within(row(/^GTM/)).getByText('2');
169
+ expect(badge).toHaveClass('text-urgent');
170
+ expect(badge).not.toHaveClass('text-wait');
189
171
  });
190
172
 
191
173
  it('emits the right LibraryFilter per row', () => {
@@ -193,8 +175,7 @@ describe('PluginsSidebar', () => {
193
175
  const expected: [RegExp, LibraryFilter][] = [
194
176
  [/^Everything/, { kind: 'all' }],
195
177
  [/^Owned by me/, { kind: 'owned' }],
196
- [/^GTM/, { kind: 'group', plugin: 'GTM' }],
197
- [/^Juan's Plugin/, { kind: 'ungrouped' }],
178
+ [/^GTM/, { kind: 'team', group: 'GTM' }],
198
179
  ];
199
180
  for (const [name, filter] of expected) {
200
181
  onSelect.mockClear();
@@ -203,11 +184,28 @@ describe('PluginsSidebar', () => {
203
184
  }
204
185
  });
205
186
 
206
- it("keeps the caller's own plugin listed even when it is empty", () => {
207
- // It is a PLACE, not a filtered view: a plugin you are always in does not
208
- // vanish because you have not put anything in it yet.
209
- renderSidebar({ ungroupedCount: 0 });
210
- expect(row(/^Juan's Plugin/)).toBeInTheDocument();
187
+ it('two teams may not share a name, but a team may share one with a lens — rows stay distinct', () => {
188
+ renderSidebar({ teams: [{ name: 'Everything', count: 1, urgent: 0 }] });
189
+ const rows = screen.getAllByRole('button', { name: /^Everything/ });
190
+ expect(rows).toHaveLength(2);
191
+ });
192
+
193
+ it('spells out Create a plugin in the Advanced view when told the workspace is untouched — the `+` alone is hover-hidden', () => {
194
+ const { onCreatePlugin } = renderSidebar({ canCreatePlugin: true });
195
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
196
+ fireEvent.click(screen.getByRole('button', { name: 'Create a plugin' }));
197
+ expect(onCreatePlugin).toHaveBeenCalledTimes(1);
198
+ });
199
+
200
+ it('says nothing about creating unless told to — the verdict is the layout\'s, and omitted means off', () => {
201
+ renderSidebar({ canCreatePlugin: false });
202
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
203
+ expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
204
+ cleanup();
205
+ window.localStorage.removeItem('bevel-library-sidebar-view');
206
+ renderSidebar({ canCreatePlugin: undefined });
207
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
208
+ expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
211
209
  });
212
210
 
213
211
  it('shows the owned count in grey, and amber only when something waits on you', () => {
@@ -217,16 +215,21 @@ describe('PluginsSidebar', () => {
217
215
  cleanup();
218
216
  renderSidebar({ ownedCount: 26, ownedAttention: 1 });
219
217
  expect(row(/^Owned by me/)).toHaveAccessibleName('Owned by me 1');
218
+ expect(within(row(/^Owned by me/)).getByText('1')).toHaveClass('text-wait');
220
219
  });
221
220
 
222
- it('sends the setup footer to Connect', () => {
223
- const { onFinishSetup } = renderSidebar();
224
- fireEvent.click(row(/integrations need setup/));
225
- expect(onFinishSetup).toHaveBeenCalledTimes(1);
226
- });
227
-
228
- it('hides the setup footer when nothing needs setup', () => {
229
- renderSidebar({ attentionCount: 0 });
221
+ /**
222
+ * The setup reminder is no longer the nav's last row — it is a footer row
223
+ * the layout passes to the frame (`IntegrationsSetupReminder`), which is
224
+ * what puts it on the same grid as the change-request dock beneath it.
225
+ * What this file has to hold is that the nav does NOT place it any more;
226
+ * the row itself is covered in `IntegrationsSetupReminder.test.tsx`.
227
+ */
228
+ it('is the nav and nothing else — no row of its own below it', () => {
229
+ renderSidebar();
230
230
  expect(screen.queryByRole('button', { name: /needs? setup/ })).not.toBeInTheDocument();
231
+ expect(screen.queryByText(/Finish now/)).not.toBeInTheDocument();
232
+ const nav = screen.getByRole('navigation', { name: 'Library navigation' });
233
+ expect(nav.parentElement?.childElementCount).toBe(1);
231
234
  });
232
235
  });
@@ -140,3 +140,19 @@ describe('PluginsSidebarMenu', () => {
140
140
  row.remove();
141
141
  });
142
142
  });
143
+
144
+ describe('PluginsSidebarMenu: Manage members', () => {
145
+ it('is absent unless the caller passes it', () => {
146
+ renderMenu();
147
+ expect(screen.queryByRole('menuitem', { name: 'Manage members' })).toBeNull();
148
+ });
149
+
150
+ it('comes last when present, and closes the menu when chosen', () => {
151
+ const onManageMembers = vi.fn();
152
+ const { onClose } = renderMenu({ onAdd: undefined, onManageAccess: undefined, onManageMembers });
153
+ expect(items()).toEqual(['New plugin', 'Copy link', 'Manage members']);
154
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Manage members' }));
155
+ expect(onManageMembers).toHaveBeenCalledTimes(1);
156
+ expect(onClose).toHaveBeenCalledTimes(1);
157
+ });
158
+ });
@@ -0,0 +1,106 @@
1
+ import { describe, it, expect, vi } from 'vitest';
2
+ import { render, screen, fireEvent } from '@testing-library/react';
3
+ import { MemoryRouter } from 'react-router-dom';
4
+ import { LibraryContext } from '../state/library-context';
5
+ import type { LibraryContextValue, LibraryItem } from '../state/library-data';
6
+ import type { PluginMembership } from '../services/library.api';
7
+ import { SharedViaPlugins } from '../components/skill-page/SharedViaPlugins';
8
+
9
+ /**
10
+ * The skill page's "In plugins" section, on the one question this ticket
11
+ * settles: who may be shared onward.
12
+ *
13
+ * The section used to read `metadata.lifecycle` off the catalog item and offer
14
+ * a retired skill nothing — the chooser went empty because the link API would
15
+ * have refused every choice. The API no longer refuses, so neither does this:
16
+ * a skill is offered every plugin the caller manages, whatever its frontmatter
17
+ * still declares.
18
+ */
19
+
20
+ const OK = { state: 'ok' as const, text: 'Ready' };
21
+
22
+ function pluginSummary(name: string) {
23
+ return {
24
+ name,
25
+ folders: [`Plugins/${name}`],
26
+ canRead: true,
27
+ canWrite: true,
28
+ } as LibraryContextValue['pluginSummaries'][number];
29
+ }
30
+
31
+ function lib(items: LibraryItem[]): LibraryContextValue {
32
+ return {
33
+ loading: false,
34
+ error: null,
35
+ skills: [],
36
+ pendingSkills: [],
37
+ pendingTools: [],
38
+ tools: [],
39
+ ownedSkills: new Set(),
40
+ writableSkills: new Set(),
41
+ ownedTools: new Set(),
42
+ allowedToolsBySkill: new Map(),
43
+ crs: [],
44
+ myCrNumbers: new Set(),
45
+ reload: vi.fn(),
46
+ items,
47
+ pluginSummaries: [pluginSummary('GTM')],
48
+ pluginsLoading: false,
49
+ pluginsError: null,
50
+ teams: [],
51
+ teamsLoading: false,
52
+ teamsError: null,
53
+ reloadPlugins: vi.fn(),
54
+ };
55
+ }
56
+
57
+ function renderSection(items: LibraryItem[], memberships: PluginMembership[] = []) {
58
+ render(
59
+ <MemoryRouter>
60
+ <LibraryContext.Provider value={lib(items)}>
61
+ <SharedViaPlugins
62
+ skillName="legacy"
63
+ skillPath="Skills/Eng/legacy"
64
+ memberships={memberships}
65
+ canWrite
66
+ onChanged={vi.fn()}
67
+ />
68
+ </LibraryContext.Provider>
69
+ </MemoryRouter>,
70
+ );
71
+ }
72
+
73
+ // The cast is the point: `lifecycle` is no longer part of `LibraryItem`, so a
74
+ // server still sending the key — from a SKILL.md that still declares it — is
75
+ // exactly the case that must change nothing here.
76
+ const legacy = {
77
+ kind: 'skill',
78
+ id: 'legacy',
79
+ name: 'legacy',
80
+ description: 'Old but readable.',
81
+ owned: true,
82
+ canWrite: true,
83
+ plugin: null,
84
+ shared: true,
85
+ plugins: [],
86
+ path: 'Skills/Eng/legacy',
87
+ status: OK,
88
+ lifecycle: 'retired',
89
+ } as LibraryItem;
90
+
91
+ describe('SharedViaPlugins', () => {
92
+ it('offers the plugins the caller manages to a skill whose frontmatter still says retired', async () => {
93
+ renderSection([legacy]);
94
+ fireEvent.click(screen.getByRole('button', { name: 'Add to plugin…' }));
95
+ expect(await screen.findByRole('option', { name: 'GTM' })).toBeInTheDocument();
96
+ });
97
+
98
+ it('leaves out only the plugins the skill is already in', () => {
99
+ renderSection([legacy], [{ name: 'GTM', linked: true, granted: true }]);
100
+ // The one managed plugin already holds it, so there is nothing to add —
101
+ // an absent chooser, not an empty one, and for a reason that is about
102
+ // membership rather than about the skill's declared lifecycle.
103
+ expect(screen.queryByRole('button', { name: 'Add to plugin…' })).not.toBeInTheDocument();
104
+ expect(screen.getByText('GTM')).toBeInTheDocument();
105
+ });
106
+ });