@bevel-software/platform-core-frontend 0.15.1 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +16 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  33. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  34. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  35. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  36. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  37. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  38. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  39. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  40. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  41. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  42. package/src/modules/admin/components/group-members-path.ts +32 -0
  43. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  44. package/src/modules/admin/services/roles.api.ts +12 -1
  45. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  46. package/src/modules/auth/components/AccountPage.tsx +73 -54
  47. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  48. package/src/modules/auth/services/account.api.ts +78 -4
  49. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  57. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  58. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  59. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  60. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  61. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  62. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  63. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  64. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  65. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  66. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  67. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  68. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  69. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  70. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  71. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  72. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  73. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  74. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  75. package/src/modules/change-requests/services/propose.api.ts +97 -8
  76. package/src/modules/change-requests/utils/approval.ts +15 -0
  77. package/src/modules/change-requests/utils/author.ts +32 -0
  78. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  79. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  80. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  81. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  82. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  83. package/src/modules/git/services/error-messages.ts +12 -0
  84. package/src/modules/git/services/pr-prompts.ts +5 -5
  85. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  86. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  87. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  88. package/src/modules/layout/components/AppLayout.tsx +2 -0
  89. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  90. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  91. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  92. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  93. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  94. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  95. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  96. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  97. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  98. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  99. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  100. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  101. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  102. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  103. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  104. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  105. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  106. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  107. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  108. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  109. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  110. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  111. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  112. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  113. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  114. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  115. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  116. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  117. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  118. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  119. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  120. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  121. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  122. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  123. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  124. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  125. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  126. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  127. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  128. package/src/modules/library/__tests__/status.test.ts +82 -2
  129. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  130. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  131. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  132. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  133. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  134. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  135. package/src/modules/library/components/LibraryCard.tsx +146 -45
  136. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  137. package/src/modules/library/components/LibraryPage.tsx +172 -39
  138. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  139. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  140. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  141. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  142. package/src/modules/library/components/PageActions.tsx +11 -9
  143. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  144. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  145. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  146. package/src/modules/library/components/PluginExtras.tsx +140 -17
  147. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  148. package/src/modules/library/components/PluginPage.tsx +157 -41
  149. package/src/modules/library/components/PluginRows.tsx +286 -0
  150. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  151. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  152. package/src/modules/library/components/ShareButton.tsx +17 -0
  153. package/src/modules/library/components/SkillsTree.tsx +141 -28
  154. package/src/modules/library/components/TeamRoute.tsx +15 -0
  155. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  156. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  157. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  158. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  159. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  160. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  161. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  162. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  163. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  164. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  165. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  166. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  167. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  168. package/src/modules/library/routes/library-paths.ts +26 -28
  169. package/src/modules/library/services/library.api.ts +38 -20
  170. package/src/modules/library/services/plugins.api.ts +69 -8
  171. package/src/modules/library/services/teams.api.ts +15 -0
  172. package/src/modules/library/services/tools.api.ts +78 -0
  173. package/src/modules/library/state/library-data.tsx +170 -32
  174. package/src/modules/library/utils/personal-plugin.ts +13 -15
  175. package/src/modules/library/utils/plugin-entries.ts +134 -0
  176. package/src/modules/library/utils/plugin-summary.ts +75 -9
  177. package/src/modules/library/utils/status.ts +135 -33
  178. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  179. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  180. package/src/modules/onboarding/agent-clients.ts +55 -23
  181. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  182. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  183. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  184. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  185. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  186. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  187. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  188. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  189. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  190. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  191. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  192. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  193. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  194. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  195. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  196. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  197. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  198. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  199. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  200. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  201. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  202. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  203. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  204. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  205. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  206. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  207. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  208. package/src/modules/settings/services/github-facade.api.ts +23 -0
  209. package/src/modules/settings/settings-nav-items.tsx +10 -2
  210. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  211. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  212. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  213. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  214. package/src/modules/setup/components/SetupGate.tsx +16 -16
  215. package/src/modules/setup/components/SetupScreen.tsx +521 -43
  216. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  217. package/src/modules/setup/services/setup.api.ts +140 -3
  218. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  219. package/src/modules/setup/utils/root-folders.ts +46 -0
  220. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  221. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  232. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  233. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  234. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  235. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  236. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  237. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  238. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  239. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  240. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  241. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  242. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  243. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  244. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  245. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  246. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  247. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  248. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  249. package/src/modules/toolbar/services/external-api-keys.api.ts +6 -0
  250. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  251. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  252. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  254. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  255. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  256. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  257. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  258. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  259. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  260. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  261. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  262. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  263. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  264. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +331 -12
  265. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  266. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  267. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  268. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  269. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  270. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  271. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  272. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  273. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  274. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  275. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  276. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  277. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  279. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  280. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  281. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  282. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  283. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  284. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  285. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  286. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  287. package/src/modules/workspace/components/renderers/index.ts +53 -2
  288. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  289. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  290. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  291. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  292. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  294. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  295. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  296. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  297. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  298. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  299. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  300. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  301. package/src/modules/workspace/services/workspace.api.ts +57 -4
  302. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  303. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  304. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  305. package/src/modules/workspace/state/workspace.context.ts +125 -19
  306. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  307. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  308. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  309. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  310. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  311. package/src/modules/workspace/utils/file-trace.ts +50 -0
  312. package/src/modules/workspace/utils/fileTree.ts +112 -36
  313. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  314. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  315. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  316. package/src/modules/workspace/utils/uploadError.ts +29 -0
  317. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  318. package/src/shared/components/Button.tsx +16 -2
  319. package/src/shared/components/Dialog.tsx +27 -11
  320. package/src/shared/components/Menu.tsx +13 -1
  321. package/src/shared/components/PageShell.tsx +13 -8
  322. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  323. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  324. package/src/shared/components/index.ts +2 -0
  325. package/src/shared/components/useDismissableMenu.ts +32 -10
  326. package/src/shared/components/useFocusHandoff.ts +51 -0
  327. package/src/shared/components/useLatestRef.ts +28 -0
  328. package/src/shared/markdown/Markdown.tsx +12 -3
  329. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  330. package/src/shared/markdown/hrefs.ts +50 -0
  331. package/src/shared/marketplace-url.ts +33 -5
  332. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  333. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  334. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  335. package/src/shared/mcp/connect-snippets.ts +14 -9
  336. package/src/shared/mcp/index.ts +1 -1
  337. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  338. package/src/shared/theme/header.ts +75 -0
  339. package/src/shared/theme/measure.ts +7 -4
  340. package/src/shared/theme/tokens.css +25 -0
  341. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  342. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  343. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  344. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  345. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  346. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,202 +1,104 @@
1
1
  import { useCallback, useMemo, useRef, useState } from 'react';
2
2
  import { Outlet, useLocation, useNavigate } from 'react-router-dom';
3
+ import { isPersonalPluginFolder } from '@bevel-software/platform-shared';
3
4
  import { cn } from '../../../lib/utils';
4
5
  import { DOCUMENT_COLUMN, documentGutters } from '../../../shared/theme/measure';
5
- import { useAuth } from '../../auth/state/auth.context';
6
+ import { HEADER_COLUMN_TOP } from '../../../shared/theme/header';
6
7
  import { useAdmin } from '../../admin/state/admin.context';
7
8
  import { attentionOf, useLibrary, workspaceHasNoPlugins } from '../state/library-data';
8
9
  import { personalPluginName } from '../utils/personal-plugin';
9
- import {
10
- isPluginsIndexPath,
11
- libraryFilterForPath,
12
- pathForPluginsIndex,
13
- pathForLibraryFilter,
14
- } from '../routes/library-paths';
15
- import { isUngrouped, pluginCounts, pluginsOfItem, type LibraryFilter } from '../utils/status';
16
- import { pluginLabel, primaryFolderOf } from '../utils/plugin-summary';
10
+ import { libraryFilterForPath, pathForLibraryFilter } from '../routes/library-paths';
11
+ import { EVERYONE_TEAM, filterLibraryItems, pluginsOfItem, type LibraryFilter } from '../utils/status';
12
+ import { pathForGroupMembers } from '../../admin/components/group-members-path';
13
+ import { ownedLensOf, pluginEntriesFor } from '../utils/plugin-entries';
17
14
  import { LINK_COPIED_TOAST, LINK_COPY_FAILED_TOAST, copyToClipboard } from '../utils/clipboard';
18
15
  import { useLibraryToast } from '../state/toast.context';
19
16
  import { useSidebar } from '../../layout/state/sidebar';
20
17
  import { SidebarFrame } from '../../layout/components/SidebarFrame';
21
- import { useWorkspace } from '../../workspace/state/workspace.context';
22
- import { ManageAccessDialog } from '../../access/components/ManageAccessDialog';
23
18
  import { ConnectAgentPill } from '../../onboarding/components/ConnectAgentPill';
19
+ import { PullRequestsForMe } from '../../git/components/PullRequestsForMe';
20
+ import { IntegrationsSetupReminder } from './IntegrationsSetupReminder';
24
21
  import { PluginsSidebar, type SidebarContextTarget } from './PluginsSidebar';
25
- import { SkillsTree } from './SkillsTree';
22
+ import { PluginsTree, SkillsTree } from './SkillsTree';
26
23
  import { PluginsSidebarMenu } from './PluginsSidebarMenu';
27
- import { AddToPluginDialog } from './AddToPluginDialog';
28
- import { DeletePluginDialog } from './DeletePluginDialog';
29
24
  import { NewPluginDialog } from './NewPluginDialog';
30
25
 
31
26
  /**
32
- * The shell every Library page renders inside: the plugin nav on the left, the
33
- * page in the scrolling column on the right.
27
+ * The shell every Library page renders inside: the nav on the left, the page
28
+ * in the scrolling column on the right.
34
29
  *
35
30
  * It is also the ONE place the URL and the sidebar meet — the path becomes a
36
31
  * `LibraryFilter` on the way in, a click becomes a `navigate` on the way out.
37
32
  * Nothing else in the Library knows either mapping, which is why the gallery
38
33
  * can take its filter as a plain prop and the sidebar can hold no state.
34
+ *
35
+ * The nav lists LENSES and PLACES, never individual plugins: Everything and
36
+ * Owned by me, then the groups (Everyone first), then the two roots as file
37
+ * trees. A plugin — the caller's own space included — is reached through the
38
+ * page it is on: its row on Everything or a team's page, its folder in the
39
+ * Plugins tree. So the
40
+ * plugin verbs (add to, manage access, delete) live on the plugin page and
41
+ * the tree row, and the nav's own menu keeps only what the nav can answer:
42
+ * a link to the row, and a new plugin.
39
43
  */
40
44
  export function LibraryLayout() {
41
45
  const lib = useLibrary();
42
- const { items, pluginSummaries, reload, reloadPlugins } = lib;
46
+ const { items, pluginSummaries, teams, reload, reloadPlugins } = lib;
43
47
  const location = useLocation();
44
48
  const navigate = useNavigate();
45
- const { user } = useAuth();
46
49
  const { isAdmin } = useAdmin();
47
- const { kbDirName } = useWorkspace();
48
50
  const toast = useLibraryToast();
49
- const [newPluginOpen, setNewPluginOpen] = useState(false);
50
51
  /**
51
- * The sidebar's right-click menu, and the two sheets it can open. All three
52
- * live HERE rather than in `PluginsSidebar` because the verbs need the plugin
53
- * summaries and the workspace's KB dir — the sidebar is handed a list of
54
- * names and counts and knows neither. The sidebar reports the click; this
55
- * decides what is true about what was clicked.
52
+ * The New plugin dialog, with WHERE the plugin goes: `''` is the plugins
53
+ * root (the nav's own verbs), a path below it is the grouping folder a
54
+ * person right-clicked in the Plugins tree.
56
55
  */
56
+ const [newPlugin, setNewPlugin] = useState<{ parent: string } | null>(null);
57
57
  const [menu, setMenu] = useState<SidebarContextTarget | null>(null);
58
- /**
59
- * Captured whole at pick time, not looked up at render time: the menu closes
60
- * as it hands over, so by the time the dialog paints there is no `menu` left
61
- * to re-derive the plugin from.
62
- */
63
- const [addTo, setAddTo] = useState<{
64
- name: string;
65
- primaryPath: string;
66
- canWrite: boolean;
67
- } | null>(null);
68
- const [manageFolder, setManageFolder] = useState<string | null>(null);
69
- /**
70
- * The plugin whose delete confirmation is up — captured whole at pick time
71
- * for the same reason `addTo` is: the menu is gone by the time the dialog
72
- * paints, and the counts belong in the dialog's copy.
73
- */
74
- const [deleting, setDeleting] = useState<{
75
- name: string;
76
- skillCount: number;
77
- toolCount: number;
78
- } | null>(null);
79
- /**
80
- * The row the open menu came from. A ref, not state, because
81
- * `useDismissableMenu` wants a stable `RefObject` to return focus INTO on
82
- * Escape — re-rendering the menu to tell it about the row would defeat the
83
- * point.
84
- */
85
58
  const menuRow = useRef<HTMLElement | null>(null);
86
- /**
87
- * Whether the nav is hidden. The state lives in a module store because the
88
- * button that flips it sits in the top bar, outside this layout's tree —
89
- * and because Knowledge's copy of this sidebar is the same object, not a
90
- * second one. See `layout/state/sidebar.ts`.
91
- */
92
59
  const { collapsed } = useSidebar();
93
60
 
94
61
  const filter = libraryFilterForPath(location.pathname);
62
+ const personalLabel = personalPluginName();
95
63
 
96
64
  /**
97
- * The member rows: every plugin the caller can READ (or manages), whether or
98
- * not anything is in it yet. Counts come from the catalog, membership does
99
- * not — a freshly created plugin has no skills or tools, and deriving the
100
- * rows from the items alone made it vanish from the very nav that lists
101
- * the caller's plugins. Being in a plugin is what puts it in your MCP;
102
- * having content is not. The catalog still contributes names the summaries
103
- * miss (a per-file grant can surface one skill from an otherwise unreadable
104
- * folder), so the two witnesses are merged rather than either winning.
65
+ * One row per team: how much of the catalog the team can use, and — in
66
+ * orange, outranking the count — how many of its plugins' links lock its
67
+ * members out of a skill right now. The count is what the team's page will
68
+ * list: its plugin rows plus its cards, from the same two slices.
105
69
  */
106
- const plugins = useMemo(() => {
107
- const counts = new Map(pluginCounts(items).map((g) => [g.plugin, g.count]));
108
- const names = new Set<string>(counts.keys());
109
- for (const g of pluginSummaries) {
110
- if (g.canRead || g.canWrite) names.add(g.name);
111
- }
112
- return [...names]
113
- .sort((a, b) => a.localeCompare(b))
114
- .map((plugin) => {
115
- const attention = attentionOf(items, plugin, pluginSummaries);
116
- return {
117
- plugin,
118
- label: pluginLabel(plugin, pluginSummaries),
119
- count: counts.get(plugin) ?? 0,
120
- attention: attention.total,
121
- urgent: attention.brokenLinks > 0,
122
- };
123
- });
124
- }, [items, pluginSummaries]);
125
- /**
126
- * Plugins the caller cannot get into, alphabetical.
127
- *
128
- * `canRead` is the folder verdict; the catalog is the other witness, and it
129
- * wins when it disagrees. Access resolves closeness-first, so a per-file grant
130
- * can hand somebody one skill inside a folder they cannot read — showing that
131
- * plugin locked while its skill sits in the gallery above would be the Library
132
- * contradicting itself. Same rule as `PluginPage`'s member-vs-locked decision,
133
- * which is what keeps the row and the page it opens in agreement.
134
- */
135
- const lockedPlugins = useMemo(() => {
136
- // Membership by folder AND by link: a shared skill linked into a plugin
137
- // the caller cannot open still sits in the gallery under that plugin, so
138
- // the plugin is visible, not locked — or it would be listed twice.
139
- const visible = new Set(items.flatMap((i) => pluginsOfItem(i)));
140
- return pluginSummaries
141
- // A manager (canWrite via admin-rescue) is not locked out — their plugin
142
- // belongs with the ones they run, not below the gap.
143
- .filter((g) => !g.canRead && !g.canWrite && !visible.has(g.name))
144
- .map((g) => ({ name: g.name, label: g.displayName || g.name }))
145
- .sort((a, b) => a.label.localeCompare(b.label));
146
- }, [pluginSummaries, items]);
147
-
148
- const ownedCount = useMemo(() => items.filter((i) => i.owned).length, [items]);
149
- /**
150
- * Owned items that are waiting on their owner. This — not `ownedCount` — is
151
- * what earns the amber badge: 26 things you own is a fact about your library,
152
- * one of them being broken is a fact about your afternoon.
153
- */
154
- const ownedAttention = useMemo(
155
- () => items.filter((i) => i.owned && i.status.state !== 'ok').length,
156
- [items],
70
+ const teamRows = useMemo(
71
+ () =>
72
+ teams.map((team) => {
73
+ const teamFilter: LibraryFilter = { kind: 'team', group: team.name };
74
+ const plugins = pluginEntriesFor(items, pluginSummaries, teamFilter, teams, '', personalLabel);
75
+ const cards = filterLibraryItems(items, teamFilter, '', teams);
76
+ const urgent = plugins.reduce(
77
+ (n, p) => n + (p.name === null ? 0 : attentionOf(items, p.name, pluginSummaries).brokenLinks),
78
+ 0,
79
+ );
80
+ return { name: team.name, count: plugins.length + cards.length, urgent };
81
+ }),
82
+ [teams, items, pluginSummaries, personalLabel],
83
+ );
84
+ const { count: ownedCount, attention: ownedAttention } = useMemo(
85
+ () => ownedLensOf(items, pluginSummaries, teams, personalLabel),
86
+ [items, pluginSummaries, teams, personalLabel],
157
87
  );
158
- const ungroupedCount = useMemo(() => items.filter(isUngrouped).length, [items]);
159
88
  const attentionCount = useMemo(
160
89
  () => items.filter((i) => i.kind === 'integration' && i.status.state !== 'ok').length,
161
90
  [items],
162
91
  );
163
-
164
- /**
165
- * What the open menu is pointing at.
166
- *
167
- * A plugin row resolves to its summary, which is where the folder behind it
168
- * lives — and therefore whether `Add a skill or tool` and `Manage access`
169
- * have anything to act on at all. A LENS row resolves to nothing, because
170
- * neither lens is a folder: "Owned by me" and your own space are slices of
171
- * the catalog, and there is no `access.md` behind a slice. That is the same
172
- * call the plugin page's `PageActions` already makes when it hides `Share` on
173
- * the personal page, and the menu has to make it the same way or the two
174
- * surfaces disagree about what a lens is.
175
- *
176
- * `Manage access` stays UNGATED on `canWrite`, exactly as `Share` is: for a
177
- * non-writer the dialog renders read-only, which is precisely what "who is
178
- * this shared with?" should answer.
179
- */
180
- const menuFilter = menu?.filter ?? null;
181
- const menuPlugin = menuFilter?.kind === 'group' ? menuFilter.plugin : null;
182
- const menuSummary = useMemo(
183
- () => (menuPlugin ? pluginSummaries.find((g) => g.name === menuPlugin) : undefined),
184
- [pluginSummaries, menuPlugin],
92
+ const existingPlugins = useMemo(
93
+ () => [...new Set([...items.flatMap((i) => pluginsOfItem(i)), ...pluginSummaries.map((g) => g.name)])],
94
+ [items, pluginSummaries],
185
95
  );
186
- const menuFolder = menuSummary ? primaryFolderOf(menuSummary) : null;
187
96
 
188
97
  const openContextMenu = useCallback((target: SidebarContextTarget) => {
189
98
  menuRow.current = target.row;
190
99
  setMenu(target);
191
100
  }, []);
192
101
 
193
- /**
194
- * A link to a row's page — origin + the row's own route, so it is the URL
195
- * that row navigates to and not the one you happen to be standing on. The
196
- * clipboard can refuse outright (a non-secure origin, an unfocused document),
197
- * and a silent no-op is the worst possible answer to "copy this" — so the
198
- * toast tells the truth either way.
199
- */
200
102
  const copyLink = useCallback(
201
103
  async (target: LibraryFilter) => {
202
104
  const ok = await copyToClipboard(`${window.location.origin}${pathForLibraryFilter(target)}`);
@@ -207,41 +109,67 @@ export function LibraryLayout() {
207
109
 
208
110
  return (
209
111
  <div className="flex h-full min-h-0 bg-canvas text-ink">
210
- {/* The connect-your-agent CTA sits above the plugin list — the one row
211
- that has to be true before the rows under it mean anything. Passed
212
- IN rather than mounted by the frame: which reminder belongs at the
213
- top of this nav is the surface's call, and `SidebarFrame` is the
214
- app's generic consistency layer. Knowledge passes the same pill from
112
+ {/* The connect-your-agent CTA sits above the nav — the one row that has
113
+ to be true before the rows under it mean anything. Passed IN rather
114
+ than mounted by the frame: which reminder belongs at the top of this
115
+ nav is the surface's call, and `SidebarFrame` is the app's generic
116
+ consistency layer. Knowledge passes the same pill from
215
117
  `ResizableThreePaneLayout`, which is what keeps it one pill in one
216
118
  place — a person who skipped the welcome page and stayed in
217
119
  Knowledge still sees it. It renders nothing once onboarding is
218
- done. */}
219
- <SidebarFrame label="Library navigation" header={<ConnectAgentPill />}>
120
+ done. The change-request dock below the nav is the same one
121
+ Knowledge pins under its tree — the requests waiting on you are
122
+ the same whichever app you are in.
123
+
124
+ The footer is a GROUP, and both of its rows are passed here for the
125
+ same reason the header's pill is: the frame spaces them and draws
126
+ the one rule above them, and the surface decides what they are. The
127
+ setup reminder used to close the nav from inside `PluginsSidebar`,
128
+ which is how it and the dock came to disagree about where the
129
+ column's left edge is. */}
130
+ <SidebarFrame
131
+ label="Library navigation"
132
+ header={<ConnectAgentPill />}
133
+ footer={
134
+ <>
135
+ <IntegrationsSetupReminder
136
+ count={attentionCount}
137
+ onFinishSetup={() => navigate('/connect')}
138
+ />
139
+ <PullRequestsForMe />
140
+ </>
141
+ }
142
+ >
220
143
  <PluginsSidebar
221
144
  filter={filter}
222
145
  onSelect={(next) => navigate(pathForLibraryFilter(next))}
223
- plugins={plugins}
224
- lockedPlugins={lockedPlugins}
225
146
  ownedCount={ownedCount}
226
147
  ownedAttention={ownedAttention}
227
- personalPluginLabel={personalPluginName(user?.name)}
228
- ungroupedCount={ungroupedCount}
229
- attentionCount={attentionCount}
230
- onFinishSetup={() => navigate('/connect')}
231
- onCreatePlugin={() => setNewPluginOpen(true)}
232
- // The whole verdict, not just the role: the create-a-plugin row is a
233
- // claim that the workspace holds no plugins AT ALL, and that claim is
234
- // only honest once both plugin witnesses have settled successfully —
235
- // while they load (or after they fail) an empty list is an unanswered
236
- // question, not an untouched workspace.
148
+ teams={teamRows}
149
+ onCreatePlugin={() => setNewPlugin({ parent: '' })}
237
150
  canCreatePlugin={isAdmin && workspaceHasNoPlugins(lib)}
238
- pluginsIndexActive={isPluginsIndexPath(location.pathname)}
239
- onOpenPluginsIndex={() => navigate(pathForPluginsIndex())}
240
151
  onContextMenu={openContextMenu}
241
152
  skillsTree={<SkillsTree />}
153
+ pluginsTree={
154
+ <PluginsTree
155
+ onCreatePlugin={(parent) => setNewPlugin({ parent })}
156
+ // A plugin cannot hold another: the verb is offered on grouping
157
+ // folders only — the root and folders no listed plugin owns.
158
+ // Closed until the plugin list has loaded: an unknown list is
159
+ // not an empty one. Personal spaces are named by the same rule
160
+ // the endpoint refuses them by — the first segment below the
161
+ // root carries the personal prefix — so the tree never offers a
162
+ // parent the endpoint will not take.
163
+ isGroupingFolder={(rel) => {
164
+ if (lib.pluginsLoading || lib.pluginsError) return false;
165
+ const below = rel.split('/');
166
+ if (below.length >= 2 && isPersonalPluginFolder(below[1]!)) return false;
167
+ return !pluginSummaries.some((s) => s.folders.some((f) => rel === f || rel.startsWith(`${f}/`)));
168
+ }}
169
+ />
170
+ }
242
171
  />
243
172
  </SidebarFrame>
244
-
245
173
  {/* The nav's right-click menu — Knowledge's file tree has had one since it
246
174
  shipped, and two sidebars in one app should not answer the same
247
175
  gesture two different ways. Rendered HERE, outside the frame, because
@@ -252,109 +180,44 @@ export function LibraryLayout() {
252
180
  y={menu.y}
253
181
  label={menu.label}
254
182
  onClose={() => setMenu(null)}
255
- onAdd={
256
- menuPlugin && menuFolder && menuSummary
257
- ? () =>
258
- setAddTo({
259
- name: menuPlugin,
260
- primaryPath: menuFolder,
261
- canWrite: menuSummary.canWrite,
262
- })
263
- : undefined
264
- }
265
- onCreatePlugin={() => setNewPluginOpen(true)}
266
- onCopyLink={menuFilter ? () => void copyLink(menuFilter) : undefined}
267
- onManageAccess={menuFolder && kbDirName ? () => setManageFolder(menuFolder) : undefined}
268
- // The OWNER's verb, and only theirs — `isOwner` is the same verdict
269
- // the DELETE route enforces, so the affordance appears for exactly
270
- // the people the backend will let through.
271
- onDelete={
272
- menuSummary?.isOwner
273
- ? () =>
274
- setDeleting({
275
- name: menuSummary.name,
276
- skillCount: menuSummary.skillCount,
277
- toolCount: menuSummary.toolCount,
278
- })
183
+ onCreatePlugin={() => setNewPlugin({ parent: '' })}
184
+ onCopyLink={menu.filter ? () => void copyLink(menu.filter!) : undefined}
185
+ // A group's roster is an administrator's to edit, on the Groups &
186
+ // Members page. Everyone is not a group — it has no roster to open.
187
+ onManageMembers={
188
+ isAdmin && menu.filter?.kind === 'team' && menu.filter.group !== EVERYONE_TEAM
189
+ ? () => navigate(pathForGroupMembers((menu.filter as { group: string }).group))
279
190
  : undefined
280
191
  }
281
192
  returnFocusTo={menuRow}
282
193
  />
283
194
  )}
284
-
285
- {addTo && (
286
- <AddToPluginDialog
287
- name={addTo.name}
288
- primaryPath={addTo.primaryPath}
289
- canWrite={addTo.canWrite}
290
- // Every skill, not just this plugin's: a skill's id is its name and
291
- // ids are global, so that is the collision the create half must catch.
292
- existingSkills={items.filter((i) => i.kind === 'skill').map((i) => i.name)}
293
- onClose={() => setAddTo(null)}
294
- />
295
- )}
296
-
297
- {manageFolder && kbDirName && (
298
- <ManageAccessDialog
299
- entry={{
300
- name: manageFolder.split('/').pop() ?? manageFolder,
301
- relativePath: `${kbDirName}/${manageFolder}`,
302
- type: 'directory',
303
- }}
304
- onClose={() => {
305
- setManageFolder(null);
306
- // Granting through the dialog can settle a pending join request —
307
- // refresh the roster and the catalog together, exactly as the plugin
308
- // page does when its copy of this dialog closes.
309
- reloadPlugins();
310
- reload();
311
- }}
312
- />
313
- )}
314
-
315
- {deleting && (
316
- <DeletePluginDialog
317
- name={deleting.name}
318
- skillCount={deleting.skillCount}
319
- toolCount={deleting.toolCount}
320
- onClose={() => setDeleting(null)}
321
- onDeleted={() => {
322
- toast(`Deleted ${deleting.name}.`);
323
- // Standing inside the plugin that just ceased to exist would
324
- // render "This plugin doesn't exist yet" — the index is the
325
- // honest place to land. Any other page is unaffected.
326
- if (filter?.kind === 'group' && filter.plugin === deleting.name) {
327
- navigate(pathForPluginsIndex());
328
- }
329
- reload();
330
- reloadPlugins();
331
- }}
332
- />
333
- )}
334
-
335
- {newPluginOpen && (
195
+ {newPlugin && (
336
196
  <NewPluginDialog
337
- // Every name the workspace already knows, readable or not: creating
338
- // `Plugins/GTM` when a locked `GTM` exists would not make a plugin, it
339
- // would drop items into somebody else's.
340
- existing={[...new Set([...plugins.map((g) => g.plugin), ...pluginSummaries.map((g) => g.name)])]}
341
- onClose={() => setNewPluginOpen(false)}
197
+ existing={existingPlugins}
198
+ parent={newPlugin.parent}
199
+ onClose={() => setNewPlugin(null)}
342
200
  onCreated={() => {
343
201
  reload();
344
202
  reloadPlugins();
345
203
  }}
346
204
  />
347
205
  )}
348
-
349
206
  {/* The shared measure (`plans/05-knowledge-ui.md` D6). The pane stays the
350
207
  scroller so the scrollbar keeps sitting at its edge; the column
351
208
  inside it is the same 880px and the same side gutters Knowledge
352
209
  uses, so the two surfaces cannot report different widths at the same
353
- window width. Top padding is the one measure they deliberately do
354
- NOT share: Skills opens on a heading (34px), Knowledge on a tab
355
- strip (12px). */}
210
+ window width.
211
+
212
+ Top padding is shared now too. It used to be the one measure the two
213
+ surfaces deliberately did not share — 34px here against Knowledge's
214
+ 12px — and that difference was the reported bug: every Library page
215
+ opens on a title bar, and 34px put it 20px below the sidebar's
216
+ header row sitting right beside it. `HEADER_COLUMN_TOP` is the one
217
+ offset both columns open on; `HEADER_BAND` is the one height their
218
+ first rows are. */}
356
219
  <main className="min-w-0 flex-1 overflow-y-auto">
357
- <div className={cn(DOCUMENT_COLUMN, documentGutters(collapsed), 'pt-[34px]')}>
220
+ <div className={cn(DOCUMENT_COLUMN, documentGutters(collapsed), HEADER_COLUMN_TOP)}>
358
221
  <Outlet />
359
222
  </div>
360
223
  </main>