@bevel-software/platform-core-frontend 0.15.1 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (346) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +16 -9
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/events.test.ts +43 -0
  6. package/src/core/bootstrap.ts +11 -3
  7. package/src/core/events.ts +85 -3
  8. package/src/core/registry.ts +1 -1
  9. package/src/lib/__tests__/email.test.ts +44 -0
  10. package/src/lib/email.ts +37 -1
  11. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  12. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  16. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  20. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +721 -126
  21. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  22. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  23. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  24. package/src/modules/access/api.ts +140 -6
  25. package/src/modules/access/components/ManageAccessDialog.tsx +1299 -561
  26. package/src/modules/access/manage-access-affordance.ts +17 -0
  27. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  28. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  29. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  30. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  31. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  32. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  33. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  34. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  35. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  36. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  37. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  38. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  39. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  40. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  41. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  42. package/src/modules/admin/components/group-members-path.ts +32 -0
  43. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  44. package/src/modules/admin/services/roles.api.ts +12 -1
  45. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  46. package/src/modules/auth/components/AccountPage.tsx +73 -54
  47. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  48. package/src/modules/auth/services/account.api.ts +78 -4
  49. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  50. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  51. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  52. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  53. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  57. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  58. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  59. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  60. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  61. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  62. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  63. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  64. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  65. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  66. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  67. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  68. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  69. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  70. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  71. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  72. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  73. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  74. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  75. package/src/modules/change-requests/services/propose.api.ts +97 -8
  76. package/src/modules/change-requests/utils/approval.ts +15 -0
  77. package/src/modules/change-requests/utils/author.ts +32 -0
  78. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  79. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  80. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  81. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  82. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  83. package/src/modules/git/services/error-messages.ts +12 -0
  84. package/src/modules/git/services/pr-prompts.ts +5 -5
  85. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  86. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  87. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  88. package/src/modules/layout/components/AppLayout.tsx +2 -0
  89. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  90. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  91. package/src/modules/layout/components/SidebarFrame.tsx +108 -3
  92. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  93. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  94. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  95. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  96. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  97. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +103 -98
  98. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +20 -5
  99. package/src/modules/library/__tests__/LockedPluginView.test.tsx +97 -7
  100. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +13 -4
  101. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  102. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  103. package/src/modules/library/__tests__/PluginExtras.test.tsx +100 -9
  104. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  105. package/src/modules/library/__tests__/PluginPage.test.tsx +258 -6
  106. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +16 -56
  107. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +155 -152
  108. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  109. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  110. package/src/modules/library/__tests__/SkillPage.test.tsx +386 -80
  111. package/src/modules/library/__tests__/SkillsTree.test.tsx +293 -4
  112. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  113. package/src/modules/library/__tests__/ToolPage.test.tsx +87 -4
  114. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +173 -26
  115. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  116. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  117. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  118. package/src/modules/library/__tests__/library-data.stale.test.tsx +121 -28
  119. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  120. package/src/modules/library/__tests__/library-paths.test.ts +47 -4
  121. package/src/modules/library/__tests__/link-membership.test.ts +13 -4
  122. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  123. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  124. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  125. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  126. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  127. package/src/modules/library/__tests__/plugin-summary.test.ts +36 -1
  128. package/src/modules/library/__tests__/status.test.ts +82 -2
  129. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  130. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  131. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  132. package/src/modules/library/components/AddToPluginDialog.tsx +74 -18
  133. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  134. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  135. package/src/modules/library/components/LibraryCard.tsx +146 -45
  136. package/src/modules/library/components/LibraryLayout.tsx +119 -256
  137. package/src/modules/library/components/LibraryPage.tsx +172 -39
  138. package/src/modules/library/components/LinkSkillPanel.tsx +1 -3
  139. package/src/modules/library/components/LockedPluginView.tsx +62 -34
  140. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  141. package/src/modules/library/components/NewPluginDialog.tsx +16 -2
  142. package/src/modules/library/components/PageActions.tsx +11 -9
  143. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  144. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  145. package/src/modules/library/components/PersonalPluginPage.tsx +121 -22
  146. package/src/modules/library/components/PluginExtras.tsx +140 -17
  147. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  148. package/src/modules/library/components/PluginPage.tsx +157 -41
  149. package/src/modules/library/components/PluginRows.tsx +286 -0
  150. package/src/modules/library/components/PluginsSidebar.tsx +239 -263
  151. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  152. package/src/modules/library/components/ShareButton.tsx +17 -0
  153. package/src/modules/library/components/SkillsTree.tsx +141 -28
  154. package/src/modules/library/components/TeamRoute.tsx +15 -0
  155. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  156. package/src/modules/library/components/plugin-page-parts.tsx +103 -17
  157. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +6 -12
  158. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  159. package/src/modules/library/components/skill-page/SkillPage.tsx +274 -122
  160. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  161. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  162. package/src/modules/library/components/tool-page/ToolPage.tsx +106 -16
  163. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  164. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  165. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  166. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  167. package/src/modules/library/routes/WorkspaceItemRoute.tsx +77 -27
  168. package/src/modules/library/routes/library-paths.ts +26 -28
  169. package/src/modules/library/services/library.api.ts +38 -20
  170. package/src/modules/library/services/plugins.api.ts +69 -8
  171. package/src/modules/library/services/teams.api.ts +15 -0
  172. package/src/modules/library/services/tools.api.ts +78 -0
  173. package/src/modules/library/state/library-data.tsx +170 -32
  174. package/src/modules/library/utils/personal-plugin.ts +13 -15
  175. package/src/modules/library/utils/plugin-entries.ts +134 -0
  176. package/src/modules/library/utils/plugin-summary.ts +75 -9
  177. package/src/modules/library/utils/status.ts +135 -33
  178. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +8 -1
  179. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  180. package/src/modules/onboarding/agent-clients.ts +55 -23
  181. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  182. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  183. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  184. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  185. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  186. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  187. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  188. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  189. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  190. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  191. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  192. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  193. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  194. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  195. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  196. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  197. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  198. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  199. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  200. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  201. package/src/modules/settings/components/ClaudeConnectionCard.tsx +9 -24
  202. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  203. package/src/modules/settings/components/DeploymentPage.tsx +10 -30
  204. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  205. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +67 -4
  206. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  207. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  208. package/src/modules/settings/services/github-facade.api.ts +23 -0
  209. package/src/modules/settings/settings-nav-items.tsx +10 -2
  210. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  211. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  212. package/src/modules/setup/__tests__/setup.test.tsx +497 -4
  213. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  214. package/src/modules/setup/components/SetupGate.tsx +16 -16
  215. package/src/modules/setup/components/SetupScreen.tsx +521 -43
  216. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  217. package/src/modules/setup/services/setup.api.ts +140 -3
  218. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  219. package/src/modules/setup/utils/root-folders.ts +46 -0
  220. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  221. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  222. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  223. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  224. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  225. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  226. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  227. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  228. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  229. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  230. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  231. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  232. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  233. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  234. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  235. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  236. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +177 -118
  237. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  238. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  239. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  240. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +542 -42
  241. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  242. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  243. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  244. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  245. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  246. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  247. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  248. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  249. package/src/modules/toolbar/services/external-api-keys.api.ts +6 -0
  250. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  251. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  252. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  253. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  254. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  255. package/src/modules/workspace/__tests__/testFixtures.ts +5 -3
  256. package/src/modules/workspace/components/FileExplorer.tsx +1295 -191
  257. package/src/modules/workspace/components/FileRoute.tsx +353 -36
  258. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  259. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  260. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  261. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  262. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  263. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +731 -18
  264. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +331 -12
  265. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  266. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  267. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  268. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  269. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  270. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  271. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  272. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  273. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  274. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  275. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  276. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  277. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  278. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  279. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  280. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  281. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  282. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  283. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  284. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  285. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  286. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  287. package/src/modules/workspace/components/renderers/index.ts +53 -2
  288. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  289. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  290. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  291. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  292. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  293. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  294. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  295. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +22 -3
  296. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  297. package/src/modules/workspace/hooks/useWorkspaceState.ts +424 -66
  298. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  299. package/src/modules/workspace/routing/kb-routes.ts +206 -29
  300. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  301. package/src/modules/workspace/services/workspace.api.ts +57 -4
  302. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  303. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  304. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  305. package/src/modules/workspace/state/workspace.context.ts +125 -19
  306. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  307. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +220 -6
  308. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  309. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  310. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  311. package/src/modules/workspace/utils/file-trace.ts +50 -0
  312. package/src/modules/workspace/utils/fileTree.ts +112 -36
  313. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  314. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  315. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  316. package/src/modules/workspace/utils/uploadError.ts +29 -0
  317. package/src/shared/__tests__/marketplace-url.test.ts +6 -1
  318. package/src/shared/components/Button.tsx +16 -2
  319. package/src/shared/components/Dialog.tsx +27 -11
  320. package/src/shared/components/Menu.tsx +13 -1
  321. package/src/shared/components/PageShell.tsx +13 -8
  322. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  323. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  324. package/src/shared/components/index.ts +2 -0
  325. package/src/shared/components/useDismissableMenu.ts +32 -10
  326. package/src/shared/components/useFocusHandoff.ts +51 -0
  327. package/src/shared/components/useLatestRef.ts +28 -0
  328. package/src/shared/markdown/Markdown.tsx +12 -3
  329. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  330. package/src/shared/markdown/hrefs.ts +50 -0
  331. package/src/shared/marketplace-url.ts +33 -5
  332. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  333. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  334. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  335. package/src/shared/mcp/connect-snippets.ts +14 -9
  336. package/src/shared/mcp/index.ts +1 -1
  337. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  338. package/src/shared/theme/header.ts +75 -0
  339. package/src/shared/theme/measure.ts +7 -4
  340. package/src/shared/theme/tokens.css +25 -0
  341. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  342. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  343. package/src/modules/library/components/PluginsIndexPage.tsx +0 -270
  344. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  345. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  346. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,422 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import type { PrFileStatus, PullRequestSummary } from '@bevel-software/platform-shared';
4
+
5
+ /**
6
+ * A document or an image in a change request.
7
+ *
8
+ * The dialog used to answer a proposed pdf, deck or screenshot with one
9
+ * sentence — "there is no text to compare" — and ask its owner to approve
10
+ * bytes nobody had seen. Every one of those formats has a viewer on the file
11
+ * page, and a viewer needs only a workspace id and a path; a branch IS a
12
+ * workspace here. These tests pin what the pane now does: which BRANCH's
13
+ * bytes each case reads, the way back to the current version, the formats
14
+ * that still have no viewer, and the refusal a reader without access gets.
15
+ */
16
+
17
+ const detailMock = vi.hoisted(() => ({ fetchPrDetail: vi.fn() }));
18
+ vi.mock('../../pr/services/pr-detail.api', () => ({ fetchPrDetail: detailMock.fetchPrDetail }));
19
+
20
+ vi.mock('../services/change-requests.api', () => ({
21
+ readFileOnBranch: vi.fn(async () => 'text'),
22
+ }));
23
+ vi.mock('../../pr/services/pr-approvals.api', () => ({
24
+ approvePrFile: vi.fn(),
25
+ revertPrFile: vi.fn(),
26
+ unapprovePrFile: vi.fn(),
27
+ }));
28
+ vi.mock('../../pr/services/pr-merge.api', () => ({ mergePullRequest: vi.fn() }));
29
+ vi.mock('../../pr/services/pr-cancel.api', () => ({
30
+ cancelPullRequest: vi.fn(),
31
+ deleteChangeRequest: vi.fn(),
32
+ }));
33
+
34
+ /** The bytes every viewer here fetches go through `authFetch`. */
35
+ const apiMock = vi.hoisted(() => ({ authFetch: vi.fn() }));
36
+ vi.mock('../../../lib/api', () => ({ authFetch: apiMock.authFetch }));
37
+
38
+ /**
39
+ * Only the bootstrap is stubbed — `rawFileUrl` stays REAL, so the URLs
40
+ * asserted below are the ones the backend actually serves.
41
+ */
42
+ const workspaceMock = vi.hoisted(() => ({ getOrCreateWorkspace: vi.fn() }));
43
+ vi.mock('../../workspace/services/workspace.api', async (importOriginal) => ({
44
+ ...(await importOriginal<object>()),
45
+ getOrCreateWorkspace: workspaceMock.getOrCreateWorkspace,
46
+ }));
47
+
48
+ const accessMock = vi.hoisted(() => ({ fetchFileAccess: vi.fn() }));
49
+ vi.mock('../../access/api', async (importOriginal) => ({
50
+ ...(await importOriginal<object>()),
51
+ fetchFileAccess: accessMock.fetchFileAccess,
52
+ }));
53
+
54
+ /**
55
+ * pdf.js needs a worker thread and a real 2D canvas context, neither of which
56
+ * happy-dom has — mocked at the module boundary exactly as `PdfRenderer`'s own
57
+ * test does, so what is under test here stays the dialog's wiring.
58
+ */
59
+ const pdfjsMock = vi.hoisted(() => {
60
+ const page = {
61
+ getViewport: vi.fn(({ scale }: { scale: number }) => ({
62
+ width: 600 * scale,
63
+ height: 800 * scale,
64
+ })),
65
+ render: vi.fn(() => ({ promise: Promise.resolve(), cancel: vi.fn() })),
66
+ cleanup: vi.fn(),
67
+ };
68
+ const doc = {
69
+ numPages: 2,
70
+ getPage: vi.fn(async () => page),
71
+ destroy: vi.fn(async () => {}),
72
+ };
73
+ return {
74
+ getDocument: vi.fn(() => ({ promise: Promise.resolve(doc), destroy: vi.fn(async () => {}) })),
75
+ };
76
+ });
77
+ vi.mock('pdfjs-dist', () => ({
78
+ GlobalWorkerOptions: {},
79
+ getDocument: pdfjsMock.getDocument,
80
+ }));
81
+
82
+ import { ChangeRequestDialog } from '../components/ChangeRequestDialog';
83
+
84
+ const CR_BRANCH = 'ali.raza/the-brief';
85
+ const TARGET = 'main';
86
+ const KB = 'knowledge-base';
87
+
88
+ /** What `getOrCreateWorkspace` answers with — the workspace id IS the branch. */
89
+ const wsId = (branch: string) => encodeURIComponent(branch);
90
+
91
+ const CR: PullRequestSummary = {
92
+ number: 12,
93
+ title: 'The brief',
94
+ authorId: 'abc',
95
+ author: { login: 'user-abc', name: 'Ali' },
96
+ appAuthor: { name: 'Ali' },
97
+ branch: CR_BRANCH,
98
+ base: TARGET,
99
+ state: 'open',
100
+ createdAt: '2026-08-07T00:00:00.000Z',
101
+ touchedNodePaths: [],
102
+ review: { approvals: 0, changesRequested: 0, pendingLogins: [] },
103
+ url: '/change-requests/12',
104
+ } as unknown as PullRequestSummary;
105
+
106
+ function detailWith(files: { path: string; status: PrFileStatus; previousPath?: string }[]) {
107
+ return {
108
+ ...CR,
109
+ body: '',
110
+ headSha: 'h',
111
+ baseSha: 'b',
112
+ files: files.map((f) => ({
113
+ ...f,
114
+ additions: 0,
115
+ deletions: 0,
116
+ isBinary: true,
117
+ sha: '',
118
+ rawUrl: '',
119
+ })),
120
+ comments: [],
121
+ approvals: files.map((f) => ({
122
+ path: f.path,
123
+ eligibleApprovers: { roles: ['Admin'], users: [] },
124
+ approvedBy: [],
125
+ isApproved: true,
126
+ viewerCanApprove: true,
127
+ inMergeGate: false,
128
+ })),
129
+ mergeableInBevel: true,
130
+ mergeBlockedReasons: [],
131
+ mergeWarnings: [],
132
+ viewerCanBypassMerge: false,
133
+ viewerCanCancel: false,
134
+ };
135
+ }
136
+
137
+ /** Every raw-file fetch the viewers made, in order. */
138
+ const rawUrls = () => apiMock.authFetch.mock.calls.map((c) => String(c[0]));
139
+
140
+ beforeEach(() => {
141
+ detailMock.fetchPrDetail.mockReset();
142
+ apiMock.authFetch.mockReset();
143
+ apiMock.authFetch.mockResolvedValue({
144
+ ok: true,
145
+ status: 200,
146
+ blob: async () => new Blob(['bytes']),
147
+ arrayBuffer: async () => new ArrayBuffer(8),
148
+ });
149
+ workspaceMock.getOrCreateWorkspace.mockReset();
150
+ workspaceMock.getOrCreateWorkspace.mockImplementation(async (branch: string) => ({
151
+ workspace: { id: wsId(branch), kbDirName: KB },
152
+ fileTree: { name: KB, type: 'directory', children: [] },
153
+ }));
154
+ accessMock.fetchFileAccess.mockReset();
155
+ accessMock.fetchFileAccess.mockResolvedValue({ canRead: true, canDownload: true });
156
+ (globalThis.URL as unknown as { createObjectURL: unknown }).createObjectURL = vi.fn(
157
+ () => 'blob:fake-url',
158
+ );
159
+ (globalThis.URL as unknown as { revokeObjectURL: unknown }).revokeObjectURL = vi.fn();
160
+ });
161
+
162
+ describe('ChangeRequestDialog: a proposed document', () => {
163
+ it('renders an added pdf with the file page viewer, reading the request branch', async () => {
164
+ detailMock.fetchPrDetail.mockResolvedValue(
165
+ detailWith([{ path: 'Inbox/brief.pdf', status: 'added' }]),
166
+ );
167
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
168
+
169
+ // The PDF viewer itself, not a sentence about one.
170
+ expect(await screen.findByText('Page 1 of 2')).toBeInTheDocument();
171
+ expect(screen.queryByText(/There is no text to compare/)).not.toBeInTheDocument();
172
+
173
+ // The bytes come from the REQUEST's workspace, under the KB dir.
174
+ await waitFor(() =>
175
+ expect(rawUrls()).toContain(
176
+ `/api/workspace/${wsId(CR_BRANCH)}/file/raw?path=${encodeURIComponent(`${KB}/Inbox/brief.pdf`)}`,
177
+ ),
178
+ );
179
+ expect(screen.getByText('Proposed version')).toBeInTheDocument();
180
+ // Nothing to open: the file does not exist on the target branch.
181
+ expect(screen.queryByRole('link', { name: /Open the current version/ })).toBeNull();
182
+ });
183
+
184
+ it('renders a changed image and offers the current version on the target branch', async () => {
185
+ detailMock.fetchPrDetail.mockResolvedValue(
186
+ detailWith([{ path: 'Docs/logo.png', status: 'modified' }]),
187
+ );
188
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
189
+
190
+ const img = await screen.findByRole('img', { name: `${KB}/Docs/logo.png` });
191
+ expect(img).toHaveAttribute('src', 'blob:fake-url');
192
+ expect(rawUrls()).toContain(
193
+ `/api/workspace/${wsId(CR_BRANCH)}/file/raw?path=${encodeURIComponent(`${KB}/Docs/logo.png`)}`,
194
+ );
195
+
196
+ expect(screen.getByText('Proposed version')).toBeInTheDocument();
197
+ const link = screen.getByRole('link', { name: /Open the current version/ });
198
+ expect(link).toHaveAttribute('href', `/workspace/${TARGET}/${KB}/Docs/logo.png`);
199
+ // A new tab: leaving the dialog mid-review would lose the review context.
200
+ expect(link).toHaveAttribute('target', '_blank');
201
+ });
202
+
203
+ it('shows the CURRENT version of a binary the request does not touch', async () => {
204
+ detailMock.fetchPrDetail.mockResolvedValue(
205
+ detailWith([{ path: 'Docs/note.md', status: 'modified' }]),
206
+ );
207
+ render(
208
+ <ChangeRequestDialog
209
+ cr={CR}
210
+ scope={{ prefix: 'Docs', baseFiles: ['logo.png'] }}
211
+ onClose={() => {}}
212
+ onResolved={() => {}}
213
+ />,
214
+ );
215
+
216
+ fireEvent.click(await screen.findByTitle('Docs/logo.png'));
217
+
218
+ expect(await screen.findByText('Current version')).toBeInTheDocument();
219
+ expect(screen.queryByText(/No text to show/)).toBeNull();
220
+ // The untouched file's bytes are the TARGET branch's — the request has no
221
+ // version of it to propose.
222
+ await waitFor(() =>
223
+ expect(rawUrls()).toContain(
224
+ `/api/workspace/${wsId(TARGET)}/file/raw?path=${encodeURIComponent(`${KB}/Docs/logo.png`)}`,
225
+ ),
226
+ );
227
+ expect(screen.queryByRole('link', { name: /Open the current version/ })).toBeNull();
228
+ });
229
+
230
+ it('keeps the note for a format with no viewer, and offers the proposed bytes', async () => {
231
+ detailMock.fetchPrDetail.mockResolvedValue(
232
+ detailWith([{ path: 'Docs/minutes.odt', status: 'added' }]),
233
+ );
234
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
235
+
236
+ expect(await screen.findByText(/There is no text to compare/)).toBeInTheDocument();
237
+ const download = await screen.findByRole('button', { name: 'Download the proposed file' });
238
+
239
+ fireEvent.click(download);
240
+ await waitFor(() =>
241
+ expect(rawUrls()).toContain(
242
+ `/api/workspace/${wsId(CR_BRANCH)}/file/raw?path=${encodeURIComponent(`${KB}/Docs/minutes.odt`)}&download=1`,
243
+ ),
244
+ );
245
+ });
246
+
247
+ /**
248
+ * A viewport renderer (pdf, image, workbook) scrolls itself and collapses to
249
+ * 0px without a definite height; a document renderer wants the file page's
250
+ * edged frame instead. The dialog's pane has to hand each the shape it was
251
+ * written for.
252
+ */
253
+ it('gives a viewport viewer a definite height and a document viewer the file frame', async () => {
254
+ detailMock.fetchPrDetail.mockResolvedValue(
255
+ detailWith([{ path: 'Inbox/brief.pdf', status: 'added' }]),
256
+ );
257
+ const pdf = render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
258
+ const viewport = await screen.findByTestId('cr-preview-viewport');
259
+ expect(viewport.className).toContain('h-full');
260
+ expect(viewport.className).toContain('min-h-[60vh]');
261
+ expect(screen.queryByTestId('file-pane-card')).toBeNull();
262
+ pdf.unmount();
263
+
264
+ detailMock.fetchPrDetail.mockResolvedValue(
265
+ detailWith([{ path: 'Inbox/offer.eml', status: 'added' }]),
266
+ );
267
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
268
+ expect(await screen.findByTestId('file-pane-card')).toBeInTheDocument();
269
+ expect(screen.queryByTestId('cr-preview-viewport')).toBeNull();
270
+ });
271
+
272
+ /**
273
+ * A DELETION. The request's branch does not have the path at all, so reading
274
+ * it there would 404 into "Failed to load PDF (HTTP 404)"; the document
275
+ * under decision is the one still on the target branch, and the pane has to
276
+ * say that it is the one that would go.
277
+ */
278
+ it('shows a removed binary from the TARGET branch, named as a deletion', async () => {
279
+ detailMock.fetchPrDetail.mockResolvedValue(
280
+ detailWith([{ path: 'Inbox/brief.pdf', status: 'removed' }]),
281
+ );
282
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
283
+
284
+ expect(await screen.findByText('Page 1 of 2')).toBeInTheDocument();
285
+ expect(await screen.findByText(/This request DELETES this file/)).toBeInTheDocument();
286
+ expect(screen.getByText('Current version')).toBeInTheDocument();
287
+
288
+ // The TARGET branch's bytes, and never the request branch's — the path is
289
+ // gone there.
290
+ await waitFor(() =>
291
+ expect(rawUrls()).toContain(
292
+ `/api/workspace/${wsId(TARGET)}/file/raw?path=${encodeURIComponent(`${KB}/Inbox/brief.pdf`)}`,
293
+ ),
294
+ );
295
+ expect(rawUrls().some((u) => u.includes(wsId(CR_BRANCH)))).toBe(false);
296
+ // This pane already IS the current version.
297
+ expect(screen.queryByRole('link', { name: /Open the current version/ })).toBeNull();
298
+ });
299
+
300
+ /** A removed format with no viewer hands over the bytes that would go. */
301
+ it('offers the target branch bytes for a removed file no viewer renders', async () => {
302
+ detailMock.fetchPrDetail.mockResolvedValue(
303
+ detailWith([{ path: 'Docs/minutes.odt', status: 'removed' }]),
304
+ );
305
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
306
+
307
+ expect(await screen.findByText(/this request DELETES/)).toBeInTheDocument();
308
+ fireEvent.click(await screen.findByRole('button', { name: 'Download the file' }));
309
+ await waitFor(() =>
310
+ expect(rawUrls()).toContain(
311
+ `/api/workspace/${wsId(TARGET)}/file/raw?path=${encodeURIComponent(`${KB}/Docs/minutes.odt`)}&download=1`,
312
+ ),
313
+ );
314
+ });
315
+
316
+ /**
317
+ * A RENAMED file's current version is under its OLD name. Pointing the link
318
+ * at the proposed path on the target branch opens a 404 — the target branch
319
+ * has never had the file under that name.
320
+ */
321
+ it('opens a renamed binary current version under its OLD path', async () => {
322
+ detailMock.fetchPrDetail.mockResolvedValue(
323
+ detailWith([
324
+ { path: 'Docs/logo-2026.png', status: 'renamed', previousPath: 'Docs/logo.png' },
325
+ ]),
326
+ );
327
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
328
+
329
+ // The proposed bytes still come from the request's branch, under the NEW name.
330
+ await screen.findByRole('img', { name: `${KB}/Docs/logo-2026.png` });
331
+ expect(rawUrls()).toContain(
332
+ `/api/workspace/${wsId(CR_BRANCH)}/file/raw?path=${encodeURIComponent(`${KB}/Docs/logo-2026.png`)}`,
333
+ );
334
+
335
+ expect(screen.getByText('Proposed version')).toBeInTheDocument();
336
+ expect(screen.getByRole('link', { name: /Open the current version/ })).toHaveAttribute(
337
+ 'href',
338
+ `/workspace/${TARGET}/${KB}/Docs/logo.png`,
339
+ );
340
+ });
341
+
342
+ /** A rename with no `previousPath` has no current version to point at. */
343
+ it('offers no current-version link for a rename without an old path', async () => {
344
+ detailMock.fetchPrDetail.mockResolvedValue(
345
+ detailWith([{ path: 'Docs/logo-2026.png', status: 'renamed' }]),
346
+ );
347
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
348
+
349
+ await screen.findByRole('img', { name: `${KB}/Docs/logo-2026.png` });
350
+ expect(screen.getByText('Proposed version')).toBeInTheDocument();
351
+ expect(screen.queryByRole('link', { name: /Open the current version/ })).toBeNull();
352
+ });
353
+
354
+ /**
355
+ * A branch that cannot be opened has to be SAID on the download path too.
356
+ * Rendering nothing under a note that promises the bytes reads as a missing
357
+ * button rather than as the branch problem it is.
358
+ */
359
+ it('says so when the branch cannot be opened for a no-viewer download', async () => {
360
+ workspaceMock.getOrCreateWorkspace.mockRejectedValue(new Error('no such branch'));
361
+ detailMock.fetchPrDetail.mockResolvedValue(
362
+ detailWith([{ path: 'Docs/minutes.odt', status: 'added' }]),
363
+ );
364
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
365
+
366
+ expect(await screen.findByText(/branch couldn't be opened/)).toBeInTheDocument();
367
+ expect(screen.queryByRole('button', { name: /Download/ })).toBeNull();
368
+ });
369
+
370
+ /**
371
+ * The no-viewer path asks the SAME access question as the viewer pane. It
372
+ * used to ask nothing at all, so a restricted `.zip` offered a live Download
373
+ * that answered a click with a bare "Download failed (HTTP 403)" — the raw
374
+ * endpoint's gate holding, but nothing the file page would ever say.
375
+ */
376
+ it('refuses the no-viewer download when the reader may not read the file', async () => {
377
+ accessMock.fetchFileAccess.mockResolvedValue({ canRead: false, canDownload: false });
378
+ detailMock.fetchPrDetail.mockResolvedValue(
379
+ detailWith([{ path: 'Docs/minutes.odt', status: 'added' }]),
380
+ );
381
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
382
+
383
+ expect(await screen.findByText("You don't have access to this file")).toBeInTheDocument();
384
+ expect(screen.queryByRole('button', { name: /Download/ })).toBeNull();
385
+ // …and the bytes were never asked for.
386
+ expect(rawUrls()).toHaveLength(0);
387
+ });
388
+
389
+ /**
390
+ * Readable but not downloadable: the button stays, disabled, with its
391
+ * reason — `DownloadFileButton`'s own rule, the same one the file page
392
+ * feeds it.
393
+ */
394
+ it('disables the no-viewer download when the reader may not download it', async () => {
395
+ accessMock.fetchFileAccess.mockResolvedValue({ canRead: true, canDownload: false });
396
+ detailMock.fetchPrDetail.mockResolvedValue(
397
+ detailWith([{ path: 'Docs/minutes.odt', status: 'added' }]),
398
+ );
399
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
400
+
401
+ const download = await screen.findByRole('button', { name: 'Download the proposed file' });
402
+ expect(download).toBeDisabled();
403
+ expect(download).toHaveAttribute(
404
+ 'title',
405
+ 'You do not have download permission for this file.',
406
+ );
407
+ });
408
+
409
+ it('refuses the same way the file page does when the reader may not read it', async () => {
410
+ accessMock.fetchFileAccess.mockResolvedValue({ canRead: false, canDownload: false });
411
+ detailMock.fetchPrDetail.mockResolvedValue(
412
+ detailWith([{ path: 'Board/deck.pptx', status: 'added' }]),
413
+ );
414
+ render(<ChangeRequestDialog cr={CR} onClose={() => {}} onResolved={() => {}} />);
415
+
416
+ expect(await screen.findByText("You don't have access to this file")).toBeInTheDocument();
417
+ expect(screen.getByText(/is restricted\. Ask an owner to grant you read access\./)).
418
+ toBeInTheDocument();
419
+ // …and the bytes were never asked for.
420
+ expect(rawUrls()).toHaveLength(0);
421
+ });
422
+ });