@bevel-software/platform-core-frontend 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +202 -0
- package/package.json +70 -0
- package/src/core/CoreAppShell.tsx +444 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +95 -0
- package/src/core/events.ts +29 -0
- package/src/core/registry.ts +336 -0
- package/src/css-side-effect-imports.d.ts +7 -0
- package/src/html-extensions.ts +12 -0
- package/src/index.css +49 -0
- package/src/index.ts +23 -0
- package/src/lib/api.ts +57 -0
- package/src/lib/utils.ts +138 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +130 -0
- package/src/modules/access/__tests__/useFileAccess.test.tsx +253 -0
- package/src/modules/access/api.ts +205 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +31 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +1232 -0
- package/src/modules/access/components/NodeOwnersBanner.tsx +30 -0
- package/src/modules/access/hooks/useFileAccess.ts +151 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +943 -0
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +74 -0
- package/src/modules/admin/services/admin.api.ts +92 -0
- package/src/modules/admin/services/roles.api.ts +136 -0
- package/src/modules/admin/state/admin.context.tsx +223 -0
- package/src/modules/auth/components/LoginScreen.tsx +135 -0
- package/src/modules/auth/hooks/useAuthState.ts +59 -0
- package/src/modules/auth/services/auth.api.ts +24 -0
- package/src/modules/auth/services/microsoft-oauth.ts +57 -0
- package/src/modules/auth/state/auth.context.ts +18 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +347 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +201 -0
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +82 -0
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +441 -0
- package/src/modules/git/__tests__/git.api.test.ts +113 -0
- package/src/modules/git/__tests__/pr.api.test.ts +44 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +212 -0
- package/src/modules/git/components/BranchSwitcher.tsx +527 -0
- package/src/modules/git/components/DiffView.tsx +30 -0
- package/src/modules/git/components/FileComparisonPanel.tsx +377 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +320 -0
- package/src/modules/git/components/ProtectedBranchBanner.tsx +42 -0
- package/src/modules/git/components/PullNeededBanner.tsx +204 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +244 -0
- package/src/modules/git/components/UnifiedDiffView.tsx +37 -0
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +99 -0
- package/src/modules/git/hooks/useAutoPullUpdates.ts +121 -0
- package/src/modules/git/hooks/useGitState.ts +335 -0
- package/src/modules/git/services/__tests__/error-messages.test.ts +134 -0
- package/src/modules/git/services/error-messages.ts +257 -0
- package/src/modules/git/services/git.api.ts +163 -0
- package/src/modules/git/services/pr-prompts.ts +159 -0
- package/src/modules/git/services/pr.api.ts +39 -0
- package/src/modules/git/state/auto-update.context.ts +21 -0
- package/src/modules/git/state/git.context.ts +82 -0
- package/src/modules/layout/components/AppLayout.tsx +40 -0
- package/src/modules/layout/components/DemoBanner.tsx +57 -0
- package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +153 -0
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +203 -0
- package/src/modules/layout/components/SlideOverlay.tsx +224 -0
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +77 -0
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +57 -0
- package/src/modules/layout/hooks/useMediaQuery.ts +23 -0
- package/src/modules/layout/state/__tests__/layout.context.test.tsx +39 -0
- package/src/modules/layout/state/layout.context.ts +46 -0
- package/src/modules/library/__tests__/DetailDialog.test.tsx +200 -0
- package/src/modules/library/__tests__/diff.test.ts +62 -0
- package/src/modules/library/__tests__/loadout.test.tsx +72 -0
- package/src/modules/library/__tests__/status.test.ts +117 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +47 -0
- package/src/modules/library/components/CompareView.tsx +357 -0
- package/src/modules/library/components/DetailDialog.tsx +566 -0
- package/src/modules/library/components/GearIcon.tsx +12 -0
- package/src/modules/library/components/LibraryCard.tsx +132 -0
- package/src/modules/library/components/LibraryPage.tsx +254 -0
- package/src/modules/library/components/LoadoutSidebar.tsx +156 -0
- package/src/modules/library/components/StatusGem.tsx +21 -0
- package/src/modules/library/components/SuggestChange.tsx +171 -0
- package/src/modules/library/components/particles.ts +50 -0
- package/src/modules/library/hooks/useLibraryData.ts +119 -0
- package/src/modules/library/hooks/useSkillDetail.ts +74 -0
- package/src/modules/library/library.css +320 -0
- package/src/modules/library/services/library.api.ts +164 -0
- package/src/modules/library/state/loadout.tsx +129 -0
- package/src/modules/library/state/toast.tsx +42 -0
- package/src/modules/library/utils/diff.ts +102 -0
- package/src/modules/library/utils/status.ts +116 -0
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +93 -0
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +158 -0
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +44 -0
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +360 -0
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +85 -0
- package/src/modules/pr/__tests__/parsePatch.test.ts +104 -0
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +72 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +193 -0
- package/src/modules/pr/components/PrApprovalBadge.tsx +80 -0
- package/src/modules/pr/components/PrCancelButton.tsx +99 -0
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +119 -0
- package/src/modules/pr/components/PrCommentComposer.tsx +92 -0
- package/src/modules/pr/components/PrCommentThread.tsx +168 -0
- package/src/modules/pr/components/PrCommentsPanel.tsx +143 -0
- package/src/modules/pr/components/PrDiffPane.tsx +425 -0
- package/src/modules/pr/components/PrFileRow.tsx +164 -0
- package/src/modules/pr/components/PrFilesList.tsx +53 -0
- package/src/modules/pr/components/PrHeader.tsx +45 -0
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +58 -0
- package/src/modules/pr/components/PrMergeButton.tsx +268 -0
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +112 -0
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +110 -0
- package/src/modules/pr/components/PrViewer.tsx +364 -0
- package/src/modules/pr/hooks/usePrViewerState.ts +150 -0
- package/src/modules/pr/services/pr-approvals.api.ts +31 -0
- package/src/modules/pr/services/pr-cancel.api.ts +19 -0
- package/src/modules/pr/services/pr-comments.api.ts +45 -0
- package/src/modules/pr/services/pr-detail.api.ts +17 -0
- package/src/modules/pr/services/pr-merge.api.ts +53 -0
- package/src/modules/pr/services/pr-open.api.ts +30 -0
- package/src/modules/pr/state/pr-viewer.context.ts +34 -0
- package/src/modules/pr/utils/bucketize-comments.ts +55 -0
- package/src/modules/pr/utils/parsePatch.ts +57 -0
- package/src/modules/review/__tests__/review.api.test.ts +121 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +15 -0
- package/src/modules/review/components/DiffViewer.tsx +78 -0
- package/src/modules/review/components/MarkdownDiffViewer.tsx +263 -0
- package/src/modules/review/components/ReviewFileRow.tsx +114 -0
- package/src/modules/review/components/ReviewPanel.tsx +260 -0
- package/src/modules/review/components/ReviewPanelSurface.tsx +52 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +106 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +88 -0
- package/src/modules/review/hooks/useReviewState.ts +256 -0
- package/src/modules/review/services/review.api.ts +72 -0
- package/src/modules/review/state/ReviewProvider.tsx +28 -0
- package/src/modules/review/state/review.context.ts +29 -0
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +488 -0
- package/src/modules/secrets-vault/components/SecretsPage.tsx +276 -0
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +362 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +51 -0
- package/src/modules/secrets-vault/services/connect.api.ts +113 -0
- package/src/modules/secrets-vault/services/secrets.api.ts +82 -0
- package/src/modules/secrets-vault/services/tool-secrets.api.ts +116 -0
- package/src/modules/toolbar/components/AdminMenu.tsx +250 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +108 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -0
- package/src/modules/toolbar/components/Toolbar.tsx +123 -0
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +122 -0
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +353 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +65 -0
- package/src/modules/tools/ToolsExplorerPage.tsx +380 -0
- package/src/modules/workflow/hooks/useEventBusSubscription.ts +24 -0
- package/src/modules/workflow/hooks/useFileLock.ts +430 -0
- package/src/modules/workflow/services/lock.api.ts +139 -0
- package/src/modules/workflow/state/EventBusFocusBinder.tsx +25 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +232 -0
- package/src/modules/workflow/state/event-bus.context.ts +75 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +54 -0
- package/src/modules/workspace/__tests__/useWorkspaceState.test.ts +91 -0
- package/src/modules/workspace/components/EditorTabs.tsx +384 -0
- package/src/modules/workspace/components/FileExplorer.tsx +1068 -0
- package/src/modules/workspace/components/FileRoute.tsx +392 -0
- package/src/modules/workspace/components/FileViewer.tsx +906 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +241 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +666 -0
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +330 -0
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +492 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +174 -0
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +87 -0
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +231 -0
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +50 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +287 -0
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +252 -0
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +268 -0
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +81 -0
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +86 -0
- package/src/modules/workspace/components/renderers/ToolForm.tsx +404 -0
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +417 -0
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +157 -0
- package/src/modules/workspace/components/renderers/__tests__/CsvRenderer.test.ts +57 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +95 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +328 -0
- package/src/modules/workspace/components/renderers/__tests__/PdfRenderer.test.tsx +167 -0
- package/src/modules/workspace/components/renderers/__tests__/htmlSandbox.test.ts +318 -0
- package/src/modules/workspace/components/renderers/csvUtils.ts +76 -0
- package/src/modules/workspace/components/renderers/htmlSandbox.ts +332 -0
- package/src/modules/workspace/components/renderers/index.ts +39 -0
- package/src/modules/workspace/components/renderers/types.ts +27 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +298 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +1315 -0
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +99 -0
- package/src/modules/workspace/routing/kb-routes.ts +266 -0
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +72 -0
- package/src/modules/workspace/services/workspace.api.ts +185 -0
- package/src/modules/workspace/state/workspace.context.ts +235 -0
- package/src/modules/workspace/utils/__tests__/frontmatter.test.ts +107 -0
- package/src/modules/workspace/utils/diff.ts +53 -0
- package/src/modules/workspace/utils/fileTree.ts +179 -0
- package/src/modules/workspace/utils/frontmatter.ts +80 -0
- package/src/modules/workspace/utils/readDroppedEntries.ts +119 -0
- package/src/modules/workspace/utils/tab-persistence.ts +23 -0
- package/src/shared/components/Dialog.tsx +198 -0
- package/src/shared/components/PageShell.tsx +51 -0
- package/src/shared/components/useModalLayer.ts +35 -0
- package/src/shared/markdown/Markdown.tsx +62 -0
- package/src/test-setup.ts +59 -0
|
@@ -0,0 +1,943 @@
|
|
|
1
|
+
import { useCallback, useEffect, useId, useRef, useState } from 'react';
|
|
2
|
+
import { Check, Loader2, Pencil, Plus, Trash2, X } from 'lucide-react';
|
|
3
|
+
import { PageShell } from '../../../shared/components/PageShell';
|
|
4
|
+
import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
|
|
5
|
+
import { useAdmin } from '../state/admin.context';
|
|
6
|
+
import {
|
|
7
|
+
addMember,
|
|
8
|
+
createRole,
|
|
9
|
+
deleteRole,
|
|
10
|
+
fetchRoles,
|
|
11
|
+
removeMember,
|
|
12
|
+
renameRole,
|
|
13
|
+
RolesApiError,
|
|
14
|
+
type RoleRosterEntry,
|
|
15
|
+
} from '../services/roles.api';
|
|
16
|
+
import { suggestPrincipals } from '../../access/api';
|
|
17
|
+
|
|
18
|
+
/** The default-branch workspace id — roles are managed there (admin status derives from it). */
|
|
19
|
+
const ROLES_WORKSPACE_ID = encodeURIComponent(DEFAULT_BRANCH);
|
|
20
|
+
|
|
21
|
+
const EMAIL_RE = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
|
|
22
|
+
|
|
23
|
+
// Mirror of the backend's canonicalRoleName (access-control.service.ts) so an
|
|
24
|
+
// optimistic create can compute the same canonical the server will assign,
|
|
25
|
+
// keeping the placeholder card's identity stable until the roster reconciles.
|
|
26
|
+
function canonicalRoleName(name: string): string {
|
|
27
|
+
return name.trim().toLowerCase().replace(/\s+/g, ' ');
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
// Advisory client-side validation for a new role name. Mirrors the backend
|
|
31
|
+
// invariants so the user gets instant feedback; the server still has final say.
|
|
32
|
+
function validateNewRoleName(name: string): string | null {
|
|
33
|
+
const trimmed = name.trim();
|
|
34
|
+
if (!trimmed) return 'Enter a role name.';
|
|
35
|
+
const lower = trimmed.toLowerCase();
|
|
36
|
+
if (lower === 'deny' || lower === 'everyone') {
|
|
37
|
+
return `"${trimmed}" is a reserved name.`;
|
|
38
|
+
}
|
|
39
|
+
if (/[:#<>]/.test(trimmed)) return 'A role name can’t contain : # < >.';
|
|
40
|
+
if (trimmed.startsWith('-')) return 'A role name can’t start with "-".';
|
|
41
|
+
return null;
|
|
42
|
+
}
|
|
43
|
+
|
|
44
|
+
function errMessage(err: unknown, fallback: string): string {
|
|
45
|
+
if (err instanceof Error) return err.message;
|
|
46
|
+
return fallback;
|
|
47
|
+
}
|
|
48
|
+
|
|
49
|
+
function initials(value: string): string {
|
|
50
|
+
const cleaned = value.trim();
|
|
51
|
+
if (!cleaned) return '?';
|
|
52
|
+
const [name] = cleaned.split('@');
|
|
53
|
+
const parts = name.split(/[.\s_-]+/).filter(Boolean);
|
|
54
|
+
if (parts.length >= 2) return (parts[0][0] + parts[1][0]).toUpperCase();
|
|
55
|
+
return name.slice(0, 2).toUpperCase();
|
|
56
|
+
}
|
|
57
|
+
|
|
58
|
+
interface DeleteTarget {
|
|
59
|
+
role: RoleRosterEntry;
|
|
60
|
+
}
|
|
61
|
+
|
|
62
|
+
interface SelfRemoveTarget {
|
|
63
|
+
canonical: string;
|
|
64
|
+
email: string;
|
|
65
|
+
}
|
|
66
|
+
|
|
67
|
+
/**
|
|
68
|
+
* Roles & Members, routed standalone at `/roles-and-members` (below the
|
|
69
|
+
* persistent toolbar). Admin-gated: non-admins get a clear "Admins only"
|
|
70
|
+
* state instead of the roster (the backend enforces the same gate on every
|
|
71
|
+
* roles endpoint — this is presentation, not the security boundary).
|
|
72
|
+
*/
|
|
73
|
+
export function AdminRolesPage() {
|
|
74
|
+
const { isAdmin } = useAdmin();
|
|
75
|
+
const [roster, setRoster] = useState<RoleRosterEntry[]>([]);
|
|
76
|
+
const [loading, setLoading] = useState(true);
|
|
77
|
+
const [error, setError] = useState<string | null>(null);
|
|
78
|
+
|
|
79
|
+
// Optimistic list reshaping. A pending create appends a placeholder card; a
|
|
80
|
+
// pending delete hides the card by canonical. Both reconcile against the
|
|
81
|
+
// authoritative roster each mutation returns (or roll back on error).
|
|
82
|
+
const [pendingCreates, setPendingCreates] = useState<RoleRosterEntry[]>([]);
|
|
83
|
+
const [pendingDeletes, setPendingDeletes] = useState<Set<string>>(new Set());
|
|
84
|
+
// Delete errors, keyed by canonical. Owned here (not on the card) because a
|
|
85
|
+
// delete optimistically unmounts the card before the commit settles; on
|
|
86
|
+
// failure the card is restored as a NEW instance, so a card-local setError
|
|
87
|
+
// would land on the unmounted one and vanish. Parent-owned, it survives the
|
|
88
|
+
// hide→restore cycle and reaches the restored card by canonical.
|
|
89
|
+
const [deleteErrors, setDeleteErrors] = useState<Record<string, string>>({});
|
|
90
|
+
|
|
91
|
+
// Bump on every load so a stale in-flight response never overwrites the
|
|
92
|
+
// current roster.
|
|
93
|
+
const requestId = useRef(0);
|
|
94
|
+
|
|
95
|
+
// Load the roster on mount (and again if admin status resolves later —
|
|
96
|
+
// AdminProvider fetches admin status asynchronously, so `isAdmin` can flip
|
|
97
|
+
// to true after the first render). All setState happens in the async
|
|
98
|
+
// callbacks — never synchronously in the effect body — so this stays clear
|
|
99
|
+
// of react-hooks/set-state-in-effect. `loading` starts true, so the spinner
|
|
100
|
+
// is already showing until the first response lands.
|
|
101
|
+
useEffect(() => {
|
|
102
|
+
if (!isAdmin) return;
|
|
103
|
+
const myReq = ++requestId.current;
|
|
104
|
+
let active = true;
|
|
105
|
+
fetchRoles()
|
|
106
|
+
.then((rows) => {
|
|
107
|
+
if (!active || myReq !== requestId.current) return;
|
|
108
|
+
setRoster(rows);
|
|
109
|
+
setError(null);
|
|
110
|
+
})
|
|
111
|
+
.catch((err) => {
|
|
112
|
+
if (!active || myReq !== requestId.current) return;
|
|
113
|
+
setError(errMessage(err, 'Failed to load roles'));
|
|
114
|
+
})
|
|
115
|
+
.finally(() => {
|
|
116
|
+
if (active && myReq === requestId.current) setLoading(false);
|
|
117
|
+
});
|
|
118
|
+
return () => {
|
|
119
|
+
active = false;
|
|
120
|
+
};
|
|
121
|
+
}, [isAdmin]);
|
|
122
|
+
|
|
123
|
+
// Each mutation returns the fresh roster — set it directly (refetch-only) and
|
|
124
|
+
// reconcile the optimistic sets in the same update, while the authoritative
|
|
125
|
+
// rows are in hand: drop a pending create once its real card appears, and a
|
|
126
|
+
// pending delete once the card is actually gone. Doing this here (rather than
|
|
127
|
+
// in a roster-watching effect) avoids effect-driven cascading setState — and
|
|
128
|
+
// a placeholder double-listing, or a no-op/failed delete hiding a card.
|
|
129
|
+
const applyRoster = useCallback((rows: RoleRosterEntry[]) => {
|
|
130
|
+
// Bump so any in-flight load() result is dropped in favour of this fresher
|
|
131
|
+
// mutation response.
|
|
132
|
+
requestId.current++;
|
|
133
|
+
setRoster(rows);
|
|
134
|
+
// The bump above makes the superseded fetch's `.finally` skip its
|
|
135
|
+
// `setLoading(false)` (its req id no longer matches), so clear the page
|
|
136
|
+
// load state here — otherwise a mutation landing mid-load leaves the page
|
|
137
|
+
// stuck spinning, or showing a stale load error under fresh rows.
|
|
138
|
+
setLoading(false);
|
|
139
|
+
setError(null);
|
|
140
|
+
const present = new Set(rows.map((r) => r.canonical));
|
|
141
|
+
setPendingCreates((prev) => {
|
|
142
|
+
if (prev.length === 0) return prev;
|
|
143
|
+
const next = prev.filter((c) => !present.has(c.canonical));
|
|
144
|
+
return next.length === prev.length ? prev : next;
|
|
145
|
+
});
|
|
146
|
+
setPendingDeletes((prev) => {
|
|
147
|
+
if (prev.size === 0) return prev;
|
|
148
|
+
const next = new Set([...prev].filter((c) => present.has(c)));
|
|
149
|
+
return next.size === prev.size ? prev : next;
|
|
150
|
+
});
|
|
151
|
+
}, []);
|
|
152
|
+
|
|
153
|
+
// Optimistic create: show a placeholder card immediately, fire the commit in
|
|
154
|
+
// the background, reconcile (or roll back the placeholder on error).
|
|
155
|
+
const createOptimistic = useCallback(
|
|
156
|
+
async (displayName: string): Promise<string | null> => {
|
|
157
|
+
const canonical = canonicalRoleName(displayName);
|
|
158
|
+
// No client-side duplicate guard: a reserved/duplicate name is left to the
|
|
159
|
+
// server, which rolls the placeholder back and surfaces its precise error.
|
|
160
|
+
const placeholder: RoleRosterEntry = {
|
|
161
|
+
canonical,
|
|
162
|
+
displayName: displayName.trim(),
|
|
163
|
+
members: [],
|
|
164
|
+
isAdmin: false,
|
|
165
|
+
referencedBy: [],
|
|
166
|
+
};
|
|
167
|
+
setPendingCreates((prev) => [...prev, placeholder]);
|
|
168
|
+
try {
|
|
169
|
+
const rows = await createRole(displayName.trim());
|
|
170
|
+
applyRoster(rows);
|
|
171
|
+
return null;
|
|
172
|
+
} catch (err) {
|
|
173
|
+
setPendingCreates((prev) => prev.filter((c) => c.canonical !== canonical));
|
|
174
|
+
return errMessage(err, 'Failed to create role');
|
|
175
|
+
}
|
|
176
|
+
},
|
|
177
|
+
[applyRoster],
|
|
178
|
+
);
|
|
179
|
+
|
|
180
|
+
// Optimistic delete: hide the card immediately, fire the commit, reconcile
|
|
181
|
+
// (or roll back the hide on error).
|
|
182
|
+
const deleteOptimistic = useCallback(
|
|
183
|
+
async (canonical: string): Promise<void> => {
|
|
184
|
+
setPendingDeletes((prev) => new Set(prev).add(canonical));
|
|
185
|
+
// Clear any stale error from a previous failed attempt on this role.
|
|
186
|
+
setDeleteErrors((prev) => {
|
|
187
|
+
if (!(canonical in prev)) return prev;
|
|
188
|
+
const rest = { ...prev };
|
|
189
|
+
delete rest[canonical];
|
|
190
|
+
return rest;
|
|
191
|
+
});
|
|
192
|
+
try {
|
|
193
|
+
const rows = await deleteRole(canonical);
|
|
194
|
+
applyRoster(rows);
|
|
195
|
+
} catch (err) {
|
|
196
|
+
// Roll back the optimistic hide and record the error against the
|
|
197
|
+
// restored card by canonical (it may be a fresh instance by now).
|
|
198
|
+
setPendingDeletes((prev) => {
|
|
199
|
+
const next = new Set(prev);
|
|
200
|
+
next.delete(canonical);
|
|
201
|
+
return next;
|
|
202
|
+
});
|
|
203
|
+
setDeleteErrors((prev) => ({ ...prev, [canonical]: errMessage(err, 'Failed to delete role') }));
|
|
204
|
+
}
|
|
205
|
+
},
|
|
206
|
+
[applyRoster],
|
|
207
|
+
);
|
|
208
|
+
|
|
209
|
+
// The list the user sees = authoritative roster minus optimistically-deleted,
|
|
210
|
+
// plus optimistically-created placeholders not yet reflected by the server.
|
|
211
|
+
const rosterCanonicals = new Set(roster.map((r) => r.canonical));
|
|
212
|
+
const visibleRoster = [
|
|
213
|
+
...roster.filter((r) => !pendingDeletes.has(r.canonical)),
|
|
214
|
+
...pendingCreates.filter((c) => !rosterCanonicals.has(c.canonical)),
|
|
215
|
+
];
|
|
216
|
+
|
|
217
|
+
if (!isAdmin) {
|
|
218
|
+
return (
|
|
219
|
+
<PageShell title="Roles & Members" width="4xl">
|
|
220
|
+
<div className="text-sm text-slate-600">
|
|
221
|
+
Admins only. Ask an admin if you need a role or membership changed.
|
|
222
|
+
</div>
|
|
223
|
+
</PageShell>
|
|
224
|
+
);
|
|
225
|
+
}
|
|
226
|
+
|
|
227
|
+
return (
|
|
228
|
+
<PageShell
|
|
229
|
+
title="Roles & Members"
|
|
230
|
+
width="4xl"
|
|
231
|
+
actions={<NewRoleControl onCreate={createOptimistic} />}
|
|
232
|
+
>
|
|
233
|
+
{loading && roster.length === 0 ? (
|
|
234
|
+
<div className="flex items-center gap-2 p-2 text-sm text-slate-600">
|
|
235
|
+
<Loader2 size={14} className="animate-spin" /> Loading…
|
|
236
|
+
</div>
|
|
237
|
+
) : error ? (
|
|
238
|
+
<div className="p-3 text-sm text-red-700 bg-red-50 border border-red-200 rounded">
|
|
239
|
+
{error}
|
|
240
|
+
</div>
|
|
241
|
+
) : visibleRoster.length === 0 ? (
|
|
242
|
+
<div className="p-2 text-sm text-slate-600">No roles yet.</div>
|
|
243
|
+
) : (
|
|
244
|
+
<div className="flex flex-col gap-3">
|
|
245
|
+
{visibleRoster.map((role) => (
|
|
246
|
+
<RoleCard
|
|
247
|
+
key={role.canonical}
|
|
248
|
+
role={role}
|
|
249
|
+
onApply={applyRoster}
|
|
250
|
+
onDelete={deleteOptimistic}
|
|
251
|
+
deleteError={deleteErrors[role.canonical] ?? null}
|
|
252
|
+
/>
|
|
253
|
+
))}
|
|
254
|
+
</div>
|
|
255
|
+
)}
|
|
256
|
+
</PageShell>
|
|
257
|
+
);
|
|
258
|
+
}
|
|
259
|
+
|
|
260
|
+
function NewRoleControl({
|
|
261
|
+
onCreate,
|
|
262
|
+
}: {
|
|
263
|
+
onCreate: (displayName: string) => Promise<string | null>;
|
|
264
|
+
}) {
|
|
265
|
+
const [open, setOpen] = useState(false);
|
|
266
|
+
const [name, setName] = useState('');
|
|
267
|
+
const [error, setError] = useState<string | null>(null);
|
|
268
|
+
|
|
269
|
+
const reset = () => {
|
|
270
|
+
setOpen(false);
|
|
271
|
+
setName('');
|
|
272
|
+
setError(null);
|
|
273
|
+
};
|
|
274
|
+
|
|
275
|
+
const submit = async () => {
|
|
276
|
+
const clientError = validateNewRoleName(name);
|
|
277
|
+
if (clientError) {
|
|
278
|
+
setError(clientError);
|
|
279
|
+
return;
|
|
280
|
+
}
|
|
281
|
+
// Optimistic: the placeholder card appears immediately, so close the form
|
|
282
|
+
// right away. The commit runs in the background; a server rejection surfaces
|
|
283
|
+
// as an inline error (re-opening the form with the typed name preserved).
|
|
284
|
+
const typed = name.trim();
|
|
285
|
+
reset();
|
|
286
|
+
const err = await onCreate(typed);
|
|
287
|
+
if (err) {
|
|
288
|
+
setOpen(true);
|
|
289
|
+
setName(typed);
|
|
290
|
+
setError(err);
|
|
291
|
+
}
|
|
292
|
+
};
|
|
293
|
+
|
|
294
|
+
if (!open) {
|
|
295
|
+
return (
|
|
296
|
+
<button
|
|
297
|
+
type="button"
|
|
298
|
+
onClick={() => setOpen(true)}
|
|
299
|
+
className="px-3 py-1.5 text-xs rounded border border-slate-200 hover:bg-slate-50 flex items-center gap-1.5"
|
|
300
|
+
>
|
|
301
|
+
<Plus size={12} /> New role
|
|
302
|
+
</button>
|
|
303
|
+
);
|
|
304
|
+
}
|
|
305
|
+
|
|
306
|
+
return (
|
|
307
|
+
<div className="flex flex-col items-end gap-1">
|
|
308
|
+
<div className="flex items-center gap-1.5">
|
|
309
|
+
<input
|
|
310
|
+
autoFocus
|
|
311
|
+
value={name}
|
|
312
|
+
onChange={(e) => setName(e.target.value)}
|
|
313
|
+
onKeyDown={(e) => {
|
|
314
|
+
if (e.key === 'Enter') submit();
|
|
315
|
+
if (e.key === 'Escape') reset();
|
|
316
|
+
}}
|
|
317
|
+
placeholder="Role name"
|
|
318
|
+
className="text-xs px-2 py-1 border border-slate-200 rounded focus:outline-none focus:border-slate-300 w-48"
|
|
319
|
+
aria-label="New role name"
|
|
320
|
+
/>
|
|
321
|
+
<button
|
|
322
|
+
type="button"
|
|
323
|
+
onClick={submit}
|
|
324
|
+
className="px-2 py-1 text-xs rounded bg-bevel hover:bg-bevel-deep text-white disabled:opacity-50 flex items-center gap-1"
|
|
325
|
+
>
|
|
326
|
+
Add
|
|
327
|
+
</button>
|
|
328
|
+
<button
|
|
329
|
+
type="button"
|
|
330
|
+
onClick={reset}
|
|
331
|
+
className="p-1 rounded hover:bg-slate-100 text-slate-500"
|
|
332
|
+
aria-label="Cancel"
|
|
333
|
+
>
|
|
334
|
+
<X size={14} />
|
|
335
|
+
</button>
|
|
336
|
+
</div>
|
|
337
|
+
{error && (
|
|
338
|
+
<div className="text-xs text-red-700 bg-red-50 border border-red-200 rounded px-2 py-1">
|
|
339
|
+
{error}
|
|
340
|
+
</div>
|
|
341
|
+
)}
|
|
342
|
+
</div>
|
|
343
|
+
);
|
|
344
|
+
}
|
|
345
|
+
|
|
346
|
+
function RoleCard({
|
|
347
|
+
role,
|
|
348
|
+
onApply,
|
|
349
|
+
onDelete,
|
|
350
|
+
deleteError,
|
|
351
|
+
}: {
|
|
352
|
+
role: RoleRosterEntry;
|
|
353
|
+
onApply: (rows: RoleRosterEntry[]) => void;
|
|
354
|
+
onDelete: (canonical: string) => Promise<void>;
|
|
355
|
+
// Delete error for this role, owned by the parent so it survives the
|
|
356
|
+
// optimistic hide→restore cycle (the card may remount in between).
|
|
357
|
+
deleteError: string | null;
|
|
358
|
+
}) {
|
|
359
|
+
const [error, setError] = useState<string | null>(null);
|
|
360
|
+
const [busy, setBusy] = useState(false);
|
|
361
|
+
|
|
362
|
+
// Rename inline-edit state.
|
|
363
|
+
const [renaming, setRenaming] = useState(false);
|
|
364
|
+
const [renameValue, setRenameValue] = useState(role.displayName);
|
|
365
|
+
// A rename commit is in flight. Other row mutations capture `role.canonical`,
|
|
366
|
+
// which changes once an identity-changing rename reconciles, so we block them
|
|
367
|
+
// until the rename settles to avoid requests against the stale canonical.
|
|
368
|
+
const [renamePending, setRenamePending] = useState(false);
|
|
369
|
+
|
|
370
|
+
// Add-member input + people autocomplete (same suggest source as Manage
|
|
371
|
+
// Access, scoped to people/emails — a role's members are emails, not groups).
|
|
372
|
+
const [memberEmail, setMemberEmail] = useState('');
|
|
373
|
+
const [suggestions, setSuggestions] = useState<{ name: string; email: string }[]>([]);
|
|
374
|
+
const [showSuggest, setShowSuggest] = useState(false);
|
|
375
|
+
const suggestReq = useRef(0);
|
|
376
|
+
|
|
377
|
+
// Optimistic member removal: lowercased emails hidden from the chip list
|
|
378
|
+
// before the server confirms. Reconciled when the authoritative roster lands.
|
|
379
|
+
const [pendingRemovals, setPendingRemovals] = useState<Set<string>>(new Set());
|
|
380
|
+
// Optimistic member addition: canonicalised emails shown as chips before the
|
|
381
|
+
// server confirms. Reconciled (dropped) once they appear in the authoritative
|
|
382
|
+
// roster, or rolled back on error.
|
|
383
|
+
const [pendingAdds, setPendingAdds] = useState<string[]>([]);
|
|
384
|
+
// Optimistic rename: the new display name shown immediately while the rename
|
|
385
|
+
// commit is in flight. Cleared once the authoritative roster reflects it (or
|
|
386
|
+
// rolled back on error).
|
|
387
|
+
const [optimisticName, setOptimisticName] = useState<string | null>(null);
|
|
388
|
+
|
|
389
|
+
useEffect(() => {
|
|
390
|
+
const q = memberEmail.trim();
|
|
391
|
+
// Server withholds people until q ≥ 2 chars (harvesting guard); mirror that.
|
|
392
|
+
if (q.length < 2) {
|
|
393
|
+
// Invalidate any in-flight request so a late 2+ char response can't
|
|
394
|
+
// repopulate the dropdown after the user backspaced below the threshold.
|
|
395
|
+
suggestReq.current++;
|
|
396
|
+
setSuggestions([]);
|
|
397
|
+
return;
|
|
398
|
+
}
|
|
399
|
+
const myReq = ++suggestReq.current;
|
|
400
|
+
const t = setTimeout(() => {
|
|
401
|
+
suggestPrincipals(ROLES_WORKSPACE_ID, q)
|
|
402
|
+
.then((res) => {
|
|
403
|
+
if (myReq !== suggestReq.current) return;
|
|
404
|
+
// People only; drop anyone already a member (server or optimistic).
|
|
405
|
+
const existing = new Set([
|
|
406
|
+
...role.members.map((m) => m.toLowerCase()),
|
|
407
|
+
...pendingAdds.map((e) => e.toLowerCase()),
|
|
408
|
+
]);
|
|
409
|
+
setSuggestions(res.people.filter((p) => !existing.has(p.email.toLowerCase())));
|
|
410
|
+
})
|
|
411
|
+
.catch(() => {
|
|
412
|
+
if (myReq === suggestReq.current) setSuggestions([]);
|
|
413
|
+
});
|
|
414
|
+
}, 200);
|
|
415
|
+
return () => clearTimeout(t);
|
|
416
|
+
}, [memberEmail, role.members, pendingAdds]);
|
|
417
|
+
|
|
418
|
+
// Dialogs.
|
|
419
|
+
const [deleteTarget, setDeleteTarget] = useState<DeleteTarget | null>(null);
|
|
420
|
+
const [selfRemove, setSelfRemove] = useState<SelfRemoveTarget | null>(null);
|
|
421
|
+
|
|
422
|
+
// Name shown in the UI = optimistic rename target while a rename is in flight,
|
|
423
|
+
// else the authoritative display name.
|
|
424
|
+
const displayName = optimisticName ?? role.displayName;
|
|
425
|
+
// Members shown in the UI = server members minus any optimistically-removed,
|
|
426
|
+
// plus any optimistically-added not yet reflected in the server roster.
|
|
427
|
+
const serverMembers = role.members.filter((m) => !pendingRemovals.has(m.toLowerCase()));
|
|
428
|
+
const serverLower = new Set(role.members.map((m) => m.toLowerCase()));
|
|
429
|
+
const extraAdds = pendingAdds.filter((e) => !serverLower.has(e.toLowerCase()));
|
|
430
|
+
const visibleMembers = [...serverMembers, ...extraAdds];
|
|
431
|
+
|
|
432
|
+
// Self-heal the optimistic set against the authoritative roster: once the
|
|
433
|
+
// server confirms (member gone) OR a removal was a no-op (member never there),
|
|
434
|
+
// the email is no longer in role.members, so drop it from pendingRemovals.
|
|
435
|
+
// Without this, a no-op remove would hide a still-present member forever.
|
|
436
|
+
useEffect(() => {
|
|
437
|
+
setPendingRemovals((prev) => {
|
|
438
|
+
if (prev.size === 0) return prev;
|
|
439
|
+
const present = new Set(role.members.map((m) => m.toLowerCase()));
|
|
440
|
+
const next = new Set([...prev].filter((e) => present.has(e)));
|
|
441
|
+
return next.size === prev.size ? prev : next;
|
|
442
|
+
});
|
|
443
|
+
// Once the server roster includes a pending-add, drop it — the real member
|
|
444
|
+
// chip now renders it, so keeping it in pendingAdds would double-list it.
|
|
445
|
+
setPendingAdds((prev) => {
|
|
446
|
+
if (prev.length === 0) return prev;
|
|
447
|
+
const present = new Set(role.members.map((m) => m.toLowerCase()));
|
|
448
|
+
const next = prev.filter((e) => !present.has(e.toLowerCase()));
|
|
449
|
+
return next.length === prev.length ? prev : next;
|
|
450
|
+
});
|
|
451
|
+
}, [role.members]);
|
|
452
|
+
|
|
453
|
+
// Clear the optimistic rename once the authoritative roster reflects it.
|
|
454
|
+
useEffect(() => {
|
|
455
|
+
if (optimisticName !== null && role.displayName === optimisticName) {
|
|
456
|
+
setOptimisticName(null);
|
|
457
|
+
}
|
|
458
|
+
}, [role.displayName, optimisticName]);
|
|
459
|
+
|
|
460
|
+
const run = useCallback(
|
|
461
|
+
async (fn: () => Promise<RoleRosterEntry[]>) => {
|
|
462
|
+
setBusy(true);
|
|
463
|
+
setError(null);
|
|
464
|
+
try {
|
|
465
|
+
const rows = await fn();
|
|
466
|
+
onApply(rows);
|
|
467
|
+
return true;
|
|
468
|
+
} catch (err) {
|
|
469
|
+
setError(errMessage(err, 'Operation failed'));
|
|
470
|
+
return false;
|
|
471
|
+
} finally {
|
|
472
|
+
setBusy(false);
|
|
473
|
+
}
|
|
474
|
+
},
|
|
475
|
+
[onApply],
|
|
476
|
+
);
|
|
477
|
+
|
|
478
|
+
const submitRename = async () => {
|
|
479
|
+
const next = renameValue.trim();
|
|
480
|
+
if (next === role.displayName) {
|
|
481
|
+
setRenaming(false);
|
|
482
|
+
return;
|
|
483
|
+
}
|
|
484
|
+
// Optimistic: show the new name and close the editor immediately. The rename
|
|
485
|
+
// commit runs in the background; the authoritative roster reconciles it (or
|
|
486
|
+
// we roll back on error). Not gated on `busy` — same posture as removal.
|
|
487
|
+
setError(null);
|
|
488
|
+
setOptimisticName(next);
|
|
489
|
+
setRenaming(false);
|
|
490
|
+
setRenamePending(true);
|
|
491
|
+
try {
|
|
492
|
+
const rows = await renameRole(role.canonical, next);
|
|
493
|
+
onApply(rows);
|
|
494
|
+
} catch (err) {
|
|
495
|
+
setOptimisticName(null); // roll back the optimistic label
|
|
496
|
+
setError(errMessage(err, 'Failed to rename role'));
|
|
497
|
+
} finally {
|
|
498
|
+
setRenamePending(false);
|
|
499
|
+
}
|
|
500
|
+
};
|
|
501
|
+
|
|
502
|
+
const submitAddMember = async (override?: string) => {
|
|
503
|
+
// A rename is reconciling — `role.canonical` is about to change, so don't
|
|
504
|
+
// fire mutations against the stale one.
|
|
505
|
+
if (renamePending) return;
|
|
506
|
+
const email = (override ?? memberEmail).trim();
|
|
507
|
+
if (!EMAIL_RE.test(email)) {
|
|
508
|
+
setError('Enter a valid email address.');
|
|
509
|
+
return;
|
|
510
|
+
}
|
|
511
|
+
const lower = email.toLowerCase();
|
|
512
|
+
// Already a member (or already pending) — clear the input and do nothing.
|
|
513
|
+
if (
|
|
514
|
+
role.members.some((m) => m.toLowerCase() === lower) ||
|
|
515
|
+
pendingAdds.some((e) => e.toLowerCase() === lower)
|
|
516
|
+
) {
|
|
517
|
+
setMemberEmail('');
|
|
518
|
+
setShowSuggest(false);
|
|
519
|
+
setSuggestions([]);
|
|
520
|
+
return;
|
|
521
|
+
}
|
|
522
|
+
// Optimistic: show the chip and clear the input immediately. The add commit
|
|
523
|
+
// runs in the background; the authoritative roster reconciles it (the
|
|
524
|
+
// self-heal effect drops it from pendingAdds), or we roll back on error.
|
|
525
|
+
// Not gated on `busy` — same posture as removal.
|
|
526
|
+
setError(null);
|
|
527
|
+
setPendingAdds((prev) => [...prev, email]);
|
|
528
|
+
setMemberEmail('');
|
|
529
|
+
setShowSuggest(false);
|
|
530
|
+
setSuggestions([]);
|
|
531
|
+
try {
|
|
532
|
+
const rows = await addMember(role.canonical, email);
|
|
533
|
+
onApply(rows);
|
|
534
|
+
} catch (err) {
|
|
535
|
+
// Roll back the optimistic chip so it disappears.
|
|
536
|
+
setPendingAdds((prev) => prev.filter((e) => e.toLowerCase() !== lower));
|
|
537
|
+
setError(errMessage(err, 'Failed to add member'));
|
|
538
|
+
}
|
|
539
|
+
};
|
|
540
|
+
|
|
541
|
+
const handleRemoveMember = async (email: string) => {
|
|
542
|
+
if (renamePending) return;
|
|
543
|
+
setError(null);
|
|
544
|
+
const lower = email.toLowerCase();
|
|
545
|
+
// If this chip is an optimistic add not yet on the server, just drop it from
|
|
546
|
+
// pendingAdds — there is nothing committed to remove. (If a prior add commit
|
|
547
|
+
// is still in flight, its self-heal will re-add the real chip; removing it
|
|
548
|
+
// again is then a normal server removal.)
|
|
549
|
+
const isServerMember = role.members.some((m) => m.toLowerCase() === lower);
|
|
550
|
+
if (!isServerMember && pendingAdds.some((e) => e.toLowerCase() === lower)) {
|
|
551
|
+
setPendingAdds((prev) => prev.filter((e) => e.toLowerCase() !== lower));
|
|
552
|
+
return;
|
|
553
|
+
}
|
|
554
|
+
// Optimistic: hide the chip immediately so removal feels instant. The
|
|
555
|
+
// server's authoritative roster reconciles it on response (or it reappears
|
|
556
|
+
// on error). We do NOT set `busy` here — the row stays interactive and the
|
|
557
|
+
// chip just disappears, which is the whole point of optimism.
|
|
558
|
+
setPendingRemovals((s) => new Set(s).add(email.toLowerCase()));
|
|
559
|
+
try {
|
|
560
|
+
const rows = await removeMember(role.canonical, email);
|
|
561
|
+
onApply(rows); // authoritative roster replaces local members
|
|
562
|
+
} catch (err) {
|
|
563
|
+
// Roll back the optimistic hide so the chip returns.
|
|
564
|
+
setPendingRemovals((s) => {
|
|
565
|
+
const next = new Set(s);
|
|
566
|
+
next.delete(email.toLowerCase());
|
|
567
|
+
return next;
|
|
568
|
+
});
|
|
569
|
+
if (err instanceof RolesApiError && err.status === 409 && err.kind === 'self-admin-removal') {
|
|
570
|
+
setSelfRemove({ canonical: role.canonical, email });
|
|
571
|
+
} else {
|
|
572
|
+
setError(errMessage(err, 'Failed to remove member'));
|
|
573
|
+
}
|
|
574
|
+
}
|
|
575
|
+
};
|
|
576
|
+
|
|
577
|
+
const confirmSelfRemove = async () => {
|
|
578
|
+
if (!selfRemove) return;
|
|
579
|
+
const ok = await run(() =>
|
|
580
|
+
removeMember(selfRemove.canonical, selfRemove.email, true),
|
|
581
|
+
);
|
|
582
|
+
if (ok) setSelfRemove(null);
|
|
583
|
+
};
|
|
584
|
+
|
|
585
|
+
const confirmDelete = async () => {
|
|
586
|
+
if (renamePending) return;
|
|
587
|
+
// Optimistic: close the dialog and let the card vanish immediately. The
|
|
588
|
+
// commit runs in the background; on failure the parent rolls back the hide
|
|
589
|
+
// and records the error (keyed by canonical), which arrives via deleteError
|
|
590
|
+
// — so it survives even if this card instance was unmounted in between.
|
|
591
|
+
setDeleteTarget(null);
|
|
592
|
+
await onDelete(role.canonical);
|
|
593
|
+
};
|
|
594
|
+
|
|
595
|
+
return (
|
|
596
|
+
<div className="border border-slate-200 rounded-lg p-4">
|
|
597
|
+
<div className="flex items-start gap-3">
|
|
598
|
+
<div className="flex-1 min-w-0">
|
|
599
|
+
{renaming ? (
|
|
600
|
+
<div className="flex items-center gap-1.5">
|
|
601
|
+
<input
|
|
602
|
+
autoFocus
|
|
603
|
+
value={renameValue}
|
|
604
|
+
onChange={(e) => setRenameValue(e.target.value)}
|
|
605
|
+
onKeyDown={(e) => {
|
|
606
|
+
if (e.key === 'Enter') submitRename();
|
|
607
|
+
if (e.key === 'Escape') {
|
|
608
|
+
setRenameValue(role.displayName);
|
|
609
|
+
setRenaming(false);
|
|
610
|
+
}
|
|
611
|
+
}}
|
|
612
|
+
disabled={busy}
|
|
613
|
+
className="text-base font-semibold px-2 py-1 border border-slate-200 rounded focus:outline-none focus:border-slate-300"
|
|
614
|
+
aria-label="Role name"
|
|
615
|
+
/>
|
|
616
|
+
<button
|
|
617
|
+
type="button"
|
|
618
|
+
onClick={submitRename}
|
|
619
|
+
disabled={busy}
|
|
620
|
+
className="p-1 rounded hover:bg-slate-100 text-slate-600 disabled:opacity-50"
|
|
621
|
+
aria-label="Save name"
|
|
622
|
+
>
|
|
623
|
+
{busy ? <Loader2 size={14} className="animate-spin" /> : <Check size={14} />}
|
|
624
|
+
</button>
|
|
625
|
+
<button
|
|
626
|
+
type="button"
|
|
627
|
+
onClick={() => {
|
|
628
|
+
setRenameValue(role.displayName);
|
|
629
|
+
setRenaming(false);
|
|
630
|
+
}}
|
|
631
|
+
disabled={busy}
|
|
632
|
+
className="p-1 rounded hover:bg-slate-100 text-slate-500"
|
|
633
|
+
aria-label="Cancel rename"
|
|
634
|
+
>
|
|
635
|
+
<X size={14} />
|
|
636
|
+
</button>
|
|
637
|
+
</div>
|
|
638
|
+
) : (
|
|
639
|
+
<div className="flex items-center gap-2">
|
|
640
|
+
<h2 className="text-base font-semibold text-slate-900 truncate">
|
|
641
|
+
{displayName}
|
|
642
|
+
</h2>
|
|
643
|
+
{role.isAdmin && (
|
|
644
|
+
<span className="text-[10px] uppercase tracking-wide text-slate-500 border border-slate-200 rounded px-1.5 py-0.5">
|
|
645
|
+
Required
|
|
646
|
+
</span>
|
|
647
|
+
)}
|
|
648
|
+
</div>
|
|
649
|
+
)}
|
|
650
|
+
</div>
|
|
651
|
+
|
|
652
|
+
{!renaming && (
|
|
653
|
+
<div className="flex items-center gap-1 shrink-0">
|
|
654
|
+
<button
|
|
655
|
+
type="button"
|
|
656
|
+
onClick={() => {
|
|
657
|
+
setRenameValue(role.displayName);
|
|
658
|
+
setRenaming(true);
|
|
659
|
+
}}
|
|
660
|
+
disabled={busy || renamePending}
|
|
661
|
+
className="p-1.5 rounded hover:bg-slate-100 text-slate-600 disabled:opacity-50"
|
|
662
|
+
title="Rename"
|
|
663
|
+
aria-label="Rename role"
|
|
664
|
+
>
|
|
665
|
+
<Pencil size={14} />
|
|
666
|
+
</button>
|
|
667
|
+
{!role.isAdmin && (
|
|
668
|
+
<button
|
|
669
|
+
type="button"
|
|
670
|
+
onClick={() => setDeleteTarget({ role })}
|
|
671
|
+
disabled={busy || renamePending}
|
|
672
|
+
className="p-1.5 rounded hover:bg-red-50 text-red-600 disabled:opacity-50"
|
|
673
|
+
title="Delete role"
|
|
674
|
+
aria-label="Delete role"
|
|
675
|
+
>
|
|
676
|
+
<Trash2 size={14} />
|
|
677
|
+
</button>
|
|
678
|
+
)}
|
|
679
|
+
</div>
|
|
680
|
+
)}
|
|
681
|
+
</div>
|
|
682
|
+
|
|
683
|
+
{/* Member chips — optimistically hides members pending removal. */}
|
|
684
|
+
<div className="mt-3 flex flex-wrap gap-2">
|
|
685
|
+
{visibleMembers.length === 0 ? (
|
|
686
|
+
<span className="text-xs text-slate-400">No members.</span>
|
|
687
|
+
) : (
|
|
688
|
+
visibleMembers.map((email) => {
|
|
689
|
+
const isLastAdminMember = role.isAdmin && visibleMembers.length === 1;
|
|
690
|
+
return (
|
|
691
|
+
<span
|
|
692
|
+
key={email}
|
|
693
|
+
className="inline-flex items-center gap-1.5 pl-1 pr-1.5 py-1 bg-slate-50 border border-slate-200 rounded-full text-xs text-slate-700"
|
|
694
|
+
>
|
|
695
|
+
<span className="w-5 h-5 rounded-full bg-slate-500 text-white text-[9px] font-semibold flex items-center justify-center">
|
|
696
|
+
{initials(email)}
|
|
697
|
+
</span>
|
|
698
|
+
<span className="truncate max-w-[14rem]">{email}</span>
|
|
699
|
+
<button
|
|
700
|
+
type="button"
|
|
701
|
+
onClick={() => handleRemoveMember(email)}
|
|
702
|
+
disabled={busy || renamePending || isLastAdminMember}
|
|
703
|
+
className="rounded-full p-0.5 text-slate-400 hover:text-red-600 hover:bg-red-50 disabled:cursor-not-allowed disabled:hover:text-slate-400 disabled:hover:bg-transparent"
|
|
704
|
+
title={
|
|
705
|
+
isLastAdminMember
|
|
706
|
+
? 'Admin must keep at least one member'
|
|
707
|
+
: 'Remove member'
|
|
708
|
+
}
|
|
709
|
+
aria-label={`Remove ${email}`}
|
|
710
|
+
>
|
|
711
|
+
<X size={12} />
|
|
712
|
+
</button>
|
|
713
|
+
</span>
|
|
714
|
+
);
|
|
715
|
+
})
|
|
716
|
+
)}
|
|
717
|
+
</div>
|
|
718
|
+
|
|
719
|
+
{/* Add member — with people autocomplete (Manage Access suggest source). */}
|
|
720
|
+
<div className="mt-3 flex items-center gap-1.5">
|
|
721
|
+
<div className="relative">
|
|
722
|
+
<input
|
|
723
|
+
type="email"
|
|
724
|
+
value={memberEmail}
|
|
725
|
+
onChange={(e) => {
|
|
726
|
+
setMemberEmail(e.target.value);
|
|
727
|
+
setShowSuggest(true);
|
|
728
|
+
}}
|
|
729
|
+
onFocus={() => setShowSuggest(true)}
|
|
730
|
+
// Delay so a click on a suggestion lands before the list unmounts.
|
|
731
|
+
onBlur={() => setTimeout(() => setShowSuggest(false), 150)}
|
|
732
|
+
onKeyDown={(e) => {
|
|
733
|
+
if (e.key === 'Enter') submitAddMember();
|
|
734
|
+
if (e.key === 'Escape') setShowSuggest(false);
|
|
735
|
+
}}
|
|
736
|
+
placeholder="Add member by email"
|
|
737
|
+
disabled={busy || renamePending}
|
|
738
|
+
className="text-xs px-2 py-1 border border-slate-200 rounded focus:outline-none focus:border-slate-300 w-64"
|
|
739
|
+
aria-label="Member email"
|
|
740
|
+
autoComplete="off"
|
|
741
|
+
/>
|
|
742
|
+
{showSuggest && suggestions.length > 0 && (
|
|
743
|
+
<ul className="absolute z-10 mt-1 w-72 max-h-56 overflow-auto bg-white border border-slate-200 rounded shadow-lg py-1">
|
|
744
|
+
{suggestions.map((p) => (
|
|
745
|
+
<li key={p.email}>
|
|
746
|
+
<button
|
|
747
|
+
type="button"
|
|
748
|
+
// onMouseDown (not onClick) so it fires before the input's blur.
|
|
749
|
+
onMouseDown={(e) => {
|
|
750
|
+
e.preventDefault();
|
|
751
|
+
submitAddMember(p.email);
|
|
752
|
+
}}
|
|
753
|
+
className="w-full text-left px-2 py-1.5 hover:bg-slate-50 flex items-center gap-2"
|
|
754
|
+
>
|
|
755
|
+
<span className="w-5 h-5 rounded-full bg-slate-500 text-white text-[9px] font-semibold flex items-center justify-center shrink-0">
|
|
756
|
+
{initials(p.email)}
|
|
757
|
+
</span>
|
|
758
|
+
<span className="flex-1 truncate text-xs text-slate-700">{p.name || p.email}</span>
|
|
759
|
+
<span className="text-[10px] text-slate-400 truncate">{p.email}</span>
|
|
760
|
+
</button>
|
|
761
|
+
</li>
|
|
762
|
+
))}
|
|
763
|
+
</ul>
|
|
764
|
+
)}
|
|
765
|
+
</div>
|
|
766
|
+
<button
|
|
767
|
+
type="button"
|
|
768
|
+
onClick={() => submitAddMember()}
|
|
769
|
+
disabled={busy || renamePending}
|
|
770
|
+
className="px-3 py-1 text-xs rounded border border-slate-200 hover:bg-slate-50 disabled:opacity-50 flex items-center gap-1"
|
|
771
|
+
>
|
|
772
|
+
{busy && <Loader2 size={12} className="animate-spin" />}
|
|
773
|
+
Add
|
|
774
|
+
</button>
|
|
775
|
+
</div>
|
|
776
|
+
|
|
777
|
+
{(error ?? deleteError) && (
|
|
778
|
+
<div className="mt-3 text-sm text-red-700 bg-red-50 border border-red-200 rounded px-3 py-2">
|
|
779
|
+
{error ?? deleteError}
|
|
780
|
+
</div>
|
|
781
|
+
)}
|
|
782
|
+
|
|
783
|
+
{deleteTarget && (
|
|
784
|
+
<ConfirmDialog
|
|
785
|
+
title={`Delete "${deleteTarget.role.displayName}"?`}
|
|
786
|
+
confirmLabel="Delete role"
|
|
787
|
+
danger
|
|
788
|
+
busy={busy}
|
|
789
|
+
onCancel={() => setDeleteTarget(null)}
|
|
790
|
+
onConfirm={confirmDelete}
|
|
791
|
+
>
|
|
792
|
+
{deleteTarget.role.referencedBy.length > 0 ? (
|
|
793
|
+
<>
|
|
794
|
+
<p className="text-sm text-slate-700">
|
|
795
|
+
{deleteTarget.role.referencedBy.length} access rule
|
|
796
|
+
{deleteTarget.role.referencedBy.length === 1 ? '' : 's'} will be
|
|
797
|
+
ignored after deletion:
|
|
798
|
+
</p>
|
|
799
|
+
<ul className="mt-2 max-h-40 overflow-auto text-xs text-slate-500 space-y-0.5">
|
|
800
|
+
{deleteTarget.role.referencedBy.map((ref, i) => (
|
|
801
|
+
<li key={`${ref.path}:${ref.verb}:${i}`} className="truncate">
|
|
802
|
+
{ref.verb} · {ref.path}
|
|
803
|
+
</li>
|
|
804
|
+
))}
|
|
805
|
+
</ul>
|
|
806
|
+
</>
|
|
807
|
+
) : (
|
|
808
|
+
<p className="text-sm text-slate-700">This role has no access rules.</p>
|
|
809
|
+
)}
|
|
810
|
+
</ConfirmDialog>
|
|
811
|
+
)}
|
|
812
|
+
|
|
813
|
+
{selfRemove && (
|
|
814
|
+
<ConfirmDialog
|
|
815
|
+
title="Remove your own admin access?"
|
|
816
|
+
confirmLabel="Remove"
|
|
817
|
+
danger
|
|
818
|
+
busy={busy}
|
|
819
|
+
onCancel={() => setSelfRemove(null)}
|
|
820
|
+
onConfirm={confirmSelfRemove}
|
|
821
|
+
>
|
|
822
|
+
<p className="text-sm text-slate-700">
|
|
823
|
+
You are removing your own last Admin membership. You may lose access
|
|
824
|
+
to admin tools.
|
|
825
|
+
</p>
|
|
826
|
+
</ConfirmDialog>
|
|
827
|
+
)}
|
|
828
|
+
</div>
|
|
829
|
+
);
|
|
830
|
+
}
|
|
831
|
+
|
|
832
|
+
function ConfirmDialog({
|
|
833
|
+
title,
|
|
834
|
+
confirmLabel,
|
|
835
|
+
danger,
|
|
836
|
+
busy,
|
|
837
|
+
children,
|
|
838
|
+
onCancel,
|
|
839
|
+
onConfirm,
|
|
840
|
+
}: {
|
|
841
|
+
title: string;
|
|
842
|
+
confirmLabel: string;
|
|
843
|
+
danger?: boolean;
|
|
844
|
+
busy: boolean;
|
|
845
|
+
children: React.ReactNode;
|
|
846
|
+
onCancel: () => void;
|
|
847
|
+
onConfirm: () => void;
|
|
848
|
+
}) {
|
|
849
|
+
const titleId = useId();
|
|
850
|
+
const panelRef = useRef<HTMLDivElement>(null);
|
|
851
|
+
// Latest onCancel without re-running the mount effect on every parent render
|
|
852
|
+
// (the parent passes a fresh closure each time, e.g. when `busy` flips).
|
|
853
|
+
const onCancelRef = useRef(onCancel);
|
|
854
|
+
useEffect(() => {
|
|
855
|
+
onCancelRef.current = onCancel;
|
|
856
|
+
}, [onCancel]);
|
|
857
|
+
|
|
858
|
+
// Real modal behaviour: hand focus to the dialog on open, restore it to the
|
|
859
|
+
// trigger on close, close on Escape, and trap Tab/Shift+Tab inside the panel
|
|
860
|
+
// so keyboard and screen-reader users can't reach the obscured page behind it.
|
|
861
|
+
useEffect(() => {
|
|
862
|
+
const previouslyFocused = document.activeElement as HTMLElement | null;
|
|
863
|
+
const panel = panelRef.current;
|
|
864
|
+
const focusable = () =>
|
|
865
|
+
Array.from(
|
|
866
|
+
panel?.querySelectorAll<HTMLElement>(
|
|
867
|
+
'button:not([disabled]), [href], input, select, textarea, [tabindex]:not([tabindex="-1"])',
|
|
868
|
+
) ?? [],
|
|
869
|
+
);
|
|
870
|
+
(focusable()[0] ?? panel)?.focus();
|
|
871
|
+
|
|
872
|
+
const onKeyDown = (e: KeyboardEvent) => {
|
|
873
|
+
if (e.key === 'Escape') {
|
|
874
|
+
e.preventDefault();
|
|
875
|
+
onCancelRef.current();
|
|
876
|
+
return;
|
|
877
|
+
}
|
|
878
|
+
if (e.key !== 'Tab') return;
|
|
879
|
+
const items = focusable();
|
|
880
|
+
if (items.length === 0) {
|
|
881
|
+
e.preventDefault();
|
|
882
|
+
return;
|
|
883
|
+
}
|
|
884
|
+
const first = items[0];
|
|
885
|
+
const last = items[items.length - 1];
|
|
886
|
+
if (e.shiftKey && document.activeElement === first) {
|
|
887
|
+
e.preventDefault();
|
|
888
|
+
last.focus();
|
|
889
|
+
} else if (!e.shiftKey && document.activeElement === last) {
|
|
890
|
+
e.preventDefault();
|
|
891
|
+
first.focus();
|
|
892
|
+
}
|
|
893
|
+
};
|
|
894
|
+
document.addEventListener('keydown', onKeyDown, true);
|
|
895
|
+
return () => {
|
|
896
|
+
document.removeEventListener('keydown', onKeyDown, true);
|
|
897
|
+
previouslyFocused?.focus?.();
|
|
898
|
+
};
|
|
899
|
+
}, []);
|
|
900
|
+
|
|
901
|
+
return (
|
|
902
|
+
<div
|
|
903
|
+
className="fixed inset-0 z-50 flex items-center justify-center bg-black/30 p-4"
|
|
904
|
+
onMouseDown={(e) => {
|
|
905
|
+
// Backdrop click (outside the panel) dismisses, like a native modal.
|
|
906
|
+
if (e.target === e.currentTarget && !busy) onCancelRef.current();
|
|
907
|
+
}}
|
|
908
|
+
>
|
|
909
|
+
<div
|
|
910
|
+
ref={panelRef}
|
|
911
|
+
role="dialog"
|
|
912
|
+
aria-modal="true"
|
|
913
|
+
aria-labelledby={titleId}
|
|
914
|
+
tabIndex={-1}
|
|
915
|
+
className="bg-white rounded-lg shadow-lg w-full max-w-md p-5 outline-none"
|
|
916
|
+
>
|
|
917
|
+
<h3 id={titleId} className="text-sm font-semibold text-slate-900">{title}</h3>
|
|
918
|
+
<div className="mt-3">{children}</div>
|
|
919
|
+
<div className="mt-5 flex justify-end gap-2">
|
|
920
|
+
<button
|
|
921
|
+
type="button"
|
|
922
|
+
onClick={onCancel}
|
|
923
|
+
disabled={busy}
|
|
924
|
+
className="px-3 py-1.5 text-xs rounded border border-slate-200 hover:bg-slate-50 disabled:opacity-50"
|
|
925
|
+
>
|
|
926
|
+
Cancel
|
|
927
|
+
</button>
|
|
928
|
+
<button
|
|
929
|
+
type="button"
|
|
930
|
+
onClick={onConfirm}
|
|
931
|
+
disabled={busy}
|
|
932
|
+
className={`px-3 py-1.5 text-xs rounded text-white disabled:opacity-50 flex items-center gap-1 ${
|
|
933
|
+
danger ? 'bg-red-600 hover:bg-red-700' : 'bg-bevel hover:bg-bevel-deep'
|
|
934
|
+
}`}
|
|
935
|
+
>
|
|
936
|
+
{busy && <Loader2 size={12} className="animate-spin" />}
|
|
937
|
+
{confirmLabel}
|
|
938
|
+
</button>
|
|
939
|
+
</div>
|
|
940
|
+
</div>
|
|
941
|
+
</div>
|
|
942
|
+
);
|
|
943
|
+
}
|