@bevel-software/platform-core-frontend 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +202 -0
- package/package.json +70 -0
- package/src/core/CoreAppShell.tsx +444 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +95 -0
- package/src/core/events.ts +29 -0
- package/src/core/registry.ts +336 -0
- package/src/css-side-effect-imports.d.ts +7 -0
- package/src/html-extensions.ts +12 -0
- package/src/index.css +49 -0
- package/src/index.ts +23 -0
- package/src/lib/api.ts +57 -0
- package/src/lib/utils.ts +138 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +130 -0
- package/src/modules/access/__tests__/useFileAccess.test.tsx +253 -0
- package/src/modules/access/api.ts +205 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +31 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +1232 -0
- package/src/modules/access/components/NodeOwnersBanner.tsx +30 -0
- package/src/modules/access/hooks/useFileAccess.ts +151 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +943 -0
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +74 -0
- package/src/modules/admin/services/admin.api.ts +92 -0
- package/src/modules/admin/services/roles.api.ts +136 -0
- package/src/modules/admin/state/admin.context.tsx +223 -0
- package/src/modules/auth/components/LoginScreen.tsx +135 -0
- package/src/modules/auth/hooks/useAuthState.ts +59 -0
- package/src/modules/auth/services/auth.api.ts +24 -0
- package/src/modules/auth/services/microsoft-oauth.ts +57 -0
- package/src/modules/auth/state/auth.context.ts +18 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +347 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +201 -0
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +82 -0
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +441 -0
- package/src/modules/git/__tests__/git.api.test.ts +113 -0
- package/src/modules/git/__tests__/pr.api.test.ts +44 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +212 -0
- package/src/modules/git/components/BranchSwitcher.tsx +527 -0
- package/src/modules/git/components/DiffView.tsx +30 -0
- package/src/modules/git/components/FileComparisonPanel.tsx +377 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +320 -0
- package/src/modules/git/components/ProtectedBranchBanner.tsx +42 -0
- package/src/modules/git/components/PullNeededBanner.tsx +204 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +244 -0
- package/src/modules/git/components/UnifiedDiffView.tsx +37 -0
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +99 -0
- package/src/modules/git/hooks/useAutoPullUpdates.ts +121 -0
- package/src/modules/git/hooks/useGitState.ts +335 -0
- package/src/modules/git/services/__tests__/error-messages.test.ts +134 -0
- package/src/modules/git/services/error-messages.ts +257 -0
- package/src/modules/git/services/git.api.ts +163 -0
- package/src/modules/git/services/pr-prompts.ts +159 -0
- package/src/modules/git/services/pr.api.ts +39 -0
- package/src/modules/git/state/auto-update.context.ts +21 -0
- package/src/modules/git/state/git.context.ts +82 -0
- package/src/modules/layout/components/AppLayout.tsx +40 -0
- package/src/modules/layout/components/DemoBanner.tsx +57 -0
- package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +153 -0
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +203 -0
- package/src/modules/layout/components/SlideOverlay.tsx +224 -0
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +77 -0
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +57 -0
- package/src/modules/layout/hooks/useMediaQuery.ts +23 -0
- package/src/modules/layout/state/__tests__/layout.context.test.tsx +39 -0
- package/src/modules/layout/state/layout.context.ts +46 -0
- package/src/modules/library/__tests__/DetailDialog.test.tsx +200 -0
- package/src/modules/library/__tests__/diff.test.ts +62 -0
- package/src/modules/library/__tests__/loadout.test.tsx +72 -0
- package/src/modules/library/__tests__/status.test.ts +117 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +47 -0
- package/src/modules/library/components/CompareView.tsx +357 -0
- package/src/modules/library/components/DetailDialog.tsx +566 -0
- package/src/modules/library/components/GearIcon.tsx +12 -0
- package/src/modules/library/components/LibraryCard.tsx +132 -0
- package/src/modules/library/components/LibraryPage.tsx +254 -0
- package/src/modules/library/components/LoadoutSidebar.tsx +156 -0
- package/src/modules/library/components/StatusGem.tsx +21 -0
- package/src/modules/library/components/SuggestChange.tsx +171 -0
- package/src/modules/library/components/particles.ts +50 -0
- package/src/modules/library/hooks/useLibraryData.ts +119 -0
- package/src/modules/library/hooks/useSkillDetail.ts +74 -0
- package/src/modules/library/library.css +320 -0
- package/src/modules/library/services/library.api.ts +164 -0
- package/src/modules/library/state/loadout.tsx +129 -0
- package/src/modules/library/state/toast.tsx +42 -0
- package/src/modules/library/utils/diff.ts +102 -0
- package/src/modules/library/utils/status.ts +116 -0
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +93 -0
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +158 -0
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +44 -0
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +360 -0
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +85 -0
- package/src/modules/pr/__tests__/parsePatch.test.ts +104 -0
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +72 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +193 -0
- package/src/modules/pr/components/PrApprovalBadge.tsx +80 -0
- package/src/modules/pr/components/PrCancelButton.tsx +99 -0
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +119 -0
- package/src/modules/pr/components/PrCommentComposer.tsx +92 -0
- package/src/modules/pr/components/PrCommentThread.tsx +168 -0
- package/src/modules/pr/components/PrCommentsPanel.tsx +143 -0
- package/src/modules/pr/components/PrDiffPane.tsx +425 -0
- package/src/modules/pr/components/PrFileRow.tsx +164 -0
- package/src/modules/pr/components/PrFilesList.tsx +53 -0
- package/src/modules/pr/components/PrHeader.tsx +45 -0
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +58 -0
- package/src/modules/pr/components/PrMergeButton.tsx +268 -0
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +112 -0
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +110 -0
- package/src/modules/pr/components/PrViewer.tsx +364 -0
- package/src/modules/pr/hooks/usePrViewerState.ts +150 -0
- package/src/modules/pr/services/pr-approvals.api.ts +31 -0
- package/src/modules/pr/services/pr-cancel.api.ts +19 -0
- package/src/modules/pr/services/pr-comments.api.ts +45 -0
- package/src/modules/pr/services/pr-detail.api.ts +17 -0
- package/src/modules/pr/services/pr-merge.api.ts +53 -0
- package/src/modules/pr/services/pr-open.api.ts +30 -0
- package/src/modules/pr/state/pr-viewer.context.ts +34 -0
- package/src/modules/pr/utils/bucketize-comments.ts +55 -0
- package/src/modules/pr/utils/parsePatch.ts +57 -0
- package/src/modules/review/__tests__/review.api.test.ts +121 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +15 -0
- package/src/modules/review/components/DiffViewer.tsx +78 -0
- package/src/modules/review/components/MarkdownDiffViewer.tsx +263 -0
- package/src/modules/review/components/ReviewFileRow.tsx +114 -0
- package/src/modules/review/components/ReviewPanel.tsx +260 -0
- package/src/modules/review/components/ReviewPanelSurface.tsx +52 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +106 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +88 -0
- package/src/modules/review/hooks/useReviewState.ts +256 -0
- package/src/modules/review/services/review.api.ts +72 -0
- package/src/modules/review/state/ReviewProvider.tsx +28 -0
- package/src/modules/review/state/review.context.ts +29 -0
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +488 -0
- package/src/modules/secrets-vault/components/SecretsPage.tsx +276 -0
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +362 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +51 -0
- package/src/modules/secrets-vault/services/connect.api.ts +113 -0
- package/src/modules/secrets-vault/services/secrets.api.ts +82 -0
- package/src/modules/secrets-vault/services/tool-secrets.api.ts +116 -0
- package/src/modules/toolbar/components/AdminMenu.tsx +250 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +108 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -0
- package/src/modules/toolbar/components/Toolbar.tsx +123 -0
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +122 -0
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +353 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +65 -0
- package/src/modules/tools/ToolsExplorerPage.tsx +380 -0
- package/src/modules/workflow/hooks/useEventBusSubscription.ts +24 -0
- package/src/modules/workflow/hooks/useFileLock.ts +430 -0
- package/src/modules/workflow/services/lock.api.ts +139 -0
- package/src/modules/workflow/state/EventBusFocusBinder.tsx +25 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +232 -0
- package/src/modules/workflow/state/event-bus.context.ts +75 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +54 -0
- package/src/modules/workspace/__tests__/useWorkspaceState.test.ts +91 -0
- package/src/modules/workspace/components/EditorTabs.tsx +384 -0
- package/src/modules/workspace/components/FileExplorer.tsx +1068 -0
- package/src/modules/workspace/components/FileRoute.tsx +392 -0
- package/src/modules/workspace/components/FileViewer.tsx +906 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +241 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +666 -0
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +330 -0
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +492 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +174 -0
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +87 -0
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +231 -0
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +50 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +287 -0
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +252 -0
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +268 -0
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +81 -0
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +86 -0
- package/src/modules/workspace/components/renderers/ToolForm.tsx +404 -0
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +417 -0
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +157 -0
- package/src/modules/workspace/components/renderers/__tests__/CsvRenderer.test.ts +57 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +95 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +328 -0
- package/src/modules/workspace/components/renderers/__tests__/PdfRenderer.test.tsx +167 -0
- package/src/modules/workspace/components/renderers/__tests__/htmlSandbox.test.ts +318 -0
- package/src/modules/workspace/components/renderers/csvUtils.ts +76 -0
- package/src/modules/workspace/components/renderers/htmlSandbox.ts +332 -0
- package/src/modules/workspace/components/renderers/index.ts +39 -0
- package/src/modules/workspace/components/renderers/types.ts +27 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +298 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +1315 -0
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +99 -0
- package/src/modules/workspace/routing/kb-routes.ts +266 -0
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +72 -0
- package/src/modules/workspace/services/workspace.api.ts +185 -0
- package/src/modules/workspace/state/workspace.context.ts +235 -0
- package/src/modules/workspace/utils/__tests__/frontmatter.test.ts +107 -0
- package/src/modules/workspace/utils/diff.ts +53 -0
- package/src/modules/workspace/utils/fileTree.ts +179 -0
- package/src/modules/workspace/utils/frontmatter.ts +80 -0
- package/src/modules/workspace/utils/readDroppedEntries.ts +119 -0
- package/src/modules/workspace/utils/tab-persistence.ts +23 -0
- package/src/shared/components/Dialog.tsx +198 -0
- package/src/shared/components/PageShell.tsx +51 -0
- package/src/shared/components/useModalLayer.ts +35 -0
- package/src/shared/markdown/Markdown.tsx +62 -0
- package/src/test-setup.ts +59 -0
|
@@ -0,0 +1,666 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { render, screen, fireEvent, waitFor, act, cleanup } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import { MemoryRouter } from 'react-router-dom';
|
|
5
|
+
import type { FileTreeEntry } from '@bevel-software/platform-shared';
|
|
6
|
+
import { FileExplorer } from '../FileExplorer';
|
|
7
|
+
import { WorkspaceContext, type UploadError, type WorkspaceContextValue } from '../../state/workspace.context';
|
|
8
|
+
import { makeWorkspaceFixture } from '../../__tests__/testFixtures';
|
|
9
|
+
import { GitContext, type GitContextValue } from '../../../git/state/git.context';
|
|
10
|
+
import { AuthContext, type AuthContextValue } from '../../../auth/state/auth.context';
|
|
11
|
+
import { PrViewerContext, type PrViewerContextValue } from '../../../pr/state/pr-viewer.context';
|
|
12
|
+
|
|
13
|
+
// PullRequestsForMe pulls in router/git wiring we don't want to exercise here;
|
|
14
|
+
// stub it so the toolbar can be tested in isolation.
|
|
15
|
+
vi.mock('../../../git/components/PullRequestsForMe', () => ({
|
|
16
|
+
PullRequestsForMe: () => null,
|
|
17
|
+
}));
|
|
18
|
+
|
|
19
|
+
// authFetch is the bearer-token wrapper around window.fetch. The Download
|
|
20
|
+
// click test asserts the URL + ?download=1 flag, so we mock it at the
|
|
21
|
+
// module level rather than monkey-patching globalThis.fetch.
|
|
22
|
+
const mockAuthFetch = vi.fn();
|
|
23
|
+
vi.mock('../../../../lib/api', () => ({
|
|
24
|
+
authFetch: (...args: unknown[]) => mockAuthFetch(...args),
|
|
25
|
+
}));
|
|
26
|
+
|
|
27
|
+
const EMPTY_TREE: FileTreeEntry = {
|
|
28
|
+
name: '.',
|
|
29
|
+
relativePath: '.',
|
|
30
|
+
type: 'directory',
|
|
31
|
+
children: [],
|
|
32
|
+
};
|
|
33
|
+
|
|
34
|
+
function makeAuth(): AuthContextValue {
|
|
35
|
+
return {
|
|
36
|
+
user: null,
|
|
37
|
+
token: null,
|
|
38
|
+
isLoading: false,
|
|
39
|
+
login: async () => {},
|
|
40
|
+
logout: () => {},
|
|
41
|
+
};
|
|
42
|
+
}
|
|
43
|
+
|
|
44
|
+
function makeGit(): GitContextValue {
|
|
45
|
+
return {
|
|
46
|
+
status: {
|
|
47
|
+
branch: 'alice/draft',
|
|
48
|
+
hasUpstream: true,
|
|
49
|
+
unmergedFromUpstream: false,
|
|
50
|
+
},
|
|
51
|
+
branches: [],
|
|
52
|
+
availability: 'ready',
|
|
53
|
+
lastError: null,
|
|
54
|
+
refreshStatus: async () => null,
|
|
55
|
+
refreshBranches: async () => {},
|
|
56
|
+
createBranch: async () => {},
|
|
57
|
+
deleteBranch: async () => {},
|
|
58
|
+
pull: async () => {},
|
|
59
|
+
fetchForkBase: async () => null,
|
|
60
|
+
revert: async () => ({ sha: 'a', authorName: 'n', authorEmail: 'e', subject: 's', committedAt: '2026-04-29T00:00:00Z' }),
|
|
61
|
+
fetchFileHistory: async () => [],
|
|
62
|
+
fetchFileDiff: async () => '',
|
|
63
|
+
fetchFileComparison: async () => '',
|
|
64
|
+
};
|
|
65
|
+
}
|
|
66
|
+
|
|
67
|
+
function makePrViewer(): PrViewerContextValue {
|
|
68
|
+
return {
|
|
69
|
+
openPrNumber: null,
|
|
70
|
+
detail: null,
|
|
71
|
+
notFound: false,
|
|
72
|
+
selectedPath: null,
|
|
73
|
+
isLoading: false,
|
|
74
|
+
lastError: null,
|
|
75
|
+
openPr: () => {},
|
|
76
|
+
closeViewer: () => {},
|
|
77
|
+
selectPath: () => {},
|
|
78
|
+
refresh: async () => {},
|
|
79
|
+
};
|
|
80
|
+
}
|
|
81
|
+
|
|
82
|
+
interface RenderOptions {
|
|
83
|
+
dispatchUpload?: ReturnType<typeof vi.fn>;
|
|
84
|
+
clearUploadError?: ReturnType<typeof vi.fn>;
|
|
85
|
+
isUploading?: boolean;
|
|
86
|
+
uploadError?: UploadError | null;
|
|
87
|
+
fileTree?: FileTreeEntry | null;
|
|
88
|
+
createFile?: ReturnType<typeof vi.fn>;
|
|
89
|
+
}
|
|
90
|
+
|
|
91
|
+
function renderExplorer(opts: RenderOptions = {}) {
|
|
92
|
+
const dispatchUpload = opts.dispatchUpload ?? vi.fn().mockResolvedValue(undefined);
|
|
93
|
+
const clearUploadError = opts.clearUploadError ?? vi.fn();
|
|
94
|
+
const createFile = opts.createFile ?? vi.fn().mockResolvedValue(undefined);
|
|
95
|
+
// Distinguish "caller wants null tree" from "caller didn't pass anything".
|
|
96
|
+
const fileTree = 'fileTree' in opts ? opts.fileTree ?? null : EMPTY_TREE;
|
|
97
|
+
const workspace: WorkspaceContextValue = makeWorkspaceFixture({
|
|
98
|
+
fileTree,
|
|
99
|
+
uploadError: opts.uploadError ?? null,
|
|
100
|
+
isUploading: opts.isUploading ?? false,
|
|
101
|
+
refreshFileTree: async () => fileTree,
|
|
102
|
+
dispatchUpload,
|
|
103
|
+
clearUploadError,
|
|
104
|
+
createFile,
|
|
105
|
+
});
|
|
106
|
+
return {
|
|
107
|
+
dispatchUpload,
|
|
108
|
+
clearUploadError,
|
|
109
|
+
createFile,
|
|
110
|
+
...render(
|
|
111
|
+
<MemoryRouter>
|
|
112
|
+
<AuthContext.Provider value={makeAuth()}>
|
|
113
|
+
<WorkspaceContext.Provider value={workspace}>
|
|
114
|
+
<GitContext.Provider value={makeGit()}>
|
|
115
|
+
<PrViewerContext.Provider value={makePrViewer()}>
|
|
116
|
+
<FileExplorer />
|
|
117
|
+
</PrViewerContext.Provider>
|
|
118
|
+
</GitContext.Provider>
|
|
119
|
+
</WorkspaceContext.Provider>
|
|
120
|
+
</AuthContext.Provider>
|
|
121
|
+
</MemoryRouter>,
|
|
122
|
+
),
|
|
123
|
+
};
|
|
124
|
+
}
|
|
125
|
+
|
|
126
|
+
function getFileInput(): HTMLInputElement {
|
|
127
|
+
return screen.getByTestId('file-explorer-file-input') as HTMLInputElement;
|
|
128
|
+
}
|
|
129
|
+
|
|
130
|
+
describe('FileExplorer toolbar', () => {
|
|
131
|
+
beforeEach(() => {
|
|
132
|
+
cleanup();
|
|
133
|
+
});
|
|
134
|
+
|
|
135
|
+
it('renders the Add files button and the hidden file input', () => {
|
|
136
|
+
renderExplorer();
|
|
137
|
+
const button = screen.getByRole('button', { name: /Add files/i });
|
|
138
|
+
expect(button).toBeInTheDocument();
|
|
139
|
+
expect(button).not.toBeDisabled();
|
|
140
|
+
const input = getFileInput();
|
|
141
|
+
expect(input).toBeInTheDocument();
|
|
142
|
+
expect(input.type).toBe('file');
|
|
143
|
+
expect(input.multiple).toBe(true);
|
|
144
|
+
expect(input.hidden).toBe(true);
|
|
145
|
+
});
|
|
146
|
+
|
|
147
|
+
it('triggers the hidden file input when the Add files button is clicked', async () => {
|
|
148
|
+
const user = userEvent.setup();
|
|
149
|
+
renderExplorer();
|
|
150
|
+
const input = getFileInput();
|
|
151
|
+
const clickSpy = vi.spyOn(input, 'click');
|
|
152
|
+
await user.click(screen.getByRole('button', { name: /Add files/i }));
|
|
153
|
+
expect(clickSpy).toHaveBeenCalledTimes(1);
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
it('calls dispatchUpload with the selected file at the workspace root', async () => {
|
|
157
|
+
const dispatchUpload = vi.fn().mockResolvedValue(undefined);
|
|
158
|
+
renderExplorer({ dispatchUpload });
|
|
159
|
+
const file = new File(['hello'], 'note.md', { type: 'text/markdown' });
|
|
160
|
+
const input = getFileInput();
|
|
161
|
+
await act(async () => {
|
|
162
|
+
fireEvent.change(input, { target: { files: [file] } });
|
|
163
|
+
});
|
|
164
|
+
expect(dispatchUpload).toHaveBeenCalledTimes(1);
|
|
165
|
+
const [uploadInput, dir] = dispatchUpload.mock.calls[0];
|
|
166
|
+
expect(uploadInput.kind).toBe('files');
|
|
167
|
+
expect(uploadInput.files).toHaveLength(1);
|
|
168
|
+
expect(uploadInput.files[0].name).toBe('note.md');
|
|
169
|
+
expect(dir).toBe('');
|
|
170
|
+
});
|
|
171
|
+
|
|
172
|
+
it('passes every file when multiple are selected at once', async () => {
|
|
173
|
+
const dispatchUpload = vi.fn().mockResolvedValue(undefined);
|
|
174
|
+
renderExplorer({ dispatchUpload });
|
|
175
|
+
const a = new File(['a'], 'a.md');
|
|
176
|
+
const b = new File(['b'], 'b.md');
|
|
177
|
+
const c = new File(['c'], 'c.md');
|
|
178
|
+
await act(async () => {
|
|
179
|
+
fireEvent.change(getFileInput(), { target: { files: [a, b, c] } });
|
|
180
|
+
});
|
|
181
|
+
expect(dispatchUpload).toHaveBeenCalledTimes(1);
|
|
182
|
+
const [uploadInput] = dispatchUpload.mock.calls[0];
|
|
183
|
+
expect(uploadInput.kind).toBe('files');
|
|
184
|
+
expect(uploadInput.files.map((f: File) => f.name)).toEqual(['a.md', 'b.md', 'c.md']);
|
|
185
|
+
});
|
|
186
|
+
|
|
187
|
+
it('resets input.value after dispatch so the same file can be re-selected', async () => {
|
|
188
|
+
const dispatchUpload = vi.fn().mockResolvedValue(undefined);
|
|
189
|
+
renderExplorer({ dispatchUpload });
|
|
190
|
+
const input = getFileInput();
|
|
191
|
+
const file = new File(['x'], 'same.md');
|
|
192
|
+
await act(async () => {
|
|
193
|
+
fireEvent.change(input, { target: { files: [file] } });
|
|
194
|
+
});
|
|
195
|
+
expect(input.value).toBe('');
|
|
196
|
+
// Second selection of the same file fires another dispatch.
|
|
197
|
+
await act(async () => {
|
|
198
|
+
fireEvent.change(input, { target: { files: [file] } });
|
|
199
|
+
});
|
|
200
|
+
expect(dispatchUpload).toHaveBeenCalledTimes(2);
|
|
201
|
+
});
|
|
202
|
+
|
|
203
|
+
it('does not call dispatchUpload when the user cancels the dialog', async () => {
|
|
204
|
+
const dispatchUpload = vi.fn().mockResolvedValue(undefined);
|
|
205
|
+
renderExplorer({ dispatchUpload });
|
|
206
|
+
await act(async () => {
|
|
207
|
+
fireEvent.change(getFileInput(), { target: { files: [] } });
|
|
208
|
+
});
|
|
209
|
+
expect(dispatchUpload).not.toHaveBeenCalled();
|
|
210
|
+
});
|
|
211
|
+
|
|
212
|
+
it('disables the Add files button while an upload is in flight', () => {
|
|
213
|
+
renderExplorer({ isUploading: true });
|
|
214
|
+
const button = screen.getByRole('button', { name: 'Add files' });
|
|
215
|
+
expect(button).toBeDisabled();
|
|
216
|
+
});
|
|
217
|
+
|
|
218
|
+
it('renders the upload error inline with filename and reason', () => {
|
|
219
|
+
renderExplorer({
|
|
220
|
+
uploadError: { filename: 'huge.bin', reason: 'File exceeds 52428800 byte limit' },
|
|
221
|
+
});
|
|
222
|
+
const alert = screen.getByRole('alert');
|
|
223
|
+
expect(alert).toHaveTextContent("Couldn't add huge.bin");
|
|
224
|
+
expect(alert).toHaveTextContent('File exceeds 52428800 byte limit');
|
|
225
|
+
});
|
|
226
|
+
|
|
227
|
+
it('clears the upload error when the dismiss button is clicked', async () => {
|
|
228
|
+
const user = userEvent.setup();
|
|
229
|
+
const clearUploadError = vi.fn();
|
|
230
|
+
renderExplorer({
|
|
231
|
+
uploadError: { filename: 'oops.md', reason: 'boom' },
|
|
232
|
+
clearUploadError,
|
|
233
|
+
});
|
|
234
|
+
await user.click(screen.getByRole('button', { name: /Dismiss upload error/i }));
|
|
235
|
+
expect(clearUploadError).toHaveBeenCalledTimes(1);
|
|
236
|
+
});
|
|
237
|
+
|
|
238
|
+
it('does not render the error region when uploadError is null', () => {
|
|
239
|
+
renderExplorer({ uploadError: null });
|
|
240
|
+
expect(screen.queryByRole('alert')).not.toBeInTheDocument();
|
|
241
|
+
});
|
|
242
|
+
|
|
243
|
+
it('routes root-level drag-and-drop through dispatchUpload (parity with the button)', async () => {
|
|
244
|
+
const dispatchUpload = vi.fn().mockResolvedValue(undefined);
|
|
245
|
+
renderExplorer({ dispatchUpload });
|
|
246
|
+
const aside = screen.getByRole('complementary');
|
|
247
|
+
const file = new File(['drop'], 'dropped.md');
|
|
248
|
+
await act(async () => {
|
|
249
|
+
fireEvent.drop(aside, {
|
|
250
|
+
dataTransfer: {
|
|
251
|
+
// No `items` (the drop handler tries FileSystem entries first,
|
|
252
|
+
// falling back to `files` for raw FileList drops / older browsers).
|
|
253
|
+
files: [file],
|
|
254
|
+
getData: () => '',
|
|
255
|
+
},
|
|
256
|
+
});
|
|
257
|
+
});
|
|
258
|
+
expect(dispatchUpload).toHaveBeenCalledTimes(1);
|
|
259
|
+
const [uploadInput, dir] = dispatchUpload.mock.calls[0];
|
|
260
|
+
expect(uploadInput.kind).toBe('files');
|
|
261
|
+
expect(uploadInput.files[0].name).toBe('dropped.md');
|
|
262
|
+
expect(dir).toBe('');
|
|
263
|
+
});
|
|
264
|
+
|
|
265
|
+
it('renders the loading placeholder when fileTree is null', async () => {
|
|
266
|
+
renderExplorer({ fileTree: null });
|
|
267
|
+
await waitFor(() => {
|
|
268
|
+
expect(screen.getByText(/Loading/i)).toBeInTheDocument();
|
|
269
|
+
});
|
|
270
|
+
});
|
|
271
|
+
});
|
|
272
|
+
|
|
273
|
+
describe('FileExplorer right-click — Download menu (per-path access)', () => {
|
|
274
|
+
beforeEach(() => {
|
|
275
|
+
cleanup();
|
|
276
|
+
mockAuthFetch.mockReset();
|
|
277
|
+
});
|
|
278
|
+
|
|
279
|
+
// A tree with one file and one folder so we can exercise both menu items
|
|
280
|
+
// — files render `Download`, folders render `Download as zip`.
|
|
281
|
+
const TREE_WITH_BOTH: FileTreeEntry = {
|
|
282
|
+
name: '.',
|
|
283
|
+
relativePath: '.',
|
|
284
|
+
type: 'directory',
|
|
285
|
+
children: [
|
|
286
|
+
{
|
|
287
|
+
name: 'reports',
|
|
288
|
+
relativePath: 'reports',
|
|
289
|
+
type: 'directory',
|
|
290
|
+
children: [],
|
|
291
|
+
},
|
|
292
|
+
{
|
|
293
|
+
name: 'brief.md',
|
|
294
|
+
relativePath: 'brief.md',
|
|
295
|
+
type: 'file',
|
|
296
|
+
},
|
|
297
|
+
],
|
|
298
|
+
};
|
|
299
|
+
|
|
300
|
+
function renderWithTree() {
|
|
301
|
+
return renderExplorer({ fileTree: TREE_WITH_BOTH });
|
|
302
|
+
}
|
|
303
|
+
|
|
304
|
+
// Under the path-scoped `download:` verb model there is no global
|
|
305
|
+
// preflight: the menu items always render. The backend returns 403 at
|
|
306
|
+
// click time for users without permission on that specific path; the
|
|
307
|
+
// click handler surfaces it via an alert.
|
|
308
|
+
|
|
309
|
+
it('shows Download on files (no preflight gate)', () => {
|
|
310
|
+
renderWithTree();
|
|
311
|
+
fireEvent.contextMenu(screen.getByText('brief.md'));
|
|
312
|
+
expect(screen.getByText('Download')).toBeInTheDocument();
|
|
313
|
+
});
|
|
314
|
+
|
|
315
|
+
it('shows Download as zip on folders (no preflight gate)', () => {
|
|
316
|
+
renderWithTree();
|
|
317
|
+
fireEvent.contextMenu(screen.getByText('reports'));
|
|
318
|
+
expect(screen.getByText('Download as zip')).toBeInTheDocument();
|
|
319
|
+
});
|
|
320
|
+
|
|
321
|
+
it('surfaces a 403 from the backend as an alert when the user lacks download on the clicked path', async () => {
|
|
322
|
+
mockAuthFetch.mockResolvedValue({
|
|
323
|
+
ok: false,
|
|
324
|
+
status: 403,
|
|
325
|
+
text: async () => '{"error":"Download permission required"}',
|
|
326
|
+
});
|
|
327
|
+
const alertSpy = vi.spyOn(window, 'alert').mockImplementation(() => {});
|
|
328
|
+
try {
|
|
329
|
+
renderWithTree();
|
|
330
|
+
fireEvent.contextMenu(screen.getByText('brief.md'));
|
|
331
|
+
await act(async () => {
|
|
332
|
+
fireEvent.click(screen.getByText('Download'));
|
|
333
|
+
});
|
|
334
|
+
expect(alertSpy).toHaveBeenCalledTimes(1);
|
|
335
|
+
const msg = alertSpy.mock.calls[0][0] as string;
|
|
336
|
+
expect(msg).toContain('brief.md');
|
|
337
|
+
expect(msg).toContain('403');
|
|
338
|
+
} finally {
|
|
339
|
+
alertSpy.mockRestore();
|
|
340
|
+
}
|
|
341
|
+
});
|
|
342
|
+
|
|
343
|
+
it('calls /file/raw?download=1 with the entry path and saves the blob', async () => {
|
|
344
|
+
mockAuthFetch.mockResolvedValue({
|
|
345
|
+
ok: true,
|
|
346
|
+
status: 200,
|
|
347
|
+
blob: async () => new Blob(['bytes']),
|
|
348
|
+
text: async () => '',
|
|
349
|
+
});
|
|
350
|
+
const createObjectURL = vi.fn(() => 'blob:fake-url');
|
|
351
|
+
const revokeObjectURL = vi.fn();
|
|
352
|
+
(globalThis.URL as any).createObjectURL = createObjectURL;
|
|
353
|
+
(globalThis.URL as any).revokeObjectURL = revokeObjectURL;
|
|
354
|
+
|
|
355
|
+
renderWithTree();
|
|
356
|
+
fireEvent.contextMenu(screen.getByText('brief.md'));
|
|
357
|
+
await act(async () => {
|
|
358
|
+
fireEvent.click(screen.getByText('Download'));
|
|
359
|
+
});
|
|
360
|
+
|
|
361
|
+
expect(mockAuthFetch).toHaveBeenCalledTimes(1);
|
|
362
|
+
const url = mockAuthFetch.mock.calls[0][0] as string;
|
|
363
|
+
expect(url).toContain('/api/workspace/ws-1/file/raw');
|
|
364
|
+
expect(url).toContain('path=brief.md');
|
|
365
|
+
expect(url).toContain('download=1');
|
|
366
|
+
expect(createObjectURL).toHaveBeenCalled();
|
|
367
|
+
expect(revokeObjectURL).toHaveBeenCalledWith('blob:fake-url');
|
|
368
|
+
});
|
|
369
|
+
|
|
370
|
+
it('calls /folder/zip?download=1 and triggers a <folder>.zip save when clicking Download as zip on a folder', async () => {
|
|
371
|
+
mockAuthFetch.mockResolvedValue({
|
|
372
|
+
ok: true,
|
|
373
|
+
status: 200,
|
|
374
|
+
blob: async () => new Blob(['PK', 'bytes']),
|
|
375
|
+
text: async () => '',
|
|
376
|
+
});
|
|
377
|
+
const createObjectURL = vi.fn(() => 'blob:fake-zip-url');
|
|
378
|
+
const revokeObjectURL = vi.fn();
|
|
379
|
+
(globalThis.URL as any).createObjectURL = createObjectURL;
|
|
380
|
+
(globalThis.URL as any).revokeObjectURL = revokeObjectURL;
|
|
381
|
+
|
|
382
|
+
// Spy on anchor `.download` to confirm we save as <folder>.zip.
|
|
383
|
+
const anchorDownloadValues: string[] = [];
|
|
384
|
+
const realCreate = document.createElement.bind(document);
|
|
385
|
+
const createSpy = vi.spyOn(document, 'createElement').mockImplementation((tag: string) => {
|
|
386
|
+
const el = realCreate(tag);
|
|
387
|
+
if (tag === 'a') {
|
|
388
|
+
Object.defineProperty(el, 'download', {
|
|
389
|
+
set(val: string) { anchorDownloadValues.push(val); },
|
|
390
|
+
get() { return anchorDownloadValues[anchorDownloadValues.length - 1] ?? ''; },
|
|
391
|
+
configurable: true,
|
|
392
|
+
});
|
|
393
|
+
}
|
|
394
|
+
return el;
|
|
395
|
+
});
|
|
396
|
+
|
|
397
|
+
// try/finally guarantees the spy is restored even if an assertion below
|
|
398
|
+
// throws — otherwise document.createElement stays mocked at the module
|
|
399
|
+
// level and contaminates later tests.
|
|
400
|
+
try {
|
|
401
|
+
renderWithTree();
|
|
402
|
+
fireEvent.contextMenu(screen.getByText('reports'));
|
|
403
|
+
await act(async () => {
|
|
404
|
+
fireEvent.click(screen.getByText('Download as zip'));
|
|
405
|
+
});
|
|
406
|
+
|
|
407
|
+
expect(mockAuthFetch).toHaveBeenCalledTimes(1);
|
|
408
|
+
const url = mockAuthFetch.mock.calls[0][0] as string;
|
|
409
|
+
expect(url).toContain('/api/workspace/ws-1/folder/zip');
|
|
410
|
+
expect(url).toContain('path=reports');
|
|
411
|
+
expect(url).toContain('download=1');
|
|
412
|
+
expect(anchorDownloadValues).toContain('reports.zip');
|
|
413
|
+
} finally {
|
|
414
|
+
createSpy.mockRestore();
|
|
415
|
+
}
|
|
416
|
+
});
|
|
417
|
+
});
|
|
418
|
+
|
|
419
|
+
// Regression coverage for the FileTreeNode collapse state machine. PR #113
|
|
420
|
+
// derived `autoExpanded` reactively without an escape hatch, so clicking the
|
|
421
|
+
// chevron on a folder that contained the open file did nothing — the user's
|
|
422
|
+
// `expanded=false` was shadowed by `autoExpanded=true` on the next render.
|
|
423
|
+
// The fix introduces a tri-state `userIntent` that overrides auto-expand and
|
|
424
|
+
// resets when the auto-expand trigger transitions. These tests would have
|
|
425
|
+
// caught the original regression.
|
|
426
|
+
describe('FileExplorer chevron collapse — userIntent vs autoExpanded', () => {
|
|
427
|
+
beforeEach(() => {
|
|
428
|
+
cleanup();
|
|
429
|
+
});
|
|
430
|
+
|
|
431
|
+
const NESTED_TREE: FileTreeEntry = {
|
|
432
|
+
name: '.',
|
|
433
|
+
relativePath: '.',
|
|
434
|
+
type: 'directory',
|
|
435
|
+
children: [
|
|
436
|
+
{
|
|
437
|
+
name: 'docs',
|
|
438
|
+
relativePath: 'docs',
|
|
439
|
+
type: 'directory',
|
|
440
|
+
children: [
|
|
441
|
+
{ name: 'a.md', relativePath: 'docs/a.md', type: 'file' },
|
|
442
|
+
{ name: 'b.md', relativePath: 'docs/b.md', type: 'file' },
|
|
443
|
+
],
|
|
444
|
+
},
|
|
445
|
+
],
|
|
446
|
+
};
|
|
447
|
+
|
|
448
|
+
function ExplorerHarness({
|
|
449
|
+
openFilePath,
|
|
450
|
+
fileTree,
|
|
451
|
+
}: {
|
|
452
|
+
openFilePath: string | null;
|
|
453
|
+
fileTree: FileTreeEntry;
|
|
454
|
+
}) {
|
|
455
|
+
const workspace = makeWorkspaceFixture({ fileTree, openFilePath });
|
|
456
|
+
return (
|
|
457
|
+
<MemoryRouter>
|
|
458
|
+
<AuthContext.Provider value={makeAuth()}>
|
|
459
|
+
<WorkspaceContext.Provider value={workspace}>
|
|
460
|
+
<GitContext.Provider value={makeGit()}>
|
|
461
|
+
<PrViewerContext.Provider value={makePrViewer()}>
|
|
462
|
+
<FileExplorer />
|
|
463
|
+
</PrViewerContext.Provider>
|
|
464
|
+
</GitContext.Provider>
|
|
465
|
+
</WorkspaceContext.Provider>
|
|
466
|
+
</AuthContext.Provider>
|
|
467
|
+
</MemoryRouter>
|
|
468
|
+
);
|
|
469
|
+
}
|
|
470
|
+
|
|
471
|
+
it('collapses a folder whose open file lives inside it (the PR #113 regression)', () => {
|
|
472
|
+
render(<ExplorerHarness openFilePath="docs/a.md" fileTree={NESTED_TREE} />);
|
|
473
|
+
// Auto-expand kicked in because openFilePath is inside `docs`, so a.md
|
|
474
|
+
// is initially visible in the tree.
|
|
475
|
+
expect(screen.getByText('a.md')).toBeInTheDocument();
|
|
476
|
+
// Click the docs row (event bubbles to the button that toggles userIntent).
|
|
477
|
+
fireEvent.click(screen.getByText('docs'));
|
|
478
|
+
// The whole point: user intent must beat autoExpanded.
|
|
479
|
+
expect(screen.queryByText('a.md')).not.toBeInTheDocument();
|
|
480
|
+
expect(screen.queryByText('b.md')).not.toBeInTheDocument();
|
|
481
|
+
});
|
|
482
|
+
|
|
483
|
+
it('re-expands a previously-collapsed folder when a different file inside it becomes the open file', () => {
|
|
484
|
+
const { rerender } = render(
|
|
485
|
+
<ExplorerHarness openFilePath="docs/a.md" fileTree={NESTED_TREE} />,
|
|
486
|
+
);
|
|
487
|
+
fireEvent.click(screen.getByText('docs'));
|
|
488
|
+
expect(screen.queryByText('a.md')).not.toBeInTheDocument();
|
|
489
|
+
// openFilePath transitions to a sibling — autoTrigger flips, userIntent
|
|
490
|
+
// resets to null, autoExpanded re-takes the wheel.
|
|
491
|
+
rerender(<ExplorerHarness openFilePath="docs/b.md" fileTree={NESTED_TREE} />);
|
|
492
|
+
expect(screen.getByText('a.md')).toBeInTheDocument();
|
|
493
|
+
expect(screen.getByText('b.md')).toBeInTheDocument();
|
|
494
|
+
});
|
|
495
|
+
|
|
496
|
+
it('renders ancestor folders expanded on deep-link mount so the open file row is visible', () => {
|
|
497
|
+
const deepTree: FileTreeEntry = {
|
|
498
|
+
name: '.',
|
|
499
|
+
relativePath: '.',
|
|
500
|
+
type: 'directory',
|
|
501
|
+
children: [
|
|
502
|
+
{
|
|
503
|
+
name: 'a',
|
|
504
|
+
relativePath: 'a',
|
|
505
|
+
type: 'directory',
|
|
506
|
+
children: [
|
|
507
|
+
{
|
|
508
|
+
name: 'b',
|
|
509
|
+
relativePath: 'a/b',
|
|
510
|
+
type: 'directory',
|
|
511
|
+
children: [
|
|
512
|
+
{
|
|
513
|
+
name: 'c',
|
|
514
|
+
relativePath: 'a/b/c',
|
|
515
|
+
type: 'directory',
|
|
516
|
+
children: [
|
|
517
|
+
{ name: 'deep.md', relativePath: 'a/b/c/deep.md', type: 'file' },
|
|
518
|
+
],
|
|
519
|
+
},
|
|
520
|
+
],
|
|
521
|
+
},
|
|
522
|
+
],
|
|
523
|
+
},
|
|
524
|
+
],
|
|
525
|
+
};
|
|
526
|
+
render(<ExplorerHarness openFilePath="a/b/c/deep.md" fileTree={deepTree} />);
|
|
527
|
+
// Every ancestor is auto-expanded — without this, deep-link URLs would
|
|
528
|
+
// open the file in the viewer but its tree row would stay hidden.
|
|
529
|
+
expect(screen.getByText('a')).toBeInTheDocument();
|
|
530
|
+
expect(screen.getByText('b')).toBeInTheDocument();
|
|
531
|
+
expect(screen.getByText('c')).toBeInTheDocument();
|
|
532
|
+
expect(screen.getByText('deep.md')).toBeInTheDocument();
|
|
533
|
+
});
|
|
534
|
+
|
|
535
|
+
it('keeps folders at depth >= 2 collapsed by default when no file is open', () => {
|
|
536
|
+
const deepTree: FileTreeEntry = {
|
|
537
|
+
name: '.',
|
|
538
|
+
relativePath: '.',
|
|
539
|
+
type: 'directory',
|
|
540
|
+
children: [
|
|
541
|
+
{
|
|
542
|
+
name: 'a',
|
|
543
|
+
relativePath: 'a',
|
|
544
|
+
type: 'directory',
|
|
545
|
+
children: [
|
|
546
|
+
{
|
|
547
|
+
name: 'b',
|
|
548
|
+
relativePath: 'a/b',
|
|
549
|
+
type: 'directory',
|
|
550
|
+
children: [
|
|
551
|
+
{
|
|
552
|
+
name: 'c',
|
|
553
|
+
relativePath: 'a/b/c',
|
|
554
|
+
type: 'directory',
|
|
555
|
+
children: [
|
|
556
|
+
{ name: 'deep.md', relativePath: 'a/b/c/deep.md', type: 'file' },
|
|
557
|
+
],
|
|
558
|
+
},
|
|
559
|
+
],
|
|
560
|
+
},
|
|
561
|
+
],
|
|
562
|
+
},
|
|
563
|
+
],
|
|
564
|
+
};
|
|
565
|
+
render(<ExplorerHarness openFilePath={null} fileTree={deepTree} />);
|
|
566
|
+
// Root (depth 0) and `a` (depth 1) are below the `depth < 2` threshold
|
|
567
|
+
// and render expanded. `b` (depth 2) renders as a row but its children
|
|
568
|
+
// — `c` and `deep.md` — must not appear.
|
|
569
|
+
expect(screen.getByText('a')).toBeInTheDocument();
|
|
570
|
+
expect(screen.getByText('b')).toBeInTheDocument();
|
|
571
|
+
expect(screen.queryByText('c')).not.toBeInTheDocument();
|
|
572
|
+
expect(screen.queryByText('deep.md')).not.toBeInTheDocument();
|
|
573
|
+
});
|
|
574
|
+
});
|
|
575
|
+
|
|
576
|
+
// The KB level splits the well-known root folders into labelled top-level
|
|
577
|
+
// sections. `Data/`, `Agents/` and `Pipelines/` get their own sections like
|
|
578
|
+
// Skills/Tools — they must not fold into the Knowledge section.
|
|
579
|
+
describe('FileExplorer sections — root folders', () => {
|
|
580
|
+
beforeEach(() => {
|
|
581
|
+
cleanup();
|
|
582
|
+
});
|
|
583
|
+
|
|
584
|
+
const dir = (name: string): FileTreeEntry => ({
|
|
585
|
+
name,
|
|
586
|
+
relativePath: name,
|
|
587
|
+
type: 'directory',
|
|
588
|
+
children: [],
|
|
589
|
+
});
|
|
590
|
+
|
|
591
|
+
it('renders Data, Agents and Pipelines as their own top-level sections', () => {
|
|
592
|
+
const tree: FileTreeEntry = {
|
|
593
|
+
name: '.',
|
|
594
|
+
relativePath: '.',
|
|
595
|
+
type: 'directory',
|
|
596
|
+
children: [
|
|
597
|
+
dir('KnowledgeBase'),
|
|
598
|
+
dir('Data'),
|
|
599
|
+
dir('Agents'),
|
|
600
|
+
dir('Pipelines'),
|
|
601
|
+
dir('Skills'),
|
|
602
|
+
dir('Tools'),
|
|
603
|
+
],
|
|
604
|
+
};
|
|
605
|
+
renderExplorer({ fileTree: tree });
|
|
606
|
+
expect(screen.getByText('Knowledge')).toBeInTheDocument();
|
|
607
|
+
expect(screen.getByText('Data')).toBeInTheDocument();
|
|
608
|
+
expect(screen.getByText('Agents')).toBeInTheDocument();
|
|
609
|
+
expect(screen.getByText('Pipelines')).toBeInTheDocument();
|
|
610
|
+
expect(screen.getByText('Skills')).toBeInTheDocument();
|
|
611
|
+
expect(screen.getByText('Tools')).toBeInTheDocument();
|
|
612
|
+
});
|
|
613
|
+
});
|
|
614
|
+
|
|
615
|
+
// Regression: creating a file in a folder the user can't write to used to
|
|
616
|
+
// spam the "Failed to create …" alert in a loop. The create input's onBlur
|
|
617
|
+
// re-fires onSubmit, and the native alert() steals+returns focus — so
|
|
618
|
+
// dismissing the alert blurred the still-mounted input, which re-submitted
|
|
619
|
+
// the same doomed create, which re-alerted, forever. The fix closes the
|
|
620
|
+
// input (setCreating(null)) BEFORE the fallible create, so there's nothing
|
|
621
|
+
// left to re-blur-submit.
|
|
622
|
+
describe('FileExplorer create — no alert loop on a write-denied path', () => {
|
|
623
|
+
beforeEach(() => {
|
|
624
|
+
cleanup();
|
|
625
|
+
});
|
|
626
|
+
|
|
627
|
+
it('shows the create failure alert exactly once and closes the input', async () => {
|
|
628
|
+
const createFile = vi
|
|
629
|
+
.fn()
|
|
630
|
+
.mockRejectedValue(
|
|
631
|
+
new Error('You don\'t have permission to write to "onboarding/KnowledgeBase/j.md". Eligible: Admin.'),
|
|
632
|
+
);
|
|
633
|
+
const alertSpy = vi.spyOn(window, 'alert').mockImplementation(() => {});
|
|
634
|
+
try {
|
|
635
|
+
renderExplorer({ createFile });
|
|
636
|
+
|
|
637
|
+
// Open the inline "New file" input on the root row, type a name, Enter.
|
|
638
|
+
await act(async () => {
|
|
639
|
+
fireEvent.click(screen.getAllByTitle('New file')[0]);
|
|
640
|
+
});
|
|
641
|
+
const input = screen.getByPlaceholderText('filename') as HTMLInputElement;
|
|
642
|
+
await act(async () => {
|
|
643
|
+
fireEvent.change(input, { target: { value: 'j.md' } });
|
|
644
|
+
fireEvent.keyDown(input, { key: 'Enter' });
|
|
645
|
+
});
|
|
646
|
+
|
|
647
|
+
// The create was attempted once and rejected.
|
|
648
|
+
expect(createFile).toHaveBeenCalledTimes(1);
|
|
649
|
+
// The input is gone — so it can no longer re-blur-submit.
|
|
650
|
+
expect(screen.queryByPlaceholderText('filename')).not.toBeInTheDocument();
|
|
651
|
+
|
|
652
|
+
// Simulate the focus returning after the user dismisses the native
|
|
653
|
+
// alert. Before the fix this blur re-fired onSubmit; now the input is
|
|
654
|
+
// unmounted so nothing happens.
|
|
655
|
+
await act(async () => {
|
|
656
|
+
fireEvent.blur(input);
|
|
657
|
+
});
|
|
658
|
+
|
|
659
|
+
expect(alertSpy).toHaveBeenCalledTimes(1);
|
|
660
|
+
expect(createFile).toHaveBeenCalledTimes(1);
|
|
661
|
+
expect(alertSpy.mock.calls[0][0]).toContain('Failed to create j.md');
|
|
662
|
+
} finally {
|
|
663
|
+
alertSpy.mockRestore();
|
|
664
|
+
}
|
|
665
|
+
});
|
|
666
|
+
});
|