@bevel-software/platform-core-frontend 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +202 -0
- package/package.json +70 -0
- package/src/core/CoreAppShell.tsx +444 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +95 -0
- package/src/core/events.ts +29 -0
- package/src/core/registry.ts +336 -0
- package/src/css-side-effect-imports.d.ts +7 -0
- package/src/html-extensions.ts +12 -0
- package/src/index.css +49 -0
- package/src/index.ts +23 -0
- package/src/lib/api.ts +57 -0
- package/src/lib/utils.ts +138 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +130 -0
- package/src/modules/access/__tests__/useFileAccess.test.tsx +253 -0
- package/src/modules/access/api.ts +205 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +31 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +1232 -0
- package/src/modules/access/components/NodeOwnersBanner.tsx +30 -0
- package/src/modules/access/hooks/useFileAccess.ts +151 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +943 -0
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +74 -0
- package/src/modules/admin/services/admin.api.ts +92 -0
- package/src/modules/admin/services/roles.api.ts +136 -0
- package/src/modules/admin/state/admin.context.tsx +223 -0
- package/src/modules/auth/components/LoginScreen.tsx +135 -0
- package/src/modules/auth/hooks/useAuthState.ts +59 -0
- package/src/modules/auth/services/auth.api.ts +24 -0
- package/src/modules/auth/services/microsoft-oauth.ts +57 -0
- package/src/modules/auth/state/auth.context.ts +18 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +347 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +201 -0
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +82 -0
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +441 -0
- package/src/modules/git/__tests__/git.api.test.ts +113 -0
- package/src/modules/git/__tests__/pr.api.test.ts +44 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +212 -0
- package/src/modules/git/components/BranchSwitcher.tsx +527 -0
- package/src/modules/git/components/DiffView.tsx +30 -0
- package/src/modules/git/components/FileComparisonPanel.tsx +377 -0
- package/src/modules/git/components/FileHistoryPanel.tsx +320 -0
- package/src/modules/git/components/ProtectedBranchBanner.tsx +42 -0
- package/src/modules/git/components/PullNeededBanner.tsx +204 -0
- package/src/modules/git/components/PullRequestsForMe.tsx +244 -0
- package/src/modules/git/components/UnifiedDiffView.tsx +37 -0
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +99 -0
- package/src/modules/git/hooks/useAutoPullUpdates.ts +121 -0
- package/src/modules/git/hooks/useGitState.ts +335 -0
- package/src/modules/git/services/__tests__/error-messages.test.ts +134 -0
- package/src/modules/git/services/error-messages.ts +257 -0
- package/src/modules/git/services/git.api.ts +163 -0
- package/src/modules/git/services/pr-prompts.ts +159 -0
- package/src/modules/git/services/pr.api.ts +39 -0
- package/src/modules/git/state/auto-update.context.ts +21 -0
- package/src/modules/git/state/git.context.ts +82 -0
- package/src/modules/layout/components/AppLayout.tsx +40 -0
- package/src/modules/layout/components/DemoBanner.tsx +57 -0
- package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +153 -0
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +203 -0
- package/src/modules/layout/components/SlideOverlay.tsx +224 -0
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +77 -0
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +57 -0
- package/src/modules/layout/hooks/useMediaQuery.ts +23 -0
- package/src/modules/layout/state/__tests__/layout.context.test.tsx +39 -0
- package/src/modules/layout/state/layout.context.ts +46 -0
- package/src/modules/library/__tests__/DetailDialog.test.tsx +200 -0
- package/src/modules/library/__tests__/diff.test.ts +62 -0
- package/src/modules/library/__tests__/loadout.test.tsx +72 -0
- package/src/modules/library/__tests__/status.test.ts +117 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +47 -0
- package/src/modules/library/components/CompareView.tsx +357 -0
- package/src/modules/library/components/DetailDialog.tsx +566 -0
- package/src/modules/library/components/GearIcon.tsx +12 -0
- package/src/modules/library/components/LibraryCard.tsx +132 -0
- package/src/modules/library/components/LibraryPage.tsx +254 -0
- package/src/modules/library/components/LoadoutSidebar.tsx +156 -0
- package/src/modules/library/components/StatusGem.tsx +21 -0
- package/src/modules/library/components/SuggestChange.tsx +171 -0
- package/src/modules/library/components/particles.ts +50 -0
- package/src/modules/library/hooks/useLibraryData.ts +119 -0
- package/src/modules/library/hooks/useSkillDetail.ts +74 -0
- package/src/modules/library/library.css +320 -0
- package/src/modules/library/services/library.api.ts +164 -0
- package/src/modules/library/state/loadout.tsx +129 -0
- package/src/modules/library/state/toast.tsx +42 -0
- package/src/modules/library/utils/diff.ts +102 -0
- package/src/modules/library/utils/status.ts +116 -0
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +93 -0
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +158 -0
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +44 -0
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +360 -0
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +85 -0
- package/src/modules/pr/__tests__/parsePatch.test.ts +104 -0
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +72 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +193 -0
- package/src/modules/pr/components/PrApprovalBadge.tsx +80 -0
- package/src/modules/pr/components/PrCancelButton.tsx +99 -0
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +119 -0
- package/src/modules/pr/components/PrCommentComposer.tsx +92 -0
- package/src/modules/pr/components/PrCommentThread.tsx +168 -0
- package/src/modules/pr/components/PrCommentsPanel.tsx +143 -0
- package/src/modules/pr/components/PrDiffPane.tsx +425 -0
- package/src/modules/pr/components/PrFileRow.tsx +164 -0
- package/src/modules/pr/components/PrFilesList.tsx +53 -0
- package/src/modules/pr/components/PrHeader.tsx +45 -0
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +58 -0
- package/src/modules/pr/components/PrMergeButton.tsx +268 -0
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +112 -0
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +110 -0
- package/src/modules/pr/components/PrViewer.tsx +364 -0
- package/src/modules/pr/hooks/usePrViewerState.ts +150 -0
- package/src/modules/pr/services/pr-approvals.api.ts +31 -0
- package/src/modules/pr/services/pr-cancel.api.ts +19 -0
- package/src/modules/pr/services/pr-comments.api.ts +45 -0
- package/src/modules/pr/services/pr-detail.api.ts +17 -0
- package/src/modules/pr/services/pr-merge.api.ts +53 -0
- package/src/modules/pr/services/pr-open.api.ts +30 -0
- package/src/modules/pr/state/pr-viewer.context.ts +34 -0
- package/src/modules/pr/utils/bucketize-comments.ts +55 -0
- package/src/modules/pr/utils/parsePatch.ts +57 -0
- package/src/modules/review/__tests__/review.api.test.ts +121 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +15 -0
- package/src/modules/review/components/DiffViewer.tsx +78 -0
- package/src/modules/review/components/MarkdownDiffViewer.tsx +263 -0
- package/src/modules/review/components/ReviewFileRow.tsx +114 -0
- package/src/modules/review/components/ReviewPanel.tsx +260 -0
- package/src/modules/review/components/ReviewPanelSurface.tsx +52 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +106 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +88 -0
- package/src/modules/review/hooks/useReviewState.ts +256 -0
- package/src/modules/review/services/review.api.ts +72 -0
- package/src/modules/review/state/ReviewProvider.tsx +28 -0
- package/src/modules/review/state/review.context.ts +29 -0
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +488 -0
- package/src/modules/secrets-vault/components/SecretsPage.tsx +276 -0
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +362 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +51 -0
- package/src/modules/secrets-vault/services/connect.api.ts +113 -0
- package/src/modules/secrets-vault/services/secrets.api.ts +82 -0
- package/src/modules/secrets-vault/services/tool-secrets.api.ts +116 -0
- package/src/modules/toolbar/components/AdminMenu.tsx +250 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +108 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -0
- package/src/modules/toolbar/components/Toolbar.tsx +123 -0
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +122 -0
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +353 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +65 -0
- package/src/modules/tools/ToolsExplorerPage.tsx +380 -0
- package/src/modules/workflow/hooks/useEventBusSubscription.ts +24 -0
- package/src/modules/workflow/hooks/useFileLock.ts +430 -0
- package/src/modules/workflow/services/lock.api.ts +139 -0
- package/src/modules/workflow/state/EventBusFocusBinder.tsx +25 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +232 -0
- package/src/modules/workflow/state/event-bus.context.ts +75 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +54 -0
- package/src/modules/workspace/__tests__/useWorkspaceState.test.ts +91 -0
- package/src/modules/workspace/components/EditorTabs.tsx +384 -0
- package/src/modules/workspace/components/FileExplorer.tsx +1068 -0
- package/src/modules/workspace/components/FileRoute.tsx +392 -0
- package/src/modules/workspace/components/FileViewer.tsx +906 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +241 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +666 -0
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +330 -0
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +492 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +174 -0
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +87 -0
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +231 -0
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +50 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +287 -0
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +252 -0
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +268 -0
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +81 -0
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +86 -0
- package/src/modules/workspace/components/renderers/ToolForm.tsx +404 -0
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +417 -0
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +157 -0
- package/src/modules/workspace/components/renderers/__tests__/CsvRenderer.test.ts +57 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +95 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +328 -0
- package/src/modules/workspace/components/renderers/__tests__/PdfRenderer.test.tsx +167 -0
- package/src/modules/workspace/components/renderers/__tests__/htmlSandbox.test.ts +318 -0
- package/src/modules/workspace/components/renderers/csvUtils.ts +76 -0
- package/src/modules/workspace/components/renderers/htmlSandbox.ts +332 -0
- package/src/modules/workspace/components/renderers/index.ts +39 -0
- package/src/modules/workspace/components/renderers/types.ts +27 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +298 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +1315 -0
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +99 -0
- package/src/modules/workspace/routing/kb-routes.ts +266 -0
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +72 -0
- package/src/modules/workspace/services/workspace.api.ts +185 -0
- package/src/modules/workspace/state/workspace.context.ts +235 -0
- package/src/modules/workspace/utils/__tests__/frontmatter.test.ts +107 -0
- package/src/modules/workspace/utils/diff.ts +53 -0
- package/src/modules/workspace/utils/fileTree.ts +179 -0
- package/src/modules/workspace/utils/frontmatter.ts +80 -0
- package/src/modules/workspace/utils/readDroppedEntries.ts +119 -0
- package/src/modules/workspace/utils/tab-persistence.ts +23 -0
- package/src/shared/components/Dialog.tsx +198 -0
- package/src/shared/components/PageShell.tsx +51 -0
- package/src/shared/components/useModalLayer.ts +35 -0
- package/src/shared/markdown/Markdown.tsx +62 -0
- package/src/test-setup.ts +59 -0
|
@@ -0,0 +1,114 @@
|
|
|
1
|
+
import { Check, X, FileEdit, FilePlus2, FileX2, ArrowRightLeft } from 'lucide-react';
|
|
2
|
+
import type { PendingChange } from '@bevel-software/platform-shared';
|
|
3
|
+
|
|
4
|
+
interface Props {
|
|
5
|
+
change: PendingChange;
|
|
6
|
+
active: boolean;
|
|
7
|
+
busy: boolean;
|
|
8
|
+
onSelect(): void;
|
|
9
|
+
onAccept(): void;
|
|
10
|
+
onReject(): void;
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
function kindLabel(kind: PendingChange['kind']): string {
|
|
14
|
+
switch (kind) {
|
|
15
|
+
case 'added': return 'Added';
|
|
16
|
+
case 'deleted': return 'Deleted';
|
|
17
|
+
case 'renamed': return 'Renamed';
|
|
18
|
+
case 'modified': return 'Modified';
|
|
19
|
+
}
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
function KindIcon({ kind }: { kind: PendingChange['kind'] }) {
|
|
23
|
+
const size = 13;
|
|
24
|
+
switch (kind) {
|
|
25
|
+
case 'added': return <FilePlus2 size={size} className="text-emerald-600" />;
|
|
26
|
+
case 'deleted': return <FileX2 size={size} className="text-red-600" />;
|
|
27
|
+
case 'renamed': return <ArrowRightLeft size={size} className="text-bevel" />;
|
|
28
|
+
case 'modified': return <FileEdit size={size} className="text-amber-600" />;
|
|
29
|
+
}
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
export function ReviewFileRow({ change, active, busy, onSelect, onAccept, onReject }: Props) {
|
|
33
|
+
const { kind, path, oldPath, linesAdded, linesRemoved, isBinary } = change;
|
|
34
|
+
|
|
35
|
+
return (
|
|
36
|
+
<div
|
|
37
|
+
role="button"
|
|
38
|
+
tabIndex={0}
|
|
39
|
+
onClick={onSelect}
|
|
40
|
+
onKeyDown={(e) => {
|
|
41
|
+
// Only treat Enter/Space as "select row" when the keypress originated
|
|
42
|
+
// on the row itself — a keyboard activation of the inner Accept/Reject
|
|
43
|
+
// buttons would otherwise bubble up and trigger selection too.
|
|
44
|
+
if (e.target !== e.currentTarget) return;
|
|
45
|
+
if (e.key === 'Enter' || e.key === ' ') {
|
|
46
|
+
e.preventDefault();
|
|
47
|
+
onSelect();
|
|
48
|
+
}
|
|
49
|
+
}}
|
|
50
|
+
className={`group flex items-center gap-2 px-2 py-1.5 rounded cursor-pointer transition-colors border ${
|
|
51
|
+
active
|
|
52
|
+
? 'bg-slate-100 border-slate-300'
|
|
53
|
+
: 'bg-white border-transparent hover:bg-slate-100 hover:border-slate-200'
|
|
54
|
+
}`}
|
|
55
|
+
>
|
|
56
|
+
<KindIcon kind={kind} />
|
|
57
|
+
|
|
58
|
+
<div className="flex-1 min-w-0">
|
|
59
|
+
<div className="flex items-center gap-1.5 text-xs text-slate-900 truncate">
|
|
60
|
+
<span className="truncate font-mono" title={path}>{path}</span>
|
|
61
|
+
<span className="text-[10px] uppercase tracking-wider text-slate-600 shrink-0">
|
|
62
|
+
{kindLabel(kind)}
|
|
63
|
+
</span>
|
|
64
|
+
</div>
|
|
65
|
+
<div className="flex items-center gap-2 text-[10px] text-slate-600 mt-0.5">
|
|
66
|
+
{oldPath && kind === 'renamed' && (
|
|
67
|
+
<span className="font-mono truncate" title={oldPath}>from {oldPath}</span>
|
|
68
|
+
)}
|
|
69
|
+
{isBinary ? (
|
|
70
|
+
<span>binary</span>
|
|
71
|
+
) : (
|
|
72
|
+
<>
|
|
73
|
+
{linesAdded !== null && (
|
|
74
|
+
<span className="text-emerald-600">+{linesAdded}</span>
|
|
75
|
+
)}
|
|
76
|
+
{linesRemoved !== null && (
|
|
77
|
+
<span className="text-red-600">−{linesRemoved}</span>
|
|
78
|
+
)}
|
|
79
|
+
</>
|
|
80
|
+
)}
|
|
81
|
+
</div>
|
|
82
|
+
</div>
|
|
83
|
+
|
|
84
|
+
<div className="flex items-center gap-1 opacity-70 group-hover:opacity-100">
|
|
85
|
+
<button
|
|
86
|
+
type="button"
|
|
87
|
+
disabled={busy}
|
|
88
|
+
onClick={(e) => {
|
|
89
|
+
e.stopPropagation();
|
|
90
|
+
onReject();
|
|
91
|
+
}}
|
|
92
|
+
title="Reject — restore the original"
|
|
93
|
+
aria-label={`Reject change to ${path}`}
|
|
94
|
+
className="p-1 rounded text-slate-600 hover:text-red-700 hover:bg-red-100 disabled:opacity-40 disabled:cursor-not-allowed"
|
|
95
|
+
>
|
|
96
|
+
<X size={13} />
|
|
97
|
+
</button>
|
|
98
|
+
<button
|
|
99
|
+
type="button"
|
|
100
|
+
disabled={busy}
|
|
101
|
+
onClick={(e) => {
|
|
102
|
+
e.stopPropagation();
|
|
103
|
+
onAccept();
|
|
104
|
+
}}
|
|
105
|
+
title="Accept — keep this change"
|
|
106
|
+
aria-label={`Accept change to ${path}`}
|
|
107
|
+
className="p-1 rounded text-slate-600 hover:text-emerald-700 hover:bg-emerald-100 disabled:opacity-40 disabled:cursor-not-allowed"
|
|
108
|
+
>
|
|
109
|
+
<Check size={13} />
|
|
110
|
+
</button>
|
|
111
|
+
</div>
|
|
112
|
+
</div>
|
|
113
|
+
);
|
|
114
|
+
}
|
|
@@ -0,0 +1,260 @@
|
|
|
1
|
+
import { useCallback, useEffect, useRef, useState } from 'react';
|
|
2
|
+
import { Check, Trash2, Eye, ChevronDown, X } from 'lucide-react';
|
|
3
|
+
import type { PendingChange } from '@bevel-software/platform-shared';
|
|
4
|
+
import { useReview } from '../state/review.context';
|
|
5
|
+
import { useWorkspace } from '../../workspace/state/workspace.context';
|
|
6
|
+
import { useFileNav } from '../../workspace/routing/kb-routes';
|
|
7
|
+
import { ReviewFileRow } from './ReviewFileRow';
|
|
8
|
+
import { DiffViewer } from './DiffViewer';
|
|
9
|
+
import { MarkdownDiffViewer } from './MarkdownDiffViewer';
|
|
10
|
+
import { BinaryChangePlaceholder } from './BinaryChangePlaceholder';
|
|
11
|
+
|
|
12
|
+
function isMarkdownPath(p: string): boolean {
|
|
13
|
+
return /\.md$/i.test(p);
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
function basename(p: string): string {
|
|
17
|
+
const i = p.lastIndexOf('/');
|
|
18
|
+
return i >= 0 ? p.slice(i + 1) : p;
|
|
19
|
+
}
|
|
20
|
+
|
|
21
|
+
function kindLabel(kind: PendingChange['kind']): string {
|
|
22
|
+
switch (kind) {
|
|
23
|
+
case 'added': return 'Added';
|
|
24
|
+
case 'deleted': return 'Deleted';
|
|
25
|
+
case 'renamed': return 'Renamed';
|
|
26
|
+
case 'modified': return 'Modified';
|
|
27
|
+
}
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
/**
|
|
31
|
+
* Review panel for pending agent changes. **Opt-in, not a takeover.** The
|
|
32
|
+
* caller (FileViewer) decides when to mount it — the user opens it from the
|
|
33
|
+
* review badge and can dismiss it via `onClose`. It no longer auto-mounts on
|
|
34
|
+
* the existence of changes; that "existence" fact drives the badge instead,
|
|
35
|
+
* keeping "are there changes" and "is the panel open" as separate concerns.
|
|
36
|
+
*
|
|
37
|
+
* Layout: a single top bar with a file-picker dropdown + global actions,
|
|
38
|
+
* then the diff fills the rest. The dropdown replaces the earlier left
|
|
39
|
+
* sidebar so the diff always gets full width — important on mobile where
|
|
40
|
+
* the sidebar was eating most of the screen.
|
|
41
|
+
*/
|
|
42
|
+
export function ReviewPanel({ onClose }: { onClose?: () => void }) {
|
|
43
|
+
const review = useReview();
|
|
44
|
+
const { refreshFileTree } = useWorkspace();
|
|
45
|
+
const { openFile } = useFileNav();
|
|
46
|
+
const [busy, setBusy] = useState(false);
|
|
47
|
+
// `busy` alone is not re-entrant-safe: two rapid clicks (or a click + a
|
|
48
|
+
// keyboard activation of the same button) can both read `busy === false`
|
|
49
|
+
// before React schedules the state update. A synchronous ref flips the
|
|
50
|
+
// lock in the same tick so the second invocation sees the first one.
|
|
51
|
+
const busyRef = useRef(false);
|
|
52
|
+
const [pickerOpen, setPickerOpen] = useState(false);
|
|
53
|
+
const pickerRef = useRef<HTMLDivElement>(null);
|
|
54
|
+
// Default action scope is the single selected file. The "Apply to all"
|
|
55
|
+
// checkbox (off by default) widens Accept/Delete to every pending change.
|
|
56
|
+
const [applyToAll, setApplyToAll] = useState(false);
|
|
57
|
+
|
|
58
|
+
const { session, selectedPath, fileDiff, isLoadingDiff, selectPath } = review;
|
|
59
|
+
|
|
60
|
+
// Auto-select the first change whenever the selection is empty but changes exist.
|
|
61
|
+
// Keeps the diff pane populated after an accept/reject collapses the selected row.
|
|
62
|
+
useEffect(() => {
|
|
63
|
+
if (!session || session.changes.length === 0) return;
|
|
64
|
+
if (selectedPath) return;
|
|
65
|
+
const first = session.changes[0];
|
|
66
|
+
selectPath(first.path);
|
|
67
|
+
}, [session, selectedPath, selectPath]);
|
|
68
|
+
|
|
69
|
+
// Close the picker on outside click / ESC.
|
|
70
|
+
useEffect(() => {
|
|
71
|
+
if (!pickerOpen) return;
|
|
72
|
+
const onMouseDown = (e: MouseEvent) => {
|
|
73
|
+
if (pickerRef.current && !pickerRef.current.contains(e.target as Node)) {
|
|
74
|
+
setPickerOpen(false);
|
|
75
|
+
}
|
|
76
|
+
};
|
|
77
|
+
const onKey = (e: KeyboardEvent) => {
|
|
78
|
+
if (e.key === 'Escape') setPickerOpen(false);
|
|
79
|
+
};
|
|
80
|
+
document.addEventListener('mousedown', onMouseDown);
|
|
81
|
+
document.addEventListener('keydown', onKey);
|
|
82
|
+
return () => {
|
|
83
|
+
document.removeEventListener('mousedown', onMouseDown);
|
|
84
|
+
document.removeEventListener('keydown', onKey);
|
|
85
|
+
};
|
|
86
|
+
}, [pickerOpen]);
|
|
87
|
+
|
|
88
|
+
const handleSelect = useCallback(
|
|
89
|
+
async (path: string) => {
|
|
90
|
+
setPickerOpen(false);
|
|
91
|
+
await selectPath(path);
|
|
92
|
+
// Also surface the file in the editor so the user can see context alongside
|
|
93
|
+
// the diff. Skip for deleted files — navigating to a missing path would
|
|
94
|
+
// land FileRoute on the file-not-found state.
|
|
95
|
+
const change = session?.changes.find((c) => c.path === path);
|
|
96
|
+
if (change && change.kind !== 'deleted') {
|
|
97
|
+
openFile(path);
|
|
98
|
+
}
|
|
99
|
+
},
|
|
100
|
+
[selectPath, openFile, session],
|
|
101
|
+
);
|
|
102
|
+
|
|
103
|
+
const withBusy = useCallback(
|
|
104
|
+
async (fn: () => Promise<void>) => {
|
|
105
|
+
if (busyRef.current) return;
|
|
106
|
+
busyRef.current = true;
|
|
107
|
+
setBusy(true);
|
|
108
|
+
try {
|
|
109
|
+
await fn();
|
|
110
|
+
// Any accept/reject changes disk state, so refresh the tree in case
|
|
111
|
+
// files were added/removed.
|
|
112
|
+
await refreshFileTree();
|
|
113
|
+
} finally {
|
|
114
|
+
busyRef.current = false;
|
|
115
|
+
setBusy(false);
|
|
116
|
+
}
|
|
117
|
+
},
|
|
118
|
+
[refreshFileTree],
|
|
119
|
+
);
|
|
120
|
+
|
|
121
|
+
if (!session || session.changes.length === 0) return null;
|
|
122
|
+
|
|
123
|
+
const count = session.changes.length;
|
|
124
|
+
const selected = session.changes.find((c) => c.path === selectedPath);
|
|
125
|
+
const selectedLabel = selected ? basename(selected.path) : 'Select a file';
|
|
126
|
+
const selectedKind = selected ? kindLabel(selected.kind) : null;
|
|
127
|
+
|
|
128
|
+
return (
|
|
129
|
+
<div className="absolute inset-0 z-20 flex flex-col bg-white">
|
|
130
|
+
<div className="min-h-10 border-b border-slate-200 flex flex-wrap items-center px-3 py-1.5 gap-2 shrink-0">
|
|
131
|
+
<Eye size={14} className="text-emerald-600 shrink-0" />
|
|
132
|
+
<span className="text-sm font-medium text-slate-900 shrink-0">
|
|
133
|
+
Review agent changes
|
|
134
|
+
</span>
|
|
135
|
+
<span className="text-xs text-slate-600 shrink-0">
|
|
136
|
+
{count} file{count === 1 ? '' : 's'} pending
|
|
137
|
+
</span>
|
|
138
|
+
|
|
139
|
+
<div ref={pickerRef} className="relative flex-1 min-w-[10rem] max-w-md">
|
|
140
|
+
<button
|
|
141
|
+
type="button"
|
|
142
|
+
onClick={() => setPickerOpen((v) => !v)}
|
|
143
|
+
aria-haspopup="listbox"
|
|
144
|
+
aria-expanded={pickerOpen}
|
|
145
|
+
className="w-full flex items-center gap-2 px-2.5 py-1 rounded border border-slate-300 bg-white hover:bg-slate-50 text-left"
|
|
146
|
+
>
|
|
147
|
+
<span className="text-xs text-slate-900 truncate flex-1" title={selected?.path}>
|
|
148
|
+
{selectedLabel}
|
|
149
|
+
</span>
|
|
150
|
+
{selectedKind && (
|
|
151
|
+
<span className="text-[10px] uppercase tracking-wider text-slate-600 shrink-0">
|
|
152
|
+
{selectedKind}
|
|
153
|
+
</span>
|
|
154
|
+
)}
|
|
155
|
+
<ChevronDown
|
|
156
|
+
size={12}
|
|
157
|
+
className={`text-slate-600 shrink-0 transition-transform ${pickerOpen ? 'rotate-180' : ''}`}
|
|
158
|
+
/>
|
|
159
|
+
</button>
|
|
160
|
+
|
|
161
|
+
{pickerOpen && (
|
|
162
|
+
<div
|
|
163
|
+
role="listbox"
|
|
164
|
+
className="absolute left-0 right-0 top-full mt-1 max-h-[60vh] overflow-y-auto bg-white border border-slate-200 rounded-md shadow-xl z-30 p-1 space-y-1"
|
|
165
|
+
>
|
|
166
|
+
{session.changes.map((change) => (
|
|
167
|
+
<ReviewFileRow
|
|
168
|
+
key={`${change.kind}:${change.oldPath ?? ''}:${change.path}`}
|
|
169
|
+
change={change}
|
|
170
|
+
active={selectedPath === change.path}
|
|
171
|
+
busy={busy}
|
|
172
|
+
onSelect={() => handleSelect(change.path)}
|
|
173
|
+
onAccept={() => withBusy(() => review.acceptOne(change.path))}
|
|
174
|
+
onReject={() => review.rejectOne(change.path)}
|
|
175
|
+
/>
|
|
176
|
+
))}
|
|
177
|
+
</div>
|
|
178
|
+
)}
|
|
179
|
+
</div>
|
|
180
|
+
|
|
181
|
+
<button
|
|
182
|
+
type="button"
|
|
183
|
+
disabled={busy || (!applyToAll && !selected)}
|
|
184
|
+
onClick={() =>
|
|
185
|
+
withBusy(() =>
|
|
186
|
+
applyToAll
|
|
187
|
+
? review.rejectAll()
|
|
188
|
+
: selected ? review.rejectOne(selected.path) : Promise.resolve(),
|
|
189
|
+
)
|
|
190
|
+
}
|
|
191
|
+
title={applyToAll ? 'Delete every pending change — restore the originals' : 'Delete this change — restore the original'}
|
|
192
|
+
className="flex items-center gap-1.5 px-2.5 py-1 rounded text-xs font-medium text-slate-700 hover:text-red-700 hover:bg-red-100 disabled:opacity-40"
|
|
193
|
+
>
|
|
194
|
+
<Trash2 size={12} />
|
|
195
|
+
Delete
|
|
196
|
+
</button>
|
|
197
|
+
<button
|
|
198
|
+
type="button"
|
|
199
|
+
disabled={busy || (!applyToAll && !selected)}
|
|
200
|
+
onClick={() =>
|
|
201
|
+
withBusy(() =>
|
|
202
|
+
applyToAll
|
|
203
|
+
? review.acceptAll()
|
|
204
|
+
: selected ? review.acceptOne(selected.path) : Promise.resolve(),
|
|
205
|
+
)
|
|
206
|
+
}
|
|
207
|
+
title={applyToAll ? 'Accept every pending change' : 'Accept this change'}
|
|
208
|
+
className="flex items-center gap-1.5 px-2.5 py-1 rounded text-xs font-medium bg-emerald-700 hover:bg-emerald-600 text-white disabled:opacity-40"
|
|
209
|
+
>
|
|
210
|
+
<Check size={12} />
|
|
211
|
+
Accept
|
|
212
|
+
</button>
|
|
213
|
+
<label className="flex items-center gap-1.5 text-xs text-slate-700 select-none shrink-0 cursor-pointer">
|
|
214
|
+
<input
|
|
215
|
+
type="checkbox"
|
|
216
|
+
checked={applyToAll}
|
|
217
|
+
onChange={(e) => setApplyToAll(e.target.checked)}
|
|
218
|
+
disabled={busy}
|
|
219
|
+
className="cursor-pointer"
|
|
220
|
+
/>
|
|
221
|
+
Apply to all
|
|
222
|
+
</label>
|
|
223
|
+
{onClose && (
|
|
224
|
+
<button
|
|
225
|
+
type="button"
|
|
226
|
+
onClick={onClose}
|
|
227
|
+
title="Close review — changes stay pending"
|
|
228
|
+
aria-label="Close review"
|
|
229
|
+
className="ml-1 p-1 rounded text-slate-500 hover:text-slate-900 hover:bg-slate-100 shrink-0"
|
|
230
|
+
>
|
|
231
|
+
<X size={16} />
|
|
232
|
+
</button>
|
|
233
|
+
)}
|
|
234
|
+
</div>
|
|
235
|
+
|
|
236
|
+
<div className="flex-1 min-w-0 min-h-0">
|
|
237
|
+
{isLoadingDiff && (
|
|
238
|
+
<div className="h-full flex items-center justify-center text-xs text-slate-600">
|
|
239
|
+
Loading diff…
|
|
240
|
+
</div>
|
|
241
|
+
)}
|
|
242
|
+
{!isLoadingDiff && !fileDiff && (
|
|
243
|
+
<div className="h-full flex items-center justify-center text-xs text-slate-600">
|
|
244
|
+
Select a file to see the diff.
|
|
245
|
+
</div>
|
|
246
|
+
)}
|
|
247
|
+
{!isLoadingDiff && fileDiff && fileDiff.isBinary && (
|
|
248
|
+
<BinaryChangePlaceholder payload={fileDiff} />
|
|
249
|
+
)}
|
|
250
|
+
{!isLoadingDiff && fileDiff && !fileDiff.isBinary && (
|
|
251
|
+
isMarkdownPath(fileDiff.path) ? (
|
|
252
|
+
<MarkdownDiffViewer payload={fileDiff} />
|
|
253
|
+
) : (
|
|
254
|
+
<DiffViewer payload={fileDiff} />
|
|
255
|
+
)
|
|
256
|
+
)}
|
|
257
|
+
</div>
|
|
258
|
+
</div>
|
|
259
|
+
);
|
|
260
|
+
}
|
|
@@ -0,0 +1,52 @@
|
|
|
1
|
+
import { useEffect, useState } from 'react';
|
|
2
|
+
import { Eye } from 'lucide-react';
|
|
3
|
+
import { useReview } from '../state/review.context';
|
|
4
|
+
import { ReviewPanel } from './ReviewPanel';
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* The floating agent-review surface the FileViewer mounts. Registered via the
|
|
8
|
+
* app registry's `fileViewerPanels` (enterprise) instead of being hard-mounted
|
|
9
|
+
* in the FileViewer, so the core viewer has no dependency on the review
|
|
10
|
+
* module. Rendered inside the FileViewer's relative container, so the
|
|
11
|
+
* absolutely-positioned badge/panel anchor exactly as before.
|
|
12
|
+
*
|
|
13
|
+
* Two separate concerns, deliberately NOT fused into one boolean:
|
|
14
|
+
* - `hasPendingReview` (the fact): a session exists. Drives the passive
|
|
15
|
+
* review badge (and, over in FileViewer, suppresses the legacy
|
|
16
|
+
* single-file Accept/Reject banner so the two review UIs don't compete).
|
|
17
|
+
* - `reviewPanelOpen` (the intent): the user has opened the panel. The
|
|
18
|
+
* panel only mounts when this is true. It never auto-opens just because
|
|
19
|
+
* changes exist — that's what kept this feature blocking the whole app.
|
|
20
|
+
* Keeping these split is what lets a later step add "auto-open only for the
|
|
21
|
+
* user who ran the agent" as a one-line tweak to the open condition.
|
|
22
|
+
*/
|
|
23
|
+
export function ReviewPanelSurface() {
|
|
24
|
+
const review = useReview();
|
|
25
|
+
const hasPendingReview = !!review.session && review.session.changes.length > 0;
|
|
26
|
+
const [reviewPanelOpen, setReviewPanelOpen] = useState(false);
|
|
27
|
+
|
|
28
|
+
// Reset intent when the changes clear, so the NEXT batch of agent changes
|
|
29
|
+
// starts as a badge again rather than auto-reopening a stale-open panel.
|
|
30
|
+
useEffect(() => {
|
|
31
|
+
if (!hasPendingReview) setReviewPanelOpen(false);
|
|
32
|
+
}, [hasPendingReview]);
|
|
33
|
+
|
|
34
|
+
if (!hasPendingReview) return null;
|
|
35
|
+
|
|
36
|
+
return reviewPanelOpen ? (
|
|
37
|
+
<ReviewPanel onClose={() => setReviewPanelOpen(false)} />
|
|
38
|
+
) : (
|
|
39
|
+
<button
|
|
40
|
+
type="button"
|
|
41
|
+
onClick={() => setReviewPanelOpen(true)}
|
|
42
|
+
className="absolute bottom-4 right-4 z-20 flex items-center gap-2 px-3 py-2 rounded-full shadow-lg bg-emerald-700 hover:bg-emerald-600 text-white text-xs font-medium"
|
|
43
|
+
title="Review the agent's pending changes"
|
|
44
|
+
>
|
|
45
|
+
<Eye size={14} />
|
|
46
|
+
Review agent changes
|
|
47
|
+
<span className="inline-flex items-center justify-center min-w-[1.25rem] h-5 px-1 rounded-full bg-white/20 text-[11px]">
|
|
48
|
+
{review.session!.changes.length}
|
|
49
|
+
</span>
|
|
50
|
+
</button>
|
|
51
|
+
);
|
|
52
|
+
}
|
|
@@ -0,0 +1,106 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { render, screen, waitFor } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import { MemoryRouter } from 'react-router-dom';
|
|
5
|
+
import type { ReactNode } from 'react';
|
|
6
|
+
import type { ReviewSession } from '@bevel-software/platform-shared';
|
|
7
|
+
import { ReviewPanel } from '../ReviewPanel';
|
|
8
|
+
import { ReviewContext, type ReviewContextValue } from '../../state/review.context';
|
|
9
|
+
import { WorkspaceContext, type WorkspaceContextValue } from '../../../workspace/state/workspace.context';
|
|
10
|
+
import { GitContext, type GitContextValue } from '../../../git/state/git.context';
|
|
11
|
+
|
|
12
|
+
const session: ReviewSession = {
|
|
13
|
+
branchName: 'razvan/onboarding-tweaks',
|
|
14
|
+
baselineRef: '',
|
|
15
|
+
createdAt: '2026-06-08T00:00:00.000Z',
|
|
16
|
+
changes: [
|
|
17
|
+
{ path: 'processes/onboarding.md', kind: 'modified', isBinary: false, linesAdded: 12, linesRemoved: 3 },
|
|
18
|
+
{ path: 'processes/new-hire-checklist.md', kind: 'added', isBinary: false, linesAdded: 40, linesRemoved: 0 },
|
|
19
|
+
],
|
|
20
|
+
};
|
|
21
|
+
|
|
22
|
+
function makeReview(overrides: Partial<ReviewContextValue> = {}): ReviewContextValue {
|
|
23
|
+
return {
|
|
24
|
+
session,
|
|
25
|
+
selectedPath: 'processes/onboarding.md',
|
|
26
|
+
fileDiff: null,
|
|
27
|
+
isLoadingDiff: false,
|
|
28
|
+
isLoading: false,
|
|
29
|
+
lastError: null,
|
|
30
|
+
refresh: vi.fn(async () => {}),
|
|
31
|
+
selectPath: vi.fn(async () => {}),
|
|
32
|
+
acceptOne: vi.fn(async () => {}),
|
|
33
|
+
rejectOne: vi.fn(async () => {}),
|
|
34
|
+
acceptAll: vi.fn(async () => {}),
|
|
35
|
+
rejectAll: vi.fn(async () => {}),
|
|
36
|
+
clearError: vi.fn(),
|
|
37
|
+
...overrides,
|
|
38
|
+
};
|
|
39
|
+
}
|
|
40
|
+
|
|
41
|
+
function renderPanel(review: ReviewContextValue) {
|
|
42
|
+
const workspace = { refreshFileTree: vi.fn(async () => null) } as unknown as WorkspaceContextValue;
|
|
43
|
+
const git = { status: { branch: session.branchName } } as unknown as GitContextValue;
|
|
44
|
+
const wrapper = ({ children }: { children: ReactNode }) => (
|
|
45
|
+
<MemoryRouter>
|
|
46
|
+
<GitContext.Provider value={git}>
|
|
47
|
+
<WorkspaceContext.Provider value={workspace}>
|
|
48
|
+
<ReviewContext.Provider value={review}>{children}</ReviewContext.Provider>
|
|
49
|
+
</WorkspaceContext.Provider>
|
|
50
|
+
</GitContext.Provider>
|
|
51
|
+
</MemoryRouter>
|
|
52
|
+
);
|
|
53
|
+
return render(<ReviewPanel />, { wrapper });
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
describe('ReviewPanel top-bar actions (BEVA-77)', () => {
|
|
57
|
+
beforeEach(() => vi.clearAllMocks());
|
|
58
|
+
|
|
59
|
+
it('shows Accept/Delete and an unchecked Apply-to-all checkbox, not the old "all" buttons', () => {
|
|
60
|
+
renderPanel(makeReview());
|
|
61
|
+
|
|
62
|
+
expect(screen.getByRole('button', { name: 'Accept' })).toBeTruthy();
|
|
63
|
+
expect(screen.getByRole('button', { name: 'Delete' })).toBeTruthy();
|
|
64
|
+
expect(screen.queryByRole('button', { name: 'Accept all' })).toBeNull();
|
|
65
|
+
expect(screen.queryByRole('button', { name: 'Reject all' })).toBeNull();
|
|
66
|
+
|
|
67
|
+
const checkbox = screen.getByRole('checkbox', { name: /apply to all/i }) as HTMLInputElement;
|
|
68
|
+
expect(checkbox.checked).toBe(false);
|
|
69
|
+
});
|
|
70
|
+
|
|
71
|
+
it('with Apply-to-all OFF, Accept/Delete act on the selected file only', async () => {
|
|
72
|
+
const review = makeReview();
|
|
73
|
+
renderPanel(review);
|
|
74
|
+
const user = userEvent.setup();
|
|
75
|
+
|
|
76
|
+
await user.click(screen.getByRole('button', { name: 'Accept' }));
|
|
77
|
+
await waitFor(() => expect(review.acceptOne).toHaveBeenCalledWith('processes/onboarding.md'));
|
|
78
|
+
expect(review.acceptAll).not.toHaveBeenCalled();
|
|
79
|
+
|
|
80
|
+
await user.click(screen.getByRole('button', { name: 'Delete' }));
|
|
81
|
+
await waitFor(() => expect(review.rejectOne).toHaveBeenCalledWith('processes/onboarding.md'));
|
|
82
|
+
expect(review.rejectAll).not.toHaveBeenCalled();
|
|
83
|
+
});
|
|
84
|
+
|
|
85
|
+
it('with Apply-to-all ON, Accept/Delete act on every change', async () => {
|
|
86
|
+
const review = makeReview();
|
|
87
|
+
renderPanel(review);
|
|
88
|
+
const user = userEvent.setup();
|
|
89
|
+
|
|
90
|
+
await user.click(screen.getByRole('checkbox', { name: /apply to all/i }));
|
|
91
|
+
|
|
92
|
+
await user.click(screen.getByRole('button', { name: 'Accept' }));
|
|
93
|
+
await waitFor(() => expect(review.acceptAll).toHaveBeenCalledTimes(1));
|
|
94
|
+
expect(review.acceptOne).not.toHaveBeenCalled();
|
|
95
|
+
|
|
96
|
+
await user.click(screen.getByRole('button', { name: 'Delete' }));
|
|
97
|
+
await waitFor(() => expect(review.rejectAll).toHaveBeenCalledTimes(1));
|
|
98
|
+
expect(review.rejectOne).not.toHaveBeenCalled();
|
|
99
|
+
});
|
|
100
|
+
|
|
101
|
+
it('disables the single-file actions when nothing is selected (Apply-to-all OFF)', () => {
|
|
102
|
+
renderPanel(makeReview({ selectedPath: null }));
|
|
103
|
+
expect((screen.getByRole('button', { name: 'Accept' }) as HTMLButtonElement).disabled).toBe(true);
|
|
104
|
+
expect((screen.getByRole('button', { name: 'Delete' }) as HTMLButtonElement).disabled).toBe(true);
|
|
105
|
+
});
|
|
106
|
+
});
|
|
@@ -0,0 +1,88 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { renderHook, act, waitFor } from '@testing-library/react';
|
|
3
|
+
import type { PendingChange, ReviewSession } from '@bevel-software/platform-shared';
|
|
4
|
+
import { useReviewState } from '../useReviewState';
|
|
5
|
+
import { fetchReviewSession, rejectReviewChange } from '../../services/review.api';
|
|
6
|
+
|
|
7
|
+
/**
|
|
8
|
+
* `useReviewState` — the optimistic reject. Rejecting a change drops the row
|
|
9
|
+
* from the session immediately (before the background commit + push resolves)
|
|
10
|
+
* so it feels instant; a failure reconciles the panel and surfaces the error.
|
|
11
|
+
*/
|
|
12
|
+
|
|
13
|
+
vi.mock('../../services/review.api', () => ({
|
|
14
|
+
fetchReviewSession: vi.fn(),
|
|
15
|
+
fetchReviewFile: vi.fn(),
|
|
16
|
+
acceptReviewChange: vi.fn(),
|
|
17
|
+
rejectReviewChange: vi.fn(),
|
|
18
|
+
}));
|
|
19
|
+
|
|
20
|
+
const mockFetchSession = vi.mocked(fetchReviewSession);
|
|
21
|
+
const mockReject = vi.mocked(rejectReviewChange);
|
|
22
|
+
|
|
23
|
+
function mkChange(path: string): PendingChange {
|
|
24
|
+
return { path, kind: 'modified', isBinary: false, linesAdded: 1, linesRemoved: 1 };
|
|
25
|
+
}
|
|
26
|
+
function mkSession(paths: string[]): ReviewSession {
|
|
27
|
+
return { branchName: 'main', baselineRef: '', createdAt: '', changes: paths.map(mkChange) };
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
describe('useReviewState — optimistic reject', () => {
|
|
31
|
+
beforeEach(() => {
|
|
32
|
+
vi.clearAllMocks();
|
|
33
|
+
});
|
|
34
|
+
|
|
35
|
+
it('rejectOne drops the row from the session immediately, before the API resolves', async () => {
|
|
36
|
+
mockFetchSession.mockResolvedValue(mkSession(['a.md', 'b.md']));
|
|
37
|
+
const { result } = renderHook(() => useReviewState('ws', 'main'));
|
|
38
|
+
await waitFor(() => expect(result.current.session?.changes).toHaveLength(2));
|
|
39
|
+
|
|
40
|
+
// Hold the reject's network promise open so we can assert mid-flight.
|
|
41
|
+
let resolveApi: (v: ReviewSession | null) => void = () => {};
|
|
42
|
+
mockReject.mockImplementation(() => new Promise((res) => { resolveApi = res; }));
|
|
43
|
+
|
|
44
|
+
act(() => { void result.current.rejectOne('a.md'); });
|
|
45
|
+
|
|
46
|
+
// Optimistic: the row is gone even though the API has not resolved.
|
|
47
|
+
expect(result.current.session?.changes.map((c) => c.path)).toEqual(['b.md']);
|
|
48
|
+
|
|
49
|
+
// `resolveApi(null)` resolves `mockReject` (the mocked
|
|
50
|
+
// `rejectReviewChange` API) with `null` — the success contract
|
|
51
|
+
// signal for "rejection landed, no remaining session data to merge
|
|
52
|
+
// back in". The hook's optimistic update is therefore the final
|
|
53
|
+
// state; we assert the optimistic removal of `a.md` survives the
|
|
54
|
+
// network round-trip unchanged.
|
|
55
|
+
await act(async () => { resolveApi(null); });
|
|
56
|
+
expect(result.current.session?.changes.map((c) => c.path)).toEqual(['b.md']);
|
|
57
|
+
});
|
|
58
|
+
|
|
59
|
+
it('on a failed reject, reconciles to the server state and surfaces the error', async () => {
|
|
60
|
+
mockFetchSession.mockResolvedValue(mkSession(['a.md', 'b.md']));
|
|
61
|
+
const { result } = renderHook(() => useReviewState('ws', 'main'));
|
|
62
|
+
await waitFor(() => expect(result.current.session?.changes).toHaveLength(2));
|
|
63
|
+
|
|
64
|
+
mockReject.mockRejectedValue(new Error('push failed'));
|
|
65
|
+
// The reconciling refresh refetches — the commit failed, so the file is
|
|
66
|
+
// still pending server-side and comes back into the panel.
|
|
67
|
+
mockFetchSession.mockResolvedValue(mkSession(['a.md', 'b.md']));
|
|
68
|
+
|
|
69
|
+
await act(async () => { await result.current.rejectOne('a.md'); });
|
|
70
|
+
|
|
71
|
+
expect(result.current.lastError).toBe('push failed');
|
|
72
|
+
expect(result.current.session?.changes.map((c) => c.path).sort()).toEqual(['a.md', 'b.md']);
|
|
73
|
+
});
|
|
74
|
+
|
|
75
|
+
it('clearError dismisses the surfaced error', async () => {
|
|
76
|
+
mockFetchSession.mockResolvedValue(mkSession(['a.md']));
|
|
77
|
+
const { result } = renderHook(() => useReviewState('ws', 'main'));
|
|
78
|
+
await waitFor(() => expect(result.current.session?.changes).toHaveLength(1));
|
|
79
|
+
|
|
80
|
+
mockReject.mockRejectedValue(new Error('boom'));
|
|
81
|
+
mockFetchSession.mockResolvedValue(mkSession(['a.md']));
|
|
82
|
+
await act(async () => { await result.current.rejectOne('a.md'); });
|
|
83
|
+
expect(result.current.lastError).toBe('boom');
|
|
84
|
+
|
|
85
|
+
act(() => { result.current.clearError(); });
|
|
86
|
+
expect(result.current.lastError).toBeNull();
|
|
87
|
+
});
|
|
88
|
+
});
|