@bevel-software/platform-core-frontend 0.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (203) hide show
  1. package/LICENSE +202 -0
  2. package/package.json +70 -0
  3. package/src/core/CoreAppShell.tsx +444 -0
  4. package/src/core/__tests__/ShellRoutes.test.tsx +95 -0
  5. package/src/core/events.ts +29 -0
  6. package/src/core/registry.ts +336 -0
  7. package/src/css-side-effect-imports.d.ts +7 -0
  8. package/src/html-extensions.ts +12 -0
  9. package/src/index.css +49 -0
  10. package/src/index.ts +23 -0
  11. package/src/lib/api.ts +57 -0
  12. package/src/lib/utils.ts +138 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +130 -0
  14. package/src/modules/access/__tests__/useFileAccess.test.tsx +253 -0
  15. package/src/modules/access/api.ts +205 -0
  16. package/src/modules/access/components/AccessRestrictedBanner.tsx +31 -0
  17. package/src/modules/access/components/ManageAccessDialog.tsx +1232 -0
  18. package/src/modules/access/components/NodeOwnersBanner.tsx +30 -0
  19. package/src/modules/access/hooks/useFileAccess.ts +151 -0
  20. package/src/modules/admin/components/AdminRolesPage.tsx +943 -0
  21. package/src/modules/admin/components/RolesCorruptedBanner.tsx +74 -0
  22. package/src/modules/admin/services/admin.api.ts +92 -0
  23. package/src/modules/admin/services/roles.api.ts +136 -0
  24. package/src/modules/admin/state/admin.context.tsx +223 -0
  25. package/src/modules/auth/components/LoginScreen.tsx +135 -0
  26. package/src/modules/auth/hooks/useAuthState.ts +59 -0
  27. package/src/modules/auth/services/auth.api.ts +24 -0
  28. package/src/modules/auth/services/microsoft-oauth.ts +57 -0
  29. package/src/modules/auth/state/auth.context.ts +18 -0
  30. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +347 -0
  31. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +201 -0
  32. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +82 -0
  33. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +441 -0
  34. package/src/modules/git/__tests__/git.api.test.ts +113 -0
  35. package/src/modules/git/__tests__/pr.api.test.ts +44 -0
  36. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +212 -0
  37. package/src/modules/git/components/BranchSwitcher.tsx +527 -0
  38. package/src/modules/git/components/DiffView.tsx +30 -0
  39. package/src/modules/git/components/FileComparisonPanel.tsx +377 -0
  40. package/src/modules/git/components/FileHistoryPanel.tsx +320 -0
  41. package/src/modules/git/components/ProtectedBranchBanner.tsx +42 -0
  42. package/src/modules/git/components/PullNeededBanner.tsx +204 -0
  43. package/src/modules/git/components/PullRequestsForMe.tsx +244 -0
  44. package/src/modules/git/components/UnifiedDiffView.tsx +37 -0
  45. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +99 -0
  46. package/src/modules/git/hooks/useAutoPullUpdates.ts +121 -0
  47. package/src/modules/git/hooks/useGitState.ts +335 -0
  48. package/src/modules/git/services/__tests__/error-messages.test.ts +134 -0
  49. package/src/modules/git/services/error-messages.ts +257 -0
  50. package/src/modules/git/services/git.api.ts +163 -0
  51. package/src/modules/git/services/pr-prompts.ts +159 -0
  52. package/src/modules/git/services/pr.api.ts +39 -0
  53. package/src/modules/git/state/auto-update.context.ts +21 -0
  54. package/src/modules/git/state/git.context.ts +82 -0
  55. package/src/modules/layout/components/AppLayout.tsx +40 -0
  56. package/src/modules/layout/components/DemoBanner.tsx +57 -0
  57. package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -0
  58. package/src/modules/layout/components/MobileChatLayout.tsx +153 -0
  59. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +203 -0
  60. package/src/modules/layout/components/SlideOverlay.tsx +224 -0
  61. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +77 -0
  62. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +57 -0
  63. package/src/modules/layout/hooks/useMediaQuery.ts +23 -0
  64. package/src/modules/layout/state/__tests__/layout.context.test.tsx +39 -0
  65. package/src/modules/layout/state/layout.context.ts +46 -0
  66. package/src/modules/library/__tests__/DetailDialog.test.tsx +200 -0
  67. package/src/modules/library/__tests__/diff.test.ts +62 -0
  68. package/src/modules/library/__tests__/loadout.test.tsx +72 -0
  69. package/src/modules/library/__tests__/status.test.ts +117 -0
  70. package/src/modules/library/components/ChangeRequestDock.tsx +47 -0
  71. package/src/modules/library/components/CompareView.tsx +357 -0
  72. package/src/modules/library/components/DetailDialog.tsx +566 -0
  73. package/src/modules/library/components/GearIcon.tsx +12 -0
  74. package/src/modules/library/components/LibraryCard.tsx +132 -0
  75. package/src/modules/library/components/LibraryPage.tsx +254 -0
  76. package/src/modules/library/components/LoadoutSidebar.tsx +156 -0
  77. package/src/modules/library/components/StatusGem.tsx +21 -0
  78. package/src/modules/library/components/SuggestChange.tsx +171 -0
  79. package/src/modules/library/components/particles.ts +50 -0
  80. package/src/modules/library/hooks/useLibraryData.ts +119 -0
  81. package/src/modules/library/hooks/useSkillDetail.ts +74 -0
  82. package/src/modules/library/library.css +320 -0
  83. package/src/modules/library/services/library.api.ts +164 -0
  84. package/src/modules/library/state/loadout.tsx +129 -0
  85. package/src/modules/library/state/toast.tsx +42 -0
  86. package/src/modules/library/utils/diff.ts +102 -0
  87. package/src/modules/library/utils/status.ts +116 -0
  88. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +93 -0
  89. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +158 -0
  90. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +44 -0
  91. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +360 -0
  92. package/src/modules/pr/__tests__/bucketize-comments.test.ts +85 -0
  93. package/src/modules/pr/__tests__/parsePatch.test.ts +104 -0
  94. package/src/modules/pr/__tests__/usePrViewerState.test.ts +72 -0
  95. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +193 -0
  96. package/src/modules/pr/components/PrApprovalBadge.tsx +80 -0
  97. package/src/modules/pr/components/PrCancelButton.tsx +99 -0
  98. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +119 -0
  99. package/src/modules/pr/components/PrCommentComposer.tsx +92 -0
  100. package/src/modules/pr/components/PrCommentThread.tsx +168 -0
  101. package/src/modules/pr/components/PrCommentsPanel.tsx +143 -0
  102. package/src/modules/pr/components/PrDiffPane.tsx +425 -0
  103. package/src/modules/pr/components/PrFileRow.tsx +164 -0
  104. package/src/modules/pr/components/PrFilesList.tsx +53 -0
  105. package/src/modules/pr/components/PrHeader.tsx +45 -0
  106. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +58 -0
  107. package/src/modules/pr/components/PrMergeButton.tsx +268 -0
  108. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +112 -0
  109. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +110 -0
  110. package/src/modules/pr/components/PrViewer.tsx +364 -0
  111. package/src/modules/pr/hooks/usePrViewerState.ts +150 -0
  112. package/src/modules/pr/services/pr-approvals.api.ts +31 -0
  113. package/src/modules/pr/services/pr-cancel.api.ts +19 -0
  114. package/src/modules/pr/services/pr-comments.api.ts +45 -0
  115. package/src/modules/pr/services/pr-detail.api.ts +17 -0
  116. package/src/modules/pr/services/pr-merge.api.ts +53 -0
  117. package/src/modules/pr/services/pr-open.api.ts +30 -0
  118. package/src/modules/pr/state/pr-viewer.context.ts +34 -0
  119. package/src/modules/pr/utils/bucketize-comments.ts +55 -0
  120. package/src/modules/pr/utils/parsePatch.ts +57 -0
  121. package/src/modules/review/__tests__/review.api.test.ts +121 -0
  122. package/src/modules/review/components/BinaryChangePlaceholder.tsx +15 -0
  123. package/src/modules/review/components/DiffViewer.tsx +78 -0
  124. package/src/modules/review/components/MarkdownDiffViewer.tsx +263 -0
  125. package/src/modules/review/components/ReviewFileRow.tsx +114 -0
  126. package/src/modules/review/components/ReviewPanel.tsx +260 -0
  127. package/src/modules/review/components/ReviewPanelSurface.tsx +52 -0
  128. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +106 -0
  129. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +88 -0
  130. package/src/modules/review/hooks/useReviewState.ts +256 -0
  131. package/src/modules/review/services/review.api.ts +72 -0
  132. package/src/modules/review/state/ReviewProvider.tsx +28 -0
  133. package/src/modules/review/state/review.context.ts +29 -0
  134. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +488 -0
  135. package/src/modules/secrets-vault/components/SecretsPage.tsx +276 -0
  136. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +362 -0
  137. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +51 -0
  138. package/src/modules/secrets-vault/services/connect.api.ts +113 -0
  139. package/src/modules/secrets-vault/services/secrets.api.ts +82 -0
  140. package/src/modules/secrets-vault/services/tool-secrets.api.ts +116 -0
  141. package/src/modules/toolbar/components/AdminMenu.tsx +250 -0
  142. package/src/modules/toolbar/components/AppSwitcher.tsx +108 -0
  143. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -0
  144. package/src/modules/toolbar/components/Toolbar.tsx +123 -0
  145. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +122 -0
  146. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +353 -0
  147. package/src/modules/toolbar/services/external-api-keys.api.ts +65 -0
  148. package/src/modules/tools/ToolsExplorerPage.tsx +380 -0
  149. package/src/modules/workflow/hooks/useEventBusSubscription.ts +24 -0
  150. package/src/modules/workflow/hooks/useFileLock.ts +430 -0
  151. package/src/modules/workflow/services/lock.api.ts +139 -0
  152. package/src/modules/workflow/state/EventBusFocusBinder.tsx +25 -0
  153. package/src/modules/workflow/state/EventBusProvider.tsx +232 -0
  154. package/src/modules/workflow/state/event-bus.context.ts +75 -0
  155. package/src/modules/workspace/__tests__/testFixtures.ts +54 -0
  156. package/src/modules/workspace/__tests__/useWorkspaceState.test.ts +91 -0
  157. package/src/modules/workspace/components/EditorTabs.tsx +384 -0
  158. package/src/modules/workspace/components/FileExplorer.tsx +1068 -0
  159. package/src/modules/workspace/components/FileRoute.tsx +392 -0
  160. package/src/modules/workspace/components/FileViewer.tsx +906 -0
  161. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +241 -0
  162. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +666 -0
  163. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +330 -0
  164. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +492 -0
  165. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +174 -0
  166. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +87 -0
  167. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +231 -0
  168. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +50 -0
  169. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +287 -0
  170. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +252 -0
  171. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +268 -0
  172. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +81 -0
  173. package/src/modules/workspace/components/renderers/TextRenderer.tsx +86 -0
  174. package/src/modules/workspace/components/renderers/ToolForm.tsx +404 -0
  175. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +417 -0
  176. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +157 -0
  177. package/src/modules/workspace/components/renderers/__tests__/CsvRenderer.test.ts +57 -0
  178. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +95 -0
  179. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +328 -0
  180. package/src/modules/workspace/components/renderers/__tests__/PdfRenderer.test.tsx +167 -0
  181. package/src/modules/workspace/components/renderers/__tests__/htmlSandbox.test.ts +318 -0
  182. package/src/modules/workspace/components/renderers/csvUtils.ts +76 -0
  183. package/src/modules/workspace/components/renderers/htmlSandbox.ts +332 -0
  184. package/src/modules/workspace/components/renderers/index.ts +39 -0
  185. package/src/modules/workspace/components/renderers/types.ts +27 -0
  186. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +298 -0
  187. package/src/modules/workspace/hooks/useWorkspaceState.ts +1315 -0
  188. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +99 -0
  189. package/src/modules/workspace/routing/kb-routes.ts +266 -0
  190. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +72 -0
  191. package/src/modules/workspace/services/workspace.api.ts +185 -0
  192. package/src/modules/workspace/state/workspace.context.ts +235 -0
  193. package/src/modules/workspace/utils/__tests__/frontmatter.test.ts +107 -0
  194. package/src/modules/workspace/utils/diff.ts +53 -0
  195. package/src/modules/workspace/utils/fileTree.ts +179 -0
  196. package/src/modules/workspace/utils/frontmatter.ts +80 -0
  197. package/src/modules/workspace/utils/readDroppedEntries.ts +119 -0
  198. package/src/modules/workspace/utils/tab-persistence.ts +23 -0
  199. package/src/shared/components/Dialog.tsx +198 -0
  200. package/src/shared/components/PageShell.tsx +51 -0
  201. package/src/shared/components/useModalLayer.ts +35 -0
  202. package/src/shared/markdown/Markdown.tsx +62 -0
  203. package/src/test-setup.ts +59 -0
@@ -0,0 +1,492 @@
1
+ import { describe, it, expect, vi, afterEach } from 'vitest';
2
+ import { render, screen, waitFor, act } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import { MemoryRouter } from 'react-router-dom';
5
+ import { useEffect, useState } from 'react';
6
+ import type { BranchInfo, WorkingTreeStatus } from '@bevel-software/platform-shared';
7
+
8
+ // Mock the access API before importing the component tree — useFileAccess
9
+ // fires a fetch in an effect on mount, and we don't want real network in tests.
10
+ type Eligible = { roles: string[]; users: { name: string; email: string }[] };
11
+ const EMPTY_ELIGIBLE: Eligible = { roles: [], users: [] };
12
+ const accessMock = vi.hoisted(() => ({
13
+ result: {
14
+ canWrite: true,
15
+ canOwner: false,
16
+ eligible: { roles: ['Admin'], users: [] },
17
+ owners: { roles: [], users: [] },
18
+ } as {
19
+ canWrite: boolean;
20
+ canOwner: boolean;
21
+ eligible: { roles: string[]; users: { name: string; email: string }[] };
22
+ owners: { roles: string[]; users: { name: string; email: string }[] };
23
+ },
24
+ fetchFileAccess: vi.fn(),
25
+ }));
26
+ accessMock.fetchFileAccess.mockImplementation(async () => accessMock.result);
27
+ vi.mock('../../../access/api', () => ({
28
+ fetchFileAccess: accessMock.fetchFileAccess,
29
+ fetchFileAccessBatch: vi.fn(async () => ({ results: {} })),
30
+ }));
31
+
32
+ // Mock the lock API too — useFileLock acquires/heartbeats/releases against
33
+ // real endpoints. In these tests we just need the acquire to succeed so the
34
+ // save flow can finish; lock contention paths are exercised in lock-specific
35
+ // tests, not here.
36
+ vi.mock('../../../workflow/services/lock.api', () => ({
37
+ acquireLock: vi.fn(async () => ({
38
+ acquired: true,
39
+ lock: {
40
+ branch: 'alice/draft',
41
+ path: 'Knowledge/Foo.md',
42
+ holderUserId: 'u1',
43
+ holderName: 'Test User',
44
+ acquiredAt: new Date().toISOString(),
45
+ lastHeartbeatAt: new Date().toISOString(),
46
+ expiresAt: new Date(Date.now() + 60_000).toISOString(),
47
+ },
48
+ })),
49
+ heartbeatLock: vi.fn(async () => ({})),
50
+ checkpointLockedFile: vi.fn(async () => null),
51
+ releaseLock: vi.fn(async () => null),
52
+ getLock: vi.fn(async () => null),
53
+ LockApiError: class LockApiError extends Error {
54
+ readonly status: number;
55
+ readonly body: unknown;
56
+ constructor(status: number, message: string, body?: unknown) {
57
+ super(message);
58
+ this.status = status;
59
+ this.body = body;
60
+ }
61
+ },
62
+ }));
63
+
64
+ import { FileViewer } from '../FileViewer';
65
+ // The lock API is mocked above; import the mocked fns so individual tests can
66
+ // override the acquire outcome (e.g. a 403 on enter-edit).
67
+ import { acquireLock as acquireLockMock, LockApiError } from '../../../workflow/services/lock.api';
68
+ import { WorkspaceContext, type WorkspaceContextValue } from '../../state/workspace.context';
69
+ import { GitContext, type GitContextValue } from '../../../git/state/git.context';
70
+ import { ReviewContext, type ReviewContextValue } from '../../../review/state/review.context';
71
+ import { AuthContext, type AuthContextValue } from '../../../auth/state/auth.context';
72
+ import { PrViewerContext, type PrViewerContextValue } from '../../../pr/state/pr-viewer.context';
73
+
74
+ let injectPendingFromTest: ((value?: string) => void) | null = null;
75
+
76
+ function makeStatus(branch = 'alice/draft'): WorkingTreeStatus {
77
+ return {
78
+ branch,
79
+ hasUpstream: true,
80
+ unmergedFromUpstream: false,
81
+ };
82
+ }
83
+
84
+ function makeGit(status: WorkingTreeStatus): GitContextValue {
85
+ const branches: BranchInfo[] = [];
86
+ return {
87
+ status,
88
+ branches,
89
+ availability: 'ready',
90
+ lastError: null,
91
+ refreshStatus: async () => null,
92
+ refreshBranches: async () => {},
93
+ createBranch: async () => {},
94
+ deleteBranch: async () => {},
95
+ pull: async () => {},
96
+ fetchForkBase: async () => null,
97
+ revert: async () => ({
98
+ sha: 'abc',
99
+ authorName: 'n',
100
+ authorEmail: 'e',
101
+ subject: 's',
102
+ committedAt: '2026-04-20T00:00:00.000Z',
103
+ }),
104
+ fetchFileHistory: async () => [],
105
+ fetchFileDiff: async () => '',
106
+ fetchFileComparison: async () => '',
107
+ };
108
+ }
109
+
110
+ function ViewerHarness({
111
+ initialContent = 'Base content',
112
+ pendingValue = 'Agent version',
113
+ branch = 'alice/draft',
114
+ filePath = 'knowledge-base/Knowledge/Foo.md',
115
+ kbDirName = 'knowledge-base',
116
+ addTab,
117
+ }: {
118
+ initialContent?: string;
119
+ pendingValue?: string;
120
+ branch?: string;
121
+ filePath?: string;
122
+ kbDirName?: string | null;
123
+ addTab?: WorkspaceContextValue['addTab'];
124
+ }) {
125
+ const [openFileContent, setOpenFileContent] = useState(initialContent);
126
+ const [pendingFileContent, setPendingFileContent] = useState<string | null>(null);
127
+
128
+ useEffect(() => {
129
+ injectPendingFromTest = (value?: string) => {
130
+ setPendingFileContent(value ?? pendingValue);
131
+ };
132
+ return () => {
133
+ injectPendingFromTest = null;
134
+ };
135
+ }, [pendingValue]);
136
+
137
+ const tab = {
138
+ path: filePath,
139
+ content: openFileContent,
140
+ savedContent: openFileContent,
141
+ isDirty: false,
142
+ pendingFileContent,
143
+ };
144
+ const workspace: WorkspaceContextValue = {
145
+ workspaceId: 'ws-1',
146
+ kbDirName,
147
+ fileTree: null,
148
+ openTabs: [tab],
149
+ activeTab: tab,
150
+ dirtyTabFilenames: [],
151
+ openFilePath: filePath,
152
+ openFileContent,
153
+ openFileSavedContent: openFileContent,
154
+ hasUnsavedFileChanges: false,
155
+ pendingFileContent,
156
+ setActiveTabContent: () => {},
157
+ uploadError: null,
158
+ isUploading: false,
159
+ uploadProgress: null,
160
+ pendingUploads: new Map(),
161
+ fsRevision: 0,
162
+ bumpFsRevision: () => {},
163
+ setPersistenceBranch: () => {},
164
+ refreshFileTree: async () => null,
165
+ addTab: addTab ?? (async () => true),
166
+ closeTab: async () => ({ closed: true, newActivePath: null }),
167
+ activateTab: () => {},
168
+ reorderTab: () => {},
169
+ closeAllTabs: () => {},
170
+ hydrateTabs: async () => ({ surviving: [], dropped: [], denied: [] }),
171
+ createFile: async () => {},
172
+ createDirectory: async () => {},
173
+ unzipHere: async () => ({ extracted: 0, skipped: [], destination: '' }),
174
+ uploadFiles: async () => {},
175
+ dispatchUpload: async () => {},
176
+ clearUploadError: () => {},
177
+ deleteEntry: async () => {},
178
+ moveEntry: async () => {},
179
+ saveFile: async (_relativePath: string, content: string) => {
180
+ setOpenFileContent(content);
181
+ },
182
+ reloadTabFromDisk: async () => {},
183
+ setPendingContent: (content: string) => {
184
+ setPendingFileContent(content);
185
+ },
186
+ acceptPendingContent: async () => {
187
+ setOpenFileContent((curr) => pendingFileContent ?? curr);
188
+ setPendingFileContent(null);
189
+ },
190
+ rejectPendingContent: async () => {
191
+ setPendingFileContent(null);
192
+ },
193
+ };
194
+ const review: ReviewContextValue = {
195
+ session: null,
196
+ selectedPath: null,
197
+ fileDiff: null,
198
+ isLoadingDiff: false,
199
+ lastError: null,
200
+ isLoading: false,
201
+ refresh: async () => {},
202
+ selectPath: async () => {},
203
+ acceptOne: async () => {},
204
+ rejectOne: async () => {},
205
+ acceptAll: async () => {},
206
+ rejectAll: async () => {},
207
+ clearError: () => {},
208
+ };
209
+ const auth: AuthContextValue = {
210
+ user: null,
211
+ token: null,
212
+ isLoading: false,
213
+ login: async () => {},
214
+ logout: () => {},
215
+ };
216
+ const prViewer: PrViewerContextValue = {
217
+ openPrNumber: null,
218
+ detail: null,
219
+ notFound: false,
220
+ selectedPath: null,
221
+ isLoading: false,
222
+ lastError: null,
223
+ openPr: () => {},
224
+ closeViewer: () => {},
225
+ selectPath: () => {},
226
+ refresh: async () => {},
227
+ };
228
+
229
+ return (
230
+ <MemoryRouter>
231
+ <AuthContext.Provider value={auth}>
232
+ <WorkspaceContext.Provider value={workspace}>
233
+ <GitContext.Provider value={makeGit(makeStatus(branch))}>
234
+ <ReviewContext.Provider value={review}>
235
+ <PrViewerContext.Provider value={prViewer}>
236
+ <button type="button" onClick={() => setPendingFileContent(pendingValue)}>
237
+ Inject pending
238
+ </button>
239
+ <FileViewer />
240
+ </PrViewerContext.Provider>
241
+ </ReviewContext.Provider>
242
+ </GitContext.Provider>
243
+ </WorkspaceContext.Provider>
244
+ </AuthContext.Provider>
245
+ </MemoryRouter>
246
+ );
247
+ }
248
+
249
+ describe('FileViewer', () => {
250
+ // Restore the access mock to its default after each test so a test that
251
+ // flips it to `canWrite: false` doesn't bleed into later tests in this file.
252
+ afterEach(() => {
253
+ accessMock.result = {
254
+ canWrite: true,
255
+ canOwner: false,
256
+ eligible: { roles: ['Admin'], users: [] },
257
+ owners: EMPTY_ELIGIBLE,
258
+ };
259
+ accessMock.fetchFileAccess.mockClear();
260
+ // Restore the default "acquire succeeds" behaviour so a per-test 403
261
+ // override doesn't leak into the next test.
262
+ vi.mocked(acquireLockMock).mockImplementation(async () => ({
263
+ acquired: true,
264
+ lock: {
265
+ branch: 'alice/draft',
266
+ path: 'Knowledge/Foo.md',
267
+ holderUserId: 'u1',
268
+ holderName: 'Test User',
269
+ acquiredAt: new Date().toISOString(),
270
+ lastHeartbeatAt: new Date().toISOString(),
271
+ expiresAt: new Date(Date.now() + 60_000).toISOString(),
272
+ },
273
+ }));
274
+ });
275
+
276
+ it('immediately enters review mode when pending arrives on a clean file', async () => {
277
+ const user = userEvent.setup();
278
+ render(<ViewerHarness initialContent="base clean" pendingValue="agent clean" />);
279
+
280
+ await user.click(screen.getByRole('button', { name: 'Inject pending' }));
281
+
282
+ expect(await screen.findByText(/Previewing agent's changes/i)).toBeInTheDocument();
283
+ expect(screen.getByText(/Reviewing agent update/i)).toBeInTheDocument();
284
+ expect(screen.queryByRole('button', { name: 'Edit' })).not.toBeInTheDocument();
285
+ expect(screen.getByText('agent clean')).toBeInTheDocument();
286
+ });
287
+
288
+ it('defers pending review when unsaved manual edits exist', async () => {
289
+ const user = userEvent.setup();
290
+ render(<ViewerHarness initialContent="base" pendingValue="agent replacement" />);
291
+
292
+ await user.click(screen.getByRole('button', { name: 'Edit' }));
293
+ const textarea = screen.getByRole('textbox') as HTMLTextAreaElement;
294
+ await user.type(textarea, ' local edits');
295
+ expect(textarea.value).toBe('base local edits');
296
+
297
+ await act(async () => {
298
+ injectPendingFromTest?.();
299
+ });
300
+
301
+ expect(await screen.findByText(/Agent update is waiting/i)).toBeInTheDocument();
302
+ expect(screen.queryByText(/Previewing agent's changes/i)).not.toBeInTheDocument();
303
+ expect((screen.getByRole('textbox') as HTMLTextAreaElement).value).toBe('base local edits');
304
+ });
305
+
306
+ it('allows reviewing deferred pending after local save', async () => {
307
+ const user = userEvent.setup();
308
+ render(<ViewerHarness initialContent="base" pendingValue="agent latest" />);
309
+
310
+ await user.click(screen.getByRole('button', { name: 'Edit' }));
311
+ const textarea = screen.getByRole('textbox') as HTMLTextAreaElement;
312
+ await user.type(textarea, ' local');
313
+ await act(async () => {
314
+ injectPendingFromTest?.();
315
+ });
316
+
317
+ await user.keyboard('{Control>}s{/Control}');
318
+
319
+ const reviewButton = await screen.findByRole('button', { name: /Review agent update/i });
320
+ await waitFor(() => expect(reviewButton).not.toBeDisabled());
321
+ await user.click(reviewButton);
322
+
323
+ expect(await screen.findByText(/Previewing agent's changes/i)).toBeInTheDocument();
324
+ expect(screen.getByText('agent latest')).toBeInTheDocument();
325
+ });
326
+
327
+ it('clears pending review state after accept/reject and returns to editable mode', async () => {
328
+ const user = userEvent.setup();
329
+ render(<ViewerHarness initialContent="base before" pendingValue="agent accepted" />);
330
+
331
+ await user.click(screen.getByRole('button', { name: 'Inject pending' }));
332
+ const accept = await screen.findByRole('button', { name: 'Accept' });
333
+ await user.click(accept);
334
+
335
+ await waitFor(() => {
336
+ expect(screen.queryByText(/Previewing agent's changes/i)).not.toBeInTheDocument();
337
+ });
338
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
339
+ expect(screen.getByText('agent accepted')).toBeInTheDocument();
340
+
341
+ await act(async () => {
342
+ injectPendingFromTest?.('agent rejected');
343
+ });
344
+ const reject = await screen.findByRole('button', { name: 'Reject' });
345
+ await user.click(reject);
346
+
347
+ await waitFor(() => {
348
+ expect(screen.queryByText(/Previewing agent's changes/i)).not.toBeInTheDocument();
349
+ });
350
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
351
+ });
352
+
353
+ // (No no-access panel tests: a tab whose read 403s AUTO-CLOSES — denied tabs
354
+ // never exist, and the access-denied view lives at the route level. See
355
+ // FileRoute.test.tsx's file-denied cases.)
356
+
357
+ it('shows the canonical-state banner on a protected branch but keeps editing enabled', () => {
358
+ // Write access is now governed by roles.yaml + access.md and enforced by
359
+ // the backend at commit time — the editor itself is no longer disabled
360
+ // based on branch name. The banner stays as informational copy.
361
+ render(<ViewerHarness initialContent="official" branch="current-company-state" />);
362
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
363
+ expect(screen.getByText(/current company state/i)).toBeInTheDocument();
364
+ });
365
+
366
+ it('goes read-only and shows AccessRestrictedBanner when canWrite is false on a protected branch', async () => {
367
+ // The access gate only fires on protected branches — drafts are
368
+ // free-for-all and never reach the API, so reproducing the read-only
369
+ // state requires a protected branch.
370
+ accessMock.result = {
371
+ canWrite: false,
372
+ canOwner: false,
373
+ eligible: { roles: ['Admin', 'Product Manager'], users: [] },
374
+ owners: EMPTY_ELIGIBLE,
375
+ };
376
+ render(<ViewerHarness initialContent="official" branch="target-company-state" />);
377
+ await waitFor(() => {
378
+ expect(screen.getByText(/You don't have permission to edit/i)).toBeInTheDocument();
379
+ });
380
+ expect(screen.getByText(/Admin, Product Manager/)).toBeInTheDocument();
381
+ expect(screen.queryByRole('button', { name: 'Edit' })).not.toBeInTheDocument();
382
+ });
383
+
384
+ // Drafts are free-for-all: even if the backend would deny at PR-merge
385
+ // time, the editor must stay writable on a draft so the user can prepare
386
+ // a change request. Mirrors the backend's lock/commit/push gates, which
387
+ // all skip the access check on non-protected branches.
388
+ it('stays editable on a draft branch even when canWrite would be false', async () => {
389
+ accessMock.result = {
390
+ canWrite: false,
391
+ canOwner: false,
392
+ eligible: { roles: ['Admin'], users: [] },
393
+ owners: EMPTY_ELIGIBLE,
394
+ };
395
+ render(<ViewerHarness initialContent="draft content" branch="alice/draft" />);
396
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
397
+ expect(screen.queryByText(/You don't have permission to edit/i)).not.toBeInTheDocument();
398
+ expect(accessMock.fetchFileAccess).not.toHaveBeenCalled();
399
+ });
400
+
401
+ // Bug A regression: files outside the KB are the user's own workspace.
402
+ // Even when the backend would say "denied" for some path, a non-repo path
403
+ // must never reach the backend — it's editable unconditionally.
404
+ it('keeps non-repo files editable and never calls the access API', async () => {
405
+ accessMock.result = {
406
+ canWrite: false,
407
+ canOwner: false,
408
+ eligible: { roles: ['Admin'], users: [] },
409
+ owners: EMPTY_ELIGIBLE,
410
+ };
411
+ render(
412
+ <ViewerHarness
413
+ initialContent="my scratch notes"
414
+ branch="alice/draft"
415
+ filePath="notes/scratch.md"
416
+ />,
417
+ );
418
+
419
+ // The Edit affordance (provided by MarkdownRenderer when not readOnly) is
420
+ // present, no banner appears, and the access lookup never fires.
421
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
422
+ expect(screen.queryByText(/You don't have permission to edit/i)).not.toBeInTheDocument();
423
+ expect(accessMock.fetchFileAccess).not.toHaveBeenCalled();
424
+ });
425
+
426
+ // Bug B regression: the hook must strip the kbDirName prefix before
427
+ // querying the backend, otherwise deeper access.md grants silently miss
428
+ // and the editor falsely shows read-only. Exercised on a protected
429
+ // branch because drafts skip the API entirely (drafts-are-free).
430
+ it('strips kbDirName before calling the API for repo files', async () => {
431
+ accessMock.result = {
432
+ canWrite: true,
433
+ canOwner: false,
434
+ eligible: { roles: ['Product Manager'], users: [] },
435
+ owners: EMPTY_ELIGIBLE,
436
+ };
437
+ render(
438
+ <ViewerHarness
439
+ initialContent="sales doc"
440
+ branch="target-company-state"
441
+ filePath="knowledge-base/Knowledge/Sales/Foo.md"
442
+ />,
443
+ );
444
+
445
+ await waitFor(() => {
446
+ expect(accessMock.fetchFileAccess).toHaveBeenCalledWith(
447
+ 'ws-1',
448
+ 'Knowledge/Sales/Foo.md',
449
+ );
450
+ });
451
+ expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
452
+ expect(screen.queryByText(/You don't have permission to edit/i)).not.toBeInTheDocument();
453
+ });
454
+
455
+ // Hardening regression: when `useFileAccess` default-allows (its lookup
456
+ // failed transiently) the Edit button is shown even on a path the backend
457
+ // will refuse. Clicking Edit then hits a 403 on lock acquisition. Before the
458
+ // fix that 403 was swallowed (console.warn only) and the click just flickered
459
+ // "Loading…" then reverted to "Edit" with no explanation. Now the refusal is
460
+ // surfaced in the save-error banner so the user understands the file is
461
+ // read-only to them. (Distinct from lock contention, which the "Locked by X"
462
+ // banner already covers.)
463
+ it('surfaces an access-denied 403 on enter-edit instead of silently reverting', async () => {
464
+ // Force the access lookup to fail → useFileAccess default-allows →
465
+ // canWrite=true → the Edit button renders on a protected branch.
466
+ accessMock.fetchFileAccess.mockRejectedValueOnce(new Error('network down'));
467
+ // The authoritative backend gate refuses the lock with a 403.
468
+ vi.mocked(acquireLockMock).mockRejectedValueOnce(
469
+ new LockApiError(
470
+ 403,
471
+ 'You don\'t have permission to write to "Knowledge/Foo.md". Eligible: Admin.',
472
+ { access: { path: 'Knowledge/Foo.md', eligibleRoles: ['Admin'], eligibleUsers: [] } },
473
+ ),
474
+ );
475
+ const user = userEvent.setup();
476
+ render(<ViewerHarness initialContent="official" branch="target-company-state" />);
477
+
478
+ // Editor stays writable (default-allow) — the Edit button is present.
479
+ const editButton = await screen.findByRole('button', { name: 'Edit' });
480
+ await user.click(editButton);
481
+
482
+ // The refusal is surfaced, not swallowed.
483
+ await waitFor(() => {
484
+ expect(
485
+ screen.getByText(/You don't have permission to write to/i),
486
+ ).toBeInTheDocument();
487
+ });
488
+ expect(screen.getByText(/Eligible: Admin/i)).toBeInTheDocument();
489
+ // And we did NOT flip into edit mode — no editable textbox appeared.
490
+ expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
491
+ });
492
+ });
@@ -0,0 +1,174 @@
1
+ import { useState, useCallback, useEffect, useMemo, useRef } from 'react';
2
+ import type { FileRendererProps, RendererSaveState } from './types';
3
+ import { parseCsv } from './csvUtils';
4
+
5
+ /**
6
+ * CSV view/edit renderer driven by the parent's `readOnly` prop, mirroring
7
+ * `MarkdownRenderer`:
8
+ *
9
+ * - `readOnly === true` → tabular preview (view mode)
10
+ * - `readOnly === false` → raw comma-separated textarea (edit mode)
11
+ *
12
+ * Editing stays as plain comma-separated text — there is no in-cell editing.
13
+ * The first row is rendered as the table header, matching the convention used
14
+ * by the `.xlsx` viewer. The dirty/save plumbing is identical to the other
15
+ * text-backed renderers.
16
+ */
17
+ export function CsvRenderer({
18
+ content,
19
+ savedContent,
20
+ filePath,
21
+ onSave,
22
+ onDirtyChange,
23
+ onValueChange,
24
+ onSaveStateChange,
25
+ readOnly = false,
26
+ }: FileRendererProps) {
27
+ const [value, setValue] = useState(content);
28
+ const [savedValue, setSavedValue] = useState(savedContent ?? content);
29
+ const [saveState, setSaveState] = useState<RendererSaveState>('idle');
30
+ const [saveError, setSaveError] = useState<string | null>(null);
31
+ // Guards against overlapping saves: a rapid second Ctrl/Cmd+S while the
32
+ // first `onSave` is still in flight would otherwise enqueue a concurrent
33
+ // commit. A ref (not `saveState`) so the check sees the latest value
34
+ // synchronously within the same tick.
35
+ const savingRef = useRef(false);
36
+
37
+ const dirty = !readOnly && value !== savedValue;
38
+
39
+ useEffect(() => {
40
+ setValue(content);
41
+ setSavedValue(savedContent ?? content);
42
+ setSaveState('idle');
43
+ setSaveError(null);
44
+ }, [content, savedContent, filePath]);
45
+
46
+ useEffect(() => {
47
+ onDirtyChange?.(dirty);
48
+ }, [dirty, onDirtyChange]);
49
+
50
+ useEffect(() => {
51
+ onSaveStateChange?.(saveState);
52
+ }, [saveState, onSaveStateChange]);
53
+
54
+ const rows = useMemo(() => (readOnly ? parseCsv(value) : []), [readOnly, value]);
55
+ const columnCount = useMemo(
56
+ () => rows.reduce((max, r) => Math.max(max, r.length), 0),
57
+ [rows],
58
+ );
59
+
60
+ const save = useCallback(async (): Promise<boolean> => {
61
+ if (readOnly || value === savedValue) return true;
62
+ if (savingRef.current) return false;
63
+ savingRef.current = true;
64
+ setSaveState('saving');
65
+ setSaveError(null);
66
+ try {
67
+ await onSave(value);
68
+ setSavedValue(value);
69
+ setSaveState('idle');
70
+ return true;
71
+ } catch (err) {
72
+ console.error('[CsvRenderer] save failed:', err);
73
+ setSaveState('error');
74
+ setSaveError(err instanceof Error ? err.message : String(err));
75
+ return false;
76
+ } finally {
77
+ savingRef.current = false;
78
+ }
79
+ }, [readOnly, value, savedValue, onSave]);
80
+
81
+ const handleChange = useCallback(
82
+ (e: React.ChangeEvent<HTMLTextAreaElement>) => {
83
+ const next = e.target.value;
84
+ setValue(next);
85
+ onValueChange?.(next);
86
+ },
87
+ [onValueChange],
88
+ );
89
+
90
+ const handleKeyDown = useCallback(
91
+ (e: React.KeyboardEvent) => {
92
+ if ((e.ctrlKey || e.metaKey) && e.key === 's') {
93
+ e.preventDefault();
94
+ void save();
95
+ }
96
+ },
97
+ [save],
98
+ );
99
+
100
+ const showStatusStrip = saveState === 'saving' || (saveState === 'error' && saveError);
101
+
102
+ return (
103
+ <div className="flex flex-col h-full">
104
+ {showStatusStrip && (
105
+ <div className="flex items-center gap-2 pb-2 mb-2 border-b border-slate-200 shrink-0">
106
+ {saveState === 'saving' && (
107
+ <span
108
+ role="status"
109
+ aria-live="polite"
110
+ aria-atomic="true"
111
+ className="text-xs text-slate-600"
112
+ >
113
+ Saving…
114
+ </span>
115
+ )}
116
+ {saveState === 'error' && saveError && (
117
+ <span
118
+ role="alert"
119
+ aria-live="assertive"
120
+ aria-atomic="true"
121
+ className="text-xs text-red-600"
122
+ >
123
+ Couldn't save your changes. Try again in a moment.
124
+ </span>
125
+ )}
126
+ </div>
127
+ )}
128
+
129
+ {readOnly ? (
130
+ <div className="flex-1 overflow-auto">
131
+ {rows.length === 0 || columnCount === 0 ? (
132
+ <div className="flex items-center justify-center h-full text-slate-600 text-sm">
133
+ This file is empty.
134
+ </div>
135
+ ) : (
136
+ <table className="border-collapse text-sm">
137
+ <tbody>
138
+ {rows.map((row, rIdx) => (
139
+ <tr key={rIdx}>
140
+ {Array.from({ length: columnCount }, (_, cIdx) => {
141
+ const cell = row[cIdx] ?? '';
142
+ const Tag = rIdx === 0 ? 'th' : 'td';
143
+ return (
144
+ <Tag
145
+ key={cIdx}
146
+ className={`border border-slate-200 px-2 py-1 align-top whitespace-pre-wrap ${
147
+ rIdx === 0
148
+ ? 'bg-slate-50 text-slate-900 font-medium text-left'
149
+ : 'text-slate-700'
150
+ }`}
151
+ >
152
+ {cell}
153
+ </Tag>
154
+ );
155
+ })}
156
+ </tr>
157
+ ))}
158
+ </tbody>
159
+ </table>
160
+ )}
161
+ </div>
162
+ ) : (
163
+ <textarea
164
+ className="flex-1 w-full bg-transparent text-sm text-slate-700 font-mono whitespace-pre-wrap break-words leading-relaxed resize-none outline-none"
165
+ value={value}
166
+ onChange={handleChange}
167
+ onKeyDown={handleKeyDown}
168
+ spellCheck={false}
169
+ autoFocus
170
+ />
171
+ )}
172
+ </div>
173
+ );
174
+ }