@bananapus/core-v6 0.0.37 → 0.0.38

package/test/units/static/JBPrices/TestPrices.sol

@@ -1,265 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPrices} from "../../../../src/JBPrices.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {mulDiv} from "@prb/math/src/Common.sol";
-import {JBPricesSetup} from "./JBPricesSetup.sol";
-import {MockPriceFeed} from "../../../mock/MockPriceFeed.sol";
-
-/// @notice Edge case & bug-hunting tests for JBPrices.
-/// Covers inverse precision, feed immutability, default fallback, and the overly-restrictive
-/// default-blocks-project-specific issue.
-contract TestPrices_Local is JBPricesSetup {
-    uint256 constant DEFAULT_PROJECT_ID = 0;
-    uint256 constant PROJECT_ID = 1;
-    uint256 _pricingCurrency = uint32(uint160(JBConstants.NATIVE_TOKEN));
-    uint256 _unitCurrency = uint32(uint160(makeAddr("unitToken")));
-
-    function setUp() public {
-        super.pricesSetup();
-    }
-
-    // ───────────────────── Helpers
-    // ─────────────────────
-
-    /// @dev Sets a mock price feed directly into storage for a given project.
-    function _storeFeed(uint256 projectId, uint256 pricing, uint256 unit_, address feed) internal {
-        bytes32 slot0 = keccak256(abi.encode(projectId, uint256(1)));
-        bytes32 slot1 = keccak256(abi.encode(pricing, uint256(slot0)));
-        bytes32 slot2 = keccak256(abi.encode(unit_, uint256(slot1)));
-        vm.store(address(_prices), slot2, bytes32(uint256(uint160(feed))));
-    }
-
-    // ───────────────────── Inverse precision tests
-    // ─────────────────────
-
-    /// @notice Feed returns 1 (minimum non-zero price). Inverse should be 10^(2*decimals).
-    function test_inversePrecision_smallPrice() external {
-        uint256 decimals = 18;
-        MockPriceFeed feed = new MockPriceFeed(1, decimals);
-        _storeFeed(PROJECT_ID, _unitCurrency, _pricingCurrency, address(feed));
-
-        // Query the inverse direction: pricing → unit requires inverting the unit→pricing feed.
-        uint256 inverse = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-        // inverse = 10^18 * 10^18 / 1 = 10^36, but mulDiv(10^18, 10^18, 1) = 10^36
-        // Wait: the formula is mulDiv(10^decimals, 10^decimals, feedPrice) = mulDiv(10^18, 10^18, 1)
-        assertEq(inverse, 10 ** (2 * decimals), "Inverse of price=1 should be 10^(2*decimals)");
-    }
-
-    /// @notice Feed returns near-max value. Inverse should not underflow to 0.
-    function test_inversePrecision_largePrice() external {
-        uint256 decimals = 18;
-        // Price is 10^36 (very large).
-        // Inverse = mulDiv(10^18, 10^18, 10^36) = 10^36 / 10^36 = 1
-        MockPriceFeed feed = new MockPriceFeed(10 ** 36, 18);
-        _storeFeed(PROJECT_ID, _unitCurrency, _pricingCurrency, address(feed));
-
-        uint256 inverse = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-        assertEq(inverse, 1, "Inverse of very large price should be 1 (floor)");
-    }
-
-    /// @notice Fuzz: price(A->B) * price(B->A) should approximate 10^(2*decimals).
-    /// Bounded to realistic price range where precision is expected to hold.
-    function testFuzz_inversePrecision_roundTrip(uint256 price) external {
-        uint256 decimals = 18;
-        // Bound price to [10^9, 10^27] — realistic range where inverse precision is reasonable.
-        // Outside this range, integer division precision loss is severe (see test below).
-        price = bound(price, 10 ** 9, 10 ** 27);
-
-        MockPriceFeed feed = new MockPriceFeed(price, decimals);
-
-        // Store feed as direct A->B feed.
-        _storeFeed(PROJECT_ID, _pricingCurrency, _unitCurrency, address(feed));
-
-        // Get direct price.
-        uint256 direct = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-        assertEq(direct, price, "Direct price should match feed");
-
-        // Get inverse price (B->A).
-        uint256 inverse = _prices.pricePerUnitOf(PROJECT_ID, _unitCurrency, _pricingCurrency, decimals);
-
-        // Round-trip: direct * inverse should approximate 10^decimals.
-        uint256 product = mulDiv(direct, inverse, 10 ** decimals);
-        assertApproxEqRel(product, 10 ** decimals, 0.01e18, "Round-trip should approximate 10^decimals");
-    }
-
-    /// @notice PRECISION BUG: At extreme prices (>10^27), inverse precision degrades severely.
-    /// For non-power-of-10 prices, round-trip error can exceed 10%.
-    function test_inversePrecision_degradesAtExtremes() external {
-        uint256 decimals = 18;
-        // Price of 3*10^35 — inverse = mulDiv(10^18, 10^18, 3*10^35) = floor(3.33) = 3
-        MockPriceFeed feed = new MockPriceFeed(3 * 10 ** 35, decimals);
-        _storeFeed(PROJECT_ID, _unitCurrency, _pricingCurrency, address(feed));
-
-        uint256 inverse = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-        // Inverse only has 1 significant digit — massive precision loss.
-        assertEq(inverse, 3, "Extreme price inverse has only 1 digit of precision");
-
-        // Round-trip: 3*10^35 * 3 / 10^18 = 9*10^17 (should be 10^18). 10% error.
-        uint256 product = mulDiv(3 * 10 ** 35, inverse, 10 ** decimals);
-        assertEq(product, 9 * 10 ** 17, "Round-trip at extreme prices loses 10% precision");
-    }
-
-    /// @notice inverse(inverse(price)) should approximately equal price (precision loss compounds).
-    function test_inversePrecision_asymmetry() external {
-        uint256 decimals = 18;
-        uint256 originalPrice = 3333 * 10 ** 14; // 0.3333 ETH (a price that doesn't divide evenly)
-
-        // Store A->B feed.
-        MockPriceFeed feed = new MockPriceFeed(originalPrice, decimals);
-        _storeFeed(PROJECT_ID, _pricingCurrency, _unitCurrency, address(feed));
-
-        // Get inverse (B->A).
-        uint256 inversePrice = _prices.pricePerUnitOf(PROJECT_ID, _unitCurrency, _pricingCurrency, decimals);
-
-        // Now set a NEW feed for B->A with the inverse price, and query A->B back via inversion.
-        // We need a different project to avoid the "already exists" check.
-        uint256 project2 = 2;
-        MockPriceFeed feed2 = new MockPriceFeed(inversePrice, decimals);
-        _storeFeed(project2, _unitCurrency, _pricingCurrency, address(feed2));
-
-        uint256 doubleInverse = _prices.pricePerUnitOf(project2, _pricingCurrency, _unitCurrency, decimals);
-
-        // Double-inverse should be approximately equal to original, but may lose precision.
-        // This documents the precision loss from compounding inversions.
-        assertApproxEqRel(doubleInverse, originalPrice, 0.01e18, "Double inverse should approximate original within 1%");
-    }
-
-    // ───────────────────── Feed immutability tests
-    // ─────────────────────
-
-    /// @notice Adding a feed for an existing pair should revert.
-    function test_feedImmutability_cannotReplace() external {
-        MockPriceFeed feed1 = new MockPriceFeed(1000e18, 18);
-        MockPriceFeed feed2 = new MockPriceFeed(2000e18, 18);
-
-        // Mock controller for project.
-        vm.mockCall(
-            address(directory), abi.encodeCall(IJBDirectory.controllerOf, (PROJECT_ID)), abi.encode(address(this))
-        );
-
-        _prices.addPriceFeedFor(PROJECT_ID, _pricingCurrency, _unitCurrency, feed1);
-
-        // Second add for same pair should revert.
-        vm.expectRevert(abi.encodeWithSelector(JBPrices.JBPrices_PriceFeedAlreadyExists.selector, feed1));
-        _prices.addPriceFeedFor(PROJECT_ID, _pricingCurrency, _unitCurrency, feed2);
-    }
-
-    /// @notice Adding A->B should block adding B->A for the same project.
-    function test_feedImmutability_inverseBlocksToo() external {
-        MockPriceFeed feed1 = new MockPriceFeed(1000e18, 18);
-        MockPriceFeed feed2 = new MockPriceFeed(2000e18, 18);
-
-        vm.mockCall(
-            address(directory), abi.encodeCall(IJBDirectory.controllerOf, (PROJECT_ID)), abi.encode(address(this))
-        );
-
-        _prices.addPriceFeedFor(PROJECT_ID, _pricingCurrency, _unitCurrency, feed1);
-
-        // Adding inverse pair should revert.
-        vm.expectRevert(abi.encodeWithSelector(JBPrices.JBPrices_PriceFeedAlreadyExists.selector, feed1));
-        _prices.addPriceFeedFor(PROJECT_ID, _unitCurrency, _pricingCurrency, feed2);
-    }
-
-    // ───────────────────── Default fallback tests
-    // ─────────────────────
-
-    /// @notice Project-specific feed takes priority over default.
-    function test_defaultFallback_projectFeedTakesPriority() external {
-        MockPriceFeed defaultFeed = new MockPriceFeed(1000e18, 18);
-        MockPriceFeed projectFeed = new MockPriceFeed(2000e18, 18);
-
-        // Store default feed.
-        _storeFeed(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, address(defaultFeed));
-        // Store project feed.
-        _storeFeed(PROJECT_ID, _pricingCurrency, _unitCurrency, address(projectFeed));
-
-        uint256 price = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, 18);
-        assertEq(price, 2000e18, "Project feed should take priority over default");
-    }
-
-    /// @notice Default inverse feed used when no project-specific direct or inverse feed exists.
-    function test_defaultFallback_inverseOfDefault() external {
-        uint256 decimals = 18;
-        // Only store default feed in the inverse direction: unit->pricing.
-        MockPriceFeed defaultFeed = new MockPriceFeed(2e18, decimals);
-        _storeFeed(DEFAULT_PROJECT_ID, _unitCurrency, _pricingCurrency, address(defaultFeed));
-
-        // Query pricing->unit on a project with no feeds — should fall back to default inverse.
-        uint256 price = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-
-        // Expected: mulDiv(10^18, 10^18, 2*10^18) = 5*10^17
-        assertEq(price, 5e17, "Should use inverse of default feed");
-    }
-
-    // ───────────────────── Same currency
-    // ─────────────────────
-
-    /// @notice pricePerUnitOf(X, X, decimals) == 10^decimals.
-    function test_sameCurrency_returns1() external view {
-        uint256 price18 = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _pricingCurrency, 18);
-        assertEq(price18, 1e18, "Same currency at 18 decimals should return 1e18");
-
-        uint256 price6 = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _pricingCurrency, 6);
-        assertEq(price6, 1e6, "Same currency at 6 decimals should return 1e6");
-    }
-
-    // ───────────────────── Zero currency reverts
-    // ─────────────────────
-
-    /// @notice Both zero pricing and zero unit currency should revert on addPriceFeedFor.
-    function test_zeroCurrency_reverts() external {
-        MockPriceFeed feed = new MockPriceFeed(1000e18, 18);
-
-        vm.prank(_owner);
-        vm.expectRevert(JBPrices.JBPrices_ZeroPricingCurrency.selector);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, 0, _unitCurrency, feed);
-
-        vm.prank(_owner);
-        vm.expectRevert(JBPrices.JBPrices_ZeroUnitCurrency.selector);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, 0, feed);
-    }
-
-    // ───────────────────── BUG HYPOTHESIS: default blocks project-specific
-    // ─────────────────────
-
-    /// @notice BUG: Adding a default A->B feed blocks ANY project from adding their own A->B feed.
-    /// This is overly restrictive — projects cannot use a different oracle for the same pair.
-    /// The check at JBPrices.sol:188-197 checks default feeds BEFORE project feeds.
-    function test_addFeedFor_defaultBlocksProjectSpecific() external {
-        MockPriceFeed defaultFeed = new MockPriceFeed(1000e18, 18);
-        MockPriceFeed projectFeed = new MockPriceFeed(2000e18, 18);
-
-        // Add default feed.
-        vm.prank(_owner);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, defaultFeed);
-
-        // Now try to add a project-specific feed for the SAME pair.
-        vm.mockCall(
-            address(directory), abi.encodeCall(IJBDirectory.controllerOf, (PROJECT_ID)), abi.encode(address(this))
-        );
-
-        // This reverts because default feed blocks project-specific feeds.
-        vm.expectRevert(abi.encodeWithSelector(JBPrices.JBPrices_PriceFeedAlreadyExists.selector, defaultFeed));
-        _prices.addPriceFeedFor(PROJECT_ID, _pricingCurrency, _unitCurrency, projectFeed);
-    }
-
-    // ───────────────────── Fuzz: valid feeds never overflow
-    // ─────────────────────
-
-    /// @notice Fuzz: pricePerUnitOf should never revert for valid feed values.
-    function testFuzz_pricePerUnitOf_neverReverts_forValidFeed(uint256 price, uint8 decimals) external {
-        // Bound inputs to reasonable ranges.
-        decimals = uint8(bound(decimals, 1, 18));
-        price = bound(price, 1, type(uint128).max);
-
-        MockPriceFeed feed = new MockPriceFeed(price, decimals);
-        _storeFeed(PROJECT_ID, _pricingCurrency, _unitCurrency, address(feed));
-
-        // Should not revert.
-        uint256 result = _prices.pricePerUnitOf(PROJECT_ID, _pricingCurrency, _unitCurrency, decimals);
-        assertGt(result, 0, "Price should be non-zero for valid feed");
-    }
-}

package/test/units/static/JBProjects/JBProjectsSetup.sol

@@ -1,22 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBProjects} from "../../../../src/JBProjects.sol";
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-/*
-Contract that deploys a target contract with other mock contracts to satisfy the constructor.
-Tests relative to this contract will be dependent on mock calls/emits and stdStorage.
-*/
-contract JBProjectsSetup is JBTest {
-    address _owner = makeAddr("owner");
-
-    // Target Contract
-    IJBProjects public _projects;
-
-    function projectsSetup() public virtual {
-        // Instantiate the contract being tested
-        _projects = new JBProjects(_owner, address(0), address(0));
-    }
-}

package/test/units/static/JBProjects/TestCreateFor.sol

@@ -1,71 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {StdStorage, stdStorage} from "forge-std/StdStorage.sol";
-import {stdError} from "forge-std/StdError.sol";
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {IERC721Receiver} from "@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol";
-import {JBProjectsSetup} from "./JBProjectsSetup.sol";
-
-contract TestCreateFor_Local is JBProjectsSetup {
-    using stdStorage for StdStorage;
-
-    address _user = makeAddr("sudoer");
-
-    function setUp() public {
-        super.projectsSetup();
-    }
-
-    function test_WhenProjectIdPlusOneIsGtUint256Max() external {
-        // it will revert with overflow
-
-        // set storage to uint256 max
-        stdstore.target(address(_projects)).sig("count()").checked_write(type(uint256).max);
-
-        assertEq(_projects.count(), type(uint256).max);
-
-        vm.expectRevert(stdError.arithmeticError);
-        _projects.createFor(address(this));
-    }
-
-    modifier whenProjectIdPlusOneIsLtOrEqToUint256Max() {
-        _;
-    }
-
-    function test_GivenOwnerIsNotAContract() external whenProjectIdPlusOneIsLtOrEqToUint256Max {
-        // it will mint and emit Create
-
-        // created on behalf of user by this contract
-        vm.expectEmit();
-        emit IJBProjects.Create(1, _user, address(this));
-
-        _projects.createFor(_user);
-
-        // check count is incrementing
-        assertEq(_projects.count(), 1);
-    }
-
-    function test_GivenItIsIERC721Receiver() external whenProjectIdPlusOneIsLtOrEqToUint256Max {
-        // it will mint and emit Create
-
-        // mock IERC721Receiver support (return interface selector for onERC721Received)
-        bytes memory receiverCall =
-            abi.encodeCall(IERC721Receiver.onERC721Received, (address(this), address(0), 1, bytes("")));
-        bytes memory returned = abi.encode(IERC721Receiver.onERC721Received.selector);
-
-        mockExpect(address(this), receiverCall, returned);
-
-        _projects.createFor(address(this));
-    }
-
-    function test_GivenItDoesNotSupportIERC721Receiver() external whenProjectIdPlusOneIsLtOrEqToUint256Max {
-        // it will revert
-
-        // encode custom error
-        bytes4 selector = bytes4(keccak256("ERC721InvalidReceiver(address)"));
-        bytes memory expectedError = abi.encodeWithSelector(selector, address(this));
-
-        vm.expectRevert(expectedError);
-        _projects.createFor(address(this));
-    }
-}

package/test/units/static/JBProjects/TestInitialProject.sol

@@ -1,21 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBProjects} from "../../../../src/JBProjects.sol";
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-contract TestInitialProject_Local is JBTest {
-    address _owner = makeAddr("owner");
-    IJBProjects _projects;
-
-    function setUp() public {}
-
-    function test_WhenInitialOwnerDNEQZeroAddress() external {
-        // It will create a project
-
-        vm.expectEmit();
-        emit IJBProjects.Create(1, _owner, address(this));
-        _projects = new JBProjects(_owner, _owner, address(0));
-    }
-}

package/test/units/static/JBProjects/TestInterfaces.sol

@@ -1,26 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBProjectsSetup} from "./JBProjectsSetup.sol";
-
-contract TestSupportsInterface_Local is JBProjectsSetup {
-    function setUp() public {
-        super.projectsSetup();
-    }
-
-    function test_WhenInterfaceIdIsIJBProjects() external {
-        // it will return true
-    }
-
-    function test_WhenInterfaceIdIsIERC721() external {
-        // it will return true
-    }
-
-    function test_WhenInterfaceIdIsIERC721Metadata() external {
-        // it will return true
-    }
-
-    function test_WhenInterfaceIdIsAnythingElse() external {
-        // it will return false
-    }
-}

package/test/units/static/JBProjects/TestSetResolver.sol

@@ -1,37 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {IJBTokenUriResolver} from "../../../../src/interfaces/IJBTokenUriResolver.sol";
-import {JBProjectsSetup} from "./JBProjectsSetup.sol";
-
-contract TestSetTokenURIResolver_Local is JBProjectsSetup {
-    IJBTokenUriResolver _resolver = IJBTokenUriResolver(makeAddr("uri"));
-
-    function setUp() public {
-        super.projectsSetup();
-    }
-
-    function test_WhenCallerIsOwner() external {
-        // it will set resolver and emit SetTokenUriResolver
-
-        // expect call from owner since we prank
-        vm.expectEmit();
-        emit IJBProjects.SetTokenUriResolver(_resolver, _owner);
-
-        vm.prank(_owner);
-        _projects.setTokenUriResolver(_resolver);
-    }
-
-    function test_WhenCallerIsNotOwner() external {
-        // it will revert
-
-        // encode custom error
-        bytes4 selector = bytes4(keccak256("OwnableUnauthorizedAccount(address)"));
-        bytes memory expectedError = abi.encodeWithSelector(selector, address(this));
-
-        vm.expectRevert(expectedError);
-
-        _projects.setTokenUriResolver(_resolver);
-    }
-}

package/test/units/static/JBProjects/TestTokenUri.sol

@@ -1,40 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {StdStorage, stdStorage} from "forge-std/StdStorage.sol";
-import {IJBTokenUriResolver} from "../../../../src/interfaces/IJBTokenUriResolver.sol";
-import {IERC721Metadata} from "@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol";
-import {JBProjectsSetup} from "./JBProjectsSetup.sol";
-
-contract TestTokenURI_Local is JBProjectsSetup {
-    using stdStorage for StdStorage;
-
-    IJBTokenUriResolver _resolver = IJBTokenUriResolver(makeAddr("uri"));
-
-    function setUp() public {
-        super.projectsSetup();
-    }
-
-    function test_WhenTheresNoResolver() external view {
-        // it will return empty string
-        string memory uri = IERC721Metadata(address(_projects)).tokenURI(0);
-
-        assertEq(bytes(uri), "");
-    }
-
-    function test_WhenTheresAResolver() external {
-        // it will return the resolved URI
-
-        // set tokenUriResolver
-        stdstore.target(address(_projects)).sig("tokenUriResolver()").checked_write(address(_resolver));
-
-        // mock call to mock resolver
-        bytes memory resolverCall = abi.encodeCall(IJBTokenUriResolver.getUri, (0));
-        bytes memory returned = abi.encode("JUICAY");
-
-        mockExpect(address(_resolver), resolverCall, returned);
-
-        string memory uri = IERC721Metadata(address(_projects)).tokenURI(0);
-        assertEq(bytes(uri), bytes("JUICAY"));
-    }
-}

package/test/units/static/JBRulesetMetadataResolver/TestSetCashOutTaxRateTo.sol

@@ -1,108 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
-import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
-import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-contract TestSetCashOutTaxRateTo_Local is JBTest {
-    using JBRulesetMetadataResolver for JBRulesetMetadata;
-
-    function setUp() external {}
-
-    function testFuzzEnsureCorrectlyPackedBits(
-        uint16 _fuzzReservedPercent,
-        uint16 _fuzzCashOutTaxRate,
-        uint16 _fuzzMetadata
-    )
-        external
-    {
-        // cash out tax rate should be re-set and re-packed correctly
-
-        address _hookAddress = makeAddr("someting");
-
-        _fuzzReservedPercent = uint16(bound(_fuzzReservedPercent, 0, JBConstants.MAX_RESERVED_PERCENT));
-        _fuzzCashOutTaxRate = uint16(bound(_fuzzCashOutTaxRate, 0, JBConstants.MAX_CASH_OUT_TAX_RATE));
-        // Ensure the metadata is a max of 14 bits.
-        _fuzzMetadata = uint16(bound(_fuzzCashOutTaxRate, 0, 16_383));
-
-        JBRulesetMetadata memory _rulesMetadata = JBRulesetMetadata({
-            reservedPercent: _fuzzReservedPercent,
-            cashOutTaxRate: _fuzzCashOutTaxRate,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: true,
-            pauseCreditTransfers: true,
-            allowOwnerMinting: true,
-            allowSetCustomToken: true,
-            allowTerminalMigration: true,
-            allowSetTerminals: true,
-            ownerMustSendPayouts: true,
-            allowSetController: true,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: true,
-            holdFees: true,
-            useTotalSurplusForCashOuts: true,
-            useDataHookForPay: true,
-            useDataHookForCashOut: true,
-            dataHook: _hookAddress,
-            metadata: _fuzzMetadata
-        });
-
-        uint256 _packed = _rulesMetadata.packRulesetMetadata();
-
-        // Reserved Rate
-        // forge-lint: disable-next-line(unsafe-typecast)
-        uint256 _reservedPercent = uint256(uint16(_packed >> 4));
-
-        // Cash out tax rate
-        // forge-lint: disable-next-line(unsafe-typecast)
-        uint256 _cashOutTaxRate = uint256(uint16(_packed >> 20));
-
-        assertEq(_reservedPercent, _fuzzReservedPercent);
-        assertEq(_cashOutTaxRate, _fuzzCashOutTaxRate);
-
-        for (uint256 _i = 68; _i < 81; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            uint256 _flag = uint256(uint16(_packed >> _i) & 1);
-            assertEq(_flag, 1);
-        }
-
-        // Data source address
-        // forge-lint: disable-next-line(unsafe-typecast)
-        address _packedDataHook = address(uint160(_packed >> 82));
-        assertEq(_packedDataHook, _hookAddress);
-
-        // Metadata
-        // forge-lint: disable-next-line(unsafe-typecast)
-        uint256 _packedMetadata = uint256(uint16(_packed >> 242));
-        assertEq(_packedMetadata, uint256(_fuzzMetadata));
-    }
-
-    function testFuzzEnsureCorrectlyPackedBits_implementationIndependent(JBRulesetMetadata memory _rulesMetadata)
-        external
-        pure
-    {
-        // Handle the unique constraints of the JBRulesetMetadata.
-        {
-            // First 2 bits of `metadata.metadata` are ignored
-            _rulesMetadata.metadata = _rulesMetadata.metadata % 16_383;
-        }
-
-        // Get the keccak from before.
-        bytes32 _before = keccak256(abi.encode(_rulesMetadata));
-
-        // Pack the metadata.
-        uint256 _packed = _rulesMetadata.packRulesetMetadata();
-
-        // Unpack the metadata and calculate the new keccak.
-        JBRuleset memory _ruleset;
-        _ruleset.metadata = _packed;
-        JBRulesetMetadata memory _unpackedMetadata = JBRulesetMetadataResolver.expandMetadata(_ruleset);
-        bytes32 _after = keccak256(abi.encode(_unpackedMetadata));
-
-        // Compare the before and the after.
-        assertEq(_before, _after);
-    }
-}

package/test/units/static/JBRulesets/JBRulesetsSetup.sol

@@ -1,24 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBRulesets} from "../../../../src/JBRulesets.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-/*
-Contract that deploys a target contract with other mock contracts to satisfy the constructor.
-Tests relative to this contract will be dependent on mock calls/emits and stdStorage.
-*/
-contract JBRulesetsSetup is JBTest {
-    // Target Contract
-    IJBRulesets public _rulesets;
-
-    // Mocks
-    IJBDirectory public directory = IJBDirectory(makeAddr("directory"));
-
-    function rulesetsSetup() public virtual {
-        // Instantiate the contract being tested
-        _rulesets = new JBRulesets(directory);
-    }
-}