@bananapus/core-v6 0.0.37 → 0.0.38

package/test/units/static/JBPermissions/TestHasPermissions.sol

@@ -1,93 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPermissions} from "../../../../src/JBPermissions.sol";
-import {JBPermissionsSetup} from "./JBPermissionsSetup.sol";
-
-contract TestHasPermissions_Local is JBPermissionsSetup {
-    address _op = makeAddr("operator");
-    address _account = makeAddr("account");
-    uint256 _projectId = 1;
-    uint256[] _permissionsArray = [256, 256];
-
-    function setUp() public {
-        super.permissionsSetup();
-    }
-
-    function test_WhenAnyPermissionIdGt255() external {
-        // it will revert with PERMISSION_ID_OUT_OF_BOUNDS
-        vm.expectRevert(abi.encodeWithSelector(JBPermissions.JBPermissions_PermissionIdOutOfBounds.selector, 256));
-        _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, true, true);
-    }
-
-    modifier whenAllPermissionIdsLt255() {
-        _permissionsArray = [1, 2, 3];
-        _;
-    }
-
-    function test_GivenOperatorDoesNotHaveAllPermissionsSpecified() external whenAllPermissionIdsLt255 {
-        // it will return false
-        uint256 permissions = 1 << 1;
-
-        // Find the storage slot
-        bytes32 permissionsOfSlot = keccak256(abi.encode(_op, uint256(0)));
-        bytes32 accountSlot = keccak256(abi.encode(_account, uint256(permissionsOfSlot)));
-        bytes32 slot = keccak256(abi.encode(_projectId, accountSlot));
-
-        // Set storage
-        vm.store(address(_permissions), slot, bytes32(permissions));
-
-        bool hasAll = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, false, true);
-        assertEq(hasAll, false);
-    }
-
-    function test_GivenOperatorHasAllPermissionsSpecified() external whenAllPermissionIdsLt255 {
-        // it will return true
-        uint256 permissions = 1 << 1;
-        permissions |= 1 << 2;
-        permissions |= 1 << 3;
-
-        // Find the storage slot
-        bytes32 permissionsOfSlot = keccak256(abi.encode(_op, uint256(0)));
-        bytes32 accountSlot = keccak256(abi.encode(_account, uint256(permissionsOfSlot)));
-        bytes32 slot = keccak256(abi.encode(_projectId, accountSlot));
-
-        // Set storage
-        vm.store(address(_permissions), slot, bytes32(permissions));
-
-        bool hasAll = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, false, false);
-        assertEq(hasAll, true);
-    }
-
-    function test_GivenOperatorHasAllPermissionsSpecifiedCounterCase() external whenAllPermissionIdsLt255 {
-        // it will return false
-        uint256 permissions = 1 << 1;
-        permissions |= 1 << 5;
-        permissions |= 1 << 7;
-
-        // Find the storage slot
-        bytes32 permissionsOfSlot = keccak256(abi.encode(_op, uint256(0)));
-        bytes32 accountSlot = keccak256(abi.encode(_account, uint256(permissionsOfSlot)));
-        bytes32 slot = keccak256(abi.encode(_projectId, accountSlot));
-
-        // Set storage
-        vm.store(address(_permissions), slot, bytes32(permissions));
-
-        bool hasAll = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, true, true);
-        bool hasAll2 = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, false, false);
-        bool hasAll3 = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, true, false);
-        bool hasAll4 = _permissions.hasPermissions(_op, _account, _projectId, _permissionsArray, false, true);
-
-        // True as it includes root
-        assertEq(hasAll, true);
-
-        // Does not include root
-        assertEq(hasAll2, false);
-
-        // True as it includes root
-        assertEq(hasAll3, true);
-
-        // Does not include root
-        assertEq(hasAll4, false);
-    }
-}

package/test/units/static/JBPermissions/TestSetPermissionsFor.sol

@@ -1,64 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPermissions} from "../../../../src/JBPermissions.sol";
-import {JBPermissionsData} from "../../../../src/structs/JBPermissionsData.sol";
-import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
-import {JBPermissionsSetup} from "./JBPermissionsSetup.sol";
-
-contract TestSetPermissionsFor_Local is JBPermissionsSetup {
-    address _op = makeAddr("operator");
-    address _account = makeAddr("account");
-    uint64 _projectId = 1;
-
-    function setUp() public {
-        super.permissionsSetup();
-    }
-
-    function test_WhenCallerDoesNotHavePermission() external {
-        // it will revert UNAUTHORIZED
-        JBPermissionsData memory emptyData;
-
-        vm.expectRevert(
-            abi.encodeWithSelector(
-                JBPermissions.JBPermissions_Unauthorized.selector, _account, address(this), 0, JBPermissionIds.ROOT
-            )
-        );
-        _permissions.setPermissionsFor(_account, emptyData);
-    }
-
-    function test_WhenCallerHasPermission() external {
-        // it packs permissions into a bitfield, stores them, and emits OperatorPermissionsSet
-
-        // used to set our root privelage and act as our counter case later
-        uint256 permissions = 1 << 1;
-
-        // Find the storage slot
-        bytes32 permissionsOfSlot = keccak256(abi.encode(_op, uint256(0)));
-        bytes32 accountSlot = keccak256(abi.encode(_account, uint256(permissionsOfSlot)));
-        bytes32 slot = keccak256(abi.encode(_projectId, accountSlot));
-
-        // Set storage: this contract can set permissions as ROOT
-        vm.store(address(_permissions), slot, bytes32(permissions));
-
-        uint8[] memory array = new uint8[](3);
-        array[0] = 1;
-        array[1] = 2;
-        array[2] = 3;
-
-        JBPermissionsData memory data = JBPermissionsData({operator: _op, projectId: _projectId, permissionIds: array});
-
-        // call it
-        vm.prank(_account);
-        _permissions.setPermissionsFor(_account, data);
-
-        // permissions that were set during the call
-        uint256 afterSet = _permissions.permissionsOf(_op, _account, _projectId);
-
-        // add missing permissions to our counter case "permissions" which we used to assign root access earlier
-        permissions |= 1 << 2;
-        permissions |= 1 << 3;
-
-        assertEq(afterSet, permissions);
-    }
-}

package/test/units/static/JBPrices/JBPricesSetup.sol

@@ -1,32 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPrices} from "../../../../src/JBPrices.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
-import {IJBPrices} from "../../../../src/interfaces/IJBPrices.sol";
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-/*
-Contract that deploys a target contract with other mock contracts to satisfy the constructor.
-Tests relative to this contract will be dependent on mock calls/emits and stdStorage.
-*/
-contract JBPricesSetup is JBTest {
-    address _owner = makeAddr("owner");
-
-    // Mocks
-    IJBPermissions public permissions = IJBPermissions(makeAddr("permissions"));
-    IJBProjects public projects = IJBProjects(makeAddr("projects"));
-    IJBDirectory public directory = IJBDirectory(makeAddr("directory"));
-    IJBRulesets public rulesets = IJBRulesets(makeAddr("rulesets"));
-
-    // Target Contract
-    IJBPrices public _prices;
-
-    function pricesSetup() public virtual {
-        // Instantiate the contract being tested
-        _prices = new JBPrices(directory, permissions, projects, _owner, address(0));
-    }
-}

package/test/units/static/JBPrices/TestAddPriceFeedFor.sol

@@ -1,107 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPrices} from "../../../../src/JBPrices.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {IJBPriceFeed} from "../../../../src/interfaces/IJBPriceFeed.sol";
-import {IJBPrices} from "../../../../src/interfaces/IJBPrices.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBPricesSetup} from "./JBPricesSetup.sol";
-
-contract TestAddPriceFeedFor_Local is JBPricesSetup {
-    IJBPriceFeed _feed = IJBPriceFeed(makeAddr("feed"));
-    // forge-lint: disable-next-line(mixed-case-variable)
-    uint256 DEFAULT_PROJECT_ID = 0;
-    uint256 _projectId = 1;
-    address _projectOneOwner = makeAddr("oneOwner");
-    uint256 _pricingCurrency = uint32(uint160(JBConstants.NATIVE_TOKEN));
-    uint256 _unitCurrency = uint32(uint160(makeAddr("someToken")));
-    uint256 _invalidCurrency = 0;
-
-    function setUp() public {
-        super.pricesSetup();
-    }
-
-    function test_WhenProjectIdIsTheDEFAULT_PROJECT_IDAndMsgSenderIsTheOwnerOfJBPrices() external {
-        // it should add the price feed without checking permissions
-
-        vm.prank(_owner);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    function test_WhenProjectIdIsTheDEFAULT_PROJECT_IDAndMsgSenderIsTheOwnerOfProjectZero() external {
-        // it should add the price feed
-        vm.prank(_owner);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    function test_WhenProjectIdIsTheDEFAULT_PROJECT_IDAndMsgSenderIsNotTheOwnerOfProjectZero() external {
-        // it should revert ONLY_OWNER()
-
-        // encode custom error
-        bytes4 selector = bytes4(keccak256("OwnableUnauthorizedAccount(address)"));
-        bytes memory expectedError = abi.encodeWithSelector(selector, address(this));
-
-        vm.expectRevert(expectedError);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    modifier whenProjectIsNotDefaultAndHasPermissions() {
-        // mock controllerOf call
-        mockExpect(
-            address(directory), abi.encodeCall(IJBDirectory.controllerOf, (_projectId)), abi.encode(address(this))
-        );
-        _;
-    }
-
-    function test_WhenProjectIdIsNotTheDEFAULT_PROJECT_ID() external whenProjectIsNotDefaultAndHasPermissions {
-        // it should require ADD_PRICE_FEED permission from the project's owner or an operator
-
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    function test_WhenPricingCurrencyOrUnitCurrencyIs0() external whenProjectIsNotDefaultAndHasPermissions {
-        // it should revert with INVALID_CURRENCY
-
-        vm.expectRevert(JBPrices.JBPrices_ZeroPricingCurrency.selector);
-        _prices.addPriceFeedFor(_projectId, _invalidCurrency, _unitCurrency, _feed);
-
-        vm.expectRevert(JBPrices.JBPrices_ZeroUnitCurrency.selector);
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _invalidCurrency, _feed);
-    }
-
-    function test_WhenADefaultFeedForTheCurrencyPairOrItsInverseAlreadyExists()
-        external
-        whenProjectIsNotDefaultAndHasPermissions
-    {
-        // it should revert with PRICE_FEED_ALREADY_EXISTS
-
-        vm.prank(_owner);
-        _prices.addPriceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency, _feed);
-
-        vm.expectRevert(abi.encodeWithSelector(JBPrices.JBPrices_PriceFeedAlreadyExists.selector, _feed));
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    function test_WhenThisProjectAlreadyHasFeedsForTheCurrencyPairOrItsInverse()
-        external
-        whenProjectIsNotDefaultAndHasPermissions
-    {
-        // it should revert with PRICE_FEED_ALREADY_EXISTS
-
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _unitCurrency, _feed);
-
-        vm.expectRevert(abi.encodeWithSelector(JBPrices.JBPrices_PriceFeedAlreadyExists.selector, _feed));
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _unitCurrency, _feed);
-    }
-
-    function test_HappyPath() external whenProjectIsNotDefaultAndHasPermissions {
-        // it should store the feed for the project and currency pair
-        // it should emit AddPriceFeed event with projectId, pricingCurrency, unitCurrency, and feed
-
-        vm.expectEmit();
-        emit IJBPrices.AddPriceFeed(_projectId, _pricingCurrency, _unitCurrency, _feed, address(this));
-
-        _prices.addPriceFeedFor(_projectId, _pricingCurrency, _unitCurrency, _feed);
-    }
-}

package/test/units/static/JBPrices/TestPricePerUnitOf.sol

@@ -1,132 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBPrices} from "../../../../src/JBPrices.sol";
-import {IJBPriceFeed} from "../../../../src/interfaces/IJBPriceFeed.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBPricesSetup} from "./JBPricesSetup.sol";
-
-contract TestPricePerUnitOf_Local is JBPricesSetup {
-    IJBPriceFeed _feed = IJBPriceFeed(makeAddr("priceFeed"));
-    // forge-lint: disable-next-line(mixed-case-variable)
-    uint256 DEFAULT_PROJECT_ID = 0;
-    uint256 _projectId = 1;
-    uint256 _defaultDirectPrice = 1_000_000_000;
-    uint256 _directPrice = 2_000_000_000;
-    uint256 _inversePrice = 1e18;
-    uint256 _directDecimals = 18;
-    uint256 _inverseDecimals = 6;
-    uint256 _pricingCurrency = uint32(uint160(JBConstants.NATIVE_TOKEN));
-    uint256 _unitCurrency = uint32(uint160(makeAddr("someToken")));
-
-    function setUp() public {
-        super.pricesSetup();
-    }
-
-    modifier givenDirectFeedExists() {
-        // Find the storage slot
-        bytes32 priceFeedForSlot = keccak256(abi.encode(_projectId, uint256(1)));
-        bytes32 pricingSlot = keccak256(abi.encode(_pricingCurrency, uint256(priceFeedForSlot)));
-        bytes32 slot = keccak256(abi.encode(_unitCurrency, uint256(pricingSlot)));
-
-        bytes32 feedBytes = bytes32(uint256(uint160(address(_feed))));
-
-        // Set direct price feed
-        vm.store(address(_prices), slot, feedBytes);
-
-        // Confirm price feed was set
-        IJBPriceFeed feed = _prices.priceFeedFor(_projectId, _pricingCurrency, _unitCurrency);
-        assertEq(address(feed), address(_feed));
-
-        bytes memory currentUnitPriceCall = abi.encodeCall(IJBPriceFeed.currentUnitPrice, (_inverseDecimals));
-        bytes memory directReturned = abi.encode(_directPrice);
-
-        mockExpect(address(feed), currentUnitPriceCall, directReturned);
-        _;
-    }
-
-    modifier givenIndirectFeedExists() {
-        // Find the storage slot
-        bytes32 priceFeedForSlot = keccak256(abi.encode(_projectId, uint256(1)));
-        bytes32 pricingSlot = keccak256(abi.encode(_unitCurrency, uint256(priceFeedForSlot)));
-        bytes32 slot = keccak256(abi.encode(_pricingCurrency, uint256(pricingSlot)));
-
-        bytes32 feedBytes = bytes32(uint256(uint160(address(_feed))));
-
-        // Set indirect price feed
-        vm.store(address(_prices), slot, feedBytes);
-
-        // Confirm price feed was set
-        IJBPriceFeed feed = _prices.priceFeedFor(_projectId, _unitCurrency, _pricingCurrency);
-        assertEq(address(feed), address(_feed));
-
-        bytes memory currentUnitPriceCall = abi.encodeCall(IJBPriceFeed.currentUnitPrice, (_directDecimals));
-        bytes memory directReturned = abi.encode(_inversePrice);
-
-        mockExpect(address(feed), currentUnitPriceCall, directReturned);
-        _;
-    }
-
-    modifier givenOnlyDefaultDirectFeedExists() {
-        // Find the storage slot
-        bytes32 priceFeedForSlot = keccak256(abi.encode(DEFAULT_PROJECT_ID, uint256(1)));
-        bytes32 pricingSlot = keccak256(abi.encode(_pricingCurrency, uint256(priceFeedForSlot)));
-        bytes32 slot = keccak256(abi.encode(_unitCurrency, uint256(pricingSlot)));
-
-        bytes32 feedBytes = bytes32(uint256(uint160(address(_feed))));
-
-        // Set direct price feed
-        vm.store(address(_prices), slot, feedBytes);
-
-        // Confirm price feed was set
-        IJBPriceFeed feed = _prices.priceFeedFor(DEFAULT_PROJECT_ID, _pricingCurrency, _unitCurrency);
-        assertEq(address(feed), address(_feed));
-
-        bytes memory currentUnitPriceCall = abi.encodeCall(IJBPriceFeed.currentUnitPrice, (_inverseDecimals));
-        bytes memory directReturned = abi.encode(_defaultDirectPrice);
-
-        mockExpect(address(feed), currentUnitPriceCall, directReturned);
-        _;
-    }
-
-    function test_WhenPricingCurrencyIsTheSameAsUnitCurrency() external view {
-        // it should return 1 with requested decimals
-
-        uint256 price = _prices.pricePerUnitOf(_projectId, _pricingCurrency, _pricingCurrency, 18);
-        assertEq(price, 1e18);
-    }
-
-    function test_WhenPriceFeedExistsForProjectIdAndPricingCurrencyToUnitCurrency() external givenDirectFeedExists {
-        // it should return the current price from price feed
-
-        uint256 pricesPrice = _prices.pricePerUnitOf(_projectId, _pricingCurrency, _unitCurrency, 6);
-        assertEq(pricesPrice, _directPrice);
-    }
-
-    function test_WhenInversePriceFeedExistsForProjectIdAndUnitCurrencyToPricingCurrency()
-        external
-        givenIndirectFeedExists
-    {
-        // it should return the inverse of the current price from inverse price feed
-
-        uint256 inversePrice = _prices.pricePerUnitOf(_projectId, _pricingCurrency, _unitCurrency, 18);
-        assertEq(inversePrice, _inversePrice);
-    }
-
-    function test_WhenProjectIdIsNotTheDEFAULT_PROJECT_IDAndNoDirectOrInversePriceFeedIsFound()
-        external
-        givenOnlyDefaultDirectFeedExists
-    {
-        // it should attempt to use the default price feed for DEFAULT_PROJECT_ID
-
-        uint256 defaultPrice = _prices.pricePerUnitOf(_projectId, _pricingCurrency, _unitCurrency, 6);
-        assertEq(defaultPrice, _defaultDirectPrice);
-    }
-
-    function test_WhenNoPriceFeedIsFoundOrExistsIncludingDefaultCase() external {
-        // it should revert with PRICE_FEED_NOT_FOUND
-
-        vm.expectRevert(JBPrices.JBPrices_PriceFeedNotFound.selector);
-        _prices.pricePerUnitOf(_projectId, _pricingCurrency, _unitCurrency, 6);
-    }
-}