@bananapus/core-v6 0.0.37 → 0.0.38

package/test/TestRulesetQueueing.sol

@@ -1,1025 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.6;
-
-import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
-import {JBController} from "../src/JBController.sol";
-import {JBDeadline} from "../src/JBDeadline.sol";
-import {JBRulesets} from "../src/JBRulesets.sol";
-import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
-import {IJBController} from "../src/interfaces/IJBController.sol";
-import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
-import {JBConstants} from "../src/libraries/JBConstants.sol";
-import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
-import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
-import {JBRuleset} from "../src/structs/JBRuleset.sol";
-import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
-import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
-import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
-import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
-
-// A project's rulesets can be queued, and re-queued as long as the current ruleset approval hook approves.
-contract TestRulesetQueuing_Local is TestBaseWorkflow {
-    IJBController private _controller;
-    JBRulesetMetadata private _metadata;
-    JBDeadline private _deadline;
-    JBSplitGroup[] private _splitGroup;
-    JBFundAccessLimitGroup[] private _fundAccessLimitGroup;
-    IJBTerminal private _terminal;
-    uint112 private _weight;
-
-    // forge-lint: disable-next-line(mixed-case-variable)
-    uint256 private _DEADLINE_DURATION = 3 days;
-    // forge-lint: disable-next-line(mixed-case-variable)
-    uint256 private _RULESET_DURATION_DAYS = 6;
-    // forge-lint: disable-next-line(unsafe-typecast, mixed-case-variable)
-    uint32 private _RULESET_DURATION = uint32(_RULESET_DURATION_DAYS * 1 days);
-
-    function setUp() public override {
-        super.setUp();
-
-        // Foundry defaults block.timestamp to 1, which causes underflow in tests using past timestamps.
-        vm.warp(1_000_001);
-
-        _terminal = jbMultiTerminal();
-        _controller = jbController();
-
-        _deadline = new JBDeadline(_DEADLINE_DURATION);
-        _weight = 1000 * 10 ** 18;
-
-        _metadata = JBRulesetMetadata({
-            reservedPercent: 0,
-            cashOutTaxRate: 0,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: false,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-    }
-
-    function launchProjectForTest() public returns (uint256) {
-        // Package up ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weight = _weight;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline;
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // Package up terminal configuration.
-        JBTerminalConfig[] memory _terminalConfigurations = new JBTerminalConfig[](1);
-        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
-        _tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-        _terminalConfigurations[0] =
-            JBTerminalConfig({terminal: _terminal, accountingContextsToAccept: _tokensToAccept});
-
-        uint256 projectId = _controller.launchProjectFor({
-            owner: address(multisig()),
-            projectUri: "myIPFSHash",
-            rulesetConfigurations: _rulesetConfig,
-            terminalConfigurations: _terminalConfigurations,
-            memo: ""
-        });
-
-        return projectId;
-    }
-
-    function launchProjectForTestWithThreeRulesets() public returns (uint256) {
-        // Package up ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](3);
-
-        // first ruleset
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = 1 days;
-        _rulesetConfig[0].weight = _weight;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // second
-        _rulesetConfig[1].mustStartAtOrAfter = uint48(block.timestamp + 1 days);
-        _rulesetConfig[1].duration = 1 days;
-        _rulesetConfig[1].weight = _weight + 100;
-        _rulesetConfig[1].weightCutPercent = 0;
-        _rulesetConfig[1].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[1].metadata = _metadata;
-        _rulesetConfig[1].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[1].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // third
-        _rulesetConfig[2].mustStartAtOrAfter = uint48(block.timestamp + 2 days);
-        _rulesetConfig[2].duration = 1 days;
-        _rulesetConfig[2].weight = _weight + 200;
-        _rulesetConfig[2].weightCutPercent = 0;
-        _rulesetConfig[2].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[2].metadata = _metadata;
-        _rulesetConfig[2].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[2].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // Package up terminal configuration.
-        JBTerminalConfig[] memory _terminalConfigurations = new JBTerminalConfig[](1);
-        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
-        _tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-        _terminalConfigurations[0] =
-            JBTerminalConfig({terminal: _terminal, accountingContextsToAccept: _tokensToAccept});
-
-        uint256 projectId = _controller.launchProjectFor({
-            owner: address(multisig()),
-            projectUri: "myIPFSHash",
-            rulesetConfigurations: _rulesetConfig,
-            terminalConfigurations: _terminalConfigurations,
-            memo: ""
-        });
-
-        return projectId;
-    }
-
-    function testEmptyConfig() public {
-        // it will revert with JBController_RulesetsArrayEmpty
-
-        // length of zero should revert
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](0);
-
-        // Deploy a project.
-        uint256 projectId = launchProjectForTest();
-
-        vm.expectRevert(JBController.JBController_RulesetsArrayEmpty.selector);
-
-        // call
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _rulesetConfig, "");
-    }
-
-    function testReconfigureProject() public {
-        // Package a ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weight = _weight;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline;
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Deploy a project.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the ruleset has a cycle number of 1.
-        assertEq(_ruleset.cycleNumber, 1);
-        // Make sure the ruleset's weight matches.
-        assertEq(_ruleset.weight, _weight);
-
-        // Keep a reference to the ruleset's ID.
-        uint256 _currentRulesetId = _ruleset.id;
-
-        // Increment the weight to create a difference.
-        _rulesetConfig[0].weight = _rulesetConfig[0].weight + 1;
-
-        // Add a ruleset.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _rulesetConfig, "");
-
-        // Make sure the current ruleset hasn't changed.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.id, _currentRulesetId);
-        assertEq(_ruleset.weight, _weight);
-
-        // Go to the start of the next ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration);
-
-        // Get the current ruleset.
-        JBRuleset memory _newRuleset = jbRulesets().currentOf(projectId);
-        // It should be the second cycle.
-        assertEq(_newRuleset.cycleNumber, 2);
-        assertEq(_newRuleset.weight, _weight + 1);
-        assertEq(_newRuleset.basedOnId, _currentRulesetId);
-    }
-
-    function testReconfigureProjectWithWeightOfZero() public {
-        // Package a ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline;
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Deploy a project.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the ruleset has a cycle number of 1.
-        assertEq(_ruleset.cycleNumber, 1);
-        // Make sure the ruleset's weight matches.
-        assertEq(_ruleset.weight, _weight);
-
-        // Keep a reference to the ruleset's ID.
-        uint256 _currentRulesetId = _ruleset.id;
-
-        // Increment the weight to create a difference.
-        _rulesetConfig[0].weight = 0;
-
-        // Add a ruleset.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _rulesetConfig, "");
-
-        // Make sure the current ruleset hasn't changed.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.id, _currentRulesetId);
-        assertEq(_ruleset.weight, _weight);
-
-        // Go to the start of the next ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration);
-
-        // Get the current ruleset.
-        JBRuleset memory _newRuleset = jbRulesets().currentOf(projectId);
-
-        // It should be the second cycle.
-        assertEq(_newRuleset.cycleNumber, 2);
-        assertEq(_newRuleset.weight, 0);
-        assertEq(_newRuleset.basedOnId, _currentRulesetId);
-    }
-
-    function testReconfigureProjectWithWeightOfOne() public {
-        // Package a ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline;
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Deploy a project.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the ruleset has a cycle number of 1.
-        assertEq(_ruleset.cycleNumber, 1);
-        // Make sure the ruleset's weight matches.
-        assertEq(_ruleset.weight, _weight);
-
-        // Keep a reference to the ruleset's ID.
-        uint256 _currentRulesetId = _ruleset.id;
-
-        // Increment the weight to create a difference.
-        _rulesetConfig[0].weight = 1;
-        _rulesetConfig[0].weightCutPercent = 1_000_000_000 / 2;
-        _rulesetConfig[0].duration = 1 days;
-
-        // Add a ruleset.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _rulesetConfig, "");
-
-        // Make sure the current ruleset hasn't changed.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.id, _currentRulesetId);
-        assertEq(_ruleset.weight, _weight);
-        assertEq(_ruleset.weightCutPercent, 0);
-
-        // Go to the start of the next ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration + 1 days);
-
-        // Get the current ruleset.
-        JBRuleset memory _newRuleset = jbRulesets().currentOf(projectId);
-
-        // It should be the second cycle.
-        assertEq(_newRuleset.cycleNumber, 3);
-        assertEq(_newRuleset.weight, _weight / 2);
-        assertEq(_newRuleset.basedOnId, _currentRulesetId);
-    }
-
-    function testMultipleQueuedOnCycledOver() public {
-        // Keep references to two different weights.
-        uint112 _weightFirstQueued = uint112(1234 * 10 ** 18);
-        uint112 _weightSecondQueued = uint112(6969 * 10 ** 18);
-
-        // Launch a project.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the ruleset is correct.
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.weight, _weight);
-
-        // Keep a reference to the current ruleset ID.
-        uint256 _currentRulesetId = _ruleset.id;
-
-        // Jump to the next ruleset.
-        vm.warp(block.timestamp + _ruleset.duration);
-
-        // Package up a first ruleset configuration to queue.
-        JBRulesetConfig[] memory _firstQueued = new JBRulesetConfig[](1);
-        _firstQueued[0].mustStartAtOrAfter = 0;
-        _firstQueued[0].duration = _RULESET_DURATION;
-        _firstQueued[0].weight = _weightFirstQueued;
-        _firstQueued[0].weightCutPercent = 0;
-        _firstQueued[0].approvalHook = _deadline; // 3 day deadline duration.
-        _firstQueued[0].metadata = _metadata;
-        _firstQueued[0].splitGroups = _splitGroup;
-        _firstQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Queue.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _firstQueued, "");
-
-        // Package up another ruleset configuration to queue.
-        JBRulesetConfig[] memory _secondQueued = new JBRulesetConfig[](1);
-        _secondQueued[0].mustStartAtOrAfter = 0;
-        _secondQueued[0].duration = _RULESET_DURATION;
-        _secondQueued[0].weight = _weightSecondQueued;
-        _secondQueued[0].weightCutPercent = 0;
-        _secondQueued[0].approvalHook = _deadline; // 3 day deadline duration.
-        _secondQueued[0].metadata = _metadata;
-        _secondQueued[0].splitGroups = _splitGroup;
-        _secondQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Queue again
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _secondQueued, "");
-
-        // Since the second ruleset was queued during the same block as the one prior, increment the ruleset ID.
-        uint256 secondRulesetId = block.timestamp + 1;
-
-        // The current ruleset should not have changed, still in ruleset #2, cycled over from ruleset #1.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 2);
-        assertEq(_ruleset.id, _currentRulesetId);
-        assertEq(_ruleset.weight, _weight);
-
-        // Jump to after the deadline has passed, but before the next ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration - 1);
-
-        // Make sure the queued ruleset is the second one queued.
-        JBRuleset memory queuedRuleset = jbRulesets().upcomingOf(projectId);
-        assertEq(queuedRuleset.cycleNumber, 3);
-        assertEq(queuedRuleset.id, secondRulesetId);
-        assertEq(queuedRuleset.weight, _weightSecondQueued);
-
-        // Go the the start of the queued ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration);
-
-        // Make sure the second queued is now the current ruleset.
-        JBRuleset memory _newRuleset = jbRulesets().currentOf(projectId);
-        assertEq(_newRuleset.cycleNumber, 3);
-        assertEq(_newRuleset.id, secondRulesetId);
-        assertEq(_newRuleset.weight, _weightSecondQueued);
-    }
-
-    function testMultipleReconfigure(uint8 _deadlineDuration) public {
-        // Create a deadline with the provided deadline duration.
-        _deadline = new JBDeadline(_deadlineDuration);
-
-        // Package the ruleset data.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weight = 10_000 ether;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline;
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Launch a project to test.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the initial, current, and queued rulesets.
-        JBRuleset memory initialRuleset = jbRulesets().currentOf(projectId);
-        JBRuleset memory currentRuleset = initialRuleset;
-        JBRuleset memory upcomingRuleset = jbRulesets().upcomingOf(projectId);
-
-        for (uint256 i = 0; i < _RULESET_DURATION_DAYS + 1; i++) {
-            // If the deadline is less than the ruleset's duration, make sure the current ruleset's weight is linearly
-            // decremented.
-            if (_deadlineDuration + i * 1 days < currentRuleset.duration) {
-                assertEq(currentRuleset.weight, initialRuleset.weight - i);
-            }
-
-            JBRulesetConfig[] memory _config = new JBRulesetConfig[](1);
-            _config[0].mustStartAtOrAfter = 0;
-            _config[0].duration = _RULESET_DURATION;
-            // Package up a new ruleset with a decremented weight.
-            _config[0].weight = uint112(initialRuleset.weight - (i + 1)); // i+1 -> next ruleset
-            _config[0].weightCutPercent = 0;
-            _config[0].approvalHook = _deadline;
-            _config[0].metadata = _metadata;
-            _config[0].splitGroups = _splitGroup;
-            _config[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-            // Queue the ruleset.
-            vm.prank(multisig());
-            _controller.queueRulesetsOf(projectId, _config, "");
-
-            // Get a reference to the current and upcoming rulesets.
-            currentRuleset = jbRulesets().currentOf(projectId);
-            upcomingRuleset = jbRulesets().upcomingOf(projectId);
-
-            // Get a list of queued rulesets
-            JBRuleset[] memory rulesetsOf = jbRulesets().allOf(projectId, 0, 1);
-
-            // Make sure the upcoming ruleset is the ruleset currently under the approval hook.
-            assertEq(upcomingRuleset.weight, _config[0].weight);
-            assertEq(rulesetsOf[0].weight, _config[0].weight);
-
-            // If the full deadline duration included in the ruleset.
-            if (
-                _deadlineDuration == 0
-                    || currentRuleset.duration % (_deadlineDuration + i * 1 days) < currentRuleset.duration
-            ) {
-                // Make sure the current ruleset's weight is still linearly decremented.
-                assertEq(currentRuleset.weight, initialRuleset.weight - i);
-
-                // Shift forward the start of the deadline into the ruleset, one day at a time, from ruleset to ruleset.
-                vm.warp(currentRuleset.start + currentRuleset.duration + i * 1 days);
-
-                // Make sure what was the upcoming ruleset is now current.
-                currentRuleset = jbRulesets().currentOf(projectId);
-                assertEq(currentRuleset.weight, _config[0].weight);
-
-                // Make the upcoming is the cycled over version of current.
-                upcomingRuleset = jbRulesets().upcomingOf(projectId);
-                assertEq(upcomingRuleset.weight, _config[0].weight);
-            }
-            // If the deadline duration is across many rulesets.
-            else {
-                // Make sure the current ruleset has cycled over.
-                vm.warp(currentRuleset.start + currentRuleset.duration);
-                assertEq(currentRuleset.weight, initialRuleset.weight - i);
-
-                // Make sure the new ruleset has started once the deadline duration has passed.
-                vm.warp(currentRuleset.start + currentRuleset.duration + _deadlineDuration);
-                currentRuleset = jbRulesets().currentOf(projectId);
-                assertEq(currentRuleset.weight, _config[0].weight);
-            }
-        }
-    }
-
-    function testLaunchProjectWrongApprovalHook() public {
-        /// Package the configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = 0;
-        _rulesetConfig[0].weight = _weight;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Launch the project.
-        uint256 projectId = launchProjectForTest();
-
-        IJBRulesetApprovalHook invalidHook = IJBRulesetApprovalHook(address(6969));
-
-        vm.prank(multisig());
-        vm.expectRevert(abi.encodeWithSelector(JBRulesets.JBRulesets_InvalidRulesetApprovalHook.selector, invalidHook));
-
-        JBRulesetConfig[] memory _config = new JBRulesetConfig[](1);
-        _config[0].mustStartAtOrAfter = 0;
-        _config[0].duration = _RULESET_DURATION;
-        _config[0].weight = 12_345 * 10 ** 18;
-        _config[0].weightCutPercent = 0;
-        _config[0].approvalHook = invalidHook;
-        _config[0].metadata = _metadata;
-        _config[0].splitGroups = _splitGroup;
-        _config[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        _controller.queueRulesetsOf(projectId, _config, "");
-    }
-
-    function testQueueShortDurationProject() public {
-        uint32 _shortDuration = 5 minutes;
-
-        _weight = uint112(10_000 * 10 ** 18);
-        _RULESET_DURATION = _shortDuration;
-
-        // Launch a project to test.
-        uint256 projectId = launchProjectForTest();
-
-        // Get a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the current ruleset is correct.
-        assertEq(_ruleset.cycleNumber, 1); // Ok.
-        assertEq(_ruleset.weight, _weight);
-
-        // Keep a reference to the current ruleset ID.
-        uint256 _currentRulesetId = _ruleset.id;
-
-        // Package up a reconfiguration.
-        JBRulesetConfig[] memory _config = new JBRulesetConfig[](1);
-        _config[0].mustStartAtOrAfter = 0;
-        _config[0].duration = _RULESET_DURATION;
-        _config[0].weight = 69 * 10 ** 18;
-        _config[0].weightCutPercent = 0;
-        _config[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _config[0].metadata = _metadata;
-        _config[0].splitGroups = _splitGroup;
-        _config[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Submit the reconfiguration.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _config, "");
-
-        // Make sure the ruleset hasn't changed.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.id, _currentRulesetId);
-        assertEq(_ruleset.weight, _weight);
-
-        // Go the the second ruleset.
-        vm.warp(_ruleset.start + _ruleset.duration);
-
-        // Make sure the ruleset cycled over.
-        JBRuleset memory _newRuleset = jbRulesets().currentOf(projectId);
-        assertEq(_newRuleset.cycleNumber, 2);
-        assertEq(_newRuleset.weight, _weight);
-
-        // Go to the end of the deadline duration.
-        vm.warp(_ruleset.start + _ruleset.duration + _DEADLINE_DURATION);
-
-        // Make sure the queued cycle is in effect.
-        _newRuleset = jbRulesets().currentOf(projectId);
-        assertEq(_newRuleset.cycleNumber, _ruleset.cycleNumber + (_DEADLINE_DURATION / _shortDuration) + 1);
-        assertEq(_newRuleset.weight, _config[0].weight);
-    }
-
-    function testQueueWithoutApprovalHook() public {
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = 5 minutes;
-        _rulesetConfig[0].weight = 10_000 * 10 ** 18;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Launch a project to test with.
-        uint256 projectId = launchProjectForTest();
-
-        // Get a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Make sure the ruleset is expected.
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.weight, _weight);
-
-        // Package a new config.
-        JBRulesetConfig[] memory _config = new JBRulesetConfig[](1);
-
-        _config[0].mustStartAtOrAfter = 0;
-        _config[0].duration = _RULESET_DURATION;
-        _config[0].weight = 69 * 10 ** 18;
-        _config[0].weightCutPercent = 0;
-        _config[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _config[0].metadata = _metadata;
-        _config[0].splitGroups = _splitGroup;
-        _config[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _config, "");
-
-        // Make sure the ruleset hasn't changed.
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.weight, _weight);
-
-        // Make sure the ruleset has changed once the ruleset is over.
-        vm.warp(_ruleset.start + _ruleset.duration);
-        _ruleset = jbRulesets().currentOf(projectId);
-        assertEq(_ruleset.cycleNumber, 2);
-        assertEq(_ruleset.weight, 69 * 10 ** 18);
-    }
-
-    function testMixedStarts() public {
-        // Keep references to our different weights for assertions.
-        uint112 _weightInitial = uint112(1000 * 10 ** 18);
-        uint112 _weightFirstQueued = uint112(1234 * 10 ** 18);
-        uint112 _weightSecondQueued = uint112(6969 * 10 ** 18);
-
-        // Package up a config.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = _RULESET_DURATION;
-        _rulesetConfig[0].weight = _weightInitial;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = _deadline; // day deadline duration.
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Launch the project to test with.
-        uint256 projectId = launchProjectForTest();
-
-        // Get the ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Keep a reference to the expected ruleset IDs (use returned id to avoid via_ir reordering of block.timestamp).
-        uint256 _initialRulesetId = _ruleset.id;
-
-        // Make sure the first ruleset has begun.
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.weight, _weightInitial);
-
-        // Package up a new config.
-        JBRulesetConfig[] memory _firstQueued = new JBRulesetConfig[](1);
-        _firstQueued[0].mustStartAtOrAfter = 0;
-        _firstQueued[0].duration = _RULESET_DURATION;
-        _firstQueued[0].weight = _weightFirstQueued;
-        _firstQueued[0].weightCutPercent = 0;
-        _firstQueued[0].approvalHook = _deadline; // 3 day deadline duration.
-        _firstQueued[0].metadata = _metadata;
-        _firstQueued[0].splitGroups = _splitGroup;
-        _firstQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Queue a ruleset to be overridden (will be in `ApprovalExpected` status of the approval hook).
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _firstQueued, "");
-
-        // Make sure the ruleset is queued.
-        JBRuleset memory _queued = jbRulesets().upcomingOf(projectId);
-        assertEq(_queued.cycleNumber, 2);
-        assertEq(_queued.id, _initialRulesetId + 1);
-        assertEq(_queued.weight, _weightFirstQueued);
-
-        // Get a list of queued rulesets
-        JBRuleset[] memory queuedRulesets = jbRulesets().allOf(projectId, 0, 1);
-
-        // Ensure rulesetsOf is accurate
-        assertEq(queuedRulesets[0].weight, _weightFirstQueued);
-
-        // Package up another config.
-        JBRulesetConfig[] memory _secondQueued = new JBRulesetConfig[](1);
-        _secondQueued[0].mustStartAtOrAfter = uint48(block.timestamp + 9 days);
-        _secondQueued[0].duration = _RULESET_DURATION;
-        _secondQueued[0].weight = _weightSecondQueued;
-        _secondQueued[0].weightCutPercent = 0;
-        _secondQueued[0].approvalHook = _deadline;
-        _secondQueued[0].metadata = _metadata;
-        _secondQueued[0].splitGroups = _splitGroup;
-        _secondQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Queue the ruleset.
-        // Will follow the cycled over (ruleset #1) ruleset, after overriding the above config, because the first
-        // ruleset queued is in `ApprovalExpected` status (the 3 day deadline has not passed).
-        // Ruleset #1 rolls over because our `mustStartAtOrAfter` occurs later than when ruleset #1 ends.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _secondQueued, "");
-
-        // Make sure this latest queued ruleset implies a cycled over ruleset from ruleset #1.
-        JBRuleset memory _requeued = jbRulesets().upcomingOf(projectId);
-        assertEq(_requeued.cycleNumber, 2);
-        assertEq(_requeued.id, _initialRulesetId);
-        assertEq(_requeued.weight, _weightInitial);
-
-        // Get a list of queued rulesets
-        JBRuleset[] memory queuedRulesets2 = jbRulesets().allOf(projectId, 0, 1);
-
-        // Ensure rulesetsOf is accurate
-        assertEq(queuedRulesets2[0].weight, _weightSecondQueued);
-
-        // Warp to when the initial ruleset rolls over and again becomes the current.
-        vm.warp(block.timestamp + _RULESET_DURATION);
-
-        // Make sure the new current is a rolled over ruleset.
-        JBRuleset memory _initialIsCurrent = jbRulesets().currentOf(projectId);
-        assertEq(_initialIsCurrent.cycleNumber, 2);
-        assertEq(_initialIsCurrent.id, _initialRulesetId);
-        assertEq(_initialIsCurrent.weight, _weightInitial);
-
-        // Second queued ruleset that replaced our first queued ruleset.
-        JBRuleset memory _requeued2 = jbRulesets().upcomingOf(projectId);
-        assertEq(_requeued2.cycleNumber, 3);
-        assertEq(_requeued2.id, _initialRulesetId + 2);
-        assertEq(_requeued2.weight, _weightSecondQueued);
-
-        // Get queued rulesets
-        JBRuleset[] memory queuedRulesets3 = jbRulesets().allOf(projectId, 0, 1);
-
-        // Ensure rulesetsOf is accurate
-        assertEq(queuedRulesets3[0].weight, _weightSecondQueued);
-    }
-
-    function testSingleBlockOverwriteQueued() public {
-        // Keep references to our different weights for assertions.
-        uint112 _weightFirstQueued = uint112(1234 * 10 ** 18);
-        uint112 _weightSecondQueued = uint112(6969 * 10 ** 18);
-
-        // Keep a reference to the expected ruleset ID (timestamp) after queuing, starting now, incremented later
-        // in-line for readability.
-        uint256 _expectedRulesetId = block.timestamp;
-
-        // Package up a config.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = 0;
-        _rulesetConfig[0].weight = _weight;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = _splitGroup;
-        _rulesetConfig[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Deploy a project to test.
-        uint256 projectId = launchProjectForTest();
-
-        // Keep a reference to the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(projectId);
-
-        // Initial ruleset data: will have a `block.timestamp` (`rulesetId`) that is 2 less than the second queued
-        // ruleset (`rulesetId` timestamps are incremented when queued in same block).
-        assertEq(_ruleset.cycleNumber, 1);
-        assertEq(_ruleset.weight, _weight);
-
-        // Package up another config.
-        JBRulesetConfig[] memory _firstQueued = new JBRulesetConfig[](1);
-        _firstQueued[0].mustStartAtOrAfter = uint48(block.timestamp + 3 days);
-        _firstQueued[0].duration = _RULESET_DURATION;
-        _firstQueued[0].weight = _weightFirstQueued;
-        _firstQueued[0].weightCutPercent = 0;
-        _firstQueued[0].approvalHook = _deadline; // 3 day deadline duration.
-        _firstQueued[0].metadata = _metadata;
-        _firstQueued[0].splitGroups = _splitGroup;
-        _firstQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Becomes queued & will be overwritten as 3 days will not pass and its status is `ApprovalExpected`.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _firstQueued, "");
-
-        // Get a reference to the queued cycle.
-        JBRuleset memory queuedToOverwrite = jbRulesets().upcomingOf(projectId);
-
-        assertEq(queuedToOverwrite.cycleNumber, 2);
-        assertEq(queuedToOverwrite.id, _expectedRulesetId + 1);
-        assertEq(queuedToOverwrite.weight, _weightFirstQueued);
-
-        // Package up another config to overwrite.
-        JBRulesetConfig[] memory _secondQueued = new JBRulesetConfig[](1);
-
-        // forge-lint: disable-next-line(unsafe-typecast)
-        _secondQueued[0].mustStartAtOrAfter = uint48(block.timestamp + _DEADLINE_DURATION);
-        _secondQueued[0].duration = _RULESET_DURATION;
-        _secondQueued[0].weight = _weightSecondQueued;
-        _secondQueued[0].weightCutPercent = 0;
-        _secondQueued[0].approvalHook = _deadline; // 3 day deadline duration.
-        _secondQueued[0].metadata = _metadata;
-        _secondQueued[0].splitGroups = _splitGroup;
-        _secondQueued[0].fundAccessLimitGroups = _fundAccessLimitGroup;
-
-        // Queuing the second ruleset will overwrite the first queued ruleset.
-        vm.prank(multisig());
-        _controller.queueRulesetsOf(projectId, _secondQueued, "");
-
-        // Make sure it's overwritten.
-        JBRuleset memory queued = jbRulesets().upcomingOf(projectId);
-        assertEq(queued.cycleNumber, 2);
-        assertEq(queued.id, _expectedRulesetId + 2);
-        assertEq(queued.weight, _weightSecondQueued);
-    }
-
-    function testApprovalHook(uint256 _start, uint256 _rulesetId, uint256 _duration) public {
-        _start = bound(_start, block.timestamp, block.timestamp + 1000 days);
-        _rulesetId = bound(_rulesetId, block.timestamp, block.timestamp + 1000 days);
-        _duration = bound(_duration, 1, block.timestamp);
-
-        JBRuleset memory _ruleset = JBRuleset({
-            // forge-lint: disable-next-line(unsafe-typecast)
-            id: uint48(_rulesetId),
-            basedOnId: 0,
-            cycleNumber: 1,
-            // forge-lint: disable-next-line(unsafe-typecast)
-            start: uint48(_start),
-            // forge-lint: disable-next-line(unsafe-typecast)
-            duration: uint32(_duration),
-            weight: 1,
-            weightCutPercent: 0,
-            metadata: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0))
-        });
-
-        JBDeadline deadline = new JBDeadline(_duration);
-
-        JBApprovalStatus _currentStatus = deadline.approvalStatusOf(1, _ruleset); // 1 is the `projectId`,
-        // unused
-
-        // Ruleset ID (timestamp) is after deadline -> approval hook failed.
-        if (_rulesetId > _start) {
-            assertEq(uint256(_currentStatus), uint256(JBApprovalStatus.Failed));
-        }
-        // Deadline starts less than a `duration` away from the `rulesetId` -> failed (would start mid-ruleset).
-        else if (_start - _duration < _rulesetId) {
-            assertEq(uint256(_currentStatus), uint256(JBApprovalStatus.Failed));
-        }
-        // Deadline starts more than a `_duration` away (will be approved when enough time has passed) -> approval
-        // expected.
-        else if (block.timestamp + _duration < _start) {
-            assertEq(uint256(_currentStatus), uint256(JBApprovalStatus.ApprovalExpected));
-        }
-        // If enough time has passed since deadline start, approved.
-        else if (block.timestamp + _duration > _start) {
-            assertEq(uint256(_currentStatus), uint256(JBApprovalStatus.Approved));
-        }
-    }
-
-    function testRulesetViewAccuracy() public {
-        // setup: deploy project and queue 2 rulesets atop the initial ruleset
-        uint256 id = launchProjectForTestWithThreeRulesets();
-
-        // Get a list of queued rulesets
-        JBRuleset[] memory rulesetsOf = jbRulesets().allOf(id, 0, 3);
-
-        // check: three rulesets returned
-        assertEq(rulesetsOf.length, 3);
-
-        // check: queued with furthest start time
-        assertEq(rulesetsOf[0].weight, _weight + 200);
-
-        // check: queued with nearest start time
-        assertEq(rulesetsOf[1].weight, _weight + 100);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[2].weight, _weight);
-
-        // get the current ruleset
-        JBRuleset memory currentRuleset = jbRulesets().currentOf(id);
-
-        // check: current should be the initial ruleset
-        assertEq(currentRuleset.weight, _weight);
-
-        // get upcoming ruleset
-        JBRuleset memory upcomingRuleset = jbRulesets().upcomingOf(id);
-
-        // check: upcoming ruleset should be 2nd queued
-        assertEq(upcomingRuleset.weight, _weight + 100);
-
-        // Get a list of queued rulesets
-        rulesetsOf = jbRulesets().allOf(id, 0, 3);
-
-        // check: three rulesets returned again
-        assertEq(rulesetsOf.length, 3);
-
-        // check: queued with furthest start time
-        assertEq(rulesetsOf[0].weight, _weight + 200);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[1].weight, _weight + 100);
-
-        // check: past with nearest start time
-        assertEq(rulesetsOf[2].weight, _weight);
-
-        // Get a list of queued rulesets
-        rulesetsOf = jbRulesets().allOf(id, 0, 2);
-
-        // check: two rulesets returned again
-        assertEq(rulesetsOf.length, 2);
-
-        // check: queued with furthest start time
-        assertEq(rulesetsOf[0].weight, _weight + 200);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[1].weight, _weight + 100);
-
-        // Get a list of queued rulesets
-        rulesetsOf = jbRulesets().allOf(id, upcomingRuleset.id, 2);
-
-        // check: two rulesets returned again
-        assertEq(rulesetsOf.length, 2);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[0].weight, _weight + 100);
-
-        // check: past with nearest start time
-        assertEq(rulesetsOf[1].weight, _weight);
-
-        // Get a list of queued rulesets
-        rulesetsOf = jbRulesets().allOf(id, upcomingRuleset.id, 1);
-
-        // check: one rulesets returned again
-        assertEq(rulesetsOf.length, 1);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[0].weight, _weight + 100);
-
-        // Get a list of queued rulesets with a larger size than there are rulesets.
-        rulesetsOf = jbRulesets().allOf(id, 0, 10);
-
-        // check: three rulesets returned
-        assertEq(rulesetsOf.length, 3);
-
-        // check: queued with furthest start time
-        assertEq(rulesetsOf[0].weight, _weight + 200);
-
-        // check: queued with nearest start time
-        assertEq(rulesetsOf[1].weight, _weight + 100);
-
-        // check: current with nearest start time
-        assertEq(rulesetsOf[2].weight, _weight);
-    }
-
-    function testWithThreeHistoricalRulesets() public {
-        // Package up ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](3);
-
-        // first ruleset in the past
-        _rulesetConfig[0].mustStartAtOrAfter = uint48(block.timestamp - 2 days);
-        _rulesetConfig[0].duration = 1 hours;
-        _rulesetConfig[0].weight = uint112(_weight);
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // second ruleset started in the past but should still be active
-        _rulesetConfig[1].mustStartAtOrAfter = uint48(block.timestamp - 2 hours);
-        _rulesetConfig[1].duration = 1 hours;
-        _rulesetConfig[1].weight = uint112(_weight + 100);
-        _rulesetConfig[1].weightCutPercent = 0;
-        _rulesetConfig[1].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[1].metadata = _metadata;
-        _rulesetConfig[1].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[1].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // third
-        _rulesetConfig[2].mustStartAtOrAfter = uint48(block.timestamp + 1 days);
-        _rulesetConfig[2].duration = 1 days;
-        _rulesetConfig[2].weight = uint112(_weight + 200);
-        _rulesetConfig[2].weightCutPercent = 0;
-        _rulesetConfig[2].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[2].metadata = _metadata;
-        _rulesetConfig[2].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[2].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        // Package up terminal configuration.
-        JBTerminalConfig[] memory _terminalConfigurations = new JBTerminalConfig[](1);
-        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
-        _tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-        _terminalConfigurations[0] =
-            JBTerminalConfig({terminal: _terminal, accountingContextsToAccept: _tokensToAccept});
-
-        uint256 projectId = _controller.launchProjectFor({
-            owner: address(multisig()),
-            projectUri: "myIPFSHash",
-            rulesetConfigurations: _rulesetConfig,
-            terminalConfigurations: _terminalConfigurations,
-            memo: ""
-        });
-
-        // Get a list of queued rulesets
-        JBRuleset[] memory rulesetsOf = jbRulesets().allOf(projectId, 0, 3);
-
-        // check: three rulesets returned
-        assertEq(rulesetsOf.length, 3);
-
-        // get the current ruleset
-        JBRuleset memory currentRuleset = jbRulesets().currentOf(projectId);
-
-        // check: current should be the second ruleset
-        assertEq(currentRuleset.weight, _weight + 100);
-
-        // check: current should be an iterated cycle.
-        assertEq(currentRuleset.cycleNumber, (2 days / 1 hours) + 1);
-    }
-}