@bananapus/core-v6 0.0.37 → 0.0.38

package/test/TestMigrationHeldFees.sol

@@ -1,255 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.6;
-
-import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
-import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
-import {JBTerminalStore} from "../src/JBTerminalStore.sol";
-import {JBTokens} from "../src/JBTokens.sol";
-import {IJBController} from "../src/interfaces/IJBController.sol";
-import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
-import {JBConstants} from "../src/libraries/JBConstants.sol";
-import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
-import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
-import {JBFee} from "../src/structs/JBFee.sol";
-import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
-import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
-import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
-import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
-import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
-
-/// @notice Confirms held fees are stranded when a terminal migrates.
-/// The migration calls addToBalanceOf with shouldReturnHeldFees: false,
-/// leaving held fees in the old terminal with no balance to process them.
-contract TestMigrationHeldFees_Local is TestBaseWorkflow {
-    IJBController private _controller;
-    JBMultiTerminal private _terminal;
-    JBMultiTerminal private _terminal2;
-    JBTokens private _tokens;
-    JBTerminalStore private _store;
-    uint256 private _projectId;
-    address private _projectOwner;
-
-    uint112 private constant WEIGHT = 1000 * 10 ** 18;
-    uint112 private constant PAY_AMOUNT = 10 ether;
-
-    function setUp() public override {
-        super.setUp();
-
-        _projectOwner = multisig();
-        _controller = jbController();
-        _terminal = jbMultiTerminal();
-        _terminal2 = jbMultiTerminal2();
-        _tokens = jbTokens();
-        _store = jbTerminalStore();
-
-        // Ruleset with holdFees=true and allowTerminalMigration=true.
-        JBRulesetMetadata memory metadata = JBRulesetMetadata({
-            reservedPercent: 0,
-            cashOutTaxRate: 0,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: true,
-            allowSetTerminals: true,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: true, // Fees are held, not processed immediately.
-            useTotalSurplusForCashOuts: false,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-
-        JBRulesetConfig[] memory rulesetConfig = new JBRulesetConfig[](1);
-        rulesetConfig[0].mustStartAtOrAfter = 0;
-        rulesetConfig[0].duration = 0;
-        rulesetConfig[0].weight = WEIGHT;
-        rulesetConfig[0].weightCutPercent = 0;
-        rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        rulesetConfig[0].metadata = metadata;
-        rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-
-        // Set up payout limit so fees are taken on payouts.
-        JBCurrencyAmount[] memory payoutLimits = new JBCurrencyAmount[](1);
-        payoutLimits[0] =
-            JBCurrencyAmount({amount: uint224(PAY_AMOUNT), currency: uint32(uint160(JBConstants.NATIVE_TOKEN))});
-        JBFundAccessLimitGroup[] memory limitGroups = new JBFundAccessLimitGroup[](1);
-        limitGroups[0] = JBFundAccessLimitGroup({
-            terminal: address(_terminal),
-            token: JBConstants.NATIVE_TOKEN,
-            payoutLimits: payoutLimits,
-            surplusAllowances: new JBCurrencyAmount[](0)
-        });
-        rulesetConfig[0].fundAccessLimitGroups = limitGroups;
-
-        // Terminal configs — both terminals accept native token.
-        JBAccountingContext[] memory tokensToAccept = new JBAccountingContext[](1);
-        tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-
-        JBTerminalConfig[] memory terminalConfigs = new JBTerminalConfig[](2);
-        terminalConfigs[0] =
-            JBTerminalConfig({terminal: IJBTerminal(address(_terminal)), accountingContextsToAccept: tokensToAccept});
-        terminalConfigs[1] =
-            JBTerminalConfig({terminal: IJBTerminal(address(_terminal2)), accountingContextsToAccept: tokensToAccept});
-
-        // Fee project (#1).
-        JBTerminalConfig[] memory feeTerminalConfigs = new JBTerminalConfig[](1);
-        feeTerminalConfigs[0] =
-            JBTerminalConfig({terminal: IJBTerminal(address(_terminal)), accountingContextsToAccept: tokensToAccept});
-
-        JBRulesetConfig[] memory feeRulesetConfig = new JBRulesetConfig[](1);
-        feeRulesetConfig[0].mustStartAtOrAfter = 0;
-        feeRulesetConfig[0].duration = 0;
-        feeRulesetConfig[0].weight = WEIGHT;
-        feeRulesetConfig[0].metadata = metadata;
-        feeRulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        feeRulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        _controller.launchProjectFor({
-            owner: address(420),
-            projectUri: "fee",
-            rulesetConfigurations: feeRulesetConfig,
-            terminalConfigurations: feeTerminalConfigs,
-            memo: ""
-        });
-
-        // Test project (#2).
-        _projectId = _controller.launchProjectFor({
-            owner: _projectOwner,
-            projectUri: "test",
-            rulesetConfigurations: rulesetConfig,
-            terminalConfigurations: terminalConfigs,
-            memo: ""
-        });
-    }
-
-    /// @notice Pay → distribute payouts (holds fees) → migrate → fees stranded.
-    function test_migration_heldFeesStranded() external {
-        // Step 1: Pay the project.
-        _terminal.pay{value: PAY_AMOUNT}({
-            projectId: _projectId,
-            amount: PAY_AMOUNT,
-            token: JBConstants.NATIVE_TOKEN,
-            beneficiary: _projectOwner,
-            minReturnedTokens: 0,
-            memo: "",
-            metadata: new bytes(0)
-        });
-
-        // Step 2: Distribute payouts — fees will be held (holdFees=true).
-        vm.prank(_projectOwner);
-        _terminal.sendPayoutsOf({
-            projectId: _projectId,
-            token: JBConstants.NATIVE_TOKEN,
-            amount: PAY_AMOUNT,
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            minTokensPaidOut: 0
-        });
-
-        // Verify held fees exist.
-        JBFee[] memory heldFees = _terminal.heldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
-        assertGt(heldFees.length, 0, "Should have held fees after payout");
-
-        // Step 3: Migrate balance to terminal2.
-        vm.prank(_projectOwner);
-        _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, IJBTerminal(address(_terminal2)));
-
-        // Step 4: Verify old terminal has no balance but still has held fees.
-        uint256 balanceAfter = _store.balanceOf(address(_terminal), _projectId, JBConstants.NATIVE_TOKEN);
-        assertEq(balanceAfter, 0, "Old terminal should have 0 balance after migration");
-
-        // Held fees still exist in old terminal.
-        JBFee[] memory feesAfterMigration = _terminal.heldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
-        assertEq(feesAfterMigration.length, heldFees.length, "Held fees remain in old terminal");
-    }
-
-    /// @notice Process held fees FIRST, then migrate — correct approach.
-    function test_migration_feeProcessingBeforeMigration() external {
-        // Pay.
-        _terminal.pay{value: PAY_AMOUNT}({
-            projectId: _projectId,
-            amount: PAY_AMOUNT,
-            token: JBConstants.NATIVE_TOKEN,
-            beneficiary: _projectOwner,
-            minReturnedTokens: 0,
-            memo: "",
-            metadata: new bytes(0)
-        });
-
-        // Distribute payouts (holds fees).
-        vm.prank(_projectOwner);
-        _terminal.sendPayoutsOf({
-            projectId: _projectId,
-            token: JBConstants.NATIVE_TOKEN,
-            amount: PAY_AMOUNT,
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            minTokensPaidOut: 0
-        });
-
-        // Fast-forward past fee holding period (28 days).
-        vm.warp(block.timestamp + 28 days + 1);
-
-        // Process held fees before migration.
-        uint256 feeProjectBalanceBefore = _store.balanceOf(address(_terminal), 1, JBConstants.NATIVE_TOKEN);
-        _terminal.processHeldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
-        uint256 feeProjectBalanceAfter = _store.balanceOf(address(_terminal), 1, JBConstants.NATIVE_TOKEN);
-
-        // Fee project should have received fees.
-        assertGt(feeProjectBalanceAfter, feeProjectBalanceBefore, "Fee project should receive fees");
-
-        // Now held fees should be cleared.
-        JBFee[] memory feesAfter = _terminal.heldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
-        assertEq(feesAfter.length, 0, "Held fees should be cleared after processing");
-
-        // Now migrate safely.
-        vm.prank(_projectOwner);
-        _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, IJBTerminal(address(_terminal2)));
-    }
-
-    /// @notice After migration, processHeldFeesOf on old terminal processes nothing (no balance).
-    function test_migration_heldFeesUnclaimable() external {
-        // Pay and distribute.
-        _terminal.pay{value: PAY_AMOUNT}({
-            projectId: _projectId,
-            amount: PAY_AMOUNT,
-            token: JBConstants.NATIVE_TOKEN,
-            beneficiary: _projectOwner,
-            minReturnedTokens: 0,
-            memo: "",
-            metadata: new bytes(0)
-        });
-
-        vm.prank(_projectOwner);
-        _terminal.sendPayoutsOf({
-            projectId: _projectId,
-            token: JBConstants.NATIVE_TOKEN,
-            amount: PAY_AMOUNT,
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            minTokensPaidOut: 0
-        });
-
-        // Migrate.
-        vm.prank(_projectOwner);
-        _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, IJBTerminal(address(_terminal2)));
-
-        // Warp past holding period.
-        vm.warp(block.timestamp + 28 days + 1);
-
-        // Try to process held fees — the fees still exist but the old terminal has no ETH.
-        // The _processFee try-catch will catch the revert and credit the fee amount back to the project.
-        _terminal.processHeldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
-
-        // The fee processing attempted but the terminal has no actual ETH.
-        // The _recordAddedBalanceFor in the catch block inflates the store balance
-        // without actual funds — this is a phantom balance.
-        // This documents the issue: either fees are lost OR phantom balances are created.
-    }
-}

package/test/TestMintTokensOf.sol

@@ -1,185 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.6;
-
-import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
-import {IJBController} from "../src/interfaces/IJBController.sol";
-import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBRulesetDataHook} from "../src/interfaces/IJBRulesetDataHook.sol";
-import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
-import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
-import {JBConstants} from "../src/libraries/JBConstants.sol";
-import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
-import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
-import {JBRuleset} from "../src/structs/JBRuleset.sol";
-import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
-import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
-import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
-import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
-
-contract TestMintTokensOf_Local is TestBaseWorkflow {
-    uint8 private constant _WEIGHT_DECIMALS = 18;
-    uint112 private constant _WEIGHT = uint112(1000 * 10 ** _WEIGHT_DECIMALS);
-    address private constant _DATA_HOOK = address(bytes20(keccak256("datahook")));
-
-    IJBController private _controller;
-    IJBTerminal private _terminal;
-    IJBTokens private _tokens;
-    address private _projectOwner;
-
-    uint256 _projectId;
-
-    function setUp() public override {
-        super.setUp();
-
-        _controller = jbController();
-        _projectOwner = multisig();
-        _terminal = jbMultiTerminal();
-        _tokens = jbTokens();
-
-        JBRulesetMetadata memory _metadata = JBRulesetMetadata({
-            reservedPercent: 0,
-            cashOutTaxRate: 0,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: true,
-            allowSetCustomToken: true,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: false,
-            useDataHookForPay: true,
-            useDataHookForCashOut: true,
-            dataHook: _DATA_HOOK,
-            metadata: 0
-        });
-
-        // Package up ruleset configuration.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = 0;
-        _rulesetConfig[0].duration = 0;
-        _rulesetConfig[0].weight = _WEIGHT;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        JBTerminalConfig[] memory _terminalConfigurations = new JBTerminalConfig[](1);
-        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
-        _tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-        _terminalConfigurations[0] =
-            JBTerminalConfig({terminal: _terminal, accountingContextsToAccept: _tokensToAccept});
-
-        _projectId = _controller.launchProjectFor({
-            owner: _projectOwner,
-            projectUri: "myIPFSHash",
-            rulesetConfigurations: _rulesetConfig,
-            terminalConfigurations: _terminalConfigurations,
-            memo: ""
-        });
-    }
-
-    function test_GivenNoRulesetIsActive() external {
-        // deploy a second project without ruleset
-        JBRulesetMetadata memory _metadata = JBRulesetMetadata({
-            reservedPercent: 0,
-            cashOutTaxRate: 0,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: true,
-            allowSetCustomToken: true,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: false,
-            useDataHookForPay: true,
-            useDataHookForCashOut: true,
-            dataHook: _DATA_HOOK,
-            metadata: 0
-        });
-
-        // Package up ruleset configuration that starts in the future.
-        JBRulesetConfig[] memory _rulesetConfig = new JBRulesetConfig[](1);
-        _rulesetConfig[0].mustStartAtOrAfter = uint48(block.timestamp + 100);
-        _rulesetConfig[0].duration = 0;
-        _rulesetConfig[0].weight = _WEIGHT;
-        _rulesetConfig[0].weightCutPercent = 0;
-        _rulesetConfig[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        _rulesetConfig[0].metadata = _metadata;
-        _rulesetConfig[0].splitGroups = new JBSplitGroup[](0);
-        _rulesetConfig[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        JBTerminalConfig[] memory _terminalConfigurations = new JBTerminalConfig[](1);
-
-        JBAccountingContext[] memory _tokensToAccept = new JBAccountingContext[](1);
-        _tokensToAccept[0] = JBAccountingContext({
-            token: JBConstants.NATIVE_TOKEN, decimals: 18, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-        _terminalConfigurations[0] =
-            JBTerminalConfig({terminal: _terminal, accountingContextsToAccept: _tokensToAccept});
-
-        _projectId = _controller.launchProjectFor({
-            owner: _projectOwner,
-            projectUri: "myIPFSHash",
-            rulesetConfigurations: _rulesetConfig,
-            terminalConfigurations: _terminalConfigurations,
-            memo: ""
-        });
-
-        // owner should be able to mint
-        vm.prank(_projectOwner);
-
-        // send: mint some tokens
-        _controller.mintTokensOf(2, 1, address(this), "", false);
-
-        // check: tokens were minted
-        uint256 balance = _tokens.totalBalanceOf(address(this), 2);
-        assertEq(balance, 1);
-    }
-
-    function test_GivenThatADataSourceIsConfigured() external {
-        // it should be able to mint
-        vm.prank(address(_DATA_HOOK));
-
-        // send: mint some tokens
-        _controller.mintTokensOf(1, 1, address(this), "", false);
-
-        // check: tokens were minted
-        uint256 balance = _tokens.totalBalanceOf(address(this), 1);
-        assertEq(balance, 1);
-    }
-
-    function test_GivenThatADataSourceHasPermissionedAnotherContractToMint() external {
-        // it should be able to mint
-
-        // Get the current ruleset.
-        JBRuleset memory _ruleset = jbRulesets().currentOf(1);
-
-        // setup: mock the datasource mint permission, allowing this contract to mint
-        bytes memory _encodedCall =
-            abi.encodeCall(IJBRulesetDataHook.hasMintPermissionFor, (1, _ruleset, address(this)));
-        bytes memory _willReturn = abi.encode(true);
-
-        vm.mockCall(address(_DATA_HOOK), _encodedCall, _willReturn);
-        vm.expectCall(address(_DATA_HOOK), _encodedCall);
-
-        // send: mint some tokens
-        _controller.mintTokensOf(1, 1, address(this), "", false);
-
-        // check: tokens were minted
-        uint256 balance = _tokens.totalBalanceOf(address(this), 1);
-        assertEq(balance, 1);
-    }
-}