@bananapus/721-hook-v6 0.0.41 → 0.0.43

package/USER_JOURNEYS.md

@@ -1,121 +0,0 @@
-# User Journeys
-
-## Repo Purpose
-
-This repo adds tiered NFT logic to Juicebox payment and cash-out flows. It owns tier pricing, reserves, and NFT lifecycle state. It does not own project-specific artwork or game logic.
-
-## Primary Actors
-
-- projects that want priced NFT tiers in their Juicebox flow
-- operators managing tier configuration and hook permissions
-- holders minting, transferring, and cashing out tiered NFTs
-- auditors reviewing tier accounting, reserve behavior, and deployer wiring
-
-## Key Surfaces
-
-- `JB721TiersHook`: runtime 721 hook behavior
-- `JB721TiersHookStore`: tier accounting and supply state
-- `JB721TiersHookDeployer` and `JB721TiersHookProjectDeployer`: wiring surfaces
-- token URI resolver contracts in downstream repos: presentation layer
-
-## Journey 1: Launch A Project With A Tiered NFT Hook
-
-**Actor:** project operator or deployer.
-
-**Intent:** attach tiered NFT issuance to a project from the start.
-
-**Preconditions**
-- the project knows its tier structure and hook expectations
-- the deployer path matches whether the project already exists
-
-**Main Flow**
-1. Deploy a hook clone or launch a project with the hook already attached.
-2. Configure tier data, hook metadata, and resolver expectations.
-3. Transfer hook ownership into the intended project control surface.
-
-**Failure Modes**
-- wrong hook wiring at launch
-- wrong resolver assumptions
-- teams treat deployer convenience as proof that runtime economics are correct
-
-**Postconditions**
-- the project has a tiered NFT hook wired into its Juicebox flow
-
-## Journey 2: Pay And Mint Tiered NFTs
-
-**Actor:** payer or integration acting for a payer.
-
-**Intent:** mint NFTs from configured tiers while preserving the project's terminal flow.
-
-**Preconditions**
-- the project has active tiers
-- payment metadata correctly names the intended tiers
-
-**Main Flow**
-1. A payment reaches the hook through the terminal.
-2. The hook decodes tier selection and records mint state in the store.
-3. NFTs mint, reserve implications update, and any split routing is applied.
-
-**Failure Modes**
-- malformed metadata
-- currency mismatch or missing pricing support
-- splits or discounts behave differently than the integration expected
-
-**Postconditions**
-- the payer or beneficiary receives the intended NFT tiers and tier state updates
-
-## Journey 3: Mint Or Release Reserve NFTs
-
-**Actor:** reserve beneficiary, operator, or any caller using the reserve path.
-
-**Intent:** realize pending reserves under the configured reserve rules.
-
-**Preconditions**
-- the relevant tiers have reserve logic enabled
-- the ruleset does not pause pending reserve minting
-
-**Main Flow**
-1. Eligible reserve amounts accumulate as mint activity happens.
-2. A caller triggers reserve minting for pending tiers.
-3. The store moves reserve state forward and NFTs mint to the configured reserve beneficiary.
-
-**Failure Modes**
-- teams misunderstand that reserve minting timing is not owner-exclusive
-- reserve assumptions drift from actual tier settings
-
-**Postconditions**
-- pending reserves mint according to tier configuration
-
-## Journey 4: Cash Out Tiered NFTs
-
-**Actor:** NFT holder.
-
-**Intent:** redeem tiered NFT exposure through the terminal cash-out path.
-
-**Preconditions**
-- the holder owns valid NFTs
-- the hook is active for the cash-out path
-
-**Main Flow**
-1. The holder requests a cash out with NFT-specific metadata.
-2. The hook burns the selected NFTs and records the burn in the store.
-3. The terminal completes reclaim logic using the hook-aware cash-out surface.
-
-**Failure Modes**
-- integrations mix fungible-token and NFT cash-out assumptions
-- pending reserves or discounts are misunderstood in value calculations
-- token IDs are invalid or already burned
-
-**Postconditions**
-- NFTs burn and reclaim value follows the intended tier model
-
-## Trust Boundaries
-
-- this repo trusts core terminals, directory checks, and pricing surfaces from `nana-core-v6`
-- metadata resolvers are outside this repo but still affect user-visible trust
-- the store is the main source of truth for tier lifecycle state
-
-## Hand-Offs
-
-- Use [nana-core-v6](../nana-core-v6/USER_JOURNEYS.md) for the underlying terminal and accounting behavior.
-- Use the downstream resolver repo when the question is about project-specific metadata or rendering.

package/assets/findings/nana-721-hook-v6-pashov-ai-audit-report-20260330-091257.md

@@ -1,83 +0,0 @@
-# 🔐 Security Review — nana-721-hook-v6
-
----
-
-## Scope
-
-|                                  |                                                        |
-| -------------------------------- | ------------------------------------------------------ |
-| **Mode**                         | ALL / default                                          |
-| **Files reviewed**               | `script/Deploy.s.sol` · `script/helpers/Hook721DeploymentLib.sol` · `src/JB721TiersHook.sol`<br>`src/JB721TiersHookDeployer.sol` · `src/JB721TiersHookProjectDeployer.sol` · `src/JB721TiersHookStore.sol`<br>`src/abstract/ERC721.sol` · `src/abstract/JB721Hook.sol` · `src/libraries/JB721Constants.sol`<br>`src/libraries/JB721TiersHookLib.sol` · `src/libraries/JB721TiersRulesetMetadataResolver.sol` · `src/libraries/JBBitmap.sol`<br>`src/libraries/JBIpfsDecoder.sol` · `src/structs/JB721InitTiersConfig.sol` · `src/structs/JB721Tier.sol`<br>`src/structs/JB721TierConfig.sol` · `src/structs/JB721TiersHookFlags.sol` · `src/structs/JB721TiersMintReservesConfig.sol`<br>`src/structs/JB721TiersRulesetMetadata.sol` · `src/structs/JB721TiersSetDiscountPercentConfig.sol` · `src/structs/JBBitmapWord.sol`<br>`src/structs/JBDeploy721TiersHookConfig.sol` · `src/structs/JBLaunchProjectConfig.sol` · `src/structs/JBLaunchRulesetsConfig.sol`<br>`src/structs/JBPayDataHookRulesetConfig.sol` · `src/structs/JBPayDataHookRulesetMetadata.sol` · `src/structs/JBQueueRulesetsConfig.sol`<br>`src/structs/JBStored721Tier.sol` | 
-| **Confidence threshold (1-100)** | 75                                                     |
-
----
-
-## Findings
-
-[90] **1. Pay Credits Let Buyers Bypass Tier Split Payments**
-
-`JB721TiersHook._mintAndUpdateCredits` · Confidence: 90
-
-**Description**
-`payCreditsOf` is merged into NFT purchasing power, but tier split payouts are still capped to `context.forwardedAmount.value`, so a buyer can mint a split-bearing tier mostly with credits while paying only a dust-sized fresh split.
-
-**Fix**
-
-```diff
-- leftoverAmount += payCredits;
-- if (context.hookMetadata.length != 0 && context.forwardedAmount.value != 0) {
--     JB721TiersHookLib.distributeAll(... amount: context.forwardedAmount.value, ...);
-- }
-+ uint256 creditBackedAmount = context.payer == context.beneficiary ? payCredits : 0;
-+ uint256 splitFundingAmount = context.forwardedAmount.value + creditBackedAmountUsedForMint;
-+ if (context.hookMetadata.length != 0 && splitFundingAmount != 0) {
-+     JB721TiersHookLib.distributeAll(... amount: splitFundingAmount, ...);
-+ }
-```
----
-
-[90] **2. Failed Early Splits Are Redistributed to Later Recipients**
-
-`JB721TiersHookLib._distributeSingleSplit` · Confidence: 90
-
-**Description**
-When an early split payout fails, its amount is added back into `leftoverAmount` before later splits are calculated, so later recipients can receive the failed recipient’s share instead of that value falling back to project balance.
-
-**Fix**
-
-```diff
-- if (!_sendPayoutToSplit(...)) {
--     leftoverAmount += payoutAmount;
-- }
-+ if (!_sendPayoutToSplit(...)) {
-+     failedAmount += payoutAmount;
-+ }
-...
-- if (leftoverAmount != 0) {
--     terminal.addToBalanceOf(... leftoverAmount ...);
-+ uint256 amountToProject = leftoverAmount + failedAmount;
-+ if (amountToProject != 0) {
-+     terminal.addToBalanceOf(... amountToProject ...);
-```
-
----
-
-Findings List
-
-| # | Confidence | Title |
-|---|---|---|
-| 1 | [90] | Pay Credits Let Buyers Bypass Tier Split Payments |
-| 2 | [90] | Failed Early Splits Are Redistributed to Later Recipients |
-
----
-
-## Leads
-
-_Vulnerability trails with concrete code smells where the full exploit path could not be completed in one analysis pass. These are not false positives — they are high-signal leads for manual review. Not scored._
-
-- **Public Address Registry Can Grief Hook Deployments** — `JB721TiersHookDeployer.deployHookFor` — Code smells: deployment success depends on `JBAddressRegistry.registerAddress`, and the registry is permissionless plus duplicate-registration-reverting — A third party can likely pre-register a predicted hook address and make `deployHookFor` revert at the registry step, but the practical griefing envelope depends on deployment mode and the caller’s ability to retry with a different salt.
-- **Shared `_nonce` Can Desync Registry Provenance After Mixed CREATE/CREATE2 Deployments** — `JB721TiersHookDeployer.deployHookFor` — Code smells: `_nonce` is incremented for both deterministic and non-deterministic deployments, while only the CREATE path consumes the deployer nonce the registry models — Mixed deployment modes may cause later saltless registrations to point at the wrong CREATE address, but I did not complete an end-to-end exploit showing downstream trust assumptions being violated.
-
----
-
-> ⚠️ This review was performed by an AI assistant. AI analysis can never verify the complete absence of vulnerabilities and no guarantee of security is given. Team security reviews, bug bounty programs, and on-chain monitoring are strongly recommended. For a consultation regarding your projects' security, visit [https://www.pashov.com](https://www.pashov.com)

package/slither-ci.config.json

@@ -1,10 +0,0 @@
-{
-  "detectors_to_exclude": "timestamp,uninitialized-local,naming-convention,solc-version,shadowing-local",
-  "exclude_informational": true,
-  "exclude_low": false,
-  "exclude_medium": false,
-  "exclude_high": false,
-  "disable_color": false,
-  "filter_paths": "(mocks/|test/|node_modules/|lib/)",
-  "legacy_ast": false
-}

package/test/721HookAttacks.t.sol

@@ -1,408 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "./utils/UnitTestSetup.sol";
-import {JB721TierConfigFlags} from "../src/structs/JB721TierConfigFlags.sol";
-
-/// @title 721HookAttacks
-/// @notice Adversarial security tests for JB721TiersHook and JB721TiersHookStore.
-contract NFTHookAttacks is UnitTestSetup {
-    using stdStorage for StdStorage;
-
-    // =========================================================================
-    // Helpers
-    // =========================================================================
-
-    /// @dev Mock the directory to accept `mockTerminalAddress` as a terminal for `projectId`.
-    function _mockTerminalAuth() internal {
-        mockAndExpect(
-            mockJBDirectory,
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-    }
-
-    /// @dev Create a pay context that requests minting specific tier IDs.
-    function _buildPayContext(
-        address targetHook,
-        uint256 value,
-        uint16[] memory tierIds
-    )
-        internal
-        view
-        returns (JBAfterPayRecordedContext memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(false, tierIds);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", targetHook);
-        bytes memory hookMetadata = metadataHelper.createMetadata(ids, data);
-
-        return JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: value,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            forwardedAmount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 0,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            weight: 10 ** 18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: bytes(""),
-            payerMetadata: hookMetadata
-        });
-    }
-
-    // =========================================================================
-    // Test 1: Zero-price tier — can an attacker mint for free?
-    // =========================================================================
-    /// @notice Add a tier with price=0 via adjustTiers. Verify the hook handles it correctly.
-    function test_zeroPriceTier_mintBehavior() public {
-        // Create hook with 1 default tier (price=10).
-        ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
-
-        // Add a zero-price tier via adjustTiers (tier ID 2).
-        JB721TierConfig[] memory newTiers = new JB721TierConfig[](1);
-        newTiers[0] = JB721TierConfig({
-            price: 0,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: reserveBeneficiary,
-            encodedIPFSUri: tokenUris[0],
-            category: 2,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        targetHook.adjustTiers(newTiers, new uint256[](0));
-
-        _mockTerminalAuth();
-
-        // Try to mint tier 2 (price=0) with 0 value.
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 2;
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 0, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        targetHook.afterPayRecordedWith(ctx);
-
-        // Verify the NFT was minted to the beneficiary.
-        assertEq(targetHook.balanceOf(beneficiary), 1, "Should mint 1 NFT at price 0");
-    }
-
-    // =========================================================================
-    // Test 2: Discount percent at maximum — effective price becomes 0
-    // =========================================================================
-    /// @notice Set discount to 100%, verify the effective price for the tier.
-    function test_maxDiscountPercent_effectivePrice() public {
-        defaultTierConfig.discountPercent = 0;
-        defaultTierConfig.flags.cantIncreaseDiscountPercent = false;
-
-        JB721TiersHook targetHook = _initHookDefaultTiers(1);
-
-        // Owner sets discount to 100%.
-        vm.mockCall(mockJBPermissions, abi.encodeWithSelector(IJBPermissions.hasPermission.selector), abi.encode(true));
-
-        vm.prank(owner);
-        targetHook.setDiscountPercentOf(1, 100);
-
-        // Read the tier and verify the discount was applied.
-        JB721Tier memory tier = store.tierOf(address(targetHook), 1, false);
-        assertEq(tier.discountPercent, 100, "Discount should be 100%");
-    }
-
-    // =========================================================================
-    // Test 3: cantIncreaseDiscountPercent flag enforcement
-    // =========================================================================
-    /// @notice Try to increase discount when the flag forbids it.
-    function test_cantIncreaseDiscountPercent_enforcement() public {
-        defaultTierConfig.discountPercent = 10;
-        defaultTierConfig.flags.cantIncreaseDiscountPercent = true;
-
-        JB721TiersHook targetHook = _initHookDefaultTiers(1);
-
-        vm.mockCall(mockJBPermissions, abi.encodeWithSelector(IJBPermissions.hasPermission.selector), abi.encode(true));
-
-        // Try to increase discount from 10 to 50 — should revert.
-        vm.prank(owner);
-        vm.expectRevert();
-        targetHook.setDiscountPercentOf(1, 50);
-
-        // Decreasing should still work.
-        vm.prank(owner);
-        targetHook.setDiscountPercentOf(1, 5);
-
-        JB721Tier memory tier = store.tierOf(address(targetHook), 1, false);
-        assertEq(tier.discountPercent, 5, "Discount decrease should work");
-    }
-
-    // =========================================================================
-    // Test 4: Reserve minting drain — high reserve frequency
-    // =========================================================================
-    /// @notice With reserveFrequency=1 (reserve on every mint), mint 5 paid NFTs
-    ///         then call mintPendingReservesFor to drain reserves.
-    function test_reserveDrain_highFrequency() public {
-        defaultTierConfig.initialSupply = 100;
-        defaultTierConfig.reserveFrequency = 1; // Reserve 1 per 1 paid mint.
-
-        ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
-        IJB721TiersHookStore hookStore = targetHook.STORE();
-
-        _mockTerminalAuth();
-
-        // Mint 5 paid NFTs from tier 1 (price=10 each, so value=50).
-        uint16[] memory tierIds = new uint16[](5);
-        for (uint256 i; i < 5; i++) {
-            tierIds[i] = 1;
-        }
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 50, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        targetHook.afterPayRecordedWith(ctx);
-
-        assertEq(targetHook.balanceOf(beneficiary), 5, "5 paid NFTs minted");
-
-        // Pending reserves should be 5 (1 per paid mint with frequency=1).
-        // With frequency=1: reserveCount = nftsMinted / frequency = 5, plus 1 if remainder > 0.
-        // 5/1 = 5, remainder 0, so pending = 5+1 = 6? Actually the formula is:
-        // numberOfPendingReservesFor = (numberOfMints + frequency - 1) / frequency - processedReserves
-        // Let's just check what the store reports.
-        uint256 pending = hookStore.numberOfPendingReservesFor(address(targetHook), 1);
-        assertTrue(pending > 0, "Should have pending reserves");
-
-        // Mint all pending reserves.
-        vm.prank(owner);
-        targetHook.mintPendingReservesFor(1, pending);
-
-        // After minting, pending should be 0.
-        uint256 pendingAfter = hookStore.numberOfPendingReservesFor(address(targetHook), 1);
-        assertEq(pendingAfter, 0, "No pending reserves after minting");
-
-        // Try to mint more reserves — should revert (nothing pending).
-        vm.prank(owner);
-        vm.expectRevert();
-        targetHook.mintPendingReservesFor(1, 1);
-    }
-
-    // =========================================================================
-    // Test 5: Cash-out weight after tier removal
-    // =========================================================================
-    /// @notice Mint NFTs from a tier, then remove the tier. Verify that
-    ///         totalCashOutWeight still accounts for the minted tokens.
-    function test_cashOutWeight_afterTierRemoval() public {
-        defaultTierConfig.initialSupply = 100;
-        defaultTierConfig.votingUnits = 10;
-        defaultTierConfig.flags.useVotingUnits = true;
-
-        ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
-        IJB721TiersHookStore hookStore = targetHook.STORE();
-
-        _mockTerminalAuth();
-
-        // Mint 3 NFTs from tier 1 (price=10 each, value=30).
-        uint16[] memory tierIds = new uint16[](3);
-        tierIds[0] = 1;
-        tierIds[1] = 1;
-        tierIds[2] = 1;
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 30, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        targetHook.afterPayRecordedWith(ctx);
-
-        assertEq(targetHook.balanceOf(beneficiary), 3, "3 NFTs minted");
-
-        // Get total cash-out weight before removal (from the store).
-        uint256 weightBefore = hookStore.totalCashOutWeight(address(targetHook));
-
-        // Remove tier 1.
-        vm.mockCall(mockJBPermissions, abi.encodeWithSelector(IJBPermissions.hasPermission.selector), abi.encode(true));
-
-        uint256[] memory tierIdsToRemove = new uint256[](1);
-        tierIdsToRemove[0] = 1;
-
-        vm.prank(owner);
-        targetHook.adjustTiers(new JB721TierConfig[](0), tierIdsToRemove);
-
-        // Verify the tier is removed.
-        assertTrue(hookStore.isTierRemoved(address(targetHook), 1), "Tier should be removed");
-
-        // Total cash-out weight should still include the minted tokens.
-        uint256 weightAfter = hookStore.totalCashOutWeight(address(targetHook));
-        assertEq(weightAfter, weightBefore, "Cash-out weight should be preserved after removal");
-    }
-
-    // =========================================================================
-    // Test 6: Invalid tier ID in pay metadata — reverts when overspending prevented
-    // =========================================================================
-    /// @notice Pass a tier ID that doesn't exist. With preventOverspending=true, must revert.
-    function test_invalidTierIdInMetadata_reverts() public {
-        // Use preventOverspending=true so invalid tiers cause a revert.
-        JB721TiersHook targetHook = _initHookDefaultTiers(1, true);
-
-        _mockTerminalAuth();
-
-        // Try to mint tier 999 which doesn't exist.
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 999;
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 1 ether, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        vm.expectRevert();
-        targetHook.afterPayRecordedWith(ctx);
-    }
-
-    // =========================================================================
-    // Test 7: Duplicate tier IDs in pay metadata — mints multiple NFTs
-    // =========================================================================
-    /// @notice Pass the same tier ID multiple times. Should mint multiple NFTs
-    ///         from that tier.
-    function test_duplicateTierIdsInMetadata_mintsMultiple() public {
-        defaultTierConfig.initialSupply = 100;
-
-        ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
-        IJB721TiersHookStore hookStore = targetHook.STORE();
-
-        _mockTerminalAuth();
-
-        // Mint 3 of the same tier (price=10 each, value=30).
-        uint16[] memory tierIds = new uint16[](3);
-        tierIds[0] = 1;
-        tierIds[1] = 1;
-        tierIds[2] = 1;
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 30, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        targetHook.afterPayRecordedWith(ctx);
-
-        assertEq(targetHook.balanceOf(beneficiary), 3, "3 NFTs minted from same tier");
-
-        // Verify remaining supply decreased.
-        JB721Tier memory tier = hookStore.tierOf(address(targetHook), 1, false);
-        assertEq(tier.remainingSupply, 97, "Supply should decrease by 3");
-    }
-
-    // =========================================================================
-    // Test 8: Supply exhaustion — no additional NFTs minted after supply drained
-    // =========================================================================
-    /// @notice Mint the entire supply of a tier, then verify no more can be minted.
-    function test_supplyExhaustion_noOvermint() public {
-        defaultTierConfig.initialSupply = 3; // Only 3 available.
-        defaultTierConfig.reserveFrequency = 0; // No reserves to keep it simple.
-
-        ForTest_JB721TiersHook targetHook = _initializeForTestHook(1);
-        IJB721TiersHookStore hookStore = targetHook.STORE();
-
-        _mockTerminalAuth();
-
-        // Mint all 3 (price=10 each, value=30).
-        uint16[] memory tierIds = new uint16[](3);
-        tierIds[0] = 1;
-        tierIds[1] = 1;
-        tierIds[2] = 1;
-
-        JBAfterPayRecordedContext memory ctx = _buildPayContext(address(targetHook), 30, tierIds);
-
-        vm.prank(mockTerminalAddress);
-        targetHook.afterPayRecordedWith(ctx);
-
-        assertEq(targetHook.balanceOf(beneficiary), 3, "All 3 minted");
-
-        // Verify supply is exhausted.
-        JB721Tier memory tier = hookStore.tierOf(address(targetHook), 1, false);
-        assertEq(tier.remainingSupply, 0, "No remaining supply");
-
-        // Try to mint one more — store enforces supply limit and reverts.
-        uint16[] memory oneMore = new uint16[](1);
-        oneMore[0] = 1;
-
-        JBAfterPayRecordedContext memory ctx2 = _buildPayContext(address(targetHook), 10, oneMore);
-
-        vm.prank(mockTerminalAddress);
-        vm.expectRevert();
-        targetHook.afterPayRecordedWith(ctx2);
-    }
-
-    // =========================================================================
-    // Test 9: adjustTiers without permission — must revert
-    // =========================================================================
-    /// @notice Non-owner without ADJUST_721_TIERS permission tries to add/remove tiers.
-    function test_adjustTiers_noPermission_reverts() public {
-        JB721TiersHook targetHook = _initHookDefaultTiers(1);
-
-        // Mock permissions to return false.
-        vm.mockCall(mockJBPermissions, abi.encodeWithSelector(IJBPermissions.hasPermission.selector), abi.encode(false));
-
-        address attacker = makeAddr("attacker");
-
-        // Try to add a new tier.
-        JB721TierConfig[] memory newTiers = new JB721TierConfig[](1);
-        newTiers[0] = JB721TierConfig({
-            price: 1,
-            initialSupply: type(uint32).max,
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: attacker,
-            encodedIPFSUri: tokenUris[0],
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: true,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(attacker);
-        vm.expectRevert();
-        targetHook.adjustTiers(newTiers, new uint256[](0));
-    }
-
-    // =========================================================================
-    // Test 10: Tier with max supply — verify no overflow
-    // =========================================================================
-    /// @notice Add a tier with initialSupply = 999_999_999 (store maximum).
-    ///         Verify it's created correctly and doesn't overflow.
-    function test_maxSupplyTier_noOverflow() public {
-        defaultTierConfig.initialSupply = 999_999_999; // Store maximum
-
-        JB721TiersHook targetHook = _initHookDefaultTiers(1);
-
-        // Read the tier to verify the supply was stored correctly.
-        JB721Tier memory tier = store.tierOf(address(targetHook), 1, false);
-        assertEq(tier.initialSupply, 999_999_999, "Initial supply should be 999_999_999");
-        assertEq(tier.remainingSupply, 999_999_999, "Remaining supply should be 999_999_999");
-    }
-}