@bananapus/721-hook-v6 0.0.41 → 0.0.43

package/test/audit/ProjectDeployerAuth.t.sol

@@ -1,266 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import "../utils/UnitTestSetup.sol";
-
-import {JB721TiersHookProjectDeployer} from "../../src/JB721TiersHookProjectDeployer.sol";
-import {JBDeploy721TiersHookConfig} from "../../src/structs/JBDeploy721TiersHookConfig.sol";
-import {JBLaunchRulesetsConfig} from "../../src/structs/JBLaunchRulesetsConfig.sol";
-import {JBQueueRulesetsConfig} from "../../src/structs/JBQueueRulesetsConfig.sol";
-import {JBPayDataHookRulesetConfig} from "../../src/structs/JBPayDataHookRulesetConfig.sol";
-import {JBPayDataHookRulesetMetadata} from "../../src/structs/JBPayDataHookRulesetMetadata.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-import {JB721InitTiersConfig} from "../../src/structs/JB721InitTiersConfig.sol";
-import {JB721TiersHookFlags} from "../../src/structs/JB721TiersHookFlags.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";
-import {IJBController} from "@bananapus/core-v6/src/interfaces/IJBController.sol";
-import {IJBRulesetApprovalHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBTerminal} from "@bananapus/core-v6/src/interfaces/IJBTerminal.sol";
-import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
-import {JBConstants} from "@bananapus/core-v6/src/libraries/JBConstants.sol";
-import {JBAccountingContext} from "@bananapus/core-v6/src/structs/JBAccountingContext.sol";
-import {JBTerminalConfig} from "@bananapus/core-v6/src/structs/JBTerminalConfig.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-contract MockProjects {
-    uint256 internal _count;
-    address internal _owner;
-
-    function setup(uint256 count_, address owner_) external {
-        _count = count_;
-        _owner = owner_;
-    }
-
-    function count() external view returns (uint256) {
-        return _count;
-    }
-
-    function ownerOf(uint256) external view returns (address) {
-        return _owner;
-    }
-
-    fallback() external {}
-}
-
-contract StrictController {
-    address internal immutable EXPECTED_CALLER;
-
-    error UnexpectedCaller(address caller);
-
-    constructor(address expectedCaller) {
-        EXPECTED_CALLER = expectedCaller;
-    }
-
-    fallback() external payable {
-        if (msg.sender != EXPECTED_CALLER) revert UnexpectedCaller(msg.sender);
-        bytes memory result = abi.encode(uint256(42));
-        assembly {
-            return(add(result, 32), mload(result))
-        }
-    }
-}
-
-contract Test_ProjectDeployerAuth is UnitTestSetup {
-    JB721TiersHookProjectDeployer internal projectDeployer;
-    address internal operator = address(0xBEEF);
-    uint256 internal testProjectId = 5;
-
-    function setUp() public override {
-        super.setUp();
-
-        MockProjects projects = new MockProjects();
-        vm.etch(mockJBProjects, address(projects).code);
-        MockProjects(mockJBProjects).setup(testProjectId, owner);
-
-        vm.mockCall(mockJBDirectory, abi.encodeWithSelector(IJBDirectory.PROJECTS.selector), abi.encode(mockJBProjects));
-
-        projectDeployer = new JB721TiersHookProjectDeployer(
-            IJBDirectory(mockJBDirectory), IJBPermissions(mockJBPermissions), jbHookDeployer, address(0)
-        );
-    }
-
-    function test_launchRulesetsFor_revertsBecauseControllerSeesProjectDeployerAsCaller() external {
-        (JBDeploy721TiersHookConfig memory hookConfig, JBLaunchRulesetsConfig memory launchConfig) =
-            _launchConfig(testProjectId);
-
-        StrictController controller = new StrictController(owner);
-
-        vm.prank(owner);
-        vm.expectRevert(abi.encodeWithSelector(StrictController.UnexpectedCaller.selector, address(projectDeployer)));
-        projectDeployer.launchRulesetsFor(
-            testProjectId, hookConfig, launchConfig, IJBController(address(controller)), bytes32(0)
-        );
-    }
-
-    function test_queueRulesetsOf_revertsBecauseControllerSeesProjectDeployerAsCaller() external {
-        (JBDeploy721TiersHookConfig memory hookConfig, JBQueueRulesetsConfig memory queueConfig) =
-            _queueConfig(testProjectId);
-
-        StrictController controller = new StrictController(owner);
-
-        vm.prank(owner);
-        vm.expectRevert(abi.encodeWithSelector(StrictController.UnexpectedCaller.selector, address(projectDeployer)));
-        projectDeployer.queueRulesetsOf(
-            testProjectId, hookConfig, queueConfig, IJBController(address(controller)), bytes32(0)
-        );
-    }
-
-    function test_launchRulesetsFor_checksLaunchPermission() external {
-        (JBDeploy721TiersHookConfig memory hookConfig, JBLaunchRulesetsConfig memory launchConfig) =
-            _launchConfig(testProjectId);
-
-        address account = owner;
-        StrictController controller = new StrictController(owner);
-
-        // Grant LAUNCH_RULESETS and SET_TERMINALS, deny QUEUE_RULESETS.
-        vm.mockCall(
-            mockJBPermissions,
-            abi.encodeWithSelector(
-                IJBPermissions.hasPermission.selector,
-                operator,
-                account,
-                testProjectId,
-                JBPermissionIds.QUEUE_RULESETS,
-                true,
-                true
-            ),
-            abi.encode(false)
-        );
-        vm.mockCall(
-            mockJBPermissions,
-            abi.encodeWithSelector(
-                IJBPermissions.hasPermission.selector,
-                operator,
-                account,
-                testProjectId,
-                JBPermissionIds.LAUNCH_RULESETS,
-                true,
-                true
-            ),
-            abi.encode(true)
-        );
-        vm.mockCall(
-            mockJBPermissions,
-            abi.encodeWithSelector(
-                IJBPermissions.hasPermission.selector,
-                operator,
-                account,
-                testProjectId,
-                JBPermissionIds.SET_TERMINALS,
-                true,
-                true
-            ),
-            abi.encode(true)
-        );
-
-        // The permission check passes with LAUNCH_RULESETS. The call proceeds to the controller, which reverts
-        // because it sees the deployer contract as the caller rather than the original operator.
-        vm.prank(operator);
-        vm.expectRevert(abi.encodeWithSelector(StrictController.UnexpectedCaller.selector, address(projectDeployer)));
-        projectDeployer.launchRulesetsFor(
-            testProjectId, hookConfig, launchConfig, IJBController(address(controller)), bytes32(0)
-        );
-    }
-
-    function _launchConfig(uint256 projectId_)
-        internal
-        view
-        returns (JBDeploy721TiersHookConfig memory hookConfig, JBLaunchRulesetsConfig memory launchConfig)
-    {
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = JB721TierConfig({
-            price: uint104(10),
-            initialSupply: uint32(100),
-            votingUnits: uint16(0),
-            reserveFrequency: uint16(0),
-            reserveBeneficiary: reserveBeneficiary,
-            encodedIPFSUri: tokenUris[0],
-            category: uint24(1),
-            discountPercent: uint8(0),
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        hookConfig = JBDeploy721TiersHookConfig({
-            name: name,
-            symbol: symbol,
-            baseUri: baseUri,
-            tokenUriResolver: IJB721TokenUriResolver(address(0)),
-            contractUri: contractUri,
-            tiersConfig: JB721InitTiersConfig({
-                tiers: tierConfigs, currency: uint32(uint160(JBConstants.NATIVE_TOKEN)), decimals: 18
-            }),
-            flags: JB721TiersHookFlags({
-                preventOverspending: false,
-                issueTokensForSplits: false,
-                noNewTiersWithReserves: true,
-                noNewTiersWithVotes: false,
-                noNewTiersWithOwnerMinting: true
-            })
-        });
-
-        JBPayDataHookRulesetConfig[] memory rulesetConfigs = new JBPayDataHookRulesetConfig[](1);
-        rulesetConfigs[0].mustStartAtOrAfter = 0;
-        rulesetConfigs[0].duration = 14;
-        rulesetConfigs[0].weight = 1e18;
-        rulesetConfigs[0].weightCutPercent = 0;
-        rulesetConfigs[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        rulesetConfigs[0].metadata = JBPayDataHookRulesetMetadata({
-            reservedPercent: 5000,
-            cashOutTaxRate: 5000,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            allowSetController: false,
-            ownerMustSendPayouts: false,
-            allowAddAccountingContext: false,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: false,
-            useDataHookForCashOut: false,
-            metadata: 0x00
-        });
-
-        JBAccountingContext[] memory accountingContexts = new JBAccountingContext[](1);
-        accountingContexts[0] = JBAccountingContext({
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN)), decimals: 18, token: JBConstants.NATIVE_TOKEN
-        });
-        JBTerminalConfig[] memory terminalConfigs = new JBTerminalConfig[](1);
-        terminalConfigs[0] = JBTerminalConfig({
-            terminal: IJBTerminal(mockTerminalAddress), accountingContextsToAccept: accountingContexts
-        });
-
-        launchConfig = JBLaunchRulesetsConfig({
-            projectId: uint56(projectId_),
-            rulesetConfigurations: rulesetConfigs,
-            terminalConfigurations: terminalConfigs,
-            memo: "launch"
-        });
-    }
-
-    function _queueConfig(uint256 projectId_)
-        internal
-        view
-        returns (JBDeploy721TiersHookConfig memory hookConfig, JBQueueRulesetsConfig memory queueConfig)
-    {
-        JBLaunchRulesetsConfig memory launchConfig;
-        (hookConfig, launchConfig) = _launchConfig(projectId_);
-        queueConfig = JBQueueRulesetsConfig({
-            projectId: uint56(projectId_), rulesetConfigurations: launchConfig.rulesetConfigurations, memo: "queue"
-        });
-    }
-}

package/test/audit/RepoFindings.t.sol

@@ -1,195 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import "../utils/UnitTestSetup.sol";
-
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-contract RepoFindings is UnitTestSetup {
-    address payable internal splitBeneficiary = payable(makeAddr("splitBeneficiary"));
-
-    function _payMetadata(
-        address hookAddress,
-        bool allowOverspending,
-        uint16[] memory tierIds
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(allowOverspending, tierIds);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-        return metadataHelper.createMetadata(ids, data);
-    }
-
-    function _nativeTokenAmount(uint256 value) internal pure returns (JBTokenAmount memory) {
-        return JBTokenAmount({
-            token: JBConstants.NATIVE_TOKEN,
-            value: value,
-            decimals: 18,
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-    }
-
-    function test_payCredits_can_underfund_split_bearing_tier_mints() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        vm.mockCall(mockJBSplits, abi.encodeWithSelector(IJBSplits.setSplitGroupsOf.selector), abi.encode());
-
-        JBSplit[] memory tierSplits = new JBSplit[](1);
-        tierSplits[0] = JBSplit({
-            preferAddToBalance: false,
-            percent: JBConstants.SPLITS_TOTAL_PERCENT,
-            projectId: 0,
-            beneficiary: splitBeneficiary,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 10,
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: JBConstants.SPLITS_TOTAL_PERCENT,
-            splits: tierSplits
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tierConfigs, new uint256[](0));
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(1) << 160);
-        vm.mockCall(
-            mockJBSplits,
-            abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, uint256(0), groupId),
-            abi.encode(tierSplits)
-        );
-
-        mockAndExpect(
-            mockJBDirectory,
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(
-            JBAfterPayRecordedContext({
-                payer: beneficiary,
-                projectId: projectId,
-                rulesetId: 0,
-                amount: _nativeTokenAmount(1 ether),
-                forwardedAmount: _nativeTokenAmount(0),
-                weight: 10e18,
-                newlyIssuedTokenCount: 0,
-                beneficiary: beneficiary,
-                hookMetadata: bytes(""),
-                payerMetadata: bytes("")
-            })
-        );
-
-        assertEq(testHook.payCreditsOf(beneficiary), 1 ether, "setup: credits should be seeded");
-
-        uint16[] memory tierIdsToMint = new uint16[](1);
-        tierIdsToMint[0] = 1;
-        bytes memory payerMetadata = _payMetadata(address(testHook), true, tierIdsToMint);
-
-        JBBeforePayRecordedContext memory beforeContext = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: _nativeTokenAmount(1),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(beforeContext);
-
-        assertEq(weight, 0, "only the fresh 1 wei payment is considered for split weight adjustment");
-        assertEq(specs.length, 1);
-        assertEq(specs[0].amount, 1, "split forwarding is capped to the fresh payment, not the credit-backed mint");
-
-        uint256 splitBeneficiaryBalanceBefore = splitBeneficiary.balance;
-        vm.deal(mockTerminalAddress, 1);
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith{value: 1}(
-            JBAfterPayRecordedContext({
-                payer: beneficiary,
-                projectId: projectId,
-                rulesetId: 0,
-                amount: _nativeTokenAmount(1),
-                forwardedAmount: _nativeTokenAmount(1),
-                weight: weight,
-                newlyIssuedTokenCount: 0,
-                beneficiary: beneficiary,
-                hookMetadata: specs[0].metadata,
-                payerMetadata: payerMetadata
-            })
-        );
-
-        assertEq(testHook.balanceOf(beneficiary), 1, "beneficiary still receives the split-bearing NFT");
-        assertEq(testHook.payCreditsOf(beneficiary), 1, "stored credits fund essentially the entire mint");
-        assertEq(
-            splitBeneficiary.balance - splitBeneficiaryBalanceBefore,
-            1,
-            "split beneficiary only receives the fresh 1 wei payment instead of the tier's 1 ether split amount"
-        );
-    }
-
-    /// @notice Creating a tier with reserveFrequency > 0 and no beneficiary (tier-specific or default)
-    /// is now rejected at creation time, preventing the retroactive dilution bug.
-    function test_new_default_reserve_beneficiary_retroactively_dilutes_existing_tiers() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory initialTier = new JB721TierConfig[](1);
-        initialTier[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 10,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x1111)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        // The new creation-time check prevents tiers with reserves but no beneficiary.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        vm.prank(owner);
-        testHook.adjustTiers(initialTier, new uint256[](0));
-    }
-}

package/test/audit/ReserveActivation.t.sol

@@ -1,87 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JB721Tier} from "../../src/structs/JB721Tier.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-
-contract Test_ReserveActivation is Test {
-    JB721TiersHookStore internal store;
-
-    function setUp() external {
-        store = new JB721TiersHookStore();
-    }
-
-    /// @notice Creating a tier with reserveFrequency > 0 and no beneficiary (tier-specific or default)
-    /// is now rejected at creation time. This prevents the phantom-reserves scenario entirely.
-    function test_soldOutTier_noPhantomReserves_afterDefaultBeneficiaryChange() external {
-        // Attempt to add a tier with reserve frequency but no beneficiary — should revert.
-        JB721TierConfig[] memory initialTiers = new JB721TierConfig[](1);
-        initialTiers[0] = _tier({
-            price: 1,
-            initialSupply: 10,
-            reserveFrequency: 2,
-            reserveBeneficiary: address(0),
-            useReserveBeneficiaryAsDefault: false,
-            category: 1
-        });
-
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        store.recordAddTiers(initialTiers);
-    }
-
-    /// @notice Creating a tier with reserveFrequency > 0 and no beneficiary (tier-specific or default)
-    /// is now rejected at creation time. This prevents the retroactive reserve activation scenario entirely.
-    function test_nonSoldOutTier_reservesStillWork_afterDefaultBeneficiaryChange() external {
-        // Attempt to add a tier with reserve frequency but no beneficiary — should revert.
-        JB721TierConfig[] memory initialTiers = new JB721TierConfig[](1);
-        initialTiers[0] = _tier({
-            price: 1,
-            initialSupply: 100,
-            reserveFrequency: 5,
-            reserveBeneficiary: address(0),
-            useReserveBeneficiaryAsDefault: false,
-            category: 1
-        });
-
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        store.recordAddTiers(initialTiers);
-    }
-
-    function _tier(
-        uint104 price,
-        uint32 initialSupply,
-        uint16 reserveFrequency,
-        address reserveBeneficiary,
-        bool useReserveBeneficiaryAsDefault,
-        uint24 category
-    )
-        internal
-        pure
-        returns (JB721TierConfig memory tier)
-    {
-        tier.price = price;
-        tier.initialSupply = initialSupply;
-        tier.reserveFrequency = reserveFrequency;
-        tier.reserveBeneficiary = reserveBeneficiary;
-        tier.category = category;
-        tier.flags = JB721TierConfigFlags({
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: useReserveBeneficiaryAsDefault,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false
-        });
-        tier.splits = new JBSplit[](0);
-    }
-}

package/test/audit/RetroactiveReserveBeneficiaryDilution.t.sol

@@ -1,149 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {JBAfterPayRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterPayRecordedContext.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-
-contract RetroactiveReserveBeneficiaryDilution is UnitTestSetup {
-    /// @notice Creating a tier with reserveFrequency > 0 but no beneficiary (tier-specific or default) now reverts,
-    /// preventing the phantom reserve scenario where a later default beneficiary retroactively inflates
-    /// totalCashOutWeight and dilutes existing holders.
-    function test_adjustTier_reverts_when_reserve_has_no_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory tier1 = new JB721TierConfig[](1);
-        tier1[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        testHook.adjustTiers(tier1, new uint256[](0));
-    }
-
-    /// @notice A tier with reserveFrequency > 0 succeeds when an explicit beneficiary is provided.
-    function test_adjustTier_succeeds_with_explicit_reserve_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory tier1 = new JB721TierConfig[](1);
-        tier1[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: owner,
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tier1, new uint256[](0));
-
-        assertEq(
-            testHook.STORE().reserveBeneficiaryOf(address(testHook), 1),
-            owner,
-            "tier-specific beneficiary should be set"
-        );
-    }
-
-    /// @notice A tier with reserveFrequency > 0 and no explicit beneficiary succeeds when a default beneficiary
-    /// was previously set by an earlier tier.
-    function test_adjustTier_succeeds_with_default_reserve_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        // Add two tiers: first sets the default beneficiary, second relies on it.
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](2);
-
-        // Tier 1: sets default beneficiary via useReserveBeneficiaryAsDefault.
-        tiers[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: owner,
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: true,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        // Tier 2: relies on the default beneficiary (no explicit one).
-        tiers[1] = JB721TierConfig({
-            price: 2 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 3,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x5678)),
-            category: 2,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tiers, new uint256[](0));
-
-        // Tier 2 should inherit the default beneficiary set by tier 1.
-        assertEq(
-            testHook.STORE().reserveBeneficiaryOf(address(testHook), 2),
-            owner,
-            "tier 2 should inherit default beneficiary"
-        );
-    }
-}