@bananapus/721-hook-v6 0.0.41 → 0.0.43

package/test/audit/FreshAudit.t.sol

@@ -1,197 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {UnitTestSetup} from "../utils/UnitTestSetup.sol";
-import {ForTest_JB721TiersHook} from "../utils/ForTest_JB721TiersHook.sol";
-import {IJB721TiersHookStore} from "../../src/interfaces/IJB721TiersHookStore.sol";
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-import {JBBeforePayRecordedContext} from "@bananapus/core-v6/src/structs/JBBeforePayRecordedContext.sol";
-import {JBAfterPayRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterPayRecordedContext.sol";
-import {JBPayHookSpecification} from "@bananapus/core-v6/src/structs/JBPayHookSpecification.sol";
-import {JBTokenAmount} from "@bananapus/core-v6/src/structs/JBTokenAmount.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-import {IJBSplitHook} from "@bananapus/core-v6/src/interfaces/IJBSplitHook.sol";
-import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {JBConstants} from "@bananapus/core-v6/src/libraries/JBConstants.sol";
-
-contract FreshAudit is UnitTestSetup {
-    function _buildPayMetadata(
-        address hookAddress,
-        bool allowOverspending,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(allowOverspending, tierIdsToMint);
-
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-
-        return metadataHelper.createMetadata(ids, data);
-    }
-
-    function _nativeAmount(uint256 value) internal pure returns (JBTokenAmount memory) {
-        return JBTokenAmount({
-            token: JBConstants.NATIVE_TOKEN,
-            value: value,
-            decimals: 18,
-            currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-        });
-    }
-
-    function test_payCredits_can_underfund_split_bearing_tier_mints() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-        address splitReceiver = makeAddr("splitReceiver");
-
-        JB721TierConfig[] memory tiersToAdd = new JB721TierConfig[](1);
-        tiersToAdd[0] = JB721TierConfig({
-            price: uint104(1 ether),
-            initialSupply: uint32(10),
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(1)),
-            category: uint24(1),
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tiersToAdd, new uint256[](0));
-
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(splitReceiver),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(1) << 160);
-        vm.mockCall(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-        vm.mockCall(
-            mockJBDirectory,
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        JBAfterPayRecordedContext memory seedCredits = JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: _nativeAmount(1 ether),
-            forwardedAmount: _nativeAmount(0),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: bytes(""),
-            payerMetadata: bytes("")
-        });
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(seedCredits);
-        assertEq(testHook.payCreditsOf(beneficiary), 1 ether, "setup: credits should be seeded");
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-        bytes memory payerMetadata = _buildPayMetadata(address(testHook), true, tierIds);
-
-        JBBeforePayRecordedContext memory beforeContext = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: _nativeAmount(1),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 0,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight, JBPayHookSpecification[] memory hookSpecifications) =
-            testHook.beforePayRecordedWith(beforeContext);
-
-        assertEq(weight, 0, "all fresh payment value is treated as split-routed");
-        assertEq(hookSpecifications.length, 1, "expected single pay hook spec");
-        assertEq(hookSpecifications[0].amount, 1, "split forwarding is capped to the fresh payment only");
-
-        JBAfterPayRecordedContext memory mintWithCredits = JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: _nativeAmount(1),
-            forwardedAmount: _nativeAmount(hookSpecifications[0].amount),
-            weight: weight,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: hookSpecifications[0].metadata,
-            payerMetadata: payerMetadata
-        });
-
-        vm.deal(mockTerminalAddress, 1);
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith{value: 1}(mintWithCredits);
-
-        assertEq(testHook.balanceOf(beneficiary), 1, "beneficiary still mints the split-bearing NFT");
-        assertEq(testHook.payCreditsOf(beneficiary), 1, "stored credits fund essentially the entire mint");
-        assertEq(splitReceiver.balance, 1, "split receiver only receives the fresh 1 wei payment");
-        assertEq(hookStore.totalCashOutWeight(address(testHook)), 1 ether, "full-price NFT still enters cash-out math");
-    }
-
-    /// @notice Creating a tier with reserveFrequency > 0 and no beneficiary (tier-specific or default)
-    /// is now rejected at creation time, preventing the retroactive dilution bug.
-    function test_new_default_reserve_beneficiary_retroactively_dilutes_existing_tiers() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory initialTier = new JB721TierConfig[](1);
-        initialTier[0] = JB721TierConfig({
-            price: uint104(1 ether),
-            initialSupply: uint32(5),
-            votingUnits: 0,
-            reserveFrequency: uint16(2),
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(2)),
-            category: uint24(1),
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        // The new creation-time check prevents tiers with reserves but no beneficiary.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        vm.prank(owner);
-        testHook.adjustTiers(initialTier, new uint256[](0));
-    }
-}

package/test/audit/FutureTierPoC.t.sol

@@ -1,39 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {UnitTestSetup} from "../utils/UnitTestSetup.sol";
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {IJB721TokenUriResolver} from "../../src/interfaces/IJB721TokenUriResolver.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-
-contract FutureTierPoC is UnitTestSetup {
-    function test_futureTierRemovalPersistsIntoNewTierAndBricksMint() external {
-        hook = _initHookDefaultTiers(0);
-
-        uint256[] memory futureTierIds = new uint256[](1);
-        futureTierIds[0] = 1;
-
-        // L-18 FIX: Removing a future (nonexistent) tier ID now reverts,
-        // preventing the "born removed" bug entirely.
-        vm.prank(owner);
-        vm.expectRevert(abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_UnrecognizedTier.selector, 1));
-        hook.adjustTiers(new JB721TierConfig[](0), futureTierIds);
-    }
-
-    function test_futureTierUriCanBePoisonedBeforeTierExists() external {
-        hook = _initHookDefaultTiers(0);
-
-        bytes32 poisonedUri = bytes32(uint256(0x1234));
-
-        vm.prank(owner);
-        hook.setMetadata("", "", "", "", IJB721TokenUriResolver(address(hook)), 1, poisonedUri);
-
-        (JB721TierConfig[] memory tiersToAdd,) = _createTiers(defaultTierConfig, 1);
-        tiersToAdd[0].encodedIPFSUri = bytes32(0);
-
-        vm.prank(owner);
-        hook.adjustTiers(tiersToAdd, new uint256[](0));
-
-        assertEq(hook.STORE().encodedIPFSUriOf(address(hook), 1), poisonedUri, "future tier inherited stale uri");
-    }
-}

package/test/audit/FutureTierRemoval.t.sol

@@ -1,47 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-
-contract Test_FutureTierRemoval is Test {
-    JB721TiersHookStore internal store;
-
-    function setUp() external {
-        store = new JB721TiersHookStore();
-    }
-
-    function test_futureRemovedTierIdIsBornRemovedAndCannotMint() external {
-        JB721TierConfig[] memory firstTier = new JB721TierConfig[](1);
-        firstTier[0] = _tier(1);
-        uint256[] memory firstIds = store.recordAddTiers(firstTier);
-        assertEq(firstIds[0], 1);
-
-        // Attempting to remove a future (nonexistent) tier ID should now revert
-        // thanks to the L-18 fix, preventing the "born removed" bug.
-        uint256[] memory futureIds = new uint256[](1);
-        futureIds[0] = 2;
-        vm.expectRevert(abi.encodeWithSignature("JB721TiersHookStore_UnrecognizedTier(uint256)", 2));
-        store.recordRemoveTierIds(futureIds);
-    }
-
-    function _tier(uint24 category) internal pure returns (JB721TierConfig memory tier) {
-        tier.price = 1;
-        tier.initialSupply = 10;
-        tier.category = category;
-        tier.flags = JB721TierConfigFlags({
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false
-        });
-        tier.splits = new JBSplit[](0);
-    }
-}

package/test/audit/Pass12L18.t.sol

@@ -1,80 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-
-/// @notice L-18: Prevent future tier pre-removal.
-/// Removing a tier ID that does not yet exist should revert with `UnrecognizedTier`.
-contract Pass12L18 is Test {
-    JB721TiersHookStore internal store;
-
-    function setUp() external {
-        store = new JB721TiersHookStore();
-    }
-
-    /// @notice Removing a future tier ID (beyond maxTierIdOf) must revert.
-    function test_L18_fix_reverts_future_removal() external {
-        // Add 5 tiers so maxTierIdOf == 5.
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](5);
-        for (uint256 i; i < 5; i++) {
-            tiers[i] = _tier(uint24(i + 1));
-        }
-        store.recordAddTiers(tiers);
-        assertEq(store.maxTierIdOf(address(this)), 5);
-
-        // Attempt to remove tier 10 (future) — should revert.
-        uint256[] memory futureTierIds = new uint256[](1);
-        futureTierIds[0] = 10;
-        vm.expectRevert(abi.encodeWithSignature("JB721TiersHookStore_UnrecognizedTier(uint256)", 10));
-        store.recordRemoveTierIds(futureTierIds);
-
-        // Attempt to remove tier 0 (invalid) — should also revert.
-        uint256[] memory zeroTierIds = new uint256[](1);
-        zeroTierIds[0] = 0;
-        vm.expectRevert(abi.encodeWithSignature("JB721TiersHookStore_UnrecognizedTier(uint256)", 0));
-        store.recordRemoveTierIds(zeroTierIds);
-    }
-
-    /// @notice Removing an existing tier still works as before.
-    function test_L18_existing_tier_removal_works() external {
-        // Add 5 tiers.
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](5);
-        for (uint256 i; i < 5; i++) {
-            tiers[i] = _tier(uint24(i + 1));
-        }
-        store.recordAddTiers(tiers);
-
-        // Remove tier 3 — should succeed.
-        uint256[] memory removeTierIds = new uint256[](1);
-        removeTierIds[0] = 3;
-        store.recordRemoveTierIds(removeTierIds);
-        assertTrue(store.isTierRemoved({hook: address(this), tierId: 3}));
-
-        // Other tiers should not be affected.
-        assertFalse(store.isTierRemoved({hook: address(this), tierId: 1}));
-        assertFalse(store.isTierRemoved({hook: address(this), tierId: 2}));
-        assertFalse(store.isTierRemoved({hook: address(this), tierId: 4}));
-        assertFalse(store.isTierRemoved({hook: address(this), tierId: 5}));
-    }
-
-    function _tier(uint24 category) internal pure returns (JB721TierConfig memory tier) {
-        tier.price = 1;
-        tier.initialSupply = 10;
-        tier.category = category;
-        tier.flags = JB721TierConfigFlags({
-            allowOwnerMint: false,
-            useReserveBeneficiaryAsDefault: false,
-            transfersPausable: false,
-            useVotingUnits: false,
-            cantBeRemoved: false,
-            cantIncreaseDiscountPercent: false,
-            cantBuyWithCredits: false
-        });
-        tier.splits = new JBSplit[](0);
-    }
-}

package/test/audit/PayCreditsBypassTierSplits.t.sol

@@ -1,200 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJB721TiersHookStore} from "../../src/interfaces/IJB721TiersHookStore.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {JBBeforePayRecordedContext} from "@bananapus/core-v6/src/structs/JBBeforePayRecordedContext.sol";
-import {JBAfterPayRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterPayRecordedContext.sol";
-import {JBPayHookSpecification} from "@bananapus/core-v6/src/structs/JBPayHookSpecification.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-import {IJBSplitHook} from "@bananapus/core-v6/src/interfaces/IJBSplitHook.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-
-contract PayCreditsBypassTierSplits is UnitTestSetup {
-    address internal splitBeneficiary = makeAddr("splitBeneficiary");
-
-    function setUp() public override {
-        super.setUp();
-        vm.etch(mockJBSplits, new bytes(0x69));
-    }
-
-    function _buildPayMetadata(
-        address hookAddress,
-        bool allowOverspending,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(allowOverspending, tierIdsToMint);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-        return metadataHelper.createMetadata(ids, data);
-    }
-
-    function _beforePayContext(
-        address hookAddress,
-        uint256 amountValue,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (JBBeforePayRecordedContext memory)
-    {
-        return JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: amountValue,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: _buildPayMetadata(hookAddress, false, tierIdsToMint)
-        });
-    }
-
-    function _afterPayContext(
-        address hookAddress,
-        uint256 amountValue,
-        uint256 forwardedAmountValue,
-        bytes memory hookMetadata,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (JBAfterPayRecordedContext memory)
-    {
-        return JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: amountValue,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            forwardedAmount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: forwardedAmountValue,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: hookMetadata,
-            payerMetadata: _buildPayMetadata(hookAddress, true, tierIdsToMint)
-        });
-    }
-
-    function test_payCredits_can_bypass_most_of_tier_split_payment() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        vm.mockCall(
-            mockJBDirectory,
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: reserveBeneficiary,
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 1_000_000_000,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory noTiers = new uint16[](0);
-        JBAfterPayRecordedContext memory creditSeedContext = JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            forwardedAmount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 0,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: "",
-            payerMetadata: _buildPayMetadata(address(testHook), true, noTiers)
-        });
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(creditSeedContext);
-        assertEq(testHook.payCreditsOf(beneficiary), 1 ether, "setup: credits should be seeded");
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-
-        (, JBPayHookSpecification[] memory specs) =
-            testHook.beforePayRecordedWith(_beforePayContext(address(testHook), 1, mintIds));
-        assertEq(specs[0].amount, 1, "forwarded amount is capped to the fresh payment");
-
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: 1_000_000_000,
-            projectId: 0,
-            beneficiary: payable(splitBeneficiary),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        vm.mockCall(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        uint256 splitBalanceBefore = splitBeneficiary.balance;
-
-        JBAfterPayRecordedContext memory creditMintContext =
-            _afterPayContext(address(testHook), 1, 1, specs[0].metadata, mintIds);
-        vm.deal(mockTerminalAddress, 1);
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith{value: 1}(creditMintContext);
-
-        assertEq(testHook.balanceOf(beneficiary), 1, "beneficiary should receive the NFT");
-        assertEq(testHook.payCreditsOf(beneficiary), 1, "credits should fund almost the entire mint");
-        assertEq(splitBeneficiary.balance - splitBalanceBefore, 1, "split recipient only gets the fresh payment");
-    }
-}