@bananapus/721-hook-v6 0.0.41 → 0.0.43

package/test/invariants/handlers/TierStoreHandler.sol

@@ -1,165 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {CommonBase} from "forge-std/Base.sol";
-import {StdCheats} from "forge-std/StdCheats.sol";
-import {StdUtils} from "forge-std/StdUtils.sol";
-
-import {JB721TiersHookStore} from "../../../src/JB721TiersHookStore.sol";
-import {JB721TierConfig} from "../../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../../src/structs/JB721TierConfigFlags.sol";
-// forge-lint: disable-next-line(unused-import)
-import {JB721TiersHookFlags} from "../../../src/structs/JB721TiersHookFlags.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-/// @notice Handler for JB721TiersHookStore invariant tests.
-/// @dev Acts as the "hook" address itself, so msg.sender (this) == hook in the store.
-contract TierStoreHandler is CommonBase, StdCheats, StdUtils {
-    JB721TiersHookStore public immutable STORE;
-
-    // This contract acts as the hook.
-    // forge-lint: disable-next-line(mixed-case-variable)
-    address public HOOK;
-
-    // Ghost variable tracking the max tier ID seen.
-    uint256 public lowestMaxTierIdSeen;
-
-    // Track how many tiers we've added.
-    uint256 public tiersAdded;
-
-    // Track minted token IDs so we can only burn minted tokens.
-    uint256[] public mintedTokenIds;
-
-    // Track burned token IDs to avoid double-burn.
-    mapping(uint256 => bool) public wasBurned;
-
-    constructor(JB721TiersHookStore store) {
-        STORE = store;
-        HOOK = address(this);
-    }
-
-    /// @notice Add a new tier.
-    function addTier(uint104 price, uint32 initialSupply, uint16 reserveFrequency, uint24 category) public {
-        // Bound inputs to valid ranges.
-        initialSupply = uint32(bound(initialSupply, 1, 1_000_000));
-        price = uint104(bound(price, 1, type(uint104).max));
-        category = uint24(bound(category, 0, 100));
-
-        // Reserve frequency must be <= initialSupply if non-zero.
-        if (reserveFrequency > 0) {
-            reserveFrequency = uint16(bound(reserveFrequency, 1, 200));
-        }
-
-        JB721TierConfig[] memory configs = new JB721TierConfig[](1);
-        configs[0] = JB721TierConfig({
-            price: price,
-            initialSupply: initialSupply,
-            votingUnits: 0,
-            reserveFrequency: reserveFrequency,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(0),
-            category: category,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: true,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        try this._doAddTiers(configs) {
-            tiersAdded++;
-            _updateMaxTierIdSeen();
-        } catch {}
-    }
-
-    /// @dev External wrapper so calldata encoding is correct for the store.
-    function _doAddTiers(JB721TierConfig[] calldata configs) external {
-        STORE.recordAddTiers(configs);
-    }
-
-    /// @notice Remove a tier.
-    function removeTier(uint256 tierId) public {
-        uint256 maxId = STORE.maxTierIdOf(HOOK);
-        if (maxId == 0) return;
-
-        tierId = bound(tierId, 1, maxId);
-
-        uint256[] memory ids = new uint256[](1);
-        ids[0] = tierId;
-
-        try this._doRemoveTiers(ids) {} catch {}
-    }
-
-    /// @dev External wrapper for calldata.
-    function _doRemoveTiers(uint256[] calldata ids) external {
-        STORE.recordRemoveTierIds(ids);
-    }
-
-    /// @notice Mint from a tier (simulates store recording a mint).
-    function mint(uint256 tierId) public {
-        uint256 maxId = STORE.maxTierIdOf(HOOK);
-        if (maxId == 0) return;
-
-        tierId = bound(tierId, 1, maxId);
-
-        uint16[] memory tierIds = new uint16[](1);
-        // forge-lint: disable-next-line(unsafe-typecast)
-        tierIds[0] = uint16(tierId);
-
-        try this._doMint(type(uint256).max, tierIds) returns (uint256[] memory tokenIds) {
-            for (uint256 i; i < tokenIds.length; i++) {
-                if (tokenIds[i] != 0) {
-                    mintedTokenIds.push(tokenIds[i]);
-                }
-            }
-        } catch {}
-
-        _updateMaxTierIdSeen();
-    }
-
-    /// @dev External wrapper for calldata.
-    function _doMint(uint256 amount, uint16[] calldata tierIds) external returns (uint256[] memory tokenIds) {
-        (tokenIds,,) = STORE.recordMint(amount, tierIds, true);
-    }
-
-    /// @notice Burn a minted token.
-    function burn(uint256 indexSeed) public {
-        if (mintedTokenIds.length == 0) return;
-
-        uint256 index = bound(indexSeed, 0, mintedTokenIds.length - 1);
-        uint256 tokenId = mintedTokenIds[index];
-
-        // Skip if already burned.
-        if (wasBurned[tokenId]) return;
-
-        uint256[] memory tokenIds = new uint256[](1);
-        tokenIds[0] = tokenId;
-
-        try this._doBurn(tokenIds) {
-            wasBurned[tokenId] = true;
-        } catch {}
-    }
-
-    /// @dev External wrapper for calldata.
-    function _doBurn(uint256[] calldata tokenIds) external {
-        STORE.recordBurn(tokenIds);
-    }
-
-    function mintedTokenCount() external view returns (uint256) {
-        return mintedTokenIds.length;
-    }
-
-    function _updateMaxTierIdSeen() internal {
-        uint256 current = STORE.maxTierIdOf(HOOK);
-        if (lowestMaxTierIdSeen == 0 || current > lowestMaxTierIdSeen) {
-            lowestMaxTierIdSeen = current;
-        }
-    }
-}

package/test/regression/BrokenTerminalDoesNotDos.t.sol

@@ -1,277 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJB721TiersHookStore} from "../../src/interfaces/IJB721TiersHookStore.sol";
-// forge-lint: disable-next-line(unused-import)
-import {JB721TiersHookLib} from "../../src/libraries/JB721TiersHookLib.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-import {IJBSplitHook} from "@bananapus/core-v6/src/interfaces/IJBSplitHook.sol";
-import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {IJBTerminal} from "@bananapus/core-v6/src/interfaces/IJBTerminal.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
-
-/// @notice Regression tests: a broken project terminal in _addToBalance now reverts the payment (M-4 fix).
-contract Test_BrokenTerminalDoesNotDos is UnitTestSetup {
-    using stdStorage for StdStorage;
-
-    function setUp() public override {
-        super.setUp();
-        vm.etch(mockJBSplits, new bytes(0x69));
-    }
-
-    // Helper: build payer metadata for tier IDs.
-    function _buildPayerMetadata(
-        address hookAddress,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(false, tierIdsToMint);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-        return metadataHelper.createMetadata(ids, data);
-    }
-
-    /// @notice Helper to build an ERC-20 afterPay context (reduces stack depth).
-    function _buildErc20PayContext(
-        address hookAddress,
-        address token,
-        uint32 currency,
-        uint8 decimals,
-        uint256[] memory tierIds,
-        uint256 amount
-    )
-        internal
-        view
-        returns (JBAfterPayRecordedContext memory)
-    {
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(hookAddress, mintIds);
-
-        uint16[] memory splitTierIds = new uint16[](1);
-        splitTierIds[0] = uint16(tierIds[0]);
-        uint256[] memory splitAmounts = new uint256[](1);
-        splitAmounts[0] = amount;
-
-        return JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({token: token, value: amount, decimals: decimals, currency: currency}),
-            forwardedAmount: JBTokenAmount({token: token, value: amount, decimals: decimals, currency: currency}),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: abi.encode(beneficiary, beneficiary, abi.encode(splitTierIds, splitAmounts)),
-            payerMetadata: payerMetadata
-        });
-    }
-
-    // ──────────────────────────────────────────────────────────────────────
-    // ETH: broken own-project terminal in _addToBalance should revert (M-4)
-    // ──────────────────────────────────────────────────────────────────────
-
-    /// @notice When a split has no valid recipient (projectId==0, beneficiary==address(0)),
-    /// funds route to the project's own terminal via _addToBalance. If that terminal reverts,
-    /// the payment now reverts with JB721TiersHookLib_SplitFallbackFailed (M-4 fix).
-    function test_brokenOwnTerminal_eth_reverts() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 100% split, priced at 1 ETH.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0].price = 1 ether;
-        tierConfigs[0].initialSupply = uint32(100);
-        tierConfigs[0].category = uint24(1);
-        tierConfigs[0].encodedIPFSUri = bytes32(uint256(0x1234));
-        tierConfigs[0].splitPercent = 1_000_000_000; // 100%
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Mock directory checks.
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        // Mock splits: a split with no valid recipient (projectId==0, beneficiary==address(0)),
-        // so funds route to _addToBalance.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(address(0)),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Mock the project's primary terminal to a contract that reverts on addToBalanceOf.
-        address brokenTerminal = makeAddr("brokenTerminal");
-        vm.etch(brokenTerminal, new bytes(0x69));
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.primaryTerminalOf.selector, projectId, JBConstants.NATIVE_TOKEN),
-            abi.encode(brokenTerminal)
-        );
-        // Make addToBalanceOf revert.
-        vm.mockCallRevert(
-            brokenTerminal, abi.encodeWithSelector(IJBTerminal.addToBalanceOf.selector), "terminal broken"
-        );
-
-        // Build payer metadata.
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        // Build hook metadata (per-tier split breakdown).
-        uint16[] memory splitTierIds = new uint16[](1);
-        splitTierIds[0] = uint16(tierIds[0]);
-        uint256[] memory splitAmounts = new uint256[](1);
-        splitAmounts[0] = 1 ether;
-
-        JBAfterPayRecordedContext memory payContext = JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            forwardedAmount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: abi.encode(beneficiary, beneficiary, abi.encode(splitTierIds, splitAmounts)),
-            payerMetadata: payerMetadata
-        });
-
-        vm.deal(mockTerminalAddress, 2 ether);
-
-        vm.prank(mockTerminalAddress);
-        // The payment should now revert when the fallback addToBalanceOf call fails (M-4).
-        vm.expectRevert();
-        testHook.afterPayRecordedWith{value: 1 ether}(payContext);
-    }
-
-    // ──────────────────────────────────────────────────────────────────────
-    // ERC-20: broken own-project terminal in _addToBalance should revert (M-4)
-    // ──────────────────────────────────────────────────────────────────────
-
-    /// @notice Same scenario as above but with ERC-20 tokens. On terminal failure, the
-    /// approval is reset to 0 for safety and the payment now reverts (M-4 fix).
-    function test_brokenOwnTerminal_erc20_reverts() public {
-        BrokenTerminalERC20 usdc = new BrokenTerminalERC20("USD Coin", "USDC", 6);
-        uint32 usdcCurrency = uint32(uint160(address(usdc)));
-
-        JB721TiersHook testHook = _initHookDefaultTiers(0, false, usdcCurrency, 6);
-
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0].price = 100e6;
-        tierConfigs[0].initialSupply = uint32(100);
-        tierConfigs[0].category = uint24(1);
-        tierConfigs[0].encodedIPFSUri = bytes32(uint256(0x1234));
-        tierConfigs[0].splitPercent = 1_000_000_000; // 100%
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = testHook.STORE().recordAddTiers(tierConfigs);
-
-        _setupErc20Mocks(testHook, tierIds, address(usdc), usdcCurrency);
-
-        JBAfterPayRecordedContext memory payContext =
-            _buildErc20PayContext(address(testHook), address(usdc), usdcCurrency, 6, tierIds, 100e6);
-
-        // Fund the terminal and approve the hook to pull tokens.
-        usdc.mint(mockTerminalAddress, 100e6);
-        vm.prank(mockTerminalAddress);
-        usdc.approve(address(testHook), 100e6);
-
-        vm.prank(mockTerminalAddress);
-        // The payment should now revert when the fallback addToBalanceOf call fails (M-4).
-        vm.expectRevert();
-        testHook.afterPayRecordedWith(payContext);
-    }
-
-    /// @notice Sets up mocks for the ERC-20 broken terminal test (extracted to avoid stack-too-deep).
-    function _setupErc20Mocks(
-        JB721TiersHook testHook,
-        uint256[] memory tierIds,
-        address token,
-        uint32 /* usdcCurrency */
-    )
-        internal
-    {
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        // Mock splits: no valid recipient, so funds route to _addToBalance.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(address(0)),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Mock the project's primary terminal to a contract that reverts on addToBalanceOf.
-        address brokenTerminal = makeAddr("brokenTerminal");
-        vm.etch(brokenTerminal, new bytes(0x69));
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.primaryTerminalOf.selector, projectId, token),
-            abi.encode(brokenTerminal)
-        );
-        // Make addToBalanceOf revert.
-        vm.mockCallRevert(
-            brokenTerminal, abi.encodeWithSelector(IJBTerminal.addToBalanceOf.selector), "terminal broken"
-        );
-    }
-}
-
-/// @notice A simple mintable ERC20 for testing.
-contract BrokenTerminalERC20 is ERC20 {
-    uint8 internal _decimals;
-
-    constructor(string memory name_, string memory symbol_, uint8 decimals_) ERC20(name_, symbol_) {
-        _decimals = decimals_;
-    }
-
-    function decimals() public view override returns (uint8) {
-        return _decimals;
-    }
-
-    function mint(address to, uint256 amount) external {
-        _mint(to, amount);
-    }
-}

package/test/regression/CacheTierLookup.t.sol

@@ -1,190 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJB721TiersHookStore} from "../../src/interfaces/IJB721TiersHookStore.sol";
-// forge-lint: disable-next-line(unused-import)
-import {JB721TiersHookLib} from "../../src/libraries/JB721TiersHookLib.sol";
-
-/// @notice calculateSplitAmounts caches the tierOf result to avoid a duplicate external call.
-/// Verifies that the cached tier lookup returns the same split amounts as reading price and splitPercent individually.
-contract Test_L35_CacheTierLookup is UnitTestSetup {
-    using stdStorage for StdStorage;
-
-    /// @notice Verify that calculateSplitAmounts returns correct per-tier amounts when multiple tiers have different
-    /// prices and split percentages. This exercises the cached `tier` variable.
-    function test_calculateSplitAmounts_multiTier_correctAmounts() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add 3 tiers with different prices and split percents.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](3);
-
-        // Tier A: 1 ETH, 25% split -> 0.25 ETH
-        tierConfigs[0].price = 1 ether;
-        tierConfigs[0].initialSupply = uint32(100);
-        tierConfigs[0].category = uint24(1);
-        tierConfigs[0].encodedIPFSUri = bytes32(uint256(0x1111));
-        tierConfigs[0].splitPercent = 250_000_000; // 25%
-
-        // Tier B: 2 ETH, 50% split -> 1 ETH
-        tierConfigs[1].price = 2 ether;
-        tierConfigs[1].initialSupply = uint32(100);
-        tierConfigs[1].category = uint24(2);
-        tierConfigs[1].encodedIPFSUri = bytes32(uint256(0x2222));
-        tierConfigs[1].splitPercent = 500_000_000; // 50%
-
-        // Tier C: 0.5 ETH, 100% split -> 0.5 ETH
-        tierConfigs[2].price = 0.5 ether;
-        tierConfigs[2].initialSupply = uint32(100);
-        tierConfigs[2].category = uint24(3);
-        tierConfigs[2].encodedIPFSUri = bytes32(uint256(0x3333));
-        tierConfigs[2].splitPercent = 1_000_000_000; // 100%
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Build payer metadata requesting all 3 tiers.
-        uint16[] memory mintIds = new uint16[](3);
-        mintIds[0] = uint16(tierIds[0]);
-        mintIds[1] = uint16(tierIds[1]);
-        mintIds[2] = uint16(tierIds[2]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 3.5 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // Total split = 0.25 + 1.0 + 0.5 = 1.75 ETH
-        assertEq(specs[0].amount, 1.75 ether, "Total split amount should be 1.75 ETH");
-    }
-
-    /// @notice Verify that a tier with splitPercent == 0 contributes nothing to the total, even when cached.
-    function test_calculateSplitAmounts_zeroSplitSkipped() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Tier A: 1 ETH, 50% split
-        // Tier B: 3 ETH, 0% split (should be skipped)
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](2);
-        tierConfigs[0].price = 1 ether;
-        tierConfigs[0].initialSupply = uint32(100);
-        tierConfigs[0].category = uint24(1);
-        tierConfigs[0].encodedIPFSUri = bytes32(uint256(0xAAAA));
-        tierConfigs[0].splitPercent = 500_000_000; // 50%
-
-        tierConfigs[1].price = 3 ether;
-        tierConfigs[1].initialSupply = uint32(100);
-        tierConfigs[1].category = uint24(2);
-        tierConfigs[1].encodedIPFSUri = bytes32(uint256(0xBBBB));
-        tierConfigs[1].splitPercent = 0; // 0%
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](2);
-        mintIds[0] = uint16(tierIds[0]);
-        mintIds[1] = uint16(tierIds[1]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 4 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // Only tier A contributes: 1 ETH * 50% = 0.5 ETH
-        assertEq(specs[0].amount, 0.5 ether, "Only non-zero split tiers should contribute");
-    }
-
-    /// @notice Verify that duplicate tier IDs in metadata produce correct cumulative split amounts.
-    /// The cached tier lookup must handle the same tier appearing multiple times.
-    function test_calculateSplitAmounts_duplicateTierIds() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Single tier: 1 ETH, 30% split
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0].price = 1 ether;
-        tierConfigs[0].initialSupply = uint32(100);
-        tierConfigs[0].category = uint24(1);
-        tierConfigs[0].encodedIPFSUri = bytes32(uint256(0xCCCC));
-        tierConfigs[0].splitPercent = 300_000_000; // 30%
-
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Request the same tier twice in metadata.
-        uint16[] memory mintIds = new uint16[](2);
-        mintIds[0] = uint16(tierIds[0]);
-        mintIds[1] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 2 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // 2 x (1 ETH * 30%) = 0.6 ETH
-        assertEq(specs[0].amount, 0.6 ether, "Duplicate tier IDs should each contribute their split amount");
-    }
-
-    // Helper: build payer metadata for tier IDs.
-    function _buildPayerMetadata(
-        address hookAddress,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(false, tierIdsToMint);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-        return metadataHelper.createMetadata(ids, data);
-    }
-}