@babylonjs/core 8.3.1 → 8.4.0

package/assetContainer.js

@@ -131,7 +131,9 @@ export class AbstractAssetContainer {
         nodes = nodes.concat(this.lights);
         nodes = nodes.concat(this.cameras);
         nodes = nodes.concat(this.transformNodes); // dummies
-        this.skeletons.forEach((skeleton) => (nodes = nodes.concat(skeleton.bones)));
+        for (const skeleton of this.skeletons) {
+            nodes = nodes.concat(skeleton.bones);
+        }
         return nodes;
     }
 }
@@ -162,18 +164,21 @@ export class InstantiatedEntries {
      * Disposes the instantiated entries from the scene
      */
     dispose() {
-        this.rootNodes.slice(0).forEach((o) => {
-            o.dispose();
-        });
-        this.rootNodes.length = 0;
-        this.skeletons.slice(0).forEach((o) => {
-            o.dispose();
-        });
-        this.skeletons.length = 0;
-        this.animationGroups.slice(0).forEach((o) => {
-            o.dispose();
-        });
-        this.animationGroups.length = 0;
+        const rootNodes = this.rootNodes;
+        for (const rootNode of rootNodes) {
+            rootNode.dispose();
+        }
+        rootNodes.length = 0;
+        const skeletons = this.skeletons;
+        for (const skeleton of skeletons) {
+            skeleton.dispose();
+        }
+        skeletons.length = 0;
+        const animationGroups = this.animationGroups;
+        for (const animationGroup of animationGroups) {
+            animationGroup.dispose();
+        }
+        animationGroups.length = 0;
     }
 }
 /**
@@ -290,7 +295,9 @@ export class AssetContainer extends AbstractAssetContainer {
         }
         if (nodesUidMap.size > 0) {
             Logger.Error("SceneSerializer._topologicalSort: There were unvisited nodes:");
-            nodesUidMap.forEach((node) => Logger.Error(node.name));
+            nodesUidMap.forEach((node) => {
+                Logger.Error(node.name);
+            });
         }
         return sortedNodes;
     }
@@ -483,7 +490,7 @@ export class AssetContainer extends AbstractAssetContainer {
                 result.rootNodes.push(clone);
             }
         };
-        sortedNodes.forEach((node) => {
+        for (const node of sortedNodes) {
             if (node.getClassName() === "InstancedMesh") {
                 const instancedNode = node;
                 const sourceMesh = instancedNode.sourceMesh;
@@ -517,10 +524,10 @@ export class AssetContainer extends AbstractAssetContainer {
                 }
                 onNewCreated(node, replicatedNode);
             }
-        });
-        this.skeletons.forEach((s) => {
+        }
+        for (const s of this.skeletons) {
             if (localOptions.predicate && !localOptions.predicate(s)) {
-                return;
+                continue;
             }
             const clone = s.clone(nameFunction ? nameFunction(s.name) : "Clone of " + s.name);
             for (const m of this.meshes) {
@@ -543,17 +550,17 @@ export class AssetContainer extends AbstractAssetContainer {
                 }
             }
             result.skeletons.push(clone);
-        });
-        this.animationGroups.forEach((o) => {
+        }
+        for (const o of this.animationGroups) {
             if (localOptions.predicate && !localOptions.predicate(o)) {
-                return;
+                continue;
             }
             const clone = o.clone(nameFunction ? nameFunction(o.name) : "Clone of " + o.name, (oldTarget) => {
                 const newTarget = storeMap[conversionMap[oldTarget.uniqueId]];
                 return newTarget || oldTarget;
             });
             result.animationGroups.push(clone);
-        });
+        }
         return result;
     }
     /**
@@ -583,94 +590,94 @@ export class AssetContainer extends AbstractAssetContainer {
      */
     addToScene(predicate = null) {
         const addedNodes = [];
-        this.cameras.forEach((o) => {
+        for (const o of this.cameras) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addCamera(o);
             addedNodes.push(o);
-        });
-        this.lights.forEach((o) => {
+        }
+        for (const o of this.lights) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addLight(o);
             addedNodes.push(o);
-        });
-        this.meshes.forEach((o) => {
+        }
+        for (const o of this.meshes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addMesh(o);
             addedNodes.push(o);
-        });
-        this.skeletons.forEach((o) => {
+        }
+        for (const o of this.skeletons) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addSkeleton(o);
-        });
-        this.animations.forEach((o) => {
+        }
+        for (const o of this.animations) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addAnimation(o);
-        });
-        this.animationGroups.forEach((o) => {
+        }
+        for (const o of this.animationGroups) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addAnimationGroup(o);
-        });
-        this.multiMaterials.forEach((o) => {
+        }
+        for (const o of this.multiMaterials) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addMultiMaterial(o);
-        });
-        this.materials.forEach((o) => {
+        }
+        for (const o of this.materials) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addMaterial(o);
-        });
-        this.morphTargetManagers.forEach((o) => {
+        }
+        for (const o of this.morphTargetManagers) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addMorphTargetManager(o);
-        });
-        this.geometries.forEach((o) => {
+        }
+        for (const o of this.geometries) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addGeometry(o);
-        });
-        this.transformNodes.forEach((o) => {
+        }
+        for (const o of this.transformNodes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addTransformNode(o);
             addedNodes.push(o);
-        });
-        this.actionManagers.forEach((o) => {
+        }
+        for (const o of this.actionManagers) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addActionManager(o);
-        });
-        this.textures.forEach((o) => {
+        }
+        for (const o of this.textures) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addTexture(o);
-        });
-        this.reflectionProbes.forEach((o) => {
+        }
+        for (const o of this.reflectionProbes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.addReflectionProbe(o);
-        });
+        }
         for (const addedNode of addedNodes) {
             // If node was added to the scene, but parent is not in the scene, break the relationship
             if (addedNode.parent && this.scene.getNodes().indexOf(addedNode.parent) === -1) {
@@ -705,146 +712,159 @@ export class AssetContainer extends AbstractAssetContainer {
      * @param predicate defines a predicate used to select which entity will be added (can be null)
      */
     removeFromScene(predicate = null) {
-        this.cameras.forEach((o) => {
+        for (const o of this.cameras) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeCamera(o);
-        });
-        this.lights.forEach((o) => {
+        }
+        for (const o of this.lights) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeLight(o);
-        });
-        this.meshes.forEach((o) => {
+        }
+        for (const o of this.meshes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeMesh(o, true);
-        });
-        this.skeletons.forEach((o) => {
+        }
+        for (const o of this.skeletons) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeSkeleton(o);
-        });
-        this.animations.forEach((o) => {
+        }
+        for (const o of this.animations) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeAnimation(o);
-        });
-        this.animationGroups.forEach((o) => {
+        }
+        for (const o of this.animationGroups) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeAnimationGroup(o);
-        });
-        this.multiMaterials.forEach((o) => {
+        }
+        for (const o of this.multiMaterials) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeMultiMaterial(o);
-        });
-        this.materials.forEach((o) => {
+        }
+        for (const o of this.materials) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeMaterial(o);
-        });
-        this.morphTargetManagers.forEach((o) => {
+        }
+        for (const o of this.morphTargetManagers) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeMorphTargetManager(o);
-        });
-        this.geometries.forEach((o) => {
+        }
+        for (const o of this.geometries) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeGeometry(o);
-        });
-        this.transformNodes.forEach((o) => {
+        }
+        for (const o of this.transformNodes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeTransformNode(o);
-        });
-        this.actionManagers.forEach((o) => {
+        }
+        for (const o of this.actionManagers) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeActionManager(o);
-        });
-        this.textures.forEach((o) => {
+        }
+        for (const o of this.textures) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeTexture(o);
-        });
-        this.reflectionProbes.forEach((o) => {
+        }
+        for (const o of this.reflectionProbes) {
             if (predicate && !predicate(o)) {
                 return;
             }
             this.scene.removeReflectionProbe(o);
-        });
+        }
     }
     /**
      * Disposes all the assets in the container
      */
     dispose() {
-        this.cameras.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const cameras = this.cameras;
+        for (const camera of cameras) {
+            camera.dispose();
+        }
         this.cameras.length = 0;
-        this.lights.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const lights = this.lights;
+        for (const light of lights) {
+            light.dispose();
+        }
         this.lights.length = 0;
-        this.meshes.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const meshes = this.meshes;
+        for (const mesh of meshes) {
+            mesh.dispose();
+        }
         this.meshes.length = 0;
-        this.skeletons.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const skeletons = this.skeletons;
+        for (const skeleton of skeletons) {
+            skeleton.dispose();
+        }
         this.skeletons.length = 0;
-        this.animationGroups.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const animationGroups = this.animationGroups;
+        for (const animationGroup of animationGroups) {
+            animationGroup.dispose();
+        }
         this.animationGroups.length = 0;
-        this.multiMaterials.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const multiMaterials = this.multiMaterials;
+        for (const multiMaterial of multiMaterials) {
+            multiMaterial.dispose();
+        }
         this.multiMaterials.length = 0;
-        this.materials.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const materials = this.materials;
+        for (const material of materials) {
+            material.dispose();
+        }
         this.materials.length = 0;
-        this.geometries.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const geometries = this.geometries;
+        for (const geometry of geometries) {
+            geometry.dispose();
+        }
         this.geometries.length = 0;
-        this.transformNodes.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const transformNodes = this.transformNodes;
+        for (const transformNode of transformNodes) {
+            transformNode.dispose();
+        }
         this.transformNodes.length = 0;
-        this.actionManagers.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const actionManagers = this.actionManagers;
+        for (const actionManager of actionManagers) {
+            actionManager.dispose();
+        }
         this.actionManagers.length = 0;
-        this.textures.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const textures = this.textures;
+        for (const texture of textures) {
+            texture.dispose();
+        }
         this.textures.length = 0;
-        this.reflectionProbes.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const reflectionProbes = this.reflectionProbes;
+        for (const reflectionProbe of reflectionProbes) {
+            reflectionProbe.dispose();
+        }
         this.reflectionProbes.length = 0;
-        this.morphTargetManagers.slice(0).forEach((o) => {
-            o.dispose();
-        });
+        const morphTargetManagers = this.morphTargetManagers;
+        for (const morphTargetManager of morphTargetManagers) {
+            morphTargetManager.dispose();
+        }
         this.morphTargetManagers.length = 0;
         if (this.environmentTexture) {
             this.environmentTexture.dispose();
@@ -902,11 +922,11 @@ export class AssetContainer extends AbstractAssetContainer {
      */
     createRootMesh() {
         const rootMesh = new Mesh("assetContainerRootMesh", this.scene);
-        this.meshes.forEach((m) => {
+        for (const m of this.meshes) {
             if (!m.parent) {
                 rootMesh.addChild(m);
             }
-        });
+        }
         this.meshes.unshift(rootMesh);
         return rootMesh;
     }
@@ -951,7 +971,7 @@ export class AssetContainer extends AbstractAssetContainer {
             };
         // Copy new node animations
         const nodesInAC = this.getNodes();
-        nodesInAC.forEach((nodeInAC) => {
+        for (const nodeInAC of nodesInAC) {
             const nodeInScene = _targetConverter(nodeInAC);
             if (nodeInScene !== null) {
                 // Remove old animations with same target property as a new one
@@ -970,19 +990,20 @@ export class AssetContainer extends AbstractAssetContainer {
                 // Append new animations
                 nodeInScene.animations = nodeInScene.animations.concat(nodeInAC.animations);
             }
-        });
+        }
         const newAnimationGroups = [];
         // Copy new animation groups
-        this.animationGroups.slice().forEach((animationGroupInAC) => {
+        const animationGroups = this.animationGroups.slice();
+        for (const animationGroupInAC of animationGroups) {
             // Clone the animation group and all its animatables
             newAnimationGroups.push(animationGroupInAC.clone(animationGroupInAC.name, _targetConverter));
             // Remove animatables related to the asset container
-            animationGroupInAC.animatables.forEach((animatable) => {
+            for (const animatable of animationGroupInAC.animatables) {
                 animatable.stop();
-            });
-        });
+            }
+        }
         // Retarget animatables
-        animatables.forEach((animatable) => {
+        for (const animatable of animatables) {
             const target = _targetConverter(animatable.target);
             if (target) {
                 // Clone the animatable and retarget it
@@ -990,7 +1011,7 @@ export class AssetContainer extends AbstractAssetContainer {
                 // Stop animation for the target in the asset container
                 scene.stopAnimation(animatable.target);
             }
-        });
+        }
         return newAnimationGroups;
     }
     /**
@@ -1001,26 +1022,26 @@ export class AssetContainer extends AbstractAssetContainer {
      */
     populateRootNodes() {
         this.rootNodes.length = 0;
-        this.meshes.forEach((m) => {
+        for (const m of this.meshes) {
             if (!m.parent && this.rootNodes.indexOf(m) === -1) {
                 this.rootNodes.push(m);
             }
-        });
-        this.transformNodes.forEach((t) => {
+        }
+        for (const t of this.transformNodes) {
             if (!t.parent && this.rootNodes.indexOf(t) === -1) {
                 this.rootNodes.push(t);
             }
-        });
-        this.lights.forEach((l) => {
+        }
+        for (const l of this.lights) {
             if (!l.parent && this.rootNodes.indexOf(l) === -1) {
                 this.rootNodes.push(l);
             }
-        });
-        this.cameras.forEach((c) => {
+        }
+        for (const c of this.cameras) {
             if (!c.parent && this.rootNodes.indexOf(c) === -1) {
                 this.rootNodes.push(c);
             }
-        });
+        }
     }
     /**
      * @since 6.26.0