@actual-app/sync-server 25.4.0-alpha.0

package/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js

@@ -0,0 +1,30 @@
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['SPK_MARBURG_BIEDENKOPF_HELADEF1MAR'],
+
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    let remittanceInformationUnstructured;
+
+    if (transaction.remittanceInformationUnstructured) {
+      remittanceInformationUnstructured =
+        transaction.remittanceInformationUnstructured;
+    } else if (transaction.remittanceInformationStructured) {
+      remittanceInformationUnstructured =
+        transaction.remittanceInformationStructured;
+    } else if (transaction.remittanceInformationStructuredArray?.length > 0) {
+      remittanceInformationUnstructured =
+        transaction.remittanceInformationStructuredArray?.join(' ');
+    }
+
+    editedTrans.remittanceInformationUnstructured =
+      remittanceInformationUnstructured;
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

package/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js

@@ -0,0 +1,19 @@
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['SPK_WORMS_ALZEY_RIED_MALADE51WOR'],
+
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    editedTrans.remittanceInformationUnstructured =
+      transaction.remittanceInformationUnstructured ??
+      transaction.remittanceInformationStructured ??
+      transaction.remittanceInformationStructuredArray?.join(' ');
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

package/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js

@@ -0,0 +1,50 @@
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['SSK_DUSSELDORF_DUSSDEDDXXX'],
+
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    // If the transaction is not booked yet by the bank, don't import it.
+    // Reason being that the transaction doesn't have the information yet
+    // to make the payee and notes field be of any use. It's filled with
+    // a placeholder text and wouldn't be corrected on the next sync.
+    if (!booked) {
+      console.debug(
+        'Skipping unbooked transaction:',
+        transaction.transactionId,
+      );
+      return null;
+    }
+
+    // Prioritize unstructured information, falling back to structured formats
+    let remittanceInformationUnstructured =
+      transaction.remittanceInformationUnstructured ??
+      transaction.remittanceInformationStructured ??
+      transaction.remittanceInformationStructuredArray?.join(' ');
+
+    if (transaction.additionalInformation) {
+      remittanceInformationUnstructured = [
+        remittanceInformationUnstructured,
+        transaction.additionalInformation,
+      ]
+        .filter(Boolean)
+        .join(' ');
+    }
+
+    const usefulCreditorName =
+      transaction.ultimateCreditor ||
+      transaction.creditorName ||
+      transaction.debtorName;
+
+    editedTrans.creditorName = usefulCreditorName;
+    editedTrans.remittanceInformationUnstructured =
+      remittanceInformationUnstructured;
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

package/src/app-gocardless/banks/swedbank_habalv22.js

@@ -0,0 +1,47 @@
+import d from 'date-fns';
+
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['SWEDBANK_HABALV22'],
+
+  /**
+   * The actual transaction date for card transactions is only available in the remittanceInformationUnstructured field when the transaction is booked.
+   */
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    const isCardTransaction =
+      transaction.remittanceInformationUnstructured?.startsWith('PIRKUMS');
+
+    if (isCardTransaction) {
+      if (!booked && !transaction.creditorName) {
+        const creditorNameMatch =
+          transaction.remittanceInformationUnstructured?.match(
+            /PIRKUMS [\d*]+ \d{2}\.\d{2}\.\d{2} \d{2}:\d{2} [\d.]+ \w{3} \(\d+\) (.+)/,
+          );
+
+        if (creditorNameMatch) {
+          editedTrans.creditorName = creditorNameMatch[1];
+        }
+      }
+
+      const dateMatch = transaction.remittanceInformationUnstructured?.match(
+        /PIRKUMS [\d*]+ (\d{2}\.\d{2}\.\d{4})/,
+      );
+
+      if (dateMatch) {
+        const extractedDate = d
+          .parse(dateMatch[1], 'dd.MM.yyyy', new Date())
+          .toISOString();
+
+        editedTrans.date = extractedDate;
+      }
+    }
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

package/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js

@@ -0,0 +1,21 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import Abanca from '../abanca_caglesmm.js';
+
+describe('Abanca', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the creditorName and debtorName as remittanceInformationStructured', () => {
+      const transaction = {
+        transactionId: 'non-unique-id',
+        internalTransactionId: 'D202301180000003',
+        transactionAmount: mockTransactionAmount,
+        remittanceInformationStructured: 'some-creditor-name',
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = Abanca.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual('Some-Creditor-Name');
+    });
+  });
+});

package/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js

@@ -0,0 +1,61 @@
+import AbnamroAbnanl2a from '../abnamro_abnanl2a.js';
+
+describe('AbnamroAbnanl2a', () => {
+  describe('#normalizeTransaction', () => {
+    it('correctly extracts the payee and when not provided', () => {
+      const transaction = {
+        transactionId: '0123456789012345',
+        bookingDate: '2023-12-11',
+        valueDateTime: '2023-12-09T15:43:37.950',
+        transactionAmount: {
+          amount: '-10.00',
+          currency: 'EUR',
+        },
+        remittanceInformationUnstructuredArray: [
+          'BEA, Betaalpas',
+          'My Payee Name,PAS123',
+          'NR:123A4B, 09.12.23/15:43',
+          'CITY',
+        ],
+      };
+
+      const normalizedTransaction = AbnamroAbnanl2a.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.notes).toEqual(
+        'BEA, Betaalpas, My Payee Name,PAS123, NR:123A4B, 09.12.23/15:43, CITY',
+      );
+      expect(normalizedTransaction.payeeName).toEqual('My Payee Name');
+    });
+
+    it('correctly extracts the payee for google pay', () => {
+      const transaction = {
+        transactionId: '0123456789012345',
+        bookingDate: '2023-12-11',
+        valueDateTime: '2023-12-09T15:43:37.950',
+        transactionAmount: {
+          amount: '-10.00',
+          currency: 'EUR',
+        },
+        remittanceInformationUnstructuredArray: [
+          'BEA, Google Pay',
+          'CCV*Other payee name,PAS123',
+          'NR:123A4B, 09.12.23/15:43',
+          'CITY',
+        ],
+      };
+
+      const normalizedTransaction = AbnamroAbnanl2a.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.notes).toEqual(
+        'BEA, Google Pay, CCV*Other payee name,PAS123, NR:123A4B, 09.12.23/15:43, CITY',
+      );
+      expect(normalizedTransaction.payeeName).toEqual('Other Payee Name');
+    });
+  });
+});

package/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js

@@ -0,0 +1,53 @@
+import Sabadell from '../bancsabadell_bsabesbbb.js';
+
+describe('BancSabadell', () => {
+  describe('#normalizeTransaction', () => {
+    describe('returns the creditorName and debtorName from remittanceInformationUnstructuredArray', () => {
+      it('debtor role - amount < 0', () => {
+        const transaction = {
+          transactionAmount: { amount: '-100', currency: 'EUR' },
+          remittanceInformationUnstructuredArray: ['some-creditor-name'],
+          internalTransactionId: 'd7dca139cf31d9',
+          transactionId: '04704109322',
+          bookingDate: '2022-05-01',
+        };
+        const normalizedTransaction = Sabadell.normalizeTransaction(
+          transaction,
+          true,
+        );
+        expect(normalizedTransaction.payeeName).toEqual('Some-Creditor-Name');
+      });
+
+      it('creditor role - amount > 0', () => {
+        const transaction = {
+          transactionAmount: { amount: '100', currency: 'EUR' },
+          remittanceInformationUnstructuredArray: ['some-debtor-name'],
+          internalTransactionId: 'd7dca139cf31d9',
+          transactionId: '04704109322',
+          bookingDate: '2022-05-01',
+        };
+        const normalizedTransaction = Sabadell.normalizeTransaction(
+          transaction,
+          true,
+        );
+        expect(normalizedTransaction.payeeName).toEqual('Some-Debtor-Name');
+      });
+    });
+
+    it('extract date', () => {
+      const transaction = {
+        transactionAmount: { amount: '-100', currency: 'EUR' },
+        remittanceInformationUnstructuredArray: ['some-creditor-name'],
+        internalTransactionId: 'd7dca139cf31d9',
+        transactionId: '04704109322',
+        bookingDate: '2024-10-02',
+        valueDate: '2024-10-05',
+      };
+      const normalizedTransaction = Sabadell.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.date).toEqual('2024-10-02');
+    });
+  });
+});

package/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js

@@ -0,0 +1,22 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import Belfius from '../belfius_gkccbebb.js';
+
+describe('Belfius', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the internalTransactionId as transactionId', () => {
+      const transaction = {
+        transactionId: 'non-unique-id',
+        internalTransactionId: 'D202301180000003',
+        transactionAmount: mockTransactionAmount,
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = Belfius.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.transactionId).toEqual(
+        transaction.internalTransactionId,
+      );
+    });
+  });
+});

package/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js

@@ -0,0 +1,34 @@
+import CBCcregbebb from '../cbc_cregbebb.js';
+
+describe('cbc_cregbebb', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the remittanceInformationUnstructured as payeeName when the amount is negative', () => {
+      const transaction = {
+        remittanceInformationUnstructured:
+          'ONKART FR Viry Paiement Maestro par Carte de débit CBC 05-09-2024 à 15.43 heures 6703 19XX XXXX X201 5 JOHN DOE',
+        transactionAmount: { amount: '-45.00', currency: 'EUR' },
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = CBCcregbebb.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual('ONKART FR Viry');
+    });
+
+    it('returns the debtorName as payeeName when the amount is positive', () => {
+      const transaction = {
+        debtorName: 'ONKART FR Viry',
+        remittanceInformationUnstructured:
+          'ONKART FR Viry Paiement Maestro par Carte de débit CBC 05-09-2024 à 15.43 heures 6703 19XX XXXX X201 5 JOHN DOE',
+        transactionAmount: { amount: '10.99', currency: 'EUR' },
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = CBCcregbebb.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual('ONKART FR Viry');
+    });
+  });
+});

package/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js

@@ -0,0 +1,110 @@
+import CommerzbankCobadeff from '../commerzbank_cobadeff.js';
+
+describe('CommerzbankCobadeff', () => {
+  describe('#normalizeTransaction', () => {
+    it('correctly formats remittanceInformationUnstructured', () => {
+      const transaction = {
+        endToEndId: '1234567890',
+        mandateId: '321654',
+        bookingDate: '2024-12-20',
+        valueDate: '2024-12-20',
+        transactionAmount: {
+          amount: '-12.34',
+          currency: 'EUR',
+        },
+        creditorName: 'SHOP NAME CITY DE',
+        remittanceInformationUnstructured:
+          'SHOP NAME//CITY/DE\n2024-12-19T15:34:31 KFN 1  AB 1234\nKartenzahlung',
+        remittanceInformationUnstructuredArray: [
+          'SHOP NAME//CITY/DE',
+          '2024-12-19T15:34:31 KFN 1 AB 1234',
+          'Kartenzahlung',
+        ],
+        remittanceInformationStructured:
+          'SHOP NAME//CITY/DE 2024-12-19T15:34:31 KFN 1 AB 1234 Kartenzahlung',
+        internalTransactionId: '3815213adb654baeadfb231c853',
+      };
+      const normalizedTransaction = CommerzbankCobadeff.normalizeTransaction(
+        transaction,
+        false,
+      );
+      expect(normalizedTransaction.notes).toEqual(
+        '2024-12-19T15:34:31 KFN 1 AB 1234, Kartenzahlung',
+      );
+    });
+
+    it('correctly formats remittanceInformationUnstructured; repair split keyword', () => {
+      const transaction = {
+        endToEndId: '901234567890',
+        mandateId: 'ABC123DEF456',
+        bookingDate: '2024-10-11',
+        valueDate: '2024-10-11',
+        transactionAmount: {
+          amount: '-56.78',
+          currency: 'EUR',
+        },
+        creditorName: 'Long payee name that is eaxtly 35ch',
+        remittanceInformationUnstructured:
+          'Long payee name that is eaxtly 35ch\n901234567890/. Long description tha\nt gets cut and is very long, did I\nmention it is long\nEnd-to-En',
+        remittanceInformationUnstructuredArray: [
+          'Long payee name that is eaxtly 35ch',
+          '901234567890/. Long description tha',
+          't gets cut and is very long, did I',
+          'mention it is long',
+          'End-to-En',
+          'd-Ref.: 901234567890',
+          'Mandatsref: ABC123DEF456',
+          'Gläubiger-ID:',
+          'AB12CDE0000000000000000012',
+          'SEPA-BASISLASTSCHRIFT wiederholend',
+        ],
+        remittanceInformationStructured:
+          'Long payee name that is eaxtly 35ch 901234567890/. Long description tha t gets cut and is very long, did I mention it is long End-to-En',
+        internalTransactionId: '812354cfdea36465asdfe',
+      };
+      const normalizedTransaction = CommerzbankCobadeff.normalizeTransaction(
+        transaction,
+        false,
+      );
+      expect(normalizedTransaction.notes).toEqual(
+        '901234567890/. Long description tha t gets cut and is very long, did I mention it is long, End-to-End-Ref.: 901234567890, Mandatsref: ABC123DEF456, Gläubiger-ID: AB12CDE0000000000000000012, SEPA-BASISLASTSCHRIFT wiederholend',
+      );
+    });
+
+    it('correctly formats remittanceInformationUnstructured; removing NOTPROVIDED', () => {
+      const transaction = {
+        endToEndId: 'NOTPROVIDED',
+        bookingDate: '2024-12-02',
+        valueDate: '2024-12-02',
+        transactionAmount: {
+          amount: '-9',
+          currency: 'EUR',
+        },
+        creditorName: 'CREDITOR NAME',
+        creditorAccount: {
+          iban: 'CREDITOR000IBAN',
+        },
+        remittanceInformationUnstructured:
+          'CREDITOR NAME\nCREDITOR00BIC\nCREDITOR000IBAN\nDESCRIPTION\nEnd-to-End-Ref.: NOTPROVIDED\nDauerauftrag',
+        remittanceInformationUnstructuredArray: [
+          'CREDITOR NAME',
+          'CREDITOR00BIC',
+          'CREDITOR000IBAN',
+          'DESCRIPTION',
+          'End-to-End-Ref.: NOTPROVIDED',
+          'Dauerauftrag',
+        ],
+        remittanceInformationStructured:
+          'CREDITOR NAME CREDITOR00BIC CREDITOR000IBAN DESCRIPTION End-to-End-Ref.: NOTPROVIDED Dauerauftrag',
+        internalTransactionId: 'f617dc31ab77622bf13d6c95d6dd8b4a',
+      };
+      const normalizedTransaction = CommerzbankCobadeff.normalizeTransaction(
+        transaction,
+        false,
+      );
+      expect(normalizedTransaction.notes).toEqual(
+        'CREDITOR00BIC CREDITOR000IBAN DESCRIPTION, Dauerauftrag',
+      );
+    });
+  });
+});

package/src/app-gocardless/banks/tests/easybank_bawaatww.spec.js

@@ -0,0 +1,54 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import EasybankBawaatww from '../easybank_bawaatww.js';
+
+describe('easybank', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the expected payeeName from a transaction with a set creditorName', () => {
+      const transaction = {
+        creditorName: 'Some Payee Name',
+        transactionAmount: mockTransactionAmount,
+        bookingDate: '2024-01-01',
+        creditorAccount: 'AT611904300234573201',
+      };
+
+      const normalizedTransaction = EasybankBawaatww.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.payeeName).toEqual('Some Payee Name');
+    });
+
+    it('returns the expected payeeName from a transaction with payee name inside structuredInformation', () => {
+      const transaction = {
+        payeeName: '',
+        transactionAmount: mockTransactionAmount,
+        remittanceInformationStructured:
+          'Bezahlung Karte MC/000001234POS 1234 K001 12.12. 23:59SOME PAYEE NAME\\\\LOCATION\\1',
+        bookingDate: '2023-12-31',
+      };
+      const normalizedTransaction = EasybankBawaatww.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual('Some Payee Name');
+    });
+
+    it('returns the full structured information as payeeName from a transaction with no payee name', () => {
+      const transaction = {
+        payeeName: '',
+        transactionAmount: mockTransactionAmount,
+        remittanceInformationStructured:
+          'Auszahlung Karte MC/000001234AUTOMAT 00012345 K001 31.12. 23:59',
+        bookingDate: '2023-12-31',
+      };
+      const normalizedTransaction = EasybankBawaatww.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual(
+        'Auszahlung Karte MC/000001234AUTOMAT 00012345 K001 31.12. 23:59',
+      );
+    });
+  });
+});