@actual-app/sync-server 25.4.0-alpha.0

package/src/app-gocardless/banks/tests/nationwide_naiagb21.spec.js

@@ -0,0 +1,105 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import Nationwide from '../nationwide_naiagb21.js';
+
+describe('Nationwide', () => {
+  describe('#normalizeTransaction', () => {
+    it('retains date for booked transaction', () => {
+      const d = new Date();
+      d.setDate(d.getDate() - 7);
+
+      const date = d.toISOString().split('T')[0];
+
+      const transaction = {
+        bookingDate: date,
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.date).toEqual(date);
+    });
+
+    it('fixes date for pending transactions', () => {
+      const d = new Date();
+      const date = d.toISOString().split('T')[0];
+
+      const transaction = {
+        bookingDate: date,
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(new Date(normalizedTransaction.date).getTime()).toBeLessThan(
+        d.getTime(),
+      );
+    });
+
+    it('keeps transactionId if in the correct format', () => {
+      const transactionId = 'a896729bb8b30b5ca862fe70bd5967185e2b5d3a';
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        transactionId,
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.transactionId).toBe(transactionId);
+    });
+
+    it('unsets transactionId if not valid length', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        transactionId: '0123456789',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.transactionId).toBeNull();
+    });
+
+    it('unsets transactionId if debit placeholder found', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        transactionId: '00DEBIT202401010000000000-1000SUPERMARKET',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.transactionId).toBeNull();
+    });
+
+    it('unsets transactionId if credit placeholder found', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        transactionId: '00CREDIT202401010000000000-1000SUPERMARKET',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Nationwide.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.transactionId).toBeNull();
+    });
+  });
+});

package/src/app-gocardless/banks/tests/nbg_ethngraaxxx.spec.js

@@ -0,0 +1,48 @@
+import NbgEthngraaxxx from '../nbg_ethngraaxxx.js';
+
+describe('NbgEthngraaxxx', () => {
+  describe('#normalizeTransaction', () => {
+    it('provides correct amount in pending transaction and removes payee prefix', () => {
+      const transaction = {
+        bookingDate: '2024-09-03',
+        date: '2024-09-03',
+        remittanceInformationUnstructured: 'ΑΓΟΡΑ testingson',
+        transactionAmount: {
+          amount: '100.00',
+          currency: 'EUR',
+        },
+        valueDate: '2024-09-03',
+      };
+
+      const normalizedTransaction = NbgEthngraaxxx.normalizeTransaction(
+        transaction,
+        false,
+      );
+
+      expect(normalizedTransaction.transactionAmount.amount).toEqual('-100.00');
+      expect(normalizedTransaction.payeeName).toEqual('Testingson');
+    });
+  });
+
+  it('provides correct amount and payee in booked transaction', () => {
+    const transaction = {
+      transactionId: 'O244015L68IK',
+      bookingDate: '2024-09-03',
+      date: '2024-09-03',
+      remittanceInformationUnstructured: 'testingson',
+      transactionAmount: {
+        amount: '-100.00',
+        currency: 'EUR',
+      },
+      valueDate: '2024-09-03',
+    };
+
+    const normalizedTransaction = NbgEthngraaxxx.normalizeTransaction(
+      transaction,
+      true,
+    );
+
+    expect(normalizedTransaction.transactionAmount.amount).toEqual('-100.00');
+    expect(normalizedTransaction.payeeName).toEqual('Testingson');
+  });
+});

package/src/app-gocardless/banks/tests/revolut_revolt21.spec.js

@@ -0,0 +1,42 @@
+import RevolutRevolt21 from '../revolut_revolt21.js';
+
+describe('RevolutRevolt21', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the expected remittanceInformationUnstructured from a bizum expense transfer', () => {
+      const transaction = {
+        transactionAmount: { amount: '-1.00', currency: 'EUR' },
+        remittanceInformationUnstructuredArray: [
+          'Bizum payment to: CREDITOR NAME',
+          'Bizum description',
+        ],
+        bookingDate: '2024-09-21',
+      };
+
+      const normalizedTransaction = RevolutRevolt21.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.notes).toEqual('Bizum description');
+    });
+  });
+
+  it('returns the expected payeeName and remittanceInformationUnstructured from a bizum income transfer', () => {
+    const transaction = {
+      transactionAmount: { amount: '1.00', currency: 'EUR' },
+      remittanceInformationUnstructuredArray: [
+        'Bizum payment from: DEBTOR NAME',
+        'Bizum description',
+      ],
+      bookingDate: '2024-09-21',
+    };
+
+    const normalizedTransaction = RevolutRevolt21.normalizeTransaction(
+      transaction,
+      true,
+    );
+
+    expect(normalizedTransaction.payeeName).toEqual('DEBTOR NAME');
+    expect(normalizedTransaction.notes).toEqual('Bizum description');
+  });
+});

package/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js

@@ -0,0 +1,133 @@
+import SandboxfinanceSfin0000 from '../sandboxfinance_sfin0000.js';
+
+describe('SandboxfinanceSfin0000', () => {
+  describe('#normalizeAccount', () => {
+    /** @type {import('../../gocardless.types.js').DetailedAccountWithInstitution} */
+    const accountRaw = {
+      resourceId: '01F3NS5ASCNMVCTEJDT0G215YE',
+      iban: 'GL0865354374424724',
+      currency: 'EUR',
+      ownerName: 'Jane Doe',
+      name: 'Main Account',
+      product: 'Checkings',
+      cashAccountType: 'CACC',
+      id: '99a0bfe2-0bef-46df-bff2-e9ae0c6c5838',
+      created: '2022-02-21T13:43:55.608911Z',
+      last_accessed: '2023-01-25T16:50:15.078264Z',
+      institution_id: 'SANDBOXFINANCE_SFIN0000',
+      status: 'READY',
+      owner_name: 'Jane Doe',
+      institution: {
+        id: 'SANDBOXFINANCE_SFIN0000',
+        name: 'Sandbox Finance',
+        bic: 'SFIN0000',
+        transaction_total_days: '90',
+        max_access_valid_for_days: '90',
+        countries: ['XX'],
+        logo: 'https://cdn.nordigen.com/ais/SANDBOXFINANCE_SFIN0000.png',
+        supported_payments: {},
+        supported_features: [],
+      },
+    };
+
+    it('returns normalized account data returned to Frontend', () => {
+      expect(SandboxfinanceSfin0000.normalizeAccount(accountRaw))
+        .toMatchInlineSnapshot(`
+        {
+          "account_id": "99a0bfe2-0bef-46df-bff2-e9ae0c6c5838",
+          "iban": "GL0865354374424724",
+          "institution": {
+            "bic": "SFIN0000",
+            "countries": [
+              "XX",
+            ],
+            "id": "SANDBOXFINANCE_SFIN0000",
+            "logo": "https://cdn.nordigen.com/ais/SANDBOXFINANCE_SFIN0000.png",
+            "max_access_valid_for_days": "90",
+            "name": "Sandbox Finance",
+            "supported_features": [],
+            "supported_payments": {},
+            "transaction_total_days": "90",
+          },
+          "mask": "4724",
+          "name": "Main Account (XXX 4724) EUR",
+          "official_name": "Checkings",
+          "type": "checking",
+        }
+      `);
+    });
+  });
+
+  describe('#sortTransactions', () => {
+    it('handles empty arrays', () => {
+      const transactions = [];
+      const sortedTransactions =
+        SandboxfinanceSfin0000.sortTransactions(transactions);
+      expect(sortedTransactions).toEqual([]);
+    });
+
+    it('returns empty array for undefined input', () => {
+      const sortedTransactions =
+        SandboxfinanceSfin0000.sortTransactions(undefined);
+      expect(sortedTransactions).toEqual([]);
+    });
+  });
+
+  describe('#countStartingBalance', () => {
+    /** @type {import('../../gocardless-node.types.js').Balance[]} */
+    const balances = [
+      {
+        balanceAmount: { amount: '1000.00', currency: 'PLN' },
+        balanceType: 'interimAvailable',
+      },
+    ];
+
+    it('should calculate the starting balance correctly', () => {
+      const sortedTransactions = [
+        {
+          transactionId: '2022-01-01-1',
+          transactionAmount: { amount: '-100.00', currency: 'USD' },
+        },
+        {
+          transactionId: '2022-01-01-2',
+          transactionAmount: { amount: '50.00', currency: 'USD' },
+        },
+        {
+          transactionId: '2022-01-01-3',
+          transactionAmount: { amount: '-25.00', currency: 'USD' },
+        },
+      ];
+
+      const startingBalance = SandboxfinanceSfin0000.calculateStartingBalance(
+        sortedTransactions,
+        balances,
+      );
+
+      expect(startingBalance).toEqual(107500);
+    });
+
+    it('returns the same balance amount when no transactions', () => {
+      const transactions = [];
+
+      expect(
+        SandboxfinanceSfin0000.calculateStartingBalance(transactions, balances),
+      ).toEqual(100000);
+    });
+
+    it('returns the balance minus the available transactions', () => {
+      /** @type {import('../../gocardless-node.types.js').Transaction[]} */
+      const transactions = [
+        {
+          transactionAmount: { amount: '200.00', currency: 'PLN' },
+        },
+        {
+          transactionAmount: { amount: '300.50', currency: 'PLN' },
+        },
+      ];
+
+      expect(
+        SandboxfinanceSfin0000.calculateStartingBalance(transactions, balances),
+      ).toEqual(49950);
+    });
+  });
+});

package/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js

@@ -0,0 +1,256 @@
+import SpkMarburgBiedenkopfHeladef1mar from '../spk_marburg_biedenkopf_heladef1mar.js';
+
+describe('SpkMarburgBiedenkopfHeladef1mar', () => {
+  describe('#normalizeAccount', () => {
+    /** @type {import('../../gocardless.types.js').DetailedAccountWithInstitution} */
+    const accountRaw = {
+      resourceId: 'e896eec6-6096-4efc-a941-756bd9d74765',
+      iban: 'DE50533500000123456789',
+      currency: 'EUR',
+      ownerName: 'JANE DOE',
+      product: 'Sichteinlagen',
+      bic: 'HELADEF1MAR',
+      usage: 'PRIV',
+      id: 'a787ba27-02ee-4fd6-be86-73831adc5498',
+      created: '2024-01-01T14:17:11.630352Z',
+      last_accessed: '2024-01-01T14:19:42.709478Z',
+      institution_id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
+      status: 'READY',
+      owner_name: 'JANE DOE',
+      institution: {
+        id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
+        name: 'Sparkasse Marburg-Biedenkopf',
+        bic: 'HELADEF1MAR',
+        transaction_total_days: '360',
+        max_access_valid_for_days: '90',
+        countries: ['DE'],
+        logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/sparkasse.png',
+        supported_payments: {
+          'single-payment': ['SCT', 'ISCT'],
+        },
+        supported_features: [
+          'card_accounts',
+          'payments',
+          'pending_transactions',
+        ],
+        /*"identification_codes": []*/
+      },
+    };
+
+    it('returns normalized account data returned to Frontend', () => {
+      expect(
+        SpkMarburgBiedenkopfHeladef1mar.normalizeAccount(accountRaw),
+      ).toEqual({
+        account_id: 'a787ba27-02ee-4fd6-be86-73831adc5498',
+        iban: 'DE50533500000123456789',
+        institution: {
+          bic: 'HELADEF1MAR',
+          countries: ['DE'],
+          id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
+          logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/sparkasse.png',
+          name: 'Sparkasse Marburg-Biedenkopf',
+          supported_features: [
+            'card_accounts',
+            'payments',
+            'pending_transactions',
+          ],
+          supported_payments: {
+            'single-payment': ['SCT', 'ISCT'],
+          },
+          transaction_total_days: '360',
+          max_access_valid_for_days: '90',
+        },
+        mask: '6789',
+        name: 'Sichteinlagen (XXX 6789) EUR',
+        official_name: 'Sichteinlagen',
+        type: 'checking',
+      });
+    });
+  });
+
+  const transactionsRaw = [
+    {
+      transactionId: 'fefa0b605ac14a7eb14f4c8ab6a6af55',
+      bookingDate: '2023-12-29',
+      valueDate: '2023-12-29',
+      transactionAmount: {
+        amount: '-40.00',
+        currency: 'EUR',
+      },
+      creditorName: 'JET Tankstelle',
+      remittanceInformationStructured: 'AUTORISATION  28.12. 18:30',
+      proprietaryBankTransactionCode: 'NSTO+000+0000+000-AA',
+      internalTransactionId: '761660c052ed48e78c2be39775f08da9',
+      date: '2023-12-29',
+    },
+    {
+      transactionId: '1a8e5d0df259472694f13132001af0a6',
+      bookingDate: '2023-12-28',
+      valueDate: '2023-12-28',
+      transactionAmount: {
+        amount: '-1242.47',
+        currency: 'EUR',
+      },
+      creditorName: 'Peter Muster',
+      remittanceInformationStructured: 'Miete 12/2023',
+      proprietaryBankTransactionCode: 'NSTO+111+1111+111-BB',
+      internalTransactionId: '5a20ac78b146401e940b6fee30ee404b',
+      date: '2023-12-28',
+    },
+    {
+      transactionId: '166983e65ec54000a361a952e6161f33',
+      bookingDate: '2023-12-27',
+      valueDate: '2023-12-27',
+      transactionAmount: {
+        amount: '1541.23',
+        currency: 'EUR',
+      },
+      debtorName: 'Arbeitgeber AG',
+      remittanceInformationStructured: 'Lohn/Gehalt 12/2023',
+      proprietaryBankTransactionCode: 'NSTO+222+2222+222-CC',
+      internalTransactionId: '51630dda877f45f186d315b8058d891a',
+      date: '2023-12-27',
+    },
+    {
+      transactionId: '4dd9f4c9968a45739c0705ebc675b54b',
+      bookingDate: '2023-12-26',
+      valueDate: '2023-12-26',
+      transactionAmount: {
+        amount: '-8.00',
+        currency: 'EUR',
+      },
+      remittanceInformationStructuredArray: [
+        'Entgeltabrechnung',
+        'siehe Anlage',
+      ],
+      proprietaryBankTransactionCode: 'NSTO+333+3333+333-DD',
+      internalTransactionId: '9c58c87c2d1644e4a5e149c837c16bbb',
+      date: '2023-12-26',
+    },
+  ];
+
+  describe('#normalizeTransaction', () => {
+    it('fallbacks to remittanceInformationStructured when remittanceInformationUnstructed is not set', () => {
+      const transaction = {
+        transactionId: 'fefa0b605ac14a7eb14f4c8ab6a6af55',
+        bookingDate: '2023-12-29',
+        valueDate: '2023-12-29',
+        transactionAmount: {
+          amount: '-40.00',
+          currency: 'EUR',
+        },
+        creditorName: 'JET Tankstelle',
+        remittanceInformationStructured: 'AUTORISATION  28.12. 18:30',
+        proprietaryBankTransactionCode: 'NSTO+000+0000+000-AA',
+        internalTransactionId: '761660c052ed48e78c2be39775f08da9',
+        date: '2023-12-29',
+      };
+
+      expect(
+        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true)
+          .notes,
+      ).toEqual('AUTORISATION  28.12. 18:30');
+    });
+
+    it('fallbacks to remittanceInformationStructuredArray when remittanceInformationUnstructed and remittanceInformationStructured is not set', () => {
+      const transaction = {
+        transactionId: '4dd9f4c9968a45739c0705ebc675b54b',
+        bookingDate: '2023-12-26',
+        valueDate: '2023-12-26',
+        transactionAmount: {
+          amount: '-8.00',
+          currency: 'EUR',
+        },
+        remittanceInformationStructuredArray: [
+          'Entgeltabrechnung',
+          'siehe Anlage',
+        ],
+        proprietaryBankTransactionCode: 'NSTO+333+3333+333-DD',
+        internalTransactionId: '9c58c87c2d1644e4a5e149c837c16bbb',
+        date: '2023-12-26',
+      };
+
+      expect(
+        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true)
+          .notes,
+      ).toEqual('Entgeltabrechnung siehe Anlage');
+    });
+  });
+
+  describe('#sortTransactions', () => {
+    it('handles empty arrays', () => {
+      const transactions = [];
+      const sortedTransactions =
+        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(transactions);
+      expect(sortedTransactions).toEqual([]);
+    });
+
+    it('returns empty array for undefined input', () => {
+      const sortedTransactions =
+        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(undefined);
+      expect(sortedTransactions).toEqual([]);
+    });
+
+    it('returns sorted array for unsorted inputs', () => {
+      const normalizeTransactions = transactionsRaw.map(tx =>
+        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(tx, true),
+      );
+      const originalOrder = Array.from(normalizeTransactions);
+      const swap = (a, b) => {
+        const swap = normalizeTransactions[a];
+        normalizeTransactions[a] = normalizeTransactions[b];
+        normalizeTransactions[b] = swap;
+      };
+      swap(1, 4);
+      swap(3, 6);
+      swap(0, 7);
+      const sortedTransactions =
+        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(normalizeTransactions);
+      expect(sortedTransactions).toEqual(originalOrder);
+    });
+  });
+
+  describe('#countStartingBalance', () => {
+    /** @type {import('../../gocardless-node.types.js').Balance[]} */
+    const balances = [
+      {
+        balanceAmount: { amount: '3596.87', currency: 'EUR' },
+        balanceType: 'closingBooked',
+        referenceDate: '2023-12-29',
+      },
+    ];
+
+    it('should return 0 when no transactions or balances are provided', () => {
+      const startingBalance =
+        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance([], []);
+      expect(startingBalance).toEqual(0);
+    });
+
+    it('should calculate the starting balance correctly', () => {
+      const normalizeTransactions = transactionsRaw.map(tx =>
+        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(tx, true),
+      );
+      const sortedTransactions =
+        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(normalizeTransactions);
+
+      const startingBalance =
+        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance(
+          sortedTransactions,
+          balances,
+        );
+
+      expect(startingBalance).toEqual(334611);
+    });
+
+    it('returns the same balance amount when no transactions', () => {
+      const transactions = [];
+
+      expect(
+        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance(
+          transactions,
+          balances,
+        ),
+      ).toEqual(359687);
+    });
+  });
+});

package/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js

@@ -0,0 +1,102 @@
+import { jest } from '@jest/globals';
+
+import SskDusseldorfDussdeddxxx from '../ssk_dusseldorf_dussdeddxxx.js';
+
+describe('ssk_dusseldorf_dussdeddxxx', () => {
+  let consoleSpy;
+
+  beforeEach(() => {
+    consoleSpy = jest.spyOn(console, 'debug');
+  });
+
+  afterEach(() => {
+    consoleSpy.mockRestore();
+  });
+
+  describe('#normalizeTransaction', () => {
+    const bookedTransactionOne = {
+      transactionId: '2024102900000000-1',
+      bookingDate: '2024-10-29',
+      valueDate: '2024-10-29',
+      transactionAmount: {
+        amount: '-99.99',
+        currency: 'EUR',
+      },
+      creditorName: 'a useful creditor name',
+      remittanceInformationStructured: 'structured information',
+      remittanceInformationUnstructured: 'unstructured information',
+      additionalInformation: 'some additional information',
+    };
+
+    const bookedTransactionTwo = {
+      transactionId: '2024102900000000-2',
+      bookingDate: '2024-10-29',
+      valueDate: '2024-10-29',
+      transactionAmount: {
+        amount: '-99.99',
+        currency: 'EUR',
+      },
+      creditorName: 'a useful creditor name',
+      ultimateCreditor: 'ultimate creditor',
+      remittanceInformationStructured: 'structured information',
+      additionalInformation: 'some additional information',
+    };
+
+    it('properly combines remittance information', () => {
+      expect(
+        SskDusseldorfDussdeddxxx.normalizeTransaction(
+          bookedTransactionOne,
+          true,
+        ).notes,
+      ).toEqual('unstructured information some additional information');
+
+      expect(
+        SskDusseldorfDussdeddxxx.normalizeTransaction(
+          bookedTransactionTwo,
+          true,
+        ).notes,
+      ).toEqual('structured information some additional information');
+    });
+
+    it('prioritizes creditor names correctly', () => {
+      expect(
+        SskDusseldorfDussdeddxxx.normalizeTransaction(
+          bookedTransactionOne,
+          true,
+        ).payeeName,
+      ).toEqual('A Useful Creditor Name');
+
+      expect(
+        SskDusseldorfDussdeddxxx.normalizeTransaction(
+          bookedTransactionTwo,
+          true,
+        ).payeeName,
+      ).toEqual('Ultimate Creditor');
+    });
+
+    const unbookedTransaction = {
+      transactionId: '2024102900000000-1',
+      valueDate: '2024-10-29',
+      transactionAmount: {
+        amount: '-99.99',
+        currency: 'EUR',
+      },
+      creditorName: 'some nonsensical creditor',
+      remittanceInformationUnstructured: 'some nonsensical information',
+    };
+
+    it('returns null for unbooked transactions', () => {
+      expect(
+        SskDusseldorfDussdeddxxx.normalizeTransaction(
+          unbookedTransaction,
+          false,
+        ),
+      ).toBeNull();
+
+      expect(consoleSpy).toHaveBeenCalledWith(
+        'Skipping unbooked transaction:',
+        unbookedTransaction.transactionId,
+      );
+    });
+  });
+});