@actual-app/sync-server 25.4.0-alpha.0

package/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js

@@ -0,0 +1,57 @@
+import SwedbankHabaLV22 from '../swedbank_habalv22.js';
+
+describe('#normalizeTransaction', () => {
+  const bookedCardTransaction = {
+    transactionId: '2024102900000000-1',
+    bookingDate: '2024-10-29',
+    valueDate: '2024-10-29',
+    transactionAmount: {
+      amount: '-22.99',
+      currency: 'EUR',
+    },
+    creditorName: 'SOME CREDITOR NAME',
+    remittanceInformationUnstructured:
+      'PIRKUMS 424242******4242 28.10.2024 22.99 EUR (111111) SOME CREDITOR NAME',
+    bankTransactionCode: 'PMNT-CCRD-POSD',
+    internalTransactionId: 'fa000f86afb2cc7678bcff0000000000',
+  };
+
+  it('extracts card transaction date', () => {
+    expect(
+      SwedbankHabaLV22.normalizeTransaction(bookedCardTransaction, true).date,
+    ).toEqual('2024-10-28');
+  });
+
+  it.each([
+    ['regular text', 'Some info'],
+    ['partial card text', 'PIRKUMS xxx'],
+    ['null value', null],
+  ])('normalizes non-card transaction with %s', (_, remittanceInfo) => {
+    const transaction = {
+      ...bookedCardTransaction,
+      remittanceInformationUnstructured: remittanceInfo,
+    };
+    const normalized = SwedbankHabaLV22.normalizeTransaction(transaction, true);
+
+    expect(normalized.bookingDate).toEqual('2024-10-29');
+    expect(normalized.date).toEqual('2024-10-29');
+  });
+
+  const pendingCardTransaction = {
+    transactionId: '2024102900000000-1',
+    valueDate: '2024-10-29',
+    transactionAmount: {
+      amount: '-22.99',
+      currency: 'EUR',
+    },
+    remittanceInformationUnstructured:
+      'PIRKUMS 424242******4242 28.10.24 13:37 22.99 EUR (111111) SOME CREDITOR NAME',
+  };
+
+  it('extracts pending card transaction creditor name', () => {
+    expect(
+      SwedbankHabaLV22.normalizeTransaction(pendingCardTransaction, false)
+        .payeeName,
+    ).toEqual('Some Creditor Name');
+  });
+});

package/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js

@@ -0,0 +1,54 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import Virgin from '../virgin_nrnbgb22.js';
+
+describe('Virgin', () => {
+  describe('#normalizeTransaction', () => {
+    it('does not alter simple payee information', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        remittanceInformationUnstructured: 'DIRECT DEBIT PAYMENT',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Virgin.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.payeeName).toEqual('Direct Debit Payment');
+      expect(normalizedTransaction.notes).toEqual('DIRECT DEBIT PAYMENT');
+    });
+
+    it('formats bank transfer payee and references', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        remittanceInformationUnstructured: 'FPS, Joe Bloggs, Food',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Virgin.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.payeeName).toEqual('Joe Bloggs');
+      expect(normalizedTransaction.notes).toEqual('Food');
+    });
+
+    it('removes method information from payee name', () => {
+      const transaction = {
+        bookingDate: '2024-01-01T00:00:00Z',
+        remittanceInformationUnstructured: 'Card 99, Tesco Express',
+        transactionAmount: mockTransactionAmount,
+      };
+
+      const normalizedTransaction = Virgin.normalizeTransaction(
+        transaction,
+        true,
+      );
+
+      expect(normalizedTransaction.payeeName).toEqual('Tesco Express');
+      expect(normalizedTransaction.notes).toEqual('Card 99, Tesco Express');
+    });
+  });
+});

package/src/app-gocardless/banks/util/extract-payeeName-from-remittanceInfo.js

@@ -0,0 +1,36 @@
+/**
+/**
+ * Extracts the payee name from the unstructured remittance information string based on pattern detection.
+ *
+ * This function scans the `remittanceInformationUnstructured` string for the presence of
+ * any of the specified patterns and removes the substring from the position of the last
+ * occurrence of the most relevant pattern. If no patterns are found, it returns the original string.
+ *
+ * @param {string} [remittanceInformationUnstructured=''] - The unstructured remittance information from which to extract the payee name.
+ * @param {string[]} [patterns=[]] - An array of patterns to look for within the remittance information.
+ *                                   These patterns are used to identify and remove unwanted parts of the remittance information.
+ * @returns {string} - The extracted payee name, cleaned of any matched patterns, or the original
+ *                     remittance information if no patterns are found.
+ *
+ * @example
+ * const remittanceInfo = 'John Doe Paiement Maestro par Carte de débit CBC 05-09-2024 à 15.43 heures 6703 19XX XXXX X...';
+ * const patterns = ['Paiement', 'Domiciliation', 'Transfert', 'Ordre permanent'];
+ * const payeeName = extractPayeeNameFromRemittanceInfo(remittanceInfo, patterns); // --> 'John Doe'
+ */
+export function extractPayeeNameFromRemittanceInfo(
+  remittanceInformationUnstructured,
+  patterns,
+) {
+  if (!remittanceInformationUnstructured || !patterns.length) {
+    return remittanceInformationUnstructured;
+  }
+
+  const indexForRemoval = patterns.reduce((maxIndex, pattern) => {
+    const index = remittanceInformationUnstructured.lastIndexOf(pattern);
+    return index > maxIndex ? index : maxIndex;
+  }, -1);
+
+  return indexForRemoval > -1
+    ? remittanceInformationUnstructured.substring(0, indexForRemoval).trim()
+    : remittanceInformationUnstructured;
+}

package/src/app-gocardless/banks/virgin_nrnbgb22.js

@@ -0,0 +1,39 @@
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['VIRGIN_NRNBGB22'],
+
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    const transferPrefixes = ['MOB', 'FPS'];
+    const methodRegex = /^(Card|WLT)\s\d+/;
+
+    const parts = transaction.remittanceInformationUnstructured.split(', ');
+
+    if (transferPrefixes.includes(parts[0])) {
+      // Transfer remittance information begins with either "MOB" or "FPS"
+      // the second field contains the payee and the third contains the
+      // reference
+
+      editedTrans.creditorName = parts[1];
+      editedTrans.debtorName = parts[1];
+      editedTrans.remittanceInformationUnstructured = parts[2];
+    } else if (parts[0].match(methodRegex)) {
+      // The payee is prefixed with the payment method, eg "Card 11, {payee}"
+
+      editedTrans.creditorName = parts[1];
+      editedTrans.debtorName = parts[1];
+    } else {
+      // Simple payee name
+
+      editedTrans.creditorName = transaction.remittanceInformationUnstructured;
+      editedTrans.debtorName = transaction.remittanceInformationUnstructured;
+    }
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

package/src/app-gocardless/errors.js

@@ -0,0 +1,84 @@
+export class RequisitionNotLinked extends Error {
+  constructor(params = {}) {
+    super('Requisition not linked yet');
+    this.details = params;
+  }
+}
+
+export class AccountNotLinkedToRequisition extends Error {
+  constructor(accountId, requisitionId) {
+    super('Provided account id is not linked to given requisition');
+    this.details = {
+      accountId,
+      requisitionId,
+    };
+  }
+}
+
+export class GenericGoCardlessError extends Error {
+  constructor(data = {}) {
+    super('GoCardless returned error');
+    this.details = data;
+  }
+}
+
+export class GoCardlessClientError extends Error {
+  constructor(message, details) {
+    super(message);
+    this.details = details;
+  }
+}
+
+export class InvalidInputDataError extends GoCardlessClientError {
+  constructor(response) {
+    super('Invalid provided parameters', response);
+  }
+}
+
+export class InvalidGoCardlessTokenError extends GoCardlessClientError {
+  constructor(response) {
+    super('Token is invalid or expired', response);
+  }
+}
+
+export class AccessDeniedError extends GoCardlessClientError {
+  constructor(response) {
+    super('IP address access denied', response);
+  }
+}
+
+export class NotFoundError extends GoCardlessClientError {
+  constructor(response) {
+    super('Resource not found', response);
+  }
+}
+
+export class ResourceSuspended extends GoCardlessClientError {
+  constructor(response) {
+    super(
+      'Resource was suspended due to numerous errors that occurred while accessing it',
+      response,
+    );
+  }
+}
+
+export class RateLimitError extends GoCardlessClientError {
+  constructor(response) {
+    super(
+      'Daily request limit set by the Institution has been exceeded',
+      response,
+    );
+  }
+}
+
+export class UnknownError extends GoCardlessClientError {
+  constructor(response) {
+    super('Request to Institution returned an error', response);
+  }
+}
+
+export class ServiceError extends GoCardlessClientError {
+  constructor(response) {
+    super('Institution service unavailable', response);
+  }
+}