@actual-app/sync-server 25.4.0-alpha.0

package/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js

@@ -0,0 +1,202 @@
+import { mockTransactionAmount } from '../../services/tests/fixtures.js';
+import IngPlIngbplpw from '../ing_pl_ingbplpw.js';
+
+describe('IngPlIngbplpw', () => {
+  describe('#normalizeAccount', () => {
+    /** @type {import('../../gocardless.types.js').DetailedAccountWithInstitution} */
+    const accountRaw = {
+      resourceId: 'PL00000000000000000987654321',
+      iban: 'PL00000000000000000987654321',
+      currency: 'PLN',
+      ownerName: 'John Example',
+      product: 'Current Account for Individuals (Retail)',
+      bic: 'INGBPLPW',
+      ownerAddressUnstructured: [
+        'UL. EXAMPLE STREET 10 M.1',
+        '00-000 WARSZAWA',
+      ],
+      id: 'd3eccc94-9536-48d3-98be-813f79199ee3',
+      created: '2022-07-24T20:45:47.929582Z',
+      last_accessed: '2023-01-24T22:12:00.193558Z',
+      institution_id: 'ING_PL_INGBPLPW',
+      status: 'READY',
+      owner_name: '',
+      institution: {
+        id: 'ING_PL_INGBPLPW',
+        name: 'ING',
+        bic: 'INGBPLPW',
+        transaction_total_days: '365',
+        max_access_valid_for_days: '90',
+        countries: ['PL'],
+        logo: 'https://cdn.nordigen.com/ais/ING_PL_INGBPLPW.png',
+        supported_payments: {},
+        supported_features: [
+          'access_scopes',
+          'business_accounts',
+          'card_accounts',
+          'corporate_accounts',
+          'pending_transactions',
+          'private_accounts',
+        ],
+      },
+    };
+
+    it('returns normalized account data returned to Frontend', () => {
+      const normalizedAccount = IngPlIngbplpw.normalizeAccount(accountRaw);
+      expect(normalizedAccount).toMatchInlineSnapshot(`
+        {
+          "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
+          "iban": "PL00000000000000000987654321",
+          "institution": {
+            "bic": "INGBPLPW",
+            "countries": [
+              "PL",
+            ],
+            "id": "ING_PL_INGBPLPW",
+            "logo": "https://cdn.nordigen.com/ais/ING_PL_INGBPLPW.png",
+            "max_access_valid_for_days": "90",
+            "name": "ING",
+            "supported_features": [
+              "access_scopes",
+              "business_accounts",
+              "card_accounts",
+              "corporate_accounts",
+              "pending_transactions",
+              "private_accounts",
+            ],
+            "supported_payments": {},
+            "transaction_total_days": "365",
+          },
+          "mask": "4321",
+          "name": "Current Account for Individuals (Retail) (XXX 4321) PLN",
+          "official_name": "Current Account for Individuals (Retail)",
+          "type": "checking",
+        }
+      `);
+    });
+  });
+
+  describe('#sortTransactions', () => {
+    it('sorts transactions by time and sequence from newest to oldest', () => {
+      const transactions = [
+        {
+          transactionId: 'D202301180000003',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301180000004',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301230000001',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301180000002',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301200000001',
+          transactionAmount: mockTransactionAmount,
+        },
+      ];
+      const sortedTransactions = IngPlIngbplpw.sortTransactions(transactions);
+      expect(sortedTransactions).toEqual([
+        {
+          transactionId: 'D202301230000001',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301200000001',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301180000004',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301180000003',
+          transactionAmount: mockTransactionAmount,
+        },
+        {
+          transactionId: 'D202301180000002',
+          transactionAmount: mockTransactionAmount,
+        },
+      ]);
+    });
+
+    it('handles empty arrays', () => {
+      const transactions = [];
+      const sortedTransactions = IngPlIngbplpw.sortTransactions(transactions);
+      expect(sortedTransactions).toEqual([]);
+    });
+
+    it('returns empty array for undefined input', () => {
+      const sortedTransactions = IngPlIngbplpw.sortTransactions(undefined);
+      expect(sortedTransactions).toEqual([]);
+    });
+  });
+
+  describe('#countStartingBalance', () => {
+    it('should calculate the starting balance correctly', () => {
+      /** @type {import('../../gocardless-node.types.js').Transaction[]} */
+      const sortedTransactions = [
+        {
+          transactionAmount: { amount: '-100.00', currency: 'USD' },
+          balanceAfterTransaction: {
+            balanceAmount: { amount: '400.00', currency: 'USD' },
+            balanceType: 'interimBooked',
+          },
+        },
+        {
+          transactionAmount: { amount: '50.00', currency: 'USD' },
+          balanceAfterTransaction: {
+            balanceAmount: { amount: '450.00', currency: 'USD' },
+            balanceType: 'interimBooked',
+          },
+        },
+        {
+          transactionAmount: { amount: '-25.00', currency: 'USD' },
+          balanceAfterTransaction: {
+            balanceAmount: { amount: '475.00', currency: 'USD' },
+            balanceType: 'interimBooked',
+          },
+        },
+      ];
+
+      /** @type {import('../../gocardless-node.types.js').Balance[]} */
+      const balances = [
+        {
+          balanceType: 'interimBooked',
+          balanceAmount: { amount: '500.00', currency: 'USD' },
+        },
+        {
+          balanceType: 'closingBooked',
+          balanceAmount: { amount: '600.00', currency: 'USD' },
+        },
+      ];
+
+      const startingBalance = IngPlIngbplpw.calculateStartingBalance(
+        sortedTransactions,
+        balances,
+      );
+
+      expect(startingBalance).toEqual(50000);
+    });
+
+    it('returns the same balance amount when no transactions', () => {
+      const transactions = [];
+
+      /** @type {import('../../gocardless-node.types.js').Balance[]} */
+      const balances = [
+        {
+          balanceType: 'interimBooked',
+          balanceAmount: { amount: '500.00', currency: 'USD' },
+        },
+      ];
+      expect(
+        IngPlIngbplpw.calculateStartingBalance(transactions, balances),
+      ).toEqual(50000);
+    });
+  });
+});

package/src/app-gocardless/banks/tests/integration_bank.spec.js

@@ -0,0 +1,158 @@
+import { jest } from '@jest/globals';
+
+import {
+  mockExtendAccountsAboutInstitutions,
+  mockInstitution,
+} from '../../services/tests/fixtures.js';
+import IntegrationBank from '../integration-bank.js';
+
+describe('IntegrationBank', () => {
+  let consoleSpy;
+
+  beforeEach(() => {
+    consoleSpy = jest.spyOn(console, 'debug');
+  });
+
+  describe('normalizeAccount', () => {
+    const account = mockExtendAccountsAboutInstitutions[0];
+
+    it('should return a normalized account object', () => {
+      const normalizedAccount = IntegrationBank.normalizeAccount(account);
+      expect(normalizedAccount).toEqual({
+        account_id: account.id,
+        institution: mockInstitution,
+        mask: '4321',
+        iban: account.iban,
+        name: 'account-example-one (XXX 4321) PLN',
+        official_name: 'Savings Account for Individuals (Retail)',
+        type: 'checking',
+      });
+    });
+
+    it('should return a normalized account object with masked value "0000" when no iban property is provided', () => {
+      const normalizedAccount = IntegrationBank.normalizeAccount({
+        ...account,
+        iban: undefined,
+      });
+      expect(normalizedAccount).toEqual({
+        account_id: account.id,
+        institution: mockInstitution,
+        mask: '0000',
+        iban: null,
+        name: 'account-example-one PLN',
+        official_name: 'Savings Account for Individuals (Retail)',
+        type: 'checking',
+      });
+    });
+
+    it('normalizeAccount logs available account properties', () => {
+      IntegrationBank.normalizeAccount(account);
+      expect(consoleSpy).toHaveBeenCalledWith(
+        'Available account properties for new institution integration',
+        {
+          account: JSON.stringify(account),
+        },
+      );
+    });
+  });
+
+  describe('sortTransactions', () => {
+    const transactions = [
+      {
+        date: '2022-01-01',
+        bookingDate: '2022-01-01',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        date: '2022-01-03',
+        bookingDate: '2022-01-03',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        date: '2022-01-02',
+        bookingDate: '2022-01-02',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+    ];
+    const sortedTransactions = [
+      {
+        date: '2022-01-03',
+        bookingDate: '2022-01-03',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        date: '2022-01-02',
+        bookingDate: '2022-01-02',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        date: '2022-01-01',
+        bookingDate: '2022-01-01',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+    ];
+
+    it('should return transactions sorted by bookingDate', () => {
+      const sortedTransactions = IntegrationBank.sortTransactions(transactions);
+      expect(sortedTransactions).toEqual(sortedTransactions);
+    });
+
+    it('sortTransactions logs available transactions properties', () => {
+      IntegrationBank.sortTransactions(transactions);
+      expect(consoleSpy).toHaveBeenCalledWith(
+        'Available (first 10) transactions properties for new integration of institution in sortTransactions function',
+        { top10Transactions: JSON.stringify(sortedTransactions.slice(0, 10)) },
+      );
+    });
+  });
+
+  describe('calculateStartingBalance', () => {
+    /** @type {import('../../gocardless-node.types.js').Transaction[]} */
+    const transactions = [
+      {
+        bookingDate: '2022-01-01',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        bookingDate: '2022-02-01',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+      {
+        bookingDate: '2022-03-01',
+        transactionAmount: { amount: '100', currency: 'EUR' },
+      },
+    ];
+
+    /** @type {import('../../gocardless-node.types.js').Balance[]} */
+    const balances = [
+      {
+        balanceAmount: { amount: '1000.00', currency: 'EUR' },
+        balanceType: 'interimBooked',
+      },
+    ];
+
+    it('should return 0 when no transactions or balances are provided', () => {
+      const startingBalance = IntegrationBank.calculateStartingBalance([], []);
+      expect(startingBalance).toEqual(0);
+    });
+
+    it('should return 70000 when transactions and balances are provided', () => {
+      const startingBalance = IntegrationBank.calculateStartingBalance(
+        transactions,
+        balances,
+      );
+      expect(startingBalance).toEqual(70000);
+    });
+
+    it('logs available transactions and balances properties', () => {
+      IntegrationBank.calculateStartingBalance(transactions, balances);
+      expect(consoleSpy).toHaveBeenCalledWith(
+        'Available (first 10) transactions properties for new integration of institution in calculateStartingBalance function',
+        {
+          balances: JSON.stringify(balances),
+          top10SortedTransactions: JSON.stringify(transactions.slice(0, 10)),
+        },
+      );
+    });
+  });
+});

package/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js

@@ -0,0 +1,38 @@
+import KBCkredbebb from '../kbc_kredbebb.js';
+
+describe('kbc_kredbebb', () => {
+  describe('#normalizeTransaction', () => {
+    it('returns the remittanceInformationUnstructured as payeeName when the amount is negative', () => {
+      const transaction = {
+        remittanceInformationUnstructured:
+          'CARREFOUR ST GIL BE1060 BRUXELLES Betaling met Google Pay via Debit Mastercard 28-08-2024 om 19.15 uur 5127 04XX XXXX 1637 5853 98XX XXXX 2266 JOHN SMITH',
+        transactionAmount: { amount: '-10.99', currency: 'EUR' },
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = KBCkredbebb.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual(
+        'CARREFOUR ST GIL BE1060 BRUXELLES',
+      );
+    });
+
+    it('returns the debtorName as payeeName when the amount is positive', () => {
+      const transaction = {
+        debtorName: 'CARREFOUR ST GIL BE1060 BRUXELLES',
+        remittanceInformationUnstructured:
+          'CARREFOUR ST GIL BE1060 BRUXELLES Betaling met Google Pay via Debit Mastercard 28-08-2024 om 19.15 uur 5127 04XX XXXX 1637 5853 98XX XXXX 2266 JOHN SMITH',
+        transactionAmount: { amount: '10.99', currency: 'EUR' },
+        date: new Date().toISOString(),
+      };
+      const normalizedTransaction = KBCkredbebb.normalizeTransaction(
+        transaction,
+        true,
+      );
+      expect(normalizedTransaction.payeeName).toEqual(
+        'CARREFOUR ST GIL BE1060 BRUXELLES',
+      );
+    });
+  });
+});

package/src/app-gocardless/banks/tests/lhv-lhvbee22.spec.js

@@ -0,0 +1,68 @@
+import LhvLhvbee22 from '../lhv-lhvbee22.js';
+
+describe('#normalizeTransaction', () => {
+  const bookedCardTransaction = {
+    transactionId: '2025010300000000-1',
+    bookingDate: '2025-01-03',
+    valueDate: '2025-01-03',
+    transactionAmount: {
+      amount: '-22.99',
+      currency: 'EUR',
+    },
+    creditorName: null,
+    remittanceInformationUnstructured:
+      '(..1234) 2025-01-02 09:32 CrustumOU\\Poordi 3\\Tallinn\\10156     ESTEST',
+    bankTransactionCode: 'PMNT-CCRD-POSD',
+    internalTransactionId: 'fa000f86afb2cc7678bcff0000000000',
+  };
+
+  it('extracts booked card transaction creditor name', () => {
+    expect(
+      LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true).payeeName,
+    ).toEqual('CrustumOU');
+  });
+
+  it('extracts booked card transaction date', () => {
+    expect(
+      LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true).date,
+    ).toEqual('2025-01-02');
+  });
+
+  it.each([
+    ['regular text', 'Some info'],
+    ['partial card text', 'PIRKUMS xxx'],
+    ['null value', null],
+    ['invalid date', '(..1234) 2025-13-45 09:32 Merchant\\Address'],
+  ])('normalizes non-card transaction with %s', (_, remittanceInfo) => {
+    const transaction = {
+      ...bookedCardTransaction,
+      remittanceInformationUnstructured: remittanceInfo,
+    };
+    const normalized = LhvLhvbee22.normalizeTransaction(transaction, true);
+
+    expect(normalized.date).toEqual('2025-01-03');
+  });
+
+  const pendingCardTransaction = {
+    transactionId: '2025010300000000-1',
+    valueDate: '2025-01-03',
+    transactionAmount: {
+      amount: '-22.99',
+      currency: 'EUR',
+    },
+    remittanceInformationUnstructured:
+      '(..1234) 2025-01-02 09:32 CrustumOU\\Poordi 3\\Tallinn\\10156     ESTEST',
+  };
+
+  it('extracts pending card transaction creditor name', () => {
+    expect(
+      LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false).payeeName,
+    ).toEqual('CrustumOU');
+  });
+
+  it('extracts pending card transaction date', () => {
+    expect(
+      LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false).date,
+    ).toEqual('2025-01-03');
+  });
+});

package/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js

@@ -0,0 +1,171 @@
+import MbankRetailBrexplpw from '../mbank_retail_brexplpw.js';
+
+describe('MbankRetailBrexplpw', () => {
+  describe('#normalizeAccount', () => {
+    /** @type {import('../../gocardless.types.js').DetailedAccountWithInstitution} */
+    const accountRaw = {
+      iban: 'PL00000000000000000987654321',
+      currency: 'PLN',
+      ownerName: 'John Example',
+      displayName: 'EKONTO',
+      product: 'RACHUNEK BIEŻĄCY',
+      usage: 'PRIV',
+      ownerAddressUnstructured: [
+        'POL',
+        'UL. EXAMPLE STREET 10 M.1',
+        '00-000 WARSZAWA',
+      ],
+      id: 'd3eccc94-9536-48d3-98be-813f79199ee3',
+      created: '2023-01-18T13:24:55.879512Z',
+      last_accessed: null,
+      institution_id: 'MBANK_RETAIL_BREXPLPW',
+      status: 'READY',
+      owner_name: '',
+      institution: {
+        id: 'MBANK_RETAIL_BREXPLPW',
+        name: 'mBank Retail',
+        bic: 'BREXPLPW',
+        transaction_total_days: '90',
+        max_access_valid_for_days: '90',
+        countries: ['PL'],
+        logo: 'https://cdn.nordigen.com/ais/MBANK_RETAIL_BREXCZPP.png',
+        supported_payments: {},
+        supported_features: [
+          'access_scopes',
+          'business_accounts',
+          'card_accounts',
+          'corporate_accounts',
+          'pending_transactions',
+          'private_accounts',
+        ],
+      },
+    };
+    it('returns normalized account data returned to Frontend', () => {
+      expect(MbankRetailBrexplpw.normalizeAccount(accountRaw))
+        .toMatchInlineSnapshot(`
+        {
+          "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
+          "iban": "PL00000000000000000987654321",
+          "institution": {
+            "bic": "BREXPLPW",
+            "countries": [
+              "PL",
+            ],
+            "id": "MBANK_RETAIL_BREXPLPW",
+            "logo": "https://cdn.nordigen.com/ais/MBANK_RETAIL_BREXCZPP.png",
+            "max_access_valid_for_days": "90",
+            "name": "mBank Retail",
+            "supported_features": [
+              "access_scopes",
+              "business_accounts",
+              "card_accounts",
+              "corporate_accounts",
+              "pending_transactions",
+              "private_accounts",
+            ],
+            "supported_payments": {},
+            "transaction_total_days": "90",
+          },
+          "mask": "4321",
+          "name": "EKONTO (XXX 4321) PLN",
+          "official_name": "RACHUNEK BIEŻĄCY",
+          "type": "checking",
+        }
+      `);
+    });
+  });
+
+  describe('#sortTransactions', () => {
+    it('returns transactions from newest to oldest', () => {
+      const sortedTransactions = MbankRetailBrexplpw.sortTransactions([
+        {
+          transactionId: '202212300001',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300003',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300002',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300000',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202112300001',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+      ]);
+
+      expect(sortedTransactions).toEqual([
+        {
+          transactionId: '202212300003',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300002',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300001',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202212300000',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+        {
+          transactionId: '202112300001',
+          transactionAmount: { amount: '100', currency: 'EUR' },
+        },
+      ]);
+    });
+
+    it('returns empty array for empty input', () => {
+      const sortedTransactions = MbankRetailBrexplpw.sortTransactions([]);
+      expect(sortedTransactions).toEqual([]);
+    });
+
+    it('returns empty array for undefined input', () => {
+      const sortedTransactions =
+        MbankRetailBrexplpw.sortTransactions(undefined);
+      expect(sortedTransactions).toEqual([]);
+    });
+  });
+
+  describe('#countStartingBalance', () => {
+    /** @type {import('../../gocardless-node.types.js').Balance[]} */
+    const balances = [
+      {
+        balanceAmount: { amount: '1000.00', currency: 'PLN' },
+        balanceType: 'interimBooked',
+      },
+    ];
+
+    it('returns the same balance amount when no transactions', () => {
+      const transactions = [];
+
+      expect(
+        MbankRetailBrexplpw.calculateStartingBalance(transactions, balances),
+      ).toEqual(100000);
+    });
+
+    it('returns the balance minus the available transactions', () => {
+      const transactions = [
+        {
+          transactionAmount: { amount: '200.00', currency: 'PLN' },
+        },
+        {
+          transactionAmount: { amount: '300.50', currency: 'PLN' },
+        },
+      ];
+
+      expect(
+        MbankRetailBrexplpw.calculateStartingBalance(transactions, balances),
+      ).toEqual(49950);
+    });
+  });
+});