tcell_agent 0.4.0 → 1.0.0

data/spec/lib/tcell_agent/rails/routes/grape_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 module TCellAgent
   module Instrumentation
-
     # Fake out grape gem
     module Grape
       class API
@@ -15,14 +14,14 @@ module TCellAgent
     class RegularRoute
     end
 
-    describe ".grape_route?" do
-      context "rails 3" do
-        context "with a regular route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 3)
-            stub_const("::Rails::VERSION::MINOR", 0)
+    describe '.grape_route?' do
+      context 'rails 3' do
+        context 'with a regular route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 3)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: RegularRoute.new)
+            route = double('route', :app => RegularRoute.new)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -30,12 +29,12 @@ module TCellAgent
           end
         end
 
-        context "with a grape route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 3)
-            stub_const("::Rails::VERSION::MINOR", 0)
+        context 'with a grape route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 3)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: GrapeRoute)
+            route = double('route', :app => GrapeRoute)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -44,13 +43,13 @@ module TCellAgent
         end
       end
 
-      context "rails 4.0" do
-        context "with a regular route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 0)
+      context 'rails 4.0' do
+        context 'with a regular route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: RegularRoute.new)
+            route = double('route', :app => RegularRoute.new)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -58,12 +57,12 @@ module TCellAgent
           end
         end
 
-        context "with a grape route" do
-          it "should return true" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 0)
+        context 'with a grape route' do
+          it 'should return true' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: GrapeRoute)
+            route = double('route', :app => GrapeRoute)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -72,13 +71,13 @@ module TCellAgent
         end
       end
 
-      context "rails 4.1" do
-        context "with a regular route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 1)
+      context 'rails 4.1' do
+        context 'with a regular route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 1)
 
-            route = double("route", app: RegularRoute.new)
+            route = double('route', :app => RegularRoute.new)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -86,12 +85,12 @@ module TCellAgent
           end
         end
 
-        context "with a grape route" do
-          it "should return true" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 1)
+        context 'with a grape route' do
+          it 'should return true' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 1)
 
-            route = double("route", app: GrapeRoute)
+            route = double('route', :app => GrapeRoute)
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -100,13 +99,13 @@ module TCellAgent
         end
       end
 
-      context "rails 4.2" do
-        context "with a regular route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 2)
+      context 'rails 4.2' do
+        context 'with a regular route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 2)
 
-            route = double("route", app: double("app", app: RegularRoute.new))
+            route = double('route', :app => double('app', :app => RegularRoute.new))
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -114,12 +113,12 @@ module TCellAgent
           end
         end
 
-        context "with a grape route" do
-          it "should return true" do
-            stub_const("::Rails::VERSION::MAJOR", 4)
-            stub_const("::Rails::VERSION::MINOR", 2)
+        context 'with a grape route' do
+          it 'should return true' do
+            stub_const('::Rails::VERSION::MAJOR', 4)
+            stub_const('::Rails::VERSION::MINOR', 2)
 
-            route = double("route", app: double("app", app: GrapeRoute))
+            route = double('route', :app => double('app', :app => GrapeRoute))
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -128,13 +127,13 @@ module TCellAgent
         end
       end
 
-      context "rails 5.0" do
-        context "with a regular route" do
-          it "should return false" do
-            stub_const("::Rails::VERSION::MAJOR", 5)
-            stub_const("::Rails::VERSION::MINOR", 0)
+      context 'rails 5.0' do
+        context 'with a regular route' do
+          it 'should return false' do
+            stub_const('::Rails::VERSION::MAJOR', 5)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: double("app", app: RegularRoute.new))
+            route = double('route', :app => double('app', :app => RegularRoute.new))
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -142,12 +141,12 @@ module TCellAgent
           end
         end
 
-        context "with a grape route" do
-          it "should return true" do
-            stub_const("::Rails::VERSION::MAJOR", 5)
-            stub_const("::Rails::VERSION::MINOR", 0)
+        context 'with a grape route' do
+          it 'should return true' do
+            stub_const('::Rails::VERSION::MAJOR', 5)
+            stub_const('::Rails::VERSION::MINOR', 0)
 
-            route = double("route", app: double("app", app: GrapeRoute))
+            route = double('route', :app => double('app', :app => GrapeRoute))
 
             is_grape_route = TCellAgent::Instrumentation.grape_route?(route)
 
@@ -157,138 +156,134 @@ module TCellAgent
       end
     end
 
-    describe ".grape_route_info" do
-
-      context "with grape version 0.10.1" do
-        it "should use route_method and route_path" do
-          route = double("route")
-          grape_gem = double("grape_gem", version: "0.10.1")
+    describe '.grape_route_info' do
+      context 'with grape version 0.10.1' do
+        it 'should use route_method and route_path' do
+          route = double('route')
+          grape_gem = double('grape_gem', :version => '0.10.1')
 
           expect(Gem).to receive(:loaded_specs).and_return({
-            "grape" => grape_gem
-          })
-          expect(route).to receive(:route_method).and_return("POST")
-          expect(route).to receive(:route_path).and_return("/grape_api/endpoint")
+                                                             'grape' => grape_gem
+                                                           })
+          expect(route).to receive(:route_method).and_return('POST')
+          expect(route).to receive(:route_path).and_return('/grape_api/endpoint')
 
           route_info = TCellAgent::Instrumentation.grape_route_info(route)
 
-          expect(route_info[:method]).to eq("POST")
-          expect(route_info[:path]).to eq("/grape_api/endpoint")
+          expect(route_info[:method]).to eq('POST')
+          expect(route_info[:path]).to eq('/grape_api/endpoint')
         end
       end
 
-      context "with grape version 0.16.0" do
-        it "should use request_method and path" do
-          route = double("route")
-          grape_gem = double("grape_gem", version: "0.16.0")
+      context 'with grape version 0.16.0' do
+        it 'should use request_method and path' do
+          route = double('route')
+          grape_gem = double('grape_gem', :version => '0.16.0')
 
           expect(Gem).to receive(:loaded_specs).and_return({
-            "grape" => grape_gem
-          })
-          expect(route).to receive(:request_method).and_return("POST")
-          expect(route).to receive(:path).and_return("/grape_api/endpoint")
+                                                             'grape' => grape_gem
+                                                           })
+          expect(route).to receive(:request_method).and_return('POST')
+          expect(route).to receive(:path).and_return('/grape_api/endpoint')
 
           route_info = TCellAgent::Instrumentation.grape_route_info(route)
 
-          expect(route_info[:method]).to eq("POST")
-          expect(route_info[:path]).to eq("/grape_api/endpoint")
+          expect(route_info[:method]).to eq('POST')
+          expect(route_info[:path]).to eq('/grape_api/endpoint')
         end
       end
-
     end
 
-    describe ".instrument_grape_api" do
-
-      context "with nil routes" do
-        it "should not send any events" do
+    describe '.instrument_grape_api' do
+      context 'with nil routes' do
+        it 'should not send any events' do
           expect(TCellAgent::SensorEvents::Util).to_not receive(:calculateRouteId)
-          TCellAgent::Instrumentation.instrument_grape_api("/api", nil)
+          TCellAgent::Instrumentation.instrument_grape_api('/api', nil)
         end
       end
 
-      context "with empty routes" do
-        it "should not send any events" do
+      context 'with empty routes' do
+        it 'should not send any events' do
           expect(TCellAgent::SensorEvents::Util).to_not receive(:calculateRouteId)
-          TCellAgent::Instrumentation.instrument_grape_api("/api", [])
+          TCellAgent::Instrumentation.instrument_grape_api('/api', [])
         end
       end
 
-      context "with grape version < 1.16" do
+      context 'with grape version < 1.16' do
         before(:each) do
-          grape_gem = double("grape_gem", version: "0.10.1")
+          grape_gem = double('grape_gem', :version => '0.10.1')
 
           expect(Gem).to receive(:loaded_specs).and_return({
-            "grape" => grape_gem
-          }).at_least(1)
+                                                             'grape' => grape_gem
+                                                           }).at_least(1)
         end
 
-        context "with one route" do
-          it "should send one event" do
-            route = double("grape_route", route_method: "GET", route_path: "/users")
+        context 'with one route' do
+          it 'should send one event' do
+            route = double('grape_route', :route_method => 'GET', :route_path => '/users')
 
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "GET", "409553642", nil, nil
+              '/api/users', 'GET', '409553642', nil, nil
             ).and_call_original
 
-            TCellAgent::Instrumentation.instrument_grape_api("/api", [route])
+            TCellAgent::Instrumentation.instrument_grape_api('/api', [route])
           end
         end
 
-        context "with two routes" do
-          it "should send two events" do
-            route = double("grape_route", route_method: "GET", route_path: "/users")
-            route_dos = double("grape_route", route_method: "POST", route_path: "/users")
+        context 'with two routes' do
+          it 'should send two events' do
+            route = double('grape_route', :route_method => 'GET', :route_path => '/users')
+            route_dos = double('grape_route', :route_method => 'POST', :route_path => '/users')
 
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "GET", "409553642", nil, nil
+              '/api/users', 'GET', '409553642', nil, nil
             ).and_call_original
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "POST", "-2105512096", nil, nil
+              '/api/users', 'POST', '-2105512096', nil, nil
             ).and_call_original
 
-            TCellAgent::Instrumentation.instrument_grape_api("/api", [route, route_dos])
+            TCellAgent::Instrumentation.instrument_grape_api('/api', [route, route_dos])
           end
         end
       end
 
-      context "with grape version >= 1.16" do
+      context 'with grape version >= 1.16' do
         before(:each) do
-          grape_gem = double("grape_gem", version: "0.16.0")
+          grape_gem = double('grape_gem', :version => '0.16.0')
 
           expect(Gem).to receive(:loaded_specs).and_return({
-            "grape" => grape_gem
-          }).at_least(1)
+                                                             'grape' => grape_gem
+                                                           }).at_least(1)
         end
 
-        context "with one route" do
-          it "should send one event" do
-            route = double("grape_route", request_method: "GET", path: "/users")
+        context 'with one route' do
+          it 'should send one event' do
+            route = double('grape_route', :request_method => 'GET', :path => '/users')
 
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "GET", "409553642", nil, nil
+              '/api/users', 'GET', '409553642', nil, nil
             ).and_call_original
 
-            TCellAgent::Instrumentation.instrument_grape_api("/api", [route])
+            TCellAgent::Instrumentation.instrument_grape_api('/api', [route])
           end
         end
 
-        context "with two routes" do
-          it "should send two events" do
-            route = double("grape_route", request_method: "GET", path: "/users")
-            route_dos = double("grape_route", request_method: "POST", path: "/users")
+        context 'with two routes' do
+          it 'should send two events' do
+            route = double('grape_route', :request_method => 'GET', :path => '/users')
+            route_dos = double('grape_route', :request_method => 'POST', :path => '/users')
 
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "GET", "409553642", nil, nil
+              '/api/users', 'GET', '409553642', nil, nil
             ).and_call_original
             expect(TCellAgent::SensorEvents::AppRoutesSensorEvent).to receive(:new).with(
-              "/api/users", "POST", "-2105512096", nil, nil
+              '/api/users', 'POST', '-2105512096', nil, nil
             ).and_call_original
 
-            TCellAgent::Instrumentation.instrument_grape_api("/api", [route, route_dos])
+            TCellAgent::Instrumentation.instrument_grape_api('/api', [route, route_dos])
           end
         end
       end
     end
-
   end
 end

data/spec/lib/tcell_agent/rails/routes/route_id_spec.rb

@@ -2,18 +2,16 @@ require 'spec_helper'
 
 module TCellAgent
   module Instrumentation
-
     describe RouteId do
       TCELL_CONTEXT_KEY = TCellAgent::Instrumentation::TCELL_ID
 
-      describe ".update_context" do
-
-        context "with nil route" do
-          it "should not set anything" do
+      describe '.update_context' do
+        context 'with nil route' do
+          it 'should not set anything' do
             tcell_context = TCellData.new
             tcell_context.route_id = nil
 
-            RouteId.update_context({TCELL_CONTEXT_KEY => tcell_context}, {}, nil)
+            RouteId.update_context({ TCELL_CONTEXT_KEY => tcell_context }, {}, nil)
 
             expect(tcell_context.route_id).to eq(nil)
             expect(tcell_context.grape_mount_endpoint).to eq(nil)
@@ -21,60 +19,59 @@ module TCellAgent
           end
         end
 
-        context "with nil context" do
-          it "should not set anything "do
-            route = double("route")
+        context 'with nil context' do
+          it 'should not set anything ' do
+            route = double('route')
             expect(route).to_not receive(:path)
 
             RouteId.update_context({}, {}, route)
           end
         end
 
-        context "with a regular route and parameters" do
-          it "should set the route id" do
+        context 'with a regular route and parameters' do
+          it 'should set the route id' do
             tcell_context = TCellData.new
             tcell_context.route_id = nil
-            tcell_context.request_method = "GET"
+            tcell_context.request_method = 'GET'
 
             route = double(
-              "route",
-              path: double("path", spec: "/some/regular/path"))
+              'route',
+              :path => double('path', :spec => '/some/regular/path')
+            )
 
             expect(TCellAgent::Instrumentation).to receive(:grape_route?).with(route).and_return(false)
 
-            RouteId.update_context({TCELL_CONTEXT_KEY => tcell_context}, {id: 1}, route)
+            RouteId.update_context({ TCELL_CONTEXT_KEY => tcell_context }, { :id => 1 }, route)
 
             expect(tcell_context.route_id).to eq(
-              TCellAgent::SensorEvents::Util.calculateRouteId("GET", "/some/regular/path")
+              TCellAgent::SensorEvents::Util.calculateRouteId('GET', '/some/regular/path')
             )
             expect(tcell_context.grape_mount_endpoint).to eq(nil)
-            expect(tcell_context.path_parameters).to eq({id: 1})
+            expect(tcell_context.path_parameters).to eq({ :id => 1 })
           end
         end
 
-        context "with a grape route and parameters" do
-          it "should set the grape mount endpoint" do
+        context 'with a grape route and parameters' do
+          it 'should set the grape mount endpoint' do
             tcell_context = TCellData.new
             tcell_context.route_id = nil
-            tcell_context.request_method = "GET"
+            tcell_context.request_method = 'GET'
 
             route = double(
-              "route",
-              path: double("path", spec: "/grape_api"))
+              'route',
+              :path => double('path', :spec => '/grape_api')
+            )
 
             expect(TCellAgent::Instrumentation).to receive(:grape_route?).with(route).and_return(true)
 
-            RouteId.update_context({TCELL_CONTEXT_KEY => tcell_context}, {id: 1}, route)
+            RouteId.update_context({ TCELL_CONTEXT_KEY => tcell_context }, { :id => 1 }, route)
 
             expect(tcell_context.route_id).to eq(nil)
-            expect(tcell_context.grape_mount_endpoint).to eq("/grape_api")
-            expect(tcell_context.path_parameters).to eq({id: 1})
+            expect(tcell_context.grape_mount_endpoint).to eq('/grape_api')
+            expect(tcell_context.path_parameters).to eq({ :id => 1 })
           end
         end
-
       end
-
     end
-
   end
 end