tcell_agent 0.4.0 → 1.0.0

data/spec/lib/tcell_agent/instrumentation_spec.rb

@@ -5,19 +5,18 @@ module TCellAgent
   end
 end
 
-
 module TCellAgent
   module Instrumentation
     describe Instrumentation do
-      context "Body - SessionId Filters" do
-        it "Tests Redaction and Events in Body" do
+      context 'Body - SessionId Filters' do
+        it 'Tests Redaction and Events in Body' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_redact = true
           action.action_id = 5
           policy_json_two = {
-            "policy_id"=>"x1a1",
-            "data"=>{
-              "session_id_protections"=>{"body"=>["redact"], "log"=>["event"]}
+            'policy_id' => 'x1a1',
+            'data' => {
+              'session_id_protections' => { 'body' => ['redact'], 'log' => ['event'] }
             }
           }
           session_id_policy = TCellAgent::Policies::DataLossPolicy.from_json(policy_json_two)
@@ -26,23 +25,23 @@ module TCellAgent
           TCellAgent.set_thread_agent(mock_agent)
 
           context = TCellData.new
-          context.session_id = "tim123123my"
+          context.session_id = 'tim123123my'
 
-          body = "this is about tim123123my 3123123."
+          body = 'this is about tim123123my 3123123.'
           TCellAgent.empty_event_queue
           context.filter_body!(body)
-          expect(body).to eq("this is about [redacted] 3123123.")
+          expect(body).to eq('this is about [redacted] 3123123.')
           expect(TCellAgent.event_queue.length).to eq(1)
           TCellAgent.set_thread_agent(nil)
         end
-        it "Tests Events in Body" do
+        it 'Tests Events in Body' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_redact = true
           action.action_id = 5
           policy_json_two = {
-            "policy_id"=>"x1a1",
-            "data"=>{
-              "session_id_protections"=>{"body"=>["event"], "log"=>["redact"]}
+            'policy_id' => 'x1a1',
+            'data' => {
+              'session_id_protections' => { 'body' => ['event'], 'log' => ['redact'] }
             }
           }
           session_id_policy = TCellAgent::Policies::DataLossPolicy.from_json(policy_json_two)
@@ -51,25 +50,25 @@ module TCellAgent
           TCellAgent.set_thread_agent(mock_agent)
 
           context = TCellData.new
-          context.session_id = "tim123123my"
+          context.session_id = 'tim123123my'
 
-          body = "this is about tim123123my 3123123."
+          body = 'this is about tim123123my 3123123.'
           TCellAgent.empty_event_queue
           context.filter_body!(body)
-          expect(body).to eq("this is about tim123123my 3123123.")
+          expect(body).to eq('this is about tim123123my 3123123.')
           expect(TCellAgent.event_queue.length).to eq(1)
           TCellAgent.set_thread_agent(nil)
         end
       end
-      context "Log - SessionId Filters" do
-        it "Tests Redaction and Events in Body" do
+      context 'Log - SessionId Filters' do
+        it 'Tests Redaction and Events in Body' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_redact = true
           action.action_id = 5
           policy_json_two = {
-            "policy_id"=>"x1a1",
-            "data"=>{
-              "session_id_protections"=>{"body"=>["redact"], "log"=>["redact"]}
+            'policy_id' => 'x1a1',
+            'data' => {
+              'session_id_protections' => { 'body' => ['redact'], 'log' => ['redact'] }
             }
           }
           session_id_policy = TCellAgent::Policies::DataLossPolicy.from_json(policy_json_two)
@@ -78,23 +77,23 @@ module TCellAgent
           TCellAgent.set_thread_agent(mock_agent)
 
           context = TCellData.new
-          context.session_id = "tim123123my"
+          context.session_id = 'tim123123my'
 
-          body = "this is about tim123123my 3123123."
+          body = 'this is about tim123123my 3123123.'
           TCellAgent.empty_event_queue
           context.filter_log(body)
-          expect(body).to eq("this is about [redacted] 3123123.")
+          expect(body).to eq('this is about [redacted] 3123123.')
           expect(TCellAgent.event_queue.length).to eq(1)
           TCellAgent.set_thread_agent(nil)
         end
-        it "Tests Events Only" do
+        it 'Tests Events Only' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_redact = true
           action.action_id = 5
           policy_json_two = {
-            "policy_id"=>"x1a1",
-            "data"=>{
-              "session_id_protections"=>{"body"=>["redact"], "log"=>["event"]}
+            'policy_id' => 'x1a1',
+            'data' => {
+              'session_id_protections' => { 'body' => ['redact'], 'log' => ['event'] }
             }
           }
           session_id_policy = TCellAgent::Policies::DataLossPolicy.from_json(policy_json_two)
@@ -103,101 +102,101 @@ module TCellAgent
           TCellAgent.set_thread_agent(mock_agent)
 
           context = TCellData.new
-          context.session_id = "tim123123my"
+          context.session_id = 'tim123123my'
 
-          body = "this is about tim123123my 3123123."
+          body = 'this is about tim123123my 3123123.'
           TCellAgent.empty_event_queue
           context.filter_log(body)
-          expect(body).to eq("this is about tim123123my 3123123.")
+          expect(body).to eq('this is about tim123123my 3123123.')
           expect(TCellAgent.event_queue.length).to eq(1)
           TCellAgent.set_thread_agent(nil)
         end
       end
-      context "Body - Database Filters" do
-        it "Tests Redaction and Events in Body" do
+      context 'Body - Database Filters' do
+        it 'Tests Redaction and Events in Body' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_redact = true
           action.action_id = 5
           context = TCellData.new
-          context.add_response_db_filter("timmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy23", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("3123123", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy1", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti21312mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti123123mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(10233234, action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(true, action, "don", "sam", "tim", "fred")
-          body = "this is about timmy1 3123123."
+          context.add_response_db_filter('timmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy23', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('3123123', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy1', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti21312mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti123123mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(10_233_234, action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(true, action, 'don', 'sam', 'tim', 'fred')
+          body = 'this is about timmy1 3123123.'
           TCellAgent.empty_event_queue
           context.filter_body!(body)
-          expect(body).to eq("this is about [redacted] [redacted].")
+          expect(body).to eq('this is about [redacted] [redacted].')
           expect(TCellAgent.event_queue.length).to eq(2)
         end
-        it "Tests Event Only Match in Body" do
+        it 'Tests Event Only Match in Body' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.body_event = true
           action.action_id = 5
           context = TCellData.new
-          context.add_response_db_filter("timmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy23", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("3123123", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy1", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti21312mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti123123mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(10233234, action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(true, action, "don", "sam", "tim", "fred")
-          body = "this is about timmy1 3123123."
+          context.add_response_db_filter('timmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy23', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('3123123', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy1', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti21312mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti123123mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(10_233_234, action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(true, action, 'don', 'sam', 'tim', 'fred')
+          body = 'this is about timmy1 3123123.'
           TCellAgent.empty_event_queue
           context.filter_body!(body)
-          expect(body).to eq("this is about timmy1 3123123.")
+          expect(body).to eq('this is about timmy1 3123123.')
           expect(TCellAgent.event_queue.length).to eq(3) # timmy, timmy1, 3123123
         end
       end
-      context "Log - Database Filters" do
-        it "Tests Redaction and Events" do
+      context 'Log - Database Filters' do
+        it 'Tests Redaction and Events' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.log_redact = true
           action.action_id = 5
           context = TCellData.new
-          context.add_response_db_filter("timmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy23", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("3123123", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy1", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti21312mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti123123mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(10233234, action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(true, action, "don", "sam", "tim", "fred")
-          body = "this is about timmy1 3123123."
+          context.add_response_db_filter('timmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy23', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('3123123', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy1', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti21312mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti123123mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(10_233_234, action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(true, action, 'don', 'sam', 'tim', 'fred')
+          body = 'this is about timmy1 3123123.'
           TCellAgent.empty_event_queue
           context.filter_log(body)
-          expect(body).to eq("this is about [redacted] [redacted].")
+          expect(body).to eq('this is about [redacted] [redacted].')
           expect(TCellAgent.event_queue.length).to eq(2)
         end
-        it "Tests Report-Only and Events" do
+        it 'Tests Report-Only and Events' do
           action = TCellAgent::Policies::DataLossPolicy::FilterActions.new
           action.log_event = true
           action.action_id = 5
           context = TCellData.new
-          context.add_response_db_filter("timmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy23", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("3123123", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("timmy1", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("tim123123my", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti21312mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter("ti123123mmy", action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(10233234, action, "don", "sam", "tim", "fred")
-          context.add_response_db_filter(true, action, "don", "sam", "tim", "fred")
-          body = "this is about timmy1 3123123."
+          context.add_response_db_filter('timmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy23', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('3123123', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('timmy1', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('tim123123my', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti21312mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter('ti123123mmy', action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(10_233_234, action, 'don', 'sam', 'tim', 'fred')
+          context.add_response_db_filter(true, action, 'don', 'sam', 'tim', 'fred')
+          body = 'this is about timmy1 3123123.'
           TCellAgent.empty_event_queue
           context.filter_log(body)
-          expect(body).to eq("this is about timmy1 3123123.")
+          expect(body).to eq('this is about timmy1 3123123.')
           expect(TCellAgent.event_queue.length).to eq(3) # timmy, timmy1, 3123123
         end
       end

data/spec/lib/tcell_agent/patches_spec.rb

@@ -2,160 +2,119 @@ require 'spec_helper'
 
 module TCellAgent
   module Instrumentation
-
-    describe ".block?" do
-
-      context "with an unexpected error" do
-        it "should return nil" do
-          request = double("request")
-          expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::Patches).and_raise(Exception.new("UNEXPECTED"))
+    describe '.block?' do
+      context 'with an unexpected error' do
+        it 'should return false' do
+          request = double('request')
+          expect(TCellAgent).to receive(:policy).with(
+            TCellAgent::PolicyTypes::Rust
+          ).and_raise(StandardError.new('UNEXPECTED'))
           expect(TCellAgent::Patches::MetaData).to_not receive(:build)
 
-          expect(Patches.block?(request)).to eq(nil)
+          expect(Patches.block?(request)).to eq(false)
         end
       end
 
-      context "with an empty patches policy" do
-        it "should return nil" do
-          request = double("request")
+      context 'with an empty patches policy' do
+        it 'should return false' do
+          request = double('request')
           expect(TCellAgent).to receive(:policy).and_return(nil)
           expect(TCellAgent::Patches::MetaData).to_not receive(:build)
 
-          expect(Patches.block?(request)).to eq(nil)
+          expect(Patches.block?(request)).to eq(false)
         end
       end
 
-      context "with a disabled patches policy" do
-        it "should return nil" do
-          request = double("request")
-          patches = TCellAgent::Policies::PatchesPolicy.from_json({
-            "policy_id" => "policy_id",
-            "version" => 1,
-            "data" => {}
-          })
-          expect(patches.enabled).to eq(false)
-
-          expect(TCellAgent).to receive(:policy).and_return(patches)
+      context 'with a disabled patches policy' do
+        it 'should return false' do
+          request = double('request')
+          rust_policies = TCellAgent::Policies::RustPolicies.new
+          expect(rust_policies.patches_enabled).to eq(false)
+
+          expect(TCellAgent).to receive(:policy).and_return(rust_policies)
           expect(TCellAgent::Patches::MetaData).to_not receive(:build)
 
-          expect(Patches.block?(request)).to eq(nil)
+          expect(Patches.block?(request)).to eq(false)
         end
       end
 
-      context "with a patches policy that does not apply" do
-        it "should return nil" do
-          request = double("request")
-          meta_data = double("meta_data")
-          patches = TCellAgent::Policies::PatchesPolicy.from_json({
-            "policy_id" => "policy_id",
-            "version" => 1,
-            "data" => {"blocked_ips" => [{"ip" => "1.1.1.1"}]}
-          })
-          expect(patches.enabled).to eq(true)
-
-          expect(TCellAgent).to receive(:policy).and_return(patches)
+      context 'with a patches policy that does not apply' do
+        it 'should return false' do
+          request = double('request')
+          meta_data = double('meta_data')
+          rust_policies = TCellAgent::Policies::RustPolicies.new
+          tcell_context = TCellAgent::Instrumentation::TCellData.new
+
+          expect(TCellAgent).to receive(:policy).and_return(rust_policies)
+          expect(rust_policies).to receive(:patches_enabled).and_return(true)
+          expect(rust_policies).to receive(:block_request?).and_return(false)
+          expect(request).to receive(:env).and_return(
+            {
+              TCellAgent::Instrumentation::TCELL_ID => tcell_context
+            }
+          )
           expect(TCellAgent::Patches::MetaData).to receive(:build).and_return(
             meta_data
           )
-          expect(meta_data).to receive(:remote_address).and_return("2.2.2.2")
 
-          expect(Patches.block?(request)).to eq(nil)
+          expect(Patches.block?(request)).to eq(false)
+          expect(tcell_context.patches_blocking_triggered).to eq(false)
         end
       end
 
-
-      context "with a patches policy that applies" do
-        it "should return a response" do
-          request = double("request")
-          meta_data = double("meta_data")
+      context 'with a patches policy that applies' do
+        it 'should return a response' do
+          request = double('request')
+          meta_data = double('meta_data')
           tcell_context = TCellAgent::Instrumentation::TCellData.new
-          patches = TCellAgent::Policies::PatchesPolicy.from_json({
-            "policy_id" => "policy_id",
-            "version" => 1,
-            "data" => {"blocked_ips" => [{"ip" => "1.1.1.1"}]}
-          })
-          expect(patches.enabled).to eq(true)
-          expect(tcell_context.ip_blocking_triggered).to eq(false)
-
-          expect(TCellAgent).to receive(:policy).and_return(patches)
+          rust_policies = TCellAgent::Policies::RustPolicies.new
+          expect(tcell_context.patches_blocking_triggered).to eq(false)
+
+          expect(TCellAgent).to receive(:policy).and_return(rust_policies)
+          expect(rust_policies).to receive(:patches_enabled).and_return(true)
+          expect(rust_policies).to receive(:block_request?).and_return(true)
           expect(TCellAgent::Patches::MetaData).to receive(:build).and_return(
             meta_data
           )
-          expect(meta_data).to receive(:remote_address).and_return("1.1.1.1")
-          expect(request).to receive(:env).and_return({TCellAgent::Instrumentation::TCELL_ID => tcell_context})
+          expect(request).to receive(:env).and_return({ TCellAgent::Instrumentation::TCELL_ID => tcell_context })
 
-          expect(Patches.block?(request)).to eq(403)
+          expect(Patches.block?(request)).to eq(true)
 
-          expect(tcell_context.ip_blocking_triggered).to eq(true)
+          expect(tcell_context.patches_blocking_triggered).to eq(true)
         end
 
         context "and that's complex" do
-          it "should return a response" do
-            request = double("request")
+          it 'should return a response' do
+            request = double('request')
             meta_data = TCellAgent::Patches::MetaData.new(
-              "get",
-              "2.3.4.5",
-              "route_id",
-              "session_id",
-              "user_id",
-              "transaction_id")
-            meta_data.get_dict = {"paramater" => "<script>"}
-            tcell_context = TCellAgent::Instrumentation::TCellData.new
-            patches = TCellAgent::Policies::PatchesPolicy.from_json({
-              "policy_id" => "policy_id",
-              "version" => 1,
-              "data" => {
-                "blocked_ips" => [{"ip" => "8.8.8.8"}],
-                "block_rules" => [
-                  {"ips" => ["8.8.8.8"]},
-                  {
-                    "ips" => ["2.3.4.5"],
-                    "sensor_matches" => {
-                      "xss" => {"patterns" => ["1", "2", "3", "4", "5", "6", "7", "8"]}
-                    }
-                  }
-                ]
-              }
-            })
-            expect(patches.enabled).to eq(true)
-            expect(tcell_context.ip_blocking_triggered).to eq(false)
-
-            expect(TCellAgent).to receive(:policy).and_return(patches)
-            expect(TCellAgent::Patches::MetaData).to receive(:build).and_return(
-              meta_data
+              'get',
+              '2.3.4.5',
+              'route_id',
+              'session_id',
+              'user_id',
+              'transaction_id',
+              'http://test.com/'
             )
-            expect(request).to receive(:env).and_return({TCellAgent::Instrumentation::TCELL_ID => tcell_context})
+            meta_data.get_dict = { 'paramater' => '<script>' }
+            tcell_context = TCellAgent::Instrumentation::TCellData.new
+            rust_policies = TCellAgent::Policies::RustPolicies.new
 
-            expect(Patches.block?(request)).to eq(403)
+            expect(tcell_context.patches_blocking_triggered).to eq(false)
 
-            expect(tcell_context.ip_blocking_triggered).to eq(true)
-          end
-        end
-
-        context "with an unexpected error" do
-          it "should return nil" do
-            request = double("request")
-            meta_data = double("meta_data")
-            patches = TCellAgent::Policies::PatchesPolicy.from_json({
-              "policy_id" => "policy_id",
-              "version" => 1,
-              "data" => {"blocked_ips" => [{"ip" => "1.1.1.1"}]}
-            })
-            expect(patches.enabled).to eq(true)
-
-            expect(TCellAgent).to receive(:policy).with(TCellAgent::PolicyTypes::Patches).and_return(patches)
+            expect(TCellAgent).to receive(:policy).and_return(rust_policies)
+            expect(rust_policies).to receive(:patches_enabled).and_return(true)
+            expect(rust_policies).to receive(:block_request?).and_return(true)
             expect(TCellAgent::Patches::MetaData).to receive(:build).and_return(
               meta_data
             )
-            expect(meta_data).to receive(:remote_address).and_raise(Exception.new("UNEXPECTED"))
-            expect(request).to_not receive(:env)
+            expect(request).to receive(:env).and_return({ TCellAgent::Instrumentation::TCELL_ID => tcell_context })
+
+            expect(Patches.block?(request)).to eq(true)
 
-            expect(Patches.block?(request)).to eq(nil)
+            expect(tcell_context.patches_blocking_triggered).to eq(true)
           end
         end
       end
-
     end
-
   end
 end