tcell_agent 0.4.0 → 1.0.0

data/spec/lib/tcell_agent/rails/middleware/redirect_middleware_spec.rb

@@ -6,13 +6,10 @@ module TCellAgent
   module Instrumentation
     module Rails
       module Middleware
-
-
         class MockAppsensorRackApp
-
           attr_reader :request_body
 
-          def initialize(route_id=nil, hmac_session_id=nil)
+          def initialize(route_id = nil, hmac_session_id = nil)
             @route_id = route_id
             @hmac_session_id = hmac_session_id
             @request_headers = {}
@@ -21,12 +18,12 @@ module TCellAgent
           def call(env)
             @env = env
             rack_request = Rack::Request.new(env)
-            response_headers = {'Content-Type' => 'text/html'}
-            env["tcell.request_data"].transaction_id = "a-b-c-d-e-f"
-            env["tcell.request_data"].hmac_session_id = @hmac_session_id
-            env["tcell.request_data"].route_id = @route_id
-            if (rack_request.params['rv'])
-              response_headers["Location"] = rack_request.params['rv']
+            response_headers = { 'Content-Type' => 'text/html' }
+            env['tcell.request_data'].transaction_id = 'a-b-c-d-e-f'
+            env['tcell.request_data'].hmac_session_id = @hmac_session_id
+            env['tcell.request_data'].route_id = @route_id
+            if rack_request.params['rv']
+              response_headers['Location'] = rack_request.params['rv']
             end
             [200, response_headers, ['OK']]
           end
@@ -34,55 +31,86 @@ module TCellAgent
           def [](key)
             @env[key]
           end
-
         end
 
         describe HeadersMiddleware do
-
           let(:app) { MockAppsensorRackApp.new }
-          let(:app2) { MockAppsensorRackApp.new("myrouteid", "hmac_sessionid") }
+          let(:app2) { MockAppsensorRackApp.new('myrouteid', 'hmac_sessionid') }
 
-          subject { withTCellMiddleware( app ) }
+          subject { with_tcell_middleware(app) }
 
-          context "Redirect Middleware" do
+          context 'Redirect Middleware' do
             before(:each) do
               TCellAgent.configuration = TCellAgent::Configuration.new
-              TCellAgent.configuration.read_config_from_file(get_test_resource_path("normal_config.json"))
+              TCellAgent.configuration.read_config_from_file(get_test_resource_path('normal_config.json'))
             end
+
             let(:request) { Rack::MockRequest.new(subject) }
-            let(:request2) { Rack::MockRequest.new( withTCellMiddleware( app2 )) }
+            let(:request2) { Rack::MockRequest.new(with_tcell_middleware(app2)) }
             let(:agent) { ::TCellAgent::Agent.new }
-            context "Event" do
+
+            context 'Event' do
               before(:each) do
-                TCellAgent.thread_agent.processPolicyJson({"http-redirect"=>{
-                  "policy_id"=>"153ed270-7481-11e5-9194-95dad9b9dec3",
-                  "data"=>{
-                  "enabled"=>true,
-                  "block"=>false,
-                  "whitelist"=>[]
-                }
-                }}, cache=false)
+                TCellAgent.thread_agent.processPolicyJson(
+                  {
+                    'http-redirect' =>
+                    {
+                      'policy_id' => '153ed270-7481-11e5-9194-95dad9b9dec3',
+                      'data' => {
+                        'enabled' => true,
+                        'block' => false,
+                        'whitelist' => []
+                      }
+                    }
+                  },
+                  false
+                )
                 TCellAgent.empty_event_queue
               end
-              it "sends redirect" do
-                response = request.get("/some/path2?abcdef=adsfsadf&rv=https://www.google.com", 'CONTENT_TYPE' => 'text/html', 'REMOTE_ADDR' => '1.3.3.4,3.4.5.6')
-                expect(response['Location']).to eq("https://www.google.com")
-                expected_as = {"event_type"=>"redirect", "method"=>"GET", "from_domain"=>"example.org", "status_code"=>200, "remote_addr"=>"1.3.3.4", "from"=>"/some/path2?abcdef=&rv=", "to"=>"www.google.com"}
+
+              it 'sends redirect' do
+                response = request.get(
+                  '/some/path2?abcdef=adsfsadf&rv=https://www.google.com',
+                  'CONTENT_TYPE' => 'text/html',
+                  'REMOTE_ADDR' => '1.3.3.4,3.4.5.6'
+                )
+                expect(response['Location']).to eq('https://www.google.com')
+                expected_as = {
+                  'event_type' => 'redirect',
+                  'method' => 'GET',
+                  'from_domain' => 'example.org',
+                  'status_code' => 200,
+                  'remote_addr' => '1.3.3.4',
+                  'from' => '/some/path2?abcdef=&rv=',
+                  'to' => 'www.google.com'
+                }
                 expect(TCellAgent.event_queue).to include(expected_as)
               end
-              it "sends redirect event with extra info" do
-                response = request2.get("/some/path2?abcdef=adsfsadf&rv=https://www.google.com", 'CONTENT_TYPE' => 'text/html', 'REMOTE_ADDR' => '1.3.3.4,3.4.5.6')
-                expect(response['Location']).to eq("https://www.google.com")
-                expected_as = {"event_type"=>"redirect", "method"=>"GET", "from_domain"=>"example.org", "status_code"=>200, "remote_addr"=>"1.3.3.4", "rid"=>"myrouteid", "from"=>"/some/path2?abcdef=&rv=", "to"=>"www.google.com", "sid"=>"hmac_sessionid"}
+
+              it 'sends redirect event with extra info' do
+                response = request2.get(
+                  '/some/path2?abcdef=adsfsadf&rv=https://www.google.com',
+                  'CONTENT_TYPE' => 'text/html',
+                  'REMOTE_ADDR' => '1.3.3.4,3.4.5.6'
+                )
+                expect(response['Location']).to eq('https://www.google.com')
+                expected_as = {
+                  'event_type' => 'redirect',
+                  'method' => 'GET',
+                  'from_domain' => 'example.org',
+                  'status_code' => 200,
+                  'remote_addr' => '1.3.3.4',
+                  'rid' => 'myrouteid',
+                  'from' => '/some/path2?abcdef=&rv=',
+                  'to' => 'www.google.com',
+                  'sid' => 'hmac_sessionid'
+                }
                 expect(TCellAgent.event_queue).to include(expected_as)
               end
-
-              end #/conext
-            end #/context
-          end #/describe
-
-
+            end
+          end
         end
       end
     end
   end
+end

data/spec/lib/tcell_agent/rails/middleware/tcell_body_proxy_spec.rb

@@ -3,32 +3,33 @@ require 'spec_helper'
 module TCellAgent
   module Instrumentation
     module Rails
-
       describe TCellBodyProxy do
-
-        context "#close" do
+        context '#close' do
           before(:each) do
             @appsensor_meta = TCellAgent::SensorEvents::AppSensorMetaEvent.new(
-              "get",
-              "remote_address",
-              "route_id",
-              "session_id",
-              "user_id",
-              "transaction_id")
+              'get',
+              'remote_address',
+              'route_id',
+              'session_id',
+              'user_id',
+              'transaction_id',
+              'http://test.com/'
+            )
           end
 
-          context "zero content length" do
-            it "appsensor_meta event should be enqueued for processing" do
+          context 'zero content length' do
+            it 'appsensor_meta event should be enqueued for processing' do
               tcell_body_proxy = TCellBodyProxy.new(
-                Rack::BodyProxy.new(["body"]) { },
+                Rack::BodyProxy.new(['body']) {},
                 true,
-                nil, nil, nil, nil)
+                nil, nil, nil, nil
+              )
               tcell_body_proxy.appsensor_meta = @appsensor_meta
 
               tcell_body_proxy.content_length = 0
 
               expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                "Running AppSensor deferred due to streaming"
+                'Running AppSensor deferred due to streaming'
               ).and_call_original
               expect(TCellAgent).to receive(:send_event).with(
                 @appsensor_meta
@@ -38,18 +39,19 @@ module TCellAgent
             end
           end
 
-          context "non zero content length" do
-            it "appsensor_meta event should be enqueued for processing" do
+          context 'non zero content length' do
+            it 'appsensor_meta event should be enqueued for processing' do
               tcell_body_proxy = TCellBodyProxy.new(
-                Rack::BodyProxy.new(["body"]) { },
+                Rack::BodyProxy.new(['body']) {},
                 true,
-                nil, nil, nil, nil)
+                nil, nil, nil, nil
+              )
               tcell_body_proxy.appsensor_meta = @appsensor_meta
 
               tcell_body_proxy.content_length = 512
 
               expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                "Running AppSensor deferred due to streaming"
+                'Running AppSensor deferred due to streaming'
               ).and_call_original
               expect(TCellAgent).to receive(:send_event).with(
                 @appsensor_meta
@@ -62,27 +64,30 @@ module TCellAgent
           end
         end
 
-        context "#each" do
-          context "with no block given" do
-            it "should return an enumerator" do
+        context '#each' do
+          context 'with no block given' do
+            it 'should return an enumerator' do
               tcell_body_proxy = TCellBodyProxy.new(
-                Rack::BodyProxy.new(["body"]) { },
+                Rack::BodyProxy.new(['body']) {},
                 true,
-                nil, nil, nil, nil)
-              expect(tcell_body_proxy.each.class.name).to eq("Enumerator")
+                nil, nil, nil, nil
+              )
+              expect(tcell_body_proxy.each.class.name).to eq('Enumerator')
             end
           end
 
-          context "with a string response" do
-            context "with a chunked response" do
-              it "should only calculate content length" do
+          context 'with a string response' do
+            context 'with a chunked response' do
+              it 'should only calculate content length' do
                 tcell_body_proxy = TCellBodyProxy.new(
-                  Rack::BodyProxy.new(["2d\r\nsome content\r\n"]) { },
+                  Rack::BodyProxy.new(["2d\r\nsome content\r\n"]) {},
                   false,
-                  nil, nil, nil, nil)
+                  nil, nil, nil, nil
+                )
 
                 expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                  "Processing tcell body proxy body").and_call_original
+                  'Processing tcell body proxy body'
+                ).and_call_original
 
                 tcell_body_proxy.each { |b| }
 
@@ -90,16 +95,18 @@ module TCellAgent
               end
             end
 
-            context "with a non chunked response" do
-              context "that should not be processed" do
-                it "should only calculate content length" do
+            context 'with a non chunked response' do
+              context 'that should not be processed' do
+                it 'should only calculate content length' do
                   tcell_body_proxy = TCellBodyProxy.new(
-                    Rack::BodyProxy.new(["some content"]) { },
+                    Rack::BodyProxy.new(['some content']) {},
                     false,
-                    nil, nil, nil, nil)
+                    nil, nil, nil, nil
+                  )
 
                   expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                    "Processing tcell body proxy body").and_call_original
+                    'Processing tcell body proxy body'
+                  ).and_call_original
 
                   tcell_body_proxy.each { |b| }
 
@@ -107,19 +114,21 @@ module TCellAgent
                 end
               end
 
-              context "that should be processed" do
-                it "should call js and dlp procs as well as calculate content length" do
-                  js_agent_insertion_proc = double("js_agent_insertion_proc")
-                  dlp_cleaner_proc = double("dlp_cleaner_proc")
+              context 'that should be processed' do
+                it 'should call js and dlp procs as well as calculate content length' do
+                  js_agent_insertion_proc = double('js_agent_insertion_proc')
+                  dlp_cleaner_proc = double('dlp_cleaner_proc')
                   tcell_body_proxy = TCellBodyProxy.new(
-                    Rack::BodyProxy.new(["some content"]) { },
+                    Rack::BodyProxy.new(['some content']) {},
                     true,
-                    js_agent_insertion_proc, "script_insert", dlp_cleaner_proc, nil)
+                    js_agent_insertion_proc, 'script_insert', dlp_cleaner_proc, nil
+                  )
 
                   expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                    "Processing tcell body proxy body").and_call_original
-                  expect(js_agent_insertion_proc).to receive(:call).with("script_insert", "some content")
-                  expect(dlp_cleaner_proc).to receive(:call).with(nil, "some content")
+                    'Processing tcell body proxy body'
+                  ).and_call_original
+                  expect(js_agent_insertion_proc).to receive(:call).with('script_insert', 'some content')
+                  expect(dlp_cleaner_proc).to receive(:call).with(nil, 'some content')
 
                   tcell_body_proxy.each { |b| }
 
@@ -129,23 +138,27 @@ module TCellAgent
             end
           end
 
-          context "with an ActionView::OutputBuffer" do
-            context "that should not be processed" do
-              it "should only calculate content length" do
-                body_chunk = "some content"
-                js_agent_insertion_proc = double("js_agent_insertion_proc")
-                dlp_cleaner_proc = double("dlp_cleaner_proc")
+          context 'with an ActionView::OutputBuffer' do
+            context 'that should not be processed' do
+              it 'should only calculate content length' do
+                body_chunk = 'some content'
+                js_agent_insertion_proc = double('js_agent_insertion_proc')
+                dlp_cleaner_proc = double('dlp_cleaner_proc')
                 tcell_body_proxy = TCellBodyProxy.new(
-                  Rack::BodyProxy.new([body_chunk]) { },
+                  Rack::BodyProxy.new([body_chunk]) {},
                   false,
-                  nil, nil, nil, nil)
+                  nil, nil, nil, nil
+                )
 
                 expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                  "Processing tcell body proxy body").and_call_original
+                  'Processing tcell body proxy body'
+                ).and_call_original
                 expect(body_chunk).to receive(:class).and_return(
-                  double("body_class", name: "ActionView::OutputBuffer"))
+                  double('body_class', :name => 'ActionView::OutputBuffer')
+                )
                 expect(body_chunk).to receive(:class).and_return(
-                  double("body_class", name: "ActionView::OutputBuffer"))
+                  double('body_class', :name => 'ActionView::OutputBuffer')
+                )
                 expect(js_agent_insertion_proc).to_not receive(:call)
                 expect(dlp_cleaner_proc).to_not receive(:call)
 
@@ -155,19 +168,21 @@ module TCellAgent
               end
             end
 
-            context "that should be processed" do
-              it "should call js and dlp procs as well as calculate content length" do
-                body_chunk = "some content"
-                js_agent_insertion_proc = double("js_agent_insertion_proc")
-                dlp_cleaner_proc = double("dlp_cleaner_proc")
+            context 'that should be processed' do
+              it 'should call js and dlp procs as well as calculate content length' do
+                body_chunk = 'some content'
+                js_agent_insertion_proc = double('js_agent_insertion_proc')
+                dlp_cleaner_proc = double('dlp_cleaner_proc')
                 tcell_body_proxy = TCellBodyProxy.new(
-                  Rack::BodyProxy.new([body_chunk]) { },
+                  Rack::BodyProxy.new([body_chunk]) {},
                   true,
-                  js_agent_insertion_proc, "script_insert", dlp_cleaner_proc, nil)
+                  js_agent_insertion_proc, 'script_insert', dlp_cleaner_proc, nil
+                )
 
                 expect(TCellAgent::Instrumentation).to receive(:safe_block).with(
-                  "Processing tcell body proxy body").and_call_original
-                expect(js_agent_insertion_proc).to receive(:call).with("script_insert", body_chunk)
+                  'Processing tcell body proxy body'
+                ).and_call_original
+                expect(js_agent_insertion_proc).to receive(:call).with('script_insert', body_chunk)
                 expect(dlp_cleaner_proc).to receive(:call).with(nil, body_chunk)
 
                 tcell_body_proxy.each { |b| }
@@ -178,7 +193,6 @@ module TCellAgent
           end
         end
       end
-
     end
   end
 end

data/spec/lib/tcell_agent/rails/responses_spec.rb

@@ -2,80 +2,76 @@ require 'spec_helper'
 
 module TCellAgent
   module Utils
-
-    describe ".responses" do
-
-      context ".empty_content?" do
-        context "with nil status code" do
-          context "with empty headers" do
-            it "should return false" do
+    describe '.responses' do
+      context '.empty_content?' do
+        context 'with nil status code' do
+          context 'with empty headers' do
+            it 'should return false' do
               expect(Rails.empty_content?(nil, {})).to eq(false)
             end
           end
 
-          context "with Content-Length header" do
-            context "that is zero" do
-              it "should return true" do
-                expect(Rails.empty_content?(nil, {'Content-Length' => 0})).to eq(true)
+          context 'with Content-Length header' do
+            context 'that is zero' do
+              it 'should return true' do
+                expect(Rails.empty_content?(nil, { 'Content-Length' => 0 })).to eq(true)
               end
             end
 
-            context "that is non zero" do
-              it "should return false" do
-                expect(Rails.empty_content?(nil, {'Content-Length' => 1})).to eq(false)
+            context 'that is non zero' do
+              it 'should return false' do
+                expect(Rails.empty_content?(nil, { 'Content-Length' => 1 })).to eq(false)
               end
             end
           end
         end
 
-        context "with a status code" do
-          context "that contains no content" do
-            context "with empty headers" do
-              it "should return true" do
+        context 'with a status code' do
+          context 'that contains no content' do
+            context 'with empty headers' do
+              it 'should return true' do
                 expect(Rails.empty_content?(204, {})).to eq(true)
               end
             end
 
-            context "with Content-Length header" do
-              context "that is zero" do
-                it "should return true" do
-                  expect(Rails.empty_content?(204, {'Content-Length' => 0})).to eq(true)
+            context 'with Content-Length header' do
+              context 'that is zero' do
+                it 'should return true' do
+                  expect(Rails.empty_content?(204, { 'Content-Length' => 0 })).to eq(true)
                 end
               end
 
-              context "that is non zero" do
-                it "should return true" do
-                  expect(Rails.empty_content?(204, {'Content-Length' => 1})).to eq(true)
+              context 'that is non zero' do
+                it 'should return true' do
+                  expect(Rails.empty_content?(204, { 'Content-Length' => 1 })).to eq(true)
                 end
               end
             end
           end
 
-          context "that contains content" do
-            context "with empty headers" do
-              it "should return false" do
+          context 'that contains content' do
+            context 'with empty headers' do
+              it 'should return false' do
                 expect(Rails.empty_content?(200, {})).to eq(false)
               end
             end
 
-            context "with Content-Length header" do
-              context "that is zero" do
-                it "should return true" do
-                  expect(Rails.empty_content?(200, {'Content-Length' => 0})).to eq(true)
+            context 'with Content-Length header' do
+              context 'that is zero' do
+                it 'should return true' do
+                  expect(Rails.empty_content?(200, { 'Content-Length' => 0 })).to eq(true)
                 end
               end
 
-              context "that is non zero" do
-                it "should return false" do
-                  expect(Rails.empty_content?(200, {'Content-Length' => 1})).to eq(false)
+              context 'that is non zero' do
+                it 'should return false' do
+                  expect(Rails.empty_content?(200, { 'Content-Length' => 1 })).to eq(false)
                 end
               end
             end
           end
         end
       end
-
     end
-
   end
 end