tcell_agent 0.4.0 → 1.0.0

data/spec/lib/tcell_agent/policies/http_redirect_policy_spec.rb

@@ -2,11 +2,9 @@ require 'spec_helper'
 
 module TCellAgent
   module Policies
-
     describe HttpRedirectPolicy do
-
-      context "with defaults" do
-        it "returns true" do
+      context 'with defaults' do
+        it 'returns true' do
           http_redirect_plain = HttpRedirectPolicy.new
           expect(http_redirect_plain.policy_id).to eq(nil)
           expect(http_redirect_plain.enabled).to eq(false)
@@ -16,219 +14,218 @@ module TCellAgent
         end
       end
 
-      describe "#suspicious_redirect?" do
+      describe '#suspicious_redirect?' do
         it "see's other domain" do
           http_redirect_policy = HttpRedirectPolicy.from_json({
-            "policy_id"=>"x1a1",
-            "data"=>{
-              "enabled"=>true
-            }
-          })
-          expect(http_redirect_policy.policy_id).to eq("x1a1")
+                                                                'policy_id' => 'x1a1',
+                                                                'data' => {
+                                                                  'enabled' => true
+                                                                }
+                                                              })
+          expect(http_redirect_policy.policy_id).to eq('x1a1')
           expect(http_redirect_policy.enabled).to eq(true)
 
-          expect(http_redirect_policy.suspicious_redirect?("test.google.com", "www.test.com")).to eq(true)
+          expect(http_redirect_policy.suspicious_redirect?('test.google.com', 'www.test.com')).to eq(true)
         end
 
-        context "with wildcard domain" do
-          it "should be false" do
+        context 'with wildcard domain' do
+          it 'should be false' do
             http_redirect_policy = HttpRedirectPolicy.from_json({
-              "policy_id"=>"x1a1",
-              "data"=>{
-                "enabled"=>true,
-                "whitelist"=>["*.google.com"]
-              }
-            })
+                                                                  'policy_id' => 'x1a1',
+                                                                  'data' => {
+                                                                    'enabled' => true,
+                                                                    'whitelist' => ['*.google.com']
+                                                                  }
+                                                                })
 
-            expect(http_redirect_policy.suspicious_redirect?("test.google.com", "www.test.com")).to eq(false)
+            expect(http_redirect_policy.suspicious_redirect?('test.google.com', 'www.test.com')).to eq(false)
 
-            expect(http_redirect_policy.suspicious_redirect?("test.google.net", "www.test.com")).to eq(true)
+            expect(http_redirect_policy.suspicious_redirect?('test.google.net', 'www.test.com')).to eq(true)
           end
         end
       end
 
-      describe "#enforce" do
-        context "with a disabled policy" do
-          it "should not enfore the policy" do
+      describe '#enforce' do
+        context 'with a disabled policy' do
+          it 'should not enfore the policy' do
             http_redirect_policy = HttpRedirectPolicy.from_json({
-              "policy_id"=>"x1a1",
-              "data"=>{
-                "enabled"=>false,
-                "block"=>true,
-                "whitelist"=>["*.google.com"]
-              }
-            })
+                                                                  'policy_id' => 'x1a1',
+                                                                  'data' => {
+                                                                    'enabled' => false,
+                                                                    'block' => true,
+                                                                    'whitelist' => ['*.google.com']
+                                                                  }
+                                                                })
 
             expect(http_redirect_policy.enforce(
-              "https://test.google.com", "www.test.com", "/path/a", "GET", "routex", "1.1.1.1", 400)
-            ).to eq(nil)
+                     'https://test.google.com', 'www.test.com', '/path/a', 'GET', 'routex', '1.1.1.1', 400
+            )).to eq(nil)
           end
         end
 
-        context "with an enabled policy" do
-          context "redirecting to non whitelisted domain" do
-            it "should block the redirect" do
+        context 'with an enabled policy' do
+          context 'redirecting to non whitelisted domain' do
+            it 'should block the redirect' do
               http_redirect_policy = HttpRedirectPolicy.from_json({
-                "policy_id"=>"x1a1",
-                "data"=>{
-                  "enabled"=>true,
-                  "block"=>true,
-                  "whitelist"=>["good.com"]
-                }
-              })
+                                                                    'policy_id' => 'x1a1',
+                                                                    'data' => {
+                                                                      'enabled' => true,
+                                                                      'block' => true,
+                                                                      'whitelist' => ['good.com']
+                                                                    }
+                                                                  })
 
               expect(http_redirect_policy.enforce(
-                "https://www.google.com/abc/def", "localhost", "/path/a", "GET", "routey", "1.1.1.1", 400
-              )).to eq("/")
+                       'https://www.google.com/abc/def', 'localhost', '/path/a', 'GET', 'routey', '1.1.1.1', 400
+              )).to eq('/')
             end
           end
 
-          context "with a wildcard whitelist" do
-            it "should not enfore allowed domains properly" do
+          context 'with a wildcard whitelist' do
+            it 'should not enfore allowed domains properly' do
               http_redirect_policy = HttpRedirectPolicy.from_json({
-                "policy_id"=>"x1a1",
-                "data"=>{
-                  "enabled"=>true,
-                  "block"=>true,
-                  "whitelist"=>["*.allowed*.com"]
-                }
-              })
+                                                                    'policy_id' => 'x1a1',
+                                                                    'data' => {
+                                                                      'enabled' => true,
+                                                                      'block' => true,
+                                                                      'whitelist' => ['*.allowed*.com']
+                                                                    }
+                                                                  })
 
               expect(http_redirect_policy.enforce(
-                "https://allowed.com", "localhost", "/path/a", "GET", "routey", "1.1.1.1", 400
+                       'https://allowed.com', 'localhost', '/path/a', 'GET', 'routey', '1.1.1.1', 400
               )).to eq(nil)
 
               expect(http_redirect_policy.enforce(
-                "https://www.alloweddomain.com", "localhost", "/path/a", "GET", "routey", "1.1.1.1", 400
+                       'https://www.alloweddomain.com', 'localhost', '/path/a', 'GET', 'routey', '1.1.1.1', 400
               )).to eq(nil)
             end
           end
         end
 
-        context "with ports" do
-          it "should remove ports in redirect event" do
+        context 'with ports' do
+          it 'should remove ports in redirect event' do
             http_redirect_policy = HttpRedirectPolicy.from_json({
-              "policy_id" => "x1a1",
-              "data" => {
-                "enabled" => true,
-                "block" => false
-              }
-            })
+                                                                  'policy_id' => 'x1a1',
+                                                                  'data' => {
+                                                                    'enabled' => true,
+                                                                    'block' => false
+                                                                  }
+                                                                })
 
             expect(TCellAgent).to receive(:send_event).with({
-              "event_type" => "redirect",
-              "method" => "GET",
-              "from_domain" => "www.test.com",
-              "status_code" => 400 ,
-              "remote_addr" => "1.1.1.1",
-              "to" => "www.google.com",
-              "from" => "/path/a",
-              "rid" => "routex"
-            })
+                                                              'event_type' => 'redirect',
+                                                              'method' => 'GET',
+                                                              'from_domain' => 'www.test.com',
+                                                              'status_code' => 400,
+                                                              'remote_addr' => '1.1.1.1',
+                                                              'to' => 'www.google.com',
+                                                              'from' => '/path/a',
+                                                              'rid' => 'routex'
+                                                            })
 
             result = http_redirect_policy.enforce(
-              "https://www.google.com:80", "http://www.test.com", "/path/a", "GET", "routex", 400, "1.1.1.1"
+              'https://www.google.com:80', 'http://www.test.com', '/path/a', 'GET', 'routex', 400, '1.1.1.1'
             )
             expect(result).to eq(nil)
           end
         end
 
-        context "dataSchemeAllowed" do
-          context "is not allowed" do
-            it "should send an event" do
+        context 'data_scheme_allowed' do
+          context 'is not allowed' do
+            it 'should send an event' do
               @http_redirect_policy = HttpRedirectPolicy.from_json({
-                "policy_id" => "x1a1",
-                "data" => {
-                  "enabled" => true,
-                  "whitelist" => [],
-                  "block" => false,
-                  "dataSchemeAllowed" => false
-                }
-              })
+                                                                     'policy_id' => 'x1a1',
+                                                                     'data' => {
+                                                                       'enabled' => true,
+                                                                       'whitelist' => [],
+                                                                       'block' => false,
+                                                                       'data_scheme_allowed' => false
+                                                                     }
+                                                                   })
 
               expect(TCellAgent).to receive(:send_event).with({
-                "event_type" => "redirect",
-                "method" => "GET",
-                "from_domain" => "www.test.com",
-                "status_code" => 400 ,
-                "remote_addr" => "1.1.1.1",
-                "to" => "data:text/html base64",
-                "from" => "/path/a",
-                "rid" => "routex"
-              })
+                                                                'event_type' => 'redirect',
+                                                                'method' => 'GET',
+                                                                'from_domain' => 'www.test.com',
+                                                                'status_code' => 400,
+                                                                'remote_addr' => '1.1.1.1',
+                                                                'to' => 'data:text/html base64',
+                                                                'from' => '/path/a',
+                                                                'rid' => 'routex'
+                                                              })
 
               result = @http_redirect_policy.enforce(
-                "data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K",
-                "http://www.test.com",
-                "/path/a",
-                "GET",
-                "routex",
+                'data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K',
+                'http://www.test.com',
+                '/path/a',
+                'GET',
+                'routex',
                 400,
-                "1.1.1.1"
+                '1.1.1.1'
               )
               expect(result).to eq(nil)
             end
 
-            context "and blocking is enabled" do
-              it "should send an event and redirect to root" do
+            context 'and blocking is enabled' do
+              it 'should send an event and redirect to root' do
                 @http_redirect_policy = HttpRedirectPolicy.from_json({
-                  "policy_id" => "x1a1",
-                  "data" => {
-                    "enabled" => true,
-                    "whitelist" => [],
-                    "block" => true,
-                    "dataSchemeAllowed" => false
-                  }
-                })
+                                                                       'policy_id' => 'x1a1',
+                                                                       'data' => {
+                                                                         'enabled' => true,
+                                                                         'whitelist' => [],
+                                                                         'block' => true,
+                                                                         'data_scheme_allowed' => false
+                                                                       }
+                                                                     })
 
                 expect(TCellAgent).to receive(:send_event).with({
-                  "event_type" => "redirect",
-                  "method" => "GET",
-                  "from_domain" => "www.test.com",
-                  "status_code" => 400 ,
-                  "remote_addr" => "1.1.1.1",
-                  "to" => "data:text/html base64",
-                  "from" => "/path/a",
-                  "rid" => "routex"
-                })
+                                                                  'event_type' => 'redirect',
+                                                                  'method' => 'GET',
+                                                                  'from_domain' => 'www.test.com',
+                                                                  'status_code' => 400,
+                                                                  'remote_addr' => '1.1.1.1',
+                                                                  'to' => 'data:text/html base64',
+                                                                  'from' => '/path/a',
+                                                                  'rid' => 'routex'
+                                                                })
 
                 result = @http_redirect_policy.enforce(
-                  "data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K",
-                  "http://www.test.com",
-                  "/path/a",
-                  "GET",
-                  "routex",
+                  'data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K',
+                  'http://www.test.com',
+                  '/path/a',
+                  'GET',
+                  'routex',
                   400,
-                  "1.1.1.1"
+                  '1.1.1.1'
                 )
-                expect(result).to eq("/")
-
+                expect(result).to eq('/')
               end
             end
           end
 
-          context "is allowed" do
-            it "should not send an event" do
+          context 'is allowed' do
+            it 'should not send an event' do
               @http_redirect_policy = HttpRedirectPolicy.from_json({
-                "policy_id" => "x1a1",
-                "data" => {
-                  "enabled" => true,
-                  "whitelist" => [],
-                  "block" => false,
-                  "dataSchemeAllowed" => true
-                }
-              })
+                                                                     'policy_id' => 'x1a1',
+                                                                     'data' => {
+                                                                       'enabled' => true,
+                                                                       'whitelist' => [],
+                                                                       'block' => false,
+                                                                       'data_scheme_allowed' => true
+                                                                     }
+                                                                   })
 
               expect(TCellAgent).to_not receive(:send_event)
 
               result = @http_redirect_policy.enforce(
-                "data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K",
-                "http://www.test.com",
-                "/path/a",
-                "GET",
-                "routex",
+                'data:text/html base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K',
+                'http://www.test.com',
+                '/path/a',
+                'GET',
+                'routex',
                 400,
-                "1.1.1.1"
+                '1.1.1.1'
               )
 
               expect(result).to eq(nil)
@@ -236,8 +233,6 @@ module TCellAgent
           end
         end
       end
-
     end
-
   end
 end

data/spec/lib/tcell_agent/policies/http_tx_policy_spec.rb

@@ -4,17 +4,17 @@ module TCellAgent
   module Policies
     describe HttpTxPolicy do
       http_tx_policy_json = {
-        "policy_id"=>"01a1",
-        "types"=>{
-          "firehose"=>{"enabled"=>true}
+        'policy_id' => '01a1',
+        'types' => {
+          'firehose' => { 'enabled' => true }
         }
       }
       http_tx_from_json = HttpTxPolicy.from_json(http_tx_policy_json)
-      context "initialized with 3 items" do
-        it "returns true" do
-          expect(http_tx_from_json.policy_id).to eq("01a1")
-          expect(http_tx_from_json.firehose["enabled"]).to eq(true)
-          expect(http_tx_from_json.firehose["lite"]).to eq(false)
+      context 'initialized with 3 items' do
+        it 'returns true' do
+          expect(http_tx_from_json.policy_id).to eq('01a1')
+          expect(http_tx_from_json.firehose['enabled']).to eq(true)
+          expect(http_tx_from_json.firehose['lite']).to eq(false)
         end
       end
     end

data/spec/lib/tcell_agent/policies/login_policy_spec.rb

@@ -2,30 +2,29 @@ require 'spec_helper'
 
 module TCellAgent
   module Policies
-
     describe LoginFraudPolicy do
       policy_json_empty = {
-        "policy_id"=>"01a1",
-        "data"=>{
-          "options"=>{}
+        'policy_id' => '01a1',
+        'data' => {
+          'options' => {}
         }
       }
 
       policy_json_one = {
-        "policy_id"=>"01a1",
-        "data"=>{
-          "options"=>{
-            "login_failed_enabled"=>true,
-            "login_success_enabled"=>true,
-            "session_hijacking_enabled"=>true
+        'policy_id' => '01a1',
+        'data' => {
+          'options' => {
+            'login_failed_enabled' => true,
+            'login_success_enabled' => true,
+            'session_hijacking_enabled' => true
           }
         }
       }
 
       empty_policy = LoginFraudPolicy.from_json(policy_json_empty)
-      context "test empty agent" do
-        it "enabled is false" do
-          expect(empty_policy.policy_id).to eq("01a1")
+      context 'test empty agent' do
+        it 'enabled is false' do
+          expect(empty_policy.policy_id).to eq('01a1')
           expect(empty_policy.login_failed_enabled).to eq(false)
           expect(empty_policy.login_success_enabled).to eq(false)
           expect(empty_policy.session_hijacking_metrics).to eq(false)
@@ -33,15 +32,14 @@ module TCellAgent
       end
 
       policy_one = LoginFraudPolicy.from_json(policy_json_one)
-      context "enabled agent" do
-        it "enabled is true" do
-          expect(empty_policy.policy_id).to eq("01a1")
+      context 'enabled agent' do
+        it 'enabled is true' do
+          expect(empty_policy.policy_id).to eq('01a1')
           expect(policy_one.login_failed_enabled).to eq(true)
           expect(policy_one.login_success_enabled).to eq(true)
           expect(policy_one.session_hijacking_metrics).to eq(true)
         end
       end
     end
-
   end
 end