strongbolt 0.3.12 → 0.3.13

data/spec/dummy/db/migrate/20150630212251_create_strongbolt_tables_indexes.rb

@@ -16,6 +16,6 @@ class CreateStrongboltTablesIndexes < ActiveRecord::Migration
     add_index :strongbolt_users_tenants, :user_id
     add_index :strongbolt_users_tenants, :tenant_id
     add_index :strongbolt_users_tenants, :type
-    add_index :strongbolt_users_tenants, [:tenant_id, :type]
+    add_index :strongbolt_users_tenants, %i[tenant_id type]
   end
-end
+end

data/spec/dummy/db/migrate/20160531110509_fix_unique_group_members.rb

@@ -1,5 +1,5 @@
 class FixUniqueGroupMembers < ActiveRecord::Migration
   def change
-    add_index :strongbolt_user_groups_users, [:user_group_id, :user_id], unique: true, name: :index_strongbolt_user_groups_users_unique
+    add_index :strongbolt_user_groups_users, %i[user_group_id user_id], unique: true, name: :index_strongbolt_user_groups_users_unique
   end
 end

data/spec/fabricators/capability_fabricator.rb

@@ -1,4 +1,4 @@
-Fabricator(:capability, class_name: "Strongbolt::Capability") do
-  model           "User"
-  action          "find"
-end
+Fabricator(:capability, class_name: 'Strongbolt::Capability') do
+  model           'User'
+  action          'find'
+end

data/spec/fabricators/role_fabricator.rb

@@ -1,9 +1,9 @@
-Fabricator(:role, class_name: "Strongbolt::Role") do
-  name              { sequence(:name) { |i| "Role #{i}" } }
+Fabricator(:role, class_name: 'Strongbolt::Role') do
+  name { sequence(:name) { |i| "Role #{i}" } }
 end
 
 Fabricator(:role_with_user_groups, from: :role) do
   after_build do |role|
     role.user_groups << Fabricate(:user_group)
   end
-end
+end

data/spec/fabricators/user_fabricator.rb

@@ -1,3 +1,3 @@
 Fabricator :user do
-  username              "USER"
-end
+  username 'USER'
+end

data/spec/fabricators/user_group_fabricator.rb

@@ -1,9 +1,9 @@
-Fabricator(:user_group, class_name: "Strongbolt::UserGroup") do
-  name          { sequence(:name) { |i| "User Group #{i}" } }
+Fabricator(:user_group, class_name: 'Strongbolt::UserGroup') do
+  name { sequence(:name) { |i| "User Group #{i}" } }
 end
 
 Fabricator(:user_group_with_roles, from: :user_group) do
   after_build do |user_group|
     user_group.roles << Fabricate(:role)
   end
-end
+end

data/spec/fixtures/application.rb

@@ -4,7 +4,10 @@ require 'action_dispatch'
 
 module Rails
   class App
-    def env_config; {} end
+    def env_config
+      {}
+    end
+
     def routes
       return @routes if defined?(@routes)
       @routes = ActionDispatch::Routing::RouteSet.new
@@ -23,6 +26,6 @@ module Rails
   end
 
   def self.env
-    "test"
+    'test'
   end
-end
+end

data/spec/fixtures/controllers.rb

@@ -2,4 +2,4 @@ class TestController < ActionController::Base
   include Rails.application.routes.url_helpers
 
   def render(*attributes); end
-end
+end

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
-ENV["RAILS_ENV"] ||= 'test'
+ENV['RAILS_ENV'] ||= 'test'
 
 RSpec.configure do |config|
   # rspec-expectations config goes here. You can use an alternate
@@ -26,7 +26,7 @@ RSpec.configure do |config|
 end
 
 # The dummy application
-require File.expand_path("../dummy/config/environment", __FILE__)
+require File.expand_path('../dummy/config/environment', __FILE__)
 
 # require 'fixtures/application'
 # require 'fixtures/controllers'
@@ -40,7 +40,7 @@ require 'database_cleaner'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
@@ -89,10 +89,9 @@ RSpec.configure do |config|
     TestsMigrations.new.migrate :down
   end
 
-  Fabrication.configure do |config|
-    config.fabricator_path = 'spec/fabricators'
-    config.path_prefix = File.expand_path("../..", __FILE__)
+  Fabrication.configure do |fabrication_config|
+    fabrication_config.fabricator_path = 'spec/fabricators'
+    fabrication_config.path_prefix = File.expand_path('../..', __FILE__)
   end
-  puts File.expand_path("../..", __FILE__)
-
+  puts File.expand_path('../..', __FILE__)
 end

data/spec/strongbolt/bolted_controller_spec.rb

@@ -1,19 +1,14 @@
-require "spec_helper"
+require 'spec_helper'
 
 # We're testing BoltedController module through this one
-describe PostsController, :type => :controller do
-
+describe PostsController, type: :controller do
   before(:all) do
-    define_model "Post"
+    define_model 'Post'
     @user = User.create!
   end
 
   let(:user) { @user }
 
-
-
-
-
   #
   # Setup a current user
   #
@@ -24,7 +19,7 @@ describe PostsController, :type => :controller do
   #
   # Performs the right query given the action
   #
-  def perform action
+  def perform(action)
     case action
     when :index, :new then get action
     when :show, :edit then get action, id: 1
@@ -34,52 +29,40 @@ describe PostsController, :type => :controller do
     end
   end
 
-
-
-
-
   #
   # Helpers
   #
-  describe "helpers" do
+  describe 'helpers' do
     before { Strongbolt.current_user = User.create! }
     after { Strongbolt.current_user = nil }
 
-    describe "can?" do
-      it "should respond to can?" do
+    describe 'can?' do
+      it 'should respond to can?' do
         expect(PostsController.new).to respond_to :can?
       end
 
-      it "should call can? on current_user" do
+      it 'should call can? on current_user' do
         expect(Strongbolt.current_user).to receive(:can?).with :find, User
         PostsController.new.can? :find, User
       end
     end
 
-    describe "cannot?" do
-      it "should respond to cannot?" do
+    describe 'cannot?' do
+      it 'should respond to cannot?' do
         expect(PostsController.new).to respond_to :cannot?
       end
 
-      it "should call can? on current_user" do
+      it 'should call can? on current_user' do
         expect(Strongbolt.current_user).to receive(:cannot?).with :find, User
         PostsController.new.cannot? :find, User
       end
     end
   end
 
-
-
-
-
-
-
-
   #
   # Before Filter, set current user
   #
   describe 'before_action' do
-
     before do
       PostsController.skip_after_action :unset_current_user
       PostsController.skip_before_action :check_authorization
@@ -96,16 +79,16 @@ describe PostsController, :type => :controller do
         get :index
       end
 
-      it "should set nil user" do
+      it 'should set nil user' do
         expect(Strongbolt.current_user).to be_nil
       end
 
-      it "should have set $request" do
+      it 'should have set $request' do
         expect($request).to be_present
       end
     end
 
-    context "when user" do
+    context 'when user' do
       let(:user) { User.new }
 
       before do
@@ -113,18 +96,16 @@ describe PostsController, :type => :controller do
         get :index
       end
 
-      it "should set the user" do
+      it 'should set the user' do
         expect(Strongbolt.current_user).to eq user
       end
     end
-
   end
 
   #
   # After filter, unset current user
   #
   describe 'after_action' do
-
     before do
       PostsController.skip_before_action :check_authorization
     end
@@ -132,45 +113,43 @@ describe PostsController, :type => :controller do
       PostsController.before_action :check_authorization
     end
 
-    context "when a user is set" do
-
+    context 'when a user is set' do
       before do
         expect_any_instance_of(PostsController).to receive(:current_user)
           .and_return @user
         get :index
       end
 
-      it "should have unsetted the user" do
+      it 'should have unsetted the user' do
         expect(Strongbolt.current_user).to be_nil
       end
     end
-
   end
 
   #
   # Catching Grant::Error and Strongbolt::Unauthorized
   #
   describe 'catching Grant::Error' do
-    context "when unauthorized method exists" do
+    context 'when unauthorized method exists' do
       before do
         allow(controller).to receive :unauthorized
         expect_any_instance_of(PostsController).to receive(:index)
           .and_raise Strongbolt::Unauthorized
       end
 
-      it "should call unauthorized" do
+      it 'should call unauthorized' do
         expect_any_instance_of(PostsController).to receive(:unauthorized)
         get :index
       end
     end
 
-    context "when no unauthorized method" do
+    context 'when no unauthorized method' do
       before do
         expect_any_instance_of(PostsController).to receive(:index)
-          .and_raise Grant::Error.new "Error"
+          .and_raise Grant::Error.new 'Error'
       end
 
-      it "should call raise Strongbolt::Unauthorized" do
+      it 'should call raise Strongbolt::Unauthorized' do
         expect do
           get :index
         end.to raise_error Strongbolt::Unauthorized
@@ -178,28 +157,19 @@ describe PostsController, :type => :controller do
     end
   end
 
-
-
-
-
-
-
-
   #
   # Checking authorization on a high level
   #
-  describe "checking authorization" do
-
+  describe 'checking authorization' do
     #
     # When no authorization unrelated errors
     #
 
-    context "when no error" do
-
+    context 'when no error' do
       before(:all) do
         # Model linked to the controller
-        define_model "Post" do
-          self.table_name = "models"
+        define_model 'Post' do
+          self.table_name = 'models'
         end
       end
 
@@ -209,21 +179,20 @@ describe PostsController, :type => :controller do
           .and_return user
       end
 
-
       #
       # Call the right CRUD operation
       #
-      describe "calling the CRUD operations" do
+      describe 'calling the CRUD operations' do
         {
-          :index    => :find,
-          :show     => :find,
-          :edit     => :update,
-          :update   => :update,
-          :new      => :create,
-          :create   => :create
+          index: :find,
+          show: :find,
+          edit: :update,
+          update: :update,
+          new: :create,
+          create: :create
         }.each do |action, operation|
           context "when calling #{action}" do
-            it "should call the operation" do
+            it 'should call the operation' do
               expect(user).to receive(:can?).with(operation, Post).and_return true
               perform action
             end
@@ -231,31 +200,27 @@ describe PostsController, :type => :controller do
         end # End checking calling right can
       end
 
-
       #
       # When calling a custom action without CRUD associated
       #
-      context "when calling unmapped action" do
-
-        it "should raise ActionNotConfigured" do
+      context 'when calling unmapped action' do
+        it 'should raise ActionNotConfigured' do
           expect do
             get :custom
           end.to raise_error Strongbolt::ActionNotConfigured
         end
-
       end
 
-
       #
       # When not authorized
       #
-      context "when not authorized" do
+      context 'when not authorized' do
         before do
           expect(Strongbolt).to receive(:access_denied)
           expect(user).to receive(:can?).and_return false
         end
 
-        it "should raise Strongbolt::Unauthorized" do
+        it 'should raise Strongbolt::Unauthorized' do
           expect do
             get :index
           end.to raise_error Strongbolt::Unauthorized
@@ -265,85 +230,81 @@ describe PostsController, :type => :controller do
       #
       # When authorized
       #
-      context "when authorized" do
+      context 'when authorized' do
         before do
           expect(user).to receive(:can?).and_return true
         end
 
-        it "should not raise error" do
+        it 'should not raise error' do
           expect do
             get :index
           end.not_to raise_error
         end
       end
-
     end # End when no error
 
-
-
     #
     # Getting model name from controller name
     #
-    describe "model_for_authorization" do
-
+    describe 'model_for_authorization' do
       after do
-        undefine "ItemsController", "Item", "Namespace::Item",
-          "Namespace::ItemsController"
+        undefine 'ItemsController', 'Item', 'Namespace::Item',
+                 'Namespace::ItemsController'
       end
 
-      context "when no module" do
+      context 'when no module' do
         before do
-          define_controller "ItemsController"
-          define_model "Item"
+          define_controller 'ItemsController'
+          define_model 'Item'
         end
 
-        it "should return the right model" do
+        it 'should return the right model' do
           expect(ItemsController.model_for_authorization).to eq Item
         end
       end
 
-      context "when both have modules" do
+      context 'when both have modules' do
         before do
-          define_controller "Namespace::ItemsController"
-          define_model "Namespace::Item"
+          define_controller 'Namespace::ItemsController'
+          define_model 'Namespace::Item'
         end
 
-        it "should return the right model" do
+        it 'should return the right model' do
           expect(Namespace::ItemsController.model_for_authorization).to eq Namespace::Item
         end
       end
 
-      context "when only controller has module" do
+      context 'when only controller has module' do
         before do
-          define_controller "Namespace::ItemsController"
-          define_model "Item"
+          define_controller 'Namespace::ItemsController'
+          define_model 'Item'
         end
 
-        it "should return the right model" do
+        it 'should return the right model' do
           expect(Namespace::ItemsController.model_for_authorization).to eq Item
         end
       end
 
-      context "when only model has module" do
+      context 'when only model has module' do
         before do
-          define_controller "ItemsController"
-          define_model "Namespace::Item"
+          define_controller 'ItemsController'
+          define_model 'Namespace::Item'
         end
 
-        it "should raise error" do
+        it 'should raise error' do
           expect do
             ItemsController.model_for_authorization
           end.to raise_error Strongbolt::ModelNotFound
         end
       end
 
-      context "when cannot find" do
+      context 'when cannot find' do
         before do
-          define_controller "ItemsController"
-          undefine_model "Item"
+          define_controller 'ItemsController'
+          undefine_model 'Item'
         end
 
-        it "should return the right model" do
+        it 'should return the right model' do
           expect do
             ItemsController.model_for_authorization
           end.to raise_error Strongbolt::ModelNotFound
@@ -351,158 +312,125 @@ describe PostsController, :type => :controller do
       end
     end
 
-
-
     #
     # When the controller doesn't have any model associated
     #
 
     context "when controller doesn't have model" do
-
       before do
-        undefine_model "Post"
+        undefine_model 'Post'
         setup_session
       end
 
-      it "should raise error" do
+      it 'should raise error' do
         expect do
           get :index
         end.to raise_error Strongbolt::ModelNotFound
       end
-
     end # End when no model associated
 
     #
     # When no current user
     #
-    context "when no current user" do
+    context 'when no current user' do
       before do
         expect(Strongbolt).to receive(:current_user).and_return nil
         expect(Strongbolt).to receive(:logger).and_call_original
       end
 
-      it "should not raise error" do
+      it 'should not raise error' do
         get :index
       end
     end
-
   end # End describe authorizations
 
-
-
-
-
-
-
   #
   # Setting a specific model for a controller
   #
   describe 'setting specific model' do
-
     before do
-      define_model "Custom" do
-        self.table_name = "models"
+      define_model 'Custom' do
+        self.table_name = 'models'
       end
     end
     after { PostsController.model_for_authorization = nil }
 
-    context "when given as a string" do
-
-      context "and not exists" do
-        it "should raise error" do
+    context 'when given as a string' do
+      context 'and not exists' do
+        it 'should raise error' do
           expect do
-            PostsController.model_for_authorization = "FEge"
+            PostsController.model_for_authorization = 'FEge'
           end.to raise_error Strongbolt::ModelNotFound
         end
       end
 
       context 'when exists' do
-        before { PostsController.model_for_authorization = "Custom" }
+        before { PostsController.model_for_authorization = 'Custom' }
 
-        it "should set it" do
+        it 'should set it' do
           expect(PostsController.model_for_authorization).to eq Custom
         end
       end
-
     end # End when given as a string
 
-    context "when given as a model" do
+    context 'when given as a model' do
       before { PostsController.model_for_authorization = Custom }
 
-      it "should set it" do
+      it 'should set it' do
         expect(PostsController.model_for_authorization).to eq Custom
       end
     end
-
   end
 
-
-
-
-
   #
   # Fetching authorization model when not specified
   #
-  describe "model_for_authorization" do
-
-    context "when model is infered from controller" do
+  describe 'model_for_authorization' do
+    context 'when model is infered from controller' do
       before do
-        define_model "Post"
+        define_model 'Post'
         get :index
       end
 
-      it "should return the model" do
+      it 'should return the model' do
         expect(PostsController.model_for_authorization).to eq Post
       end
     end
 
-    context "when model cannot be infered" do
+    context 'when model cannot be infered' do
       before do
-        undefine_model "Post"
+        undefine_model 'Post'
       end
 
-      it "should raise ModelNotFound" do
+      it 'should raise ModelNotFound' do
         expect do
           PostsController.model_for_authorization
         end.to raise_error Strongbolt::ModelNotFound
       end
     end
-
   end
 
-
-
-
-
-
-
-
   #
   # Skipping controller authorization
   #
   describe 'skip_controller_authorization' do
-
     after { PostsController.before_action :check_authorization }
 
-    context "when no argument" do
-
+    context 'when no argument' do
       before { PostsController.skip_controller_authorization }
 
       RESTFUL_ACTIONS.each do |action|
-        it "should not call check_authorization" do
+        it 'should not call check_authorization' do
           expect_any_instance_of(PostsController).not_to receive(:check_authorization)
           perform action
         end
       end
-
     end
 
     context 'with only argument' do
-
       before { PostsController.skip_controller_authorization only: skipped_actions }
 
-      context "when 1 action" do
-
+      context 'when 1 action' do
         let(:skipped_actions) { :index }
 
         RESTFUL_ACTIONS.each do |action|
@@ -515,12 +443,10 @@ describe PostsController, :type => :controller do
             perform action
           end
         end
-
       end # End 1 action
 
-      context "when several actions" do
-
-        let(:skipped_actions) { [:show, :index] }
+      context 'when several actions' do
+        let(:skipped_actions) { %i[show index] }
 
         RESTFUL_ACTIONS.each do |action|
           it "should skip the right ones - #{action}" do
@@ -532,17 +458,13 @@ describe PostsController, :type => :controller do
             perform action
           end
         end
-
       end # End several actions
-
     end # End when only argument
 
-    context "with except argument" do
-
+    context 'with except argument' do
       before { PostsController.skip_controller_authorization except: preserved_actions }
 
-      context "when 1 action" do
-
+      context 'when 1 action' do
         let(:preserved_actions) { :index }
 
         RESTFUL_ACTIONS.each do |action|
@@ -555,12 +477,10 @@ describe PostsController, :type => :controller do
             perform action
           end
         end
-
       end # End 1 action
 
-      context "when several actions" do
-
-        let(:preserved_actions) { [:show, :index] }
+      context 'when several actions' do
+        let(:preserved_actions) { %i[show index] }
 
         RESTFUL_ACTIONS.each do |action|
           it "should preserve the right ones - #{action}" do
@@ -572,20 +492,14 @@ describe PostsController, :type => :controller do
             perform action
           end
         end
-
       end # End several actions
-
     end # End except argument
-
   end # End skipping controller authorization
 
-
-
-
   #
   # Skip all authorizations checking
   #
-  describe "skip_all_authorization" do
+  describe 'skip_all_authorization' do
     #
     # The controller raiser error if grant enabled
     #
@@ -602,20 +516,20 @@ describe PostsController, :type => :controller do
       end
     end
 
-    it "should raise an error" do
+    it 'should raise an error' do
       expect do
         get :index
       end.to raise_error Strongbolt::Unauthorized
     end
 
-    context "when skipping" do
+    context 'when skipping' do
       before { PostsController.skip_all_authorization only: :index }
       after do
         PostsController.before_action :check_authorization
         PostsController.skip_around_action :disable_authorization
       end
 
-      it "should not raise error" do
+      it 'should not raise error' do
         expect do
           get :index
         end.not_to raise_error
@@ -623,84 +537,72 @@ describe PostsController, :type => :controller do
     end
   end # End skipping all authorization
 
-
-
-
-
   #
   # Mapping custom action to CRUD operation
   #
-  describe "authorize_as_" do
+  describe 'authorize_as_' do
     before do
       setup_session
-      define_model "Post"
+      define_model 'Post'
     end
 
-    [:find, :update, :create, :destroy].each do |operation|
+    %i[find update create destroy].each do |operation|
       context "authorize_as_#{operation}" do
         before do
           PostsController.send "authorize_as_#{operation}", :custom, :other
         end
 
-        it "should respond_to" do
+        it 'should respond_to' do
           expect(PostsController).to respond_to "authorize_as_#{operation}"
         end
 
-        it "should call the proper operation" do
+        it 'should call the proper operation' do
           expect(user).to receive(:can?).with(operation, Post).and_return true
           get :custom
         end
-
       end
     end
   end
 
-
-
-
   #
   # Render without authorization
   #
-  describe "render_without_authorization" do
-
+  describe 'render_without_authorization' do
     after { PostsController.render_with_authorization }
 
-    it "should have aliased render" do
+    it 'should have aliased render' do
       expect(PostsController.new).to respond_to :_render
     end
 
-    context "when no arg" do
+    context 'when no arg' do
       before do
         PostsController.render_without_authorization
         expect(Strongbolt).not_to receive(:without_authorization)
       end
 
-      it "should perform without auth when index" do
+      it 'should perform without auth when index' do
         get :index
       end
 
-      it "should perform without auth when show" do
+      it 'should perform without auth when show' do
         get :show, id: 1
       end
     end
 
-    context "when 1 arg" do
+    context 'when 1 arg' do
       before do
         PostsController.render_without_authorization :index
       end
 
-      it "should perform without auth when index" do
+      it 'should perform without auth when index' do
         expect(Strongbolt).to receive(:without_authorization)
         get :index
       end
 
-      it "should not perform without auth when show" do
+      it 'should not perform without auth when show' do
         expect(Strongbolt).not_to receive(:without_authorization)
         get :show, id: 1
       end
     end
-
   end
-
-
 end