strongbolt 0.3.12 → 0.3.13

data/lib/strongbolt/configuration.rb

@@ -1,14 +1,12 @@
 module Strongbolt
-
   module Configuration
-
     #
     # A placeholder class for logger when not defined
     # Just print what's given
     #
     class DefaultLogger
-      def method_missing method_name, text = nil, &block
-        puts "[#{method_name}] #{block.present? ? block.call : text}"
+      def method_missing(method_name, text = nil, &block)
+        puts "[#{method_name}] #{block.present? ? yield : text}"
       end
     end
 
@@ -21,7 +19,9 @@ module Strongbolt
     #
     # Returns the constantize version of user class
     #
-    def self.user_class_constant() self.user_class.constantize; end
+    def self.user_class_constant
+      self.user_class.constantize
+    end
 
     #
     # Sets the logger used by Strongbolt
@@ -33,20 +33,22 @@ module Strongbolt
     # Sets the tenants of the application
     #
     @@tenants = []
-    def self.tenants= tenants
+    def self.tenants=(tenants)
       @@tenants = []
-      [*tenants].each {|t| add_tenant t}
+      [*tenants].each { |t| add_tenant t }
     end
 
     #
     # Returns the tenants
     #
-    def self.tenants() @@tenants; end
+    def self.tenants
+      @@tenants
+    end
 
     #
     # Adds a tenant if not in the list
     #
-    def self.add_tenant tenant
+    def self.add_tenant(tenant)
       tenant = tenant.constantize if tenant.is_a? String
       unless @@tenants.any? { |m| m.name == tenant.name }
         tenant.send :tenant
@@ -54,7 +56,6 @@ module Strongbolt
       end
     end
 
-
     #
     # Allows to configure what happens when the access is denied,
     # or call the block that has been given
@@ -62,30 +63,30 @@ module Strongbolt
     # The block access denied receives as arguments:
     #   user, instance, action, request_path
     #
-    def self.access_denied *args, &block
+    def self.access_denied(*args, &block)
       if block.present?
         @@access_denied_block = block
-      else
-        @@access_denied_block.call(*args) if defined?(@@access_denied_block)
+      elsif defined?(@@access_denied_block)
+        @@access_denied_block.call(*args)
       end
     end
 
     #
     # Allows to set Capability Models list
     #
-    def self.models= models
+    def self.models=(models)
       Strongbolt::Capability.add_models models
     end
 
     #
     # Controllers to skip controller authorization check ups
     #
-    def self.skip_controller_authorization_for *controllers
+    def self.skip_controller_authorization_for(*controllers)
       ActiveSupport.on_load :action_controller do
         controllers.each do |controller|
           begin
             "#{controller.camelize}Controller".constantize.send :skip_controller_authorization
-          rescue NameError => e
+          rescue NameError
             raise NameError, "Controller #{controller} doesn't correspond to a valid controller name"
           end
         end
@@ -96,7 +97,7 @@ module Strongbolt
     # Default permissions
     #
     @@default_capabilities = []
-    def self.default_capabilities= list
+    def self.default_capabilities=(list)
       @@default_capabilities = list.inject([]) do |capabilities, hash|
         capabilities.concat Capability.from_hash(hash)
       end
@@ -105,7 +106,5 @@ module Strongbolt
     def self.default_capabilities
       @@default_capabilities
     end
-
   end
-
 end

data/lib/strongbolt/controllers/url_helpers.rb

@@ -9,13 +9,13 @@ module Strongbolt
     # It's not very nice like that but would be too complicated to do like Devise for now...
     #
     module UrlHelpers
-      URLS = %w{role  user_group user_group_user role_capability}
+      URLS = %w[role user_group user_group_user role_capability].freeze
 
       #
       # Creates the url helpers for the specific url and scope
       #
-      def self.create_url_helper url, scope=nil
-        [:path, :url].each do |path_or_url|
+      def self.create_url_helper(url, scope = nil)
+        %i[path url].each do |path_or_url|
           class_eval <<-URL_HELPERS
             def #{scope.present? ? "#{scope}_" : ''}#{url}_#{path_or_url} *args
               send(:main_app).send("#{scope.present? ? "#{scope}_" : ''}strongbolt_#{url}_#{path_or_url}", *args)
@@ -30,8 +30,8 @@ module Strongbolt
       URLS.each do |url|
         create_url_helper url
         create_url_helper url.pluralize
-        [:new, :edit].each { |scope| create_url_helper url, scope }
+        %i[new edit].each { |scope| create_url_helper url, scope }
       end
     end
   end
-end
+end

data/lib/strongbolt/engine.rb

@@ -1,25 +1,25 @@
-require "strongbolt/rails/routes"
+require 'strongbolt/rails/routes'
 
-require "strongbolt/helpers"
-require "strongbolt/controllers/url_helpers"
+require 'strongbolt/helpers'
+require 'strongbolt/controllers/url_helpers'
 
 module Strongbolt
   class Engine < ::Rails::Engine
-
     initializer 'strongbolt.assets.precompile' do |app|
-      %w(javascripts).each do |sub|
+      next if Rails.application.config.try(:api_only)
+      %w[javascripts].each do |sub|
         app.config.assets.paths << root.join('app', 'assets', sub).to_s
       end
     end
 
-    initializer "strongbolt.helpers" do
+    initializer 'strongbolt.helpers' do
       ActionView::Base.send :include, Strongbolt::Helpers
     end
 
     #
     # Session Store should be accessible anytime
     #
-    initializer "strongbolt.session" do
+    initializer 'strongbolt.session' do
       if defined? ActiveRecord::SessionStore::Session
         ActiveRecord::SessionStore::Session.grant(:find, :create, :update, :destroy) { true }
       end
@@ -28,7 +28,7 @@ module Strongbolt
     #
     # Avoids authorization checking in the middleware
     #
-    initializer "strongbolt.devise_integration" do
+    initializer 'strongbolt.devise_integration' do
       if defined?(Warden) && defined?(Warden::SessionSerializer)
         Warden::SessionSerializer.perform_without_authorization :store, :fetch, :delete
       end
@@ -37,7 +37,7 @@ module Strongbolt
     #
     # Initialize our custom url helpers
     #
-    initializer "strongbolt.url_helpers" do
+    initializer 'strongbolt.url_helpers' do
       Strongbolt.include_helpers Strongbolt::Controllers
     end
   end

data/lib/strongbolt/errors.rb

@@ -19,13 +19,13 @@ module Strongbolt
       if @message
         @message
       else
-        user_str = user == nil ? 'Anonymous' : "#{user.try(:class).try(:name)}:#{user.try :id}"
-        model_str = model.is_a?(Class) ? "#{model.try :name}" : "#{model.try(:class).try(:name)}:#{model.try :id}"
+        user_str = user.nil? ? 'Anonymous' : "#{user.try(:class).try(:name)}:#{user.try :id}"
+        model_str = model.is_a?(Class) ? (model.try :name).to_s : "#{model.try(:class).try(:name)}:#{model.try :id}"
         "#{action} permission not granted to #{user_str} for resource #{model_str}"
       end
     end
   end
-  
+
   ModelNotFound = Class.new StrongboltError
   ActionNotConfigured = Class.new StrongboltError
 
@@ -35,4 +35,4 @@ module Strongbolt
   TenantError = Class.new StrongboltError
   InverseAssociationNotConfigured = Class.new TenantError
   DirectAssociationNotConfigured = Class.new TenantError
-end
+end

data/lib/strongbolt/generators/migration.rb

@@ -3,7 +3,7 @@ require 'rails/generators/active_record'
 module Strongbolt
   module Generators
     module Migration
-      def self.included receiver
+      def self.included(receiver)
         receiver.send :include, Rails::Generators::Migration
         receiver.send :include, InstanceMethods
         receiver.extend         ClassMethods
@@ -17,14 +17,12 @@ module Strongbolt
           next_migration_number = current_migration_number(dirname) + 1
           ActiveRecord::Migration.next_migration_number(next_migration_number)
         end
-
       end
 
       module InstanceMethods
-
         def copy_migration(source, target)
-          if self.class.migration_exists?("db/migrate", "#{target}")
-            say_status "skipped", "Migration #{target}.rb already exists"
+          if self.class.migration_exists?('db/migrate', target.to_s)
+            say_status 'skipped', "Migration #{target}.rb already exists"
           else
             migration_template "#{source}.rb", "db/migrate/#{target}.rb"
           end
@@ -32,4 +30,4 @@ module Strongbolt
       end
     end
   end
-end
+end

data/lib/strongbolt/helpers.rb

@@ -1,18 +1,16 @@
 module Strongbolt
   module Helpers
-    def can? *args, &block
+    def can?(*args, &block)
       # Block can be used when testing an instance
       Strongbolt.without_authorization do
-        if block.present?
-          args.insert 1, block.call
-        end
+        args.insert 1, yield if block.present?
 
-        return current_user.can? *args
+        return current_user.can?(*args)
       end
     end
 
-    def cannot? *args, &block
-      ! can? *args, &block
+    def cannot?(*args, &block)
+      !can?(*args, &block)
     end
   end
 end

data/lib/strongbolt/rails/routes.rb

@@ -4,17 +4,17 @@ module ActionDispatch::Routing
   #
   class Mapper
     def strongbolt
-      scope :module => :strongbolt do
+      scope module: :strongbolt do
         resources :user_groups do
-          resources :user_groups_users, as: :users, path: 'users', only: [:create, :destroy]
+          resources :user_groups_users, as: :users, path: 'users', only: %i[create destroy]
         end
 
         resources :roles do
-          resources :capabilities, only: [:create, :destroy] do
+          resources :capabilities, only: %i[create destroy] do
             delete :destroy, on: :collection
           end
         end
       end
     end
   end
-end
+end

data/lib/strongbolt/role.rb

@@ -1,23 +1,22 @@
 module Strongbolt
   class Role < Base
-
     acts_as_nested_set
 
     validates :name, presence: true
 
     has_many :roles_user_groups,
-      :class_name => "Strongbolt::RolesUserGroup",
-      :dependent => :restrict_with_exception,
-      :inverse_of => :role
-    has_many :user_groups, :through => :roles_user_groups
+             class_name: 'Strongbolt::RolesUserGroup',
+             dependent: :restrict_with_exception,
+             inverse_of: :role
+    has_many :user_groups, through: :roles_user_groups
 
     has_many :users, through: :user_groups
 
     has_many :capabilities_roles,
-      :class_name => "Strongbolt::CapabilitiesRole",
-      :dependent => :delete_all,
-      :inverse_of => :role
-    has_many :capabilities, :through => :capabilities_roles
+             class_name: 'Strongbolt::CapabilitiesRole',
+             dependent: :delete_all,
+             inverse_of: :role
+    has_many :capabilities, through: :capabilities_roles
 
     before_destroy :should_not_have_children
 
@@ -29,15 +28,15 @@ module Strongbolt
     #
     def inherited_capabilities
       Strongbolt::Capability.joins(:roles)
-        .where("strongbolt_roles.lft < :lft AND strongbolt_roles.rgt > :rgt", lft: lft, rgt: rgt)
-        .distinct
+                            .where('strongbolt_roles.lft < :lft AND strongbolt_roles.rgt > :rgt', lft: lft, rgt: rgt)
+                            .distinct
     end
 
     private
 
     def should_not_have_children
       if children.count > 0
-        raise ActiveRecord::DeleteRestrictionError.new :children
+        raise ActiveRecord::DeleteRestrictionError, :children
       end
     end
   end

data/lib/strongbolt/roles_user_group.rb

@@ -1,14 +1,14 @@
 module Strongbolt
   class RolesUserGroup < Base
-    authorize_as "Strongbolt::UserGroup"
+    authorize_as 'Strongbolt::UserGroup'
 
     belongs_to :user_group,
-      :class_name => "Strongbolt::UserGroup",
-      :inverse_of => :roles_user_groups
+               class_name: 'Strongbolt::UserGroup',
+               inverse_of: :roles_user_groups
 
     belongs_to :role,
-      :class_name => "Strongbolt::Role",
-      :inverse_of => :roles_user_groups
+               class_name: 'Strongbolt::Role',
+               inverse_of: :roles_user_groups
 
     validates_presence_of :user_group, :role
   end

data/lib/strongbolt/rspec.rb

@@ -19,11 +19,11 @@ if defined?(RSpec)
     end
 
     config.around(:each) do |example|
-      Strongbolt.without_authorization &example
+      Strongbolt.without_authorization(&example)
       # Clear all the User authorizations that could have been defined
       User.clear_authorizations
       # Removes the user from current_user to avoid leaks
       Strongbolt.current_user = nil
     end
   end
-end
+end

data/lib/strongbolt/rspec/user.rb

@@ -7,12 +7,11 @@ Strongbolt.user_class_constant.class_eval do
   # Best to use a class context and use class instance variables
   #
   class << self
-
     def authorizations
       @authorizations ||= {}
     end
 
-    def set_authorization_for user, authorized, *args
+    def set_authorization_for(user, authorized, *args)
       return if user.new_record?
 
       self.authorizations[user.id] ||= {}
@@ -23,22 +22,22 @@ Strongbolt.user_class_constant.class_eval do
       @authorizations = {}
     end
 
-    def authorized? user, *args
+    def authorized?(user, *args)
       # Cannot do if user not saved
       return false if user.new_record?
       key = key_for(*args)
       if self.authorizations[user.id].present? && self.authorizations[user.id][key].present?
         return self.authorizations[user.id][key]
       else
-        user._can? *args
+        user._can?(*args)
       end
     end
 
-    def key_for *args
+    def key_for(*args)
       action = args[0]
       instance = args[1]
       attrs = args[2] || :any
-      all_instances = (args[3] || false) ? "all" : "tenanted"
+      all_instances = args[3] || false ? 'all' : 'tenanted'
       if instance.is_a?(ActiveRecord::Base)
         model = instance.class.name
         if instance.new_record?
@@ -51,21 +50,20 @@ Strongbolt.user_class_constant.class_eval do
         "#{action}-#{model}-#{attrs}-#{all_instances}"
       end
     end
-
   end
 
   #
   # 2 methods to setup mocking and stubs
   #
   def init
-    if RSpec::Mocks::Version::STRING >= "3.0"
-      require "rspec/mocks/standalone"
+    if RSpec::Mocks::Version::STRING >= '3.0'
+      require 'rspec/mocks/standalone'
     else
-      RSpec::Mocks::setup(self) unless self.respond_to? :allow
+      RSpec::Mocks.setup(self) unless self.respond_to? :allow
     end
   end
 
-  def setup_stub authorized, arguments
+  def setup_stub(authorized, arguments)
     init
     # Set the authorizations on a class level
     self.class.set_authorization_for self, authorized, *arguments
@@ -76,15 +74,15 @@ Strongbolt.user_class_constant.class_eval do
   #
   alias_method :_can?, :can?
 
-  def can? *args
+  def can?(*args)
     self.class.authorized? self, *args
   end
 
-  def can! *args
+  def can!(*args)
     setup_stub true, args
   end
 
-  def cannot! *args
+  def cannot!(*args)
     setup_stub false, args
   end
-end
+end