strongbolt 0.3.12 → 0.3.13

data/spec/strongbolt/configuration_spec.rb

@@ -1,42 +1,35 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Strongbolt::Configuration do
-
-
   #
   # User class
   #
-  describe "user class" do
-
-    it "should default to User" do
-      expect(Strongbolt::Configuration.user_class).to eq "User"
+  describe 'user class' do
+    it 'should default to User' do
+      expect(Strongbolt::Configuration.user_class).to eq 'User'
     end
 
-    context "when setting it" do
-      before { Strongbolt::Configuration.user_class = "Account" }
-      after { Strongbolt::Configuration.user_class = "User" }
+    context 'when setting it' do
+      before { Strongbolt::Configuration.user_class = 'Account' }
+      after { Strongbolt::Configuration.user_class = 'User' }
 
-      it "should give it" do
-        expect(Strongbolt::Configuration.user_class).to eq "Account"
+      it 'should give it' do
+        expect(Strongbolt::Configuration.user_class).to eq 'Account'
       end
     end
-
   end
 
-
-
   #
   # Setting up tenants
   #
   describe 'tenants=' do
-
     before do
-      define_model "Model" do
-        self.table_name = "models"
+      define_model 'Model' do
+        self.table_name = 'models'
       end
 
-      define_model "OtherModel" do
-        self.table_name = "models"
+      define_model 'OtherModel' do
+        self.table_name = 'models'
       end
 
       expect(Model).to receive(:send).with :tenant
@@ -44,76 +37,70 @@ describe Strongbolt::Configuration do
     end
     after { Strongbolt::Configuration.tenants = [] }
 
-    it "should tenant the models" do
-      Strongbolt::Configuration.tenants = "Model", OtherModel, Model
+    it 'should tenant the models' do
+      Strongbolt::Configuration.tenants = 'Model', OtherModel, Model
       expect(Strongbolt::Configuration.tenants).to eq [Model, OtherModel]
     end
-
   end
 
   #
   # Configuring Capability Models
   #
-  describe "models=" do
+  describe 'models=' do
     before do
-      Strongbolt::Configuration.models = "OtherModel", "Model"
+      Strongbolt::Configuration.models = 'OtherModel', 'Model'
     end
     after do
       Strongbolt::Capability.models = nil
     end
 
-    it "should set Capability::Models" do
-      expect(Strongbolt::Capability.models).to eq ["Model", "OtherModel", "Strongbolt::Capability", "Strongbolt::Role", "Strongbolt::UserGroup", "Strongbolt::UsersTenant"]
+    it 'should set Capability::Models' do
+      expect(Strongbolt::Capability.models).to eq ['Model', 'OtherModel', 'Strongbolt::Capability', 'Strongbolt::Role', 'Strongbolt::UserGroup', 'Strongbolt::UsersTenant']
     end
 
-    context "when adding other models" do
+    context 'when adding other models' do
       before do
-        Strongbolt::Configuration.models = "Model", "LastModel"
+        Strongbolt::Configuration.models = 'Model', 'LastModel'
       end
 
-      it "should merge with current models" do
-        expect(Strongbolt::Capability.models).to eq ["LastModel", "Model", "OtherModel", "Strongbolt::Capability", "Strongbolt::Role", "Strongbolt::UserGroup", "Strongbolt::UsersTenant"]
+      it 'should merge with current models' do
+        expect(Strongbolt::Capability.models).to eq ['LastModel', 'Model', 'OtherModel', 'Strongbolt::Capability', 'Strongbolt::Role', 'Strongbolt::UserGroup', 'Strongbolt::UsersTenant']
       end
     end
 
-    context "when adding 1 model" do
+    context 'when adding 1 model' do
       before do
-        Strongbolt::Configuration.models = "BottomModel"
+        Strongbolt::Configuration.models = 'BottomModel'
       end
 
-      it "should merge with current models" do
-        expect(Strongbolt::Capability.models).to eq ["BottomModel", "Model", "OtherModel", "Strongbolt::Capability", "Strongbolt::Role", "Strongbolt::UserGroup", "Strongbolt::UsersTenant"]
+      it 'should merge with current models' do
+        expect(Strongbolt::Capability.models).to eq ['BottomModel', 'Model', 'OtherModel', 'Strongbolt::Capability', 'Strongbolt::Role', 'Strongbolt::UserGroup', 'Strongbolt::UsersTenant']
       end
     end
-  end #/models=
-
-
+  end # /models=
 
   #
   # Setting default permissions
   #
-  describe "default_capabilities=" do
-
+  describe 'default_capabilities=' do
     before do
       Strongbolt::Configuration.default_capabilities = [
-        {:model => "User", :actions => :all},
-        {:model => "Model", :actions => "find"}
+        { model: 'User', actions: :all },
+        { model: 'Model', actions: 'find' }
       ]
     end
     after do
       Strongbolt::Configuration.default_capabilities = []
     end
 
-    it "should return 5 Capabilities" do
+    it 'should return 5 Capabilities' do
       expect(Strongbolt::Configuration.default_capabilities.size).to eq 5
     end
 
-    it "should return Capability" do
+    it 'should return Capability' do
       Strongbolt::Configuration.default_capabilities.each do |c|
         expect(c).to be_a Strongbolt::Capability
       end
     end
-
   end
-
 end

data/spec/strongbolt/controllers/url_helpers_spec.rb

@@ -1,10 +1,9 @@
-require "spec_helper"
-require "strongbolt/controllers/url_helpers"
+require 'spec_helper'
+require 'strongbolt/controllers/url_helpers'
 
 module Strongbolt
   module Controllers
     describe UrlHelpers do
-      
       let(:helpersClass) do
         Class.new do
           def main_app; end
@@ -19,16 +18,15 @@ module Strongbolt
 
       it { should respond_to :new_role_path }
 
-      describe "edit_role_path" do
-        let(:main_app) { double("main_app", :edit_strongbolt_role_path => true) }
-        
-        it "should call new_strongbolt_role_path on the main app" do
+      describe 'edit_role_path' do
+        let(:main_app) { double('main_app', edit_strongbolt_role_path: true) }
+
+        it 'should call new_strongbolt_role_path on the main app' do
           expect(helpers).to receive(:main_app).and_return main_app
           expect(main_app).to receive(:edit_strongbolt_role_path).with 2
           helpers.edit_role_path 2
         end
       end
-
     end
   end
-end
+end

data/spec/strongbolt/helpers_spec.rb

@@ -1,12 +1,11 @@
-require "spec_helper"
-require "strongbolt/helpers"
+require 'spec_helper'
+require 'strongbolt/helpers'
 
 describe Strongbolt::Helpers do
-
   before do
     @user = User.create!
 
-    define("Helper", Object) do
+    define('Helper', Object) do
       include Strongbolt::Helpers
     end
 
@@ -19,25 +18,24 @@ describe Strongbolt::Helpers do
 
   let(:user) { @user }
   let(:helper) { Helper.new }
-  
-  describe "can?" do
+
+  describe 'can?' do
     before do
-      expect(user).to receive(:can?).with :find, "me"
+      expect(user).to receive(:can?).with :find, 'me'
     end
 
-    it "should call the user method" do
-      helper.can?(:find) { "me" }
+    it 'should call the user method' do
+      helper.can?(:find) { 'me' }
     end
   end
-  
-  describe "cannot?" do
+
+  describe 'cannot?' do
     before do
-      expect(user).to receive(:can?).with :find, "me"
+      expect(user).to receive(:can?).with :find, 'me'
     end
 
-    it "should call the user method" do
-      helper.cannot? :find, "me"
+    it 'should call the user method' do
+      helper.cannot? :find, 'me'
     end
   end
-
-end
+end

data/spec/strongbolt/role_spec.rb

@@ -1,9 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Strongbolt
-
   describe Role do
-    
     let(:role) { Role.new name: 'Moderator' }
 
     subject { role }
@@ -12,79 +10,78 @@ module Strongbolt
 
     it { is_expected.to validate_presence_of :name }
 
-    it { is_expected.to have_many(:roles_user_groups).class_name("Strongbolt::RolesUserGroup")
-      .dependent :restrict_with_exception }
+    it {
+      is_expected.to have_many(:roles_user_groups).class_name('Strongbolt::RolesUserGroup')
+                                                  .dependent :restrict_with_exception
+    }
     it { is_expected.to have_many(:user_groups).through :roles_user_groups }
 
-    it { is_expected.to have_many(:users).through :user_groups  }
-    
-    it { is_expected.to have_many(:capabilities_roles).class_name("Strongbolt::CapabilitiesRole")
-      .dependent :delete_all }
+    it { is_expected.to have_many(:users).through :user_groups }
+
+    it {
+      is_expected.to have_many(:capabilities_roles).class_name('Strongbolt::CapabilitiesRole')
+                                                   .dependent :delete_all
+    }
     it { is_expected.to have_many(:capabilities).through :capabilities_roles }
 
-    it { is_expected.to belong_to(:parent).class_name("Strongbolt::Role") }
+    it { is_expected.to belong_to(:parent).class_name('Strongbolt::Role') }
 
-    describe "inherited capabilities" do
-      
+    describe 'inherited capabilities' do
       before do
         # A family
-        grandfather = Role.create! name: "GrandFather"
-        father = Role.create! name: "Father", parent: grandfather
-        sibling = Role.create! name: "Sibling"
+        grandfather = Role.create! name: 'GrandFather'
+        father = Role.create! name: 'Father', parent: grandfather
+        sibling = Role.create! name: 'Sibling'
         role.parent = father
         role.save!
-        child = Role.create! name: "Child", parent: role
+        child = Role.create! name: 'Child', parent: role
 
         # Some capabilities
         begin
-          role.capabilities.create! model: "Model", action: "create"
+          role.capabilities.create! model: 'Model', action: 'create'
         rescue => e
           puts e.record.capabilities_roles[0].errors.full_messages
         end
-        child.capabilities.create! model: "Model", action: "destroy"
-        @inherited1 = father.capabilities.create! model: "Model", action: "update"
-        @inherited2 = grandfather.capabilities.create! model: "Model", action: "find"
-        sibling.capabilities.create! model: "User", action: "find"
+        child.capabilities.create! model: 'Model', action: 'destroy'
+        @inherited1 = father.capabilities.create! model: 'Model', action: 'update'
+        @inherited2 = grandfather.capabilities.create! model: 'Model', action: 'find'
+        sibling.capabilities.create! model: 'User', action: 'find'
       end
 
       let(:inherited_capabilities) { role.inherited_capabilities }
 
-      it "should have 2 inherited_capabilities" do
+      it 'should have 2 inherited_capabilities' do
         expect(inherited_capabilities.size).to eq 2
       end
 
-      it "should have the right ones" do
+      it 'should have the right ones' do
         expect(inherited_capabilities).to include @inherited1
         expect(inherited_capabilities).to include @inherited2
       end
-
     end
 
-    describe 'destroy' do |variable|
+    describe 'destroy' do |_variable|
       before { role.save! }
 
-      context "when have user groups" do
-        before { role.user_groups << UserGroup.create!(name: "User Group") }
+      context 'when have user groups' do
+        before { role.user_groups << UserGroup.create!(name: 'User Group') }
 
-        it "should raise error when destroy" do
+        it 'should raise error when destroy' do
           expect do
             role.destroy
           end.to raise_error ActiveRecord::DeleteRestrictionError
         end
       end
 
-      context "when have children" do
-        before { Role.create! name: "Child", parent: role }
+      context 'when have children' do
+        before { Role.create! name: 'Child', parent: role }
 
-        it "should raise an error when destroy" do
+        it 'should raise an error when destroy' do
           expect do
             role.destroy
           end.to raise_error ActiveRecord::DeleteRestrictionError
         end
       end
-
     end
-
   end
-
-end
+end

data/spec/strongbolt/tenantable_spec.rb

@@ -1,8 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Strongbolt::Tenantable do
-
-  it "should have been included in ActiveRecord::Base" do
+  it 'should have been included in ActiveRecord::Base' do
     expect(ActiveRecord::Base.included_modules).to include Strongbolt::Tenantable
   end
 
@@ -10,25 +9,25 @@ describe Strongbolt::Tenantable do
   # When a class is set as tenant
   #
   describe 'tenant?' do
-    context "when class is not a tenant" do
+    context 'when class is not a tenant' do
       before do
-        define_model "OtherModel"
+        define_model 'OtherModel'
       end
 
-      it "should return false" do
+      it 'should return false' do
         expect(OtherModel.tenant?).to eq false
       end
     end
 
-    context "when class is a tenant" do
+    context 'when class is a tenant' do
       before do
-        define_model "OtherModel" do
+        define_model 'OtherModel' do
           send :tenant
         end
       end
       after { Strongbolt.send :tenants=, [] }
 
-      it "should return true" do
+      it 'should return true' do
         expect(OtherModel.tenant?).to eq true
       end
     end
@@ -37,13 +36,11 @@ describe Strongbolt::Tenantable do
   #
   # Tenant setup
   #
-  describe "tenant setup" do
-
+  describe 'tenant setup' do
     #
     # When every association is properly configured
     #
-    context "when no configuration error" do
-
+    context 'when no configuration error' do
       #
       # Set up a series of models to test the tenant setup
       #
@@ -51,166 +48,181 @@ describe Strongbolt::Tenantable do
         #
         # Tenant Model
         #
-        define_model "TenantModel" do
-          self.table_name = "models"
-          has_many :child_models, class_name: "ChildModel"
+        define_model 'TenantModel' do
+          self.table_name = 'models'
+          has_many :child_models, class_name: 'ChildModel'
 
-          belongs_to :parent, class_name: "UnownedModel",
-            foreign_key: :parent_id
+          belongs_to :parent, class_name: 'UnownedModel',
+                              foreign_key: :parent_id
         end
 
         #
         # Direct child to Tenant Model
         #
-        define_model "ChildModel" do
-          self.table_name = "child_models"
+        define_model 'ChildModel' do
+          self.table_name = 'child_models'
 
           belongs_to :tenant_model, foreign_key: :model_id,
-            class_name: "TenantModel"
+                                    class_name: 'TenantModel'
 
-          has_many :other_child_models, class_name: "OtherChildModel"
+          has_many :other_child_models, class_name: 'OtherChildModel'
+          has_one :very_polymorphic_sibling_model, as: :model, class_name: 'VeryPolymorphicSiblingModel'
         end
 
         #
         # 2nd degree child of tenant model
         #
-        define_model "OtherChildModel" do
-          self.table_name = "child_models"
+        define_model 'OtherChildModel' do
+          self.table_name = 'child_models'
 
           belongs_to :child_model, foreign_key: :model_id,
-            class_name: "ChildModel"
+                                   class_name: 'ChildModel'
           belongs_to :uncle_model, foreign_key: :parent_id,
-            class_name: "UncleModel"
-          has_one :sibling_model, class_name: "SiblingModel"
-          has_one :polymorphic_sibling_model, class_name: "PolymorphicSiblingModel"
+                                   class_name: 'UncleModel'
+          has_one :sibling_model, class_name: 'SiblingModel'
+          has_one :polymorphic_sibling_model, class_name: 'PolymorphicSiblingModel'
 
           has_and_belongs_to_many :bottom_models,
-            join_table: "model_models",
-            class_name: "BottomModel",
-            foreign_key: :parent_id,
-            association_foreign_key: :child_id
+                                  join_table: 'model_models',
+                                  class_name: 'BottomModel',
+                                  foreign_key: :parent_id,
+                                  association_foreign_key: :child_id
         end
 
         #
         # Parent of second degree child
         #
-        define_model "UncleModel" do
-          self.table_name = "models"
+        define_model 'UncleModel' do
+          self.table_name = 'models'
 
-          has_many :other_child_models, class_name: "OtherChildModel"
-          belongs_to :parent, class_name: "UnownedModel",
-            foreign_key: :parent_id
+          has_many :other_child_models, class_name: 'OtherChildModel'
+          belongs_to :parent, class_name: 'UnownedModel',
+                              foreign_key: :parent_id
         end
 
         #
         # Cousin of second degree child
         #
-        define_model "SiblingModel" do
-          self.table_name = "child_models"
+        define_model 'SiblingModel' do
+          self.table_name = 'child_models'
 
           belongs_to :other_child_model, foreign_key: :model_id
+          has_one :very_polymorphic_sibling_model, as: :other_model, class_name: 'VeryPolymorphicSiblingModel'
         end
 
         #
         # Cousin of second degree child
         #
-        define_model "PolymorphicSiblingModel" do
-          self.table_name = "child_models"
+        define_model 'PolymorphicSiblingModel' do
+          self.table_name = 'child_models'
 
           belongs_to :model, polymorphic: true
           has_one :unowned_model, foreign_key: :model_id
         end
 
+        #
+        # Cousin of second degree child
+        #
+        define_model 'VeryPolymorphicSiblingModel' do
+          self.table_name = 'other_child_models'
+
+          belongs_to :model, polymorphic: true
+          belongs_to :other_model, polymorphic: true
+        end
+
         #
         # Top level model, parent of Tenant Model
         #
-        define_model "UnownedModel" do
+        define_model 'UnownedModel' do
           has_many :tenant_models, foreign_key: :parent_id,
-            class_name: "TenantModel"
+                                   class_name: 'TenantModel'
           # has_many :uncle_models, foreign_key: :parent_id
         end
 
         #
         # Bottom level model, has and belons to many 2nd degree child
         #
-        define_model "BottomModel" do
-          self.table_name = "models"
+        define_model 'BottomModel' do
+          self.table_name = 'models'
 
           has_and_belongs_to_many :other_child_models,
-            class_name: "OtherChildModel",
-            join_table: "model_models",
-            foreign_key: :child_id,
-            association_foreign_key: :parent_id
+                                  class_name: 'OtherChildModel',
+                                  join_table: 'model_models',
+                                  foreign_key: :child_id,
+                                  association_foreign_key: :parent_id
         end
 
         TenantModel.send :tenant
       end
 
-      it "should have added has_one :tenant_model to other child model" do
+      it 'should have added has_one :tenant_model to other child model' do
         expect(OtherChildModel.new).to have_one(:tenant_model).through(:child_model)
       end
 
-      it "should have added has_many :tenant_models to BottomModel" do
+      it 'should have added has_many :tenant_models to BottomModel' do
         expect(BottomModel.new).to have_many(:tenant_models).through :other_child_models
       end
 
-      it "should have created a has_one :tenant_model to SiblingModel" do
+      it 'should have created a has_one :tenant_model to SiblingModel' do
         expect(SiblingModel.new).to have_one(:tenant_model).through :other_child_model
       end
 
-      it "should not have set a :tenant_model on polymorphic association" do
+      it 'should not have set a :tenant_model on polymorphic association' do
         expect(PolymorphicSiblingModel.new).not_to have_one(:tenant_model)
       end
 
-      it "should have added has_many :tenant_models to UncleModel" do
+      it 'should have added has_many :tenant_models to UncleModel' do
         expect(UncleModel.new).not_to have_many(:tenant_models).through :other_child_models
       end
 
-      %w{ChildModel OtherChildModel BottomModel SiblingModel}.each do |model|
+      %w[ChildModel OtherChildModel BottomModel SiblingModel].each do |model|
         it "should have added a scope with_tenants to #{model}" do
           expect(model.constantize).to respond_to :with_tenant_models
         end
       end
 
-      %w{ChildModel OtherChildModel BottomModel SiblingModel}.each do |model|
+      %w[ChildModel OtherChildModel BottomModel SiblingModel].each do |model|
         it "should have added a scope where_tenants to #{model}" do
           expect(model.constantize).to respond_to :where_tenant_models_among
         end
       end
 
-      it "creates a has_many users_tenant_models" do
+      it 'creates a has_many users_tenant_models' do
         expect(Strongbolt::Configuration.user_class.constantize.new).to have_many(:users_tenant_models)
           .dependent(:delete_all)
       end
 
-      it "creates a has_many relationship on the User defined" do
+      it 'creates a has_many relationship on the User defined' do
         expect(Strongbolt::Configuration.user_class.constantize.new).to have_many(:tenant_models).through :users_tenant_models
       end
 
-      it "creates a relationship on the user to get accessible tenants" do
+      it 'creates a relationship on the user to get accessible tenants' do
         expect(Strongbolt::Configuration.user_class.constantize.new).to respond_to :accessible_tenant_models
       end
 
-      it "should have added models to Capability::Models" do
+      it 'should have added models to Capability::Models' do
         expect(Strongbolt::Capability.models).to be_present
         expect(Strongbolt::Capability.models.size).to be > 0
       end
 
+      it 'should not raise an error' do
+        expect do
+          TenantModel.send :tenant
+        end.not_to raise_error
+      end
     end
 
-
     #
     # When an association lacks an inverse (none configured and none found)
     #
 
-    context "when an association lacks an inverse" do
-
+    context 'when an association lacks an inverse' do
       before(:all) do
         #
         # Tenant Model
         #
-        define_model "TenantModel" do
-          self.table_name = "models"
+        define_model 'TenantModel' do
+          self.table_name = 'models'
 
           has_many :child_models
         end
@@ -218,39 +230,37 @@ describe Strongbolt::Tenantable do
         #
         # Direct child to Tenant Model
         #
-        define_model "ChildModel" do
-          self.table_name = "child_models"
+        define_model 'ChildModel' do
+          self.table_name = 'child_models'
 
           belongs_to :tenant_model, foreign_key: :model_id
 
           has_many :other_child_models
         end
 
-        define_model "OtherChildModel" do
-          self.table_name = "child_models"
+        define_model 'OtherChildModel' do
+          self.table_name = 'child_models'
         end
       end
 
-      it "should raise an error" do
+      it 'should raise an error' do
         expect do
           TenantModel.send :tenant
         end.to raise_error Strongbolt::InverseAssociationNotConfigured
       end
-
     end
 
     #
     # When a direct association lacks a reference to the tenant
     #
 
-    context "when an association lacks an inverse" do
-
+    context 'when an association lacks an inverse' do
       before(:all) do
         #
         # Tenant Model
         #
-        define_model "TenantModel" do
-          self.table_name = "models"
+        define_model 'TenantModel' do
+          self.table_name = 'models'
 
           has_many :child_models
         end
@@ -258,24 +268,16 @@ describe Strongbolt::Tenantable do
         #
         # Direct child to Tenant Model
         #
-        define_model "ChildModel" do
-          self.table_name = "child_models"
+        define_model 'ChildModel' do
+          self.table_name = 'child_models'
         end
       end
 
-      it "should raise an error" do
+      it 'should raise an error' do
         expect do
           TenantModel.send :tenant
         end.to raise_error Strongbolt::DirectAssociationNotConfigured
       end
-
     end
-
-
-
   end
-
 end
-
-
-