strongbolt 0.3.12 → 0.3.13

data/spec/controllers/strongbolt/user_groups_controller_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 module Strongbolt
   describe UserGroupsController do
-
     let!(:user_group) { Fabricate :user_group }
 
     let(:valid_attributes) { Fabricate.attributes_for :user_group }
@@ -12,205 +11,175 @@ module Strongbolt
     #
     # GET #index
     #
-    describe "GET #index" do
-      
+    describe 'GET #index' do
       before { get :index }
 
       it { should be_success }
 
       it { should render_template :index }
 
-      it "should assign user groups" do
-        expect(assigns :user_groups).to eq [user_group]
+      it 'should assign user groups' do
+        expect(assigns(:user_groups)).to eq [user_group]
       end
-
     end
 
     #
     # GET #new
     #
-    describe "GET #new" do
-      
+    describe 'GET #new' do
       before { get :new }
 
       it { should be_success }
 
       it { should render_template :new }
-
     end
 
-
     #
     # GET #show
     #
-    describe "GET #show" do
-      
+    describe 'GET #show' do
       before { get :show, id: user_group.id }
 
       it { should be_success }
 
-      it "should assign user group" do
-        expect(assigns :user_group).to eq user_group
+      it 'should assign user group' do
+        expect(assigns(:user_group)).to eq user_group
       end
 
       it { should render_template :show }
-
     end
 
     #
     # GET #edit
     #
-    describe "GET #edit" do
-      
+    describe 'GET #edit' do
       before { get :edit, id: user_group.id }
 
       it { should be_success }
 
-      it "should assign user group" do
-        expect(assigns :user_group).to eq user_group
+      it 'should assign user group' do
+        expect(assigns(:user_group)).to eq user_group
       end
 
       it { should render_template :edit }
-
     end
 
     #
     # POST #create
     #
-    describe "POST #create" do
-
+    describe 'POST #create' do
       let(:create) { post :create, user_group: attributes }
 
       context 'when valid attributes' do
-      
         let(:attributes) { valid_attributes }
 
-        it "should redirect to show" do
+        it 'should redirect to show' do
           create
           expect(response).to redirect_to user_group_path(UserGroup.last)
         end
 
-        it "should create an user group" do
+        it 'should create an user group' do
           expect do
             create
           end.to change(UserGroup, :count).by 1
         end
-
       end
 
-      context "when invalid attributes" do
-        
+      context 'when invalid attributes' do
         let(:attributes) { {} }
 
-        it "should redirect_to new" do
+        it 'should redirect_to new' do
           create
           expect(response).to redirect_to new_user_group_path
         end
 
-        it "should not create an user group" do
+        it 'should not create an user group' do
           expect do
             create
           end.not_to change(UserGroup, :count)
         end
 
-        it "should set flash danger" do
+        it 'should set flash danger' do
           create
           expect(flash[:danger]).to be_present
         end
-
       end
-
     end
 
-
     #
     # PUT #update
     #
-    describe "PUT #update" do
-      
+    describe 'PUT #update' do
       before { put :update, id: user_group.id, user_group: attributes }
 
       context 'when valid attributes' do
-        
         let(:attributes) { valid_attributes }
 
         it { should redirect_to user_group_path(user_group) }
 
-        it "should update attributes" do
+        it 'should update attributes' do
           expect(user_group.reload.name).to eq valid_attributes[:name]
         end
-
       end
 
       context 'when invalid attributes' do
-        
-        let(:attributes) { {name: ""} }
+        let(:attributes) { { name: '' } }
 
         it { should redirect_to edit_user_group_path(user_group) }
 
-        it "should not update attributes" do
-          expect(user_group.reload.name).not_to eq ""
+        it 'should not update attributes' do
+          expect(user_group.reload.name).not_to eq ''
         end
 
-        it "should set flash danger" do
+        it 'should set flash danger' do
           expect(flash[:danger]).to be_present
         end
-
       end
-
     end
 
-
     #
     # DELETE #destroy
     #
-    describe "DELETE #destroy" do
-      
+    describe 'DELETE #destroy' do
       let(:destroy) { delete :destroy, id: user_group.id }
 
-      context "when no user" do
-
-        it "should redirect to index" do
+      context 'when no user' do
+        it 'should redirect to index' do
           destroy
           expect(response).to redirect_to user_groups_path
         end
 
-        it "should set flash success" do
+        it 'should set flash success' do
           destroy
           expect(flash[:success]).to be_present
         end
 
-        it "should delete a user group" do
+        it 'should delete a user group' do
           expect do
             destroy
-          end.to change(UserGroup, :count).by -1
+          end.to change(UserGroup, :count).by(-1)
         end
-
       end
 
-      context "when has users" do
-        
+      context 'when has users' do
         before { user_group.users << Fabricate(:user) }
 
-        it "should redirect to show" do
+        it 'should redirect to show' do
           destroy
           expect(response).to redirect_to user_group_path(user_group)
         end
 
-        it "should set flash danger" do
+        it 'should set flash danger' do
           destroy
           expect(flash[:danger]).to be_present
         end
 
-        it "should not delete a user group" do
+        it 'should not delete a user group' do
           expect do
             destroy
           end.not_to change(UserGroup, :count)
         end
-
       end
-
     end
-
   end
-end
+end

data/spec/controllers/strongbolt/user_groups_users_controller_spec.rb

@@ -1,8 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 module Strongbolt
   describe UserGroupsUsersController do
-
     let(:user_group) { Fabricate :user_group }
     let(:user)       { Fabricate :user }
 
@@ -11,39 +10,34 @@ module Strongbolt
     #
     # POST #create
     #
-    describe "POST #create" do
-      
-      context "when valid user group and user" do
-      
+    describe 'POST #create' do
+      context 'when valid user group and user' do
         before { post :create, user_group_id: user_group.id, id: user.id }
 
         it { should redirect_to user_group_path(user_group) }
 
-        it "should have add user to group" do
+        it 'should have add user to group' do
           user_group.reload
           expect(user_group.users).to include user
         end
 
-        context "when redoing" do
+        context 'when redoing' do
           before { post :create, user_group_id: user_group.id, id: user.id }
 
           it { should redirect_to user_group_path(user_group) }
 
-          it "should not have added it twice" do
+          it 'should not have added it twice' do
             expect(user_group.users.count).to eq 1
           end
         end
-
       end
-    
     end
 
     #
     # DELETE #destroy
     #
-    describe "DELETE #destroy" do
-      context "when valid user group and user" do
-        
+    describe 'DELETE #destroy' do
+      context 'when valid user group and user' do
         before do
           user_group.users << user
           delete :destroy, user_group_id: user_group.id, id: user.id
@@ -51,19 +45,17 @@ module Strongbolt
 
         it { should redirect_to user_group_path(user_group) }
 
-        it "should have removed user" do
+        it 'should have removed user' do
           user_group.reload
           expect(user_group.users).not_to include user
         end
 
-        context "when redoing" do
+        context 'when redoing' do
           before { delete :destroy, user_group_id: user_group.id, id: user.id }
 
           it { should redirect_to user_group_path(user_group) }
         end
-
       end
     end
-
   end
-end
+end

data/spec/controllers/without_authorization_controller_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe WithoutAuthorizationController do
   before do
@@ -7,14 +7,14 @@ describe WithoutAuthorizationController do
       .and_return User.new
   end
 
-  describe "GET #show" do
-    it "should not raise error" do
+  describe 'GET #show' do
+    it 'should not raise error' do
       expect { get :show }.not_to raise_error
     end
 
-    it "should be success" do
+    it 'should be success' do
       get :show
       expect(response).to be_success
     end
   end
-end
+end

data/spec/dummy/app/controllers/posts_controller.rb

@@ -1,7 +1,7 @@
 #
 # We create the controller we'll be using in our tests
 #
-RESTFUL_ACTIONS = [:index, :show, :new, :create, :update, :edit, :destroy]
+RESTFUL_ACTIONS = %i[index show new create update edit destroy].freeze
 
 class PostsController < TestController
   include Strongbolt::BoltedController
@@ -15,4 +15,4 @@ class PostsController < TestController
   def custom; end
 
   def current_user; end
-end
+end

data/spec/dummy/app/controllers/test_controller.rb

@@ -1,3 +1,3 @@
 class TestController < ActionController::Base
   def render(*attributes); end
-end
+end

data/spec/dummy/app/controllers/without_authorization_controller.rb

@@ -2,4 +2,4 @@ class WithoutAuthorizationController < ApplicationController
   def show
     head :ok
   end
-end
+end

data/spec/dummy/bin/rails

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

data/spec/dummy/config/application.rb

@@ -1,15 +1,15 @@
 require File.expand_path('../boot', __FILE__)
 
 # Pick the frameworks you want:
-require "active_record/railtie"
-require "action_controller/railtie"
+require 'active_record/railtie'
+require 'action_controller/railtie'
 # require "action_mailer/railtie"
-require "action_view/railtie"
+require 'action_view/railtie'
 # require "sprockets/railtie"
 # require "rails/test_unit/railtie"
 
 Bundler.require(*Rails.groups)
-require "strongbolt"
+require 'strongbolt'
 
 module Dummy
   class Application < Rails::Application
@@ -26,4 +26,3 @@ module Dummy
     # config.i18n.default_locale = :de
   end
 end
-

data/spec/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/dummy/config/initializers/strongbolt.rb

@@ -28,5 +28,5 @@ Strongbolt.setup do |config|
   #
   # config.models = 'HABTM_Roles', 'HABTM_UserGroups', 'HABTM_Capabilities', 'HABTM_Users', 'HABTM_Roles'
 
-  config.skip_controller_authorization_for "without_authorization"
-end
+  config.skip_controller_authorization_for 'without_authorization'
+end

data/spec/dummy/config/routes.rb

@@ -1,5 +1,4 @@
 Rails.application.routes.draw do
-
   strongbolt
 
   resources :posts do
@@ -7,6 +6,5 @@ Rails.application.routes.draw do
   end
   resources :welcome
 
-  get "without_authorization" => "without_authorization#show"
-  
+  get 'without_authorization' => 'without_authorization#show'
 end

data/spec/dummy/db/migrate/20150630212236_create_strongbolt_tables.rb

@@ -1,18 +1,18 @@
 class CreateStrongboltTables < ActiveRecord::Migration
   def change
-    create_table :strongbolt_capabilities, :force => true do |t|
+    create_table :strongbolt_capabilities, force: true do |t|
       t.string   :name
       t.string   :description
       t.string   :model
       t.string   :action
       t.string   :attr
-      t.boolean  :require_ownership, :default => false, :null => false
-      t.boolean  :require_tenant_access, :default => true, :null => false
+      t.boolean  :require_ownership, default: false, null: false
+      t.boolean  :require_tenant_access, default: true, null: false
 
       t.timestamps
     end
 
-    create_table :strongbolt_roles, :force => true do |t|
+    create_table :strongbolt_roles, force: true do |t|
       t.string   :name
       t.integer  :parent_id
       t.integer  :lft
@@ -22,33 +22,32 @@ class CreateStrongboltTables < ActiveRecord::Migration
       t.timestamps
     end
 
-    create_table :strongbolt_user_groups, :force => true do |t|
+    create_table :strongbolt_user_groups, force: true do |t|
       t.string :name
       t.text :description
 
       t.timestamps
     end
 
-    create_table :strongbolt_user_groups_users, :id => false, :force => true do |t|
+    create_table :strongbolt_user_groups_users, id: false, force: true do |t|
       t.integer :user_group_id
       t.integer :user_id
     end
 
-    create_table :strongbolt_roles_user_groups, :id => false, :force => true do |t|
+    create_table :strongbolt_roles_user_groups, id: false, force: true do |t|
       t.integer :user_group_id
       t.integer :role_id
     end
 
-    create_table :strongbolt_capabilities_roles, :id => false, :force => true do |t|
+    create_table :strongbolt_capabilities_roles, id: false, force: true do |t|
       t.integer  :role_id
       t.integer  :capability_id
     end
 
-    create_table :strongbolt_users_tenants, :force => true do |t|
+    create_table :strongbolt_users_tenants, force: true do |t|
       t.integer  :user_id
       t.integer  :tenant_id
       t.string   :type
     end
   end
 end
-