sproutcore 1.7.1.beta → 1.8.0

data/lib/frameworks/sproutcore/frameworks/routing/tests/system/routes.js

@@ -95,8 +95,8 @@ test('Route tree', function() {
   s = a.wildcardRoutes['foo'];
   ok(s, 'There should be a wildcardRoutes tree for a');
   
-  equals(r.routeForParts(['a'], {}), null, 'routeForParts should return null for non existant routes');
-  equals(r.routeForParts(['a', 'b'], {}), null, 'routeForParts should return null for non existant routes');
+  equals(r.routeForParts(['a'], {}), null, 'routeForParts should return null for non existent routes');
+  equals(r.routeForParts(['a', 'b'], {}), null, 'routeForParts should return null for non existent routes');
   equals(r.routeForParts(abc, {}), c, 'routeForParts should return the correct route for a/b/c');
   
   equals(r.routeForParts(abd, {}), d, 'routeForParts should return the correct route for a/b/d');

data/lib/frameworks/sproutcore/frameworks/runtime/core.js

@@ -39,7 +39,7 @@ window.SproutCore = window.SproutCore || SC ;
 // rest of the methods go into the mixin defined below.
 
 /**
-  @version 1.7.1.beta
+  @version 1.8.0
   @namespace
 
   All SproutCore methods and functions are defined
@@ -59,7 +59,7 @@ window.SproutCore = window.SproutCore || SC ;
 */
 SC = window.SC; // This is dumb but necessary for jsdoc to get it right
 
-SC.VERSION = '1.7.1.beta';
+SC.VERSION = '1.8.0';
 
 /**
   @private
@@ -99,6 +99,9 @@ SC._baseMixin = function (override) {
       if (target===copy) continue ; // prevent never-ending loop
       if (copy !== undefined && ( override || (target[key] === undefined) )) target[key] = copy ;
     }
+    // Manually copy toString() because some JS engines do not enumerate it
+    // (such as IE8)
+    if (options.hasOwnProperty('toString')) target.toString = options.toString;
   }
 
   return target;
@@ -166,6 +169,8 @@ SC.mixin(/** @scope window.SC.prototype */ {
   T_BOOL:      'boolean',
   T_ARRAY:     'array',
   T_STRING:    'string',
+  T_DATE:      'date',
+  T_REGEXP:    'regexp',
 
   // ........................................
   // TYPING & ARRAY MESSAGING
@@ -176,7 +181,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
 
     Use this instead of the built-in typeOf() to get the type of an item.
     It will return the same result across all browsers and includes a bit
-    more detail. 
+    more detail.
 
     @param {Object} item the item to check
     @returns {String} One of the following, depending on the type of the item<br>
@@ -186,6 +191,8 @@ SC.mixin(/** @scope window.SC.prototype */ {
             SC.T_NULL: Null value,<br>
             SC.T_UNDEFINED: Undefined value,<br>
             SC.T_FUNCTION: A function,<br>
+            SC.T_DATE: Date primitive,<br>
+            SC.T_REGEXP: RegExp primitive,<br>
             SC.T_ARRAY: An instance of Array,<br>
             SC.T_CLASS: A SproutCore class (created using SC.Object.extend()),<br>
             SC.T_OBJECT: A SproutCore object instance,<br>
@@ -201,7 +208,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
     if (nativeType === "function") {
       return item.isClass ? SC.T_CLASS : SC.T_FUNCTION;
     } else if (nativeType === "object") {
-      
+
       // Note: typeOf() may be called before SC.Error has had a chance to load
       // so this code checks for the presence of SC.Error first just to make
       // sure.  No error instance can exist before the class loads anyway so
@@ -562,7 +569,7 @@ SC.mixin(/** @scope window.SC.prototype */ {
   /**
     Creates a new object with the passed object as its prototype.
 
-    This method uses JavaScript's native inheritence method to create a new
+    This method uses JavaScript's native inheritance method to create a new
     object.
 
     You cannot use beget() to create new SC.Object-based objects, but you
@@ -656,9 +663,9 @@ SC.mixin(/** @scope window.SC.prototype */ {
   /**
     Convenience method to inspect an object.  This method will attempt to
     convert the object into a useful string description.
-    
-    @param {Object} obj The object you want to inspec.
-    
+
+    @param {Object} obj The object you want to inspect.
+
     @returns {String} A description of the object
   */
   inspect: function(obj) {

data/lib/frameworks/sproutcore/frameworks/runtime/debug/test_suites/array/base.js

@@ -11,7 +11,7 @@
   Adds a new module of unit tests to verify that the passed object implements
   the SC.Array interface.  To generate, call the ArrayTests array with a 
   test descriptor.  Any properties you pass will be applied to the ArrayTests
-  descendent created by the create method.
+  descendant created by the create method.
   
   You should pass at least a newObject() method, which should return a new 
   instance of the object you want to have tested.  You can also implement the
@@ -145,7 +145,7 @@ SC.TestSuite = /** @scope SC.TestSuite.prototype */ {
   
   /**
     Default teardown method for use with modules.  This method will call the
-    destroyObejct() method, passing the current object property on the 
+    destroyObject() method, passing the current object property on the 
     receiver.  It will also clear the object property.
   */
   teardown: function() {
@@ -164,7 +164,7 @@ SC.TestSuite = /** @scope SC.TestSuite.prototype */ {
   
   /**
     Default method to destroy a generated object instance after a test has 
-    completed.  If you override newObject() you can also overried this method
+    completed.  If you override newObject() you can also override this method
     to cleanup the object you just created.
     
     Default method does nothing.
@@ -184,7 +184,7 @@ SC.TestSuite = /** @scope SC.TestSuite.prototype */ {
           teardown: function() { T.teardown(); }
         }
     
-    @param {String} desc detailed descrition
+    @param {String} desc detailed description
     @returns {SC.TestSuite} receiver
   */
   module: function(desc) {
@@ -375,7 +375,7 @@ SC.ArraySuite = SC.TestSuite.create("Verify SC.Array compliance: %@#%@", {
   
 });
 
-// Simple verfication of length
+// Simple verification of length
 SC.ArraySuite.define(function(T) {
   T.module("length");
   

data/lib/frameworks/sproutcore/frameworks/runtime/debug/test_suites/array/replace.js

@@ -90,5 +90,17 @@ SC.ArraySuite.define(function(T) {
     
     T.validateAfter(obj, after, observer, YES);
   });
+
+  test("[].replace(0, 0, 'X') will call notify `[]` changed only once", function() {
+    var exp = T.expected(1),
+        callCount = 0;
+
+    obj.addObserver('[]', function () {
+      callCount++;
+    });
+
+    obj.replace(0, 0, exp);
+    equals(callCount, 1, "expects the key '[]' to be notified only once");
+  });
   
 });

data/lib/frameworks/sproutcore/frameworks/runtime/ext/function.js

@@ -78,7 +78,7 @@ SC.mixin(Function.prototype,
 
         capitalizedName: function() {
           return this.getPath('person.fullName').toUpper();
-        }.property('person.firstName')
+        }.property('person.fullName')
 
     This will cause observers of +capitalizedName+ to be fired when either
     +fullName+ _or_ +person+ changes.
@@ -156,7 +156,7 @@ SC.mixin(Function.prototype,
 
     All non-computed properties are idempotent and normally you should make
     your computed properties behave the same way.  However, if you need to
-    make your property change its return value everytime your method is
+    make your property change its return value every time your method is
     called, you may chain this to your property to make it volatile.
 
     If you do not specify this option, properties are assumed to be

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/array.js

@@ -31,7 +31,7 @@ SC.CoreArray = /** @lends SC.Array.prototype */ {
   // length: 0,
 
   /**
-    This is one of the primitves you must implement to support SC.Array.  You
+    This is one of the primitives you must implement to support SC.Array.  You
     should replace amt objects started at idx with the objects in the passed
     array.
 

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/copyable.js

@@ -8,7 +8,7 @@
 /**
   @class
 
-  Impelements some standard methods for copying an object.  Add this mixin to
+  Implements some standard methods for copying an object.  Add this mixin to
   any object you create that can create a copy of itself.  This mixin is
   added automatically to the built-in array.
 

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/enumerable.js

@@ -762,7 +762,7 @@ SC.Enumerable = /** @scope SC.Enumerable.prototype */{
 
 } ;
 
-// Build in a separate function to avoid unintential leaks through closures...
+// Build in a separate function to avoid unintentional leaks through closures...
 SC._buildReducerFor = function(reducerKey, reducerProperty) {
   return function(key, value) {
     var reducer = this[reducerKey] ;
@@ -899,7 +899,7 @@ SC.Reducers = /** @scope SC.Reducers.prototype */ {
   },
 
   /**
-    Reduces an enumberable to the max of the items in the enumerable. If
+    Reduces an enumerable to the max of the items in the enumerable. If
     reducerProperty is passed, it will reduce that property. Otherwise, it will
     reduce the item itself.
 
@@ -929,7 +929,7 @@ SC.Reducers = /** @scope SC.Reducers.prototype */ {
   },
 
   /**
-    Reduces an enumberable to the min of the items in the enumerable. If
+    Reduces an enumerable to the min of the items in the enumerable. If
     reducerProperty is passed, it will reduce that property. Otherwise, it will
     reduce the item itself.
 
@@ -949,7 +949,7 @@ SC.Reducers = /** @scope SC.Reducers.prototype */ {
   },
 
   /**
-    Reduces an enumberable to the max of the items in the enumerable. If
+    Reduces an enumerable to the max of the items in the enumerable. If
     reducerProperty is passed, it will reduce that property. Otherwise, it will
     reduce the item itself.
 
@@ -979,7 +979,7 @@ SC.Reducers = /** @scope SC.Reducers.prototype */ {
   },
 
   /**
-    Reduces an enumberable to the average of the items in the enumerable. If
+    Reduces an enumerable to the average of the items in the enumerable. If
     reducerProperty is passed, it will reduce that property. Otherwise, it will
     reduce the item itself.
 
@@ -1001,7 +1001,7 @@ SC.Reducers = /** @scope SC.Reducers.prototype */ {
   },
 
   /**
-    Reduces an enumberable to the sum of the items in the enumerable. If
+    Reduces an enumerable to the sum of the items in the enumerable. If
     reducerProperty is passed, it will reduce that property. Otherwise, it will
     reduce the item itself.
 
@@ -1328,7 +1328,7 @@ Array.prototype.isEnumerable = YES ;
     // The mixinIfMissing methods should be applied if they are not defined.
     // If Prototype 1.6 is included, some of these methods will be defined
     // already, but we want to override them anyway in this special case
-    // because our version is faster and functionally identitical.
+    // because our version is faster and functionally identical.
     if (!Array.prototype[key] || ((typeof Prototype === 'object') && Prototype.Version.match(/^1\.6/))) {
       Array.prototype[key] = mixinIfMissing[key] ;
     }

data/lib/frameworks/sproutcore/frameworks/runtime/mixins/observable.js

@@ -19,6 +19,9 @@ sc_require('private/chain_observer');
 */
 SC.LOG_OBSERVERS = NO ;
 
+SC.OBSERVES_HANDLER_ADD = 0;
+SC.OBSERVES_HANDLER_REMOVE = 1;
+
 /**
   @class
 
@@ -194,7 +197,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
     Likewise, if you try to call get() on a property whose values is
     undefined, the unknownProperty() method will be called on the object.
-    If this method reutrns any value other than undefined, it will be returned
+    If this method returns any value other than undefined, it will be returned
     instead.  This allows you to implement "virtual" properties that are
     not defined upfront.
 
@@ -238,7 +241,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     If you try to set a value on a key that is undefined in the target
     object, then the unknownProperty() handler will be called instead.  This
     gives you an opportunity to implement complex "virtual" properties that
-    are not predefined on the obejct.  If unknownProperty() returns
+    are not predefined on the object.  If unknownProperty() returns
     undefined, then set() will simply set the value on the object.
 
     Property Observers
@@ -250,7 +253,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     observers (i.e. observer methods declared on the same object), will be
     called immediately.  Any "remote" observers (i.e. observer methods
     declared on another object) will be placed in a queue and called at a
-    later time in a coelesced manner.
+    later time in a coalesced manner.
 
     Chaining
     ---
@@ -630,7 +633,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
       Called by set() whenever it needs to determine which cached dependent
       keys to clear.  Recursively searches dependent keys to determine all
-      cached property direcly or indirectly affected.
+      cached property directly or indirectly affected.
 
       The return value is also saved for future reference
 
@@ -860,7 +863,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
 
     /**
       This method will register any observers and computed properties saved on
-      the object.  Normally you do not need to call this method youself.  It
+      the object.  Normally you do not need to call this method yourself.  It
       is invoked automatically just before property notifications are sent and
       from the init() method of SC.Object.  You may choose to call this
       from your own initialization method if you are using SC.Observable in
@@ -896,32 +899,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
           propertyPathsLength = (propertyPaths) ? propertyPaths.length : 0 ;
           for(ploc=0;ploc<propertyPathsLength;ploc++) {
             path = propertyPaths[ploc] ;
-            dotIndex = path.indexOf('.') ;
-            // handle most common case, observing a local property
-            if (dotIndex < 0) {
-              this.addObserver(path, this, observer) ;
-
-            // next most common case, use a chained observer
-            } else if (path.indexOf('*') === 0) {
-              this.addObserver(path.slice(1), this, observer) ;
-
-            // otherwise register the observer in the observers queue.  This
-            // will add the observer now or later when the named path becomes
-            // available.
-            } else {
-              root = null ;
-
-              // handle special cases for observers that look to the local root
-              if (dotIndex === 0) {
-                root = this; path = path.slice(1) ;
-              } else if (dotIndex===4 && path.slice(0,5) === 'this.') {
-                root = this; path = path.slice(5) ;
-              } else if (dotIndex<0 && path.length===4 && path === 'this') {
-                root = this; path = '';
-              }
-
-              SC.Observers.addObserver(path, this, observer, root);
-            }
+            this.addObservesHandler(observer, path);
           }
         }
       }
@@ -955,6 +933,94 @@ SC.Observable = /** @scope SC.Observable.prototype */{
       }
 
     },
+    
+    /**
+      Will add an observes handler to this object for a given property path.
+      
+      In most cases, the path provided is relative to this object. However,
+      if the path begins with a captial character then the path is considered
+      relative to the window object.
+      
+      @param {Function} observer the function on this object that will be 
+        notified of changes
+      @param {String} path a property path string
+      @return {Object} returns this
+    */
+    addObservesHandler: function(observer, path) {
+      this._configureObservesHandler(SC.OBSERVES_HANDLER_ADD, observer, path);
+      return this;
+    },
+    
+    /**
+      Will remove an observes handler from this object for a given property path.
+      
+      In most cases, the path provided is relative to this object. However,
+      if the path begins with a captial character then the path is considered
+      relative to the window object.
+      
+      @param {Function} observer the function on this object that will be 
+        notified of changes
+      @param {String} path a property path string
+      @return {Object} returns this
+    */
+    removeObservesHandler: function(observer, path) {
+      this._configureObservesHandler(SC.OBSERVES_HANDLER_REMOVE, observer, path);
+      return this;
+    },
+    
+    /** @private
+    
+      Used to either add or remove an observer handler on this object
+      for a given property path.
+      
+      In most cases, the path provided is relative to this object. However,
+      if the path begins with a captial character then the path is considered
+      relative to the window object.
+      
+      You must supply an action that is to be performed by this method. The 
+      action can either be `SC.OBSERVES_HANDLER_ADD` or `SC.OBSERVES_HANDLER_REMOVE`.
+      
+      @param {Function} observer the function on this object that will be 
+        notified of changes
+      @param {String} path a property path string
+      @param {String} path a dot-notation property path string
+    */
+    _configureObservesHandler: function(action, observer, path) {
+      var dotIndex, root;
+      
+      switch (action) {
+      case SC.OBSERVES_HANDLER_ADD:
+        action = "addObserver"; break;
+      case SC.OBSERVES_HANDLER_REMOVE:
+        action = "removeObserver"; break;
+      default:
+        throw "invalid action provided: " + action;
+      }
+
+      dotIndex = path.indexOf('.');
+
+      if (dotIndex < 0) {
+        this[action](path, this, observer);
+      } else if (path.indexOf('*') === 0) {
+        this[action](path.slice(1), this, observer);
+      } else {
+        root = null;
+
+        if (dotIndex === 0) {
+          root = this; path = path.slice(1);
+        } else if (dotIndex === 4 && path.slice(0, 5) === 'this.') {
+          root = this; path = path.slice(5);
+        } else if (dotIndex < 0 && path.length === 4 && path === 'this') {
+          root = this; path = '';
+        } else if (dotIndex > 0 && path[0] === path.charAt(0).toLowerCase()) {
+          // if the first character for the given path is lower case
+          // then we assume the path is relative to this
+          root = this;
+        }
+
+        SC.Observers[action](path, this, observer, root);
+      }
+    },
 
     // ..........................................
     // NOTIFICATION
@@ -1312,7 +1378,7 @@ SC.Observable = /** @scope SC.Observable.prototype */{
     /**
       Navigates the property path, finally setting the value but only if
       the value does not match the current value.  This will avoid sending
-      unecessary change notifications.
+      unnecessary change notifications.
 
       @param {String} path the property path to set
       @param {Object} value the value to set

data/lib/frameworks/sproutcore/frameworks/runtime/private/chain_observer.js

@@ -166,8 +166,13 @@ SC._ChainObserver.prototype = {
 
     // remove observer
     var obj = this.object ;
-    if (obj && obj.removeObserver) {
-      obj.removeObserver(this.property, this, this.propertyDidChange) ;
+    if (obj) {
+      if (this.property === '@each' && this.next && obj._removeContentObserver) {
+        obj._removeContentObserver(this);
+      }
+      if (obj.removeObserver) {
+        obj.removeObserver(this.property, this, this.propertyDidChange) ;
+      }
     }
 
     // destroy next item in chain