sproutcore 1.7.1.beta → 1.8.0

data/lib/frameworks/sproutcore/frameworks/desktop/views/checkbox.js

@@ -79,9 +79,7 @@ SC.CheckboxView = SC.ButtonView.extend(SC.StaticLayout,
     if(!this.get('isEnabled')) return YES;
     this.set('isActive', YES);
     this._isMouseDown = YES;
-    // even if radiobuttons are not set to get firstResponder, allow default 
-    // action, that way textfields loose focus as expected.
-    if (evt) evt.allowDefault();
+    if (evt && this.get('acceptsFirstResponder')) evt.allowDefault();
     return YES;
   },
   
@@ -92,11 +90,12 @@ SC.CheckboxView = SC.ButtonView.extend(SC.StaticLayout,
     this.set('isActive', NO);
     this._isMouseDown = NO;
 
-    this._toggleValue();
-
     // fire action
     if (this.get('buttonBehavior') !== SC.HOLD_BEHAVIOR) {
-      if (this.$().within(evt.target)) { this._action(evt); }
+      if (this.$().within(evt.target)) {
+        this._toggleValue();
+        this._action(evt);
+      }
     }
 
     return YES;

data/lib/frameworks/sproutcore/frameworks/desktop/views/collection.js

@@ -62,9 +62,9 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
 
   /**
     @type Array
-    @default ['isFirstResponder', 'isEnabled', 'isActive']
+    @default ['hasFirstResponder', 'isEnabled', 'isActive']
   */
-  displayProperties: ['isFirstResponder', 'isEnabled', 'isActive'],
+  displayProperties: ['hasFirstResponder', 'isEnabled', 'isActive'],
 
   /**
     @type String
@@ -409,7 +409,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
 
     For example, if you set `contentValueKey` to 'name' and set the
     exampleView to an `SC.LabelView`, then the label views created by the
-    colleciton view will display the value of the content.name.
+    collection view will display the value of the content.name.
 
     If you are writing your own custom item view for a collection, you can
     get this behavior automatically by including the SC.Control mixin on your
@@ -443,7 +443,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     This property is used to store the calculated height to have
     a consistent scrolling behavior due to the issues generated by using top
     instead of `scrollTop`. We could look at the min-height set in the view, but
-    to avoid perf hits we simply store it and the scrollView will use it if
+    to avoid performance hits we simply store it and the scrollView will use it if
     different than 0.
 
     @type Number
@@ -455,7 +455,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     This property is used to store the calculated width to have
     a consistent scrolling behavior due to the issues generated by using left
     instead of `scrollLeft`. We could look at the min-width set in the view, but
-    to avoid perf hits we simply store it and the scrollView will use it if
+    to avoid performance hits we simply store it and the scrollView will use it if
     different than 0.
 
     @type Number
@@ -557,7 +557,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     passed value is `null`, then you should show the insertion point *AFTER* that
     last item view returned by the itemViews property.
 
-    Once this method is called, you are guaranteed to also recieve a call to
+    Once this method is called, you are guaranteed to also receive a call to
     `hideInsertionPoint()` at some point in the future.
 
     The default implementation of this method does nothing.
@@ -701,9 +701,9 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     Note that if you do implement this method, you are expected to maintain
     the range observer object yourself.  If a range observer has not been
     created yet, this method should create it.  If an observer already exists
-    this method should udpate it.
+    this method should update it.
 
-    When you create a new range observer, the oberver must eventually call
+    When you create a new range observer, the observer must eventually call
     `contentRangeDidChange()` for the collection view to function properly.
 
     If you override this method you probably also need to override
@@ -735,7 +735,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     provide your own range observer behavior.
 
     Note that if you override this method you should probably also override
-    `updateRangeObserver()` to create or update a range oberver as needed.
+    `updateRangeObserver()` to create or update a range observer as needed.
 
     @returns {void}
   */
@@ -759,6 +759,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
   contentLengthDidChange: function() {
     var content = this.get('content');
     this.set('length', content ? content.get('length') : 0);
+    this.computeLayout();
   },
 
   /** @private
@@ -852,7 +853,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     define them on your subclass:
 
       - *willReload()* is called just before the items are reloaded
-      - *didReload()* is called jsut after items are reloaded
+      - *didReload()* is called just after items are reloaded
 
     You can use these two methods to setup and teardown caching, which may
     reduce overall cost of a reload.  Each method will be passed an index set
@@ -1561,7 +1562,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
   },
 
   /**
-    Primtive to remove the indexes from the selection.
+    Primitive to remove the indexes from the selection.
 
     @param {Number|SC.IndexSet} indexes index or indexes to deselect
     @returns {SC.CollectionView} receiver
@@ -2189,7 +2190,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
       return YES;
     }
 
-    // recieved a mouseDown on the collection element, but not on one of the
+    // received a mouseDown on the collection element, but not on one of the
     // childItems... unless we do not allow empty selections, set it to empty.
     if (!itemView) {
       if (this.get('allowDeselectAll')) this.select(null, false);
@@ -2782,7 +2783,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
   _computeDropOperationState: function(drag, evt, dragOp) {
     // get the insertion index for this location.  This can be computed
     // by a subclass using whatever method.  This method is not expected to
-    // do any data valdidation, just to map the location to an insertion
+    // do any data validation, just to map the location to an insertion
     // index.
     var loc    = this.convertFrameFromView(drag.get('location'), null),
         dropOp = SC.DROP_BEFORE,
@@ -2996,7 +2997,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
         if (i < idx) idx--;
       }, this);
 
-      // now insert objects into new insertion locaiton
+      // now insert objects into new insertion location
       if (dropOp === SC.DROP_AFTER) idx++;
       content.replace(idx, 0, objects, dropOp);
       this.select(SC.IndexSet.create(idx, objects.length));
@@ -3044,7 +3045,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate, SC.CollectionConte
     possible.  Otherwise, you should never return DROP_ON.
 
     For compatibility, you can also return just the insertion index.  If you
-    do this, then the collction view will assume the drop operation is
+    do this, then the collection view will assume the drop operation is
     SC.DROP_BEFORE.
 
     If an insertion is NOT allowed, you should return -1 as the insertion

data/lib/frameworks/sproutcore/frameworks/desktop/views/date_field.js

@@ -8,40 +8,40 @@
 
 /** @class
 
-  A Date field add behaviour to the Text Field to support date management, 
+  A Date field add behaviour to the Text Field to support date management,
   for example, disabling deletion, and special behaviour to tabs commands.
-  
-  This field view is tighly inregrated with SC.DateTime
-  
+
+  This field view is tightly integrated with SC.DateTime
+
   By default the Date Field View show Date only, but if you need to show the Time do:
-  
+
       dateAndTime: Shared.DateFieldView.design({
         showTime: YES,
         valueBinding: '...'
       }),
-  
+
   and if you only need to show time:
-  
+
       timeOnly: Shared.DateFieldView.design({
         showTime: YES,
         showDate: NO,
         valueBinding: '...'
       })
-  
+
   Example usage with special format:
-  
+
       specialDate: Shared.DateFieldView.design({
         formatDate: '%d %b of %Y',
         valueBinding: '...'
       }),
-  
+
   You can override these format as you like, but has some limitations,
   actually only support these KEY from SC.DateTime:
-  
+
   %a %b %d %H %I %j %m %M %p %S %U %W %y %Y
-  
+
   These are keys that has FIXED length, so we can control the selection and tabing.
-  
+
   @extends SC.TextFieldView
   @since SproutCore 1.0
   @author Juan Pablo Goldfinger
@@ -54,49 +54,49 @@ SC.DateFieldView = SC.TextFieldView.extend(
     @default null
   */
   value: null,
-  
+
   /**
     @type Boolean
     @default YES
   */
   showDate: YES,
-  
+
   /**
     @type Boolean
     @default NO
   */
   showTime: NO,
-  
+
   /**
     @type String
     @default '%I:%M %p'
   */
   formatTime: '%I:%M %p',
-  
+
   /**
     @type String
     @default '%d/%m/%Y'
   */
   formatDate: '%d/%m/%Y',
-  
+
   /**
     @type String
     @default '%d/%m/%Y %I:%M %p'
   */
   formatDateTime: '%d/%m/%Y %I:%M %p',
-  
+
   // DateTime constants (with fixed width, like numbers or abbs with fixed length)
   // original: '%a %A %b %B %c %d %h %H %i %I %j %m %M %p %S %U %W %x %X %y %Y %Z %%'.w(),
-  // NOTE: I think that %a and %b areb't useful because is more adecuato to represente day
-  // with 1..31 without zeros at start, but causes the lenght not to be fixed)
+  // NOTE: I think that %a and %b aren't useful because is more adequate to represent day
+  // with 1..31 without zeros at start, but causes the length not to be fixed)
 
   /** @private*/
   _dtConstants: ['%a', '%b', '%d', '%H', '%I', '%j', '%m', '%M', '%p', '%S', '%U', '%W', '%y', '%Y'],
   // Width constants for each representation %@.
-  
+
   /** @private */
   _wtConstants: [3,3,2,2,2,3,2,2,2,2,2,2,2,4],
-  
+
   /** @private */
   activeSelection: 0,
 
@@ -104,7 +104,7 @@ SC.DateFieldView = SC.TextFieldView.extend(
   FUTURE: DatePickerSupport.
   createChildViews: function() {
     sc_super();
-    if (SC.browser.webkit) {
+    if (SC.browser.isWebkit) {
       // ON MOZILLA DON'T WORK
       var view = Shared.DatePickerView.extend({
         layout: { right: 0, centerY: 0, width: 18, height: 15 }
@@ -115,10 +115,10 @@ SC.DateFieldView = SC.TextFieldView.extend(
     }
   },
   */
-  
+
   /**
     The current format to apply for Validator and to show.
-    
+
     @field
     @type String
     @observes showTime
@@ -131,10 +131,10 @@ SC.DateFieldView = SC.TextFieldView.extend(
     if (st === YES) return this.get('formatTime');
     return this.get('formatDate');
   }.property('showTime', 'showDate').cacheable(),
-  
+
   /**
-    The current validator to format the Date to the input field and viceversa.
-    
+    The current validator to format the Date to the input field and vice versa.
+
     @field
     @type SC.Validator.DateTime
     @observes format
@@ -142,34 +142,34 @@ SC.DateFieldView = SC.TextFieldView.extend(
   validator: function() {
     return SC.Validator.DateTime.extend({ format: this.get('format') });
   }.property('format').cacheable(),
-  
+
   /**
     Array of Key/TextSelection found for the current format.
-    
+
     @field
     @type SC.Array
-  */  
+  */
   tabsSelections: function() {
     var arr = [];
     var ft = this.get('format');
     var _dt = this.get('_dtConstants');
     var _wt = this.get('_wtConstants');
-    
-    // Parse the string format to retrieve and build 
+
+    // Parse the string format to retrieve and build
     // a TextSelection array ordered to support tabs behaviour
     if (SC.empty(ft)) {
       throw 'The format string is empty, and must be a valid string.';
     }
-    
+
     var pPos, key, keyPos, startAt = 0, nPos = 0, oPos = 0;
     while(startAt < ft.length && ft.indexOf('%', startAt) !== -1) {
       pPos = ft.indexOf('%', startAt);
       key = ft.substring(pPos, pPos + 2);
       startAt = pPos + 2;
-      
+
       keyPos = _dt.indexOf(key);
       if (keyPos === -1) {
-        throw "SC.DateFieldView: The format's key '%@' is not supported.".fmt(key); 
+        throw "SC.DateFieldView: The format's key '%@' is not supported.".fmt(key);
       }
       nPos = nPos + pPos - oPos;
       arr.push(SC.Object.create({
@@ -177,13 +177,13 @@ SC.DateFieldView = SC.TextFieldView.extend(
         textSelection: SC.TextSelection.create({ start: nPos, end: nPos + _wt[keyPos] })
       }));
       nPos = nPos + _wt[keyPos];
-      oPos = startAt;   
+      oPos = startAt;
     }
     pPos = key = keyPos = null;
-    
+
     return arr;
   }.property('format').cacheable(),
-  
+
   /** @private
     If the activeSelection changes or the value changes, update the "TextSelection" to show accordingly.
   */
@@ -194,7 +194,7 @@ SC.DateFieldView = SC.TextFieldView.extend(
       this.selection(null, ts[as].get('textSelection'));
     }
   }.observes('activeSelection', 'value'),
-  
+
   /** @private
     Updates the value according the key.
   */
@@ -216,22 +216,22 @@ SC.DateFieldView = SC.TextFieldView.extend(
       case '%U': this.set('value', value.advance({ week1: newValue })); break;
       case '%W': this.set('value', value.advance({ week0: newValue })); break;
       case '%y': case '%Y': this.set('value', value.advance({ year: newValue })); break;
-    } 
+    }
   },
-  
+
   _selectRootElement: function() {
-    // TODO: This is a solution while I don't found how we 
+    // TODO: This is a solution while I don't found how we
     // receive the last key from the last input.
     // (to see if is entering with Tab or backTab)
     /*if (this.get('activeSelection') === -1) {
     }*/
   },
 
-  
+
   // ..........................................................
   // Key Event Support
-  // 
-  
+  //
+
   /** @private */
   keyDown: function(evt) {
     if (this.interpretKeyEvents(evt)) {
@@ -240,7 +240,7 @@ SC.DateFieldView = SC.TextFieldView.extend(
     }
     return sc_super();
   },
-  
+
   /** @private */
   ctrl_a: function() {
     return YES;
@@ -277,7 +277,7 @@ SC.DateFieldView = SC.TextFieldView.extend(
     this.set('activeSelection', ns);
     return YES;
   },
-    
+
   /** @private */
   moveLeft: function(evt) {
     var ts = this.get('tabsSelections');
@@ -293,9 +293,9 @@ SC.DateFieldView = SC.TextFieldView.extend(
   insertTab: function(evt) {
     var ts = this.get('tabsSelections');
     var ns = this.get('activeSelection') + 1;
-    if (ns < ts.length) { 
+    if (ns < ts.length) {
       this.set('activeSelection', ns);
-      return YES;   
+      return YES;
     }
     return NO;
   },
@@ -303,7 +303,7 @@ SC.DateFieldView = SC.TextFieldView.extend(
   /** @private */
   insertBacktab: function(evt) {
     var ns = this.get('activeSelection') - 1;
-    if (ns !== -1) { 
+    if (ns !== -1) {
       this.set('activeSelection', ns);
       return YES;
     }

data/lib/frameworks/sproutcore/frameworks/desktop/views/disclosure.js

@@ -66,7 +66,7 @@ SC.DisclosureView = SC.ButtonView.extend(
   /** @private
 
     Allows toggling of the value with the right and left arrow keys.
-    Extends the behavior inherted from SC.ButtonView.
+    Extends the behavior inherited from SC.ButtonView.
     @param evt
   */
   keyDown: function(evt) {

data/lib/frameworks/sproutcore/frameworks/desktop/views/grid.js

@@ -111,7 +111,7 @@ SC.GridView = SC.ListView.extend(
   },
   
   /** @private
-    Overrides default CollectionView method to compute the minimim height
+    Overrides default CollectionView method to compute the minimum height
     of the list view.
   */
   computeLayout: function() {