sproutcore 1.7.1.beta → 1.8.0

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/animation.js

@@ -136,47 +136,5 @@ SC.View.reopen(
   transitionDidEnd: function(evt){
     // WARNING: Sometimes this will get called more than once for a property. Not sure why.
     this.get('layoutStyleCalculator').transitionDidEnd(evt);
-  },
-
-  /**
-    Setting wantsAcceleratedLayer to YES will use transforms to move the
-    layer when available. On some platforms transforms are hardware accelerated.
-  */
-  wantsAcceleratedLayer: NO,
-
-  /**
-    Specifies whether transforms can be used to move the layer.
-  */
-  hasAcceleratedLayer: function(){
-    if (this.get('wantsAcceleratedLayer') && SC.platform.supportsAcceleratedLayers) {
-      var layout = this.get('layout'),
-          animations = layout.animate,
-          AUTO = SC.LAYOUT_AUTO,
-          key;
-
-      if (animations && (animations.top || animations.left)) {
-        for (key in animations) {
-          // If we're animating other transforms at different speeds, don't use acceleratedLayer
-          if (
-            SC.CSS_TRANSFORM_MAP[key] &&
-            ((animations.top && animations.top.duration !== animations[key].duration) ||
-             (animations.left && animations.left.duration !== animations[key].duration))
-          ) {
-            return NO;
-          }
-        }
-      }
-
-      // loose comparison used instead of (layout.X === null || layout.X === undefined)
-      if (
-        layout.left != null && !SC.isPercentage(layout.left) && layout.left !== AUTO &&
-        layout.top != null && !SC.isPercentage(layout.top) && layout.top !== AUTO &&
-        layout.width != null && !SC.isPercentage(layout.width) && layout.width !== AUTO &&
-        layout.height != null && !SC.isPercentage(layout.height) && layout.height !== AUTO
-      ) {
-       return YES;
-      }
-    }
-    return NO;
-  }.property('wantsAcceleratedLayer').cacheable()
+  }
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/keyboard.js

@@ -50,34 +50,7 @@ SC.View.reopen(
   
     @param {SC.Responder} responder
   */
-  didBecomeKeyResponderFrom: function(responder) {
-    
-    // Hack!!!
-    // If we try to execute the focus code right now, the iPad will take this as an opportunity to break
-    // execution of the current Run Loop (if that Run Loop was started by a timer expiring) to execute
-    // any touch event code that is waiting at this time.
-    //
-    // This becomes a problem in particular for ScrollView's that use a timer to pass touches to their content,
-    // because the touchend event can come in while the timer code is executing and pause here to complete
-    // the touchend code and then continue the timer code afterward.  However, the timer code's 
-    // execution context will then be out-of-date and will cause a crash in RootResponder's assignTouch().
-    //
-    // To verify this, use the branch sproutcore/timer_touch_debug in any SproutCore project.  Then visit
-    // the app launcher http://my.local.machine.ip:4020 on an iPad 1 and simply press one of the app's
-    // in the list.  The app should crash on the first touch (depending slightly on the speed at which you
-    // touch the selection; presses will crash it, taps generally won't).  It should occur on the first
-    // touch or else try reloading the app until you get the proper touch speed figured out.
-    //
-    // Using the debug branch, when it crashes, notice how the console statements aren't in order according
-    // to the timestamps and notice how there is a big gap in timestamps around this.$().focus() where the
-    // touchend block of code runs.
-    //
-    // -Tyler Keating : tyler@sproutcore.com
-
-    this.invokeLater(function() {
-      this.$().focus();
-    });
-  },
+  didBecomeKeyResponderFrom: function(responder) {},
 
   /**
     This method will process a key input event, attempting to convert it to
@@ -291,7 +264,6 @@ SC.View.reopen(
   */
   nextValidKeyView: function() {
     var cur = this, next;
-
     while(next !== this) {
       next = null;
 
@@ -303,8 +275,10 @@ SC.View.reopen(
 
       // if we have no children or siblings, unroll up closest parent that has a
       // next sibling
-      if(!next) while(cur = cur.get('parentView')) {
-        if(next = cur._getNextKeyView()) break;
+      if(!next) {
+        while(cur = cur.get('parentView')) {
+          if(next = cur._getNextKeyView()) break;
+        }
       }
 
       // if no parents have a next sibling, start over from the beginning
@@ -314,12 +288,12 @@ SC.View.reopen(
       }
 
       // if it's a valid firstResponder, we're done!
-      if(next.get('isVisibleInWindow') && next.get('acceptsFirstResponder')) return next;
-
+      if(next.get('isVisibleInWindow') && next.get('acceptsFirstResponder')) {
+        return next;
+      }
       // otherwise keep looking
       cur = next;
     }
-
     // this will only happen if no views are visible and accept first responder
     return null;
   }.property('nextKeyView'),

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/layout.js

@@ -230,7 +230,8 @@ SC.View.reopen(
     ret = (
       ((layout.width !== undefined) && (layout.height !== undefined)) &&
       ((layout.width !== SC.LAYOUT_AUTO) && (layout.height !== SC.LAYOUT_AUTO)) &&
-      ((layout.left !== undefined) && (layout.top !== undefined))
+      ((layout.left !== undefined) && (layout.top !== undefined)) &&
+      ((layout.left !== SC.LAYOUT_AUTO) && (layout.top !== SC.LAYOUT_AUTO))
     );
 
     // The layout may appear fixed, but only if none of the values are percentages
@@ -838,7 +839,7 @@ SC.View.reopen(
 
   /**
     One of two methods that are invoked whenever one of your childViews
-    layout changes.  This method is invoked everytime a child view's layout
+    layout changes.  This method is invoked every time a child view's layout
     changes to give you a chance to record the information about the view.
 
     Since this method may be called many times during a single run loop, you

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/layout_style.js

@@ -446,7 +446,16 @@ SC.View.LayoutStyleCalculator = SC.Object.extend({
 
     ret.zIndex     = this.zIndex;
     ret.opacity    = this.opacity;
-    ret.mozOpacity = this.opacity;
+
+    // for ie, we will NOT use alpha. It is just a source of pain.
+    // a) it will not affect absolutely positioned child elements, and is therefore
+    //    useless for most SC purposes.
+    // 
+    // b) It completely breaks semitransparent background images (PNGs with opacity)
+    //
+    // If users want to use alpha, they should do it on their own.
+    
+    // if(!SC.none(this.opacity)) ret.filter = "alpha(opacity=%@)".fmt(this.opacity * 100);
 
     ret.backgroundPosition = this.backgroundPosition;
 

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/manipulation.js

@@ -137,12 +137,13 @@ SC.View.reopen(
       if(pane && pane.get('isPaneAttached')) {
         view._notifyDidAppendToDocument();
       }
-
-      // notify views
-      if (this.didAddChild) { this.didAddChild(view, beforeView) ; }
-      if (view.didAddToParent) { view.didAddToParent(this, beforeView) ; }
     });
 
+    // Even though its layer has not necessarily been created, the child views 
+    // are added immediately. Hence notify views immediately.
+    if (this.didAddChild) { this.didAddChild(view, beforeView) ; }
+    if (view.didAddToParent) { view.didAddToParent(this, beforeView) ; }
+
     return this ;
   },
 
@@ -280,7 +281,7 @@ SC.View.reopen(
   },
 
   /**
-    Implement this, and call didFinsihBuildOut when you are done.
+    Implement this, and call didFinishBuildOut when you are done.
   */
   buildOut: function() {
     this.buildOutDidFinish();

data/lib/frameworks/sproutcore/frameworks/core_foundation/views/view/theming.js

@@ -246,7 +246,27 @@ SC.View.reopen(
       SC.Logger.error("Name '%@' will be ignored.", renderDelegate.name);
     }
     // @endif
-  }.enhance()
+  }.enhance(),
+  
+
+  /**
+    Invokes a method on the render delegate, if one is present and it implements
+    that method.
+    
+    @param {String} method The name of the method to call.
+    @param arg One or more arguments.
+  */
+  invokeRenderDelegateMethod: function(method, args) {
+    var renderDelegate = this.get('renderDelegate');
+    if (!renderDelegate) return undefined;
+    
+    if (SC.typeOf(renderDelegate[method]) !== SC.T_FUNCTION) return undefined;
+    
+    args = SC.$A(arguments);
+    args.shift();
+    args.unshift(this.get('renderDelegateProxy'));
+    return renderDelegate[method].apply(renderDelegate, args);
+  }
 });
 
 /**
@@ -358,7 +378,7 @@ SC.View._RenderDelegateProxy = {
   the view's render delegate, if present. You may specify a default value to
   return if there is no such property or is no render delegate.
   
-  The generated property is read+write, so it may be overriden.
+  The generated property is read+write, so it may be overridden.
   
   @param {String} propertyName The name of the property to get from the render delegate..
   @param {Value} def The default value to use if the property is not present.

data/lib/frameworks/sproutcore/frameworks/datastore/data_sources/data_source.js

@@ -260,7 +260,7 @@ SC.DataSource = SC.Object.extend( /** @scope SC.DataSource.prototype */ {
     queries, you can do so by passing a SC.SparseArray instance instead of
     a regular array of storeKeys and then populate the sparse array on demand.
 
-    ### Handling Errors and Cancelations
+    ### Handling Errors and Cancellations
 
     If you encounter an error while trying to fetch the results for a query
     you can call SC.Store#dataSourceDidErrorQuery() instead.  This will put
@@ -424,7 +424,7 @@ SC.DataSource = SC.Object.extend( /** @scope SC.DataSource.prototype */ {
   },
 
   /**
-    Called from `commitRecords()` to commit destroted records to the
+    Called from `commitRecords()` to commit destroyed records to the
     store.  You can override this method to actually send the destroyed
     records to your store.  The default version will simply call
     `destroyRecord()` for each storeKey.

data/lib/frameworks/sproutcore/frameworks/datastore/mixins/relationship_support.js

@@ -189,7 +189,7 @@ SC.RelationshipSupport = {
     } else if (SC.instanceOf(proto[key], SC.ManyAttribute)) {
       dataHash[hashKey] = dataHash[hashKey] || [];
 
-      if (dataHash[key].indexOf(relativeID) < 0) {
+      if (dataHash[hashKey].indexOf(relativeID) < 0) {
         dataHash[hashKey].push(relativeID);
       }
     }

data/lib/frameworks/sproutcore/frameworks/datastore/models/child_attribute.js

@@ -84,9 +84,7 @@ SC.ChildAttribute = SC.RecordAttribute.extend(
     var attrKey = this.get('key') || key, cRef,
         cacheKey = SC.keyFor('__kid__', SC.guidFor(this));
     if (value !== undefined) {
-      // this.orphan(record, cacheKey, value);
       value = this.fromType(record, key, value) ; // convert to attribute.
-      // record[cacheKey] = value;
     } else {
       value = record.readAttribute(attrKey);
       if (SC.none(value) && (value = this.get('defaultValue'))) {

data/lib/frameworks/sproutcore/frameworks/datastore/models/children_attribute.js

@@ -68,7 +68,42 @@ SC.ChildrenAttribute = SC.ChildAttribute.extend(
     }
     
     return ret;
+  },
+  
+  /**
+    The core handler.  Called from the property.
+    @param {SC.Record} record the record instance
+    @param {String} key the key used to access this attribute on the record
+    @param {Object} value the property value if called as a setter
+    @returns {Object} property value
+  */
+  call: function(record, key, value) {
+    var attrKey = this.get('key') || key, cRef,
+        cacheKey = SC.keyFor('__kid__', SC.guidFor(this));
+    if (value !== undefined) {
+      value = this.fromType(record, key, value) ; // convert to attribute.
+    } else {
+      value = record.readAttribute(attrKey);
+      if (SC.none(value) && (value = this.get('defaultValue'))) {
+        if (typeof value === SC.T_FUNCTION) {
+          value = this.defaultValue(record, key, this);
+          // write default value so it doesn't have to be executed again
+          if (record.attributes()) {
+            // Check for an array
+            if (value instanceof Array) {
+              // Instantiate the construct and replace all of the content.
+              value = this.toType(record, key, value).replace(0, value.length, value);
+            } else {
+              record.writeAttribute(attrKey, value, true);
+            }
+          }
+        }
+      } else value = this.toType(record, key, value);
+    }
+  
+    return value ;
   }
+    
 });
 
 

data/lib/frameworks/sproutcore/frameworks/datastore/models/record.js

@@ -336,7 +336,7 @@ SC.Record = SC.Object.extend(
 
   /**
     You can invoke this method anytime you need to make the record as dirty.
-    This will cause the record to be commited when you `commitChanges()`
+    This will cause the record to be committed when you `commitChanges()`
     on the underlying store.
 
     If you use the `writeAttribute()` primitive, this method will be called
@@ -466,23 +466,22 @@ SC.Record = SC.Object.extend(
     Should not have to be called manually.
   */
   propagateToAggregates: function() {
-    var storeKey = this.get('storeKey'),
+    var storeKey   = this.get('storeKey'),
         recordType = SC.Store.recordTypeFor(storeKey),
-        idx, len, key, val, recs;
-
-    var aggregates = recordType.aggregates;
+        aggregates = recordType.__sc_aggregate_keys,
+        idx, len, key, prop, val, recs;
 
     // if recordType aggregates are not set up yet, make sure to
     // create the cache first
     if (!aggregates) {
-      var dataHash = this.get('store').readDataHash(storeKey);
       aggregates = [];
-      for(var k in dataHash) {
-        if(this[k] && this[k].get && this[k].get('aggregate')===YES) {
-          aggregates.push(k);
+      for (key in this) {
+        prop = this[key];
+        if (prop  &&  prop.isRecordAttribute  &&  prop.aggregate === YES) {
+          aggregates.push(key);
         }
       }
-      recordType.aggregates = aggregates;
+      recordType.__sc_aggregate_keys = aggregates;
     }
 
     // now loop through all aggregate properties and mark their related
@@ -505,13 +504,19 @@ SC.Record = SC.Object.extend(
       @param {SC.Record} record to propagate to
     */
     iter =  function(rec) {
-      var childStatus, parentStatus;
+      var childStatus, parentStore, parentStoreKey, parentStatus;
 
       if (rec) {
         childStatus = this.get('status');
         if ((childStatus & dirty)  ||
             (childStatus & readyNew)  ||  (childStatus & destroyed)) {
-          parentStatus = rec.get('status');
+
+          // Since the parent can cache 'status', and we might be called before
+          // it has been invalidated, we'll read the status directly rather than
+          // trusting the cache.
+          parentStore    = rec.get('store');
+          parentStoreKey = rec.get('storeKey');
+          parentStatus   = parentStore.peekStatus(parentStoreKey);
           if (parentStatus === readyClean) {
             // Note:  storeDidChangeProperties() won't put it in the
             //        changelog!
@@ -583,6 +588,7 @@ SC.Record = SC.Object.extend(
         recordId   = this.get('id'),
         store      = this.get('store'),
         storeKey   = this.get('storeKey'),
+        keysToKeep = {},
         key, valueForKey, typeClass, recHash, attrValue, normChild,  isRecord,
         isChild, defaultVal, keyForDataHash, attr;
 
@@ -597,11 +603,17 @@ SC.Record = SC.Object.extend(
         typeClass = valueForKey.typeClass;
         if (typeClass) {
           keyForDataHash = valueForKey.get('key') || key; // handle alt keys
+
+          // As we go, we'll build up a key —> attribute mapping table that we
+          // can use when purging keys from the data hash that are not defined
+          // in the schema, below.
+          keysToKeep[keyForDataHash] = YES;
+
           isRecord = SC.typeOf(typeClass.call(valueForKey))===SC.T_CLASS;
           isChild  = valueForKey.isNestedRecordTransform;
           if (!isRecord && !isChild) {
             attrValue = this.get(key);
-            if(attrValue!==undefined || (attrValue===null && includeNull)) {
+            if(attrValue!==undefined && (attrValue!==null || includeNull)) {
               attr = this[key];
               // if record attribute, make sure we transform with the fromType
               if(SC.instanceOf(attr, SC.RecordAttribute)) {
@@ -609,6 +621,9 @@ SC.Record = SC.Object.extend(
               }
               dataHash[keyForDataHash] = attrValue;
             }
+            else if(!includeNull) {
+              keysToKeep[keyForDataHash] = NO;
+            }
 
           } else if (isChild) {
             attrValue = this.get(key);
@@ -640,6 +655,18 @@ SC.Record = SC.Object.extend(
       }
     }
 
+    // Finally, we'll go through the underlying data hash and remove anything
+    // for which no appropriate attribute is defined.  We can do this using
+    // the mapping table we prepared above.
+    for (key in dataHash) {
+      if (!keysToKeep[key]) {
+        // Deleting a key doesn't seem too common unless it's a mistake, so
+        // we'll log it in debug mode.
+        SC.debug("%@:  Deleting key from underlying data hash due to normalization:  %@", this, key);
+        delete dataHash[key];
+      }
+    }
+
     return this;
   },
 
@@ -691,7 +718,7 @@ SC.Record = SC.Object.extend(
     Lets you commit this specific record to the store which will trigger
     the appropriate methods in the data source for you.
 
-    @param {Hash} params optional additonal params that will passed down
+    @param {Hash} params optional additional params that will passed down
       to the data source
     @param {boolean} recordOnly optional param if you want to only commit a single
       record if it has a parent.
@@ -913,7 +940,7 @@ SC.Record = SC.Object.extend(
 
       if (!id && (pk = recordType.prototype.primaryKey)) {
         id = hash[pk];
-        // In case there isnt a primary key supplied then we create on
+        // In case there is not a primary key supplied then we create on
         // on the fly
         sk = id ? store.storeKeyExists(recordType, id) : null;
         if (sk){
@@ -1336,9 +1363,9 @@ SC.Record.mixin( /** @scope SC.Record */ {
     opts = opts || {};
     var isNested = opts.nested || opts.isNested;
     var attr;
-    
+
     this._throwUnlessRecordTypeDefined(recordType, 'toMany');
-    
+
     if(isNested){
       attr = SC.ChildrenAttribute.attr(recordType, opts);
     }
@@ -1352,7 +1379,7 @@ SC.Record.mixin( /** @scope SC.Record */ {
     Will return one of the following:
 
      1. `SC.SingleAttribute` that converts the underlying ID to a single
-        record.  If you modify this property, it will rewrite the underyling
+        record.  If you modify this property, it will rewrite the underlying
         ID. It will also modify the inverse of the relationship, if you set it.
      2. `SC.ChildAttribute` that you can edit the contents
         of this relationship.
@@ -1376,7 +1403,7 @@ SC.Record.mixin( /** @scope SC.Record */ {
     }
     return attr;
   },
-  
+
   _throwUnlessRecordTypeDefined: function(recordType, relationshipType) {
     if (!recordType) {
       throw "Attempted to create " + relationshipType + " attribute with " +