sproutcore 1.7.1.beta → 1.8.0

data/lib/frameworks/sproutcore/frameworks/desktop/views/stacked.js

@@ -20,7 +20,7 @@ sc_require('views/collection') ;
   
   This view makes no attempt to size or position your child views.  It assumes
   you are using StaticLayout for your child views.  If you don't enable static
-  layout your views will probably overlay on top of eachother and will look 
+  layout your views will probably overlay on top of each other and will look 
   incorrect.
 
   Note also that the default layout for this view set's the height to "auto".
@@ -72,7 +72,7 @@ SC.StackedView = SC.CollectionView.extend(
     of the view until the end of the run loop.  You can force an immediate 
     update by passing YES to the "immediately" parameter.
     
-    @param {Boolean} immediately YES to update immedately
+    @param {Boolean} immediately YES to update immediately
     @returns {SC.StackedView} receiver
   */
   updateHeight: function(immediately) {

data/lib/frameworks/sproutcore/frameworks/desktop/views/static_content.js

@@ -12,7 +12,7 @@
 
   Normally, views in SproutCore are absolutely positioned. Their width and
   height are either pre-determined, or specified relative to their enclosing
-  view. Occasionally, you may want to display content that is layed out by
+  view. Occasionally, you may want to display content that is laid out by
   the browser. For example, if you were writing a documentation browser, you
   may want to display the table of contents as an SC.ListView, but the actual
   pages as HTML content.
@@ -96,7 +96,7 @@ SC.StaticContentView = SC.View.extend(SC.StaticLayout,
 
     if (!layer) return { x: 0, y: 0, width: 0, height: 0 };
 
-    if (layer.getBoundingClientRect) {
+    if (layer.getBoundingClientRect && !SC.browser.isIE8OrLower) {
       rect = layer.getBoundingClientRect();
 
       return { x: 0, y: 0, width: rect.width, height: rect.height };

data/lib/frameworks/sproutcore/frameworks/desktop/views/tab.js

@@ -195,7 +195,7 @@ SC.TabView = SC.View.extend(
 
   /** @private */
   createChildViews: function() {
-    var childViews  = [], view, containerView, layout,
+    var childViews  = [], containerView, layout,
         tabLocation = this.get('tabLocation'),
         tabHeight   = this.get('tabHeight'),
         controlSize = this.get('controlSize');
@@ -214,9 +214,8 @@ SC.TabView = SC.View.extend(
       ariaRole: 'tabpanel'
     });
 
-    view = this.containerView = this.createChildView(containerView) ;
-    childViews.push(view);
-
+    this.containerView = this.createChildView(containerView) ;
+    
     //  The segmentedView managed by this tab view.  Note that this TabView uses
     //  a custom segmented view.  You can access this view but you cannot change
     // it.
@@ -250,9 +249,11 @@ SC.TabView = SC.View.extend(
       }
     });
 
-    view = this.segmentedView = this.createChildView(this.segmentedView) ;
-    childViews.push(view);
-
+    this.segmentedView = this.createChildView(this.segmentedView) ;
+    
+    childViews.push(this.segmentedView);
+    childViews.push(this.containerView);
+    
     this.set('childViews', childViews);
     return this;
   },

data/lib/frameworks/sproutcore/frameworks/desktop/views/web.js

@@ -26,7 +26,7 @@ SC.WebView = SC.View.extend(SC.Control, {/** @scope SC.WebView.prototype */
   displayProperties: ['value', 'shouldAutoResize'],
 
   /**
-    The content of the iframe can be bigger than the size specifed when creating
+    The content of the iframe can be bigger than the size specified when creating
     the view. If you want the view to be auto-resized to the dimensions of the
     iframe, then set the value of this property to YES.
     The web view can be auto resized only if the contents are from the same
@@ -95,7 +95,7 @@ SC.WebView = SC.View.extend(SC.Control, {/** @scope SC.WebView.prototype */
         if(contentWindow && contentWindow.document && contentWindow.document.documentElement){
           var docElement = contentWindow.document.documentElement;
           // setting the width before the height gives more accurate results..
-          // atleast for the test iframe content i'm using.
+          // at least for the test iframe content i'm using.
           //TODO: try out document flows other than top to bottom.
           if (!SC.browser.isIE) {
             this.$().width(docElement.scrollWidth);

data/lib/frameworks/sproutcore/frameworks/experimental/Buildfile

@@ -12,3 +12,5 @@ config :greenhouse,
   :css_theme => 'ace.greenhouse'
 
 config :polymorphism, :required => :datastore
+
+config :split_view, :required => :foundation

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/controllers/files.js

@@ -28,7 +28,7 @@ Greenhouse.filesController = SC.TreeController.create(SC.CollectionViewDelegate,
   treeItemChildrenKey: "contents",
   
   /**
-    Call this method whenever you want to relaod the files from the server.
+    Call this method whenever you want to reload the files from the server.
   */
   reload: function() {
     var fileQuery = Greenhouse.FILES_QUERY, target = Greenhouse.targetController.get('content');

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/controllers/library.js

@@ -15,7 +15,7 @@
 Greenhouse.libraryController = SC.TreeController.create( SC.CollectionViewDelegate,
 /** @scope Greenhouse.libraryController.prototype */ {
   /**
-    Call this method whenever you want to relaod the library from hte server
+    Call this method whenever you want to reload the library from hte server
   */
   reload: function() {
     var configQuery = Greenhouse.CONFIG_QUERY, target = Greenhouse.targetController.get('content');

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/controllers/targets.js

@@ -20,7 +20,7 @@ Greenhouse.targetsController = SC.ArrayController.create(
 /** @scope Greenhouse.targetsController.prototype */ {
 
   /**
-    Call this method whenever you want to relaod the targets from the server.
+    Call this method whenever you want to reload the targets from the server.
   */
   reload: function() {
     var targets = Greenhouse.store.find(Greenhouse.TARGETS_QUERY);

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/controllers/view_configs.js

@@ -14,7 +14,7 @@ Greenhouse.viewConfigsController = SC.ArrayController.create(
 /** @scope Greenhouse.viewConfigsController.prototype */ {
 
   /**
-    Call this method whenever you want to relaod the view configs from the server.
+    Call this method whenever you want to reload the view configs from the server.
   */
   reload: function() {
     var configQuery = Greenhouse.CONFIG_QUERY, target = Greenhouse.targetController.get('content');

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/mixins/drop_down.js

@@ -50,7 +50,7 @@ Greenhouse.DropDown = {
       }
     }
 
-    // TODO: [BB] Check for existance of target and action
+    // TODO: [BB] Check for existence of target and action
     if (this.target !== undefined && this.action !== undefined) {
       this.set('target', this);
       this.set('action', 'toggle');

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/states/ready.js

@@ -133,7 +133,7 @@ Greenhouse.mixin( /** @scope Greenhouse */{
     fileSelected: SC.State.design({
 
       enterState: function(){
-        //TODO: draw message saing we can't do anythign with this right now...
+        //TODO: draw message saying we can't do anything with this right now...
       },
       exitState: function(){}
     }),

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/views/plist_item.js

@@ -129,7 +129,7 @@ Greenhouse.PlistItemView = SC.View.extend(SC.Control,
     this._checkboxRenderDelegate = renderer;
   },
   /** 
-    Determines if the event occured inside an element with the specified
+    Determines if the event occurred inside an element with the specified
     classname or not.
   */
   _isInsideElementWithClassName: function(className, evt) {

data/lib/frameworks/sproutcore/frameworks/experimental/apps/greenhouse/views/web.js

@@ -22,7 +22,7 @@ Greenhouse.WebView = SC.WebView.extend(
         if(contentWindow && contentWindow.document && contentWindow.document.documentElement){
           var docElement = contentWindow.document.documentElement;
           // setting the width before the height gives more accurate results.. 
-          // atleast for the test iframe content i'm using.
+          // at least for the test iframe content i'm using.
           //TODO: try out document flows other than top to bottom.
           if (!SC.browser.isIE){
             this.$().width(docElement.scrollWidth);

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/controllers/page_design.js

@@ -30,7 +30,7 @@ SC.PageDesignController = SC.Object.extend({
   selection: null,
   
   /** 
-    Updates the selection either by adding the item or by reseting the 
+    Updates the selection either by adding the item or by resetting the 
     selection.  Calling this method with no parameters will reset the 
     selection.
     
@@ -155,7 +155,7 @@ SC.PageDesignController = SC.Object.extend({
     this.deselect(designer);
     designer.set('isRootDesigner', YES);
     designer.set('prevRootDesigner', currRoot);
-    //TODO: allow greenhouse to hightlight the root view!
+    //TODO: allow greenhouse to highlight the root view!
     this.set('rootDesigner', designer);
   },
   

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/css/css_style_sheet.js

@@ -46,7 +46,7 @@ SC.CSSStyleSheet = SC.Object.extend(
   },
   
   /**
-    @property {Boolean} YES if the stylsheet is enabled.
+    @property {Boolean} YES if the stylesheet is enabled.
   */
   isEnabled: function(key, val) {
     if (val !== undefined) {
@@ -144,7 +144,7 @@ SC.mixin(SC.CSSStyleSheet,
         var ss2 = SC.CSSStyleSheet.find('style') ; // same thing
         sc_assert(ss === ss2) ; // SC.CSSStyleSheet objects are stable
     
-    @param {String} nameOrUrl a stylsheet name or href to find
+    @param {String} nameOrUrl a stylesheet name or href to find
     @returns {SC.CSSStyleSheet} null if not found
   */
   find: function(nameOrUrl) {

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/designers/object_designer.js

@@ -99,7 +99,7 @@ SC.ObjectDesigner = SC.Object.extend(
   
   
   /*
-    Array of properties avaliaible to edit in greenhouse
+    Array of properties available to edit in greenhouse
     
   */
   editableProperties: function(){

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/designers/view_designer.js

@@ -352,7 +352,7 @@ SC.ViewDesigner = SC.Object.extend(
 
 
   /*
-    Array of properties avaliaible to edit in greenhouse
+    Array of properties available to edit in greenhouse
 
   */
   editableProperties: function(){
@@ -485,7 +485,7 @@ SC.ViewDesigner = SC.Object.extend(
 
 
   /**
-    over-ride this method in your designers to customies drop operations
+    over-ride this method in your designers to customize drop operations
     default just calls appendChild
 
     TODO: Come up with a better name for this method.

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/mixins/snap_lines.js

@@ -38,7 +38,7 @@ SC.SnapLines = {
   
   
   /*
-    This method will setup the datastructure required to draw snap lines
+    This method will setup the data structure required to draw snap lines
     it should be called in dragStarted if using with an `SC.Drag` or on
     `mouseDown` if using it with a move
   
@@ -123,7 +123,7 @@ SC.SnapLines = {
     This method will check the passed views position with the other child views
     and draw any lines.  It should be called in `dragUpdated` if using `SC.Drag`
     or in `mouseMoved` if using a move.  it will also return a hash of the
-    snapped coords in local and global coodinates
+    snapped coords in local and global coordinates
     
   */
   drawLines: function(view, eventX, eventY, mouseDownX, mouseDownY){
@@ -137,7 +137,7 @@ SC.SnapLines = {
         rMinY, rMidY, rMaxY, rMinXMod, rMidXMod, rMaxXMod, rMinYMod, rMidYMod, rMaxYMod, xHit, yHit,
         moveDirection = this._dragDirection(eventX, eventY, mouseDownX, mouseDownY), xValues, yValues, 
         that = this, xHitVals, yHitVals, ret;
-    //get the frame and all the relavent points of interest
+    //get the frame and all the relevant points of interest
     parent = view.get('parentView');
     frame = parent ? parent.convertFrameToView(view.get('frame'), null) : view.get('frame');
     rMinX = SC.minX(frame);

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/views/designer_drop_target.js

@@ -91,7 +91,7 @@ SC.DesignerDropTarget = SC.ContainerView.extend(
   /**
     Called to actually perform the drag operation.
     
-    Overide this method to actually perform the drag operation.  This method
+    Override this method to actually perform the drag operation.  This method
     is only called if you returned `YES` in `acceptDragOperation()`.
     
     Return the operation that was actually performed or `SC.DRAG_NONE` if the

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/views/drawing.js

@@ -59,8 +59,8 @@
           ?transparency: 0.2
         }
       }
-  
-  @author Evin Grano 
+
+  @author Evin Grano
   @extends SC.View
   @since SproutCore 1.0
 */
@@ -74,23 +74,23 @@ SC.STROKE = 'stroke';
 
 
 SC.DrawingView = SC.View.extend({
-  
+
   classNames: 'scui-drawing-view',
-  
+
   shapes: [],
-  
+
   _drawingManager: {},
-  
+
   shapesDidChange: function(){
     this.set('layerNeedsUpdate', YES);
     this.updateLayerIfNeeded();
   }.observes('*shapes.[]'),
-  
+
   init: function(){
     sc_super();
-    
+
     // Register Basic Shapes
-    
+
     // Drawing a Line
     this.registerShapeDrawing( SC.LINE, function(ctx, params){
       if (params.style){
@@ -103,7 +103,7 @@ SC.DrawingView = SC.View.extend({
       ctx.lineTo(params.end.x, params.end.y);
       ctx.stroke();
     });
-    
+
     // Drawing a Rectangle
     this.registerShapeDrawing( SC.RECT, function(ctx, params){
       if (params.style){
@@ -123,7 +123,7 @@ SC.DrawingView = SC.View.extend({
           break;
       }
     });
-    
+
     // Drawing a Circle
     this.registerShapeDrawing( SC.CIRCLE, function(ctx, params){
       if (params.style){
@@ -136,7 +136,7 @@ SC.DrawingView = SC.View.extend({
       if (params.type === SC.FILL) ctx.fill();
       else ctx.stroke();
     });
-    
+
     // Drawing a Polygon
     this.registerShapeDrawing( SC.POLY, function(ctx, params){
       if (params.style){
@@ -147,7 +147,7 @@ SC.DrawingView = SC.View.extend({
       ctx.beginPath();
       var len = params.path ? params.path.length : 0;
       if (len < 2) return;
-      
+
       var path = params.path, curr;
       ctx.moveTo(path[0].x, path[0].y);
       for(var i = 1; i < len; i++){
@@ -159,12 +159,12 @@ SC.DrawingView = SC.View.extend({
       else ctx.stroke();
     });
   },
-  
+
   render: function(context, firstTime) {
     //console.log('%@.render()'.fmt(this));
     var frame = this.get('frame');
     if (firstTime) {
-      if (!SC.browser.msie) {
+      if (!SC.browser.isIE) {
         context.push('<canvas class="base-layer" width="%@" height="%@">You can\'t use canvas tags</canvas>'.fmt(frame.width, frame.height));
       }
     }
@@ -191,26 +191,26 @@ SC.DrawingView = SC.View.extend({
         SC.Logger.error("SC.DrawingView.render(): Canvas element is not accessible.");
       }
     }
-    
+
     return sc_super();
   },
-  
+
   registerShapeDrawing: function(name, drawingFunction){
     if (!name) {
       SC.Logger.error('Can\'t register this drawing paradigm because name is null');
       return NO;
     }
-    
+
     // OK, create the drawing paradigm
     this._drawingManager[name] = drawingFunction;
     this.set('layerNeedsUpdate', YES);
     this.updateLayerIfNeeded();
     return YES;
   },
-  
+
   /**
-    @private 
-    
+    @private
+
     Function for actually drawing the shapes that we have listed
   */
   _drawShapes: function(cntx){

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/designer/views/page_item_view.js

@@ -74,7 +74,7 @@ SC.pageItemView = SC.ListItemView.extend(
   /**
    Called to actually perform the drag operation.
 
-   Overide this method to actually perform the drag operation.  This method
+   Override this method to actually perform the drag operation.  This method
    is only called if you returned `YES` in `acceptDragOperation()`.
 
    Return the operation that was actually performed or `SC.DRAG_NONE` if the

data/lib/frameworks/sproutcore/frameworks/experimental/frameworks/forms/views/form.js

@@ -92,70 +92,76 @@ SC.FormView = SC.View.extend(SC.FlowedLayout, SC.CalculatesEmptiness, SC.FormsEd
   /**
   */
   createChildViews: function() {
-    var cv = SC.clone(this.get("childViews"));
-    var idx, len = cv.length, key, v, exampleRow = this.get("exampleRow");
-
-    // rows that are provided as plain hashes need to be created by passing them into
-    // exampleRow.extend.
-    for (idx = 0; idx < len; idx++) {
-      key = cv[idx];
-      if (SC.typeOf(key) === SC.T_STRING) {
-        v = this.get(key);
-        if (v && !v.isClass && SC.typeOf(v) === SC.T_HASH) {
-          this[key] = exampleRow.extend(v);
+    var childViews = this.get('childViews'),
+        len        = childViews.length,
+        idx, key, views, view,
+        attrs, exampleRow = this.get('exampleRow');
+
+    this.beginPropertyChanges() ;
+
+    // swap the array
+    for (idx=0; idx<len; ++idx) {
+      if (key = (view = childViews[idx])) {
+
+        // is this is a key name, lookup view class
+        if (typeof key === SC.T_STRING) {
+          view = this[key];
+        } else {
+          key = null ;
         }
-      }
-    }
 
-    // we will be initializing the 'content' property for all child views
-    var content = this.get("content");
-    sc_super();
+        if (!view) {
+          SC.Logger.error ("No view with name "+key+" has been found in "+this.toString());
+          // skip this one.
+          continue;
+        }
 
-    for (idx = 0; idx < len; idx++) {
-      key = cv[idx];
-
-      // if the view was originally declared as a string, then we have something to give it
-      if (SC.typeOf(key) === SC.T_STRING) {
-        // try to get the actual view
-        v = this.get(key);
-
-        if (v && !v.isClass) {
-          // we used to set contentValueKey on applicable children, but given that was too
-          // implicit: any LabelView child of the form view would get the contentValueKey.
-          // 
-          // instead, we give ALL views a formKey for their convenience; if they want to
-          // use contentValue support they should do so directly.
-          v.set('formKey', key);
-
-          // We used to try to be clever and bind child views' 'content' to 
-          // individual properties if the views didn't have content value support.
-          // For instance, a plain view named 'myView' would get bound to content.myView.
-          //
-          // Cleverness is evil, so, we have dropped this. Instead, we always bind content,
-          // and always do so directly.
-          if (!v.get("content")) {
-            v.bind('content', this, 'content');
-          }
+        if(!view.isClass && SC.typeOf(view) === SC.T_HASH) {
+          attrs = view;
+          view = exampleRow;
+        }
+        else {
+          attrs = {};
+        }
+
+        if((attrs.isFormField || view.prototype.isFormField) && (attrs.hasContentValueSupport || view.prototype.hasContentValueSupport)) {
+          attrs.contentValueKey = key;
+        }
 
-          // for form rows, set up label measuring and the label itself.
-          if (v.isFormRow) {
-            // set label (if possible).
-            if (SC.none(v.get('label'))) {
-                v.set("label", key.humanize().titleize());
-            }
-
-            // set the label size measuring stuff
-            if (this.get('labelWidth') !== null) {
-              v.set("shouldMeasureLabel", NO);
-            }
+        attrs.formKey = key;
+
+        // createChildView creates the view if necessary, but also sets
+        // important properties, such as parentView
+        view = this.createChildView(view, attrs) ;
+
+        if(!view.get('content')) {
+          view.bind('content', this, 'content');
+        }
+
+        // for form rows, set up label measuring and the label itself.
+        if (view.isFormRow) {
+          // set label (if possible).
+          if (SC.none(view.get('label'))) {
+              view.set("label", key.humanize().titleize());
           }
 
+          // set the label size measuring stuff
+          if (this.get('labelWidth') !== null) {
+            view.set("shouldMeasureLabel", NO);
+          }
         }
+
+        if (key) { this[key] = view ; } // save on key name if passed
       }
+      childViews[idx] = view;
     }
 
+    this.endPropertyChanges() ;
+
     this._hasCreatedRows = YES;
     this.recalculateLabelWidth();
+
+    return this ;
   },
 
   
@@ -216,7 +222,7 @@ SC.FormView = SC.View.extend(SC.FlowedLayout, SC.CalculatesEmptiness, SC.FormsEd
     if (this._rowLabelSize !== ret) {
       this._rowLabelSize = ret;
       
-      // set by looping throuhg child views
+      // set by looping through child views
       for (idx = 0; idx < len; idx++) {
         child = children[idx];