spree_core 3.1.14 → 3.2.0.rc1

data/spec/models/spree/product/scopes_spec.rb

@@ -0,0 +1,183 @@
+require 'spec_helper'
+
+describe "Product scopes", type: :model do
+  let!(:product) { create(:product) }
+
+  describe '#available' do
+    context 'when discontinued' do
+      let!(:discontinued_product) { create(:product, discontinue_on: Time.current - 1.day) }
+
+      it { expect(Spree::Product.available).not_to include(discontinued_product) }
+    end
+
+    context 'when not discontinued' do
+      let!(:product_2) { create(:product, discontinue_on: Time.current + 1.day) }
+
+      it { expect(Spree::Product.available).to include(product_2) }
+    end
+
+    context 'when available' do
+      let!(:product_2) { create(:product, available_on: Time.current - 1.day) }
+
+      it { expect(Spree::Product.available).to include(product_2) }
+    end
+
+    context 'when not available' do
+      let!(:unavailable_product) { create(:product, available_on: Time.current + 1.day) }
+
+      it { expect(Spree::Product.available).not_to include(unavailable_product) }
+    end
+
+    context 'when multiple prices present' do
+      let!(:price_1) { create(:price, currency: 'EUR', variant: product.master) }
+      let!(:price_2) { create(:price, currency: 'EUR', variant: product.master) }
+
+      it 'should not duplicate product' do
+        expect(Spree::Product.available).to eq([product])
+      end
+    end
+  end
+
+  context "A product assigned to parent and child taxons" do
+    before do
+      @taxonomy = create(:taxonomy)
+      @root_taxon = @taxonomy.root
+
+      @parent_taxon = create(:taxon, name: 'Parent', taxonomy_id: @taxonomy.id, parent: @root_taxon)
+      @child_taxon = create(:taxon, name:'Child 1', taxonomy_id: @taxonomy.id, parent: @parent_taxon)
+      @parent_taxon.reload # Need to reload for descendents to show up
+
+      product.taxons << @parent_taxon
+      product.taxons << @child_taxon
+    end
+
+    it "calling Product.in_taxon returns products in child taxons" do
+      product.taxons -= [@child_taxon]
+      expect(product.taxons.count).to eq(1)
+
+      expect(Spree::Product.in_taxon(@parent_taxon)).to include(product)
+    end
+
+    it "calling Product.in_taxon should not return duplicate records" do
+      expect(Spree::Product.in_taxon(@parent_taxon).to_a.count).to eq(1)
+    end
+
+    context 'orders products based on their ordering within the classifications' do
+      let(:other_taxon) { create(:taxon, products: [product]) }
+      let!(:product_2) { create(:product, taxons: [@child_taxon, other_taxon]) }
+
+      it 'by initial ordering' do
+        expect(Spree::Product.in_taxon(@child_taxon)).to eq([product, product_2])
+        expect(Spree::Product.in_taxon(other_taxon)).to eq([product, product_2])
+      end
+
+      it 'after ordering changed' do
+        [@child_taxon, other_taxon].each do |taxon|
+          Spree::Classification.find_by(taxon: taxon, product: product).insert_at(2)
+          expect(Spree::Product.in_taxon(taxon)).to eq([product_2, product])
+        end
+      end
+    end
+  end
+
+  context "property scopes" do
+    let(:name) { "A proper tee" }
+    let(:value) { "A proper value"}
+    let!(:property) { create(:property, name: name)}
+
+    before do
+      product.properties << property
+      product.product_properties.find_by(property: property).update_column(:value, value)
+    end
+
+    context "with_property" do
+      let(:with_property) { Spree::Product.method(:with_property) }
+      it "finds by a property's name" do
+        expect(with_property.(name).count).to eq(1)
+      end
+
+      it "doesn't find any properties with an unknown name" do
+        expect(with_property.("fake").count).to eq(0)
+      end
+
+      it "finds by a property" do
+        expect(with_property.(property).count).to eq(1)
+      end
+
+      it "finds by an id" do
+        expect(with_property.(property.id).count).to eq(1)
+      end
+
+      it "cannot find a property with an unknown id" do
+        expect(with_property.(0).count).to eq(0)
+      end
+    end
+
+    context "with_property_value" do
+      let(:with_property_value) { Spree::Product.method(:with_property_value) }
+      it "finds by a property's name" do
+        expect(with_property_value.(name, value).count).to eq(1)
+      end
+
+      it "cannot find by an unknown property's name" do
+        expect(with_property_value.("fake", value).count).to eq(0)
+      end
+
+      it "cannot find with a name by an incorrect value" do
+        expect(with_property_value.(name, "fake").count).to eq(0)
+      end
+
+      it "finds by a property" do
+        expect(with_property_value.(property, value).count).to eq(1)
+      end
+
+      it "cannot find with a property by an incorrect value" do
+        expect(with_property_value.(property, "fake").count).to eq(0)
+      end
+
+      it "finds by an id with a value" do
+        expect(with_property_value.(property.id, value).count).to eq(1)
+      end
+
+      it "cannot find with an invalid id" do
+        expect(with_property_value.(0, value).count).to eq(0)
+      end
+
+      it "cannot find with an invalid value" do
+        expect(with_property_value.(property.id, "fake").count).to eq(0)
+      end
+    end
+  end
+
+  context '#add_simple_scopes' do
+    let(:simple_scopes) { [:ascend_by_updated_at, :descend_by_name] }
+
+    before do
+      Spree::Product.add_simple_scopes(simple_scopes)
+    end
+
+    context 'define scope' do
+      context 'ascend_by_updated_at' do
+        context 'on class' do
+          it { expect(Spree::Product.ascend_by_updated_at.to_sql).to eq Spree::Product.order("#{Spree::Product.quoted_table_name}.updated_at ASC").to_sql }
+        end
+
+        context 'on ActiveRecord::Relation' do
+          it { expect(Spree::Product.limit(2).ascend_by_updated_at.to_sql).to eq Spree::Product.limit(2).order("#{Spree::Product.quoted_table_name}.updated_at ASC").to_sql }
+          it { expect(Spree::Product.limit(2).ascend_by_updated_at.to_sql).to eq Spree::Product.ascend_by_updated_at.limit(2).to_sql }
+        end
+      end
+
+      context 'descend_by_name' do
+        context 'on class' do
+          it { expect(Spree::Product.descend_by_name.to_sql).to eq Spree::Product.order("#{Spree::Product.quoted_table_name}.name DESC").to_sql }
+        end
+
+        context 'on ActiveRecord::Relation' do
+          it { expect(Spree::Product.limit(2).descend_by_name.to_sql).to eq Spree::Product.limit(2).order("#{Spree::Product.quoted_table_name}.name DESC").to_sql }
+          it { expect(Spree::Product.limit(2).descend_by_name.to_sql).to eq Spree::Product.descend_by_name.limit(2).to_sql }
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/product_duplicator_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+
+module Spree
+
+  describe Spree::ProductDuplicator, type: :model do
+
+    let(:product) { create(:product, properties: [create(:property, name: "MyProperty")])}
+    let!(:duplicator) { Spree::ProductDuplicator.new(product)}
+
+    let(:image) { File.open(File.expand_path('../../../fixtures/thinking-cat.jpg', __FILE__)) }
+    let(:params) { {viewable_id: product.master.id, viewable_type: 'Spree::Variant', attachment: image, alt: "position 1", position: 1} }
+
+    before do
+      Spree::Image.create(params)
+    end
+
+    it "will duplicate the product" do
+      expect{duplicator.duplicate}.to change{Spree::Product.count}.by(1)
+    end
+
+    context 'when image duplication enabled' do
+
+      it "will duplicate the product images" do
+        expect{duplicator.duplicate}.to change{Spree::Image.count}.by(1)
+      end
+
+    end
+
+    context 'when image duplication disabled' do
+
+      let!(:duplicator) { Spree::ProductDuplicator.new(product, false) }
+
+      it "will not duplicate the product images" do
+        expect{duplicator.duplicate}.to change{Spree::Image.count}.by(0)
+      end
+
+    end
+
+    context 'image duplication default' do
+
+      context 'when default is set to true' do
+
+        it 'clones images if no flag passed to initializer' do
+          expect{duplicator.duplicate}.to change{Spree::Image.count}.by(1)
+        end
+
+      end
+
+      context 'when default is set to false' do
+
+        before do
+          ProductDuplicator.clone_images_default = false
+        end
+
+        after do
+          ProductDuplicator.clone_images_default = true
+        end
+
+        it 'does not clone images if no flag passed to initializer' do
+          expect{ProductDuplicator.new(product).duplicate}.to change{Spree::Image.count}.by(0)
+        end
+
+      end
+
+    end
+
+    context "product attributes" do
+      let!(:new_product) {duplicator.duplicate}
+
+      it "will set an unique name" do
+        expect(new_product.name).to eql "COPY OF #{product.name}"
+      end
+
+      it "will set an unique sku" do
+        expect(new_product.sku).to include "COPY OF SKU"
+      end
+
+      it "copied the properties" do
+        expect(new_product.product_properties.count).to be 1
+        expect(new_product.product_properties.first.property.name).to eql "MyProperty"
+      end
+    end
+
+    context "with variants" do
+      let(:option_type) { create(:option_type, name: "MyOptionType")}
+      let(:option_value1) { create(:option_value, name: "OptionValue1", option_type: option_type)}
+      let(:option_value2) { create(:option_value, name: "OptionValue2", option_type: option_type)}
+
+      let!(:variant1) { create(:variant, product: product, option_values: [option_value1]) }
+      let!(:variant2) { create(:variant, product: product, option_values: [option_value2]) }
+
+      it  "will duplciate the variants" do
+        # will change the count by 3, since there will be a master variant as well
+        expect{duplicator.duplicate}.to change{Spree::Variant.count}.by(3)
+      end
+
+      it "will not duplicate the option values" do
+        expect{duplicator.duplicate}.to change{Spree::OptionValue.count}.by(0)
+      end
+
+    end
+  end
+end

data/spec/models/spree/product_filter_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+require 'spree/core/product_filters'
+
+describe 'product filters', type: :model do
+  # Regression test for #1709
+  context 'finds products filtered by brand' do
+    let(:product) { create(:product) }
+    before do
+      property = Spree::Property.create!(name: "brand", presentation: "brand")
+      product.set_property("brand", "Nike")
+    end
+
+    it "does not attempt to call value method on Arel::Table" do
+      expect { Spree::Core::ProductFilters.brand_filter }.not_to raise_error
+    end
+
+    it "can find products in the 'Nike' brand" do
+      expect(Spree::Product.brand_any("Nike")).to include(product)
+    end
+    it "sorts products without brand specified" do
+      product.set_property("brand", "Nike")
+      create(:product).set_property("brand", nil)
+      expect { Spree::Core::ProductFilters.brand_filter[:labels] }.not_to raise_error
+    end
+  end
+end

data/spec/models/spree/product_option_type_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Spree::ProductOptionType do
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:product) }
+    it { is_expected.to validate_presence_of(:option_type) }
+    it { is_expected.to validate_uniqueness_of(:product_id).scoped_to(:option_type_id).allow_nil }
+  end
+end

data/spec/models/spree/product_promotion_rule_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Spree::ProductPromotionRule do
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:product) }
+    it { is_expected.to validate_presence_of(:promotion_rule) }
+    it { is_expected.to validate_uniqueness_of(:product_id).scoped_to(:promotion_rule_id).allow_nil }
+  end
+end

data/spec/models/spree/product_property_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Spree::ProductProperty, type: :model do
+  context "touching" do
+    it "should update product" do
+      pp = create(:product_property)
+      expect(pp.product).to receive(:touch)
+      pp.touch
+    end
+  end
+
+  context 'property_name=' do
+    before do
+      @pp = create(:product_property)
+    end
+
+    it "should assign property" do
+      @pp.property_name = "Size"
+      expect(@pp.property.name).to eq('Size')
+    end
+  end
+end