spree_core 3.1.14 → 3.2.0.rc1

data/spec/mailers/order_mailer_spec.rb

@@ -0,0 +1,122 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::OrderMailer, type: :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:order) do
+    order = stub_model(Spree::Order)
+    product = stub_model(Spree::Product, name: %{The "BEST" product})
+    variant = stub_model(Spree::Variant, product: product)
+    price = stub_model(Spree::Price, variant: variant, amount: 5.00)
+    line_item = stub_model(Spree::LineItem, variant: variant, order: order, quantity: 1, price: 4.99)
+    allow(variant).to receive_messages(default_price: price)
+    allow(order).to receive_messages(line_items: [line_item])
+    order
+  end
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::OrderMailer.confirm_email(order)
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  it "doesn't aggressively escape double quotes in confirmation body" do
+    confirmation_email = Spree::OrderMailer.confirm_email(order)
+    expect(confirmation_email.body).not_to include(""")
+  end
+
+  it "confirm_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      Spree::OrderMailer.confirm_email(order.id).body
+    }.not_to raise_error
+  end
+
+  it "cancel_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      cancel_email = Spree::OrderMailer.cancel_email(order.id).body
+    }.not_to raise_error
+  end
+
+  context "only shows eligible adjustments in emails" do
+    before do
+      create(:adjustment, order: order, eligible: true, label: "Eligible Adjustment")
+      create(:adjustment, order: order, eligible: false, label: "Ineligible Adjustment")
+    end
+
+    let!(:confirmation_email) { Spree::OrderMailer.confirm_email(order) }
+    let!(:cancel_email) { Spree::OrderMailer.cancel_email(order) }
+
+    specify do
+      expect(confirmation_email.body).not_to include("Ineligible Adjustment")
+    end
+
+    specify do
+      expect(cancel_email.body).not_to include("Ineligible Adjustment")
+    end
+  end
+
+  context "displays unit costs from line item" do
+    # Regression test for #2772
+
+    # Tests mailer view spree/order_mailer/confirm_email.text.erb
+    specify do
+      confirmation_email = Spree::OrderMailer.confirm_email(order)
+      expect(confirmation_email).to have_body_text("4.99")
+      expect(confirmation_email).to_not have_body_text("5.00")
+    end
+
+    # Tests mailer view spree/order_mailer/cancel_email.text.erb
+    specify do
+      cancel_email = Spree::OrderMailer.cancel_email(order)
+      expect(cancel_email).to have_body_text("4.99")
+      expect(cancel_email).to_not have_body_text("5.00")
+    end
+  end
+
+  context "emails must be translatable" do
+    context "pt-BR locale" do
+      before do
+        I18n.enforce_available_locales = false
+        pt_br_confirm_mail = { spree: { order_mailer: { confirm_email: { dear_customer: 'Caro Cliente,' } } } }
+        pt_br_cancel_mail = { spree: { order_mailer: { cancel_email: { order_summary_canceled: 'Resumo da Pedido [CANCELADA]' } } } }
+        I18n.backend.store_translations :'pt-BR', pt_br_confirm_mail
+        I18n.backend.store_translations :'pt-BR', pt_br_cancel_mail
+        I18n.locale = :'pt-BR'
+      end
+
+      after do
+        I18n.locale = I18n.default_locale
+        I18n.enforce_available_locales = true
+      end
+
+      context "confirm_email" do
+        specify do
+          confirmation_email = Spree::OrderMailer.confirm_email(order)
+          expect(confirmation_email).to have_body_text("Caro Cliente,")
+        end
+      end
+
+      context "cancel_email" do
+        specify do
+          cancel_email = Spree::OrderMailer.cancel_email(order)
+          expect(cancel_email).to have_body_text("Resumo da Pedido [CANCELADA]")
+        end
+      end
+    end
+  end
+
+  context "with preference :send_core_emails set to false" do
+    it "sends no email" do
+      Spree::Config.set(:send_core_emails, false)
+      message = Spree::OrderMailer.confirm_email(order)
+      expect(message.body).to be_blank
+    end
+  end
+end

data/spec/mailers/reimbursement_mailer_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::ReimbursementMailer, type: :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:reimbursement) { create(:reimbursement) }
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::ReimbursementMailer.reimbursement_email(reimbursement)
+      expect(message.from).to eq [Spree::Store.current.mail_from_address]
+    end
+  end
+
+  it "accepts a reimbursement id as an alternative to a Reimbursement object" do
+    expect(Spree::Reimbursement).to receive(:find).with(reimbursement.id).and_return(reimbursement)
+
+    expect {
+      Spree::ReimbursementMailer.reimbursement_email(reimbursement.id).body
+    }.not_to raise_error
+  end
+
+  context "emails must be translatable" do
+    context "reimbursement_email" do
+      context "pt-BR locale" do
+        before do
+          I18n.enforce_available_locales = false
+          pt_br_shipped_email = { spree: { reimbursement_mailer: { reimbursement_email: { dear_customer: 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+          I18n.enforce_available_locales = true
+        end
+
+        specify do
+          reimbursement_email = Spree::ReimbursementMailer.reimbursement_email(reimbursement)
+          expect(reimbursement_email.body).to include("Caro Cliente,")
+        end
+      end
+    end
+  end
+end

data/spec/mailers/shipment_mailer_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::ShipmentMailer, type: :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:order) { stub_model(Spree::Order, number: 'R12345') }
+  let(:shipping_method) { stub_model(Spree::ShippingMethod, name: 'USPS') }
+  let(:product) { stub_model(Spree::Product, name: %{The "BEST" product}, sku: 'SKU0001') }
+  let(:variant) { stub_model(Spree::Variant, product: product) }
+  let(:line_item) { stub_model(Spree::LineItem, variant: variant, order: order, quantity: 1, price: 5) }
+  let(:shipment) do
+    shipment = stub_model(Spree::Shipment)
+    allow(shipment).to receive_messages(line_items: [line_item], order: order)
+    allow(shipment).to receive_messages(tracking_url: "http://track.com/me")
+    allow(shipment).to receive_messages(shipping_method: shipping_method)
+    shipment
+  end
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::ShipmentMailer.shipped_email(shipment)
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  # Regression test for #2196
+  it "doesn't include out of stock in the email body" do
+    shipment_email = Spree::ShipmentMailer.shipped_email(shipment)
+    expect(shipment_email.body).not_to include(%Q{Out of Stock})
+  end
+
+  it "shipment_email accepts an shipment id as an alternative to an Shipment object" do
+    expect(Spree::Shipment).to receive(:find).with(shipment.id).and_return(shipment)
+    expect {
+      Spree::ShipmentMailer.shipped_email(shipment.id).body
+    }.not_to raise_error
+  end
+
+  context "emails must be translatable" do
+    context "shipped_email" do
+      context "pt-BR locale" do
+        before do
+          I18n.enforce_available_locales = false
+          pt_br_shipped_email = { spree: { shipment_mailer: { shipped_email: { dear_customer: 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+          I18n.enforce_available_locales = true
+        end
+
+        specify do
+          shipped_email = Spree::ShipmentMailer.shipped_email(shipment)
+          expect(shipped_email).to have_body_text("Caro Cliente,")
+        end
+      end
+    end
+  end
+
+  context "shipped_email" do
+    let(:shipped_email) { Spree::ShipmentMailer.shipped_email(shipment) }
+
+    specify do
+      expect(shipped_email).to have_body_text(order.number)
+    end
+
+    specify do
+      expect(shipped_email).to have_body_text(shipping_method.name)
+    end
+
+    specify do
+      expect(shipped_email).to have_body_text("href=\"#{shipment.tracking_url}\"")
+    end
+  end
+end

data/spec/mailers/test_mailer_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::TestMailer, type: :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:user) { create(:user) }
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::TestMailer.test_email('test@example.com')
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  it "confirm_email accepts a user id as an alternative to a User object" do
+    expect {
+      Spree::TestMailer.test_email('test@example.com')
+    }.not_to raise_error
+  end
+
+  context "action mailer host" do
+    it "falls back to spree store url" do
+      ActionMailer::Base.default_url_options = {}
+      Spree::TestMailer.test_email('test@example.com').deliver_now
+      expect(ActionMailer::Base.default_url_options[:host]).to eq(Spree::Store.current.url)
+    end
+
+    it "uses developer set host" do
+      ActionMailer::Base.default_url_options[:host] = 'test.test'
+      Spree::TestMailer.test_email('test@example.com').deliver_now
+      expect(ActionMailer::Base.default_url_options[:host]).to eq('test.test')
+    end
+  end
+end

data/spec/models/option_type_prototype_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Spree::OptionTypePrototype do
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:prototype) }
+    it { is_expected.to validate_presence_of(:option_type) }
+    it { is_expected.to validate_uniqueness_of(:prototype_id).scoped_to(:option_type_id).allow_nil }
+  end
+end

data/spec/models/spree/ability_spec.rb

@@ -0,0 +1,251 @@
+require 'spec_helper'
+require 'cancan/matchers'
+require 'spree/testing_support/ability_helpers'
+require 'spree/testing_support/bar_ability'
+
+# Fake ability for testing registration of additional abilities
+class FooAbility
+  include CanCan::Ability
+
+  def initialize(user)
+    # allow anyone to perform index on Order
+    can :index, Spree::Order
+    # allow anyone to update an Order with id of 1
+    can :update, Spree::Order do |order|
+      order.id == 1
+    end
+  end
+end
+
+describe Spree::Ability, type: :model do
+  let(:user) { build(:user) }
+  let(:ability) { Spree::Ability.new(user) }
+  let(:token) { nil }
+
+  after(:each) {
+    Spree::Ability.abilities = Set.new
+  }
+
+  context 'register_ability' do
+    it 'should add the ability to the list of abilties' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).abilities).not_to be_empty
+    end
+
+    it 'should apply the registered abilities permissions' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).can?(:update, mock_model(Spree::Order, id: 1))).to be true
+    end
+  end
+
+  context '#abilities_to_register' do
+    it 'adds the ability to the list of abilities' do
+      allow_any_instance_of(Spree::Ability).to receive(:abilities_to_register) { [FooAbility] }
+      expect(Spree::Ability.new(user).abilities).to include FooAbility
+    end
+
+    it 'applies the registered abilities permissions' do
+      allow_any_instance_of(Spree::Ability).to receive(:abilities_to_register) { [FooAbility] }
+      expect(Spree::Ability.new(user).can?(:update, mock_model(Spree::Order, id: 1))).to be true
+    end
+  end
+
+  context 'for general resource' do
+    let(:resource) { Object.new }
+
+    context 'with admin user' do
+      before(:each) { allow(user).to receive(:has_spree_role?).and_return(true) }
+      it_should_behave_like 'access granted'
+      it_should_behave_like 'index allowed'
+    end
+
+    context 'with customer' do
+      it_should_behave_like 'access denied'
+      it_should_behave_like 'no index allowed'
+    end
+  end
+
+  context 'for admin protected resources' do
+    let(:resource) { Object.new }
+    let(:resource_shipment) { Spree::Shipment.new }
+    let(:resource_product) { Spree::Product.new }
+    let(:resource_user) { create :user }
+    let(:resource_order) { Spree::Order.new }
+    let(:fakedispatch_user) { Spree.user_class.create }
+    let(:fakedispatch_ability) { Spree::Ability.new(fakedispatch_user) }
+
+    context 'with admin user' do
+      it 'should be able to admin' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+        expect(ability).to be_able_to :admin, resource
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).to be_able_to :show, resource_product
+        expect(ability).to be_able_to :create, resource_user
+      end
+    end
+
+    context 'with fakedispatch user' do
+      it 'should be able to admin on the order and shipment pages' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+
+        Spree::Ability.register_ability(BarAbility)
+
+        expect(ability).not_to be_able_to :admin, resource
+
+        expect(ability).to be_able_to :admin, resource_order
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).not_to be_able_to :update, resource_order
+        # ability.should_not be_able_to :create, resource_order # Fails
+
+        expect(ability).to be_able_to :admin, resource_shipment
+        expect(ability).to be_able_to :index, resource_shipment
+        expect(ability).to be_able_to :create, resource_shipment
+
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :update, resource_product
+        # ability.should_not be_able_to :show, resource_product # Fails
+
+        expect(ability).not_to be_able_to :admin, resource_user
+        expect(ability).not_to be_able_to :update, resource_user
+        expect(ability).to be_able_to :update, user
+        # ability.should_not be_able_to :create, resource_user # Fails
+        # It can create new users if is has access to the :admin, User!!
+
+        # TODO change the Ability class so only users and customers get the extra premissions?
+
+        Spree::Ability.remove_ability(BarAbility)
+      end
+    end
+
+    context 'with customer' do
+      it 'should not be able to admin' do
+        expect(ability).not_to be_able_to :admin, resource
+        expect(ability).not_to be_able_to :admin, resource_order
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :admin, resource_user
+      end
+    end
+  end
+
+  context 'as Guest User' do
+
+    context 'for Country' do
+      let(:resource) { Spree::Country.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionType' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionValue' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Order' do
+      let(:resource) { Spree::Order.new }
+
+      context 'requested by same user' do
+        before(:each) { resource.user = user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested by other user' do
+        before(:each) { resource.user = Spree.user_class.new }
+        it_should_behave_like 'create only'
+      end
+
+      context 'requested with proper token' do
+        let(:token) { 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: token }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested with inproper token' do
+        let(:token) { 'FAIL' }
+        before(:each) { allow(resource).to receive_messages guest_token: token }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Product' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for ProductProperty' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Property' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for State' do
+      let(:resource) { Spree::State.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxons' do
+      let(:resource) { Spree::Taxon.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxonomy' do
+      let(:resource) { Spree::Taxonomy.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for User' do
+      context 'requested by same user' do
+        let(:resource) { user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+      context 'requested by other user' do
+        let(:resource) { create(:user) }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Variant' do
+      let(:resource) { Spree::Variant.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Zone' do
+      let(:resource) { Spree::Zone.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+  end
+
+end