spree_core 3.1.14 → 3.2.0.rc1

data/spec/models/spree/calculator/refunds/default_refund_amount_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Spree::Calculator::Returns::DefaultRefundAmount, type: :model do
+  let(:order)           { create(:order) }
+  let(:line_item_quantity) { 2 }
+  let(:item_price)      { 100.0 }
+  let(:pre_tax_amount)  { line_item_quantity * item_price }
+  let(:line_item)       { create(:line_item, price: item_price, quantity: line_item_quantity) }
+  let(:inventory_unit) { build(:inventory_unit, order: order, line_item: line_item) }
+  let(:return_item) { build(:return_item, inventory_unit: inventory_unit ) }
+  let(:calculator) { Spree::Calculator::Returns::DefaultRefundAmount.new }
+
+  before { order.line_items << line_item }
+
+  subject { calculator.compute(return_item) }
+
+  context "not an exchange" do
+    context "no promotions or taxes" do
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+
+    context "order adjustments" do
+      let(:adjustment_amount) { -10.0 }
+
+      before do
+        order.adjustments << create(:adjustment, order: order, amount: adjustment_amount, eligible: true, label: 'Adjustment', source_type: 'Spree::Order')
+        order.adjustments.first.update_attributes(amount: adjustment_amount)
+      end
+
+      it { is_expected.to eq (pre_tax_amount - adjustment_amount.abs) / line_item_quantity }
+    end
+
+    context "shipping adjustments" do
+      let(:adjustment_total) { -50.0 }
+
+      before { order.shipments << Spree::Shipment.new(adjustment_total: adjustment_total) }
+
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+  end
+
+  context "an exchange" do
+    let(:return_item) { build(:exchange_return_item) }
+
+    it { is_expected.to eq 0.0 }
+  end
+end

data/spec/models/spree/calculator/shipping/flat_percent_item_total_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatPercentItemTotal, type: :model do
+      let(:variant1) { build(:variant, price: 10.11) }
+      let(:variant2) { build(:variant, price: 20.2222) }
+
+      let(:line_item1) { build(:line_item, variant: variant1) }
+      let(:line_item2) { build(:line_item, variant: variant2) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 2, variant2 => 1 })
+      end
+
+      subject { FlatPercentItemTotal.new(preferred_flat_percent: 10) }
+
+      it "should round result correctly" do
+        expect(subject.compute(package)).to eq(4.04)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flat_rate_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatRate, type: :model do
+      subject { Calculator::Shipping::FlatRate.new(preferred_amount: 4.00) }
+
+      it 'always returns the same rate' do
+        expect(subject.compute(build(:stock_package_fulfilled))).to eql 4.00
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flexi_rate_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlexiRate, type: :model do
+      let(:variant1) { build(:variant, price: 10) }
+      let(:variant2) { build(:variant, price: 20) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 4, variant2 => 6 })
+      end
+
+      let(:subject) { FlexiRate.new }
+
+      context "compute" do
+        it "should compute amount correctly when all fees are 0" do
+          expect(subject.compute(package).round(2)).to eq(0.0)
+        end
+
+        it "should compute amount correctly when first_item has a value" do
+          subject.preferred_first_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(1.0)
+        end
+
+        it "should compute amount correctly when additional_items has a value" do
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(9.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(14.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values AND max items has value" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          subject.preferred_max_items = 3
+          expect(subject.compute(package).round(2)).to eq(26.0)
+        end
+
+        it "should allow creation of new object with all the attributes" do
+          FlexiRate.new(preferred_first_item: 1,
+                        preferred_additional_item: 1,
+                        preferred_max_items: 1)
+        end
+      end
+    end
+  end
+end
+

data/spec/models/spree/calculator/shipping/per_item_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe PerItem, type: :model do
+      let(:variant1) { build(:variant) }
+      let(:variant2) { build(:variant) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 5, variant2 => 3 })
+      end
+
+      subject { PerItem.new(preferred_amount: 10) }
+
+      it "correctly calculates per item shipping" do
+        expect(subject.compute(package).to_f).to eq(80) # 5 x 10 + 3 x 10
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/price_sack_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe PriceSack do
+      let(:variant) { build(:variant, price: 2) }
+      subject(:calculator) do
+        calculator = PriceSack.new
+        calculator.preferred_minimal_amount = 5
+        calculator.preferred_normal_amount = 10
+        calculator.preferred_discount_amount = 1
+        calculator
+      end
+
+      let(:normal_package) do
+        build(:stock_package, variants_contents: { variant => 2 })
+      end
+
+      let(:discount_package) do
+        build(:stock_package, variants_contents: { variant => 4 })
+      end
+
+      it 'computes the correct amount' do
+        expect(calculator.compute(normal_package)).to eq(calculator.preferred_normal_amount)
+        expect(calculator.compute(discount_package)).to eq(calculator.preferred_discount_amount)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping.rb

@@ -0,0 +1,8 @@
+require_dependency 'spree/calculator'
+
+module Spree
+  class Calculator::Shipping < Calculator
+    def compute(content_items)
+    end
+  end
+end

data/spec/models/spree/calculator/tiered_flat_rate_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredFlatRate, type: :model do
+  let(:calculator) { Spree::Calculator::TieredFlatRate.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when tiers is not a hash" do
+      before { calculator.preferred_tiers = ["nope", 0] }
+      it { is_expected.to be false }
+    end
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_amount = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 10 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 15 }
+    end
+  end
+end
+

data/spec/models/spree/calculator/tiered_percent_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredPercent, type: :model do
+  let(:calculator) { Spree::Calculator::TieredPercent.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when base percent is less than zero" do
+      before { calculator.preferred_base_percent = -1 }
+      it { is_expected.to be false }
+    end
+    context "when base percent is greater than 100" do
+      before { calculator.preferred_base_percent = 110 }
+      it { is_expected.to be false }
+    end
+    context "when tiers is not a hash" do
+      before { calculator.preferred_tiers = ["nope", 0] }
+      it { is_expected.to be false }
+    end
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+      context "and one of the values is not a percent" do
+        before { calculator.preferred_tiers = { 10 => 110 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_percent = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 5 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 22 }
+    end
+  end
+end

data/spec/models/spree/calculator_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe Spree::Calculator, type: :model do
+
+  let(:order) { create(:order) }
+  let!(:line_item) { create(:line_item, order: order) }
+  let(:shipment) { create(:shipment, order: order, stock_location: create(:stock_location_with_items)) }
+
+  context "with computable" do
+    context "and compute methods stubbed out" do
+      context "with a Spree::LineItem" do
+        it "calls compute_line_item" do
+          expect(subject).to receive(:compute_line_item).with(line_item)
+          subject.compute(line_item)
+        end
+      end
+
+      context "with a Spree::Order" do
+        it "calls compute_order" do
+          expect(subject).to receive(:compute_order).with(order)
+          subject.compute(order)
+        end
+      end
+
+      context "with a Spree::Shipment" do
+        it "calls compute_shipment" do
+          expect(subject).to receive(:compute_shipment).with(shipment)
+          subject.compute(shipment)
+        end
+      end
+
+      context "with a arbitray object" do
+        it "calls the correct compute" do
+          s = "Calculator can all"
+          expect(subject).to receive(:compute_string).with(s)
+          subject.compute(s)
+        end
+      end
+    end
+
+  context "with no stubbing" do
+    context "with a Spree::LineItem" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(line_item)}.to raise_error NotImplementedError, /Please implement \'compute_line_item\(line_item\)\' in your calculator/
+        end
+      end
+
+      context "with a Spree::Order" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(order)}.to raise_error NotImplementedError, /Please implement \'compute_order\(order\)\' in your calculator/
+        end
+      end
+
+      context "with a Spree::Shipment" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(shipment)}.to raise_error NotImplementedError, /Please implement \'compute_shipment\(shipment\)\' in your calculator/
+        end
+      end
+
+      context "with a arbitray object" do
+        it "raises NotImplementedError" do
+          s = "Calculator can all"
+          expect{subject.compute(s)}.to raise_error NotImplementedError, /Please implement \'compute_string\(string\)\' in your calculator/
+        end
+      end
+    end
+  end
+
+end

data/spec/models/spree/classification_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+module Spree
+  describe Classification, type: :model do
+    # Regression test for #3494
+    it "cannot link the same taxon to the same product more than once" do
+      product = create(:product)
+      taxon = create(:taxon)
+      add_taxon = lambda { product.taxons << taxon }
+      expect(add_taxon).not_to raise_error
+      expect(add_taxon).to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    let(:taxon_with_5_products) do
+      products = []
+      5.times do
+        products << create(:base_product)
+      end
+
+      create(:taxon, products: products)
+    end
+
+    def positions_to_be_valid(taxon)
+      positions = taxon.reload.classifications.map(&:position)
+      expect(positions).to eq((1..taxon.classifications.count).to_a)
+    end
+
+    it "has a valid fixtures" do
+      expect positions_to_be_valid(taxon_with_5_products)
+      expect(Spree::Classification.count).to eq 5
+    end
+
+    context "removing product from taxon" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        expect(p.classifications.first.position).to eq(2)
+        taxon_with_5_products.products.destroy(p)
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing taxon's products" do
+      before :each do
+        products = taxon_with_5_products.products.to_a
+        products.pop(1)
+        taxon_with_5_products.products = products
+        taxon_with_5_products.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "removing taxon from product" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons.destroy(taxon_with_5_products)
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing product's taxons" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons = []
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "destroying classification" do
+      before :each do
+        classification = taxon_with_5_products.classifications[1]
+        classification.destroy
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/display_money_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+module Spree
+
+  describe DisplayMoney do
+    let(:test_class) do
+      Class.new do
+        extend DisplayMoney
+        def total; 10.0; end
+      end
+    end
+
+    describe ".money_methods" do
+      before { test_class.money_methods :total }
+
+      context "currency is not defined" do
+        it "generates a display_method that builds a Spree::Money without options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+        end
+      end
+
+      context "currency is defined" do
+        before { test_class.class_eval { def currency; "USD"; end } }
+
+        it "generates a display_* method that builds a Spree::Money with currency" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0, currency: "USD")
+        end
+      end
+
+      context "with multiple + options" do
+        before do
+          test_class.class_eval { def amount; 20.0; end }
+          test_class.money_methods :total, amount: { no_cents: true }
+        end
+
+        it "generates a display_* method that builds a Spree::Money with the specified options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+          expect(test_class.new.display_amount).to eq Spree::Money.new(20.0, no_cents: true)
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/user_methods_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe Spree::UserMethods do
+  let(:test_user) { create :user }
+
+  describe 'Associations' do
+    subject { test_user }
+
+    it 'should have many promotion_rule_users' do
+      is_expected.to have_many(:promotion_rule_users).with_foreign_key(:user_id).
+        class_name('Spree::PromotionRuleUser').dependent(:destroy)
+    end
+
+    it 'should have many role_users' do
+      is_expected.to have_many(:role_users).class_name('Spree::RoleUser').
+        with_foreign_key(:user_id).dependent(:destroy)
+    end
+  end
+
+  describe '#has_spree_role?' do
+    subject { test_user.has_spree_role? name }
+
+    let(:role) { Spree::Role.create(name: name) }
+    let(:name) { 'test' }
+
+    context 'with a role' do
+      before { test_user.spree_roles << role }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'without a role' do
+      it { is_expected.to be_falsy }
+    end
+  end
+
+  describe '#last_incomplete_spree_order' do
+    subject { test_user.last_incomplete_spree_order }
+
+    context 'with an incomplete order' do
+      let(:last_incomplete_order) { create :order, user: test_user }
+
+      before do
+        create(:order, user: test_user, created_at: 1.day.ago)
+        create(:order, user: create(:user))
+        last_incomplete_order
+      end
+
+      it { is_expected.to eq last_incomplete_order }
+    end
+
+    context 'without an incomplete order' do
+      it { is_expected.to be_nil }
+    end
+  end
+
+  context '#check_completed_orders' do
+    let(:possible_promotion) { create(:promotion, advertise: true, starts_at: 1.day.ago) }
+    context 'rstrict t delete dependent destroyed' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, completed_at: Time.current)
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect { test_user.destroy }.to raise_error(Spree::Core::DestroyWithOrdersError)
+        expect(test_user.promotion_rule_users.any?).to be(true)
+      end
+    end
+
+    context 'allow to destroy dependent destroy' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, created_at: 1.day.ago)
+        test_user.destroy
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect(test_user.promotion_rule_users.any?).to be(false)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/vat_price_calculation_spec.rb

@@ -0,0 +1,66 @@
+require "spec_helper"
+
+module Spree
+  describe VatPriceCalculation do
+    let(:test_class) do
+      Class.new do
+        include VatPriceCalculation
+        def total; 10.0; end
+      end
+    end
+
+    describe "#gross_amount" do
+      let(:zone) { Zone.new }
+      let(:tax_category) { TaxCategory.new }
+      let(:price_options) do
+        {
+          tax_zone: zone,
+          tax_category: tax_category
+        }
+      end
+      let(:amount) { 100 }
+
+      subject(:gross_amount) { test_class.new.gross_amount(amount, price_options) }
+
+      context "with no default zone set" do
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with no zone given" do
+        let(:zone) { nil }
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with a default zone set" do
+        let(:default_zone) { Spree::Zone.new }
+        before do
+          allow(Spree::Zone).to receive(:default_tax).and_return(default_zone)
+        end
+
+        context "and zone equal to the default zone" do
+          let(:zone) { default_zone }
+
+          it "does not call 'TaxRate.included_tax_amount_for'" do
+            expect(TaxRate).not_to receive(:included_tax_amount_for)
+            gross_amount
+          end
+        end
+
+        context "and zone not equal to default zone" do
+          let(:zone) { Spree::Zone.new }
+
+          it "calls TaxRate.included_tax_amount_for two times" do
+            expect(TaxRate).to receive(:included_tax_amount_for).twice
+            gross_amount
+          end
+        end
+      end
+    end
+  end
+end