spree_core 3.1.14 → 3.2.0.rc1

data/spec/models/spree/order/tax_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, type: :model do
+    let(:order) { stub_model(Spree::Order) }
+
+    context "#tax_zone" do
+      let(:bill_address) { create :address }
+      let(:ship_address) { create :address }
+      let(:order) { Spree::Order.create(ship_address: ship_address, bill_address: bill_address) }
+      let(:zone) { create :zone }
+
+      context "when no zones exist" do
+        it "should return nil" do
+          expect(order.tax_zone).to be_nil
+        end
+      end
+
+      context "when tax_using_ship_address: true" do
+        before { Spree::Config.set(tax_using_ship_address: true) }
+
+        it "should calculate using ship_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(ship_address)
+          expect(Spree::Zone).not_to receive(:match).with(bill_address)
+          order.tax_zone
+        end
+      end
+
+      context "when tax_using_ship_address: false" do
+        before { Spree::Config.set(tax_using_ship_address: false) }
+
+        it "should calculate using bill_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(bill_address)
+          expect(Spree::Zone).not_to receive(:match).with(ship_address)
+          order.tax_zone
+        end
+      end
+
+      context "when there is a default tax zone" do
+        before do
+          @default_zone = create(:zone, name: "foo_zone")
+          allow(Spree::Zone).to receive_messages default_tax: @default_zone
+        end
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(match: zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(match: nil) }
+
+          it "should return the default tax zone" do
+            expect(order.tax_zone).to eq(@default_zone)
+          end
+        end
+      end
+
+      context "when no default tax zone" do
+        before { allow(Spree::Zone).to receive_messages default_tax: nil }
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(match: zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(match: nil) }
+
+          it "should return nil" do
+            expect(order.tax_zone).to be_nil
+          end
+        end
+      end
+    end
+
+  end
+end

data/spec/models/spree/order/totals_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module Spree
+  describe Order, type: :model do
+    let(:order) { Order.create }
+    let(:shirt) { create(:variant) }
+
+    context "adds item to cart and activates promo" do
+      let(:promotion) { Promotion.create name: 'Huhu' }
+      let(:calculator) { Calculator::FlatPercentItemTotal.new(preferred_flat_percent: 10) }
+      let!(:action) { Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+      before { order.contents.add(shirt, 1) }
+
+      context "item quantity changes" do
+        it "recalculates order adjustments" do
+          expect {
+            order.contents.add(shirt, 3)
+          }.to change { order.adjustments.eligible.pluck(:amount) }
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/order/updating_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Order, type: :model do
+  let(:order) { create(:order) }
+
+  context "#update_with_updater!" do
+    let(:line_items) { [mock_model(Spree::LineItem, amount: 5) ]}
+
+    context "when there are update hooks" do
+      before { Spree::Order.register_update_hook :foo }
+      after { Spree::Order.update_hooks.clear }
+      it "should call each of the update hooks" do
+        expect(order).to receive :foo
+        order.update_with_updater!
+      end
+    end
+  end
+end

data/spec/models/spree/order/validations_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, type: :model do
+    context "validations" do
+      # Regression test for #2214
+      it "does not return two error messages when email is blank" do
+        order = Spree::Order.new
+        allow(order).to receive_messages(require_email: true)
+        order.valid?
+        expect(order.errors[:email]).to eq(["can't be blank"])
+      end
+    end
+  end
+end

data/spec/models/spree/order_contents_spec.rb

@@ -0,0 +1,297 @@
+require 'spec_helper'
+
+describe Spree::OrderContents, type: :model do
+  let(:order) { Spree::Order.create }
+  let(:variant) { create(:variant) }
+
+  subject { described_class.new(order) }
+
+  context "#add" do
+    context 'given quantity is not explicitly provided' do
+      it 'should add one line item' do
+        line_item = subject.add(variant)
+        expect(line_item.quantity).to eq(1)
+        expect(order.line_items.size).to eq(1)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.add(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.add(variant)
+      end
+    end
+
+    it 'should add line item if one does not exist' do
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(1)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it 'should update line item if one exists' do
+      subject.add(variant, 1)
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(2)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant, 1)
+
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+
+    context "running promotions" do
+      let(:promotion) { create(:promotion) }
+      let(:calculator) { Spree::Calculator::FlatRate.new(preferred_amount: 10) }
+
+      shared_context "discount changes order total" do
+        before { subject.add(variant, 1) }
+        it { expect(subject.order.total).not_to eq variant.price }
+      end
+
+      context "one active order promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+
+      context "one active line item promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.line_item_adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+
+      context "VAT for variant with percent promotion" do
+        let!(:category) { Spree::TaxCategory.create name: "Taxable Foo" }
+        let!(:rate) do
+          Spree::TaxRate.create(
+            amount: 0.25,
+            included_in_price: true,
+            calculator: Spree::Calculator::DefaultTax.create,
+            tax_category: category,
+            zone: create(:zone_with_country, default_tax: true)
+          )
+        end
+        let(:variant) { create(:variant, price: 1000) }
+        let(:calculator) { Spree::Calculator::PercentOnLineItem.new(preferred_percent: 50) }
+        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
+
+        it "should update included_tax_total" do
+          expect(order.included_tax_total.to_f).to eq(0.00)
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(100)
+        end
+
+        it "should update included_tax_total after adding two line items" do
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(100)
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(200)
+        end
+      end
+    end
+  end
+
+  context "#remove" do
+    context "given an invalid variant" do
+      it "raises an exception" do
+        expect {
+          subject.remove(variant, 1)
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    context 'given quantity is not explicitly provided' do
+      it 'should remove one line item' do
+        line_item = subject.add(variant, 3)
+        subject.remove(variant)
+
+        expect(line_item.quantity).to eq(2)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        line_item = subject.add(variant, 1)
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.remove(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        line_item = subject.add(variant, 1)
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.remove(variant)
+      end
+    end
+
+    it 'should reduce line_item quantity if quantity is less the line_item quantity' do
+      line_item = subject.add(variant, 3)
+      subject.remove(variant, 1)
+
+      expect(line_item.quantity).to eq(2)
+    end
+
+    it 'should remove line_item if quantity matches line_item quantity' do
+      subject.add(variant, 1)
+      removed_line_item = subject.remove(variant, 1)
+
+      # Should reflect the change already in Order#line_item
+      expect(order.line_items).to_not include(removed_line_item)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant,2)
+
+      expect(order.item_total.to_f).to eq(39.98)
+      expect(order.total.to_f).to eq(39.98)
+
+      subject.remove(variant,1)
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+  end
+
+  context "#remove_line_item" do
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        line_item = subject.add(variant, 1)
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.remove_line_item(line_item, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        line_item = subject.add(variant, 1)
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.remove_line_item(line_item)
+      end
+    end
+
+    it 'should remove line_item' do
+      line_item = subject.add(variant, 1)
+      subject.remove_line_item(line_item)
+
+      expect(order.reload.line_items).to_not include(line_item)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      line_item = subject.add(variant,2)
+
+      expect(order.item_total.to_f).to eq(39.98)
+      expect(order.total.to_f).to eq(39.98)
+
+      subject.remove_line_item(line_item)
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+    end
+  end
+
+  context "update cart" do
+    let!(:shirt) { subject.add variant, 1 }
+
+    let(:params) do
+      { line_items_attributes: {
+        "0" => { id: shirt.id, quantity: 3 }
+      } }
+    end
+
+    it "changes item quantity" do
+      subject.update_cart params
+      expect(shirt.quantity).to eq 3
+    end
+
+    it "updates order totals" do
+      expect {
+        subject.update_cart params
+      }.to change { subject.order.total }
+    end
+
+    context "submits item quantity 0" do
+      let(:params) do
+        { line_items_attributes: {
+          "0" => { id: shirt.id, quantity: 0 },
+          "1" => { id: "666", quantity: 0}
+        } }
+      end
+
+      it "removes item from order" do
+        expect {
+          subject.update_cart params
+        }.to change { subject.order.line_items.count }
+      end
+
+      it "doesnt try to update unexistent items" do
+        filtered_params = { line_items_attributes: {
+          "0" => { id: shirt.id, quantity: 0 },
+        } }
+        expect(subject.order).to receive(:update_attributes).with(filtered_params)
+        subject.update_cart params
+      end
+
+      it "should not filter if there is only one line item" do
+        single_line_item_params = { line_items_attributes: { id: shirt.id, quantity: 0 } }
+        expect(subject.order).to receive(:update_attributes).with(single_line_item_params)
+        subject.update_cart single_line_item_params
+      end
+
+    end
+
+    it "ensures updated shipments" do
+      expect(subject.order).to receive(:ensure_updated_shipments)
+      subject.update_cart params
+    end
+  end
+
+  context "completed order" do
+    let(:order) { create(:order, state: 'complete', completed_at: Time.current) }
+
+    before { order.shipments.create! stock_location_id: variant.stock_location_ids.first }
+
+    it "updates order payment state" do
+      expect {
+        subject.add variant
+      }.to change { order.payment_state }
+
+      expect {
+        subject.remove variant
+      }.to change { order.payment_state }
+    end
+  end
+end

data/spec/models/spree/order_inventory_spec.rb

@@ -0,0 +1,239 @@
+require 'spec_helper'
+
+describe Spree::OrderInventory, type: :model do
+  let(:order) { create :completed_order_with_totals }
+  let(:line_item) { order.line_items.first }
+
+  subject { described_class.new(order, line_item) }
+
+  describe 'delegate' do
+    it { is_expected.to delegate_method(:inventory_units).to(:line_item) }
+  end
+
+  context "when order is missing inventory units" do
+    before { line_item.update_column(:quantity, 2) }
+
+    it 'creates the proper number of inventory units' do
+      subject.verify
+      expect(subject.inventory_units.count).to eq 2
+    end
+  end
+
+  context "#add_to_shipment" do
+    let(:shipment) { order.shipments.first }
+
+    context "order is not completed" do
+      before { allow(order).to receive_messages completed?: false }
+
+      it "doesn't unstock items" do
+        expect(shipment.stock_location).not_to receive(:unstock)
+        expect(subject.send(:add_to_shipment, shipment, 5)).to eq(5)
+      end
+    end
+
+    context "inventory units state" do
+      before { shipment.inventory_units.destroy_all }
+
+      it 'sets inventory_units state as per stock location availability' do
+        expect(shipment.stock_location).to receive(:fill_status).with(subject.variant, 5).and_return([3, 2])
+
+        expect(subject.send(:add_to_shipment, shipment, 5)).to eq(5)
+
+        units = shipment.inventory_units_for(subject.variant).group_by(&:state)
+        expect(units['backordered'].size).to eq(2)
+        expect(units['on_hand'].size).to eq(3)
+      end
+    end
+
+    context "store doesnt track inventory" do
+      let(:variant) { create(:variant) }
+
+      before { Spree::Config.track_inventory_levels = false }
+
+      it "creates only on hand inventory units" do
+        variant.stock_items.destroy_all
+
+        # The before_save callback in LineItem would verify inventory
+        line_item = order.contents.add variant, 1, shipment: shipment
+
+        units = shipment.inventory_units_for(line_item.variant)
+        expect(units.count).to eq 1
+        expect(units.first).to be_on_hand
+      end
+    end
+
+    context "variant doesnt track inventory" do
+      let(:variant) { create(:variant) }
+      before { variant.track_inventory = false }
+
+      it "creates only on hand inventory units" do
+        variant.stock_items.destroy_all
+
+        line_item = order.contents.add variant, 1
+        subject.verify(shipment)
+
+        units = shipment.inventory_units_for(line_item.variant)
+        expect(units.count).to eq 1
+        expect(units.first).to be_on_hand
+      end
+    end
+
+    it 'should create stock_movement' do
+      expect(subject.send(:add_to_shipment, shipment, 5)).to eq(5)
+
+      stock_item = shipment.stock_location.stock_item(subject.variant)
+      movement = stock_item.stock_movements.last
+      # movement.originator.should == shipment
+      expect(movement.quantity).to eq(-5)
+    end
+  end
+
+  context "#determine_target_shipment" do
+    let(:stock_location) { create :stock_location }
+    let(:variant) { line_item.variant }
+
+    before do
+      allow(line_item).to receive(:changed?).and_return(:true)
+      subject.verify
+
+      order.shipments.create(stock_location_id: stock_location.id, cost: 5)
+
+      shipped = order.shipments.create(stock_location_id: order.shipments.first.stock_location.id, cost: 10)
+      shipped.update_column(:state, 'shipped')
+    end
+
+    it 'should select first non-shipped shipment that already contains given variant' do
+      shipment = subject.send(:determine_target_shipment)
+      expect(shipment.shipped?).to be false
+      expect(shipment.inventory_units_for(variant)).not_to be_empty
+
+      expect(variant.stock_location_ids.include?(shipment.stock_location_id)).to be true
+    end
+
+    context "when no shipments already contain this varint" do
+      before do
+        subject.line_item.reload
+        subject.inventory_units.destroy_all
+      end
+
+      it 'selects first non-shipped shipment that leaves from same stock_location' do
+        shipment = subject.send(:determine_target_shipment)
+        shipment.reload
+        expect(shipment.shipped?).to be false
+        expect(shipment.inventory_units_for(variant)).to be_empty
+        expect(variant.stock_location_ids.include?(shipment.stock_location_id)).to be true
+      end
+    end
+  end
+
+  context 'when order has too many inventory units' do
+    before do
+      line_item.quantity = 3
+      line_item.save!
+
+      line_item.update_column(:quantity, 2)
+      subject.line_item.reload
+    end
+
+    it 'should be a messed up order' do
+      expect(order.shipments.first.inventory_units_for(line_item.variant).size).to eq(3)
+      expect(line_item.quantity).to eq(2)
+    end
+
+    it 'should decrease the number of inventory units' do
+      subject.verify
+      expect(subject.inventory_units.count).to eq 2
+    end
+
+    context '#remove_from_shipment' do
+      let(:shipment) { order.shipments.first }
+      let(:variant) { subject.variant }
+
+      context "order is not completed" do
+        before { allow(order).to receive_messages completed?: false }
+
+        it "doesn't restock items" do
+          expect(shipment.stock_location).not_to receive(:restock)
+          expect(subject.send(:remove_from_shipment, shipment, 1)).to eq(1)
+        end
+      end
+
+      it 'should create stock_movement' do
+        expect(subject.send(:remove_from_shipment, shipment, 1)).to eq(1)
+
+        stock_item = shipment.stock_location.stock_item(variant)
+        movement = stock_item.stock_movements.last
+        # movement.originator.should == shipment
+        expect(movement.quantity).to eq(1)
+      end
+
+      it 'should destroy backordered units first' do
+        allow(shipment).to receive_messages(
+          inventory_units_for_item: [
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'backordered', shipped?: false),
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'on_hand', shipped?: false),
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'backordered', shipped?: false)
+          ]
+        )
+
+        expect(shipment.inventory_units_for_item[0]).to receive(:destroy)
+        expect(shipment.inventory_units_for_item[1]).not_to receive(:destroy)
+        expect(shipment.inventory_units_for_item[2]).to receive(:destroy)
+
+        expect(subject.send(:remove_from_shipment, shipment, 2)).to eq(2)
+      end
+
+      it 'should destroy unshipped units first' do
+        allow(shipment).to receive_messages(
+          inventory_units_for_item: [
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'shipped', shipped?: true),
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'on_hand', shipped?: false)
+          ]
+        )
+
+        expect(shipment.inventory_units_for_item[0]).not_to receive(:destroy)
+        expect(shipment.inventory_units_for_item[1]).to receive(:destroy)
+
+        expect(subject.send(:remove_from_shipment, shipment, 1)).to eq(1)
+      end
+
+      it 'only attempts to destroy as many units as are eligible, and return amount destroyed' do
+        allow(shipment).to receive_messages(
+          inventory_units_for_item: [
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'shipped', shipped?: true),
+            mock_model(Spree::InventoryUnit, variant_id: variant.id, state: 'on_hand', shipped?: false)
+          ]
+        )
+
+        expect(shipment.inventory_units_for_item[0]).not_to receive(:destroy)
+        expect(shipment.inventory_units_for_item[1]).to receive(:destroy)
+
+        expect(subject.send(:remove_from_shipment, shipment, 1)).to eq(1)
+      end
+
+      it 'should destroy self if not inventory units remain' do
+        allow(shipment.inventory_units).to receive_messages(count: 0)
+        expect(shipment).to receive(:destroy)
+
+        expect(subject.send(:remove_from_shipment, shipment, 1)).to eq(1)
+      end
+
+      context "inventory unit line item and variant points to different products" do
+        let(:different_line_item) { create(:line_item) }
+
+        let!(:different_inventory) do
+          shipment.set_up_inventory("on_hand", variant, order, different_line_item)
+        end
+
+        context "completed order" do
+          before { order.touch :completed_at }
+
+          it "removes only units that match both line item and variant" do
+            subject.send(:remove_from_shipment, shipment, shipment.inventory_units.count)
+            expect(different_inventory.reload).to be_persisted
+          end
+        end
+      end
+    end
+  end
+end