spree_core 3.0.5 → 3.0.6

data/spec/models/spree/asset_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Spree::Asset, :type => :model do
+  describe "#viewable" do
+    it "touches association" do
+      product = create(:custom_product)
+      asset = Spree::Asset.create! { |a| a.viewable = product.master }
+
+      expect do
+        asset.touch
+      end.to change { product.reload.updated_at }
+    end
+  end
+
+  describe "#acts_as_list scope" do
+    it "should start from first position for different viewables" do
+      asset1 = Spree::Asset.create(viewable_type: 'Spree::Image', viewable_id: 1)
+      asset2 = Spree::Asset.create(viewable_type: 'Spree::LineItem', viewable_id: 1)
+
+      expect(asset1.position).to eq 1
+      expect(asset2.position).to eq 1
+    end
+  end
+
+end

data/spec/models/spree/calculator/default_tax_spec.rb

@@ -0,0 +1,127 @@
+require 'spec_helper'
+
+describe Spree::Calculator::DefaultTax, :type => :model do
+  let!(:country) { create(:country) }
+  let!(:zone) { create(:zone, :name => "Country Zone", :default_tax => true, :zone_members => []) }
+  let!(:tax_category) { create(:tax_category, :tax_rates => []) }
+  let!(:rate) { create(:tax_rate, :tax_category => tax_category, :amount => 0.05, :included_in_price => included_in_price) }
+  let(:included_in_price) { false }
+  let!(:calculator) { Spree::Calculator::DefaultTax.new(:calculable => rate ) }
+  let!(:order) { create(:order) }
+  let!(:line_item) { create(:line_item, :price => 10, :quantity => 3, :tax_category => tax_category) }
+  let!(:shipment) { create(:shipment, :cost => 15) }
+
+  context "#compute" do
+    context "when given an order" do
+      let!(:line_item_1) { line_item }
+      let!(:line_item_2) { create(:line_item, :price => 10, :quantity => 3, :tax_category => tax_category) }
+
+      before do
+        allow(order).to receive_messages :line_items => [line_item_1, line_item_2]
+      end
+
+      context "when no line items match the tax category" do
+        before do
+          line_item_1.tax_category = nil
+          line_item_2.tax_category = nil
+        end
+
+        it "should be 0" do
+          expect(calculator.compute(order)).to eq(0)
+        end
+      end
+
+      context "when one item matches the tax category" do
+        before do
+          line_item_1.tax_category = tax_category
+          line_item_2.tax_category = nil
+        end
+
+        it "should be equal to the item total * rate" do
+          expect(calculator.compute(order)).to eq(1.5)
+        end
+
+        context "correctly rounds to within two decimal places" do
+          before do
+            line_item_1.price = 10.333
+            line_item_1.quantity = 1
+          end
+
+          specify do
+            # Amount is 0.51665, which will be rounded to...
+            expect(calculator.compute(order)).to eq(0.52)
+          end
+
+        end
+      end
+
+      context "when more than one item matches the tax category" do
+        it "should be equal to the sum of the item totals * rate" do
+          expect(calculator.compute(order)).to eq(3)
+        end
+      end
+
+      context "when tax is included in price" do
+        let(:included_in_price) { true }
+
+        it "will return the deducted amount from the totals" do
+          # total price including 5% tax = $60
+          # ex pre-tax = $57.14
+          # 57.14 + %5 = 59.997 (or "close enough" to $60)
+          # 60 - 57.14 = $2.86
+          expect(calculator.compute(order).to_f).to eql 2.86
+        end
+      end
+    end
+
+    context "when tax is included in price" do
+      let(:included_in_price) { true }
+      context "when the variant matches the tax category" do
+
+        context "when line item is discounted" do
+          before do
+            line_item.promo_total = -1
+            Spree::TaxRate.store_pre_tax_amount(line_item, [rate])
+          end
+
+          it "should be equal to the item's discounted total * rate" do
+            expect(calculator.compute(line_item)).to eql 1.38
+          end
+        end
+
+        it "should be equal to the item's full price * rate" do
+          Spree::TaxRate.store_pre_tax_amount(line_item, [rate])
+          expect(calculator.compute(line_item)).to eql 1.43
+        end
+      end
+    end
+
+    context "when tax is not included in price" do
+      context "when the line item is discounted" do
+        before { line_item.promo_total = -1 }
+
+        it "should be equal to the item's pre-tax total * rate" do
+          expect(calculator.compute(line_item)).to eq(1.45)
+        end
+      end
+
+      context "when the variant matches the tax category" do
+        it "should be equal to the item pre-tax total * rate" do
+          expect(calculator.compute(line_item)).to eq(1.50)
+        end
+      end
+    end
+
+    context "when given a shipment" do
+      it "should be 5% of 15" do
+        expect(calculator.compute(shipment)).to eq(0.75)
+      end
+
+      it "takes discounts into consideration" do
+        shipment.promo_total = -1
+        # 5% of 14
+        expect(calculator.compute(shipment)).to eq(0.7)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/flat_percent_item_total_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlatPercentItemTotal, :type => :model do
+  let(:calculator) { Spree::Calculator::FlatPercentItemTotal.new }
+  let(:line_item) { mock_model Spree::LineItem }
+
+  before { allow(calculator).to receive_messages preferred_flat_percent: 10 }
+
+  context "compute" do
+    it "should round result correctly" do
+      allow(line_item).to receive_messages amount: 31.08
+      expect(calculator.compute(line_item)).to eq 3.11
+
+      allow(line_item).to receive_messages amount: 31.00
+      expect(calculator.compute(line_item)).to eq 3.10
+    end
+
+    it 'returns object.amount if computed amount is greater' do
+      allow(calculator).to receive_messages preferred_flat_percent: 110
+      allow(line_item).to receive_messages amount: 30.00
+
+      expect(calculator.compute(line_item)).to eq 30.0
+    end
+  end
+end

data/spec/models/spree/calculator/flat_rate_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlatRate, type: :model do
+  let(:calculator) { Spree::Calculator::FlatRate.new }
+
+  let(:order) do
+    mock_model(
+      Spree::Order, quantity: 10, currency: "USD"
+    )
+  end
+
+  context "compute" do
+    it "should compute the amount as the rate when currency matches the order's currency" do
+      calculator.preferred_amount = 25.0
+      calculator.preferred_currency = "GBP"
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(25.0)
+    end
+
+    it "should compute the amount as 0 when currency does not match the order's currency" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "GBP"
+      allow(order).to receive_messages currency: "USD"
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute the amount as 0 when currency is blank" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = ""
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute the amount as the rate when the currencies use different casing" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "gBp"
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(100.0)
+    end
+
+    it "should compute the amount as 0 when there is no object" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "GBP"
+      expect(calculator.compute.round(2)).to eq(0.0)
+    end
+  end
+end

data/spec/models/spree/calculator/flexi_rate_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlexiRate, :type => :model do
+  let(:calculator) { Spree::Calculator::FlexiRate.new }
+
+  let(:order) do
+    mock_model(
+      Spree::Order, quantity: 10
+    )
+  end
+
+  context "compute" do
+    it "should compute amount correctly when all fees are 0" do
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute amount correctly when first_item has a value" do
+      allow(calculator).to receive_messages :preferred_first_item => 1.0
+      expect(calculator.compute(order).round(2)).to eq(1.0)
+    end
+
+    it "should compute amount correctly when additional_items has a value" do
+      allow(calculator).to receive_messages :preferred_additional_item => 1.0
+      expect(calculator.compute(order).round(2)).to eq(9.0)
+    end
+
+    it "should compute amount correctly when additional_items and first_item have values" do
+      allow(calculator).to receive_messages :preferred_first_item => 5.0, :preferred_additional_item => 1.0
+      expect(calculator.compute(order).round(2)).to eq(14.0)
+    end
+
+    it "should compute amount correctly when additional_items and first_item have values AND max items has value" do
+      allow(calculator).to receive_messages :preferred_first_item => 5.0, :preferred_additional_item => 1.0, :preferred_max_items => 3
+      expect(calculator.compute(order).round(2)).to eq(7.0)
+    end
+
+    it "should allow creation of new object with all the attributes" do
+      Spree::Calculator::FlexiRate.new(:preferred_first_item => 1, :preferred_additional_item => 1, :preferred_max_items => 1)
+    end
+  end
+end

data/spec/models/spree/calculator/percent_on_line_item_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module Spree
+  class Calculator
+    describe PercentOnLineItem, :type => :model do
+      let(:line_item) { double("LineItem", amount: 100) }
+
+      before { subject.preferred_percent = 15 }
+
+      it "computes based on item price and quantity" do
+        expect(subject.compute(line_item)).to eq 15
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/price_sack_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Spree::Calculator::PriceSack, :type => :model do
+  let(:calculator) do
+    calculator = Spree::Calculator::PriceSack.new
+    calculator.preferred_minimal_amount = 5
+    calculator.preferred_normal_amount = 10
+    calculator.preferred_discount_amount = 1
+    calculator
+  end
+
+  let(:order) { stub_model(Spree::Order) }
+  let(:shipment) { stub_model(Spree::Shipment, :amount => 10) }
+
+  # Regression test for #714 and #739
+  it "computes with an order object" do
+    calculator.compute(order)
+  end
+
+  # Regression test for #1156
+  it "computes with a shipment object" do
+    calculator.compute(shipment)
+  end
+
+  # Regression test for #2055
+  it "computes the correct amount" do
+    expect(calculator.compute(2)).to eq(calculator.preferred_normal_amount)
+    expect(calculator.compute(6)).to eq(calculator.preferred_discount_amount)
+  end
+end

data/spec/models/spree/calculator/refunds/default_refund_amount_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe Spree::Calculator::Returns::DefaultRefundAmount, :type => :model do
+  let(:order)           { create(:order) }
+  let(:line_item_quantity) { 2 }
+  let(:pre_tax_amount)  { 100.0 }
+  let(:line_item)       { create(:line_item, price: 100.0, quantity: line_item_quantity, pre_tax_amount: pre_tax_amount) }
+  let(:inventory_unit) { build(:inventory_unit, order: order, line_item: line_item) }
+  let(:return_item) { build(:return_item, inventory_unit: inventory_unit ) }
+  let(:calculator) { Spree::Calculator::Returns::DefaultRefundAmount.new }
+
+  before { order.line_items << line_item }
+
+  subject { calculator.compute(return_item) }
+
+  context "not an exchange" do
+    context "no promotions or taxes" do
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+
+    context "order adjustments" do
+      let(:adjustment_amount) { -10.0 }
+
+      before do
+        order.adjustments << create(:adjustment, order: order, amount: adjustment_amount, eligible: true, label: 'Adjustment', source_type: 'Spree::Order')
+        order.adjustments.first.update_attributes(amount: adjustment_amount)
+      end
+
+      it { is_expected.to eq (pre_tax_amount - adjustment_amount.abs) / line_item_quantity }
+    end
+
+    context "shipping adjustments" do
+      let(:adjustment_total) { -50.0 }
+
+      before { order.shipments << Spree::Shipment.new(adjustment_total: adjustment_total) }
+
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+  end
+
+  context "an exchange" do
+    let(:return_item) { build(:exchange_return_item) }
+
+    it { is_expected.to eq 0.0 }
+  end
+
+  context "pre_tax_amount is zero" do
+    let(:pre_tax_amount)  { 0.0 }
+    it { should eq 0.0 }
+  end
+end

data/spec/models/spree/calculator/shipping.rb

@@ -0,0 +1,8 @@
+require_dependency 'spree/calculator'
+
+module Spree
+  class Calculator::Shipping < Calculator
+    def compute(content_items)
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flat_percent_item_total_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatPercentItemTotal, :type => :model do
+      let(:variant1) { build(:variant, :price => 10.11) }
+      let(:variant2) { build(:variant, :price => 20.2222) }
+
+      let(:line_item1) { build(:line_item, variant: variant1) }
+      let(:line_item2) { build(:line_item, variant: variant2) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 2, variant2 => 1 })
+      end
+
+      subject { FlatPercentItemTotal.new(:preferred_flat_percent => 10) }
+
+      it "should round result correctly" do
+        expect(subject.compute(package)).to eq(4.04)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flat_rate_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatRate, :type => :model do
+      subject { Calculator::Shipping::FlatRate.new(:preferred_amount => 4.00) }
+
+      it 'always returns the same rate' do
+        expect(subject.compute(build(:stock_package_fulfilled))).to eql 4.00
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flexi_rate_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlexiRate, :type => :model do
+      let(:variant1) { build(:variant, :price => 10) }
+      let(:variant2) { build(:variant, :price => 20) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 4, variant2 => 6 })
+      end
+
+      let(:subject) { FlexiRate.new }
+
+      context "compute" do
+        it "should compute amount correctly when all fees are 0" do
+          expect(subject.compute(package).round(2)).to eq(0.0)
+        end
+
+        it "should compute amount correctly when first_item has a value" do
+          subject.preferred_first_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(1.0)
+        end
+
+        it "should compute amount correctly when additional_items has a value" do
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(9.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(14.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values AND max items has value" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          subject.preferred_max_items = 3
+          expect(subject.compute(package).round(2)).to eq(26.0)
+        end
+
+        it "should allow creation of new object with all the attributes" do
+          FlexiRate.new(:preferred_first_item => 1,
+                        :preferred_additional_item => 1,
+                        :preferred_max_items => 1)
+        end
+      end
+    end
+  end
+end
+