spree_core 3.0.5 → 3.0.6

data/spec/models/spree/order/shipments_spec.rb

@@ -0,0 +1,43 @@
+describe Spree::Order, type: :model do
+  let(:order) { create(:order_with_totals) }
+
+  context "ensure shipments will be updated" do
+    before { Spree::Shipment.create!(order: order, stock_location: create(:stock_location)) }
+
+    it "destroys current shipments" do
+      order.ensure_updated_shipments
+      expect(order.shipments).to be_empty
+    end
+
+    it "puts order back in address state" do
+      order.ensure_updated_shipments
+      expect(order.state).to eq 'address'
+    end
+
+    it "resets shipment_total" do
+      order.update_column(:shipment_total, 5)
+      order.ensure_updated_shipments
+      expect(order.shipment_total).to eq(0)
+    end
+
+    context "except when order is completed, that's OrderInventory job" do
+      it "doesn't touch anything" do
+        allow(order).to receive_messages completed?: true
+        order.update_column(:shipment_total, 5)
+        order.shipments.create!(stock_location: create(:stock_location))
+
+        expect {
+          order.ensure_updated_shipments
+        }.not_to change { order.shipment_total }
+
+        expect {
+          order.ensure_updated_shipments
+        }.not_to change { order.shipments }
+
+        expect {
+          order.ensure_updated_shipments
+        }.not_to change { order.state }
+      end
+    end
+  end
+end

data/spec/models/spree/order/state_machine_spec.rb

@@ -0,0 +1,216 @@
+require 'spec_helper'
+
+describe Spree::Order, type: :model do
+  let(:order) { Spree::Order.new }
+  before do
+    # Ensure state machine has been re-defined correctly
+    Spree::Order.define_state_machine!
+    # We don't care about this validation here
+    allow(order).to receive(:require_email)
+  end
+
+  context "#next!" do
+    context "when current state is confirm" do
+      before do
+        order.state = "confirm"
+        order.run_callbacks(:create)
+        allow(order).to receive_messages payment_required?: true
+        allow(order).to receive_messages process_payments!: true
+        allow(order).to receive :has_available_shipment
+      end
+
+      context "when payment processing succeeds" do
+        before do
+          order.payments << FactoryGirl.create(:payment, state: 'checkout', order: order)
+          allow(order).to receive_messages process_payments: true
+        end
+
+        it "should finalize order when transitioning to complete state" do
+          expect(order).to receive(:finalize!)
+          order.next!
+        end
+
+        context "when credit card processing fails" do
+          before { allow(order).to receive_messages process_payments!: false }
+
+          it "should not complete the order" do
+            order.next
+            expect(order.state).to eq("confirm")
+          end
+        end
+      end
+
+      context "when payment processing fails" do
+        before { allow(order).to receive_messages process_payments!: false }
+
+        it "cannot transition to complete" do
+          order.next
+          expect(order.state).to eq("confirm")
+        end
+      end
+    end
+
+    context "when current state is delivery" do
+      before do
+        allow(order).to receive_messages payment_required?: true
+        allow(order).to receive :apply_free_shipping_promotions
+        order.state = "delivery"
+      end
+
+      it "adjusts tax rates when transitioning to delivery" do
+        # Once for the line items
+        expect(Spree::TaxRate).to receive(:adjust).once
+        allow(order).to receive :set_shipments_cost
+        order.next!
+      end
+
+      it "adjusts tax rates twice if there are any shipments" do
+        # Once for the line items, once for the shipments
+        order.shipments.build stock_location: create(:stock_location)
+        expect(Spree::TaxRate).to receive(:adjust).twice
+        allow(order).to receive :set_shipments_cost
+        order.next!
+      end
+    end
+  end
+
+  context "#can_cancel?" do
+    %w(pending backorder ready).each do |shipment_state|
+      it "should be true if shipment_state is #{shipment_state}" do
+        allow(order).to receive_messages completed?: true
+        order.shipment_state = shipment_state
+        expect(order.can_cancel?).to be true
+      end
+    end
+
+    (Spree::Shipment.state_machine.states.keys - [:pending, :backorder, :ready]).each do |shipment_state|
+      it "should be false if shipment_state is #{shipment_state}" do
+        allow(order).to receive_messages completed?: true
+        order.shipment_state = shipment_state
+        expect(order.can_cancel?).to be false
+      end
+    end
+  end
+
+  context "#cancel" do
+    let!(:variant) { stub_model(Spree::Variant) }
+    let!(:inventory_units) { [stub_model(Spree::InventoryUnit, variant: variant),
+                              stub_model(Spree::InventoryUnit, variant: variant)] }
+    let!(:shipment) do
+      shipment = stub_model(Spree::Shipment)
+      allow(shipment).to receive_messages inventory_units: inventory_units, order: order
+      allow(order).to receive_messages shipments: [shipment]
+      shipment
+    end
+
+    before do
+      2.times do
+        create(:line_item, order: order, price: 10)
+      end
+
+      allow(order.line_items).to receive_messages find_by_variant_id: order.line_items.first
+
+      allow(order).to receive_messages completed?: true
+      allow(order).to receive_messages allow_cancel?: true
+
+      shipments = [shipment]
+      allow(order).to receive_messages shipments: shipments
+      allow(shipments).to receive_messages states: []
+      allow(shipments).to receive_messages ready: []
+      allow(shipments).to receive_messages pending: []
+      allow(shipments).to receive_messages shipped: []
+
+      allow_any_instance_of(Spree::OrderUpdater).to receive(:update_adjustment_total) { 10 }
+    end
+
+    it "should send a cancel email" do
+      # Stub methods that cause side-effects in this test
+      allow(shipment).to receive(:cancel!)
+      allow(order).to receive :has_available_shipment
+      allow(order).to receive :restock_items!
+      mail_message = double "Mail::Message"
+      order_id = nil
+      expect(Spree::OrderMailer).to receive(:cancel_email) { |*args|
+        order_id = args[0]
+        mail_message
+      }
+      expect(mail_message).to receive :deliver_later
+      order.cancel!
+      expect(order_id).to eq(order.id)
+    end
+
+    context "restocking inventory" do
+      before do
+        allow(shipment).to receive(:ensure_correct_adjustment)
+        allow(shipment).to receive(:update_order)
+        allow(Spree::OrderMailer).to receive(:cancel_email).and_return(mail_message = double)
+        allow(mail_message).to receive :deliver
+
+        allow(order).to receive :has_available_shipment
+      end
+    end
+
+    context "resets payment state" do
+      let(:payment) { create(:payment, amount: order.total) }
+
+      before do
+        # TODO: This is ugly :(
+        # Stubs methods that cause unwanted side effects in this test
+        allow(Spree::OrderMailer).to receive(:cancel_email).and_return(mail_message = double)
+        allow(mail_message).to receive :deliver_later
+        allow(order).to receive :has_available_shipment
+        allow(order).to receive :restock_items!
+        allow(shipment).to receive(:cancel!)
+        allow(payment).to receive(:cancel!)
+        allow(order).to receive_message_chain(:payments, :valid, :size).and_return(1)
+        allow(order).to receive_message_chain(:payments, :completed).and_return([payment])
+        allow(order).to receive_message_chain(:payments, :completed, :includes).and_return([payment])
+        allow(order).to receive_message_chain(:payments, :last).and_return(payment)
+      end
+
+      context "without shipped items" do
+        it "should set payment state to 'void'" do
+          expect { order.cancel! }.to change{ order.reload.payment_state }.to("void")
+        end
+      end
+
+      context "with shipped items" do
+        before do
+          allow(order).to receive_messages shipment_state: 'partial'
+          allow(order).to receive_messages outstanding_balance?: false
+          allow(order).to receive_messages payment_state: "paid"
+        end
+
+        it "should not alter the payment state" do
+          order.cancel!
+          expect(order.payment_state).to eql "paid"
+        end
+      end
+
+      context "with payments" do
+        let(:payment) { create(:payment) }
+
+        it "should automatically refund all payments" do
+          allow(order).to receive_message_chain(:payments, :valid, :size).and_return(1)
+          allow(order).to receive_message_chain(:payments, :completed).and_return([payment])
+          allow(order).to receive_message_chain(:payments, :completed, :includes).and_return([payment])
+          allow(order).to receive_message_chain(:payments, :last).and_return(payment)
+          expect(payment).to receive(:cancel!)
+          order.cancel!
+        end
+      end
+    end
+  end
+
+  # Another regression test for #729
+  context "#resume" do
+    before do
+      allow(order).to receive_messages email: "user@spreecommerce.com"
+      allow(order).to receive_messages state: "canceled"
+      allow(order).to receive_messages allow_resume?: true
+
+      # Stubs method that cause unwanted side effects in this test
+      allow(order).to receive :has_available_shipment
+    end
+  end
+end

data/spec/models/spree/order/tax_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, :type => :model do
+    let(:order) { stub_model(Spree::Order) }
+
+    context "#tax_zone" do
+      let(:bill_address) { create :address }
+      let(:ship_address) { create :address }
+      let(:order) { Spree::Order.create(:ship_address => ship_address, :bill_address => bill_address) }
+      let(:zone) { create :zone }
+
+      context "when no zones exist" do
+        it "should return nil" do
+          expect(order.tax_zone).to be_nil
+        end
+      end
+
+      context "when :tax_using_ship_address => true" do
+        before { Spree::Config.set(:tax_using_ship_address => true) }
+
+        it "should calculate using ship_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(ship_address)
+          expect(Spree::Zone).not_to receive(:match).with(bill_address)
+          order.tax_zone
+        end
+      end
+
+      context "when :tax_using_ship_address => false" do
+        before { Spree::Config.set(:tax_using_ship_address => false) }
+
+        it "should calculate using bill_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(bill_address)
+          expect(Spree::Zone).not_to receive(:match).with(ship_address)
+          order.tax_zone
+        end
+      end
+
+      context "when there is a default tax zone" do
+        before do
+          @default_zone = create(:zone, :name => "foo_zone")
+          allow(Spree::Zone).to receive_messages :default_tax => @default_zone
+        end
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => nil) }
+
+          it "should return the default tax zone" do
+            expect(order.tax_zone).to eq(@default_zone)
+          end
+        end
+      end
+
+      context "when no default tax zone" do
+        before { allow(Spree::Zone).to receive_messages :default_tax => nil }
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => nil) }
+
+          it "should return nil" do
+            expect(order.tax_zone).to be_nil
+          end
+        end
+      end
+    end
+
+  end
+end

data/spec/models/spree/order/totals_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module Spree
+  describe Order, :type => :model do
+    let(:order) { Order.create }
+    let(:shirt) { create(:variant) }
+
+    context "adds item to cart and activates promo" do
+      let(:promotion) { Promotion.create name: 'Huhu' }
+      let(:calculator) { Calculator::FlatPercentItemTotal.new(:preferred_flat_percent => 10) }
+      let!(:action) { Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+      before { order.contents.add(shirt, 1) }
+
+      context "item quantity changes" do
+        it "recalculates order adjustments" do
+          expect {
+            order.contents.add(shirt, 3)
+          }.to change { order.adjustments.eligible.pluck(:amount) }
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/order/updating_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Order, :type => :model do
+  let(:order) { create(:order) }
+
+  context "#update!" do
+    let(:line_items) { [mock_model(Spree::LineItem, :amount => 5) ]}
+
+    context "when there are update hooks" do
+      before { Spree::Order.register_update_hook :foo }
+      after { Spree::Order.update_hooks.clear }
+      it "should call each of the update hooks" do
+        expect(order).to receive :foo
+        order.update!
+      end
+    end
+  end
+end

data/spec/models/spree/order/validations_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, :type => :model do
+    context "validations" do
+      # Regression test for #2214
+      it "does not return two error messages when email is blank" do
+        order = Spree::Order.new
+        allow(order).to receive_messages(:require_email => true)
+        order.valid?
+        expect(order.errors[:email]).to eq(["can't be blank"])
+      end
+    end
+  end
+end

data/spec/models/spree/order_contents_spec.rb

@@ -0,0 +1,256 @@
+require 'spec_helper'
+
+describe Spree::OrderContents, :type => :model do
+  let(:order) { Spree::Order.create }
+  let(:variant) { create(:variant) }
+
+  subject { described_class.new(order) }
+
+  context "#add" do
+    context 'given quantity is not explicitly provided' do
+      it 'should add one line item' do
+        line_item = subject.add(variant)
+        expect(line_item.quantity).to eq(1)
+        expect(order.line_items.size).to eq(1)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.add(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.add(variant)
+      end
+    end
+
+    it 'should add line item if one does not exist' do
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(1)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it 'should update line item if one exists' do
+      subject.add(variant, 1)
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(2)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant, 1)
+
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+
+    context "running promotions" do
+      let(:promotion) { create(:promotion) }
+      let(:calculator) { Spree::Calculator::FlatRate.new(:preferred_amount => 10) }
+
+      shared_context "discount changes order total" do
+        before { subject.add(variant, 1) }
+        it { expect(subject.order.total).not_to eq variant.price }
+      end
+
+      context "one active order promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+
+      context "one active line item promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.line_item_adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+
+      context "VAT for variant with percent promotion" do
+        let!(:category) { Spree::TaxCategory.create name: "Taxable Foo" }
+        let!(:rate) do
+          Spree::TaxRate.create(
+            amount: 0.25,
+            included_in_price: true,
+            calculator: Spree::Calculator::DefaultTax.create,
+            tax_category: category,
+            zone: create(:zone_with_country, default_tax: true)
+          )
+        end
+        let(:variant) { create(:variant, price: 1000) }
+        let(:calculator) { Spree::Calculator::PercentOnLineItem.new(:preferred_percent => 50) }
+        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
+
+        it "should update included_tax_total" do
+          expect(order.included_tax_total.to_f).to eq(0.00)
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(100)
+        end
+
+        it "should update included_tax_total after adding two line items" do
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(100)
+          subject.add(variant, 1)
+          expect(order.included_tax_total.to_f).to eq(200)
+        end
+      end
+    end
+  end
+
+  context "#remove" do
+    context "given an invalid variant" do
+      it "raises an exception" do
+        expect {
+          subject.remove(variant, 1)
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    context 'given quantity is not explicitly provided' do
+      it 'should remove one line item' do
+        line_item = subject.add(variant, 3)
+        subject.remove(variant)
+
+        expect(line_item.quantity).to eq(2)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        line_item = subject.add(variant, 1)
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.remove(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        line_item = subject.add(variant, 1)
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.remove(variant)
+      end
+    end
+
+    it 'should reduce line_item quantity if quantity is less the line_item quantity' do
+      line_item = subject.add(variant, 3)
+      subject.remove(variant, 1)
+
+      expect(line_item.quantity).to eq(2)
+    end
+
+    it 'should remove line_item if quantity matches line_item quantity' do
+      subject.add(variant, 1)
+      removed_line_item = subject.remove(variant, 1)
+
+      # Should reflect the change already in Order#line_item
+      expect(order.line_items).to_not include(removed_line_item)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant,2)
+
+      expect(order.item_total.to_f).to eq(39.98)
+      expect(order.total.to_f).to eq(39.98)
+
+      subject.remove(variant,1)
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+  end
+
+  context "update cart" do
+    let!(:shirt) { subject.add variant, 1 }
+
+    let(:params) do
+      { line_items_attributes: {
+        "0" => { id: shirt.id, quantity: 3 }
+      } }
+    end
+
+    it "changes item quantity" do
+      subject.update_cart params
+      expect(shirt.quantity).to eq 3
+    end
+
+    it "updates order totals" do
+      expect {
+        subject.update_cart params
+      }.to change { subject.order.total }
+    end
+
+    context "submits item quantity 0" do
+      let(:params) do
+        { line_items_attributes: {
+          "0" => { id: shirt.id, quantity: 0 },
+          "1" => { id: "666", quantity: 0}
+        } }
+      end
+
+      it "removes item from order" do
+        expect {
+          subject.update_cart params
+        }.to change { subject.order.line_items.count }
+      end
+
+      it "doesnt try to update unexistent items" do
+        filtered_params = { line_items_attributes: {
+          "0" => { id: shirt.id, quantity: 0 },
+        } }
+        expect(subject.order).to receive(:update_attributes).with(filtered_params)
+        subject.update_cart params
+      end
+
+      it "should not filter if there is only one line item" do
+        single_line_item_params = { line_items_attributes: { id: shirt.id, quantity: 0 } }
+        expect(subject.order).to receive(:update_attributes).with(single_line_item_params)
+        subject.update_cart single_line_item_params
+      end
+
+    end
+
+    it "ensures updated shipments" do
+      expect(subject.order).to receive(:ensure_updated_shipments)
+      subject.update_cart params
+    end
+  end
+
+  context "completed order" do
+    let(:order) { create(:order, state: 'complete', completed_at: Time.now) }
+
+    before { order.shipments.create! stock_location_id: variant.stock_location_ids.first }
+
+    it "updates order payment state" do
+      expect {
+        subject.add variant
+      }.to change { order.payment_state }
+
+      expect {
+        subject.remove variant
+      }.to change { order.payment_state }
+    end
+  end
+end